| * thumper is back | 00:12 | |
| thumper | rockstar: I've got the popup-diff working perfectly | 00:12 |
|---|---|---|
| thumper | rockstar: I'd like you to take another look | 00:12 |
| rockstar | thumper, okay. I looked at your markup yesterday, and saw some issues. Have you checked it across browsers? | 00:19 |
| rockstar | I'm not sure if it's going to work across browsers. | 00:19 |
| thumper | rockstar: it works in konq | 00:19 |
| thumper | rockstar: what were the issues you saw? | 00:19 |
| rockstar | thumper, the ones I'm concerned about are IE and Opera, for the opposite reasons. Opera is standards compliant, so the nesting of tables is inconsistent enough to freak it out, and IE ignores standards and sticks its head in its butt. | 00:20 |
| thumper | rockstar: I don't have the environment set up to test ie | 00:21 |
| thumper | rockstar: we can use ec2? | 00:21 |
| rockstar | thumper, but IE issues with the overlay itself are known. | 00:22 |
| rockstar | thumper, we can, but I don't know how to do it. I have a Windows vm I used last week. | 00:22 |
| thumper | ... | 00:23 |
| * thumper thinks | 00:23 | |
| thumper | rockstar: where do I get opera from? | 00:23 |
| rockstar | thumper, there are debs for opera available. | 00:23 |
| thumper | rockstar: I think I could tweak my local settings to have a local windowd box to look | 00:24 |
| rockstar | thumper, I'd be happy to check what it looks like, but just looking at your code, it's not going to work on IE. | 00:28 |
| thumper | rockstar: I'm booting windows on another laptop | 00:29 |
| thumper | rockstar: and downloading opera | 00:29 |
| rockstar | ...for the same reason the current incarnation of the wizard widget will never work on IE. | 00:29 |
| rockstar | thumper, so I'd first suggest a if (Y.UA.IE) { return; } in the connect stuff. | 00:30 |
| thumper | rockstar: it doesn't seem to be connecting in opera either | 00:31 |
| * rockstar wonders if we updated lazr-js in the versions.cfg | 00:32 | |
| thumper | rockstar: are there examples elsewhere where we do this? | 00:33 |
| rockstar | thumper, the subscriber stuff does it. lib/canonical/launchpad/javascript/code/branchsubscription.js | 00:34 |
| thumper | ok | 00:34 |
| thumper | so... why doesn't it work? | 00:34 |
| rockstar | thumper, by the way, I'm working on a subscription widget that makes that code better, because it sucks terribly right now. | 00:35 |
| thumper | rockstar: excellent | 00:35 |
| thumper | I'd love to get this and the other branches landed asap | 00:35 |
| thumper | nothing like shaking things out like real use | 00:35 |
| thumper | :) | 00:35 |
| rockstar | thumper, so, in IE, it won't work because the overlay uses a table layout, and IE hateses innerHTML on tables. | 00:36 |
| thumper | hmm.. | 00:37 |
| thumper | the overlay is also broken in that it give everything id=shadow | 00:38 |
| thumper | v.bad | 00:38 |
| rockstar | thumper, yes, I need to fix that as well. | 00:39 |
| thumper | arse | 00:39 |
| thumper | I can't get my windows laptop to see the local launchpad on my laptop | 00:39 |
| rockstar | thumper, so once you draw the overlay, in IE you can't update it. | 00:40 |
| rockstar | thumper, you'll have to edit your apache configs to listen on the public interface. | 00:40 |
| wgrant | thumper: https://dev.launchpad.net/Running/RemoteAccess | 00:40 |
| thumper | rockstar: did that | 00:41 |
| thumper | wgrant: ta | 00:41 |
| rockstar | thumper, can you change the lazr-js popupdiff namespace to code.branchmergeproposal.popupdiff ? I'm going to send an email to our team (and eventually to the list) on the organization of namespaces. | 00:44 |
| thumper | rockstar: sure | 00:45 |
| thumper | rockstar: although | 00:45 |
| thumper | rockstar: why add the branchmergeproposal into the namespace? | 00:46 |
| thumper | rockstar: it is used on branch and bug pages | 00:46 |
| rockstar | thumper, also, Y.popupdiff = Y.namespace('code.popupupdiff') is probably unnecessary. Do you have a specific reason for it? | 00:46 |
| thumper | no | 00:47 |
| thumper | not really | 00:47 |
| rockstar | thumper, yes, but diffs hang off merge proposals. | 00:47 |
| thumper | I just copied that from other samples | 00:47 |
| rockstar | thumper, so you could do "var namespace = Y.namespace('code...')" and then use namespace as a shortcut var to the namespace. Attaching it to Y is kinda pointless. | 00:48 |
| thumper | rockstar: I don't think we use in internally | 00:49 |
| thumper | rockstar: just to get access to the methods from outside I think | 00:49 |
| rockstar | thumper, yea, you'll notice that all of us have been doing things oddly. We're learning. | 00:49 |
| thumper | :) | 00:49 |
| rockstar | thumper, yeah, but you use it to define "connect_diff_links" | 00:49 |
| thumper | oh, ok | 00:50 |
| thumper | can we just then go "Y.code.branchmergeproposal.popupdiff.connect_diff_links()" ? | 00:50 |
| rockstar | thumper, yes. | 00:50 |
| thumper | ok | 00:51 |
| rockstar | thumper, the javascript needs documentation. | 00:52 |
| thumper | :) | 00:52 |
| wgrant | bzr: ERROR: Server sent an unexpected error: ('error', "ImportError instance has no attribute 'message'") | 00:55 |
| wgrant | Local codehosting is unhappy with me. | 00:55 |
| thumper | damn | 00:57 |
| thumper | wgrant: I just used local codehosting to get some branches in | 01:09 |
| wgrant | thumper: Hm, odd. I must have broken something at some point. | 01:11 |
| rockstar | wgrant, I wonder if codehosting can't find one of the needed libraries. I suggest looking at the oopses. | 01:59 |
| === matsubara-afk is now known as matsubara | ||
| === salgado is now known as salgado-sick | ||
| leonardr | in the absence of an on-call reviewer let me restate my humble request for someone to review https://code.edge.launchpad.net/~leonardr/lazr.restful/latest-version/+merge/14791 | 13:39 |
| bac | leonardr: i can review it for you. | 14:01 |
| leonardr | bac, thanks | 14:01 |
| leonardr | i've got a sequel coming soon | 14:01 |
| === abentley changed the topic of #launchpad-reviews to: on call: abentley || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | leonardr: looks good. | 14:08 |
| leonardr | great | 14:10 |
| === henninge changed the topic of #launchpad-reviews to: on call: abentley, henninge || reviewing: -,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | Hi abentley! | 14:16 |
| abentley | henninge: Hi! | 14:16 |
| === sinzui changed the topic of #launchpad-reviews to: on call: abentley, henninge || reviewing: -,- || queue [sinzui, sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-lunch | ||
| abentley | sinzui: If you mention my nick when you request a review, I'll respond promptly. | 14:51 |
| sinzui | abentley: sorry, I was promptly pinged after I updated the topic, went into a meeting, then was pinged again | 14:51 |
| abentley | sinzui: np. | 14:52 |
| leonardr | abentley or henninge, can you add https://code.edge.launchpad.net/~leonardr/lazr.restful/active-versions/+merge/14912 to the queue? | 15:02 |
| === abentley changed the topic of #launchpad-reviews to: on call: abentley, henninge || reviewing: -,- || queue [sinzui, sinzui, leonardr] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | leonardr: queued. | 15:04 |
| abentley | sinzui: r=me on musette-and-drums | 15:04 |
| sinzui | thanks. By tomorrow there may be no open trivial bug in the registry | 15:05 |
| === leonardr is now known as leonardr-away | ||
| abentley | sinzui: On involvement-code-link-bug-482256, what would you think about mentioning the product by name in the Link? | 15:21 |
| sinzui | That would be inconsistent with the involvement menu We do not do that for the dozen other exceptions | 15:22 |
| abentley | sinzui: Dozen other exceptions to what? | 15:24 |
| sinzui | The involvement menu is about the pillar. The links are activated for and by the pillar. We have exceptions for many subordinate objects to enable or disable the links for series and package, for each facet | 15:26 |
| sinzui | We also have exceptions for project-groups because the are broken by design | 15:26 |
| abentley | sinzui: I see. r=me. | 15:27 |
| sinzui | fab | 15:28 |
| abentley | sinzui: I just thought the phrasing was a bit awkward and terminology-laden, and since we already knew what the series' product was... | 15:30 |
| === abentley changed the topic of #launchpad-reviews to: on call: abentley, henninge || reviewing: -,- || queue [sinzui, leonardr] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | abentley: I understand. The menu and the 3.0 headers may need more reconciliation to make it clear what is going on. Since few project enable official_codehosting, this oops from the menu was rarely seen. Yet the goal of the involvement menu to to encourage projects to choose official_codehosting | 15:33 |
| === abentley changed the topic of #launchpad-reviews to: on call: abentley, henninge || reviewing: sinzui,- || queue [leonardr] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === leonardr-away is now known as leonardr | ||
| === abentley changed the topic of #launchpad-reviews to: on call: abentley, henninge || reviewing: leonardr,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === abentley changed the topic of #launchpad-reviews to: on call: abentley, henninge || reviewing: -,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara-lunch is now known as matsubara | ||
| === abentley is now known as abentley-lunch | ||
| === abentley changed the topic of #launchpad-reviews to: on call: abentley || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara is now known as matsubara-afk | ||
| rockstar | thumper, did you see my review? | 21:46 |
| thumper | rockstar: yeah, I think so | 21:47 |
| rockstar | thumper, I also forgot that we had talked about disabling Opera and IE last night - other than that and the things I recommended, we should land it. | 21:47 |
| === abentley changed the topic of #launchpad-reviews to: on call: -|| reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!