=== ursula is now known as Ursinha === flacoste is now known as flacoste_afk === stub1 is now known as stub === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: bac || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === jtv is now known as jtv-afk [11:05] adeuring: Is https://code.edge.launchpad.net/~jtv/launchpad/custom-language-codes/+merge/14555 good to land? If so, can you flip the MP status please? I always feel kinda dirty doing it for someone elses reviews. [11:05] adeuring: Same for https://code.edge.launchpad.net/~sinzui/launchpad/packaging-page-bug-481351/+merge/14811, too, please. [11:06] gmb: right, I'll update the status [11:06] Thanks. === matsubara-afk is now known as matsubara [11:48] thanks for the review gmb. and good morning. === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [11:52] Morning bac. [11:52] gmb: much going on here today? [11:52] bac: Not atm. There were some small branches in the +activereviews queue; didn't take long to clear. No requests so far. [11:54] cool. i'm about to amble up the street for some pastries but will be back in a jiffy. === jtv-afk is now known as jtv [12:04] * gmb -> lunch === gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: lunch,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [13:59] hi sinzui [14:00] hi bac [14:14] bigjools: are you going to review cody's branch? [14:16] bac: I worked with him on it so I am happy with what it's doing, so if you want to finish it off that would be good! I am pretty busy at UDS [14:16] bigjools: ah, ok. you were listed on the MP so i wanted to ask first. i'll do it. [14:17] oh I was wasn't I === matsubara is now known as matsubara-lunch === flacoste_afk is now known as flacoste [14:54] leonardr: have you seen https://code.launchpad.net/~jkakar/launchpadlib/testing-support/+merge/14444 ? === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -,cody || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [14:56] flacoste, looking [14:57] hmm === salgado is now known as salgado-lunch === matsubara-lunch is now known as matsubara === danilo_ is now known as danilos [16:12] flacoste, i've commented on https://code.edge.launchpad.net/~jkakar/launchpadlib/testing-support/+merge/14444 [16:12] jml, i'd like to read your thoughts on that as well [16:14] bac: Once you're done with Cody's branch could you take a look at https://code.edge.launchpad.net/~gmb/launchpad/subscribers-timeout-bug-471974/+merge/14955 for me? === salgado-lunch is now known as salgado === henninge_ is now known as henninge [17:21] sinzui: Are you still okay to land https://code.edge.launchpad.net/~wgrant/launchpad/distroseries-source-format-selection-part1/+merge/14729? [17:23] rockstar: Can you land https://code.edge.launchpad.net/~zematynnad/lazr-js/fx_fix/+merge/14793 on behalf of Danny Tamez? [17:23] The change is fine to land in db-devel. That was not acceptable to wgrant. Given the security change, I do not know what he can do about it. He may b able to split the work into separate branches, each getting a new review [17:25] sinzui: Does he want it to get to edge sooner? [17:25] yes [17:25] sinzui: Okay, I'll leave it in his court for now. Thanks. [17:26] beuno: Hi, do you think you could land https://code.edge.launchpad.net/~jblount/lazr-js/gimme-some-docs/+merge/12272 for Josh? [17:33] allenap, please do === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [17:39] beuno: Ah, I was asking if you could do it ;) [17:39] beuno: If you're really busy, then I will, just say. [18:21] allenap, if you can, I'd be super happy [18:39] gmb: you still here? [18:47] hi bac [18:48] hi salgado [18:48] bac, can you do a review for me? https://code.edge.launchpad.net/~salgado/launchpad/bug-481375/+merge/14961 [18:48] salgado: indeed! === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: gmb || queue [salgado] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [19:29] salgado: sorry i got distracted. r=bac [19:30] bac, no worries, thanks! :) === salgado is now known as salgado-afk === matsubara is now known as matsubara-afk [21:00] sinzui, allenap: It's no use on edge unless we cherrypick it, so it is fine to land to db-devel. Please do. [21:18] wgrant: I will land it as soon as we have a working py2.5 image for ec2 [21:24] sinzui: Thanks. [21:34] sinzui: Don't worry about it. al-maisan is landing for me. [21:35] wgrant: al-maisan: okay. thanks [21:35] sinzui: you are welcome [21:35] Thanks al-maisan, sinzui. [21:37] bac, if you have time, add this to your queue: https://code.edge.launchpad.net/~leonardr/lazr.restful/double-your-enjoyment/+merge/14967 === bac changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [-] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [21:38] leonardr: sorryi didn't update the topic but i'm done for the day [21:38] bac, np [21:45] rockstar: can you approve my popup-diff branch now? [21:46] thumper, yessir. [21:47] thumper, whoa whoa whoa. Why is there a diff inline in your comment? [21:47] :) [21:47] rockstar: because I attached it to the comment [21:48] thumper, that looks scary... [21:48] rockstar: why? [21:49] thumper, it just looks weird. I'm not sure it's wrong though, but I _feel_ like it is. [21:49] * rockstar is not a UI expert, no matter how hard he tries to get beuno to teach him [21:51] thumper, the comments aren't yuidoc format (basically javadoc format) [21:52] thumper, um, land it the way it is. After this branch I'm working on now, I need to audit our javascript and make some changes anyway. [21:52] thumper, basically, we've been doing it wrong, and that's my fault. [21:52] rockstar: ok [21:53] thumper, r=me [21:53] Also, inline bmp status changing is the sexiness [22:46] mars: when you get a chance, can you review my lazr-js branch? https://code.edge.launchpad.net/~edwin-grubbs/lazr-js/activator-ie-fixes/+merge/14969 [22:53] someone review this pls: https://code.edge.launchpad.net/~mwhudson/launchpad/fix-public-image-building/+merge/14970 [23:03] mwhudson, done [23:03] jml: thank you