[11:05] <gmb> adeuring: Is https://code.edge.launchpad.net/~jtv/launchpad/custom-language-codes/+merge/14555 good to land? If so, can you flip the MP status please? I always feel kinda dirty doing it for someone elses reviews.
[11:05] <gmb> adeuring: Same for https://code.edge.launchpad.net/~sinzui/launchpad/packaging-page-bug-481351/+merge/14811, too, please.
[11:06] <adeuring> gmb: right, I'll update the status
[11:06] <gmb> Thanks.
[11:48] <bac> thanks for the review gmb.  and good morning.
[11:52] <gmb> Morning bac.
[11:52] <bac> gmb:  much going on here today?
[11:52] <gmb> bac: Not atm. There were some small branches in the +activereviews queue; didn't take long to clear. No requests so far.
[11:54] <bac> cool. i'm about to amble up the street for some pastries but will be back in a jiffy.
[12:04]  * gmb -> lunch
[13:59] <bac> hi sinzui
[14:00] <sinzui> hi bac
[14:14] <bac> bigjools: are you going to review cody's branch?
[14:16] <bigjools> bac: I worked with him on it so I am happy with what it's doing, so if you want to finish it off that would be good!  I am pretty busy at UDS
[14:16] <bac> bigjools: ah, ok.  you were listed on the MP so i wanted to ask first.  i'll do it.
[14:17] <bigjools> oh I was wasn't I
[14:54] <flacoste> leonardr: have you seen https://code.launchpad.net/~jkakar/launchpadlib/testing-support/+merge/14444 ?
[14:56] <leonardr> flacoste, looking
[14:57] <leonardr> hmm
[16:12] <leonardr> flacoste, i've commented on https://code.edge.launchpad.net/~jkakar/launchpadlib/testing-support/+merge/14444
[16:12] <leonardr> jml, i'd like to read your thoughts on that as well
[16:14] <gmb> bac: Once you're done with Cody's branch could you take a look at https://code.edge.launchpad.net/~gmb/launchpad/subscribers-timeout-bug-471974/+merge/14955 for me?
[17:21] <allenap> sinzui: Are you still okay to land https://code.edge.launchpad.net/~wgrant/launchpad/distroseries-source-format-selection-part1/+merge/14729?
[17:23] <allenap> rockstar: Can you land https://code.edge.launchpad.net/~zematynnad/lazr-js/fx_fix/+merge/14793 on behalf of Danny Tamez?
[17:23] <sinzui> The change is fine to land in db-devel. That was not acceptable to wgrant. Given the security change, I do not know what he can do about it. He may b able to split the work into separate branches, each getting a new review
[17:25] <allenap> sinzui: Does he want it to get to edge sooner?
[17:25] <sinzui> yes
[17:25] <allenap> sinzui: Okay, I'll leave it in his court for now. Thanks.
[17:26] <allenap> beuno: Hi, do you think you could land https://code.edge.launchpad.net/~jblount/lazr-js/gimme-some-docs/+merge/12272 for Josh?
[17:33] <beuno> allenap, please do
[17:39] <allenap> beuno: Ah, I was asking if you could do it ;)
[17:39] <allenap> beuno: If you're really busy, then I will, just say.
[18:21] <beuno> allenap, if you can, I'd be super happy
[18:39] <bac> gmb: you still here?
[18:47] <salgado> hi bac
[18:48] <bac> hi salgado
[18:48] <salgado> bac, can you do a review for me? https://code.edge.launchpad.net/~salgado/launchpad/bug-481375/+merge/14961
[18:48] <bac> salgado: indeed!
[19:29] <bac> salgado: sorry i got distracted.  r=bac
[19:30] <salgado> bac, no worries, thanks! :)
[21:00] <wgrant> sinzui, allenap: It's no use on edge unless we cherrypick it, so it is fine to land to db-devel. Please do.
[21:18] <sinzui> wgrant: I will land it as soon as we have a working py2.5 image for ec2
[21:24] <wgrant> sinzui: Thanks.
[21:34] <wgrant> sinzui: Don't worry about it. al-maisan is landing for me.
[21:35] <sinzui> wgrant: al-maisan: okay. thanks
[21:35] <al-maisan> sinzui: you are welcome 
[21:35] <wgrant> Thanks al-maisan, sinzui.
[21:37] <leonardr> bac, if you have time, add this to your queue: https://code.edge.launchpad.net/~leonardr/lazr.restful/double-your-enjoyment/+merge/14967
[21:38] <bac> leonardr: sorryi didn't update the topic but i'm done for the day
[21:38] <leonardr> bac, np
[21:45] <thumper> rockstar: can you approve my popup-diff branch now?
[21:46] <rockstar> thumper, yessir.
[21:47] <rockstar> thumper, whoa whoa whoa.  Why is there a diff inline in your comment?
[21:47] <thumper> :)
[21:47] <thumper> rockstar: because I attached it to the comment
[21:48] <rockstar> thumper, that looks scary...
[21:48] <thumper> rockstar: why?
[21:49] <rockstar> thumper, it just looks weird.  I'm not sure it's wrong though, but I _feel_ like it is.
[21:49]  * rockstar is not a UI expert, no matter how hard he tries to get beuno to teach him
[21:51] <rockstar> thumper, the comments aren't yuidoc format (basically javadoc format)
[21:52] <rockstar> thumper, um, land it the way it is.  After this branch I'm working on now, I need to audit our javascript and make some changes anyway.
[21:52] <rockstar> thumper, basically, we've been doing it wrong, and that's my fault.
[21:52] <thumper> rockstar: ok
[21:53] <rockstar> thumper, r=me
[21:53] <rockstar> Also, inline bmp status changing is the sexiness
[22:46] <EdwinGrubbs> mars: when you get a chance, can you review my lazr-js branch? https://code.edge.launchpad.net/~edwin-grubbs/lazr-js/activator-ie-fixes/+merge/14969
[22:53] <mwhudson> someone review this pls: https://code.edge.launchpad.net/~mwhudson/launchpad/fix-public-image-building/+merge/14970
[23:03] <jml> mwhudson, done
[23:03] <mwhudson> jml: thank you