[03:57] <stub> https://code.edge.launchpad.net/~stub/launchpad/replication/+merge/14980 for staging and dogfood rebuild goodness. Pretty trivial.
[04:15] <thumper> stub: shouldn't you be closing cursors?
[04:15] <stub> thumper: Nah- they close themselves when they drop out of scope and the script is in autocommit mode anyway
[04:16] <thumper> ok
[04:16] <thumper> done
[06:58] <thumper> trivial review: https://code.edge.launchpad.net/~thumper/launchpad/branch-visibility-fubar/+merge/14982
[07:03] <mwhudson> thumper: is not specified in the private case really appropriate?
[07:04] <mwhudson> i guess it's consistent with our approach in general
[08:14] <thumper> mwhudson: yes, it is consistent with what we have
[08:15] <mwhudson> thumper: fair enough
[08:15]  * mwhudson approves
[08:15] <thumper> mwhudson: thanks
[08:15]  * mwhudson wonders if submitting the review is going to time out
[08:15] <mwhudson> ah, not quite
[11:59] <gmb> allenap: Could you do a JS review of https://code.edge.launchpad.net/~gmb/launchpad/subscribers-timeout-bug-471974/+merge/14955 for me? bac suggested I get someone to review the JS specifically.
[12:00] <allenap> gmb: Okay.
[12:00] <gmb> allenap: I'll request a review.
[12:00] <allenap> gmb: Cool.
[12:00] <gmb> AAAAGH.
[12:01]  * gmb hates at chromium's behaviour
[12:01] <gmb> allenap: requested. It doesn't say JS, but I guess you can figure that out for yourself.
[12:32] <allenap> gmb: Why does it try to load the portlet after the ids?
[12:36] <allenap> gmb: I'm going to go to lunch now, so I'll catch up with you later :)
[13:08] <gmb> allenap: Because it... needs to load the portlet?
[13:09] <gmb> I suppose we could load the portlet first, then grab the IDs before setting up the subscribe / unsubscribe links. That might make more sense.
[14:02] <sinzui> henninge: r=me
[14:03] <henninge> sinzui: cheers
[14:10] <allenap> gmb: Ah, I meant, why after? Why not fire off the request at the same time?
[14:14] <abentley> flacoste: Can I get an RC on this for cherry-picking? :
[14:14] <abentley> flacoste: https://code.launchpad.net/~abentley/launchpad/parse-binary-2/+merge/14915
[14:18] <flacoste> abentley: approved
[14:19] <abentley> flacoste: Thanks.
[14:24] <gmb> allenap: Well, we need the IDs before we set up the portlet, or at least before we set up the subscribe / unsubscribe links.
[14:25] <gmb> allenap: So it might make more sense to load the portlet and then, when that's loaded, get the IDs before setting up the links.
[14:26] <allenap> gmb: If the IDs fail to load, and the portlet is loaded anyway, I assume the links will not be set up?
[14:27] <gmb> allenap: Correct.
[14:27] <gmb> allenap: In fact, we can use that to our advantage by only setting up the links if the IDs are present.
[14:27] <gmb> Instead of trying to set them up anyway with unpredictable results.
[14:28] <allenap> gmb: Sounds good.
[14:28] <gmb> allenap: Cool. I'll go do that now.
[14:38] <allenap> gmb: Instead of using a place-holder template into which you put some JSON, and which then you have to parse at client end to get the JSON back out, you could override LaunchpadView.render() to simply return some JSON.
[14:41] <gmb> allenap: Ooh, sweet. I'll do that, thanks.
[14:43] <allenap> gmb: The request.response mime type might need setting too, but it'll probably work without (and I never said that).
[14:44] <gmb> allenap: Hah. What to, assuming that that's what I need to do?
[14:45] <allenap> gmb: application/json I think.
[14:45] <gmb> allenap: Right, thought as much; wasn't sure about the first bit though.
[14:52] <flacoste> abentley: talk to salgado, he also has a r-c
[14:52] <flacoste> abentley: you should land it together
[14:52]  * flacoste hopes it's not too late
[14:52] <abentley> flacoste: Sorry, it's too late.
[14:54] <bac> hi allenap
[14:54] <allenap> bac: Hi there.
[14:55] <bac> allenap: what do you think of http://pastebin.ubuntu.com/321559/
[14:58] <allenap> bac: Looks good. Instead of cd'ing in and cd'ing out again, I'd run it in a sub-shell, like (cd $$subdir && bzr clean-tree ...)
[14:58] <bac> allenap: hey i'll give that a try
[14:58]  * bac lacks makefile-fu and even bash-fu
[15:02] <bac> allenap: hey that worked:  http://pastebin.ubuntu.com/321567/
[15:03] <allenap> bac: The exit $$? will only exit the sub-shell I think, but if you move it outside of the braces it should work.
[15:04] <allenap> bac: So (cd $$subdir && bzr clean-tree --ignored --force) || exit $$?;
[15:05] <allenap> bac: r=me though. And, does this get called as part of a make clean on the top-level Makefile?
[15:05] <bac> allenap: it does not
[15:05] <bac> allenap: i think cleaning sourcecode is something we should do only rarely and on-demand
[15:06] <bac> what do you think?
[15:06] <bac> i just wanted a target to make it easier without a lot of fuss
[15:06] <allenap> bac: That's fair.
[15:07] <bac> allenap: if we change our minds it's an easy fix later
[15:07] <allenap> bac: Yes. If we wire it in now, it probably annoys a lot of people who keep having to rebuild stuff.
[15:08] <bac> allenap: and normal tree updates shouldn't need a clean and rebuild.  we only experienced it this week as the 2.4->2.5 change could not trigger a rebuild
[15:08] <bac> thanks for the review and improvements
[15:08] <allenap> bac: Yep.
[15:08] <allenap> bac: While you're there, do you normally reply to the "Project License Submitted" messages?
[15:08] <allenap> bac: As in, should I leave them alone?
[15:09] <bac> please continue to point them out to me
[15:09] <bac> i do not regularly review the feedback queue
[15:09] <bac> sinzui will often reply to them whether he is CHR or not
[15:10] <allenap> bac: Okay. And I've just noticed https://wiki.canonical.com/Launchpad/PolicyandProcess/CommunityHelpRotation/LicensingIssues which I can work through.
[15:10] <allenap> bac: Thanks.
[15:10] <bac> np
[15:11] <sinzui> I do, but I only looked once last week. I had to do some project review catchup over the weekend too
[15:21] <gmb> allenap: I've updated https://code.edge.launchpad.net/~gmb/launchpad/subscribers-timeout-bug-471974/+merge/14955 with an incremental diff of the suggested changes.
[15:22] <allenap> gmb: Top banana.
[15:33] <gmb> bac: See above about the branch you reviewed yesterday.
[15:34] <bac> gmb: will do
[15:34] <gmb> Thanks
[15:35] <bac> gmb:  i'll update the MP.  thanks for adding the test.
[15:35] <gmb> bac: No worries. Working on trying to get windmill working now.
[15:36] <bac> gmb: my use of "fragility" was from frustration at not being able to figure out why the icon alignment issue was there.  your explanation that it was pre-existing is good.
[15:37] <gmb> Ah, right.
[15:37] <gmb> bac: Yeah, I can't figure that one out, either. That reminds me - I'll file a bug now.
[15:43] <leonardr> edwin, can you please review https://code.edge.launchpad.net/~leonardr/lazr.restful/double-your-enjoyment/+merge/14967 ?
[15:43] <EdwinGrubbs> leonardr: sure
[15:45] <allenap> gmb: That's a beaut. One final question: why do you need to do the .replace('bugs.', '') bit?
[15:47] <gmb> allenap: I think it's to do with the correct path to the bug. I admit, I've cribbed that from what's already there. I'll remove it, see what breaks.
[15:47] <allenap> gmb: Cool.
[15:51] <gmb> allenap: Answer: nuffink. I'll remove it.
[15:51] <allenap> gmb: Even cooler.
[15:52] <gmb> allenap, bac: Thanks.
[15:58] <gmb> bac: FTR, the windmill tests break on this machine, but not because of the changes I've made; the changes are tested before the failure happens and I'm seeing the same failure on other branches, so think it's a not-enough-CPU issue with this box.
[15:58] <gmb> I *hate* having to say "It fails, but that's okay"
[15:59] <bac> gmb: that's fine, in a despicable sort of way
[15:59] <gmb> Yeah, I feel kinda dirty.
[15:59] <gmb> I'll submit it to EC2 then take a shower.
[16:07] <allenap> EdwinGrubbs: Will you have time for a small clean-up review? https://code.edge.launchpad.net/~allenap/launchpad/remove-striped_class/+merge/14996
[16:08] <EdwinGrubbs> allenap: sure
[16:08] <allenap> EdwinGrubbs: Thanks.
[16:48] <EdwinGrubbs> leonardr: what does this do? taggedValue(LAZR_WEBSERVICE_NAME, dict(singular="contact", plural="contacts"))
[16:49] <leonardr> edwin, that sets the human-readable singular and plural name used by lazr.restful in wadl generation
[16:49] <leonardr> ordinarily it happens automatically when the class is generated
[16:49] <leonardr> but since i'm not using the class generation features, i need to do it manually
[16:56] <EdwinGrubbs> leonardr: is there a reason that ContactSet.path="contact" is singular?
[16:56] <leonardr> edwin: no, that's a mistake. i'll fix it but i probably won't be using .path anyway
[17:05] <EdwinGrubbs> leonardr: why do the ITestDataSet.get() methods take a new request parameter but the getAll() methods do not?
[17:05] <leonardr> edwin: because get() is part of the implementation of ITraverseWithGet (which i made the classes implement instead of Traversable), and getAll() is not part of any interface
[17:10] <EdwinGrubbs> leonardr: I see that TraverseWithGet has the request parameter, but ITraverseWithGet does not. Does that need to be updated in this branch?
[17:10] <leonardr> maybe...
[17:10] <leonardr> edwin: yes, i'll change that while i'm at it
[17:14] <EdwinGrubbs> leonardr: review sent
[17:44] <leonardr> edwin, here's my incremental diff. i fixed everything we talked about and added a tiny bit more tested code
[17:44] <leonardr> https://pastebin.canonical.com/24847/
[17:44] <leonardr> i also cleaned up the prose such as unfinished sentences
[17:47] <EdwinGrubbs> leonardr: looks good. r=me
[21:04] <intellectronica> EdwinGrubbs: can i ask for a small review, please?
[21:06] <EdwinGrubbs> intellectronica: of course
[21:11] <intellectronica> EdwinGrubbs: great. https://code.edge.launchpad.net/~intellectronica/launchpad/bugs-homepage-searchbox/+merge/15007
[22:09] <intellectronica> EdwinGrubbs: looks like i can get a face-to-face review from deryck here, so don't worry about it
[22:29] <EdwinGrubbs> intellectronica: is there a purpose to having a bug supervisor and security contact listed in launchpad if they are not using the launchpad bug tracker? or at least should the edit buttons be removed?
[22:33] <EdwinGrubbs> intellectronica: oops, I didn't see your last comment. nevermind.
[23:14] <sidnei> EdwinGrubbs: got time for a review?
[23:14] <EdwinGrubbs> sidnei: how big is it?
[23:15] <EdwinGrubbs> sidnei: it looks like I will have a bunch of time between meetings tomorrow at UDS, so I might be able to do it then also.
[23:16] <sidnei> EdwinGrubbs: the mp says 2100, but 70% of that is under 'examples' in lazr-js
[23:16] <sidnei> EdwinGrubbs: https://code.edge.launchpad.net/~sidnei/lazr-js/combo-service/+merge/15009
[23:19] <EdwinGrubbs> sidnei: I'll start on it now, but I probably won't finish until tomorrow.
[23:19] <sidnei> EdwinGrubbs: im more than happy with that!
[23:58] <al-maisan> Hello intellectronica, do you mind reviewing a simple and innocuous Soyuz branch? Life at the UDS :)
[23:58] <al-maisan> *live
[23:59] <intellectronica> al-maisan: there's no such thing as a simple and iccocuous soyuz branch ... but sure, where are you? :)
[23:59] <bigjools> al-maisan: he's sat next to me, shall I hit him? :)