[00:00] <al-maisan> intellectronica: it was worth a try :) we can meet on level 3, in the central area, I'll be there in a few minutes.
[00:00] <intellectronica> al-maisan: oright, will join you there shortly
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== ursula is now known as Ursinha
[04:50] <mwhudson> thumper: hey, want to review a branch!?
[04:57] <mwhudson> https://code.launchpad.net/~mwhudson/launchpad/bzr-svn-imports/+merge/15027 fwiw
=== matsubara-afk is now known as matsubara
[12:35] <henninge> noodles775: Hi! I requested a UI review of you, if that is ok! ;)
[12:56] <noodles775> henninge: np, although I was chatting with beuno and we thought that, when there's time, it'd be great to always first have a review by someone who's going through the graduation process. So if sinzui is keen to take a look first, I'll then go over it afterwards, otherwise if we don't hear back I'll do it later this afternoon.
[12:56] <noodles775> is that ok with you?
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:07] <henninge> henninge: fine by me
[13:12] <henninge> noodles775: ^ :)
[13:12]  * henninge relocates
[13:50] <allenap> noodles775: Got time for a quick one? https://code.edge.launchpad.net/~allenap/lp-dev-utils/open-project-review-in-browser/+merge/15037
[13:56] <noodles775> allenap: sure. do we have http://api.* urls?
[13:57]  * noodles775 has only seen http://lp.net/api/beta/*
[13:57] <allenap> noodles775: I think the /api/beta urls are for the benefit of the js apis (can't do cross-domain stuff). The api.* domains are old-skool I think.
[13:58] <noodles775> ok.
=== ursula is now known as Ursinha
[14:10] <noodles775> allenap: done.
[14:10] <allenap> noodles775: Thanks.
[14:23] <gmb> noodles775: Can I get a review of https://code.edge.launchpad.net/~gmb/launchpad/no-sync-from-dupes-bug-484609/+merge/15036 please?
[14:24] <noodles775> gmb: sure.
[14:24] <gmb> Ta
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: gmb || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:28] <gmb> noodles775: I've just spotted some errors circa lines 84 and 85 of the diff - references to multiple bug watches when there's only one. I'll fix it.
[14:29] <noodles775> gmb: ok, it's just comments in your doctest right? So I'll still start it now.
[14:29] <gmb> noodles775: Right.
[14:37] <noodles775> gmb: s/bug_watche/bugwatch on line 80 of diff?
[14:37] <gmb> noodles775: Yes. 
[14:39] <noodles775> gmb: also, the import of transaction on line 87 is unnecessary.
[14:40] <gmb> noodles775: Okidoke. I'll remove it.
=== sinzui changed the topic of #launchpad-reviews to: on call: noodles || reviewing: gmb || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:52] <noodles775> Hi sinzui, let me know if you can/want to do an initial ui review for henninge's branch at:
[14:52] <noodles775> https://code.launchpad.net/~henninge/launchpad/bug-422466-status-picker/+merge/15035
[14:53] <sinzui> I do
[14:53] <noodles775> sinzui: great!
[14:53] <sinzui> I'll do it now in fact
[14:56] <allenap> noodles775: I've replied to your review. Thanks for the good comments. It's not urgent that you look back at it, so this isn't meant to be a "me me", just a nod :)
[14:58] <noodles775> allenap: yep, I'll try it out in a tick. Thanks.
=== salgado_ is now known as salgado
[15:05] <gmb> noodles775: Changes made and pushed.
[15:05] <noodles775> Thanks gmb
=== salgado is now known as salgado-lunch
[15:18] <gmb> noodles775: Thanks for the review.
[15:18] <noodles775> gmb: np!
[15:21] <rockstar> noodles775, can I put a branch in your queue?
[15:22] <noodles775> rockstar: pop it in the queue, if I don't get to it before EODing, the next person will grab it :-)
[15:22] <rockstar> noodles775, well, I SHOULD be the next person, but I'm at UDS.
[15:25] <noodles775> rockstar: yep, but abel will be on tomorrow too (hopefully I'll get through sinzui's and henninge's branches quickly).
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: sinzui || queue [henninge, rockstar] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:29] <noodles775> rockstar: where is your branch? (I can't see it on activereviews...)
[15:29] <rockstar> noodles775, intellectronica just walked up.  I can have him review so you can EOD without worry.
[15:29] <rockstar> noodles775, I haven't submitted it.  I usually line up a reviewer before I submit.
[15:30] <noodles775> rockstar: ah ok. Great.
=== EdwinGrubbs_ is now known as EdwinGrubbs
[15:38] <sinzui> henninge: noodles775: I did a ui review.
[15:39] <henninge> sinzui: cheers
[15:39] <noodles775> Thanks sinzui, I'll do one too after your branch.
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: henninge || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:50] <noodles775> henninge: is your branch intentionally targeted at db-devel? (or is it just that you created it when devel was closed)
[15:50] <henninge> noodles775: It depends on yui-3final
[15:51] <noodles775> henninge: sorry, maybe I missed that... is yui-3final on db-devel but not devel?
[15:52] <henninge> noodles775: yes, mars landed it into db-devel. If all works out, it will be landed on devel, too.
[15:52]  * noodles775 is still in the process of going through email from the past week.
[15:52] <noodles775> Great, thanks henninge.
[15:52] <henninge> noodles775: I heard flacoste and mars talk about it ... ;)
[15:52] <henninge> you were in the room, too ;-P
[15:53] <intellectronica> which reminds me, what's with yui3-final? we still have a few branches that depend on it waiting to land.
[15:53] <noodles775> Yeah, but I don't hear much when coding ;). But you'll land this on devel if the yui-3final lands there right? (so that it gets more exposure before release etc.)
[15:54] <henninge> noodles775: definitely
[15:54] <henninge> intellectronica: it's landed on db-devel
=== noodles775 changed the topic of #launchpad-reviews to: on call: - || reviewing: henninge || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:54] <intellectronica> and what's stopping it from landing in devel? as noodles775 said we prolly want to have it used on edge a bit before releasing it
[15:55] <henninge> ask flacoste 
=== matsubara is now known as matsubara-lunch
[15:59] <henninge> noodles775: I somehow anticipated sinzui's comment about moving the edit link closer to the actual data, while pondering it over lunch. If you agree, I'll change that.
[16:00] <noodles775> henninge: I'm just getting your branch to run it locally now.
[16:02] <henninge> cool
[16:02] <noodles775> henninge: but yes, looking at your screenshots (thanks for those!), I'd definitely agree that the edit icon for the item (as opposed to the status) should be next to the item itself.
[16:04] <flacoste> intellectronica: we want to do QA on staging before releasing to users on edge
[16:04] <flacoste> intellectronica: just to make sure there isn't any major fuck-up
[16:05] <intellectronica> flacoste: oright. i'll land stuff on db-devel then. get that tested too
[16:06] <flacoste> intellectronica: plan is to land on devel on Monday
[16:06] <intellectronica> excellent. can't wait!
[16:12] <bac> noodles775: are you EOD or still accepting reviews?
[16:16] <bac> sinzui: i just sent in a MP.  would you mind reviewing it?  i'll not be here for an hour, though, as i'm out to get lunch.
[16:17] <sinzui> I do it
[16:20] <salgado> EdwinGrubbs, you're not reviewing sidnei's combo-service branch, right?  I'm about to start reviewing it so just wanted to make sure you haven't done so
=== bac is now known as bac-lunch
[16:21] <EdwinGrubbs> salgado: I didn't get very far, so feel free to take it over.
[16:21] <salgado> ok
[16:23] <sidnei> salgado: actually, mars just finished it
[16:23] <salgado> really?
[16:24] <sidnei> salgado: yep, right before you joined
[16:24] <noodles775_> henninge: you've got a screenshot there logged in as no-priv with the picker displaying, but when I'm logged in as no-priv I don't have an option to click on? What did I miss?
[16:25] <henninge> noodles775_: ah sorry, you need to create an entry as no-priv. Actually, create a project first, activate translations on it and upload something to the queue ...
[16:25] <noodles775_> henninge: ok, doing so now. Thanks.
[16:26] <noodles775_> henninge: also, when logged in as Carlos, are the Deleted and Blocked items in the picker meant to be disabled? They appear grayed out, but I can click on them and it updates (it could just be my colour-blindness).
[16:27] <henninge> noodles775_: I chose darkgray for those states ...
[16:27] <henninge> noodles775_: so, no, they are not grayed out.
[16:27] <henninge> noodles775_: got a suggestion for a better color scheme? ;)
[16:28] <noodles775_> henninge: nope - I'm not a great resource for choosing colours - I normally either (1) look for precedents, or (2) use a decent colour-scheme generator.
[16:30] <henninge> oh, didn't know such things exist
[16:30] <henninge> noodles775_: anyway, that is easy to fix in css.
[16:30] <noodles775_> yep.
[16:30] <noodles775_> henninge: if you don't mind flash, http://kuler.adobe.com/
[16:33] <henninge> noodles775_: wow, this is really kul!
[16:33] <noodles775_> :-)
[16:35] <henninge> noodles775_: bugs uses gray for invalid and won't fix, too.
[16:35] <henninge> but they don't have disabled items.
[16:35] <noodles775_> henninge: aha.
[16:39] <henninge> sinzui: I just saw that I may have broken the jacascript behind the expander button - maybe that was why it was hard to figure out what it does.
[16:39] <sinzui> henninge: I also tested one of my branches
[16:40] <henninge> sinzui: but I agree that it looks like it should either be moved to the left of not make use of the "expander" semantics.
[16:40] <henninge> s/of/or/
[16:40] <sinzui> henninge: the expander is always on the left on gtk, qt, macos, beos, java swing, and java swt
[16:40] <henninge> as I said, I agree
[16:41] <sinzui> henninge: I did not recognise it as an expander since it pointed to my scrollbar. I clicked the info icon and it expanded, then I had to toggle while looking at the other side of my browser to see what happened
[16:42] <henninge> ;)
[16:42] <sinzui> henninge: This is definitely a different bug
[16:46] <leonardr> anyone want to review a lazr.restful branch? https://code.edge.launchpad.net/~leonardr/lazr.restful/double-your-enjoyment-2/+merge/15045
[16:50] <flacoste> rockstar: i have 11 left before i disapppear in another meeting
[16:50] <rockstar> flacoste, well, can you show me some code where canonical_url hackery is done in the way that I need to do it for windmill?
[16:50] <flacoste> rockstar: can you remind me of the problem again?
[16:51] <rockstar> flacoste, canonical_url returns a url without the port number on it, so it's generally useless for use in windmill tests.
[16:51] <flacoste> ok
[16:52] <rockstar> flacoste, so what you said was that we need to install something into canonical_url space that tells it the url.
[16:52] <flacoste> rockstar: so what you need to do is modify the WindmillLayer testSetUp and testTearDown methods
[16:53] <flacoste> in testSetUp you should push the following on the config
[16:53] <flacoste> [vhost.mainsite]
[16:53] <flacoste> rooturl: http://launchpad.dev:8085/
[16:53] <flacoste> and so on for all the vhosts
[16:53] <rockstar> flacoste, ah, okay.
[16:53] <flacoste> look in configs/testrunner-appserver/launchpad-lazr.conf for the whole list
[16:53] <flacoste> all vhost.* sections should be pushed
[16:54] <flacoste> and then you pop that config back in the testTearDown
[16:54] <flacoste> et voilà
[16:54] <flacoste> that should work
[16:55] <rockstar> flacoste, easy peasy pumpkin squeezy.
[16:55] <sinzui> bac: r=me
[16:55] <henninge> noodles775_: pushed new version with moved edit icon and new colour scheme.
[16:55] <noodles775_> henninge: ok, merging now, thanks!
[16:58] <noodles775_> henninge: did you decide not to put the edit icon also next to the pot file (as sinzui suggested?), it only seems to be next to the template?
[17:00] <henninge> noodles775_: well, that is what is mainly been used. The file name is seldom changed.
[17:00] <noodles775_> henninge: OK, makes sense.
[17:01] <henninge> noodles775_: If we ever get as far as in-line editing all this data, it would be worth adding another icon.
[17:02] <noodles775_> henninge: well, I thought that was part of the advantage of sinzui's suggestion - that the UI wouldn't change when in-lining the other items (as you'd already have the icon there).
[17:02] <henninge> :-)
[17:02] <henninge> shot in the foot
[17:07] <henninge> noodles775_: I just tried it out and it looks too confusing. Have a look: http://people.canonical.com/~henninge/screenshots/status-picker-more-edit-icons.png
[17:08] <henninge> noodles775_: the two edit icons for different entries get dangerously close ...
[17:08] <henninge> noodles775_: I'd rather leave it with one icon per entry.
[17:09] <noodles775_> Yep, it does produce a lot of edit icons. I've written in the (as yet unsent) review that I'd leave that up to you - I think your previous justification is a good one (that it's normally only the template that users want to edit).
[17:14] <henninge_> noodles775_: daily disconnect, that is when I know it's time to go home .. ;)
[17:14] <noodles775_> henninge: yeah, I'm about to do a runner too.
[17:14] <noodles775_> just sending your review :)
[17:15] <henninge_> noodles775_: thank you very much! Enjoy your evening.
[17:15] <noodles775_> henninge, sinzui : ok, review sent, but I'm keen for sinzui's thoughts on two points mentioned in the review.
[17:15] <noodles775_> Night!
=== henninge_ is now known as henninge
=== matsubara-lunch is now known as matsubara
=== bac-lunch is now known as bac
=== salgado is now known as salgado-afk
=== mwhudson_ is now known as mwhudson
=== matsubara is now known as matsubara-afk
=== abentley1 is now known as abentley