/srv/irclogs.ubuntu.com/2009/11/23/#launchpad-reviews.txt

mwhudsonthumper: pls review 02:12
mwhudsonhttps://code.edge.launchpad.net/~mwhudson/launchpad/ec2-test-shutdown-if-setup-fails/+merge/1513802:12
* thumper looks02:12
mwhudsonno diff yet :/02:12
* thumper waits02:13
mwhudsonthumper: it's there now02:17
thumpermwhudson: done02:30
mwhudsonthumper: thanks02:30
thumpermwhudson: still around?04:55
mwhudsonthumper: slightly04:55
mwhudsonthumper: i can review that branch we were talking about if you want04:55
thumpermwhudson: want to look at this trivial branch?04:55
thumpercool04:55
thumpermwhudson: should be your way soon04:57
thumpermwhudson: ta05:04
mwhudsonthumper: np05:04
=== noodles775_ is now known as noodles775
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
leonardrintellectronica, can you please review https://code.edge.launchpad.net/~leonardr/lazr.restful/double-your-enjoyment-2/+merge/15045 ?13:24
intellectronicaleonardr: sure. do you need my credit card details?13:25
intellectronicaleonardr: r=me13:37
leonardrintellectronica, tx13:37
=== sinzui changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
intellectronicasinzui: branch?14:06
sinzuiintellectronica: https://code.launchpad.net/~sinzui/launchpad/vocab-storm-bug-413287/+merge/1512514:06
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: sinzui || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
intellectronicasinzui: all good. r=me14:16
sinzuithanks!14:16
=== abentley1 is now known as abentley
=== abentley changed the topic of #launchpad-reviews to: on call: intellectronica,abentley || reviewing: sinzui,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica,abentley || reviewing: -,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-lunch
bacintellectronica, abentley: i have a small branch for your reviewing pleasure15:21
abentleybac: Lay it on me.15:21
bachttps://code.edge.launchpad.net/~bac/launchpad/bug-266890/+merge/1515315:22
=== abentley changed the topic of #launchpad-reviews to: on call: intellectronica,abentley || reviewing: -,bac || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
rockstarintellectronica, could you take a second look at my branch you were reviewing last week?15:22
intellectronicarockstar: sure thing. have you incorporated the comments from my initial review?15:23
abentleybac: This looks like a good thing to do.  Do you think a mixin is the best way to express the commonality between ProductAdminView and ProductReviewLicenseView?15:30
bacabentley: i did.  do you have another suggestion?15:30
bacabentley: they really are two completely different beasts that share that one field15:31
abentleybac: Okay, then.  I thought that ProductReviewLicenseView was something like a subset of ProductAdminView.15:31
abentleybac: r=me.15:31
bacabentley: thanks!15:31
=== matsubara is now known as matsubara-lunch
rockstarintellectronica, I have.15:33
intellectronicarockstar: great. i've got no other comments. r=me15:37
=== abentley changed the topic of #launchpad-reviews to: on call: intellectronica,abentley || reviewing: -,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
rockstarintellectronica, thanks!15:37
intellectronicaabentley: if it's ok with you, i'm going to go off duty here. call soon and after that i'd like to get some time for my own work.15:40
intellectronicathough as always, feel free to summon me if all of a sudden it gets very busy15:40
=== intellectronica changed the topic of #launchpad-reviews to: on call: abentley || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
abentleyintellectronica: That sounds fine.15:40
=== salgado-lunch is now known as salgado
=== jamalta_ is now known as jamalta
=== deryck is now known as deryck[lunch]
=== matsubara-lunch is now known as matsubara
=== beuno is now known as beuno-lunch
=== deryck[lunch] is now known as deryck
=== beuno-lunch is now known as beuno
=== sinzui changed the topic of #launchpad-reviews to: on call: abentley || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
sinzuiabentley: I have a branch that removes the old main-template from our tree: https://code.launchpad.net/~sinzui/launchpad/remove-main-template/+merge/1516518:13
abentleysinzui: I'm going to get lunch and then review it.  Cool?18:15
=== abentley is now known as abentley-lunch
sinzuiabentley: np, the branch is bonus work18:16
leonardrabentley, can you add me to the queue? https://code.edge.launchpad.net/~leonardr/lazr.restful/version-specific-request-interface/+merge/1517219:38
leonardrit's kind of a complicated branch, so feel free to ask lots of questions19:38
=== bigjools-afk is now known as bigjools
=== abentley-lunch is now known as abentley
abentleyleonardr: okay.20:06
=== abentley changed the topic of #launchpad-reviews to: on call: abentley || reviewing: sinzui || queue [leonardr] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-afk
=== abentley changed the topic of #launchpad-reviews to: on call: abentley || reviewing: leonardr || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
abentleyleonardr: since you're not wanting to land this branch, why do you want it reviewed?20:15
leonardrabentley: because i don't want to have someone review a 5k loc branch later on20:17
abentleyleonardr: We have other tools that help with that, like looms and pipelines.20:17
leonardrall right, but i'd still rather have the code reviewed as it's finished, so that if there's a catastrophic error in this branch i find out today20:20
leonardri can always do it later, it's not a big deal20:25
=== abentley1 is now known as abentley
=== salgado is now known as salgado-afk
abentleyleonardr: I think it's better to do it later.  The review process isn't really meant to find bugs, or even design issues.  You're much more likely to find them yourself, as you work on the next stage.21:37
leonardrabentley, ok21:37
abentleyleonardr: I'd be happy to show you how to use pipelines to manage this set of work.21:38
leonardrabentley, can i ping you tomorrow?21:38
abentleyleonardr: sure.21:38
leonardrok21:39
=== abentley changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bigjools-afk is now known as bigjools

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!