[02:12] <mwhudson> thumper: pls review 
[02:12] <mwhudson> https://code.edge.launchpad.net/~mwhudson/launchpad/ec2-test-shutdown-if-setup-fails/+merge/15138
[02:12]  * thumper looks
[02:12] <mwhudson> no diff yet :/
[02:13]  * thumper waits
[02:17] <mwhudson> thumper: it's there now
[02:30] <thumper> mwhudson: done
[02:30] <mwhudson> thumper: thanks
[04:55] <thumper> mwhudson: still around?
[04:55] <mwhudson> thumper: slightly
[04:55] <mwhudson> thumper: i can review that branch we were talking about if you want
[04:55] <thumper> mwhudson: want to look at this trivial branch?
[04:55] <thumper> cool
[04:57] <thumper> mwhudson: should be your way soon
[05:04] <thumper> mwhudson: ta
[05:04] <mwhudson> thumper: np
[13:24] <leonardr> intellectronica, can you please review https://code.edge.launchpad.net/~leonardr/lazr.restful/double-your-enjoyment-2/+merge/15045 ?
[13:25] <intellectronica> leonardr: sure. do you need my credit card details?
[13:37] <intellectronica> leonardr: r=me
[13:37] <leonardr> intellectronica, tx
[14:06] <intellectronica> sinzui: branch?
[14:06] <sinzui> intellectronica: https://code.launchpad.net/~sinzui/launchpad/vocab-storm-bug-413287/+merge/15125
[14:16] <intellectronica> sinzui: all good. r=me
[14:16] <sinzui> thanks!
[15:21] <bac> intellectronica, abentley: i have a small branch for your reviewing pleasure
[15:21] <abentley> bac: Lay it on me.
[15:22] <bac> https://code.edge.launchpad.net/~bac/launchpad/bug-266890/+merge/15153
[15:22] <rockstar> intellectronica, could you take a second look at my branch you were reviewing last week?
[15:23] <intellectronica> rockstar: sure thing. have you incorporated the comments from my initial review?
[15:30] <abentley> bac: This looks like a good thing to do.  Do you think a mixin is the best way to express the commonality between ProductAdminView and ProductReviewLicenseView?
[15:30] <bac> abentley: i did.  do you have another suggestion?
[15:31] <bac> abentley: they really are two completely different beasts that share that one field
[15:31] <abentley> bac: Okay, then.  I thought that ProductReviewLicenseView was something like a subset of ProductAdminView.
[15:31] <abentley> bac: r=me.
[15:31] <bac> abentley: thanks!
[15:33] <rockstar> intellectronica, I have.
[15:37] <intellectronica> rockstar: great. i've got no other comments. r=me
[15:37] <rockstar> intellectronica, thanks!
[15:40] <intellectronica> abentley: if it's ok with you, i'm going to go off duty here. call soon and after that i'd like to get some time for my own work.
[15:40] <intellectronica> though as always, feel free to summon me if all of a sudden it gets very busy
[15:40] <abentley> intellectronica: That sounds fine.
[18:13] <sinzui> abentley: I have a branch that removes the old main-template from our tree: https://code.launchpad.net/~sinzui/launchpad/remove-main-template/+merge/15165
[18:15] <abentley> sinzui: I'm going to get lunch and then review it.  Cool?
[18:16] <sinzui> abentley: np, the branch is bonus work
[19:38] <leonardr> abentley, can you add me to the queue? https://code.edge.launchpad.net/~leonardr/lazr.restful/version-specific-request-interface/+merge/15172
[19:38] <leonardr> it's kind of a complicated branch, so feel free to ask lots of questions
[20:06] <abentley> leonardr: okay.
[20:15] <abentley> leonardr: since you're not wanting to land this branch, why do you want it reviewed?
[20:17] <leonardr> abentley: because i don't want to have someone review a 5k loc branch later on
[20:17] <abentley> leonardr: We have other tools that help with that, like looms and pipelines.
[20:20] <leonardr> all right, but i'd still rather have the code reviewed as it's finished, so that if there's a catastrophic error in this branch i find out today
[20:25] <leonardr> i can always do it later, it's not a big deal
[21:37] <abentley> leonardr: I think it's better to do it later.  The review process isn't really meant to find bugs, or even design issues.  You're much more likely to find them yourself, as you work on the next stage.
[21:37] <leonardr> abentley, ok
[21:38] <abentley> leonardr: I'd be happy to show you how to use pipelines to manage this set of work.
[21:38] <leonardr> abentley, can i ping you tomorrow?
[21:38] <abentley> leonardr: sure.
[21:39] <leonardr> ok