[09:31] <jtv> henninge, care to review my fix?  https://code.edge.launchpad.net/~jtv/launchpad/bug-487445/+merge/15185
[09:31] <henninge> jtv: let's see what you are fixing ...
[09:32] <henninge> jtv: wow, you are quick!
[09:32] <jtv> henninge: I wrote the fix this morning
[09:33] <jtv> when I saw that stub was ahead of me I marked my bug invalid, but kept the branch around
[09:33] <henninge> jtv: still waiting for the diff to appear.
[09:33] <jtv> http://paste.ubuntu.com/326709/
[09:34] <henninge> jtv: Actually, I was not sure if all the dependcies are needed but lazr.choiceedit is needed for sure.
[09:34] <jtv> henninge: it can sometimes be worth whittling that down... not a job for this branch though I think
[09:34] <jtv> we want a quick fix here
[09:35] <henninge> jtv: true, r=me
[09:35] <jtv> thanks
[09:36] <henninge> jtv: I was starting on a branch to fix that when I hit the APR_CONFIG problem.
[09:37] <jtv> stuart hit that one too
[09:38] <jtv> oops, I'm running out of time... have a bunch of things to do outside
[09:38] <jtv> started work far too early; various little brush fires
[09:38] <henninge> jtv: go ahead, see you later, then
[09:38] <jtv> my branch is in pqm... please watch it for me!
[09:38] <henninge> jtv: thanks, I will
[12:11] <bac> good morning gmb
[12:11] <gmb> Hi bac. 
[12:11] <gmb> Another quiet day today, it seems.
[12:11] <gmb> Well, so far anyway.
[12:12] <bac> quiet is good
[12:15] <gmb> Indeed.
[12:15] <gmb> So good, I think I'll grab some lunch.,
[12:27] <jtv> gmb: thanks for the review
[14:59] <barry> gmb, bac if you're looking for something to review, would you like to take my lazr-js branch?  https://code.edge.launchpad.net/~barry/lazr-js/482298-picker-batching/+merge/15176
[14:59] <bac> barry i'd love to!
[14:59] <barry> bac: awesome, thanks
[15:03] <bac> barry: is there an URL that demonstrates it?
[15:08] <barry> bac: the best thing to do is load the examples/picker/index.html file
[15:08] <bac> barry: ok
[15:08] <barry> bac: by choosing "numbers" you get the simplified api; "letters" gets you the more complex api
[15:08] <bac> rt
[15:14] <bac> barry: i've loaded that page.  the 'show widget' button is disabled.  have i done something wrong?
[15:14] <barry> bac: hmm...
[15:14] <barry> bac: did you run 'make'?
[15:15] <bac> nope
[15:15] <bac> doing so now
[15:16] <barry> bac: i just tried it.  it doesn't seem to help
[15:16] <bac> oy
[15:16] <barry> bac: something's changed/broken in trunk i think.  let me ping the rhinos
[15:17] <bac> ok
[15:21] <bac> barry: after the make the picker example now loads
[15:21] <barry> good!  unfortunately it still doesn't for me :(
[15:22] <bac> reloaded the page?
[15:23] <barry> yep, js errors
[15:23] <barry> i'm trying the trunk now
[15:24] <barry> trunk works.  i'm chatting w/ noodles775 in rhinos to try to fix my branch
[15:27] <bac> barry: what's the deal with the roman numerals in index.html?  is it used?
[15:27] <barry> no, it's just sample code
[15:27] <bac> ah, ok
[15:29] <barry> bac: make clean & make fixed my local problem
[15:29] <bac> ok
[15:32] <bac> barry: it looks good to me.
[15:33] <barry> bac: thanks
[17:10]  * gmb EoDs
[20:37] <abentley> bac: Could you please review https://code.launchpad.net/~abentley/launchpad/errorlog-context/+merge/15217 ?
[20:43] <bac> abentley: certainly
[20:52] <bac> abentley: r=bac
[20:52] <abentley> bac: Thanks!
[21:03]  * bac -> EOD
[22:24] <bigjools> wgrant: after you finish checking the source format in your change, why is there an assertion error instead of an upload error if the format is not recognised?
[22:25] <wgrant> bigjools: Let me check.
[22:26] <wgrant> bigjools: We've already checked that the distroseries supports the format, so if the case isn't handled there it is a bug.
[22:27] <wgrant> We will not get into that method unless Soyuz knows about the format.
[22:27] <bigjools> okay, then it makes more sense to me to be checking enum values instead of strings then
[22:27] <bigjools> I'll add that to the review
[22:27] <wgrant> bigjools: True.
[22:28] <wgrant> That code pre-dates the enum.
[22:28]  * wgrant fixes.
[22:28] <bigjools> right
[22:36] <bigjools> wgrant: what are these new orig tarball "comp" files for?
[22:36] <bigjools> component, I mean
[22:36] <wgrant> bigjools: If I have foo_1.2-3.orig-bar.tar.gz, it will be extracted into bar/ in the new source tree.
[22:37] <bigjools> ah interesting
[22:40] <nhandler> Could someone help me with the test section of the merge proposal for https://code.launchpad.net/~nhandler/launchpad/bugfix151113 ? I'm not really sure what test would be appropriate for this (I think I've spent more time looking into what test to use than it took to patch the actual bug)
[22:41] <bigjools> nhandler: If I have time I can take a look in a while when I've finished reviewing wgrant's branch
[22:41] <wgrant> nhandler: lib/lp/blueprints/doc/specification-notifications.txt
[22:42] <nhandler> Thanks wgrant 
[22:50] <nhandler> I might be mis-interpreting the test result, but it looks like it is failing because I fixed the bug. It is expecting a notification with the incorrect white space. In this case, should I just patch the test?
[22:51] <wgrant> nhandler: Exactly.
[23:03] <nhandler> Alright, I just proposed the branch for merging
[23:31] <bigjools> nhandler: I approved it but I can't land it right now, can you find someone else who will do it for you please
[23:32] <nhandler> bigjools: Yeah, I'll try. Thanks for approving it
[23:32] <bigjools> np - perhaps... /me looks around.... barry or bac can do it?
[23:32] <wgrant> bigjools: I considered using lambdas, but I think I really need statements.
[23:33] <bigjools> wgrant: the other option is to slap it all in a new class
[23:33] <bigjools> but it's up to you
[23:33] <bigjools> I just don't like a gazillion chained elifs :)
[23:34] <wgrant> Right.
[23:34] <bigjools> and on that note, I need to EOD
[23:34] <wgrant> Thanks.
[23:34] <bigjools> as the sun sets over Austin
[23:35] <bigjools> no prob - I'll check it first thing tomorrow.  I'm not sure if we ought to land it just yet in case some 3.0 packages hit the builders before they're ready
[23:36] <bigjools> although I guess the lack of a new dpkg on cocoplum would prevent that
[23:36] <wgrant> bigjools: We just won't allow the new formats in any serie yet.
[23:36] <bigjools> ah of course
[23:36] <bigjools> ok, cool, then I'll get it landed in the morning if it looks good
[23:36] <wgrant> Great.
[23:37] <bigjools> thanks a bunch for making the change
[23:37] <wgrant> np
[23:40] <bac> bigjools: wha? you're in austin?
[23:40] <bigjools> yes
[23:40] <bigjools> bac: I went to the last UT home game on Saturday :)
[23:42] <nhandler> bac: Would you be up for landing https://code.edge.launchpad.net/~nhandler/launchpad/bugfix151113/+merge/15225