/srv/irclogs.ubuntu.com/2009/12/01/#launchpad-dev.txt

=== jelmer_ is now known as jelmer
thumperlifeless: was there a bug about the +activereviews fubar?01:38
thumperlifeless: FWIW I've found the bug and fixing it01:38
lifelessthumper: I think it was lp death spiraling01:42
thumperlifeless: no, it wasn't01:42
lifelessthumper: and no, we didn't file a bug01:42
* thumper files one01:42
lifelessthanks for fixing it.01:42
thumperevery time I think of the question I need to talk to gary about, it is my afternoon and he is away :(02:04
wgrantLP doesn't work on Lucid :(02:08
wgrantShould I upload fixes to my own PPA, and get somebody to copy them in?02:08
lifelesswgrant: yes02:13
ajmitchwgrant: I hope it's mostly due to python 2.5 support going away, and nothing more major02:23
wgrantajmitch: That's right.02:24
mwhudsonwow typing out model code is boring04:13
* wgrant yearns for bug tag editing in bug listings.04:42
lifelessmwhudson: model code?04:49
wgrantHow do I create a WIP MP?04:49
mwhudsonlifeless: the python code that reflects the database tables04:50
mwhudsonwgrant: you create a ready for review one and change the status i think04:50
wgrantmwhudson: Ah. That's a bit crap.04:50
mwhudson(or "use the api", maybe)04:50
mwhudsonwgrant: yes04:50
thumperwgrant: you used to be able to ..07:17
thumperwgrant: but the option got removed for simplicity07:17
thumperwgrant: I want to add an "Extra options" area like bugs07:17
thumperwgrant: and bring it back07:17
thumperAAARRRGGGHHHH!!!!!!!!!!!!!!!!!08:00
thumper✁☹08:00
* thumper files a bug08:01
* thumper doesn't file a bug, but just fixes the damn problem08:04
adeuringgood morning08:11
jelmer'morning08:22
noodles775Morning jelmer :-D08:22
thumperjelmer: hi, starting officially today?08:26
jelmerthumper: hi - yep08:26
thumperjelmer: welcome and congratulations08:26
bigjoolsgood morning jelmer08:27
jelmerthumper: Thanks :-)08:28
wgrantMorning.08:34
noodles775Hi wgrant08:35
wgrantbigjools: Did you get around to uploading that dpkg? My connection has returned to full speed, so I can do it if needed.08:35
bigjoolswgrant: not yet, I was half-way through editing the changelog08:35
bigjoolswgrant: I was trying to think of an appropriate version :)08:36
wgrantbigjools: Some use the CAT version, others use ~launchpad1...08:37
bigjoolsyeah I was going with the latter08:37
* wgrant prepares a lucid Launchpad PPA.08:41
bigjoolswgrant: it's uploading now08:52
wgrantbigjools: Thanks08:53
wgrantbigjools: Now I guess somebody needs to poke $LOSA and $EC2TEST_AMI_UPDATING_PERSON...08:53
bigjoolsyarp08:54
bigjoolswhen the package is built I'll do that08:54
wgrantThanks.08:54
bigjoolswgrant: it was buildbot and ... ?08:54
wgrantbigjools: ec2test images08:55
bigjoolsthat's the same thing in my head08:56
wgrantbigjools: (and cocoplum and germanium and iron... how are those RTs going?)08:56
wgrantThey're different images.08:56
bigjoolscan you tell I don't use ec2? :)08:56
wgrant:(08:56
bigjoolswgrant: https://edge.launchpad.net/~launchpad/+archive/ppa/+build/137402708:58
bigjoolsballs08:59
wgrantUm.08:59
wgrantThat's odd.08:59
* wgrant looks.08:59
bigjoolsdebhelper(inst 6.0.4ubuntu1 ! >= wanted 6.0.7)08:59
mwhudsoni can rebuild the images for ec2 test09:00
bigjoolscool thanks.  I'd like to get the package built first :)09:00
mwhudsonjust drop me a mail when the ~launchpad ppa has the new hotness09:00
bigjoolsyarp09:00
* mwhudson shouldn't be at the computer any more...09:00
mwhudsonrunning away now09:00
jmlflee09:00
wgrantbigjools: Let me check how my PPA managed to build it.09:00
wgrantAh, of course, it's not exactly the same.09:01
wgrantmine's an older version.09:01
wgrantYou could use debhelper from hardy-backports, or ask cjwatson how he did it...09:02
wgrantbigjools: You retried it?09:06
bigjoolsno09:07
bigjoolswtf09:07
thumperjml: please QA your bits :)09:07
* thumper runs away too09:07
wgrantbigjools: The depwait giver-back is being rather too lenient, then?09:07
bigjoolsyes09:08
bigjoolsI thought it waited longer09:08
bigjoolsI will copy the hardy-backports dpkg09:08
bigjoolss/dpkg/debhelper/09:08
wgrantbigjools: Using the forbidden UI?09:09
bigjoolsshhh09:09
wgrantIt is handy for that.09:09
bigjoolsI don't mind making it more public if we can force people to specify package names up front09:09
wgrantRight.09:10
wgrantAlthough I don't see why it has to time out while listing them all.09:11
wgrantRebuild archives manage to list their packages.09:11
bigjoolsyeah we can possible make the same optimisations09:13
bigjoolspossibly*09:13
* bigjools stabs intel xorg09:14
jmlthumper, !09:14
wgrantbigjools: Still broken, even on Karmic?09:14
bigjoolsyes09:14
wgrantbigjools: What's wrong with it?09:14
bigjoolsz-order is totally borked sometimes, you get the wrong windows half-painted over the top of the one that has focus09:14
wgrantI see that sometimes during Compiz transitions, but never otherwise.09:15
wgrant(well, except for Firefox, but that's Mozilla)09:15
wgrantbigjools: You didn't just retry it before it was published, did you?09:16
bigjoolsI didn't09:16
wgrantOr was that the depwait giver-back thing again?09:16
wgrantAh.09:16
bigjoolsyes :/09:16
jmlif a revision broke the test suite because it was actually behaving badly, how should that be marked on the QA plan?09:16
bigjoolsjml: BAD09:17
jmlbigjools, thanks.09:17
jmlI did some refactoring on the upload permission stuff09:17
jmlhow should I QA that?09:17
bigjoolsjml: ?? (untestable)09:18
jmlbigjools, is there some way to at least smoke test it?09:19
jmlmake sure that people can still upload to their PPAs & what-not.09:19
bigjoolsjml: yeah you can use dogfood if it was up :(09:19
jmlbigjools, hmm. ok.09:19
wgrantbigjools: Still updating?09:19
wgrant*restoring09:19
* jml writes a launchpadlib script to test the final QA item09:20
* wgrant tracks down the retry-depwait bug.09:21
* bigjools tries to get into dogfood09:21
wgrantWell, it doesn't take pockets into account.09:22
wgrantThat would do it.09:22
bigjoolsthat's.... suboptimal09:22
bigjoolsooo nice race condition09:24
bigjoolsretry build, click rescore, then see if you can beat it getting dispatched09:24
bigjoolsif not, OOPS!09:25
wgrantbigjools: Oh, do you want to review my gina 3.0 branch?09:29
bigjoolswgrant: I can, stick it in my queue09:29
bigjoolswgrant: it built \o/09:30
wgrantbigjools: Excellent.09:30
mrevellmorning09:31
* bigjools retries other arches09:31
lifelessrandom question09:46
lifelessarch all packages09:46
lifelesswhat controls what queue they go to? Is it code, or a db entry?09:47
wgrantdistroseries.nominatedarchindep09:47
wgrantIt's in the DB.09:47
lifelessI was wondering, if we could just make it roundrobin through some  sort of hack09:47
wgrantSort of.09:48
wgrantBug #285206 is better.09:48
lifelessjust putting the idea out there.09:48
mupBug #285206: builddmaster needs to be able to deal with "random arch" buildds <oem-services> <soyuz-build> <Soyuz:Triaged> <https://launchpad.net/bugs/285206>09:48
* bigjools would love it if lifeless fixed that :)09:49
wgrantIt should be nearly free after BFB, I think.09:49
wgrantThe main problem is queueing.09:49
bigjoolsyeah09:49
wgrants/queueing/ordering/09:49
jmlif I have a python dictionary corresponding to the JSON dict of a launchpad rest resource, can I somehow bless it into an actual launchpadlib object?09:54
jml(also, is the rest service _slower_ than the rest of Launchpad?)09:54
* jml discovers launchpadlib.uris. Is happy.09:56
jmlhmm. http://paste.ubuntu.com/332235/09:59
jmlyou know, if that got split out into a method that took 'representation' as a parameter, unit testing would be much easier, and I'd be able to do what I want.10:01
lifelessjml: you should do that :)10:03
jmllifeless, I should do a lot of things.10:03
jmlI need help dealing with a bad QA item. Who do I talk to?10:04
lifelesswhats bad about it10:09
lifelessjml: I need a quick review (real quick): https://code.edge.launchpad.net/~lifeless/testtools/meta/+merge/1547910:14
jmllifeless, done10:16
lifelessthanks10:16
maxbHmm. Launchpad is confused. It has sent me a mail claiming "You are receiving this email because you are the uploader of the above PPA package." for bigjools upload of dpkg to launchpad PPA10:44
bigjools!10:44
bigjoolsthat's special10:45
bigjoolsmaxb: ah I know why10:45
bigjoolsit's because you're listed as a separately permissioned uploader10:45
bigjoolsit's deliberate10:46
bigjoolsbut the email template is wrong of course10:46
maxbIt's still wrong :-)10:46
bigjoolsyeah :(10:46
bigjoolsit was done for our OEM team so they get all upload notifications sent to a list10:47
maxbIn a perfect world we'd extend the concept of subscriptions to PPAs10:47
bigjoolsyes, that's the eventual plan10:47
bigjoolsthen we can remove the emails that go to the owner's address10:47
wgrantHm.10:53
wgrantI note a lack of lpia Lucid PPA builds10:53
wgrantHas the chroot been removed, but not yet the DAS?10:53
bigjoolsyes10:53
wgrantAh.10:53
=== matsubara-afk is now known as matsubara
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
=== adiroiba1 is now known as adiroiban
asabilhi all14:53
asabilis it possible to configure launchpad not to use subdomains ?14:53
jmlno, not really.15:00
=== matsubara is now known as matsubara-lunch
asabilok15:03
=== noodles775_ is now known as noodles775
jmlbarry, hey, you know 'make run_all'?15:21
jmlbarry, can we stop it from doing that mailman spew?15:47
barryjml: it should only spew if something earlier up fails15:47
jml127.0.0.88 - "" "xmlrpc-private.launchpad.dev:8087" [1/Dec/2009:15:22:07 +0100] "POST /mailinglists HTTP/1.0" 200 392 4 0.135702133179 46 47 "Anonymous" "MailingListApplication:MailingListAPIView" "" "xmlrpclib.py/1.0.1 (by www.pythonware.com)"15:47
jml127.0.0.88 - "" "xmlrpc-private.launchpad.dev:8087" [1/Dec/2009:15:22:08 +0100] "POST /mailinglists HTTP/1.0" 200 392 3 0.0679800510406 25 36 "Anonymous" "MailingListApplication:MailingListAPIView" "" "xmlrpclib.py/1.0.1 (by www.pythonware.com)"15:47
jml127.0.0.88 - "" "xmlrpc-private.launchpad.dev:8087" [1/Dec/2009:15:22:13 +0100] "POST /mailinglists HTTP/1.0" 200 392 4 0.0281419754028 20 46 "Anonymous" "MailingListApplication:MailingListAPIView" "" "xmlrpclib.py/1.0.1 (by www.pythonware.com)"15:47
jmlbarry, I mean that spew.15:47
barryjml: oh15:48
barryjml: well, i guess shut off logging in the xmlrpc server?15:48
jmlbarry, what's making the requests?15:48
allenapmars: I'm about to look at bug 489342, but I wondered if you know if anyone else has already done some work on it?15:49
mupBug #489342: "'display_name' is undefined" JavaScript error on development <javascript> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/489342>15:49
barryjml: it's the mailman xmlrpc queue runner.  it polls launchpad.dev every so often15:49
jmlbarry, hmm.15:50
marsallenap, jml and I looked into it on Friday.  We thought it may have been a change in the last week, but I was able to reproduce on an old branch of db-devel.15:50
marsallenap, I'm really puzzled by the bug's absence on staging and edge.15:51
jmlbarry, I think what I might do is abandon 'make run_all'15:51
barryjml: unless you really need the other services, that's the best advice i can give15:51
jmlmars, out of curiosity, have you diffed the various outputs?15:51
marsjml, the on-page outputs?  No, good idea though.15:52
marsallenap, ^15:52
jmlmars, yeah, that's what I meant: js, css & html.15:52
jmlmars, it might not locate the problem, but you might find out what's different about edge & staging.15:52
allenapmars: Okay, I have no idea what that refers to yet, but I'll take a look :)15:52
jmlbarry, codehosting needs the private XML-RPC service15:53
barryjml: iirc, there are ways to start services selectively.  i don't remember the details, but you should be able to make run_all and not start mailman.  read the Makefile for details (there's a make variable)15:54
jmlbarry, hmm. thanks.15:54
marsallenap, details are in the bug description.  The bug doesn't show up in production, only on devel.  By capturing and diffing the output of a real page, we might be able to narrow down what is different between production and devel.15:54
jmlbarry, even if there's a variable, I might make a helper though. It's _really_ useful to be able to fire up codehosting without thinking too much.15:54
jmlbarry, even if there's a variable, I might make a helper though. It's _really_ useful to be able to fire up codehosting without thinking too much.15:57
barryjml: copy the run_all target and remove mailman from the bin/run -r option15:58
jmlok. I'll do that.15:58
jmlalthough, it's week 415:58
jmlwhy are we even talking about making small improvements to increase developer speed :(15:58
barryjml: exactly. jfdi15:59
jmlbarry, I can't!15:59
=== salgado is now known as salgado-lunch
jmlbarry, week 4 means I can't.15:59
barryjml: so now you've started to find the root cause.  rinse and repeat :)16:00
jmlbarry, well, there's already some interest in thawing during week 416:02
barryjml: that would rock16:02
allenapgmb: Have you got 10 minutes to talk about bug 489342? I think it's related to the async subscriber portlet work.16:17
mupBug #489342: "'display_name' is undefined" JavaScript error on development <javascript> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/489342>16:17
gmbOy.16:17
gmballenap: Sure.16:17
gmbSkype?16:17
allenapgmb: Cool, Skype? Ready? :)16:17
=== salgado-lunch is now known as salgado
EdwinGrubbsbac: ping17:22
jmlis there a PPA with all of the latest launchpadlib stuff in it?17:29
bigjoolsjml: I hear we have this great search thing in LP ...17:29
cody-somervilleI heard its crap17:30
* bigjools takes cody-somerville off his xmas list17:31
cody-somerville:-(17:31
bigjoolsjml: also see the cool expander at the bottom of here https://edge.launchpad.net/ubuntu/+source/python-launchpadlib17:31
jmlbigjools, you know what, I tried searching for 'launchpadlib ppa' and I found a broken link to one of your PPAs at item eight or so17:31
bigjoolsjml: or you can go to https://edge.launchpad.net/ubuntu/+ppas :)17:32
bigjoolsumm ew, broken icons17:32
jmlhmm. no one seems to have packaged the latest release17:34
marsbeuno, ^ looks like more sprites are broken, this time on https://edge.launchpad.net/ubuntu/+ppas17:39
beunohrm17:40
marssame problem, the sprites have been applied to a block-display <li> tag17:40
beunoyeah17:41
beunothey need to be applied to a span17:41
jmlanyway, where was I.17:42
jmlone of my QA items is bad. An API I added doesn't behave as advertised. Instead of returning a dict mapping URLs to branch objects, it returns a dict mapping URLs to branch json dicts.17:43
jmlhow can I tell what db queries are used to load a person via the API?18:07
marsjml, is there a way to tell which queries are used on a regular launchpad page?18:08
marsversus the API18:09
jmlmars, yes. you can add ++oops++ as the suffix of the URL to generate an oops report18:10
marsjml, oh, neat.  I assume you tried that with the API URL?  Might work, depending on how the publisher machinery views the request.18:10
sinzuihave I mentioned how much I hate ZCML recently? Well I still do.18:11
jmlwell, I tried entering an API url into my browser. All I get is "Unknown consumer (None)."18:11
marssinzui, hehe18:11
jmlmars, whether I use the suffix or not18:11
jmlmars, https://dev.launchpad.net/Debugging was where I got the ++oops++ trick from, btw18:11
marsjml, try it via the launchpad.net/api/ URL18:11
marsjml, the url that the JS uses18:12
jmlno joy18:13
jmldifferent stuff, no oops love.18:13
bacEdwinGrubbs: hi18:16
marsjml, wow, thanks for the debugging page link.  That is useful!18:30
=== deryck is now known as deryck[lunch]
jmlmars, np. please update it as you think of stuff.18:32
marsjml, just tried it myself, and you're right.  No oops for API ++oops++ urls.  darnit.18:33
jml'* * * * *' means "run every minute" in cron, right?18:34
jmlhmm.18:36
jmlcan 'links' log in to Launchpad, I wonder.18:36
marsjml, on devel, tried "$ LP_DEBUG_SQL=1 make run"18:37
marsit doesn't return too much18:38
marsI wish I could tell were the session and auth SQL statments begin and end though18:38
marsalso works in curl: $ curl -k https://bugs.launchpad.dev/api/beta/~name1218:40
jmlmars, not quite as convenient as being able to generate an OOPS, sadly.18:41
* jml starts gathering data on how long it takes to do a named get for a particular api18:42
EdwinGrubbsbac: I had some questions about private teams and vocabularies. I see that you currently allow private teams in the ValidTeam vocabulary if the user is a participant of the team, but a private-membership team is never in the vocab.18:45
bacEdwinGrubbs: yes as PMTs can never be used for anything18:46
sinzuiEdwinGrubbs: we are trying to remove them because they really cannot be used for anything18:47
EdwinGrubbsbac: currently, if a form field uses PublicPersonChoice with the ValidTeamVocabulary, it displays "Invalid value" for non-members trying to enter in a form and hides it from the picker. However, for members of the private team, the form displays "Constraint not satisifed" since PublicPersonChoice rejects it although it actually shows up in the vocabulary for members. This also means that the picker allows you to select a team t18:49
jmlhmm. something is going on that I don't understand18:50
jmlit looks like the first time I hit a bug via wget it takes a while to load, and then following hits take less time: http://paste.ubuntu.com/332535/18:51
bacEdwinGrubbs: your last sentence got truncated.18:51
EdwinGrubbs bac:... This also means that the picker allows you to select a team that can't be used.18:52
bacEdwinGrubbs: that indeed sounds like a problem.18:52
EdwinGrubbsbac: so, I'm wondering whether the security measure should be primarily handled by the vocabulary or by the *PersonChoice. I can explain the pros and cons.18:53
bacEdwinGrubbs: perhaps we need two vocabularies18:53
bacEdwinGrubbs: one vocab to use with PublicPersonChoice and one to use with ParticipatingPersonChoice18:54
Ursinhadanilos, here is better, I guess :)18:54
Ursinhaor danilo_18:54
danilo_Ursinha, hi, yes :)18:55
Ursinhadanilo_, rite :P18:55
=== danilo_ is now known as danilos
danilosUrsinha, so, what test is bothering you? :)18:56
Ursinhadanilos, lp.translations.browser.tests.test_product_view.TestProduct.test_primary_translatable_with_package_link failed18:56
Ursinhadanilos, I went to the test to see why, and it18:56
Ursinhagrrr18:56
bacmthaddon: ping18:56
Ursinhait's testing a behavior I wasn't expecting18:56
danilosUrsinha, right, let me take a look18:57
Ursinhadanilos, the way I implemented, primary_translatable is or the translation focus or the development focus18:57
EdwinGrubbsbac: the advantage of the vocabulary is that it does all the work, however, if you are allowed to pass in any vocab to PublicPersonChoice, etc., then you can confuse the programmer.18:57
Ursinhathat test expects that if the devel focus has a link to a package, we should return nothing18:58
Ursinhadanilos, ^18:58
danilosUrsinha, well, it expects that for a reason, let me take a closer look :)18:59
Ursinhadanilos, I couldn't find an explanation where that properties were defined, so thanks for looking :P18:59
EdwinGrubbsbac: Either, the PublicPersonChoice has to duplicate the privacy check in case an inappropriate vocab is used, or it has to restrict which vocabs are allowed, or we could have one Choice class per relevant vocab: PublicPersonOrTeamChoice, PublicTeamChoice, etc.19:00
danilosUrsinha, did you change in any way how development_focus is used as primary_translatable other than giving precedence to translation_focus?19:01
Ursinhadanilos, I'm pretty sure I didn't, but I'll double check19:01
danilosUrsinha, because, I don't see how your code would have broken the test since the test itself doesn't set the translation_focus19:01
Ursinhadanilos, indeed19:02
danilosUrsinha, where's your branch so I can see how the test is failing as well :)19:04
bacEdwinGrubbs: and we are currently doing #1, correct?19:04
EdwinGrubbsbac: The advantage of putting the restriction only in the Choice classes instead of the vocabulary is that it prevents creating new two vocabs when we have orthoganol search criteria. For example, you could use PublicPersonChoice(vocab=ValidTeamOwner) or ParticipatingPersonChoice(vocab=ValidTeamOwner) instead of having two separate vocabs.19:04
Ursinhadanilos, https://code.edge.launchpad.net/~ursinha/launchpad/add-translation-focus/19:05
bacEdwinGrubbs: at the expense of doing more in python than in SQL19:05
EdwinGrubbsbac: actually, we are currently checking the value in both places.19:05
EdwinGrubbsbac: although, you only have to check one value in python, which is not really as expensive as checking all the possible values in SQL.19:06
EdwinGrubbsbac: for the picker search that is.19:07
EdwinGrubbsbac: actually, nevermind that last point, since it only makes sense for private-membership teams which are going away.19:07
bacEdwinGrubbs: if the constraint only lives in the Choice won't we get more situations where an inappropriate team is presented only to be rejected by the constraint?19:07
Ursinhadanilos, I think I know what I did wrong19:08
* jml now gathering data on how long stuff I care about takes19:08
danilosUrsinha, cool19:08
EdwinGrubbsbac: yes, but this does have the advantage of providing the user a clear error as to why the team can't be used, so they don't think the picker is broken when it can't find a team they know exists.19:08
sinzuiHow do I clearsign the new COC for sample person?19:09
Ursinhadanilos, hm, no, false alarm :(19:09
bacEdwinGrubbs: and what will that error look like?  something better than "Constraint not satisfied"?19:09
sinzuidholbach provided a branch to update the COC, but we need a signed version by name12 to pass the test19:10
EdwinGrubbsbac: I remember beuno mentioning at some point that it would be nice if unselectable items showed up in the picker, but it didn't let you click on them, but vocabularies don't really have a system for that built-in.19:10
EdwinGrubbsbac: Yes, I was thinking of "Private teams are not allowed." for users that can see the team, but it will automatically default to "Invalid value" for other users.19:11
EdwinGrubbsbac: The vocab would still filter out teams based on the user's ability to see them, but the Choice would handle whether a private team is an appropriate value for a given field.19:13
bacEdwinGrubbs: I think what you describe sounds well thought-out and a simplification.19:13
EdwinGrubbsbac: cool, so I didn't just waist a bunch of time staring at zope code for no reason.19:14
bacEdwinGrubbs: that would never be wasted time.  well...19:14
Ursinhadanilos, it seems I created a translation_focus property to translations and it wasn't needed :) I guess I complicated what was simple19:21
danilosUrsinha, could be, I tried playing with your branch and hit some issues with my LP tree19:21
Ursinhadanilos, well, fixed, pushed, running tests again19:23
marsjml, check that the subsequent wgets are not returning a 304: Unchanged HTTP status code19:31
* mars <- back to lunch19:31
mrevellnight all :)19:33
=== deryck[lunch] is now known as deryck
EdwinGrubbsbac: I see that ParticipatingPersonChoice only allows private teams and not public or private-membership, however, the docstring says it allows any non-private-membership team.19:37
mwhudsongood morning19:43
jelmerhey mwhudson19:44
mwhudsonjelmer: https://code.edge.launchpad.net/~mwhudson/launchpad/code-import-paranoia/+merge/15467 btw19:44
mwhudsonjelmer: do you manage to test RemoteGitBzrDirFormat at all in bzr-git's tests?19:45
bacEdwinGrubbs: that doesn't sound right19:46
EdwinGrubbsbac: can you look at lib/canonical/launchpad/fields/__init__.py for me?19:46
bacEdwinGrubbs: what you said is not correct19:46
bacEdwinGrubbs: ParticipatingPersonChoice constraint is *not* of is_private_membership19:47
jelmermwhudson, yes, you're right - it's not tested19:47
bacEdwinGrubbs: so it allows private and public19:47
jelmermwhudson: We need more test infrastructure for that19:47
jelmermwhudson, most of the underlying infrastructure is19:47
bacbarry: ping19:48
mwhudsonjelmer: did you see the thread about file:/// urls in the database on launchpad-dev?19:48
mwhudsonit's somewhat related19:48
jelmermwhudson, no, where was that? launchpad-dev?19:48
EdwinGrubbsbac: sorry, I confused myself. It makes sense now.19:48
mwhudsonjelmer: yes19:49
bacEdwinGrubbs: understandable19:49
mwhudsonjelmer: i guess automatically testing bzr-svn over http is pretty challenging :-)19:49
mwhudsoncreate an apache config file, run it, test, tear down the server19:49
mwhudsonbut blearg19:49
mwhudsonjelmer: https://lists.launchpad.net/launchpad-dev/msg01828.html19:50
jmlmwhudson, hello19:52
mwhudsonjml: hello19:52
jmlmwhudson, mthaddon was asking today about memory problems we're having on bazaar.lp.net19:52
jelmermwhudson, I've just replied19:53
jelmermwhudson: bzr-local-test-server provides some help there19:53
jelmerbut it's far from trivial19:53
mwhudsonjelmer: i see19:53
mwhudsonjml: do we know what was using the memory?19:54
jmlmwhudson, lots of bzr processes.19:54
jmlmwhudson, some of them are hours old, which makes mthaddon suspect that bug 260171 has reared its head again19:55
* mwhudson waits for mup19:55
jml'Codehosting server used a lot of memory and not releasing "old" processes'19:55
jmlhttps://bugs.edge.launchpad.net/launchpad-code/+bug/26017119:55
jmlfor some reason it's private19:56
mwhudsonjml: well afaict nothing has changed here19:56
jmlmwhudson, yeah, that's what I was thinking.19:57
jmlmwhudson, which means we still don't know why the memory usage is so high.19:58
jmlmwhudson, or what to do in a situation where we're running dangerously low on memory20:00
mwhudsonjml: yes, i don't have a good answer for that last point20:00
maxbwgrant: You seem to have mislanded a local change into     lp:~launchpad-committers/ubuntu/lucid/python-defaults/ubuntu-unofficial. Mind if I push --overwrite it?20:02
* maxb checks you have the revision in another branch, and does it20:08
marsanyone able to help spot the problem with the following pqm-submit command?  It says I'm "Not authorized to commit to branch": http://paste.ubuntu.com/332582/20:17
marsAnd I included the trailing slash on the --submit-branch this time.20:17
sinzuibac: EdwinGrubbs: I am looking at bug 490224. I recall some decision a long time ago that affected the content-type of downloads, but I do not know the rules.20:18
mupBug #490224: .tar.bz2 download has wrong Content-Type <Launchpad Registry:New> <https://launchpad.net/bugs/490224>20:18
salgadomars, can you do a --dry-run and paste the output?20:18
marssure20:18
marssalgado, http://paste.ubuntu.com/332588/20:20
salgadomars, I think what you want is to remove the trailing slash20:21
marsalright20:21
bacsinzui: looking20:22
EdwinGrubbssinzui: I can't remember any possible root cause for the wrong content-type. What doe20:24
EdwinGrubbssinzui: oops, I was going to ask what does the db row for that file say the content-type is?20:25
sinzuiEdwinGrubbs: I do not know20:26
bacEdwinGrubbs, sinzui: we are using mimetypes.guess_type to figure out the content type20:26
bacsinzui, EdwinGrubbs: for "*.bz2" it returns (None, None) so we default to "text/plain"20:27
sinzuiha ha20:27
bacsinzui: it is in ProductReleaseEditView20:27
sinzuithat sounds familiar. Did we have some hacks to second guess other types?20:28
bacsinzui: sorry, ProductReleaseAddDownloadFileVIew20:28
bacsinzui: if we did we don't now20:28
EdwinGrubbssinzui, bac: it also seems bad that it returns Content-Encoding:gzip when it is already compressed with bz2.20:28
bacbut i don't think we did20:28
=== matsubara is now known as matsubara-afk
wgrantmaxb: Argh, damn, sorry. Must have checked that out rather than branched it.20:29
bacEdwinGrubbs: using 'wget -S' i don't see that Content-Encoding20:29
maxbI guess we should start populating the PPA for lucid :-)20:30
=== salgado is now known as salgado-afk
wgrantmaxb: Right, I've mostly done it in https://launchpad.net/~wgrant/+archive/launchpad20:30
wgrantmaxb: But lucid's pylint is currently uninstallable, and I decided that merging logilab-common at 1am was inadvisable.20:31
bacsinzui, EdwinGrubbs: the mimetypes package for python2.6 returns (None, 'bzip2')20:31
maxbjoy20:31
bacEdwinGrubbs: you have an XXX note about using python-magic.  Was any progress made on that?20:33
sinzuibac: did you init()20:33
bacsinzui: i don't understand?20:33
EdwinGrubbsbac: in which file is the XXX?20:33
sinzuibac:20:34
sinzui>>> mimetypes.init()20:34
sinzui>>> mimetypes.guess_type('file.tar.bz2')20:34
sinzui('application/x-tar', 'bzip2')20:34
bacsinzui: no i did not20:34
EdwinGrubbsbac, sinzui: btw, the odd Content-Encoding:gzip only occurs on HEAD requests, so it is irrelevant.20:34
bacsinzui: but if i do "init()" i get the same results of (None, None)20:35
sinzuioops. We do not call init in the class20:35
bacsinzui: you sure you're using 2.5?20:35
bacEdwinGrubbs: browser/productrelease.py20:35
sinzuiI am using 2.6, but the mimetype.init() requirement is ages old.20:35
maxbwgrant: In order to point out that it's being worked on already, shall I copy your python-{defaults,support} into the launchpad PPA?20:35
bacsinzui: it does not seem to change the results on 2.520:35
sinzuiI see 2.5 is buggered20:36
* sinzui checks 2.420:36
sinzuiWell that's below average20:37
bacsinzui: calling init is not required. it looks like guess_types calls it if not done yet20:37
sinzuiI see it has an inited attr20:38
wgrantmaxb: That's probably a good idea.20:39
sinzuibac: in any case, we either need to update to python 2.6, or hack the Finder and ProductReleaseAddDownloadFileView classes. In all cases we need a db update20:41
bacsinzui: why a db update?20:41
maxbdone. I'll ignore the no-change rebuilds for now20:41
maxbunless you think otherwise20:42
sinzuibecause all the bz2 files uploaded via the View are the wrong content type20:42
sinzuibac: Finder defaults to application/octet-stream20:42
bacsinzui: ah, you mean we need to update the data we've stored.  right.20:43
bacsinzui: can we install a mimetypes file that includes knowledge of .bz2 and use it when we init mimetypes?20:43
bacsinzui: or just provide a wrapper around it that knows about .bz220:44
sinzuibac: I am not sure what to do.20:48
bacsinzui: perhaps look at the diff in the mimetypes.py from 2.5 and 2.6 and see if we can hack the difference20:50
sinzuiWe are close to getting to 2.620:50
sinzuigary_poster: barry: was there an estimate of effort or time needed to get to 2.6?20:51
barrysinzui: at the time we thought maybe another week or two20:52
bacsinzui: it looks like they just add new entries into suffix_map and encodings_map20:52
barrysinzui: it kind of depends on the dependencies20:52
bacsinzui: i think mimetypes provides means to do that cleanly20:52
gary_postersinzui: we don't plan to move to 2.6 until Lucid unless there is something really compelling20:53
sinzuibac: the easiest is to make the Finder and AddDownloadFile agree that the default is application/octet-stream20:57
bacsinzui: why not x-tar?20:58
bacsinzui: look at the comment in /etc/mime.types20:58
bacsinzui: recall .bz2 and .gz are compression not encodings, so we need to figure out what has been compressed20:59
maxbI was planning to start getting in the residual changes from the python-migration2.6 branch this week, but then I noticed it was week 4, so I figured I might as well do it next week instead20:59
sinzuibac: yes, I agree with you20:59
sinzuibz2 appears to be the only broken type of the common types. I think we can add a rule to set the type to application/x-tar for bz221:01
sinzuibarry: mwhudson: I vaguely recall that we could drop our hacks to urlsplit, urlparse, and safe_hasattr when we switched to python 2.5.21:04
barrysinzui: i think that's right.  i don't remember the details though21:04
* mwhudson doesn't remember anything about this sorry21:05
sinzuibac: I loath to do extensive hacking to fix mimetypes since we will toss it out when we get to 2.621:06
bacsinzui: i agree.  it just depends on the window...21:06
bacsinzui: but will there be others we discover?21:07
sinzuiIf we add up the time to add and remove 2.6 hacks, we may just find that we would save time helping launchpad get to 2.621:07
bacsinzui: probably.  but i still wonder if our users won't always be ahead of the mimetypes package so having the infrastructure in place to update it might be useful.21:08
bacsinzui: BjornT_ would probably know about urlsplit, etc21:09
sinzuibac: excellent argument. We know the ones we must support. we can call init(mimetypes.knownfiles + ['launchpad,mimetypes']) to ensure we do not get regressions21:10
BjornT_bac: i just confirmed that urlparse and friends are fixed in both 2.5.4 and 2.5.2, so we should be able to remove our versions21:11
sinzui\o/21:11
wgrantCan anyone think why bootstrapping LP on lucid would be attempting to grab 'distribute'? I didn't think LP used it at all.22:52
wgrantMy upgraded installation works fine, but bootstrapping a new one fails.22:53
* mwhudson also wonders why launchpad-dependencies doesn't want to install on hardy22:54
wgrantmwhudson: What does it whine about?22:54
wgrantHmm, new dpkg-dev not liking old devscripts, maybe?22:55
mwhudsonwgrant: http://pastebin.ubuntu.com/332660/22:55
wgrantThere was something like that in my previous experiments, but it didn't appear to be a problem here.22:55
mwhudsonwgrant: yes, something very much like that22:55
wgrantmwhudson: Try devscripts from hardy-backports.22:56
* mwhudson wonders if hardy-backports is enabled...22:56
wgrantNot by default.22:56
wgrantAh, EC2. Inconvenient.22:56
mwhudsoni guess there's no wonderful "sudo enable-backports" command?22:57
wgrantmwhudson: Not beyond 'echo "deb http://archive.ubuntu.com/ubuntu hardy-backports main restricted universe multiverse" >> /etc/apt/sources.list'22:58
mwhudsonwgrant: i guess i'll do something like that then22:59
wgrantmwhudson: The devscripts from hardy-backports is indeed new enough to not fall afoul of the new dpkg-dev.23:00
mwhudsonyes, this seems to be Doing Stuff23:00
wgrantmwhudson: If that works, just copy 2.10.39ubuntu2~hardy1 from https://edge.launchpad.net/ubuntu/+archive/primary/+copy-packages?field.name_filter=devscripts&field.status_filter=published&field.series_filter=hardy23:01
mwhudsonwgrant: "copy existing binaries" ?23:03
wgrantmwhudson: Yes.23:03
mwhudsonhm23:03
mwhudsoni wonder if this is going to time out23:03
mwhudsonyes23:04
wgrantIt didn't when I tried it last week :(23:04
wgrantAh, looks like I didn't copy binaries.23:04
* mwhudson confuzzed23:05
wgrantAnyway, I have a train to catch.23:05
mwhudsonnow i get The following source cannot be copied:23:05
mwhudson    * devscripts 2.10.39ubuntu2~hardy1 in hardy (same version already building in the destination archive for Hardy)23:05
mwhudsonwgrant: thanks for the hints so far23:05
wgrantUm.23:05
wgrantOdd.23:05
wgrantOh.23:06
mwhudsonso it looks like the copy was actually ok and the time out was rendering the resulting page23:06
mwhudsonmaybe23:06
wgrantDid it maybe time out while trying to render +copy-packages again?23:06
wgrantRight.23:06
wgrantYeah, it copied fine.23:06
wgrantAnyway, /me leaves.23:06
mwhudsonso i just have to wait until it's published and then we'll be happy23:07
EdwinGrubbssinzui: I sent my response to your review. I could work on an oops bug tonight, if there is something you would like fixed before the rollout.23:19
* sinzui looks.23:24
* maxb wishes LP defaulted to "copy binaries". Deciding to rebuilt already built source ought to be a deliberate choice23:25
sinzuiEdwinGrubbs: We do not have any RC candidates. I see two bugs Bug #230801 and Bug #406751 that I think are short23:29
mupBug #230801: AssertionError triggered renewing team membership <oops> <registry> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/230801>23:29
mupBug #406751: misprint in title of "/@@/maybe" image  <trivial> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/406751>23:29
sinzuiEdwinGrubbs: neither needs to be done this week23:29
* mwhudson watches x11 being installed on the ec2 image23:36
mwhudsonthat's a little odd23:36
mwhudsonhm, only x11-common23:36
EdwinGrubbssinzui: I'll look into the first one23:45
=== EdwinGrubbs is now known as Edwin-afk
* mwhudson lunches23:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!