[01:58] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/fix-date-review-requested/+merge/15464 anyone?
[01:59]  * mwhudson looks
[01:59] <thumper> mwhudson: thanks
[02:38] <mwhudson> thumper: will sort_order now always be non-None?
[02:38] <thumper> mwhudson: yes
[02:38] <mwhudson> it seems like it would be if you could create a review in the WIP state
[02:39] <thumper> mwhudson: but then it wouldn't be in the list
[02:39] <thumper> mwhudson: so it won't need to be sorted
[02:39]  * thumper is heading to get shoes for the girls
[02:39] <thumper> back later
[02:39] <mwhudson> thumper: ah ok
[02:41] <thumper> mwhudson: I could add another fallback to date_created if you think it is worthwhile
[02:41] <mwhudson> thumper: nah
[02:42] <mwhudson> thumper: reviewed 
[02:42] <thumper> ta
[03:20] <mwhudson> thumper: if you get the chance: https://code.edge.launchpad.net/~mwhudson/launchpad/code-import-paranoia/+merge/15467
[10:01] <noodles775> Hey gmb, I assume you're doing bugs RC stuff today and would prefer not to be reviewing non-urgent non RC branches?
[10:07] <gmb> noodles775: Pretty much, yes. I might have a chance to take a look at anything like that later, though.
[10:11] <noodles775> gmb, thanks. There's no rush for this one at all, so just see how you go.
[11:33] <bac> morning gmb
[11:34] <gmb> Hi bac
[11:34] <bac> i'll be reviewing today but not until 1700UTC
[11:37]  * noodles775 pops one in the queue just for whoever has time later (not urgent at all)
[11:40] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/487009-db-generalise-ibuilder-1b/+merge/15477
[12:24] <BjornT_> gmb: can you review this small patch? it's an rc candidate: https://code.edge.launchpad.net/~bjornt/launchpad/choiceedit-click-handler/+merge/15484
[12:24] <gmb> BjornT_: Sure. I'll take a look at it in a couple of minutes.
[12:24] <BjornT_> thanks
[12:27] <gmb> BjornT_: r=me
[12:28] <BjornT_> gmb: thanks!
[12:29] <salgado> https://code.edge.launchpad.net/~stub/launchpad/bug-490239-session-tuning/+merge/15403
[12:29] <salgado> https://code.edge.launchpad.net/~stub/launchpad/auth-mirror-tables/+merge/15414
[12:29] <salgado> gmb, it'd be great if you could take the two above ones as well; both are RC candidates
[12:30] <gmb> salgado: Will take a look at those after lunch.
[12:31] <gmb> salgado: Also, https://code.edge.launchpad.net/~gmb/launchpad/indexed-message-parents/+merge/15486 is an RC candidate. adeuring is reviewing it now.
[12:31] <gmb> salgado: It's a fix for bug 394097
[12:31] <mup> Bug #394097: accessing message 0 of bug 371281 gives wrong return type of IMessage <api> <bug-page> <oops> <Launchpad Bugs:Triaged by allenap> <https://launchpad.net/bugs/394097>
[12:31] <salgado> gmb, cool, thanks for fixing that one!
[12:32] <gmb> salgado: Working it out was mostly allenap's work, I assure you. I just contributed the patch to stop it from happening.
[12:33] <gmb> salgado: Do you want me to request the rc review now or wait until adeuring is done with it?
[12:33] <salgado> gmb, it's ok to request it now
[12:33] <gmb> Ok
[12:34] <gmb> ARGH, bloody person picker.
[12:34] <gmb> salgado: Requested. Doesn't say "RC" but I think you can work that out.
[12:34] <salgado> yep, I can
[12:35] <gmb> adeuring: Note: the docstring for TestBugIndexedMessages is bong; fixing it now.
[13:39] <salgado> gmb, do you still need an RC review for https://code.edge.launchpad.net/~gmb/launchpad/bugzilla3.4-see-also-bug-419134/+merge/15404 ?
[13:39] <gmb> salgado: No; QAing was too much of a pain, so we'll find a better way to do QA and CP it later.
[13:39] <gmb> (If absolutely necessary)
[13:40] <salgado> ok
[14:15] <gmb> salgado: I've made the cahnges you requested.
[14:16] <gmb> Hurrah for branches that are all removals.
[14:19] <gmb> Boo for branches that contain sampledata changes
[14:19] <gmb> salgado: Should I land my branch on devel or db-devel?
[14:19] <salgado> gmb, devel
[14:20] <gmb> Cool
[14:26] <gmb> salgado: I'm a little leery of approving https://code.edge.launchpad.net/~stub/launchpad/auth-mirror-tables/+merge/15414. Not because I don't think it looks right - so far, so good - but I don't have the SQL nouse to spot errors, I suspect.
[14:29] <salgado> gmb, I know how that feels, but I find it unlikely we have much people that can spot errors on SQL written by our DBA
[14:29] <gmb> salgado: Heh. Fair point. Just wanted to make you aware of it :)
[15:30] <gmb> noodles775: r=me with a few minor changes.
[15:30] <noodles775> Thanks gmb!
[15:30] <gmb> np
[18:38] <bac> salgado: do you want to have a look at https://code.edge.launchpad.net/~thumper/launchpad/fix-date-review-requested/+merge/15464
[18:41] <salgado> bac, sure, I'll review it later
[20:03] <bac> salgado: another: https://code.edge.launchpad.net/~stub/launchpad/auth-mirror-tables/+merge/15414
[20:03] <salgado> bac, reviewing that one right now. :)
[20:03] <bac> salgado: great.  just doing clean up.
[23:12] <ursula> bac, hi :)
[23:13] <bac> hi ursula
[23:14] <ursula> oh :(
[23:14] <bac> ursula: what's up?
[23:15] <bac> ursula: you have a review?  np
[23:19] <bac> ursula: at line 53 of the diff, please factor out the test for 'if product_series'
[23:22] <ursula> bac, let me see
[23:22] <bac> ursula: this isn
[23:22] <bac> ursula: this isn't for an RC is it?
[23:23] <ursula> bac, nope, I just wanted to have a review before going on vacations
[23:23] <bac> ursula: ok
[23:23] <bac> that code change is one thing
[23:24] <ursula> bac, what do you mean by factor out the test?
[23:24] <bac> ursula: does this new field show up in the UI?
[23:25] <bac> ursula: i mean:
[23:25] <bac> if product_series is not None:
[23:25] <bac>      if blah:
[23:25] <bac>        do something
[23:25] <ursula> ah, ok :)
[23:25] <bac>     elif
[23:25] <bac>     do something else
[23:26] <bac> ursula: so how is this field set?  is it in the UI?
[23:26] <ursula> bac, yes, in the +changetranslators one
[23:26] <ursula> I think I mentioned that in the MP..
[23:27] <bac> ursula: right, i see that now.
[23:28] <bac> ursula: you're going to need some tests for this.  a doc test, a story, and webservice too.
[23:28] <ursula> bac, I see
[23:29] <ursula> bac, well, I guess I'll have to do that when I return... or someday in this meantime
[23:29] <bac> ursula: ok.  sorry.
[23:32] <bac> ursula: you'll also need a schema change, no?
[23:32] <bac> ursula: which will require a db review from jml and stub.
[23:33] <ursula> bac, already did that, in a separated branch, that has already landed
[23:33] <bac> ursula: excellent!
[23:34] <ursula> bac, do you know an example so I can write the tests that are missing?
[23:34] <ursula> I'll try to do that while I wait at the airport
[23:36] <bac> ursula: i'd look at how some of the companion fields are tested, like translationpermission
[23:37] <bac> ursula: that should give you an idea.
[23:37] <ursula> bac, awesome, thanks muchly
[23:37] <bac> ursula: have a nice vacation!