[01:58] https://code.edge.launchpad.net/~thumper/launchpad/fix-date-review-requested/+merge/15464 anyone? [01:59] * mwhudson looks [01:59] mwhudson: thanks [02:38] thumper: will sort_order now always be non-None? [02:38] mwhudson: yes [02:38] it seems like it would be if you could create a review in the WIP state [02:39] mwhudson: but then it wouldn't be in the list [02:39] mwhudson: so it won't need to be sorted [02:39] * thumper is heading to get shoes for the girls [02:39] back later [02:39] thumper: ah ok [02:41] mwhudson: I could add another fallback to date_created if you think it is worthwhile [02:41] thumper: nah [02:42] thumper: reviewed [02:42] ta [03:20] thumper: if you get the chance: https://code.edge.launchpad.net/~mwhudson/launchpad/code-import-paranoia/+merge/15467 [10:01] Hey gmb, I assume you're doing bugs RC stuff today and would prefer not to be reviewing non-urgent non RC branches? [10:07] noodles775: Pretty much, yes. I might have a chance to take a look at anything like that later, though. [10:11] gmb, thanks. There's no rush for this one at all, so just see how you go. === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: - || queue [] || Currently reviewing urgent and RC branches only || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === matsubara-afk is now known as matsubara [11:33] morning gmb [11:34] Hi bac [11:34] i'll be reviewing today but not until 1700UTC === noodles775 changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: - || queue [noodles] || Currently reviewing urgent and RC branches only || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [11:37] * noodles775 pops one in the queue just for whoever has time later (not urgent at all) [11:40] https://code.edge.launchpad.net/~michael.nelson/launchpad/487009-db-generalise-ibuilder-1b/+merge/15477 [12:24] gmb: can you review this small patch? it's an rc candidate: https://code.edge.launchpad.net/~bjornt/launchpad/choiceedit-click-handler/+merge/15484 [12:24] BjornT_: Sure. I'll take a look at it in a couple of minutes. [12:24] thanks [12:27] BjornT_: r=me [12:28] gmb: thanks! [12:29] https://code.edge.launchpad.net/~stub/launchpad/bug-490239-session-tuning/+merge/15403 [12:29] https://code.edge.launchpad.net/~stub/launchpad/auth-mirror-tables/+merge/15414 [12:29] gmb, it'd be great if you could take the two above ones as well; both are RC candidates [12:30] salgado: Will take a look at those after lunch. === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: - || queue [stub(rc), stub(rc), noodles] || Currently reviewing urgent and RC branches only || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [12:31] salgado: Also, https://code.edge.launchpad.net/~gmb/launchpad/indexed-message-parents/+merge/15486 is an RC candidate. adeuring is reviewing it now. [12:31] salgado: It's a fix for bug 394097 [12:31] Bug #394097: accessing message 0 of bug 371281 gives wrong return type of IMessage

[12:31] gmb, cool, thanks for fixing that one! [12:32] salgado: Working it out was mostly allenap's work, I assure you. I just contributed the patch to stop it from happening. [12:33] salgado: Do you want me to request the rc review now or wait until adeuring is done with it? [12:33] gmb, it's ok to request it now [12:33] Ok [12:34] ARGH, bloody person picker. [12:34] salgado: Requested. Doesn't say "RC" but I think you can work that out. [12:34] yep, I can [12:35] adeuring: Note: the docstring for TestBugIndexedMessages is bong; fixing it now. [13:39] gmb, do you still need an RC review for https://code.edge.launchpad.net/~gmb/launchpad/bugzilla3.4-see-also-bug-419134/+merge/15404 ? [13:39] salgado: No; QAing was too much of a pain, so we'll find a better way to do QA and CP it later. [13:39] (If absolutely necessary) [13:40] ok === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell [14:15] salgado: I've made the cahnges you requested. === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: stub(rc) || queue [stub(rc), noodles] || Currently reviewing urgent and RC branches only || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: stub(rc) || queue [noodles] || Currently reviewing urgent and RC branches only || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [14:16] Hurrah for branches that are all removals. [14:19] Boo for branches that contain sampledata changes [14:19] salgado: Should I land my branch on devel or db-devel? [14:19] gmb, devel [14:20] Cool [14:26] salgado: I'm a little leery of approving https://code.edge.launchpad.net/~stub/launchpad/auth-mirror-tables/+merge/15414. Not because I don't think it looks right - so far, so good - but I don't have the SQL nouse to spot errors, I suspect. [14:29] gmb, I know how that feels, but I find it unlikely we have much people that can spot errors on SQL written by our DBA [14:29] salgado: Heh. Fair point. Just wanted to make you aware of it :) === matsubara is now known as matsubara-lunch === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: noodles || queue [] || Currently reviewing urgent and RC branches only || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === noodles775_ is now known as noodles775 [15:30] noodles775: r=me with a few minor changes. === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: - || queue [] || Currently reviewing urgent and RC branches only || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [15:30] Thanks gmb! [15:30] np === salgado is now known as salgado-lunch === gmb changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === salgado-lunch is now known as salgado === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === deryck is now known as deryck[lunch] [18:38] salgado: do you want to have a look at https://code.edge.launchpad.net/~thumper/launchpad/fix-date-review-requested/+merge/15464 [18:41] bac, sure, I'll review it later === danilo_ is now known as danilos === deryck[lunch] is now known as deryck [20:03] salgado: another: https://code.edge.launchpad.net/~stub/launchpad/auth-mirror-tables/+merge/15414 [20:03] bac, reviewing that one right now. :) [20:03] salgado: great. just doing clean up. === matsubara is now known as matsubara-afk === salgado is now known as salgado-afk === sinzui changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [23:12] bac, hi :) [23:13] hi ursula === bac changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [23:14] oh :( [23:14] ursula: what's up? [23:15] ursula: you have a review? np [23:19] ursula: at line 53 of the diff, please factor out the test for 'if product_series' [23:22] bac, let me see [23:22] ursula: this isn [23:22] ursula: this isn't for an RC is it? [23:23] bac, nope, I just wanted to have a review before going on vacations [23:23] ursula: ok [23:23] that code change is one thing [23:24] bac, what do you mean by factor out the test? [23:24] ursula: does this new field show up in the UI? [23:25] ursula: i mean: [23:25] if product_series is not None: [23:25] if blah: [23:25] do something [23:25] ah, ok :) [23:25] elif [23:25] do something else [23:26] ursula: so how is this field set? is it in the UI? [23:26] bac, yes, in the +changetranslators one [23:26] I think I mentioned that in the MP.. [23:27] ursula: right, i see that now. [23:28] ursula: you're going to need some tests for this. a doc test, a story, and webservice too. [23:28] bac, I see [23:29] bac, well, I guess I'll have to do that when I return... or someday in this meantime [23:29] ursula: ok. sorry. [23:32] ursula: you'll also need a schema change, no? [23:32] ursula: which will require a db review from jml and stub. [23:33] bac, already did that, in a separated branch, that has already landed [23:33] ursula: excellent! [23:34] bac, do you know an example so I can write the tests that are missing? [23:34] I'll try to do that while I wait at the airport [23:36] ursula: i'd look at how some of the companion fields are tested, like translationpermission [23:37] ursula: that should give you an idea. [23:37] bac, awesome, thanks muchly [23:37] ursula: have a nice vacation! === EdwinGrubbs is now known as Edwin-afk