[10:17] <henninge> noodles775: Hi! could you do a ui review for bug 425583?
[10:17] <mup> Bug #425583: Improve language set index page <post-3-ui-cleanup> <Launchpad Translations:Triaged> <https://launchpad.net/bugs/425583>
[10:18] <henninge> noodles775: the bug has a mockup attached to it, there is no branch or mp yet.
[10:18] <noodles775> henninge: sure.
[10:18] <henninge> Seeing how this release week is a quiet one for you ... ;-)
[10:19] <noodles775> henninge: I don't suppose I can do a swap with you?
[10:19] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/487009-db-more-soyuz-extraction/+merge/15533
[10:19] <henninge> noodles775: sure you can ;)
[10:20] <noodles775> Thanks!
[10:53] <noodles775> henninge: ok, done. It looks great! I added a few thoughts that came up as I thought about interacting with it.
[10:54] <henninge> noodles775: cool, I'll look at it in a minute
[10:54] <henninge> noodles775: about your branch
[10:55] <henninge> without wanting to check each line, I trust that the code moved to dispatchBuildToSlave, verifyBuildRequest, _cachePrivateSourceOnSlave, _extraBuildArgs was copied verbatim?
[10:55] <noodles775> Almost verbatim, I had to check all references to self, so that self.url would become self._builder.url.
[11:00] <henninge> noodles775: and you had to add a call to _extraBuildArgs
[11:02] <noodles775> henninge: The extra build arguments used to be created in startBuild(), so yes, I copied that code out into BinaryPackageBuildBehavior._extraBuildArgs() and called it from the specific dispatchBuildToSlave instead.
[11:04] <henninge> noodles775: I am trying to decide if this is a pure refactoring branch or if it adds functionality that would need tests.
[11:04] <henninge> noodles775: what about the new code for IdleBuildBehavior?
[11:06] <noodles775> henninge: yep, as mentioned in the MP, I'm going to add some documentation for the build behavior infrastructure in the next branch, but I've certainly tried to ensure that I'm not adding any new functionality to IBuilder in this branch, just pure refactoring.
[11:06] <henninge> noodles775: also the return value of "status" is not demonstrated/tested.
[11:07] <henninge> noodles775: ah, I see
[11:10] <noodles775> henninge: so, the current behavior of the status property is tested in doc/builder.txt (not exhaustively), and I've tried to ensure that I haven't modified its behaviour.
[11:10] <noodles775> But without a doubt, it could be better tested.
[11:17] <henninge> noodles775: oh, I missed that that is moved code, too. Found it now at the end of the patch ;)
[11:18] <noodles775> Ah, great :D
[11:18] <noodles775> Note, in that case it's split code, rather than moved.
[11:18] <henninge> noodles775: let me just verify that the test is really passing and then you're good to go
[11:18] <noodles775> Ta!
[11:19] <henninge> yes, the 'Idle' went to the Idle...Behavior
[11:27] <henninge> noodles775: done r=me
[11:27] <noodles775> Thanks henninge !
[11:28] <salgado> allenap, do you plan to write a windmill test for your fix to bug 489342?
[11:28] <mup> Bug #489342: "'display_name' is undefined" JavaScript error on development <javascript> <Launchpad Bugs:In Progress by allenap> <https://launchpad.net/bugs/489342>
[11:28] <allenap> salgado: Maybe, but I don't really know where to start right now, and I want to get it landed ;)
[11:29] <allenap> salgado: I can promise to write a test and do manual QA for the release.
[11:29] <allenap> If that's okay with you.
[11:29] <salgado> allenap, that's ok, yes, but can you file a bug for the missing test so that we don't forget about it?
[11:30] <allenap> salgado: Certainly. Thanks.
[11:30] <allenap> salgado: I'll go land now.
[11:30] <salgado> allenap, please land on db-devel
[11:30] <allenap> salgado: Sure.
[11:30] <salgado> I need to get devel closed
[11:32] <allenap> salgado: Gah! I just submitted it and it's gone in for devel.
[11:33] <allenap> salgado: I can resubmit to db-devel if you want to close devel.
[11:33] <salgado> allenap, delete the branch from LP
[11:34] <allenap> salgado: Okay.
[11:34] <salgado> or push --overwrite a 'devel' branch on top of it
[11:34] <salgado> and then resubmit
[11:35] <salgado> seems to have worked
[11:40] <henninge> noodles775: thanks for your comment on the languages page. I just replied to it.
[12:37] <salgado> allenap, stub's got a RC branch up for review, can you take it?
[12:37] <salgado> https://code.edge.launchpad.net/~stub/launchpad/opstats-nodb/+merge/15543
[12:49] <mars> allenap, ping, would you be able to review a brief set of fixes to the JS unit test suite?  https://code.launchpad.net/~mars/launchpad/fix-js-unittests/+merge/15546
[13:34] <allenap> salgado: Sure
[13:34] <allenap> mars: Sure.
[13:46] <allenap> salgado, stub: r=me
[15:29] <EdwinGrubbs> allenap: would you like me to take mars' branch?
[15:29] <allenap> EdwinGrubbs: I did it already, sorry.
[15:30] <EdwinGrubbs> you shouldn't be sorry. I should be thanking you for saving me work.
[15:30] <mars> lol
[15:30] <mars> allenap, thanks for the review
[15:30] <allenap> Heh :)
[15:31] <allenap> mars: Welcome :)
[16:47] <deryck> allenap or EdwinGrubbs -- I have a simple js unit test fix.  30 line diff.
[16:47] <deryck> https://code.edge.launchpad.net/~deryck/launchpad/fix-me-too-unit-test-491441/+merge/15561
[16:47] <EdwinGrubbs> deryck: I can take it.
[16:48] <deryck> EdwinGrubbs, cool, thanks.
[16:49] <EdwinGrubbs> deryck: I assume this is not an RC candidate.
[16:49] <deryck> EdwinGrubbs, no, it's not.
[16:49] <deryck> Just want it ready when pqm opens is all.
[16:49] <deryck> simple fix, so catch it while I can.
[19:42] <gary_poster> EdwinGrubbs: you have time for a testfix/reroll candidate?  https://code.edge.launchpad.net/~gary/launchpad/opstats-nodb/+merge/15569
[19:44] <EdwinGrubbs> gary_poster: sure, looking now
[19:47] <EdwinGrubbs> gary_poster: r=me
[19:50] <gary_poster> thank you