[02:16] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/lp-code-errors/+merge/15724
[04:06] <thumper> and now https://code.edge.launchpad.net/~thumper/launchpad/claim-review-into-model-attempt2/+merge/15728
[07:37] <adiroiban> henninge: hi. is the submission now open?
[07:39] <henninge> adiroiban: yes, channel topic on #lp-dev says "PQM is open for srs bsns" ;-)
[07:39] <henninge> Good morning adiroiban :)
[07:40] <adiroiban> srs bsns ? Serious Business ?
[07:40] <henninge> correct
[07:41] <adiroiban> does it mean any kind of MP ?
[07:41] <henninge> our losas, aren't they just a funny bunch ? ;-)
[07:42] <henninge> adiroiban: yes, the other states are "closed", which was last week, and "testfix" which may happen anytime when the test suite breaks on the buildbot.
[07:43] <adiroiban> henninge: I see. That make sense now :) 
[07:46] <adiroiban> henninge: will you "land" my branch , or is there something I need to do?
[07:49] <henninge> adiroiban: hang on, let me check on the situation
[07:54] <henninge> adiroiban: please merge the current devel into your branch and push it again.
[07:56] <henninge> adiroiban: like this: http://paste.ubuntu.com/336365/
[07:57] <adiroiban> henninge: much appreciated :)
[07:57] <henninge> watch for merge conflicts
[08:05] <adiroiban> henninge: and I should create a new MP ?
[08:05] <henninge> adiroiban: no
[08:06] <henninge> adiroiban: if you didn't have any serious merge conflicts, we can just land it.
[08:06] <henninge> adiroiban: what was the branch again?
[08:06] <adiroiban> https://code.edge.launchpad.net/~adiroiban/launchpad/bug-97293/+merge/15391
[08:06] <adiroiban> there were only 2 lines of code :)
[08:07] <adiroiban> from bzr merge -> All changes applied successfully.
[08:09] <henninge> cool
[08:09] <adiroiban> branch was pushed
[08:09] <henninge> adiroiban: a, I remember
[08:10] <henninge> adiroiban: yup got. Ok, nothing else for you to do now, I will land it.
[08:11] <adiroiban> henninge: thanks. An for the other one I should do the same merge and ping the person who told me that will land the branch?
[08:11] <henninge> adiroiban: just ping me
[08:11] <henninge> after the pushing
[08:11] <adiroiban> ok
[08:15] <adiroiban> henninge: https://code.edge.launchpad.net/~adiroiban/launchpad/bug-193750 merged...
[08:15] <adiroiban> should I give you the full link to the branch  or to the MP, or just the MP number?
[08:17] <henninge> adiroiban: all good, I got it.
[08:17] <henninge> ;)
[08:18] <adiroiban> henninge: :) ... another one https://code.edge.launchpad.net/~adiroiban/launchpad/bug-487970/+merge/15250
[08:26] <adiroiban> henninge: last one: https://code.edge.launchpad.net/~adiroiban/launchpad/bug-135008/+merge/15347
[08:27] <henninge> adeuring: wow, you have been busy! Great job!
[08:30] <henninge> adiroiban: ah, one more thing you can do: Add a commit message to each mp!
[08:31] <henninge> that way I don't have to make them up  ... ;)
[08:31] <adiroiban> henninge: hm... how?
[08:31] <adiroiban> :)
[08:31] <henninge> adiroiban: simply click on "Set commit message" :)
[08:31] <henninge> It's a new feature!
[08:32] <henninge> adiroiban: It's a green line starting with a (+) icon.
[08:32] <adiroiban> Ah... it was just my nose covering that link :)
[08:32] <henninge> lol
[08:33] <adiroiban> got it
[08:33] <adiroiban> and what should I write there?
[08:34] <henninge> it's just a bzr commit message to use when your  branch is merged and commit into devel.
[08:35] <henninge> so you can probably just copy something you used for your local commits.
[08:35] <adiroiban> yes. thanks
[08:35] <henninge> "copying plural values will also enable the required fields"
[08:35] <henninge> adiroiban: But make it proper sentences, please. ;)
[08:35] <henninge> "Copying plural values will also enable the required fields."
[08:46] <adiroiban> henninge: done for all 4 MPs
[08:46] <henninge> adiroiban: cool, thanks. You are, done. I'll keep you posted on the proress during the day.
[08:48] <adiroiban> henninge: thanks. I will also need a pre-MP review for https://code.edge.launchpad.net/~adiroiban/launchpad/bug-431249
[08:49] <adiroiban> should I ask it on lp-reviews or via the bug tracker?
[08:51] <henninge> adiroiban: no, using the bug tracker for code reviews is not what we do.
[08:51] <henninge> adiroiban: asking here or directly one of the lp developers is what you should do.
[08:52] <adiroiban> henninge: here or on lp-dev ?
[08:52] <henninge> adiroiban: Incidently I am an on-call reviewer (OCR) today.
[08:52] <henninge> ;)
[08:52] <henninge> adiroiban: "here" is #lp-reviews
[08:53] <henninge> but I am also Help contact and currently busy landing some great contributions submitted by a cool community member ... ;-)
[08:54] <adiroiban> OCRs are also doing pre-MPs reviews ?
[08:54] <adiroiban> sorry for all these questions... but I'm lost in this process
[09:24] <henninge> adiroiban: first one's in! http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9977
[09:24] <henninge> adiroiban: the others will take longer, though. I did not run this through the test suite since it does not yet run javascript tests.
[09:25] <henninge> I just ran the tests locally and submitted directly.
[09:25] <adiroiban> henninge: ok. np. thanks
[09:30] <henninge> adiroiban: was this your first contribution to Launchpad?
[09:32] <adiroiban> henninge: yep. 2 lines ... like 0.02$ :)
[09:33] <henninge> adiroiban: Well, Congratulations!
[09:33] <henninge> ;-)
[10:16] <danilos> adiroiban, henninge: hi :)
[10:16] <adiroiban> danilos: hi :D
[10:16] <henninge> hi danilos!
[10:17] <adiroiban> danilos: I would need a quick review for this branch so see if I should push it to a MP https://code.edge.launchpad.net/~adiroiban/launchpad/bug-431249
[10:18] <danilos> adiroiban, I've seen you looked into a gazillion of bugs :) I'll be going through them and commenting; in general, I suggest you talk about the bugs beforehand (i.e. before starting on them), just to make sure you are not wasting your time if we disagree what the solution should be
[10:18] <danilos> adiroiban, sure, looking at bug 431249
[10:18] <mup> Bug #431249: Put navigation links in a seperate template/macro. <post-3-ui-cleanup> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/431249>
[10:20] <adiroiban> danilos: i agree... but the goal of all those bugs was to get into the code. Even if that work will not be used, I still learnt how to hack LP
[10:20] <danilos> adiroiban, sure :)
[10:20] <danilos> adiroiban, I am not saying it's not great, just giving an advance notice :) it's possible they are all doing exactly as desired :)
[10:21] <adiroiban> danilos: so you can consider this is the pre implementation discussion. I was aware of this risk
[10:21] <adiroiban> there is no problem if that code will not be used... as you can see, I start working on some bugs that were not even confirmed
[10:22] <danilos> adiroiban, right, bug 431249 fix looks reasonable; I'd still keep the page ID something like "translation-macros", even though it's registered only on TranslationsLayer, because this might hide a generic +macros if it exists
[10:22] <mup> Bug #431249: Put navigation links in a seperate template/macro. <tech-debt> <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/431249>
[10:22] <danilos> (or if it's created in the future)
[10:22] <danilos> adiroiban, otherwise, it looks like a good approach, so, provided there are sufficient tests, go for it :)
[10:22] <adiroiban> danilos: ok. I can change that
[10:23] <adiroiban> danilos: should I add more test ? 
[10:23] <danilos> adiroiban, not necessarily, only add a test if there's not any one testing the generic presence of these links on both pages - do not go through all the conditional tests etc.
[10:23] <adiroiban> those changes should not touch any „visible” part
[10:24] <adiroiban> aha. ok
[10:24] <danilos> adiroiban, right, so, it's two options: find existing test or write one :) former is usually simpler :)
[10:24] <danilos> adiroiban, btw, did you get help from Henning about landing your already approved branches?
[10:25] <adiroiban> danilos: yep. everhing is ok.
[10:26] <adiroiban> danilos: the other feedback I'm asking is about this one: https://code.edge.launchpad.net/~adiroiban/launchpad/bug-406477
[10:29] <danilos> adiroiban, looking
[10:32] <danilos> adiroiban, in general, it's fine; however, I'd rather structure those permissions differently, and make use of launchpad.TranslationsAdmin permission for this role instead of using launchpad.Admin (though, note that you'd have to change .zcml in that case as well, perhaps even some templates something/required:launchpad.Admin conditions)
[10:33] <danilos> adiroiban, but, if you want to keep it simple, just go with what you've got (what I am suggesting is simply because the current state of privileges/permissions in LP is a bit of a mess, and I'd like to clean it up :)
[10:34] <adiroiban> danilos: I can look into that. This was my first look at LP privilege system, and I just wanted to make sure I got it right.
[10:37] <adiroiban> danilos: thanks. This should could keep me bussy for some time :)
[10:39] <danilos> adiroiban, heh, nah, thank you :)
[11:55] <salgado> henninge, trivial one for you: http://paste.ubuntu.com/336479/
[11:56] <henninge> salgado: what is that file for?
[11:56]  * henninge is reading the file ... ;)
[11:56] <salgado> yeah, the heading there says it all
[11:57] <henninge> salgado: so, I wonder why this was able to land, then?
[11:57] <henninge> salgado: r=me, of course ;)
[11:57] <salgado> henninge, because PQM doesn't run the testsuite?
[11:58] <henninge> salgado: ;) I see it now ...
[12:00] <henninge> salgado: did you see my r=me ?
[12:00] <salgado> henninge, yep, thanks!
[12:02] <henninge> adeuring: Hi!
[12:02] <adeuring> hi henninge
[12:02] <henninge> adeuring: Did you land a branch for Adi this morning?
[12:03] <adeuring> henninge: yes
[12:03] <adeuring> lp:bug-192750
[12:03] <henninge> adeuring: ok, I have the same branch in ec2 for him. I think he wasn't aware that you were going to do that, too.
[12:04] <adeuring> henninge: then you can kill the ec2 instance, I think
[12:04] <henninge> adeuring: oh yeah, np with that
[12:04] <henninge>  I was just wondering what happened
[12:06] <henninge> adeuring: it's bug 19-3-750, though. 
[12:06] <mup> Bug #19: "Display settings" forgotten when "Save" is pressed <Launchpad Translations:Fix Released by daf> <https://launchpad.net/bugs/19>
[12:06] <henninge> mup: bug 193750
[12:06] <mup> Bug #193750: remove references to +addticket <trivial> <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/193750>
[12:06] <adeuring> henninge: yes
[12:27] <salgado> henninge, I have yet another trivial one for you: http://paste.ubuntu.com/336490/
[12:27] <salgado> this one reverts a couple changes I committed to mainline by accident
[12:29] <henninge> salgado: I guess it's too early in the morning for you! ;)
[12:29] <henninge> s/is/was/
[12:30] <salgado> yeah, today didn't start very well
[12:32] <henninge> salgado: shouldn't this patch be the other way round?
[12:32] <henninge> I just compared it to the patch you want to revert.
[12:32] <salgado> henninge, yes, the other way around is what I'm committing, sorry
[12:33] <salgado> I applied it with -R, but gave you the original diff, where the change was introduced
[12:33] <salgado> http://paste.ubuntu.com/336495/ is the correct one
[12:33] <henninge> salgado: cool, r=me
[12:34] <salgado> thanks henninge-lunch 
[13:14] <henninge> Hi mrevell !
[13:14] <mrevell> hi henninge
[13:14] <henninge> mrevell: Do you know what help@lp.net points to?
[13:15] <mrevell> henninge, yes, it points to feedback@launchpad.net
[13:16] <henninge> mrevell: sure? I got an email this morning addressed to me an to help but I only saw one copy.
[13:17] <henninge> I am subscribed to feedback.
[13:17] <mrevell> henninge, let me checl
[13:17] <mrevell> s/checl/check
[13:19] <henninge> mrevell: nm, I checked, too. The other one'sin the bin ...
[13:19] <mrevell> henninge, I don't see anything in the queue
[13:19] <henninge> sorry
[13:20] <henninge> argh!
[13:20] <henninge> no, that's not it
[15:23] <EdwinGrubbs> abentley: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-433809-picker-search-slash/+merge/15674
[15:23] <abentley> EdwinGrubbs: Okay
[15:24] <noodles775> henninge or abentley: could either of you review an incremental to an MP which was approved last cycle (but not landed?). See my last comment at:
[15:24] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/443353-api-builds-from-private/+merge/14896
[15:24] <henninge> noodles775, abentley: Sorry, got my hands full on CHR.
[15:24] <noodles775> np, it's not urgent.
[15:25] <abentley> noodles775: I'll queue it.
[15:25] <noodles775> Thanks abentley 
[15:26] <abentley> EdwinGrubbs: In the future, you can set db-devel as the prerequisite branch and still propose merging into devel.
[15:28] <noodles775> oh, abentley, on that note, I've got a pipeline of MPs that were approved, but are all proposed for db-devel (as they were dependent on schema changes). I'm keen to land them now in devel. What would you recommend as the best way?
[15:29] <noodles775> (I'm about to just aggregate all the changes into a new devel branch, propose it as an MP and link to the previous approvals before ec2 land'ing it).
[15:29] <abentley> noodles775: Personally, I would land the last pipe on devel using pqm-submit.
[15:30] <abentley> noodles775: I'm not sure whether ec2 land will allow you to override the target.  I would assume not.
[15:30] <noodles775> abentley: ok, I'll try that. Thanks!
[15:30] <noodles775> (once I've QA'd it on dogfood etc.)
[15:31] <abentley> noodles775: No problem.  (this implies you'll need to run the tests if you haven't already)
[15:31] <noodles775> abentley: yes, I'll re-merge db-devel, run the tests, QA on dogfood, and if all goes well land that branch on devel.
[15:32] <abentley> noodles775: I would recommend merging devel rather than db-devel.
[15:56] <abentley> noodles775: I'm concerned because this diff includes a lot of changes that don't seem to be in scope, e.g. YUI -> LPS.
[15:58] <noodles775> abentley: I'm not sure why you say not in scope? The core change of the branch was to getBuildsForSources() - which affected the UI as outlined in the incremental?
[15:59] <abentley> noodles775: Your incremental diff doesn't show the YUI -> LPS change.
[15:59] <noodles775> abentley: LPS?
[16:00] <abentley> noodles775: Look that the preview diff.  It has a bunch of YUI -> LPS changes in it.
[16:02] <noodles775> abentley: ah, you mean the generated diff - I'm assuming that's because I've just merged devel and pushed as you suggested (but the MP is for db-devel).
[16:03] <noodles775> The actual diff for this change is in the comment.
[16:05] <abentley> noodles775-otp: I see.  I didn't realize you'd be asking for review on any of those.
[16:06] <noodles775-otp> abentley: just the incremental. But yes, after I did that, I thought a better option would have been to add a new pipe and do it there.
[16:07] <abentley> noodles775-otp: So to be clear: you actually want to land this on devel, not db-devel.
[16:08] <noodles775-otp> abentley: correct. I had to develop it using db-devel last cycle, but want to land it in devel now.
[16:08] <noodles775-otp> Is there a way to re-target the MP at devel?
[16:09] <abentley> noodles775-otp: No, that would be a different proposal, which makes sense because there are different criteria for landing on devel.
[16:10] <noodles775-otp> abentley: OK (although I can see there would be cases where it matters, but in this case it's really just the diff being reviewed).  I just thought I had memories of using hitchhiker to do it once before.
[16:11] <abentley> noodles775-otp: No, hitchhiker only controls branches.  It doesn't provide a way to manipulate merge proposals.
[16:12] <noodles775-otp> OK. Let me know if I should revert r9893 on that branch then.
[16:12] <abentley> noodles775-otp: Don't worry about it, I'm regenerating the preview diff locally.
[16:13] <noodles775-otp> ok, thanks.
[16:25] <abentley> noodles775-otp: Are both of the finds necessary, or would the second find (for copied binaries) work even if SourcePackagePublishingHistory.archiveID == Build.archiveID ?
[16:35] <noodles775-otp> abentley: hrm, I thought so when I wrote that a few weeks ago, but looking at the two finds now, I'm struggling to see why.
[16:36] <noodles775> BTW: If you're willing to re-review the entire MP, I could create a new MP against devel.
[16:36] <abentley> noodles775: Okay, I don't think it's a blocking issue, but if we can simplify by removing the first find, that would be great.  So r=me, do what you will.
[16:37] <noodles775> abentley: OK, I'll try it and see. Thanks!
[16:41] <abentley> EdwinGrubbs: In case you didn't see earlier, I've bumped your review to the queue because you weren't around to answer my questions.
[16:42] <EdwinGrubbs> abentley: I was only gone for a few minutes and then you were offline so I couldn't respond.
[16:42] <abentley> EdwinGrubbs: Sorry about that, my IRC client doesn't make that very obvious.
[16:43] <abentley> EdwinGrubbs: Okay, so is the conditional needed?
[16:44] <EdwinGrubbs> abentley: do you mean this conditional:     if '/' in query:
[16:45] <abentley> EdwinGrubbs: No, I mean in patch line 100, "if result is not None".
[16:46] <abentley> EdwinGrubbs: It looks like the code should actually read "result = IStore(...).find(...).one(), so that you can raise lookuperror if there were no results.
[16:47] <EdwinGrubbs> abentley: well, I assume the original purpose of that is to provide the LookupError exception as opposed to something more generic. A try/except clause could also be used, but that would be less efficient.
[16:47] <abentley> EdwinGrubbs: I thought find could never return None.  Am I wrong?
[16:49] <EdwinGrubbs> abentley: oh, I see what you are saying. I didn't think about the differences in the return values between sqlobject and storm. I'll test that I'm testing the right return value for an unsuccesful find().
[16:51] <abentley> EdwinGrubbs: Great.  I'll leave the review alone for now.  Please ping me when you've examined that.
[16:51] <EdwinGrubbs> ok
[17:09] <salgado> abentley, I have a one-liner for a testfix branch; can I skip the queue? http://paste.ubuntu.com/336670/
[17:10] <abentley> salgado: I don't know what this LPS thing is.
[17:10] <salgado> abentley, I replaced all YUI() calls with LPS in our templates
[17:11] <salgado> LPS is just a YUI instance, stored globally to be used in templates
[17:11] <abentley> salgado: very well, r=me.
[17:12] <salgado> thanks abentley 
[17:33] <sinzui> abentley: your understanding of translatables not being batched is correct.
[17:34] <adiroiban> salgado: I got an email from Buildbot, but I can not access this link  https://lpbuildbot.canonical.com/builders/lp/builds/405
[17:35] <adiroiban> can you please copy the part describing the build problem?
[17:35] <salgado> adiroiban, no need to worry about it; you got that because my changes caused a test to fail
[17:35] <salgado> I've already fixed the test and submitted it to pqm
[17:36] <adiroiban> salgado: ok. thanks. I was not sure what to do with it :)
[17:44] <danilos> salgado, hey, got a time to take a peek at https://code.edge.launchpad.net/~danilo/launchpad/bug-493629/+merge/15758 (it's a one line change which hopefully fixes the JS buildbot for good, patch by mars actually) - I know you are not OCR, but just so I don't have to wait for abentley to come back from lunch and I can go for dinner :)
[17:46]  * salgado checks the diff
[17:47] <salgado> danilos, r=me
[17:48] <danilos> salgado, thanks
[19:40] <adiroiban> abentley: hi, Can you please review https://code.edge.launchpad.net/~adiroiban/launchpad/bug-431249/+merge/15767 ?
[19:40] <abentley> adiroiban: Okay, I'll have a look in a minute
[19:41] <adiroiban> abentley: thanks.  no hurry :)
[20:00] <abentley> adiroiban: Has this branch been through a complete test suite run?
[20:01] <adiroiban> abentley: nope. Only the translation tests.
[20:01] <adiroiban> on my computer
[20:01] <abentley> adiroiban: It's approved, so let me know when it's been through a complete test suite run, and I'll land it.
[20:02] <adiroiban> abentley: should I run the full test on my computer?
[20:02] <abentley> adiroiban: Yes, that's fine.
[20:03] <adiroiban> on the previous one Henning launched the test on some supercomputer 
[20:03] <adiroiban> running all tests on my computer would take many hours... 
[20:04] <abentley> adiroiban: I run all the tests on my computer.
[20:09] <adiroiban> abentley: thanks. 
[20:10] <abentley> adiroiban: There's no supercomputer, he would have just used Amazon's Elastic Compute Cloud.
[20:10] <adiroiban> can I run the complte test on a remote computer with no X libs? I have a shell account on a remote computer I can configure it for testing my branches
[20:10] <adiroiban> but I'm not sure about testing Javascript
[20:11] <abentley> adiroiban: Yes, I don't think the test suite uses x libs.  The javascript testing isn't integrated into test runs anyhow.
[20:12] <adiroiban> abentley: ok. thanks. Then I'll start configuring that machine.
[20:19] <EdwinGrubbs> abentley: I fixed the handling of the return value from find() and I pasted the incremental diff into https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-433809-picker-search-slash/+merge/15674
[20:21] <abentley> EdwinGrubbs: Cool.  On the phone.
[20:33] <thumper> rockstar: shall I send a few reviews your way?
[20:33] <rockstar> thumper, sure.  Are they urgent?
[20:34] <thumper> thumper: isn't everything?
[20:34]  * thumper facepalms
[20:34] <thumper> rockstar: I'll fire the ui one your way
[20:35] <thumper> rockstar: I just have others that you may be interested in
[20:39] <rockstar> thumper, okay, fire them my way.
[20:40] <thumper> rockstar: this is the ui one https://code.edge.launchpad.net/~thumper/launchpad/hiding-review-fields/+merge/15722
[20:40] <thumper> rockstar: that is just a "get the branch and look at it" type review
[20:41] <thumper> rockstar: and others around the claim/delete review arena:
[20:41] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/claim-review-into-model-browser-integration/+merge/15719
[20:41] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/claim-review-into-model-attempt2/+merge/15728
[20:41] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/delete-pending-reviews/+merge/15739
[23:20] <bac> sinzui: still around?