[00:25] rockstar: how's it going? [00:25] It's going. [00:28] rockstar: I'd like to talk to you about claim/reassign review when you have a mental break [00:28] thumper, okay. [02:58] thumper: want to review this bzr-svn-ui branch? [02:58] mwhudson: sure [03:10] thumper: https://code.edge.launchpad.net/~mwhudson/launchpad/bzr-svn-ui/+merge/15792 [03:10] thumper: were you waiting on any reviews from me? [03:10] mwhudson: no [03:10] mwhudson: rockstar got to them before you :) [03:10] thumper: :-) === stub1 is now known as stub [04:41] thumper: it seems your conditional tag on your approve vote confuses ec2 land :( [04:50] sorry. [04:50] jml: i think it's thumper's fault really ;-) [04:50] * mwhudson eods [04:51] mwhudson, ec2 land should probably embrace Postel's Law. [04:51] mwhudson, g'night. [04:59] mwhudson: why is it my fault? [05:02] thumper: just being silly [07:08] hello [07:08] simple patch up for review [07:08] https://code.edge.launchpad.net/~jml/launchpad/db-revision-bug-487628/+merge/15805 [07:08] danilos, it fixes a bug you filed, so perhaps you might like to do that. [07:21] jml: did you check that the exception text does not appear in any doctest? [07:22] ... and would need to be adapted there. [07:28] henninge, I checked the class name, but not the text itself. I'll check that now. [07:29] henninge, all good. === henninge is now known as henninge-brb [09:31] danilos, can you please take a look at this review https://code.edge.launchpad.net/~adiroiban/launchpad/bug-406477/+merge/15793 ? [09:31] it's about changing launchpad.Admin to launchpad.TranslationsAdmin [09:31] but only if you have time === henninge-brb is now known as henninge === gmb changed the topic of #launchpad-reviews to: on-call: || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [10:59] *sigh* === matsubara-afk is now known as matsubara [11:47] gmb: Fancy a js review? https://code.edge.launchpad.net/~allenap/launchpad/no-display-name-from-api-bug-491334/+merge/15808 [11:48] allenap: Sure. [11:48] gmb: Thank you. === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: allenap || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [11:50] * gmb hates at the whole typeof() != "undefined" bollocks. [11:50] Grr. [11:53] allenap: r=me === gmb changed the topic of #launchpad-reviews to: on-call: gmb || reviewing: lunch || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [11:53] * gmb takes this opportunity to truffle for nourishment [11:55] gmb: Thank you! [11:56] gmb: Agreed, typeof should be taken out back, shot in the head and thrown in the wheelie bin. [11:57] gmb: Actually, I'm going to remove the typeof() again, and replace it with window.LP !== undefined. Referencing it via the window stops it from blowing chunks down the inside of my monitor. === henninge is now known as henninge-lunch === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === bac changed the topic of #launchpad-reviews to: on-call: gmb,bac || reviewing: lunch,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: on-call: gmb,bac || reviewing: lunch,jpds || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: on-call: gmb,bac || reviewing: lunch, jpds || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on-call: gmb, bac || reviewing: -, jpds || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [14:01] Hah, accidentally the longest lunch break evar. [14:02] Morning bac. [14:02] hey gmb === gmb changed the topic of #launchpad-reviews to: on-call: gmb, bac || reviewing: sinzui, jpds || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [14:03] Afternoon bac, gmb. :) [14:03] Hi jpds. [14:03] hi jpds -- just looking at your branch now [14:03] Awesome. [14:04] * gmb is amazed that sinzui's StructuralSubscriptions change is only 641 lines. [14:04] Unless there's a zero missing in the linecount... [14:05] I was too. I was expecting 2000 lines. [14:06] gmb: I think the structuralsubscription link mixin that intellectronica added two releases ago dramatically reduced the number of callsites. [14:06] sinzui: Yeah, I was thinking along the same lines. [14:06] sinzui: r=me, anyway. [14:06] faboo [14:08] jpds: i just tried running your branch and registering a new mirror. it throws an exception because newMirror() doesn't take a whiteboard argument. === gmb changed the topic of #launchpad-reviews to: on-call: gmb, bac || reviewing: -, jpds || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on-call: gmb, bac || reviewing: -, jpds || queue [gmb] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [15:07] bac: When you're free, will you be able to do a JS / Code review for https://code.launchpad.net/~gmb/launchpad/ajax-dupefinder-has-risen-from-the-grave/+merge/15599? [15:07] gmb: sure [15:07] bac: Thanks. === salgado is now known as salgado-lunch === matsubara is now known as matsubara-lunch === bac changed the topic of #launchpad-reviews to: on-call: gmb, bac || reviewing: -, gmb || queue [-] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === salgado-lunch is now known as salgado === gmb changed the topic of #launchpad-reviews to: on-call: bac || reviewing: gmb || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [16:38] bac: I'm going to go afk for a while now but I'll be back later. Feel free to ask any questions you may have in the review and I'll get back to you when I can. [16:38] gmb: ok. sorry i didn't get to it yet. [16:38] bac: No worries. === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: lunch, then gmb || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === matsubara-lunch is now known as matsubara [17:19] bac, hi, can you take a look at https://code.edge.launchpad.net/~danilo/launchpad/bug-494106/+merge/15822? [17:19] bac, when diff shows up, at least :) === danilo_ is now known as danilos [17:20] bac: can you please review this MP: https://code.edge.launchpad.net/~adeuring/launchpad/bug-494075/+merge/15823 ? === deryck is now known as deryck[lunch] [17:24] bac, actually, https://code.edge.launchpad.net/~danilo/launchpad/bug-494106/+merge/15824 for me (the former one was against a wrong LP branch, diff too big) === danilos changed the topic of #launchpad-reviews to: on-call: bac || reviewing: lunch, then gmb || queue [danilo, adeuring] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [17:25] gmb, how about you? :) === deryck[lunch] is now known as deryck === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: gmb || queue [danilo, adeuring] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [18:28] danilos, adeuring: will get to them shortly [18:44] hi gmb === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: adeuring || queue [gmb,] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [19:41] adeuring: your MP has a diff against db-devel at 4K lines. this should be against devel, no? [19:41] bac: yes, sorry for the mess. The real diff should be quite short, 100 lines or so. [19:42] adeuring: i've had quite a lot of problem lately with MPs getting targeted to the wrong branch. [19:43] i wish it was possible to retarget the MP [19:43] adeuring: ah, thanks for letting me know! I already began to question my abilities to properly select radio buttons on web pages ;) [19:44] adeuring: actually i always use 'bzr send' and only use the web ui to make corrections when the wrong target is used [19:45] bac: yeah, I should get used to that too [19:46] bac: anyway, this is the dif again teh devel branch_: http://paste.ubuntu.com/337502/ [19:46] adeuring: thanks === EdwinGrubbs is now known as Edwin-lunch [20:10] bac: Can you look at the changes I've made at https://code.edge.launchpad.net/~jpds/launchpad/fix_196173/+merge/15807 when you have time? Thanks! [20:14] bac: thanks for your review! [20:14] np abel. thanks for the branch [20:20] jpds: the changes look good. i'd like to see doc/distribution-mirror.txt updated to show the whiteboard being set. [20:26] bac: Something like http://pastebin.ubuntu.com/337541/ ? [20:27] jpds: that's good. [20:28] bac: Pushed. [20:32] jpds: do we need to discuss with the mirror administrators the fact that registrants can now see the whiteboard? i assume there are no embarassing comments on the whiteboards but it might be a good heads up that the policy has changed. === matsubara is now known as matsubara-afk [20:34] bac: I checked with spm last night to make sure there was nothing... unpolitical there. [20:34] * jpds → msh. [20:35] s/h$/g/ [20:35] jpds: right, but a message for people going forward might be nice. is there a mailing list for the team you can post to? [20:36] bac: The interested parties are subscribed to the bug report. :) [20:39] jpds: and now there is a comment... [20:39] jpds: nice work. i'll go update the MP to show it approved. do you need me to land it for you? [20:40] I don't think I can operate PQM. [20:40] ok. i'll do it [20:41] Thanks! [20:41] sinzui: will you take a glance at: http://pastebin.ubuntu.com/337544/? let's call it a mid-flight rather than review. === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [gmb,] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [20:42] gmb are you around? [20:47] bac: Oh, and we've operated on the belief that they could already see it: http://spooky.ubuntuwire.org/~jpds/screenshot_002.png - the irony. :( === salgado is now known as salgado-afk [20:51] bac: I like the work done so far. [20:52] bac: how to do propose to test it? verify that our mime-types knows what bz2 is? [20:55] sinzui: oh, i already added a test but forgot to add it to bzr [20:55] sinzui: http://pastebin.ubuntu.com/337558/ [20:58] bac: looks good. [20:58] sinzui: great. i'll make a MP and let you rubber stamp it! [20:59] bac: Yes. I will approve this to land. Do you want to treat the data fix as a separate bug since it needs separate deployment? [21:00] sinzui: yes [21:00] i'll open that now === Edwin-lunch is now known as EdwinGrubbs [22:20] sinzui: i'm beginning to wonder if i took the right approach on the mimetypes fix [22:21] bac: do you want to load a mime.types file? [22:22] sinzui: no, i think i'd rather provide a method that adds the extra bits as i do now but have it invoked "early" so that everyone who imports the standard mimetypes will get the modified version. [22:24] I think that is kind of magic [22:25] bac: considering that we are designing for multiple distros and pythons, I like explcit [22:25] bac: Consider how difficult debugging will be if it is not clear which mimetypes you are using [22:28] sinzui: consider what's happening in model/bug.py [22:29] sinzui: they muck with mimetypes but don't explicitly use it. it is used by zope.contenttype later [22:33] I think the bug example should be using your approach. bug 229040 illustrates we may have to live this this a long time [22:33] Bug #229040: debdiff shown as html

[22:41] sinzui: i can move the add_type for the deb diff into my lp.services.mime but then getting it invoked is a problem [22:41] i've chatted with gary some and what i'd like to do is convert what i have in lp.services.mime into an initialization method [22:42] and then call that method from site.py, which will ensure everyone who then uses the standard mimetypes will get one that has been customized [22:49] bac: okay [22:50] sinzui: the mod is easy so i'll run it by you shortly