| === pocek_ is now known as pocek | ||
| ion | keybuk: Some small fixes, https://code.edge.launchpad.net/~ion/ubuntu/lucid/mountall/lucid | 06:28 |
|---|---|---|
| ion | keybuk: Also an autoreconf commit is needed at some point. | 06:31 |
| Keybuk | I've been committing autoreconf as I go | 06:32 |
| Keybuk | it builds here ;) | 06:32 |
| ion | conf/Makefile.in doesn’t install the new conf/mounted-* files even though conf/Makefile.am was updated. | 06:33 |
| Keybuk | oh, I probably didn't test that yet | 06:33 |
| ion | Before making the $MOUNTPOINT guard change, i hosed my virtualbox test machine by running ‘start mounted-tmp’ without thinking. find happily proceeded to delete files under /. ;-) | 06:37 |
| Keybuk | lol | 06:42 |
| Keybuk | that's pessimal | 06:44 |
| Keybuk | I shall take a look | 06:46 |
| Keybuk | just catching up with e-mail atm | 06:46 |
| ion | I’m not sure if i’m doing the right thing in the “Handle remounts again” commit, but it does make my VM boot again. The “Now supports multiple filesystem types listed in fstab” commit caused mounted () never to be called after the successful remount of /. | 06:49 |
| Keybuk | oh, hmm | 06:49 |
| Keybuk | yeah that's probably a bug | 06:49 |
| Keybuk | because forcing parse_mountinfo() won't reflag it as mounted | 06:49 |
| Keybuk | this whole filesystem thing is a hard problem <g> | 06:50 |
| Keybuk | though I'm happy that more code is moving out of mountall again now - fits the idea better that it'll be a tool to parse files and auto-generate upstart jobs from them | 06:50 |
| ion | Yeah | 06:50 |
| ion | Also, i finished Voyager last night. Next up: Enterprise. | 06:52 |
| Keybuk | my god | 06:54 |
| Keybuk | you brave man | 06:54 |
| ion | I’ve been watching all Star Trek series in the original air date order. | 06:57 |
| ion | Yes, even TAS. | 06:59 |
| ion | It was hilariously bad. | 06:59 |
| Keybuk | I watched DS9 end-to-end | 07:01 |
| Keybuk | I had thought that I hadn't watched much of it before | 07:01 |
| Keybuk | but in practice, it's turned out that I had watched almost all of the first six seasons | 07:01 |
| Keybuk | right | 07:58 |
| Keybuk | that's me caught up on e-mail and bugs now | 07:58 |
| Keybuk | I shall have breakfast then look at your branch, ion | 07:59 |
| Keybuk | ion: around? | 08:20 |
| === [2]sassyn is now known as sassyn | ||
| === ev1 is now known as ev | ||
| === danderso1 is now known as danderson | ||
| === robbiew_ is now known as robbiew | ||
| ion | keybuk: Around. | 17:09 |
| Keybuk | ion: still around? :) | 18:11 |
| ion | Yeah | 18:11 |
| Keybuk | so I've merged a couple of your patches, but not most of them | 18:12 |
| Keybuk | 196: I don't see what this patch does | 18:12 |
| Keybuk | from what I can tell, this would hide valid errors that should break the hook script | 18:13 |
| Keybuk | the stated aim is to handle the file not existing, but the [ -f ... ] && on the front *already*does*that* | 18:13 |
| Keybuk | no? | 18:13 |
| ion | [ -f /etc/motd.tail ] && whatever when /etc/motd.tail doesn’t exist → false && whatever → false → the script dies with set -e | 18:14 |
| Keybuk | no it doesn't | 18:14 |
| ion | Ah, sorry. | 18:14 |
| Keybuk | -e will only terminate the script on statuses that you do not check | 18:15 |
| Keybuk | otherwise it'd terminate on every "if" or "while" | 18:15 |
| Keybuk | http://www.opengroup.org/onlinepubs/009695399/utilities/set.html | 18:15 |
| ion | I just looked at sh -ec '[ -f /etc/motd.tail ] && cat /etc/motd.tail' and saw it returning 1. I should have added ‘; echo foo’ to it to make sure and not just assume. | 18:15 |
| Keybuk | -e When this option is on, if a simple command fails for any of the reasons listed in Consequences of Shell Errors or returns an exit status value >0, and is not part of the compound list following a while, until, or if keyword, and is not a part of an AND or OR list, and is not a pipeline preceded by the ! reserved word, then the shell shall immediately exit. | 18:15 |
| Keybuk | "and is not a part of an AND or OR list" being the key bit | 18:16 |
| ion | Yeah | 18:16 |
| Keybuk | 198 I've done in a different way | 18:16 |
| Keybuk | 199 was fixed already but not pushed | 18:17 |
| ion | Yeah, you fixed remounts better indeed. | 18:17 |
| Keybuk | 201 I just don't agree with | 18:17 |
| Keybuk | if I'd wanted to fix the hooks to only be possible to run with certain mountpoints, I would have just hardcoded the paths instead of actually using $MOUNTPOINT :) | 18:17 |
| Keybuk | if people run those by themselves, and screw up, that's their own funeral <g> | 18:17 |
| ion | Alright. But it might be non-obvious to sysadmin that a ‘start mounted-tmp’ might delete everything. How about a [ -n "$MOUNTPOINT" ] check? | 18:18 |
| Keybuk | if sysadmins are going around starting random jobs without even reading them, that's their own fault | 18:19 |
| ion | Ok | 18:20 |
| ion | Is dying if a connection to plymouth fails the right thing to do? | 18:21 |
| Keybuk | that being said, Upstart should have more of a facility for "required arguments" | 18:21 |
| Keybuk | ion: yes, I think so | 18:21 |
| Keybuk | otherwise mountall won't be able to get help from the user | 18:21 |
| ion | Ok | 18:22 |
| === robbiew1 is now known as robbiew | ||
| === robbiew is now known as robbiew_ | ||
| === robbiew_ is now known as robbiew | ||
| wasabi | So. Ever considered a feature in Upstart to parse /etc/init.d files and build a bunch of jobs in a rc.* namespace? :) | 23:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!