[02:44] <jml> https://code.edge.launchpad.net/~jml/launchpad/fix-release-hot-bugs-486437/+merge/16173 -- could someone please review this?
[02:48] <thumper> is there a test yet?
[02:50] <jml> thumper, I don't recall anyone asking for one.
[02:51] <jml> thumper, or making suggestions as to where said test should go.
[02:51] <thumper> where is it tested now?
[02:53] <jml> thumper, there's a page test.
[02:53] <jml> thumper, which still passes
[02:54] <jml> thumper, since firefox has no fix released bugs in the sample data.
[02:54] <thumper> he
[02:54] <thumper> not much of a test then is it?
[02:54] <thumper> only saying the things I've learnt to say from you :)
[02:56] <jml> *grumble grumble*
[02:58] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/fix-review-comment-field-enablement/+merge/16178
[02:58] <thumper> now that one is hard to test
[02:58] <thumper> in fact I have no idea even if it is possible with windmill
[02:59] <jml> thumper, have you tried?
[03:00] <thumper> tried to test with windmill, or tried the fix?
[03:00] <jml> thumper, the former.
[03:00] <thumper> jml: I've looked at the windmill api
[03:00] <jml> doesn't it let you record tests?
[03:00] <thumper> and it isn't obvious how to tab to the next field
[03:00] <thumper> ah yeah
[03:00] <thumper> not tried to do that
[03:00] <thumper> any idea how?
[03:01] <jml> thumper, nope.
[03:01] <jml> thumper, happy to say I've avoided the whole mess :)
[03:12] <jml> thumper, changing the status of a bug is bloody difficult.
[03:12] <thumper> jml: why?
[03:12] <thumper> jml: why not just factory.makeBug?
[03:13] <jml> thumper, because nothing else in the test does that.
[03:13] <thumper> jml: they have to learn some time :)
[03:13]  * thumper sniggers
[03:13] <jml> thumper, well, this patch isn't the place to teach them.
[03:14] <thumper> :)
[03:34] <jml> thumper, test added. code fixed.
[03:37] <thumper> jml: status=any(*UNRESOLVED_BUGTASK_STATUSES)
[03:37] <jml> thumper, yet?
[03:37] <jml> yes, rather?
[03:37] <thumper> does: status=UNRESOLVED_BUGTASK_STATUSES work?
[03:37] <jml> thumper, no.
[03:37] <thumper> why?
[03:37] <jml> thumper, that was the first thing I tried.
[03:37] <thumper> any is a generator isn't it?
[03:37] <jml> thumper, no.
[03:37] <jml> thumper, ha. ha. ha.
[03:38] <jml> thumper, it's a thing specific to Launchpad
[03:38] <jml> thumper, from canonical.launchpad.searchbuilder
[03:38] <thumper> hmm...
[03:38] <thumper> damn
[03:38] <jml> thumper, which I bet you didn't know existed
[03:38] <thumper> nope
[03:38] <jml> thumper, 'any' is a generator by default
[03:38] <jml> thumper, me neither :)
[03:38] <thumper> any becomes a keyword soon isn't it?
[03:38] <jml> thumper, builtin, I think.
[03:39] <thumper> ew
[03:39] <thumper> r=me
[03:39] <jml> thumper, I don't think searchbuilder is that bad (he says without looking at the code)
[03:39] <jml> thumper, but to me, it makes more sense to re-use storm primitives
[03:40] <jml> thumper, thanks.
[03:40] <jml> I'll land that next Monday!
[03:40] <thumper> hmm...
[03:41] <thumper> damn javascript garbage collector
[10:02] <mrevell> Anyone care to review my branch? It's for an RC -- https://code.edge.launchpad.net/~matthew.revell/launchpad/whatsnew-3112/+merge/16147
[10:10] <intellectronica> mrevell: approved
[10:10] <mrevell> ah, thanks intellectronica
[10:10] <intellectronica> mrevell: now you need to get an rc, though
[10:11] <mrevell> intellectronica, yeah, I've got Danilo right where I want him.
[10:11] <danilo_> mrevell, aha
[10:12] <mrevell> :)
[10:12] <intellectronica> mrevell: you do? can you tap him on the shoulder on my behalf?
[10:12] <mrevell> intellectronica, heh
[10:12] <danilo_> intellectronica, I've seen yours as well, will be getting to it shortly
[10:12] <intellectronica> danilo_: great, thanks
[10:19] <danilo_> intellectronica, ok, so the code looks ok, I've got only some RC-related questions
[10:19] <intellectronica> yes?
[10:20] <danilo_> intellectronica, so, how much does this affect our users? is the tag editing completely broken? (I remember you experiencing something along those lines yesterday, but sinzui had no problems editing them for other projects)
[10:20] <danilo_> intellectronica, and, if it affects only a subset of our users, what subset is it? is it a subset we can direct to edge? how/when do you plan to QA this?
[10:21] <intellectronica> danilo_: tbh it doesn't affect users all that much. only a subset of users can edit official tags anyway, and those have a workaround if they need to edit urgently
[10:21] <intellectronica> danilo_: but the fix is small and doesn'ty touch anything else, and oem services have asked that we fix it asap
[10:21] <danilo_> intellectronica, right, what is that workaround?
[10:22] <danilo_> intellectronica, that's the other thing: it doesn't touch anything else? should this have a windmill test?
[10:22] <intellectronica> danilo_: disable javascript and reload the page
[10:22] <danilo_> (i.e. something else to be touched :)
[10:22] <danilo_> intellectronica, ok, that sounds nasty, I think it's worth of an RC, but I'd like to see test added as well
[10:23] <intellectronica> danilo_: ok, let me add a windmill test for this
[10:23] <danilo_> intellectronica, thanks, if it's going to be a big involved test, I don't want to pressure you, but if it's decently simple, I'd very much like to have it... at least right after the rollout, it doesn't have to be included in this landing
[10:24] <intellectronica> danilo_: i'll see if i can modify the existing test to just add a dot somewhere and see that it doesn'
[10:24] <intellectronica> tt fail
[10:24] <danilo_> intellectronica, sounds good, thanks
[10:41] <danilo_> allenap, hi, I am looking at https://code.edge.launchpad.net/~allenap/launchpad/bugtracker-snapshot-bug-447100/+merge/16130 — looks very reasonable but the question is why RC? who are the affected users and how many of them are there?
[10:42] <danilo_> allenap, i.e. can we only fix it on edge after the rollout, would that be good enough for users likely to use it? (we do have both edge and production APIs as well now)
[10:51] <allenap> danilo_: It probably is enough to just have it on edge.
[10:51] <allenap> danilo_: There are probably not many affected users.
[10:52] <allenap> danilo_: And it's not a frequently used page. At least, I hope it isn't; it's configuration.
[10:53] <danilo_> allenap, right, so I guess we can say no to this RC unless you feel really strongly about it? I don't want you to feel bad about it, but the more RCs we have, the bigger chances of something breaking with this little QA time we've got
[10:53] <allenap> danilo_: Fair, I'm happy with that. I'll mention it to deryck when he's online. I doubt he'll have a problem with that.
[10:54] <danilo_> allenap, ok, thanks
[11:00] <danilo_> allenap, btw, I've marked your MP as 'approved' but that's for regular landing, RC is disapprove :)
[11:02] <allenap> danilo_: No worries, I got that... but I was tempted to land and use the plausible deniability and ask forgiveness defences ;)
[11:02] <danilo_> hehe :)
[11:02] <gmb> *sigh*
[11:09] <allenap> danilo_: I can't land anything in PQM. Do you know if it's it in testfix mode? It doesn't look like it should be...
[11:09] <danilo_> allenap, are you landing to db-devel or devel? (devel is already closed)
[11:10] <allenap> danilo_: Oh rats.
[11:10] <allenap> danilo_: When did devel close? I've been trying since yesterday afternoon.
[11:11] <danilo_> allenap, it was closed together with PQM, I wasn't aware of the option that it could be kept open and that I should have asked spm to do it in such a way
[11:12] <allenap> danilo_: Okay. Just to check, is it safe to just submit my based-on-devel branch to db-devel?
[11:12] <danilo_> allenap, should be if all the devel revisions you have are already in stable
[11:13] <allenap> danilo_: Cool, thanks.
[11:13] <danilo_> allenap, otherwise, it's still safe if all the tests pass for you :)
[11:22] <salgado> adiroiban, around?
[11:22] <adiroiban> salgado: hi. yes.
[11:23] <StevenK> danilo_, bigjools: Is my netbook-cron branch still going to make it in?
[11:23] <bigjools> StevenK: yes
[11:23] <bigjools> it landed already
[11:23] <StevenK> bigjools: That's odd, I see "Approved revision: not available" on the merge page
[11:23] <salgado> adiroiban, hi there.  do you have the test failures for that branch handy?  In the merge proposal you said which test failed, but I'd like to see what the failure is
[11:24] <adiroiban> salgado: yes. let me paste it. 
[11:24] <bigjools> StevenK: I can assure you it landed
[11:25] <adiroiban> salgado: http://paste.ubuntu.com/341811/
[11:25] <StevenK> bigjools: So it's the merge page that's not correct. I can deal with that.
[11:25] <salgado> adiroiban, is that the only test that failed?
[11:25] <bigjools> StevenK: what URL are you looking at?
[11:25] <adiroiban> salgado: the view needs to be refresh, as in that test the translationgroup is initialized with None
[11:25] <adiroiban> salgado: yes
[11:26] <StevenK> bigjools: https://code.edge.launchpad.net/~stevenk/launchpad/netbook-cron/+merge/16115
[11:26] <bigjools> StevenK: I landed a copy of your branch, that's why it didn't set yours
[11:26] <adiroiban> salgado: now, that we save the translationgroup on view it's like we cache it
[11:26] <salgado> adiroiban, I see
[11:27] <adiroiban> salgado: and if meanwhile the group is changed, the view does not know about it.
[11:27] <adiroiban> but is hard to have that behaviour in a real system
[11:27] <adiroiban> and with a page reload you will have the problem solved
[11:27] <adiroiban> i mean you will see the new value
[11:27] <adiroiban> I  tried to force a refresh in the test, 
[11:28] <adiroiban> but I don't know what I did wrong, as it did not solve the problem
[11:29] <salgado> adiroiban, agreed.  I think the best thing is to change the test as it makes no sense for the test to expect that behavior from the view -- specially since it's not documented
[11:29] <adiroiban> with those changed, I ran a new full test for translations module, and it was ok
[11:30] <adiroiban> salgado: ok. I will look into that
[11:30] <adiroiban> since this is not RC , i think there is no hurry
[11:30] <adiroiban> or do you want to land it now?
[11:31] <salgado> not really, and even if I wanted, danilo_ wouldn't
[11:31] <adiroiban> also there is a follow up for that branch to also clean those tests
[11:31] <danilo_> salgado, that's right :)
[11:31] <adiroiban> :)
[11:31] <adiroiban> salgado: thanks for looking into this 
[11:32] <danilo_> adiroiban, salgado: though, what you are discussing sounds like cachedproperties in a test, though I am just guessing
[11:32] <adiroiban> danilo_: nope
[11:32] <adiroiban> is just a = b.c , but c is none
[11:33] <adiroiban> so then b.c = True
[11:33] <adiroiban> a is not updated
[11:33] <salgado> adiroiban, the first thing I'd do is check that self.dsl.distroseries.distribution.translationgroup is not None
[11:33] <danilo_> adiroiban, I am not sure I follow you :)
[11:34] <adiroiban> salgado: and if it none ? what shall i do?
[11:34] <adiroiban> of why that check?
[11:35] <salgado> adiroiban, then we need to find out why it's not being updated when you assign the group to self.distroseries.distribution.translationgroup
[11:36] <adiroiban> because view.translationsgroup is None
[11:36] <adiroiban> so it is not linked with self.distroseries.distribution.translationgroup
[11:37] <salgado> adiroiban, I meant that after your change to the test, which creates a new view instance in your test method
[11:37] <adiroiban> salgado: ah :)
[11:37] <adiroiban> yep
[11:38] <adiroiban> I will look at that as I still need to learn how all those classed are linked and how does their timeline look like
[11:39] <salgado> adiroiban, cool. don't hesitate to ask if you have any questions. :)
[11:39] <adiroiban> salgado: sure. np.
[11:46] <gmb> salgado, adiroiban: To be clear, which branch are you talking about here? Is it one of the ones currently in the review queue in the /topic?
[11:46] <adiroiban> gmb: nope
[11:47] <gmb> adiroiban: Righto, I'll crack on with reviewing those then.
[11:48] <adiroiban> gmb: thanks. There is no hurry for them
[11:48] <adiroiban> they are low priority
[11:48] <gmb> adiroiban: Maybe not, but I'm on-call reviewer and I'm bored ;)
[11:48] <intellectronica> danilo_: i've added a windmill test and my branch has been re-reviewed. care to take a look again?
[11:49] <danilo_> intellectronica, sure, thanks!
[11:50] <adiroiban> gmb: :D
[11:50] <gmb> adiroiban: So, to create a merged person, you do the following:
[11:50] <gmb> person_1 = factory.makePerson()
[11:50] <gmb> person_2 = factory.makePerson()
[11:51] <gmb> person_2.merged = person_1
[11:51] <gmb> That then means that person_2 has been merged into person_1.
[11:51] <gmb> adiroiban: This branch really needs a test before it lands.
[11:52] <adiroiban> gmb: ok. np. I will do that
[11:52] <gmb> adiroiban: Thanks. I'll mark the review as Needs Fixing for now.
[11:52] <adiroiban> sure
[13:08] <StevenK> bigjools: Excuse my complete ignorance about PQM, but it's normal that I can't see the changes in lp:~launchpad-pqm/launchpad/devel
[13:09] <beuno> StevenK, you should be able to see anything
[13:09] <beuno> what is it you're trying to see specifically?
[13:09] <StevenK> beuno: The changes from my netbook-cron branch in what will be released, since I'm slightly paranoid
[13:11] <beuno> StevenK, it seems to have been landed in db-devel
[13:11] <beuno> http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/revision/8790
[13:12] <beuno> wasn't UNR renamed to UNE?
[13:13] <StevenK> beuno: Yes, hence the netbook name. It follows precedent from server.
[13:13] <beuno> ah, missed that
[13:15] <StevenK> beuno: So in documentation, it's the Ubuntu Server Edition, but the meta package and so on is ubuntu-server. So I'm doing the same thing with netbook.
[13:16] <beuno> gotcha
[13:17] <StevenK> beuno: Will db-devel turn into devel? What's the process there?
[13:18] <beuno> StevenK, db-devel gets rolled out to production directly, not edge daily
[13:18] <beuno> so, IIRC, it will merge into devel when the roll-out happens
[13:19] <beuno> if you're worried if it will land, don't worry, if it's in db-devel, it will  :)
[13:19] <StevenK> When it's scheduled to land?
[13:20] <beuno> I think roll-out is this week?  tomorrow or Thu?
[13:20] <beuno> danilos should know
[13:21] <beuno> or flacoste
[13:23] <danilos> StevenK, it's going to be on production LP servers on Wednesday 22:00 UTC
[13:24] <StevenK> danilos: Okay, thanks.
[13:24] <danilos> StevenK, if you really want the nitty gritty details, db-devel turns into db-stable when all the tests pass, and then we roll out whatever is in db-stable by 12:00 UTC on Wednesday
[13:25] <StevenK> danilos: Ah!
[13:25] <danilos> StevenK, your revision (8790) is already in db-stable (up to 8794), so you should be safe
[13:26] <StevenK> danilos: Excellent, thanks!
[13:37] <bigjools> StevenK: I told you to trust me ;)
[13:38] <StevenK> bigjools: You did, yes :-)
[14:53]  * gmb goes off-call to fix an RC bug.
[14:54] <gmb> deryck: lp:~gmb/launchpad/windmill-test
[14:54] <deryck> gmb, got it.  thanks.
[14:55] <deryck> taking a break from your usually cleverly named branches? :)
[14:58] <gmb> deryck: Only the dupefinder got Hammer Horror titles ;)
[14:58] <gmb> I'm saving the next batch for bug heat :)
[14:58] <deryck> heh
[14:58] <gmb> Right. Coffee, then hacking.
[15:15] <leonardr> salgado, do you have time to review https://code.edge.launchpad.net/~leonardr/launchpad/anonymous-oauth/+merge/16199? it shouldn't take long
[15:15] <salgado> leonardr, otp
[15:24] <salgado> leonardr, do you mind if I do it after lunch?
[15:40] <allenap> Hi bac, got time for a short+simple review? https://code.edge.launchpad.net/~allenap/launchpad/bugwatch-bugtasks-as-a-list/+merge/16200
[15:42] <bac> allenap: for you?  sure!
[15:42] <bac> allenap: is this an RC candidate/
[15:42] <bac> ?
[15:42] <allenap> bac: Thanks :) And no, not RC yet, but I might ask.
[15:43] <allenap> bac: There's probably a bit too much lint cleaning in there - sorry, I got a little enthusiastic - but it's still quite short and understandable.
[16:17] <gmb> bac: Can you review https://code.edge.launchpad.net/~gmb/launchpad/checkwatches-keyerror-oops-bug-496988/+merge/16204 for me (RC candidate)
[16:23] <bac> gmb: in your final test it is not clear that either of those bug watches cause a key error.  is it b/c there is a bug 1 but not bug 2?  i think the casual reader might need more info there.
[16:24] <mup> Bug #1: Microsoft has a majority market share <iso-testing> <ubuntu> <Clubdistro:Invalid> <Computer Science Ubuntu:Invalid by compscibuntu-bugs> <EasyPeasy Overview:In Progress by ramvi> <Ichthux:Invalid by raphink> <JAK LINUX:Invalid> <OpenOffice:Invalid by lh-maviya> <Tabuntu:Invalid by tinarussell> <Tivion:Confirmed for shakaran> <Ubuntu:In Progress by sabdfl> <ubuntu-express (Ubuntu):Invalid by jahyire2006> <Ubuntu Jaunty:In Progress> <
[16:24] <bac> thanks mup.  helpful!
[16:26] <gmb> bac: Ah, right. I'll add a comment.
[16:26] <bac> gmb: thanks, r=bac
[16:26] <gmb> bac: Ta.
[16:27] <jpds> Do non-RC MPs get reviews too at the moment?
[16:27] <bac> jpds: depending on reviewer availability.
[16:27] <bac> jpds: i can do a review now if the changes are short
[16:27] <jpds> I have: https://code.edge.launchpad.net/~jpds/launchpad/fix_450262/+merge/16203
[16:28] <bac> jpds: that's pretty short.  i'll do it now.
[16:34] <bac> jpds: in addition you'll need to get a UI review.  it is always welcome to have screen shots for those added to the bug and/or referenced from the MP
[16:36] <bac> jpds: also there is no test for this new functionality.  you'll need to add one.  there are plenty of examples of test that check to ensure email is sent or not sent.
[16:37] <jpds> bac: Something like http://people.canonical.com/~jpds/fix_450262_screen.png ?
[16:48] <bac> jpds: yep
[16:52] <jpds> bac: OK, prefect, I'll look for existing test and will add a new one.
[17:31] <jpds> bac: Tests for fix_450262 added and pushed.
[17:31] <bac> thanks jpds.  i have to go out now but will look at it later
[17:31] <jpds> No problem.
[18:05] <leonardr> salgado, ping re my review?
[18:06] <salgado> leonardr, did you get it?
[18:06] <leonardr> salgado: i'm looking on the web
[18:06] <leonardr> checking email now
[18:06] <salgado> I sent it 10 minutes ago, but I see the mp hasn't been updated yet
[18:11] <leonardr> salgado: i haven't gotten the email yet either
[18:11] <salgado> An error occurred while processing a mail you sent to Launchpad's email
[18:11] <salgado> interface.
[18:11]  * salgado resends
[18:19] <leonardr> salgado, can you point me to example code so i can see how to check that consumer is stored in the database?
[18:20] <salgado> leonardr, doc/oauth.txt
[18:20] <leonardr> ok
[18:21] <salgado> you might need to login() in your test, though
[18:27] <leonardr> salgado, while you're at it, do you want to look at my launchpadlib branch?
[18:27] <leonardr> my response to your review shouldn't affect this code
[18:27] <salgado> leonardr, sure
[18:28] <leonardr> ok, writing it up
[18:38] <leonardr> salgado: https://code.edge.launchpad.net/~leonardr/launchpadlib/anonymous-access/+merge/16213