/srv/irclogs.ubuntu.com/2009/12/16/#launchpad-dev.txt

MTecknologyjml: at least it seems like it's on the decline some00:02
MTecknologyjml: some really bored people that have probably never been laid and never will be....00:03
jmlwhat's the test plan home page?00:08
jmlnever mind00:10
jml(I'd like to know what it is, but at least now I've done my QA item)00:10
jmlI'm really looking forward to landing my 'hot bugs' patch00:14
spmjml: you should perhaps wear your hot pants when you do so? get in the groove of the moment.00:15
jmlspm, good call.00:16
jmlspm, I'll take photos for you.00:17
spmjml: on this one, I'm prepared to believe *without* photos. a rare exception.00:17
jmlspm, heh.00:17
jmlI often want to file multiple bugs on a project at once00:24
jmlI wish Launchpad made that easier.00:24
pooliemm00:30
jmlI'm filing stacks of usability bugs on 'gtg'00:37
jmlwhich means filing a bug, hitting "End", looking for the "Report another bug" thing and then clicking it.00:37
jmlI filed a bug about this years ago, of course.00:37
jmlsince my previous bug tracker was trac, which makes this quite easy.00:37
* mwhudson noms00:38
MTecknologyI hate trac...00:42
MTecknologyjml: just do Back; change details if you know it wasn't reported...00:42
jmlMTecknology, I hate trac too, but it still does some stuff better than Launchpad.00:45
MTecknologyjml: You ever try Mantis?00:47
jmlMTecknology, maybe once, but never for long and not enough to remember it.00:47
jmlthumper, hey, I thought code review comments would get permalinks for free01:08
* jml lunching01:11
pooliejml: what's gtg?01:33
pooliebtw unless it's just me (which it may be) https://bugs.edge.launchpad.net/malone/+bug/471328 seems pretty critical01:34
mupBug #471328: Also affects search error - too many matches <bug-page> <ui> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/471328>01:34
jmlpoolie, "Getting Things GNOME"01:34
poolieyou can't choose bzr or bzr-svn from a project picker01:34
jmlpoolie, it's a todo thing that has potential, a fairly active community and not the greatest code.01:34
jmlpoolie, I'm living in constant tension between writing my own and helping them with theirs.01:35
poolie"price: Free" :-)01:35
pooliethanks ubuntu :)01:35
jmlpoolie, I'm not sure how that could be a new bug01:37
jmlpoolie, well, at least new to this cycle01:37
* poolie plays on staging01:38
pooliewell01:38
pooliei didn't see it before01:38
pooliei would have noticed because i do reassign from bzr to plugins pretty often01:38
pooliemaybe it's transient xmlrpc failure?01:38
jmlpoolie, it was filed in early november, so it'd have to affect production.01:39
* poolie tests01:39
jmlpoolie, anyway, it does seem pretty serious. Given that all of the bugs guys are afk atm, I'm not sure of the best way to escalate it.01:39
poolielet me try to reproduce it again01:40
jmlI mean, other than me actually fixing the bug.01:40
poolie:)01:40
pooliehm on https://bugs.staging.launchpad.net/bzr/+bug/385879 i don't get that problem but just a stuck spinner01:41
mupBug #385879: EOL filter only applied to files when first checked out <content-filtering> <Bazaar:Fix Released by mbp> <Bazaar 2.0:Fix Released by ian-clatworthy> <https://launchpad.net/bugs/385879>01:41
poolieoh when i tried a second time i did get "undefined"01:41
poolieso it may be intermittent?01:41
jmlsounds plausible01:42
=== adiroiba1 is now known as adiroiban
jmlmwhudson, hi03:23
mwhudsonjml: hi03:23
jmlmwhudson, I was wondering, now that we almost have a fully working bazaar.edge and we have a bzr buildbot...03:24
jmlmwhudson, how much of a pain would it be to automatically land working bzr updates?03:24
jmlmwhudson, and do you think that would be a good idea.03:24
jmlmwhudson, feel free to tell me to go away -- I'm only asking out of curiosity.03:25
mwhudsonjml: i guess it wouldn't make sense to go on getting bzr from an egg in this case03:25
jmlmwhudson, but eggs are teh future.03:25
mwhudsonjml: in fact it flies rather thoroughly in the face of the "use releases" direction buildout consciously pushes us in03:26
mwhudsonjml: that doesn't mean it's a bad thing though03:26
mwhudsonnecessarily03:26
mwhudsonjml: having an autoupdated thingy for bazaar.edge but keeping prod using releases would be nice03:27
mwhudsona bit harder to arrange though i guess03:27
jmlmwhudson, I was typing the same thing, more or less :)03:27
mwhudsoni guess there might be issues with new formats03:28
mwhudsonyou could push a new format to baz.edge but the scanner wouldn't be able to read it03:28
mwhudsonwell, i guess tests fail when a new format is added03:28
jmlmwhudson, don't we already have that problem?03:28
mwhudsonjml: yes03:28
mwhudsonwell, modulo what i just said03:28
jmlmwhudson, yeah, but even without edge, people can still push up formats that we don't support.03:29
mwhudsonjml: true i guess03:29
mwhudsonmaybe only over sftp03:29
jmlright.03:29
jmlmwhudson, anyway, it's something to keep in the back of the mind. getting it set up might save us some boring maintenance work, and give bzr better a tighter feedback loop for new server-side behaviours.03:31
jml(maybe we should get poolie to do it!)03:32
pooliesaying the word 'egg' requires fighting robert03:32
mwhudsonbetter than fighting a bear i guess03:33
pooliequestionable03:33
pooliemore seriously, we do have nightly debs03:33
pooliewhy not use them+03:33
poolies/+/?03:33
wgrantLP has a vendetta against using packages or anything that isn't woefully insecure.03:33
jmlpoolie, I think this is one of those cases where whoever wants to get this done will need to possess a will of iron, regardless of implementation details03:34
jmlpoolie, and that given said iron will, they get to do it however they want.03:34
pooliethe good thing is i do have a will of iron03:34
pooliethe bad bit is it's iron filings03:35
jmlhahaha03:35
poolieos03:35
poolieso03:35
pooliehm03:36
pooliei may try to get it running against the system bzrlib03:36
poolienot your own copy03:36
jmlpoolie, one of the things about using nightlies to consider is that the buildbot doesn't run against them.03:36
jmlpoolie, and we only want to update if the tests pass -- it is still a live system running against production data.03:37
* jml afk03:41
=== Ursinha is now known as Ursinha-afk
mwhudsonok, i didn't expect this: http://pastebin.ubuntu.com/342383/04:30
mwhudson(i guess i need to run it with ./bin/py or python2.5)04:30
wgrantspm: buildd-manager is broken.04:33
jmlmwhudson, nice04:34
* jml does some illicit programming04:34
jmldon't tell anyone04:34
wgranthttps://edge.launchpad.net/~ubuntuone-hackers/+archive/ppa/+build/1129031 is assigned to a builder and utterly broken. I wonder if that is related.04:35
spmwgrant: I assume that's not a statement of observation; rather a pls fix? :-)04:35
wgrantspm: Yes please.04:35
spmhrm. oddness. going for a bounce on it.04:36
wgrantIt might help, but there are some broken build records around...04:36
mwhudsoni wonder if testcasewithfactory should flush the active stores in it's tearDown04:37
spmahh. k. will chase them too. ta.04:37
jmlsomeone just commented that, CACHE_DIRECTORY = os.path.expanduser('~/.launchpadlib/cache') might be a bad idea for windows04:37
jmldoes anyone have any good suggestions for what should be used instead?04:37
jmlthis is for a launchpadlib cache04:37
spmwgrant: out of not-idle curisoity, have you considered becomming our nagios system? :-P04:38
* mwhudson finds that all his tests so far violate database constraints, but none of them actually issued any queries04:38
mwhudsonanyway, /me eods more or less04:38
mwhudsonbiab04:38
wgrantspm: Ah, that build is fixed now. I wonder if the restart did that.04:38
spmhaven't been able to get the (*&^(*&^ing thing to stop yet.04:38
spmI do so love issuing "stop" scripts and have them ignored04:39
wgrantspm: SIGTERM kills it in not too long for me...04:39
wgrantHmm.04:39
wgrantInteresting.04:39
spmyeah - but there are "right" ways. I suspect the kill and kill with prejudice are in the immediate futuire here04:39
wgrantI don't see why an attempt was made to build https://edge.launchpad.net/~ubuntuone-hackers/+archive/ppa/+build/1129031 at all -- it's five months old, and for a disabled archive.04:40
spm2009-12-16 04:37:04+0000 [-] Received SIGTERM, shutting down. <== LIES!!!04:41
wgrantI'04:42
wgrantI've not worked out why it doesn't just die quickly.04:42
spmit's pretty effing annoying...04:42
spm2009-12-16 04:43:08+0000 [-] Server Shut Down.04:43
spmawesome. nice and fast.04:43
wgrantIs it back up yet?04:43
wgrantHum.04:43
wgrantThat build oopses sometimes, but not others. That is slightly concerning.04:44
spmyup. all looks "normal". for values of...04:44
wgrantMuch better. Thanks.04:45
wgrantAny idea what killed it?04:45
spmthe passage of time...04:49
spmI tried 2 'stops', one straight up kill; it actually stopped on it's own a few secs before I was going to -9 it.04:49
wgrantI mean, what broke it?04:50
spmeither way. wrong. bug 49728204:50
mupBug #497282: buildd-manager is reluctant on shutting down in a timely manner <Soyuz:New> <https://launchpad.net/bugs/497282>04:50
spmno idea.04:50
spmit looked like it was havng issues with one of the hosts. but...04:50
spmwgrant: what were the symptoms you were seeing that showed it as broken?04:51
wgrantbohrium was hung as usual, but that happened 10 hours before the breakage.04:51
wgrantspm: No build dispatched lately.04:51
spmkk04:51
wgranthttps://edge.launchpad.net/~ubuntuone-hackers/+archive/ppa/+build/1129031 was also sitting on /builders, assigned to a builder but with status 'Needs build'04:51
wgrantThat doesn't make sense.04:51
wgrantAnd now it OOPSes intermittently like OOPS-1446ED19204:52
spmweird04:52
wgrantIt seems like it was pretty effectively broken, since it also wasn't updating the status of builds that were in progress.04:53
pooliejml, i think the answer to your 'does lplib follow a fixed release schedule' is 'no' :)04:54
jmlpoolie, it's _really_ frustrating.04:54
jmlpoolie, trunk has some stuff that'll make bzrlib integration much easier.04:55
jmlwell, a little easier.04:55
wgrantThat problematic build just got hit again. I wonder if things have jammed up already.04:59
spmwgrant: aaaah. this may be a bug we've been tracking04:59
wgrantYeah, it is.04:59
wgrantFor now, kill that build and restart, I guess.05:00
spmhttps://bugs.edge.launchpad.net/soyuz/+bug/49657405:00
mupBug #496574: buildd-manager fails to deal with "Fault 8002" errors <buildd-manager> <soyuz-build> <Soyuz:Triaged> <https://launchpad.net/bugs/496574>05:00
spmand there was another....05:00
wgrantOh, could be that, I guess.05:00
spmmeh. can't find it. the gist is that something in the soyuz part is borked. this has been *flooding* us with OOPSes. that you saw that oops, (as did I on a 2nd attempt) suggests that could be it.05:01
wgrantThat build has hit a builder again, but other builds seem to still be working.05:02
wgrantSo maybe the two horrible brokennesses are unrelated.05:02
jmlmwhudson, where does your lazy-import-supporting pyflakes live?05:04
=== danilo_ is now known as danilos
* jml gone07:48
adiroibanhenninge: hi. do you have 5 minutes to answer a questions? :)07:54
adiroibanhere is the code http://paste.ubuntu.com/342540/07:54
henningeadiroiban: Hi!07:54
* henninge looks07:54
adiroibani would like to get rid of the permission checking from model07:55
adiroibanand only have them in security.py07:55
adiroibanalso to get rid of permission_helper.py07:55
adiroibanas those checks are also implemented in security.py07:55
henningeadiroiban: I just created permission_helper.py last cycle07:57
henningeadiroiban: and I actually have a branch that extends it07:57
henningeadiroiban: I discussed this at length at the Dallas sprint07:58
adiroibanhenninge: why not have that logic in security.py ?07:58
henningeadiroiban: because it is needed in the model, too.07:58
henningeadiroiban: the zope security system will only give you control over access to attributes.07:58
adiroibanbut we can import the class from security.py07:58
henningeadiroiban: which class?07:59
adiroibanAdminTranslationImportQueueEntry07:59
adiroibanlike the last example from the pastebin08:00
henningebut that one still uses is_admin_or_rosetta_expert. Where would that come from.08:02
henninge?08:02
henningeadiroiban: The challange is to control which values the parameters of a method can take in relation to the user that is setting it.08:03
adiroibanhenninge: true. it just replaces the self.isUbuntuAndIsUserTranslationGroupOwner(user)08:03
adiroibanand similar , we can use OnlyRosettaExpertsAndAdmins08:04
henningeadiroiban: To me, security.py is our interface to the zope policy. But we have more policy than that.08:04
adiroibanhenninge: yes. but you can do the same in lib/canonical/launchpad/security.py08:04
adiroibanbut with permission_helper.py, we will end up with code duplicated in security.py08:06
adiroibanas we already have a check similar to is_admin_or_rosetta_expert , in security.py08:06
henningethe idea was to move the code out of security.py to make it usable in model code08:06
henningeadiroiban: yes, and that check should use is_admin_or_rosetta_expert.08:06
adiroibanbut then we still need that code for the view08:06
adiroibanyep08:07
adiroibanok08:07
adiroibanthen reference security_helper from security.py08:07
adiroibanthat is also ok08:07
henningesorry, which code do we need for the view08:07
henningeadiroiban: it does!08:07
henningeadiroiban: security has just not been converted to use these helpers08:08
henningecompletely08:08
henningesecurity.py, I mean08:08
adiroibanhenninge: yes. I see know.08:08
henningeadiroiban: may be permission_helpers is the wrong term08:09
adiroibanthen I should implemenet all the translations security logic in security_helper.py08:09
adiroibanand then use that code from security.py08:09
henningeadiroiban: yes, and call it permission_checkers.py08:09
henningeadiroiban: I am moving the file out of translations into services anyway.08:10
henningeadiroiban: I will do the renaming. Can you wait until my branch is done? This should happen this morning.08:10
adiroibanhenninge: ok. It make more sense now :)08:10
adiroibanyes. no hurry08:11
henningeGreat ;)08:11
henningeadiroiban: actually, danilo wants me to de done with it ... ;)08:11
adiroibanhenninge: but why is not a good idea to use security.py classes in the model ?08:12
henningeadiroiban: I have not thought much about that but my first impression is this:08:13
henningesecurity.py is our interface to the permissions mentioned in the zcml08:13
danilosI don't think it would such a bad idea, especially since they define a permission for a user to a model class08:14
henningeso, if there is a <require> statement on a class that requires a certain permission, there will be a checker or it in security.py08:15
henningebut, as I mentioned before, that does not give us finer control over method parameters.08:15
henningeso we have to add checks in the model about parameter values.08:16
adiroiban@enabled_with_permission('launchpad.Admin') can only be used in the view?08:16
daniloshenninge, right, but those checks can be gotten by using different privileges... ie. if has_perm(user, 'launchpad.Admin'): allow this08:16
henningeIf we want to use the classes from security.py for this, we'd have to add classes there that have no relation to the zcml08:16
danilosadiroiban, you can define in ZML what attributed/methods are accessible for each permission, but there are cases where you want to allow only certain values to be passed in by certain users (i.e. henning has an example of setStatus on translation import queue, where only admins can set any status)08:17
henningeadiroiban: on, it is used on the interface, thus on the model. But it only applies to attributes.08:17
adiroibanyou know better. I see security.py as the place to store all security logic08:17
henningeadiroiban: yes, I think it is a question of what we define security.py to be and what is supposed to be in there.08:18
adiroibandanilos: yep. I saw that code. and maybe we can have those values in a different attribute08:18
adiroiban:)08:18
adiroibanor just do the check in security.py08:18
henningeadiroiban: I thought about that08:19
henningethat would have meant to have seperate "setStatusApproved", "setStatusFailed" etc08:19
henningeor "setStatusAdmin".08:19
henningeI was advised against that at the sprint.08:19
adiroibanhenninge: ok. np.08:20
henningejust saying08:20
adiroibanthen I will add the logic in security_helper.py08:20
adiroibanand make use of it from security.py and from the model08:20
henningeadiroiban: that is how I meant it to be08:21
henningeadiroiban, danilos: but maybe we should take that discussion to the list as this is a general discussion about the use of security.py.08:21
daniloshenninge, yep, sounds like a good idea08:21
henningeok, I will do that08:22
adiroibanhenninge: i think that is ok to move code away from security.py ... as it can become a big file, but I think we should still use the security.py interface from the model. Instead of security_helper.is_admin_or_rosetta_expert() use security.OnlyRosettaExpertsAndAdmins.checkAuthenticated08:26
adiroibanor create a new permission interface08:26
adiroibanbut I will wait for your branch08:27
adiroibanand the discussion from the ml08:27
henningeadiroiban: yes, the discussion will be of most interest as I don't want some-one else to come along next cycle or so and change it all over again. We need some consensus here across the team.08:28
adiroibanhenninge: ok.08:30
henningeadiroiban: I just realised you cannot just use " security.OnlyRosettaExpertsAndAdmins.checkAuthenticated" from model code as checkAuthenticated is not a class method.08:53
henningeadiroiban: you'd have to instantiate OnlyRosettaExpertsAndAdmins first.08:53
adiroibanyes. I'm doing something like this OnlyRosettaExpertsAndAdmins( self).checkAuthenticated(user)08:54
henningeI see08:55
adiroibanI'm running now all tests08:56
adiroibanand see if there are problems08:56
mrevellmorning09:18
maxbHi, I have a trivial lp-dev-deps change, if someone has a moment: https://code.edge.launchpad.net/~maxb/meta-lp-deps/no-pullparser/+merge/1623210:07
jtvhi mrevell!  you have nag mail.  :-)10:35
mrevelljtv, thanks, I see it :) Will get to it today10:36
* jtv cheers mrevell on10:36
mrevellheh10:36
stubhenninge: A long, long time ago we specced out a system of crowds, where you would construct a crowd by combining teams and peoples. You could then query the crowd to see if a person was or was not a member of that crowd. Designed to be DB friendly, but also would make nicer things like is_admin_or_rosetta_export()10:52
henningestub: sounds cool10:53
jtval-maisan_: do you know if there are any current plans to move Build.sourcepackagerelease (and the stuff that relies on it) into BuildPackageJob?10:55
al-maisan_jtv: on the phone, ttyl10:55
jtvpl10:55
jtvok10:55
stubhenninge: The crowd was really just a list of Person (or even just their ids), and the 'is in' and 'isn't in' operations just single queries against the TeamParticipation table.10:56
deryckMorning, all.11:04
=== matsubara-afk is now known as matsubara
al-maisan_jtv: AFAIU there are no plans to relocate Build properties into BuildPackageJob11:13
al-maisan_jtv: why do you ask :)11:13
jtval-maisan_: my question was misguided.  I don't need a Build for our prospective BuildFarmJob implementation, do I?11:13
jtvhi deryck11:13
al-maisan_jtv: you probably don't .. what data/properties do you envision being in your "TranslationFarmJob" ?11:15
jtval-maisan_: a reference to the branch it should gets its data from.11:15
al-maisan_jtv: in that case it would seem there's no need to reference a `Build`11:16
jtvbigjools, is this the right interpretation of you described on the phone?  http://rookery.canonical.com/~jtv/farmjob.dia11:48
bigjoolscan you turn that into a PNG?11:49
jtvbigjools: with the power of free software, yes I can!11:49
jtvbigjools: http://rookery.canonical.com/~jtv/farmjob.png11:50
jtvbigjools: and then I gather our BuildFarmJobBehavior would receive a BuildQueue entry to work on11:51
bigjoolsjtv: it's a bit corrupted11:57
bigjoolsis the << Iwhatever >> part supposed to be an "implements" ?11:57
jtvbigjools: yes11:57
jtvalthough maybe the base class does that... not too important I guess :)11:58
bigjoolsjtv: ok it's wrong on your translations one then :)11:58
jtvbigjools: ahhh, they're both wrong actually: meant to say IBuildFarmJob on both11:58
bigjoolsjtv: that's the basic gist of things, yes.  Although you will need content classes and builder behaviours as well.11:59
jtvbigjools: I knew about the behaviors but left them out here because I'm focusing on db schema right now... what are the content classes for?11:59
bigjoolsjtv: scratch that you already have one, sorry12:00
jtvah, branch :)12:00
bigjoolsbbiab12:01
danilosadiroiban, hi, have you done the QA on https://bugs.edge.launchpad.net/rosetta/+bug/406477 as well?12:17
mupBug #406477: Need more permissions on admin template pages for ubuntu-translations-coordinators <qa-needstesting> <Launchpad Translations:Fix Committed by adiroiban> <https://launchpad.net/bugs/406477>12:17
=== jelmer_ is now known as jelmer
* adiroiban looking12:18
maxbsalgado: Hi. If you're around, I'm going to be doing a lp-deps upload today, if you wanted to put the ssh removal in too12:22
salgadohi maxb.  I'll try to get that in before you upload, but if it's not there by the time you get to it, don't worry12:29
salgadounless you want to do it yourself and get the blame^Wcredit for it12:29
jtvadiroiban: need help with that Q/A?  I have an unprivileged account for comparison12:36
adiroibanjtv: yes. please test this link https://translations.launchpad.net/ubuntu/karmic/+source/kdepim/+pots/kxforms/+admin12:37
adiroibando I need to create a test account on edge or staging is also ok?12:38
adiroibanI'm new to LP qa process12:38
jtvadiroiban: staging should be fine, provided you're sure that your branch has been rolled out there12:38
adiroibani can not access staging right now12:39
=== Ursinha-afk is now known as Ursinha
GOTTMODUSHi everyone12:41
GOTTMODUSto wich user is the svn import branch review going?12:42
jtvno need to shout!  :)12:42
GOTTMODUSi cant see ist from the default users site12:42
GOTTMODUS??12:42
GOTTMODUSwhere did i shout?12:42
jtvgottmodus: your nick12:42
GOTTMODUSah ok12:42
jtvadiroiban: same here...  and getting a "not found" for that page on edge.  We're expecting an "access denied," no?12:42
adiroibanjtv: no. I should be ok12:43
jtvgottmodus: the joke does work better with all caps, but it's a bit noisy nonetheless :-)12:43
adiroibanthe Navigation is breacking that chain12:43
adiroibanjtv: I have tested as an UTC and everything is ok12:45
jtvadiroiban: it's a bit weird though that it says "there's no page with this address in Launchpad" when it should say that I'm not allowed to access the page12:49
adiroibanjtv: that was the same case in the previous implementation12:50
jtvadiroiban: in that case, no worry here.  :)12:50
adiroibanjtv: you can try on lp.net12:51
adiroibanjtv: i disabled my redirection for edge, and tested on stable and I also got a page not found error12:52
adiroibanjtv: there should not be a problem, since the user does not see the admin link12:52
adiroibanjtv: actually, neither do UTCs ... as the +templates pages times out12:53
jtv:(12:53
wgrantbigjools: Do you know if dpkg + buildds are upgraded for tomorrow's rollout?12:54
jtvadiroiban: from an unprivileged account I see neither the link to that page, nor the same for another (non-deactivated) template.  So looks good to me.12:56
bigjoolswgrant: in progress, but not yet AFAIK12:57
adiroibandanilos: I don't know what to say. I have tested on my computer, and tested on edge as UTC. Everything was ok. Also the test was written to cover an anonymous, a logged in user and an Admin13:01
danilosadiroiban, right, it was mostly to do some QA, since you haven't marked it as qa-ok in the bug... also, QA is usually done on edge and/or staging, you might be surprised, but many things break only when we hit production database :)13:02
jtvadiroiban: did D. find something wrong with the branch?13:02
adiroibanjtv: I don't know. He approved it13:03
jtvjust confusion over the qa process then I guess?13:03
adiroibanjtv: yes. I did not tag it with qa-ok13:04
adiroibanbut only qa-needtesting13:04
jtvWe're weird that way. :)  It's a pretty nice system actually.13:04
adiroibanI was thinking that I should mark qa-needtesting, whey I need someone else to also look into it13:04
jtvadiroiban: it should happen automatically (though we did have some breakage recently)13:09
adiroibanjtv: well I don't know how things should be going... so as always... I am very confused13:10
jtvadiroiban: need a summary?13:10
adiroibanjtv: or a wikipage ? :)13:11
jtvadiroiban: don't think we have one for this, since it's still only on an experimental scale...13:11
adiroibanjtv: so when my branch is merged with a fixes=lp:222 the bug report is updated to fix-comminted and qa-needtesting tag is added?13:12
adiroibanand then I have to test the commit on devel/staging and set it to qa-ok ?13:12
jtvadiroiban: the bug status is not updated to "fix committed" iirc, but otherwise, yes13:12
jtvAnd you try to Q/A on staging or edge, not just devel because of the unexpected differences that real-life data can make (see what D. said above)13:13
adiroibanjtv: I have tested all my bugs targeted for this release and tagged them with fix-ok13:13
jtvadiroiban: we usually just verb "QA" to avoid confusion with the test suite.13:14
adiroibanjtv: ok. thanks for the jargon update :)13:15
jtvGlad you don't mind; I know I'm pedantic but who knows what confusion it may save later :)13:15
=== jtv is now known as jtv-eat
adiroibanwell I still have problems with page tests / stories / functional tests ... etc13:16
beunoBjornT, bug 49740513:26
beuno\o/13:26
mupBug #497405: Run Windmill tests by default <story-windmill-layer> <Launchpad Foundations:In Progress by bjornt> <https://launchpad.net/bugs/497405>13:26
BjornTbeuno: i'm really looking forward not having to monitor the jscheck builder constantly, and chase people to fix things. better to have buildbot take care of that :)13:29
beunoBjornT, yeah, and I'm happy to never have to stare at flacoste when we mention tests slowing people down to develop awesomeness13:30
salgadoBjornT, can we use utilities/ec2 to run the windmill tests?13:36
BjornTsalgado: yes. if you grab my branch, you can.13:37
salgadoBjornT, wow, I was expecting a "not yet" answer.  this is great news13:44
salgadoI might even review your branch13:44
beunojoey, have you changed your default font settings?13:57
joeythat was fast :-)13:58
joeybeuno: no13:58
joeyshould I?13:58
beunojoey, that that I don't trust you13:58
beunobut13:58
beunowhat's the values?  :)13:58
beunowhat are13:59
beunoserif, 16, monospace, 12?13:59
beunojoey, Preferences > Content > Fonts / Advanced14:00
joeyLoading FF. Was in chrome14:00
joeycan't find the option in chrome14:01
joey16 and 12 in FF14:01
beunohm14:01
beunoand you see all bug pages with the side portlets at the bottom?14:02
joeyyes14:02
joeyon both FF and chromium14:02
joeystarted about a week ago14:03
joeyor more14:03
joeyI was out for a few weeks14:03
joeyit was like that when I came back to work14:03
beunojoey, and your fonts14:03
beunosystem fonts14:03
beunoin appearance14:03
beunoare they set at 10?14:03
joeyafaict, nothing has changed14:03
joeyit happens on two different computers14:03
joeymy desktop and my netbook14:03
* joey looks at his sys fonts14:04
joeyas soon as I figure out where they are. I'm not a font junkie14:04
joeyall listed as 10 on my desktop14:04
beunoI'm running out of ideas14:04
beunoWFM (and I think, in general)14:05
joeytry css :-)14:05
beunoone last test14:05
beunocan you start firefox with a clean profile, no addons?14:05
joeysure14:05
beunook14:06
beunoI can reproduce now14:06
beunojoey, not needed14:06
beunoif you have your browser wide enough14:06
beunoit happens14:06
joeyyeah I JUST now noticed that14:06
beunoyou probably have 1600+ res, right?14:06
joey1920 on the desktop, 1280 on the netbook14:06
joeythe clean profile I opened in a window and it was correct, and when I maximized, poof14:07
beunoI can't reproduce it in 1280, but now we know there's an issue there14:07
beunosinzui, where you aware ^>14:07
sinzuibeuno: danilo remarked upon it. I could not reproduce it to identify if we need to add a css rule or markup to base-layout.pt14:09
joeybeuno: a side note... all my computers are widescreens14:17
joeybeuno: so that may be why I see it at other resolutions14:17
beunojoey, yeah, very likely14:17
beunoif the width of the sidebar is seto to 17%14:18
beunoit doesn't break14:18
beunojoey, bug 49351814:27
mupBug #493518: Side portlet moved again below the main content on wide-screen displays (1920x1200) <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/493518>14:27
Pilkybeuno: if it helps, Safari 4 doesn't have the issue, I can spread my browser window across 2 displays and it works fine14:36
beunoPilky, interesting...14:36
Pilkylet me just try firefox14:36
Pilkyoh wait, does happen in safari14:38
Pilkyhad the wrong bug visible14:38
beunook, that's good news then  :)14:38
=== vednis is now known as mars
=== matsubara is now known as matsubara-lunch
=== salgado is now known as salgado-lunch
danilosjoey, beuno, sinzui: there was a bug along those lines before, which I fixed, but it's back with a vengeance when #maincontent CSS was removed: https://bugs.edge.launchpad.net/launchpad-foundations/+bug/43534615:55
mupBug #435346: 3.0 interface overflows sidebars and causes horizontal scrolling if you manually change browser font sizes <qa-ok> <Launchpad Foundations:Fix Released by danilo> <https://launchpad.net/bugs/435346>15:55
=== henninge_ is now known as henninge
=== jamalta is now known as jamalta|work
=== matsubara-lunch is now known as matsubara
=== Ursinha is now known as Ursinha-lunch
=== salgado-lunch is now known as salgado
=== abentley1 is now known as abentley
=== beuno-lunch is now known as beuno
=== elmo__ is now known as elmo
=== Ursinha-lunch is now known as Ursinha
=== mrevell is now known as mrevell-dinner
james_whow does a branch become owned by ~vcs-imports?18:00
james_wI just requested an import and it is under ~james-w, I assumed it went under the former18:00
=== deryck is now known as deryck[lunch]
cody-somervillejames_w, it shouldn't be under ~james-w unless thats changed.18:01
cody-somervillejames_w, whats the branch?18:01
james_w~james-w/alsa-driver/trunk18:02
=== mbarnett` is now known as mbarnett
=== matsubara_ is now known as matsubara
salgadosinzui, is there any reason why registry/templates/object-timeline-graph.pt doesn't use the new stylesheet?18:36
sinzuisalgado: yes it is in an iframe. It should be just canvas and thus not use any css18:37
sinzuisalgado: if the template now has markup displayed to users, we need to reconsider this18:37
salgadosinzui, oh, right, my question was actually: "why does it use the old stylesheet instead of the new one".18:38
salgadoshould it use none?  I'd be more than happy to change that18:39
sinzuisalgado: I do not think it needs css, I see every element uses a style attribute to disable the default. If I am wrong, it must use style-3.0.css.18:41
salgadook, I'll remove the launchpad-stylesheet macro from it and see what happens18:42
=== EdwinGrubbs is now known as Edwin-lunch
=== deryck[lunch] is now known as deryck
mwhudsongood morning19:46
thumpermorning19:58
=== matsubara is now known as matsubara-afk
thumpermwhudson: I changed the url for https://code.edge.launchpad.net/~vcs-imports/analysesi/main, but the update still looks at the old location20:10
thumpermwhudson: I'm pretty sure it is the same repository, just at a different location20:10
thumpermwhudson: how do we blow away the existing checkout?20:10
=== mthaddon changed the topic of #launchpad-dev to: Launchpad will be down/in read-only from 22:00 UTC until 23:00 UTC for a code update | Launchpad Development Channel | Week 4 of 3.1.12 | PQM is closed; RC only (https://dev.launchpad.net/CurrentRolloutBlockers, RM: danilos) | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in #launchpad-reviews | Use http://paste.ubuntu.com/ for pastes
mwhudsonthumper: oh for CVS its completely terrible20:10
mwhudsonthumper: https://wiki.canonical.com/InformationInfrastructure/OSA/LPHowTo/UpdateCodeImportLocation20:11
mwhudsonthumper: needs a LOSA :(20:11
thumperok20:11
thumpermwhudson: ew20:12
mwhudsonthumper: yes20:13
=== salgado is now known as salgado-afk
* mwhudson fights with storm20:15
sinzuibac: what are your plans for Bug 44741820:36
mupBug #447418: Timeout with large milestone with lots of private bugs <timeout> <Launchpad Registry:In Progress by bac> <https://launchpad.net/bugs/447418>20:36
bacsinzui: don't know yet20:47
bacsinzui: just started looking.20:47
thekornintellectronica, hi, thanks to you guidance last evening I managed to fix bug 497108, I attached the branch and a screenshot of the result.20:53
mupBug #497108: show changes to the affected product field of a task in the interleaved activity log <Launchpad Bugs:New> <https://launchpad.net/bugs/497108>20:53
thekornwhat's the next step?20:53
intellectronicathekorn: that's wonderful! thank you so much for taking on this work20:53
intellectronicathekorn: go ahead and propose the branch for merging. i can review it now. the tree is closed right now (release in 1h) but we can land this as soon as it opens again20:55
thekornok20:56
=== Edwin-lunch is now known as EdwinGrubbs
thekornintellectronica, created merge proposal at https://code.edge.launchpad.net/~thekorn/launchpad/affects_in_interleaved_activitylog/+merge/1626121:00
sinzuibac: sorry, I was called away to get children from the local institution21:01
intellectronicathekorn: huh, that's a very small diff :)21:01
thekornintellectronica, yes, that surprised me too21:02
intellectronicathekorn: we do need to add a test, though, to demonstrate the new behaviour21:02
sinzuibac: I was pondering (this weekend) of converting. the bug table to an ajax call like subscribers. I need to see all the bugs when looking at a milestone, so I am not keen to use a batch navigator.21:02
thekornintellectronica, that's what I thought, can you point me to a place where I should add them21:03
thekornshould I add a doctest or a unittest21:03
sinzuibac: my plan may be total rubbish because the SQL time on the page is very good as I recall. Most of the time was in python, and I think it is in the status counts, the same code we disabled on series because they caused timeout.21:03
intellectronicathekorn: there should be a story test somewhere, looking for it21:03
* sinzui suspects something with enums, but he really does not know wtf is wrong with the code21:04
thekornintellectronica, and most importantly: is there a way to only run relevant test, and not this huge testsuite21:04
intellectronicathekorn: of course :) `bin/test -vv -t $pattern` where pattern is a regex matching the paths of the tests you'd like to run21:05
thekornok, so stories are doctests, nice21:07
sinzuithekorn: that is almost nice. most stories are mediocre function tests instead of user integration tests.21:08
intellectronicathekorn: see lib/lp/bugs/stories/bugs/xx-bug-activity.txt21:09
intellectronicathekorn: to run it, go `bin/test -vv -t xx-bug-activity.txt`21:09
thekornok, lets try to compile a test21:15
sinzuiI think I just approve the last two mailing lists that will ever need approval21:42
sinzuiI think I just approved the last two mailing lists that will ever need approval21:42
bacsinzui: yeah, as soon as i started looking at this problem i ran into our friend get_status_counts21:47
sinzuiIt looks so simple to loop of a fixed set of object that are cached. yet I suspect something is not cached, or worse, the access of status is very costly21:49
wgrantWhen is 3.2.1/3.1.13/whatever it is?21:53
sinzuiwgrant: I think we are going to rename the series 10.05 and the milestone will be named 01 after the month21:55
sinzuiwgrant: We are trying to use series like we tell other projects21:56
al-maisan_sinzui: the series?21:56
wgrantsinzui: But that's barely useful, since LP doesn't really release, and has no use for series.21:56
sinzuial-maisan_: yes rename the series to make sense, and the milestone to be the month21:56
sinzuior the step21:56
wgrantAnyway, I don't really care about how it's spelt -- what is the targetted release date?21:57
sinzuiwgrant: it does not make sense to ever create a new series since we do not release, but since a series sets the focus of development, and we mean to be very focused for this series, we would be insane to create another series21:57
sinzuiI wish I knew. I took a guess for the registry21:58
wgrantAh. And when is ~launchpad on vacation?21:58
thumperwgrant: for me, real soon now :)21:59
sinzuiI think we stop getting paid to work on the 25 of December and most of us return on  January 221:59
thumpersinzui: 2nd is a Saturday21:59
wgrantAh, so just the week. Great.21:59
sinzuithumper: true.22:00
bacthumper: you don't get paid for saturdays?22:00
sinzuiI hope not, otherwise management would tell me to stop woring on what I want to work on22:01
sinzuiI started a branch to add karma to registry actions (with the ulterior motive to wire all the events so that I can send notifications and create sparklines). I hope to finish over the holidays22:03
=== mbarnett changed the topic of #launchpad-dev to: Launchpad will be down/in read-only from 22:00 UTC until 23:59 UTC for a code update | Launchpad Development Channel | Week 4 of 3.1.12 | PQM is closed; RC only (https://dev.launchpad.net/CurrentRolloutBlockers, RM: danilos) | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in #launchpad-reviews | Use http://paste.ubuntu.com/ for pastes
=== mbarnett changed the topic of #launchpad-dev to: Launchpad will be down/in read-only from 22:00 UTC until 01:00 UTC for a code update | Launchpad Development Channel | Week 4 of 3.1.12 | PQM is closed; RC only (https://dev.launchpad.net/CurrentRolloutBlockers, RM: danilos) | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in #launchpad-reviews | Use http://paste.ubuntu.com/ for pastes

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!