=== mwhudson_ is now known as mwhudson
[08:22] <mwhudson> jml: https://code.edge.launchpad.net/~mwhudson/launchpad/recipe-model-code/+merge/16272 if by some freak event you're still around
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue [jpds] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[11:10]  * noodles775 checks for jpds' mp
[11:11] <noodles775> Seems to be reviewed already.
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue [] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: -, - || queue [] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[11:14] <jpds> noodles775: ui review for the changes would be good.
[11:14] <noodles775> jpds, ok, will do!
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: -, - || queue [jpds-ui] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado-afk is now known as salgado
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: jpds-ui, - || queue [] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[12:06] <jpds> noodles775: Ah, that ubuntu-team thing is... interesting.
[12:07] <jpds> noodles775: I think we should just be able to remove people silently as the bug report says, but adding should still notify people.
[12:07] <jpds> Have to fix the template now.
[12:16] <jpds> Is there a way of having multiple tal:condition='s in one <span> ?
[12:17] <adiroiban> jpds: nope. but you can use python to handle complex conditions
[12:18] <adiroiban> tal:condition="python: PYTHON WONDERS LAND"
[12:18] <adiroiban> and view/something is view.something
[12:25] <jpds> adiroiban: Neat.
[12:25] <jpds> noodles775: Thanks for the review, I've fixed the issues you pointed out.
=== adiroiban changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: jpds-ui, - || queue [adiroiban(bug-492375)] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[12:51]  * maxb would like to enqueue https://code.edge.launchpad.net/~maxb/meta-lp-deps/no-sshd/+merge/16280
=== maxb changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: jpds-ui, - || queue [adiroiban(bug-492375), maxb#495454] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:00] <noodles775> jpds: regarding always notifying on enabling - yes, I think you're right. I was thinking specifically about the case where:
[13:01] <noodles775> an admin silently deactivates a membership, but then needs to re-enable it as it was a mistake, but in that case, there's no need to do it silently - a mistake can be admitted :)
[13:01] <noodles775> jpds: and thanks for implementing the other suggestions!
[13:07] <jpds> noodles775: Interesting situation, althought I'd imagine that this feature would be used with caution.
[13:09] <jpds> noodles775: Pushed final changes, you can land if you're happy with the changes.
[13:10] <noodles775> jpds: thanks! I'll leave the landing to bac when he re-reviews the code changes.
[13:11] <jpds> \o/ Awesome.
[13:18] <noodles775> maxb: sorry, I'm not so familiar with the lp dependencies - is there a reason why you've not incremented the version to 0.62 and added a new changelog entry, rather than editing the 0.61 entry that you created with r67?
[13:21] <noodles775> adiroiban: thanks for the details in your MP. Unless I hear from sinzui (he may want to take it) I'll start a UI review in an hour or so, and leave the code to al-maisan.
[13:22] <adiroiban> noodles775: sure. there's no hurry
[13:28] <jpds> Hmm, now that the rollout is done, does that mean that we can land https://code.edge.launchpad.net/~jpds/launchpad/fix_176396/+merge/16082 ?
[13:29] <maxb> noodles775: Because 0.61 hasn't been built/uploaded yet
[13:29] <noodles775> maxb: ah thanks. I've already approved it.
[13:46] <leonardr> salgado: can you spare a couple minutes to help me wrap up the launchpad anonymous-access branch?
[13:46] <salgado> leonardr, sure, what's up?
[13:47] <leonardr> salgado: http://pastebin.ubuntu.com/343545/
[13:47] <leonardr> i made a tarball of launchpadlib 1.5.4 (pre-release) and changed launchpad to use it
[13:47] <leonardr> i ran the tests last night and they all passed
[13:47] <leonardr> so if you'll approve that branch i can land it
[13:48] <salgado> sure, looks good to me, but you won't be able to land it as pqm is closed
[13:50] <leonardr> argh. i always lose track. when does it reopen? next year? and how can i find that information as someone who only does a launchpad branch very occasionally?
[13:51] <maxb> noodles775: What's the proper [r=] tag for you? I had assumed it was LP username, but I see you're michael.nelson there, but I'm fairly sure I've seen [r=noodles] in the past
[13:52] <noodles775> maxb: yeah, noodles is it.
[14:04] <maxb> gah, and after asking that, I got carried away with debcommit and forgot to add it
[14:24] <al-maisan> noodles775: how does the ui/code review split work?
[14:25] <noodles775> al-maisan: you just do a normal code review.
[14:25] <al-maisan> noodles775: OK, thanks!
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: jpds-ui, adiroiban(bug-492375) || queue [maxb#495454] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:35] <al-maisan> hello adiroiban : just making sure I understand things properly: should I see the "View all languages" link on https://translations.launchpad.dev/ubuntu when I am *not* logged in?
[14:36] <adiroiban> al-maisan: yes
[14:38] <al-maisan> adiroiban: pebkac, I started looking at the page prior to merging your branch :P
[14:38] <al-maisan> sorry
[14:38] <adiroiban> al-maisan: well... you lost me :)
[14:39] <adiroiban> ah.
[14:39] <al-maisan> adiroiban: don't worry .. I just need to merge your branch ..
[14:39] <adiroiban> google put me back on track :)
[14:42] <al-maisan> adiroiban: based on geoip the following languages are offered to me while I am logged off: afrikaans; sotho, southern; xhosa, zulu
[14:43] <al-maisan> that's a bit funny since I am based in DE
[14:43] <adiroiban> yep...
[14:43] <adiroiban> I did not changed that code
[14:43] <al-maisan> adiroiban: no problem -- just commenting on it..
[14:44] <adiroiban> adiroiban: yep. I know. Jeroen told me they are thinking to remove that feature
[14:44] <adiroiban> still, in the current code I'm just using the list
[14:50] <al-maisan> adiroiban: the page you described in the "Demo and Q/A" works as expected .. now on to the code
[14:50] <adiroiban> hooray
[15:00] <al-maisan> I am getting this error when I run a windmill test:
[15:00] <al-maisan>   Set up lp.translations.windmill.testing.TranslationsWindmillLayer <type 'exceptions.KeyError'>:
[15:00] <al-maisan> 'MOZILLA_BINARY'
[15:01] <al-maisan> any idea what it means?
[15:01] <al-maisan> this is the full paste: http://pastebin.ubuntu.com/343602/
[15:02] <leonardr> noodles776 or al-maisan, can you put a quick contrib branch in the queue?
[15:02] <leonardr> https://code.edge.launchpad.net/~rick-rickspencer3/lazr.restfulclient/add_gaurd_for_None_to_eq_functions/+merge/16043
[15:02] <adiroiban> do you have firefox installed in the right location?
[15:02] <leonardr> review my revised diff, not the original branch. (i can push another branch if you want, but i'd like to keep the review here)
[15:03] <al-maisan> adiroiban: ah, that explains it, I don't have firefox installed at all -- this is run in a chroot
[15:03]  * al-maisan installs firefox
[15:03] <adiroiban> :)
[15:03] <adiroiban> This is my first windmill test
[15:03] <al-maisan> noodles775: could you take the branch that leonardr asked about .. I'll need to attend the other meeting in an hour..
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: jpds-ui, adiroiban(bug-492375) || queue [adiroiban-ui, maxb#495454, leonardr] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: -, adiroiban(bug-492375) || queue [adiroiban-ui, maxb#495454, leonardr] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:05] <noodles775> al-maisan: i've put it in the queue for the moment, so either I or one of the US reviewers will get to it :)
[15:05] <al-maisan> noodles775: good man :) thanks!
[15:07] <noodles775> leonardr: I don't understand - haven't you just reviewed that LAZR branch? or at least asked for changes (extra tests)?
[15:09] <leonardr> noodles775: i pointed out that there were no tests, and went ahead and added the tests because rick isn't on irc and i figured that was the best way to show him how the test system worked
[15:09] <leonardr> but since my code is now in the branch i don't want to approve my own code
=== salgado is now known as salgado-lunch
[15:10] <noodles775> leonardr: right - I was confused because the revision with your tests wasn't yet showing on the branch (on the MP).
[15:10] <noodles775> Still isn't, but I assume it'll appear soon :)
[15:11] <leonardr> noodles: i don't think i can push to the branch--it's rickspencer3's branch
[15:11] <leonardr> that's why i offered to push a different branch, but said i'd prefer that the review happen in the original
[15:12] <noodles775> leonardr: Sorry - I should read a bit more thoroughly before asking questions. OK, I'll review it with your tests and assume they'll be included.
[15:12] <leonardr> yeah, my branch is what i'll merge
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: adiroiban-ui, adiroiban(bug-492375) || queue [maxb#495454, leonardr] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== jamalta_ is now known as jamalta
[15:16] <al-maisan> adiroiban: this windmill test fails on my system (maybe due to my strange setup):
[15:16] <al-maisan> test_results: ERROR    Test Failure in test {'version': '0.1', 'suite_name': 'SeriesLanguages Tables', 'result': False, 'starttime': '2009-11-17T20:43:5.858Z', 'output': None, 'debug': 'Looking up name loginpage_submit_login, failed.', 'params': {'name': 'loginpage_submit_login', 'uuid': 'acee01d8-eb1e-11de-a198-00218652d375'}, 'endtime': '2009-11-17T20:43:5.859Z', 'method': 'asserts.assertNode'}
[15:17] <adiroiban> al-maisan: ah... that is part of user.ensure_login(self.client)
[15:17] <adiroiban> and it fails for all windmill tests
[15:17] <al-maisan> adiroiban: good to know :) thanks!
[15:18] <adiroiban> from canonical.launchpad.windmill.testing import lpuser
[15:18] <adiroiban> and I'm using user = lpuser.TRANSLATIONS_ADMIN
[15:19] <adiroiban> to get a user for which I know the preferred languages
[15:19] <adiroiban> I think the windmill test are still very fragile
[15:19] <adiroiban> for translations
[15:19] <adiroiban> are are only 2 or 3 other windmill tests
[15:20] <al-maisan> adiroiban: so, I am wondering: will this also fail after the branch is reviewed and submitted to PQM?
[15:20] <adiroiban> al-maisan: the translations Windmill test are disabled in pqm
[15:20] <adiroiban> tests
[15:21] <al-maisan> adiroiban: ah, yes, that's right!
[15:21] <al-maisan> thanks again!
[15:21] <adiroiban> np
[15:29] <al-maisan> adiroiban: you added isPreferredLanguage() twice .. is there any particular reason for that?
[15:30] <adiroiban> it should be an error 
[15:30] <adiroiban> let me check
[15:30] <adiroiban> on is for distroseries
[15:30] <adiroiban> and the other is for productseries
[15:30] <adiroiban> but that should be all
[15:30] <al-maisan> yes
[15:31] <al-maisan> was there no good place to put it once and reuse it?
[15:32] <adiroiban> no
[15:32] <adiroiban> we talked about that in the pre-implemetnation call
[15:32] <al-maisan> aha
[15:32] <adiroiban> in the future we should have a single serieslanguage view
[15:32] <adiroiban> for both product and distro
[15:32] <adiroiban> right now also preferred_languages
[15:34] <adiroiban> implements the same logic
[15:34] <adiroiban> in both classes
[15:35] <adiroiban> i think there is a bug about than creating the interface... and if not, I will add it now
[15:37] <al-maisan> adiroiban: cool .. please provide me with the bug number.
[15:37]  * adiroiban is searching 
[15:38] <adiroiban> bug 496361
[15:38] <mup> Bug #496361: Register a single view (SeriesLanguageView)  for all ISeriesLanguage-implementing objects <Launchpad Translations:New for adiroiban> <https://launchpad.net/bugs/496361>
[15:38] <al-maisan> adiroiban: thanks !
[15:38] <adiroiban> but there is a lot of refactoring work in there 
[15:39] <adiroiban> so maybe after analyzing it, it should be splited in other bugs
[15:39] <al-maisan> sure, no problem
[15:40] <al-maisan> adiroiban: there is one little typo (please see the review email), otherwise r=me
[15:41] <adiroiban> al-maisan: thanks. I'll fix it and push the changes right away... anyway we can not land it now
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: adiroiban-ui, <meeting> || queue [maxb#495454, leonardr] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:45] <adiroiban> al-maisan: i don't see any info about the typo
[15:45] <noodles775> adiroiban: ok, I've just sent the ui review too... great work!
[15:45] <al-maisan> adiroiban: just a sec
[15:45] <adiroiban> sure
[15:46] <al-maisan> + * Set up initial the visibility for languages in a serieslanguages table.
[15:46] <al-maisan> should probably read:
[15:46] <al-maisan> "Set up the initial visibility.." ?
[15:46] <al-maisan> adiroiban: ^
[15:46] <adiroiban> yes. sorry for that. 
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: maxb#495454, <meeting> || queue [leonardr] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:47] <al-maisan> adiroiban: take it easy :) erring is human, and, your branch looked great otherwise.
[15:48] <noodles775> Sure did/does!
=== noodles775 changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: leonardr, <meeting> || queue [] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:50] <al-maisan> noodles775, adiroiban: my review email appeared with some delay but it's there now.
[15:50] <adiroiban> al-maisan: ah. ok. np
[15:58] <adiroiban> noodles775: regarding word capitalization. I agree
[15:58] <adiroiban> but I tried to be consistent with the previous implementation
[15:59] <adiroiban> https://translations.edge.launchpad.net/ubuntu/karmic/+source/gfxboot-theme-ubuntu/
[15:59] <adiroiban> so then I should also open a bug for that
[15:59] <adiroiban> ?
[16:00] <noodles775> adiroiban: yeah, I saw that you'd kept it consistent. I don't think it's worth a bug to fix the capitalization - it's easy enough to do little drive-by cleanups like this when the page is touched. Up to you.
[16:01] <adiroiban> noodles775: ok. I will change it in this branch
[16:01] <noodles775> Great, thanks!
=== salgado-lunch is now known as salgado
[16:05] <adiroiban> noodles775: I will also hide the „Show all languages” when not needed. I was thinking that most translators/visitors will define their preferred languages and I was avoiding to much logic in that view
[16:08] <noodles775> adiroiban: ah, is "English" the default if a person has never set their preferred language? I didn't realise that. But yes, there could be a lot of people in that situation.
[16:08] <noodles775> (I mean, as in "English" is actually selected, as opposed to not having any preferred language selected).
[16:11] <salgado> adiroiban, did you run the test suite after doing the test changes you just added to https://code.edge.launchpad.net/~adiroiban/launchpad/bug-427319/+merge/15994?
[16:13] <adiroiban> salgado: is running
[16:13] <adiroiban> not finished yet
[16:13] <salgado> adiroiban, I think it won't work because your changes expect view.initialize() to return the view, but it doesn't
[16:16] <adiroiban> salgado: true
[16:17] <adiroiban> salgado: i need to do self.view.initialize()
[16:17] <salgado> right
=== al-maisan changed the topic of #launchpad-reviews to: on call: noodles775, al-maisan || reviewing: leonardr, - || queue [] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:18] <salgado> adiroiban, it may be that you don't even need to instantiate the view again -- just calling .initialize() on it when you update stuff might be enough
[16:20] <adiroiban> salgado: indeed ... now testing
[16:24] <adiroiban> salgado: is working for @property but not for @cachedproperty
[16:24] <salgado> right, that's expected.  I'd forgotten there was a cached property
[16:26] <adiroiban> I'll push the changes and start a full test using that code
=== noodles775 changed the topic of #launchpad-reviews to: on call: al-maisan || reviewing: - || queue [] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== al-maisan changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [] || RC candidates take priority || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:05] <leonardr> gary: https://code.edge.launchpad.net/~leonardr/launchpadlib/use-shorthand-uris-in-all-tests/+merge/16298
[17:06] <leonardr> the diff is here if you need it:
[17:06] <leonardr> http://pastebin.ubuntu.com/343631/
[17:07] <gary_poster> leonardr: on it
[17:10] <gary_poster> leonardr: my only thought is that it might be nice to explain what that test_dev string is in introduction.txt.  Agree?
[17:12] <gary_poster> (and where it is defined)
[17:19] <leonardr> gary, sure
[17:20] <gary_poster> leonardr: ok, will merge-conditional on that then
[17:21] <leonardr> gary: it's defined in uris
[17:22] <gary_poster> leonardr: yeah, I saw that in the diff.  I meant that it would be nice to have an explanation in the text
[17:22] <leonardr> sure
[17:37] <leonardr> gary: ok, you should be able to update launchpadlib and do a release now
=== fjlacoste is now known as flacoste
[18:09] <gary_poster> leonardr: http://paste.ubuntu.com/343640/
[18:10] <leonardr> wtf, how did that test not get run
[18:10] <leonardr> it looks like they haven't been run for a while
[18:10] <leonardr> that first failure looks like it was caused by a change landed while i was on vacation
[18:14] <leonardr> gary: ok, the problem is that testing launchpadlib in a launchpad context only runs the doctests, not the unit tests
[18:14] <gary_poster> leonardr: ah ok
[18:14] <leonardr> i and others have only been running the doctests. i'd like to fix launchpad to run the unit tests too, but i'll settle for fixing the tests for now
[18:16] <gary_poster> fair enough
[18:17] <gary_poster> maybe add a bug for getting launchpad to run the unittests?
[18:18] <leonardr> yeah
[18:18] <leonardr> if allenap were around i'd have a better shot at fixing this stuff, he landed the two branches
[18:18] <gary_poster> urg. :-(
[18:19] <gary_poster> yeah, the last one was the only one that clearly pointed to your recent changes
[18:24] <leonardr> gary: there's a chance it might be more fallout from my login_With refactoring
[18:24] <gary_poster> leonardr: ok.  You agree that we ought to give you a chance to fix these before making a release?
[18:25] <leonardr> gary: yes
[18:25] <gary_poster> cool
[18:49] <leonardr> gary: https://code.edge.launchpad.net/~leonardr/launchpadlib/test-failures/+merge/16303
[19:45] <gary_poster> leonardr: approved (sorry was on calls)
[19:45] <gary_poster> leonardr: going to lunch then will make release
[19:45] <leonardr> gary: np
[19:45] <leonardr> all right
[20:12] <abentley> Is there a team for UI reviewers?
=== salgado is now known as salgado-afk
[20:18] <gary_poster> leonardr: if you make the comment fix and merge then I can make the release
[20:18] <leonardr> gary: i'm having trouble committing
[20:18] <leonardr> https://bugs.edge.launchpad.net/bzr/+bug/246233 seems to be happening to me
[20:19] <mup> Bug #246233: TooManyConcurrentRequests error when ssh connection fails (bzr crashes when pulling) <hpss> <5-a-day-data:Invalid> <Bazaar:Fix Released by spiv> <https://launchpad.net/bugs/246233>
[20:19] <leonardr> ok, it seems to have been transient
[20:19] <leonardr> gary: commited now
[20:19] <gary_poster> cool thanks
[20:21] <allenap> gary_poster, leonardr: Hi, I did run the test suite before landing those branches ;) There was one failing test which I filed a bug for iirc, but obviously it's not good now.
[20:22] <leonardr> allenap: it turned out to be my fault
[20:22] <gary_poster> leonardr: did you see my comment about line 39 in the diff?
[20:22] <allenap> leonardr: Oh, phew :)
[20:22] <gary_poster> allenap: what he said. :-) thanks for saying hi though
[20:23] <gary_poster> leonardr: "be returned as is).  :param launchpadlib_dir: The user's" should have a \n in there
[20:23] <leonardr> gary: missed that, i'll fix it
[20:23] <gary_poster> thanks
[20:23] <leonardr> i also fixed a typo that broke a test, but i think i fixed that before you saw the branch
[20:23] <gary_poster> yes you did
[20:24] <gary_poster> the review UI is imporving nicely
[20:24] <gary_poster> improving
[20:25] <leonardr> gary: i also added instructions on developing lazr.* branches and getting them landed to https://dev.launchpad.net/HackingLazrLibraries
[20:26] <gary_poster> leonardr: I saw that in your email to jml but had not read the content.  Looks great, thank you.
[20:29] <leonardr> gary: ok, formatting is fixed
[20:29] <leonardr> hopefully the release will work now and i can give you the stuff to land my launchpad branch once pqm opens
[20:42] <gary_poster> leonardr: everything worked.  going to pick up son.
[20:42] <leonardr> gary: ok, i'll make instructions for you