[00:41] <jml> mwhudson, I'll have a look today
[00:41] <mwhudson> jml: oh thanks
[10:47] <henninge> wgrant: do you have any idea why the config changes you are implementing in your branch were kept on a wiki page?
[10:48] <henninge> wgrant: I mean, as opposed to doing what you are doing now from the start. Did the soyuz team expect problems with these changes?
[10:48] <henninge> noodles775: ^
[10:49] <wgrant> henninge: I just didn't ever submit them.
[10:49] <henninge> wgrant: Oh, you wrote those instructions!
[10:50] <wgrant> henninge: I did.
[10:50] <wgrant> Well, most of them, at least. Various bits have been added since.
[10:50] <henninge> wgrant: So it is a well tested setup?
[10:51] <wgrant> It has been used by only a few people, but it does work.
[10:52] <henninge> I guess what I want to know is if the soyuz team is aware of that, i.e. if you had a  pre-implementation chat about them.
[10:53] <henninge> wgrant: ^
[10:53] <wgrant> henninge: Not really, no.
[10:54] <henninge> wgrant: don't get me wrong, the changes look fine to me.
[10:55] <henninge> but I guess since this does not affect production code, I should not be over-paranoid.
[10:55] <noodles775> I wasn't aware of them, but am all for them.
[10:55] <henninge> wgrant: r=me ;)
[10:55] <wgrant> The process-upload.py invocation is stolen from the production configs, actually.
[10:55] <wgrant> henninge: Thanks. Can you land it?
[10:55] <henninge> wgrant: sure
[10:55] <wgrant> henninge: Thanks.
[10:56] <henninge> wgrant: can you set a commit message, please?
[10:57] <henninge> noodles775: did you just reserve a spot in the queue or do you actually have  an mp ready ... ;-)
[10:58] <wgrant> henninge: Done.
[10:58] <noodles775> henninge: I've got an MP which was already approved, but I've since added a few revisions:
[10:59] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/475808-unembargoing-oops/+merge/16141
[10:59] <noodles775> And since the revs are now displayed inline, you can see which ones :) (The bug has the information about what failed during QA on dogfood etc., as well as the new QA which went through df fine).
[11:00] <noodles775> henninge: are you OCR'ing today?
[11:01] <noodles775> or just being very helpful :)
[11:01] <henninge> noodles775: no, I was going to offer to trade reviews again ... ;)
[11:03] <noodles775> henninge: sure - although I'll not get to it 'til after lunch, so it might be worth waiting for a better prospect ;)
[11:03] <henninge> noodles775: but I think with your branch I'd feel better if Aaron picked up on it. Or is he on leave already?
[11:03] <henninge> noodles775: yes, mine is not urgent anyway
[11:03] <noodles775> henninge: I think he'll be around when it's morning.
[11:03]  * henninge goes to land wgrant's branch
[11:52] <salgado> noodles775, has your branch been reviewed already?
[11:52] <noodles775> salgado: no it hasn't. It's actually a re-review (I should have requested a new one), as I've updated it since it was approved: 
[11:52] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/475808-unembargoing-oops/+merge/16141
[11:53] <salgado> oh, ok.  I'll get to it in a minute
[11:53] <noodles775> Thanks.
[12:09] <salgado> noodles775, what is the ancestry component of a delayed copy?
[12:09] <noodles775> salgado: An older version of the package that has been published in the destination archive.
[12:10] <noodles775> It's used to determine the correct component to publish to ('main', 'universe', 'multiverse' etc.)
[12:10] <salgado> right
[12:10] <salgado> noodles775, """Return the ancestor of the given parkace
[12:10] <salgado> in getNearestAncestor
[12:11] <noodles775> salgado: Right, thanks. I guess my fingers slipped there!
[12:15] <salgado> noodles775, I think the docstring for that method should also state that it can return None 
[12:15] <noodles775> Yep, I'll update that too.
[12:20] <salgado> 172	+            if (is_ppa and binary.component not in
[12:20] <salgado> 173	+                distroseries.upload_components):
[12:20] <salgado> 174	                 # Only complain about non-PPA uploads.
[12:21] <salgado> noodles775, ain't that going to complain only about PPA uploads instead of non-PPA ones, as the comment says?
[12:22] <noodles775> salgado: yes - I replaced line 155 with 172 - and missed the not, that saves one ec2 failure - thanks!
[12:23] <salgado> you mean, if we have a test for that. ;)
[12:23] <noodles775> if? ;)
[12:24] <adiroiban> henninge: is there anything I need to do for this MP https://code.edge.launchpad.net/~adiroiban/launchpad/bug-435165/+merge/16084 :D
[12:32] <noodles775> salgado: just for the pride of soyuz, distroseriesqueue.txt would have failed ;)
[12:36] <salgado> heh. ok
[12:37] <henninge> adiroiban: yes, keep poking your reviewer about it ... ;-)
[12:37] <henninge> adiroiban: or find a new one
[12:38] <adiroiban> :) no hurry. I just wanted to make sure the ball is not on my side :D
[12:39] <salgado> noodles775, r=me with those small changes
[12:40] <noodles775> salgado: thanks, already pushed. BTW: I'm planning to land it on devel now, rather than db-devel as the mp says.
[12:40] <salgado> noodles775, yeah, I guessed that from reading your comment on the bug report
[12:54] <salgado> henninge, I assume yours is bug-489227-import-status?
[14:33] <henninge> salgado: yes, it is
[14:36] <henninge> salgado: thanks for the review. ;) Yes, background would probably be helpful. Sorry about that, I was lazy and just copied the bug description.
[14:52] <EdwinGrubbs> salgado: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part2/+merge/16325
[14:52] <EdwinGrubbs> salgado: you will find it very familiar
[14:53] <salgado> that's what I was going to say
[14:56] <salgado> EdwinGrubbs, how did you split it up?
[14:56] <EdwinGrubbs> salgado: all of your original changes are in the first branch plus a tiny bit of cleanup.
[14:57] <EdwinGrubbs> salgado: this branch redid a lot of the javascript because adding teams was more complicated than expected.
[14:58] <jpds> abentley: Ping.
[14:58] <abentley> jpds: pong
[14:58] <jpds> abentley: Hi, would you be able to land https://code.edge.launchpad.net/~jpds/launchpad/fix_176396/+merge/16082 for me now that PQM is opened?
[14:58] <salgado> EdwinGrubbs, because we had to update different sections of the page or something else?
[14:59] <abentley> jpds: I think we still have the re-roll to do, don't we?
[14:59] <jpds> Re-roll?
[15:00] <abentley> We usually do a second rollout on Fridays to fix any issues we discovered after the release.
[15:00] <jpds> Ah, right, did not know that.
[15:01] <EdwinGrubbs> salgado: yes, I added the Recently invited list, since that is the status that new teams should be added to if you admin the super team. If you admin the member team, then it will go into the proposed status, but you have to do that through the "Add my teams" page.
[15:08] <salgado> EdwinGrubbs, right. we completely forgot about the latter case.  you still have to use the "Add my teams" page, though, if you want to propose one of your teams as member?  or does the new widget handle that as well?
[15:09] <EdwinGrubbs> salgado: the new widget handles that now. The model's addMember() method now checks whether the reviewer is an admin of the owning team and then sets the status to APPROVED or INVITED accordingly.
[15:09] <salgado> oh, nice
[15:10] <EdwinGrubbs> salgado: that's backwards, the reviewer has to be an admin on the new member team. The user has to be an admin of the owning team to even see the "Add member" link.
[15:11] <salgado> right
[15:11] <salgado> EdwinGrubbs, I'll step out now to get some lunch but I'll review your branch as soon as I get back
[15:12] <salgado> and thanks a lot for finishing it
[15:45] <abentley> salgado-lunch: Could you review my proposal too please?  https://code.edge.launchpad.net/~abentley/launchpad/jobstatus/+merge/16309
[16:25] <salgado> abentley, sure
[17:07] <EdwinGrubbs> salgado: I'm back
[17:23] <salgado> EdwinGrubbs, sorry, was on a call.  I'll continue your review now
[17:31] <salgado> EdwinGrubbs, btw, would you mind asking somebody else to have a look at your windmill test?  I've never written one myself, so can't even think about reviewing it
[17:31] <EdwinGrubbs> salgado: ok
[17:36] <EdwinGrubbs> rockstar: can you do a UI review and review a windmill test. Salgado is reviewing the rest of the code in the branch.
[18:27] <EdwinGrubbs> salgado: will you be here on Monday if I don't finish the changes today?
[18:27] <salgado> EdwinGrubbs, yep
[18:33] <EdwinGrubbs> intellectronica: ping
[18:34] <intellectronica> EdwinGrubbs: yo
[18:35] <salgado> mars, when you have some time, can you have a quick look at https://code.edge.launchpad.net/~salgado/lazr-js/bug-482235/+merge/16349 for me?  I'd like some feedback (mostly on the XXXs there and the lack of documentation for the plugin) before I polish it and ask for a proper review
[18:36] <EdwinGrubbs> intellectronica: hi
[18:40] <intellectronica> EdwinGrubbs: ?
[18:41] <EdwinGrubbs> intellectronica: you said "yo"
[18:41] <intellectronica> EdwinGrubbs: you said "ping"
[18:43] <EdwinGrubbs> intellectronica: oops, sorry, I was going to ask you if you could do a ui review and review a windmill test. Salgado reviewed the rest of the branch.
[18:44] <EdwinGrubbs> https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part2/+merge/16325
[18:44] <intellectronica> EdwinGrubbs: sure. i can review the test. for the ui review you'll have to find one more reviewer
[18:44] <EdwinGrubbs> intellectronica: thanks, will do
[18:45] <EdwinGrubbs> intellectronica: I have to reboot, so I'll be away for just a sec
[19:09] <intellectronica> EdwinGrubbs: i need to go now, but if you still want me to review request it in an mp and i'll do it later