=== mwhudson_ is now known as mwhudson
[00:36] <mwhudson> anyone here?
[00:36] <mwhudson> jml: maybe you?
[00:42] <mwhudson> rockstar even?
[00:42] <rockstar> mwhudson, hello sir.
[00:42] <mwhudson> rockstar: can you do a trivial review?
[00:42] <mwhudson> i know you're not really here...
[00:44] <rockstar> mwhudson, sure, send it on over.
[00:44] <mwhudson> heh, it's https://bugs.edge.launchpad.net/bugs/392155 reappearing 100k bugs later
[00:44] <mup> Bug #392155: make run_all is broken <Launchpad Foundations:Fix Released by jml> <https://launchpad.net/bugs/392155>
[00:46] <mwhudson> rockstar: https://code.edge.launchpad.net/~mwhudson/launchpad/unshag-make-run_all/+merge/16461
[00:46] <mwhudson> man there's a lot of typing to do for a trivial fix :(
[00:49] <rockstar> mwhudson, r=me
[00:49] <mwhudson> rockstar: ta
[00:53] <jml> mwhudson, I'm back.
[00:53] <mwhudson> jml: hello
[00:53] <mwhudson> jml: could you maybe look at https://code.edge.launchpad.net/~mwhudson/launchpad/log-noop-puller-runs/+merge/16460 ?
[00:54] <mwhudson> jml: it involves gathering data, you'll like it 
[00:54] <mwhudson> :-p
[00:54]  * mwhudson .oO(maybe i need to graph it too for full jml baiting...)
[00:55] <jml> hahaha
[00:58] <jml> mwhudson, any ideas for a graph?
[00:59] <mwhudson> jml: dunno
[00:59] <mwhudson> jml: puller runs per day by type?
[00:59] <mwhudson> branch type i mean
[00:59] <mwhudson> would be easier after i finish off that branch that schedules puller runs with the job table
[00:59] <mwhudson> sadly the last time i looked at that branch i started throwing things around the room
[01:01] <jml> mwhudson, well, you're moving out soon right?
[01:01] <mwhudson> :)
[01:04] <mwhudson> jml: i think i need to abandon my attempt to be minimal and actually think about it again
[01:05] <mwhudson> jml: could i ask you to ec2 land https://code.edge.launchpad.net/~mwhudson/launchpad/unshag-make-run_all/+merge/16461 ?
[01:05] <mwhudson> i would, but i need to pack up for a bit here
[01:05] <jml> mwhudson, sure.
[01:06] <mwhudson> ta
[01:06] <mwhudson> mind you
[01:06] <mwhudson> maybe ec2 land is excessive for that branch
[01:07] <jml> mwhudson, do you want to just pqm-submit it?
[01:07] <mwhudson> jml: yeah ok
[01:07]  * mwhudson uses ec2 land to figure out the commit message
[01:07] <jml> mwhudson, that's good. because I am late for a thing.
[01:07] <mwhudson> jml: :)
[01:07] <mwhudson> jml: enjoy your thing
[08:26] <noodles775> mwhudson: can you r or rs a testfix reversion of r10066 (which enabled inclusion of windmill tests by default) http://pastebin.ubuntu.com/344576/
[08:27] <noodles775> ^^^ or anyone else who is keen.
[08:27] <mwhudson> noodles775: did you consider disabling the memcached layer tests?
[08:28] <mwhudson> as it seems to be some interaction there?
[08:28] <mwhudson> otoh, this is easier i guess
[08:28] <noodles775> mwhudson: I mentioned in my email,...
[08:28] <mwhudson> noodles775: ah okay
[08:28] <mwhudson> noodles775: r=me then
[08:28] <noodles775> safer... (we can disable the memcached tests and reenable these in another branch that goes through ec2)
[08:28] <noodles775> thanks
[09:16] <henninge> adiroiban: the final diff looks good. Let's land this!
[09:16] <henninge> adiroiban: Your last devel merge has been a few days. Can you please do that once more? I will land the branch then.
[09:16] <henninge> adiroiban: Thanks for your work.
[09:17] <adiroiban> henninge: sure
[09:17] <adiroiban> henninge: do I need any special setup for running soyuz or packagearchiver tests?
[09:18] <henninge> adiroiban: not that I know of. They are part of the normal test suite AFAIK
[09:18] <adiroiban> i have started a full test for LP and some tests get stuck
[09:19] <henninge> shouldn't. Hm...
[09:20] <henninge> adiroiban: some tests take a bit longer, I think.
[09:20] <adiroiban> well for ex this one was running for 8 hours lp.archiveuploader.tests.test_ppauploadprocessor.TestPPAUploadProcessor.testPPAUploadResultingInNoBuilds
[10:05] <adiroiban> henninge: sorry for the delay. got some problem with the new css stuff. The merged branch should be pushed
[10:05] <henninge> adiroiban: I just realised: the dot "." in "and <a href=\"%s\">%d other templates</a>." should probably be placed in the template so that it appears at the end of the sentence even if this part is empty.
[10:06] <henninge> adiroiban: cool
[10:06] <henninge> np
[10:06] <adiroiban> henninge: that was my first implementation... but this will brake some tests
[10:06] <henninge> ;)
[10:06] <henninge> never mind, then.
[10:06] <adiroiban> in the previous implementation there was no dot
[10:07] <henninge> which I'd consider a bug since this is a full English sentence. But just a very small one :-)
[10:08] <adiroiban> henninge: let me fix it
[10:08] <adiroiban> and change the tests
[10:09] <henninge> adiroiban: if you wish. The branch is approved for landing as it is ... ;)
[10:09] <henninge> thanks a lot!
[10:12] <adiroiban> well, I will fix it...as it's now or never
[10:15] <jtv1> oh, hi henninge, hi adiroiban!
[10:16] <henninge> Hi jtv1, 2, and 3 ... ;-)
=== jtv1 is now known as jtv
[10:16] <henninge> jtv: had enough of cloning?
[10:16] <jtv> henninge: yes, what's the fun in reproducing if you have to do it this way?
[10:17] <henninge> :)
[10:17] <jtv> Nobody on call today?
[10:17] <jtv> I just fixed a regression to my own fix... the translations branch approver was still missing a permission.
[10:17] <adiroiban> jtv: hi
[10:17] <adiroiban> :)
[10:17] <henninge> jtv: are you saying it's a small branch?
[10:17] <jtv> adiroiban: not gone for the holidays yet?  Or will you be here even more during the holidays?  :-)
[10:18] <jtv> henninge: yes
[10:18] <jtv> henninge: https://code.edge.launchpad.net/~jtv/launchpad/son-of-bug-487447/+merge/16480
[10:18] <jtv> almost all test change
[10:19] <jtv> and most of the diff is adding 1 line of code to each test in the test case.
[10:19] <jtv> (lots of context lines)
[10:24] <henninge> jtv: r=me
[10:24] <jtv> henninge: kuhl, danke!
[10:24] <henninge> lol
[11:14] <stub> Pretty trivial review at https://code.edge.launchpad.net/~stub/launchpad/librarian-report/+merge/16463, maybe for jtv.
[11:15] <jtv> stub: having a look...
[11:16] <jtv> stub: why use Popen instead of our nice run_script wrapper?
[11:16] <stub> We have a nice run_script wrapper? This time I'm just cargo culting what I landed last week. Last week I didn't know about run_script nor if it is suitable in this case.
[11:17] <stub> (this test is cut & paste the preceding test, with a few different arguments)
[11:17] <jtv> stub: and shame, shame, SHAME on you (or whoever is responsible) for using slashes in dates...
[11:17] <stub> jtv: Anything PG will parse unambiguously will work - you might notice the lack of validation...
[11:18] <stub> I think - works too
[11:18] <stub> For the slash deficient amongst us
[11:18] <jtv> <slash?  I'll give you a slash!  hah!>
[11:19] <stub> I think we only hire losas in locales which use / though so it is fine.
[11:19] <adiroiban> jtv: yep. still here to annoy Henning  with my branches
[11:19]  * jtv bares teeth at stub
[11:19] <jtv> adiroiban: annoy?  not very likely :)
[11:19] <adiroiban> :)
[11:20] <jtv> stub: slashes in dates are a symptom of inbreeding
[11:21]  * stub goes to take a slash
[11:23] <henninge> adiroiban: cool dot! ;-)
[11:24] <henninge> adiroiban: I'll initiate the landing ...
[11:24] <henninge> forward thrusters ... check ... landing gear ... check ... parachutes .... ch...check!
[11:34] <henninge> adiroiban: we're in descent
[11:36] <jtv> stub: I'm also slightly curious what happened to the line of test output right above your real change... did you just pick a different line of the output to compare against?
[11:37] <stub> jtv: Yes. I wanted the tests to demonstrate the output changes with the different command line arguments.
[11:42] <jtv> stub: makes sense
[11:45] <jtv> stub: afaict you could get rid of all existing imports and most of the code in this test if you use run_script
[11:50] <stub> k
[11:53] <stub> One import - I still have to assemble the patch etc.
[12:55] <adiroiban> henninge: successfully landed. Thanks!
[12:55] <adiroiban> do you think you can land this branch ? https://code.edge.launchpad.net/~adiroiban/launchpad/bug-497438/+merge/16335
[12:55] <adiroiban> it fixed the lucid translation not found problem
=== ursula is now known as Ursinha
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [jelmer] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:11] <bac> good morning
[13:13] <noodles775> hi bac, I'm just heading out for an hour, but I've got a lazr-js branch ready for review if you've time later:
[13:13] <noodles775> https://code.edge.launchpad.net/~michael.nelson/lazr-js/491337-error-style-try-2/+merge/16423
[13:13] <bac> ok, noodles775.  i'll have a look
[13:13] <noodles775> ta 
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [jelmer, noodlesXXX] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:37] <henninge> adiroiban: the branch did not land yet, there must be some misunderstanding.
[13:37] <adiroiban> henninge: ah. I got an email from buildbot 
[13:37] <adiroiban> maybe is for another branch...
[13:38] <henninge> adiroiban: yes, must be.
[13:38] <adiroiban> as I can not access the link from that email
[13:38] <henninge> adiroiban: what's the link
[13:38] <henninge> ?
[13:38] <adiroiban> https://lpbuildbot.canonical.com/builders/lp/builds/445
[13:39] <henninge> adiroiban: http://paste.ubuntu.com/344718/
[13:39] <henninge> that's what's landed
[13:41] <adiroiban> thanks
[13:42] <jtv> stub: any news on the branch?
[13:42] <stub> News?
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: jelmer || queue [noodlesXXX] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:42] <henninge> adiroiban: can you set a commit message on bug-497438, please?
[13:42] <stub> jtv: What am I doing to what branch?
[13:43] <jtv> stub: I thought you were trying out run_script, hence my silence
[13:44] <stub> jtv: No, I was waiting on your review. I can change it to run_script easily enough - no real gain though on clarity or line count that I can see but whatever.
[13:44] <adiroiban> henninge: done
[13:45] <jtv> stub: oic... you meant "I still have to assemble the path" but wrote "I still have to assemble the patch."  What a difference a letter makes!
[13:46] <stub> oops
[13:46] <jtv> what I was getting at was that you don't have to compose the path any more
[13:49] <jtv> we do seem to have a bunch of run_script definitions though
[13:53] <jtv> stub: you'd do (retval, out, err) = run_script('scripts/', ['--from=2005-01-01', '--until=2005-12-31']) and that's all it takes to run the script
[13:54] <stub> Ok - so don't need the absolute path.
[13:54] <jtv> ahem, 'scripts/librarian-report.py' that is
[13:54] <jtv> right
[13:54] <stub> sounds like good change then.
[13:55] <jtv> 's what I thought too :)
[13:57] <bac> hi jelmer
[14:00] <bac> hi jelmer_
[14:00]  * bac tries all permutations
[14:07] <jelmer> hi bac
[14:08] <henninge> adiroiban: it's landing
[14:10] <bac> hi jelmer -- was going to talk to you about interactive testing of your branch with launchpadlib but i just included the comments in the review.  let me know if you have questions.
[14:10] <jelmer> bac: will do - thanks for the review!
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: noodles || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado changed the topic of #launchpad-reviews to: on call: bac || reviewing: noodles || queue [salgado] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:19] <salgado> hi bac.  can you do a trivial review for me?
[14:20] <bac> salgado: sure
[14:31]  * salgado suspects his m-p submission failed.  it's been almost 20 minutes since he sent it and lp doesn't seem to have done anything with it
[14:39] <salgado> bac: https://code.edge.launchpad.net/~salgado/launchpad/bug-422552/+merge/16483
=== salgado is now known as salgado-lunch
[15:16] <adiroiban> al-maisan: Hi! Do you have time for landing this branch https://code.edge.launchpad.net/~adiroiban/launchpad/bug-492375/+merge/16279 ?  Thanks! I've done a new full test and it was ok. 
=== salgado-lunch is now known as salgado
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: salgado || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:02] <bac> hi salgado
[16:02] <salgado> hi bac
[16:03] <bac> salgado: what if you just did request.split() instead of request.split(' ')?  the former seems to handle mutliple space characters
[16:03] <salgado> does it?
[16:03] <bac> salgado: and doesn't require normalizing
[16:04] <bac> >>> 'a b   c'.split()
[16:04] <bac> ['a', 'b', 'c']
[16:04] <bac> >>> 'a b   c'.split(' ')
[16:04] <bac> ['a', 'b', '', '', 'c']
[16:04] <salgado> If sep
[16:04] <salgado>     is not specified or is None, any whitespace string is a separator.
[16:04] <salgado> yeah, looks good to me
[16:05] <bac> salgado: but i'm glad we have a test now for the case
[16:06] <salgado> indeed
[16:06] <bac> salgado: r=bac
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:07] <salgado> bac, do you think a comment would be desirable explaining why we use split() instead of split(' ')?  (I don't think it would)
[16:07] <bac> salgado: nah, since it DTRT i don't think it adds anything
[16:08] <salgado> cool
[16:08] <salgado> thanks bac!
[16:18] <noodles775> Thanks for the review bac (I dropped off earlier, so sorry if I missed any questions)
[16:18] <bac> noodles775: nope.  just a fleeting moment of confusion when i realized i hadn't run 'make build' in the branch and that's why it did nothing.
[16:18] <noodles775> :)
=== deryck is now known as deryck[lunch]
[18:35] <EdwinGrubbs> beuno: do you have any thoughts on how I should resolve the issue I commented on in the mp? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part2/+merge/16325
[18:36] <beuno> EdwinGrubbs, hey
[18:36] <beuno> let me actually read your comment
[18:39] <beuno> hrm
[18:39] <beuno> I'm torn here
[18:40] <EdwinGrubbs> yep, me too
[18:40] <beuno> we need a good mechanism for this type of behavior
[18:41] <beuno> this branch is probably not the time to do it
[18:41] <beuno> EdwinGrubbs, how about this
[18:43] <beuno> lets land this branch
[18:43] <beuno> and you brainstorm a bit on the list how to solve this problem in the future, in a more general way
[18:45] <EdwinGrubbs> beuno: sounds good to me
[18:46] <beuno> EdwinGrubbs, cool, I'll make it official
[18:47] <EdwinGrubbs> thanks
=== deryck[lunch] is now known as deryck
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: allenap || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[20:30] <allenap> bac: Thank you for the review. You saved my bacon :) I'll go and fix it now.
[20:31] <bac> ummm, bacon
[20:31] <bac> allenap: i think gmb gets credit for all of those great XXX comments
[20:32] <allenap> bac: Yes :) And I get idiot points for not using grep!
[21:58] <allenap> bac: I'm still working on fixing those other XXXs, but it's getting late here, so I'll finish it tomorrow.