=== jelmer_ is now known as jelmer
[08:52] <wgrant> ec2 test didn't detach for me earlier. Is that known?
[09:07] <jml> wgrant, it's not unknown
[09:07] <jml> wgrant, but I don't think anyone knows the root cause
[09:08] <jml> wgrant, or how to reproduce the problem.
[09:55] <al-maisan> question: does the the owner of an object has permission="launchpad.Edit" by default?
[09:57] <wgrant> No.
[09:58] <al-maisan> wgrant: thanks !
[11:02] <jtv1> Oops while approving an MP :-(
=== jtv1 is now known as jtv
[11:05] <jtv> Any Code folks left?
[11:05] <jtv> abentley, are you here?
[11:08] <jtv> guess not... rockstar maybe?
[11:11] <jtv> Seems I can still review, but I need to claim the review first.  Otherwise, oops.
[11:20] <jtv> adiroiban: err... did you break rosetta-admin permissions?  :-)
[11:21] <adiroiban> jtv: hi. yep
[11:22] <adiroiban> jtv: can you please point me to the bug report you are concerned about?
[11:22] <jtv> adiroiban: we don't have one yet... just getting word from dpm that he can't do his work.  :-)
[11:22] <adiroiban> jtv: hm.. the about about lucid being closed?
[11:23] <adiroiban> or other problems?
[11:23] <dpm> adiroiban, jtv, that's not blocking my work, so don't worry
[11:23] <jtv> adiroiban: completely different... we suddenly can't change the translation settings for a project any more
[11:25] <adiroiban> jtv: also a direct access to the url is not working?
[11:26] <jtv> adiroiban: permission denied.
[11:27] <dpm> jtv, what's the usual URL to change the translation permission settings?
[11:27] <adiroiban> jtv: can you please fill a bug report and I will try to fix it.
[11:28] <adiroiban> basicaly we just need to replace launchpad.Admin with launchpad.TranslationsAdmin
[11:28] <jtv> dpm: +changetranslators
[11:29] <jtv> adiroiban: that'd be great... but if you end up cleaning up a mess made by the rest of us, that'd be pretty embarrassing.  :-)
[11:29]  * jtv files bug
[11:31] <dpm> jtv, thanks. And do you know where that URL normally is accessible through the UI? Is it at https://translations.launchpad.net/project, under the Permissions section? (I'm thinking in terms of updating the help page)
[11:31] <jtv> dpm: right under where it says "is translated with <Open> permissions" there should be a "Change permissions" link
[11:31] <dpm> jtv, thanks!
[11:32] <jtv> dpm: btw can we still edit this for Ubuntu?
[11:32] <adiroiban> jtv: I can do that as a project owner
[11:33] <jtv> Wow...  there is a bug that *looks* like it's about this, but it's bug 127171
[11:33] <mup> Bug #127171: Rosetta experts not allowed to "Change translators" <Launchpad Translations:Triaged> <https://launchpad.net/bugs/127171>
[11:33] <jtv> adiroiban: just trying to get an idea of the scope of the bug, but you bring up a good point: is rosetta-admins in utc?
[11:33] <adiroiban> jtv: nope
[11:34] <adiroiban> rosetta admin and distribution translations owners are two different groups
[11:34] <adiroiban> jtv: this looks like an old bug
[11:34] <jtv> indeed
[11:34] <adiroiban> my permission changes landed only a few days ago
[11:35] <dpm> adiroiban, jtv, are you talking in terms of LP teams? Rosetta admins is part of https://launchpad.net/~ubuntu-translations-coordinators/+members#active
[11:36] <jtv> that's what I meant... it means that we can't see in Ubuntu whether this affects distros as well
[11:36] <jtv> But yes, this looks like an old problem.  adiroiban: see, almost got into that embarrassing situation there :-)
[11:37] <jtv> sorry for impugning you.
[11:37] <adiroiban> jtv: the distribution translation group owners needs some more permission. Ex there is bug 347143
[11:37] <mup> Bug #347143: Distro translation group owners should be able to manage language packs <Launchpad Translations:Triaged by adiroiban> <https://launchpad.net/bugs/347143>
[11:38] <adiroiban> jtv: np. I have done some changes in the security.py and I should be able to fix those bugs
[11:39] <adiroiban> jtv: there is as a thread on launchpad-dev ML about the current mess from LP security system
[11:39] <jtv> "Where to put security-related code"?
[11:40] <adiroiban> yes
[11:41] <adiroiban> and the thread went beyond the subject with „how to write security classes”
[11:41] <adiroiban> and how we should handle security in LP cpde
[11:41] <adiroiban> code
[11:42] <henninge> adiroiban: the conclusion was *not* to use checkAuthenticated outside of security.py
[11:42] <adiroiban> henninge: yep
[11:43] <jtv> makes sense
[11:43] <jtv> although I'm not sure we can always avoid it... henning, didn't you work on one of those instances as part of the +translate rework?
[11:50] <henninge> adiroiban: I am about to land the branch that makes more use of permission_helpers.py. I will have to make another branch to remove it again. Just so you know.
[11:50] <henninge> jtv: I don't remember anything like tha.
[11:50] <henninge> t
[11:51] <jtv> henninge: it's a pretty vague memory, so never mind...  There was some spot or other where things got complex enough (translation team membership etc.) that we had a customized check.
[11:51] <henninge> jtv: customized checks are ok
[11:52] <henninge> jtv: adi had suggested to import the checker classes from security.py and call checkAuthenticated in model code.
[11:53] <henninge> or was it view code? no, we have check_permission for that.
[11:56] <jtv> ah I just had it the wrong way around... this is the kind of stuff I figure out when I need it, then forget again.  :)
[11:56] <jtv> anyway I'll read and archive that thread for next time.
[11:57] <adiroiban> henninge: I will not touch the model security code until we have the security_helper fixed
[11:57] <adiroiban> henninge: so I will wait for you changes
[11:57] <adiroiban> your
[12:00] <henninge> adiroiban: permission_helper is still in there. There is nothing that needs to be "fixed" as it is just a collection of helper method which are optional.
[12:00] <henninge> adiroiban: I am not sure I will get around to removing it very soon.
[12:01] <adiroiban> henninge: ah. my impression was that you were going to rename it to security_checker.py
[12:01] <henninge> adiroiban: no, that was just an idea.
[12:01] <adiroiban> and change isUser to canDoSomethibng
[12:01] <adiroiban> isRosettaAdmin to canAdministerRosetta
[12:01] <adiroiban> or something like that
[12:02] <henninge> adiroiban: no, what I am thinking of is an extension to Person objects so that they have attributes like "is_admin" for celebrity groups.
[12:03] <henninge> so, that would include is_rosetta_expert
[12:03] <adiroiban> henninge: ok. I am still fuzzy with permission handling in LP. so don't worry about me
[12:03] <henninge> adiroiban: but "can*" methods are specific to model classes, so they should appear there.
[12:04] <henninge> adiroiban: that's the concept that you didn't like, remember?
[12:04] <henninge> ;-)
[12:05] <adiroiban> yep
[12:21] <adiroiban> jtv, henninge: Right now launcpad.Edit is required for +changetranslators for IProduct and IProject. Adding rosetta admins to launchpad.Edit will also give other edit rigths (non related to translations). Should I use launchpad.TranslationsAdmin or just go with the current launchpad.Edit ?
[12:22] <henninge> adiroiban: I think lp.TranslationsAdmin is better.
[12:22] <jtv> adiroiban: this should definitely be limited to Translations settings
[12:22] <jtv> so what henning said.  :)
[12:23] <henninge> adiroiban, jtv, dpm, everybody else: Happy Holidays, enjoy any of them you might have, see you next year! :-)
[12:23] <adiroiban> jtv, henninge: OK.
[12:23] <jtv> henninge: happy holidays!
[12:23] <jtv> it was a pleasure working with you in 2009; see you in 2010
[12:23] <dpm> henninge, happy holidays to you as well!
[12:24] <adiroiban> henninge: ohohooo Happy holidays!
[12:24] <jtv> (or 2552 and 2553 respectively, here)
[12:24] <adiroiban> :)
[12:24] <henninge> jtv: same here
[12:24] <henninge> ;)
[12:45] <adiroiban> how can I create a project-group like https://edge.launchpad.net/unr
[12:45] <adiroiban> ?
[12:46] <adiroiban> ah... using partof
[12:48] <wgrant> Only admins can create them.
[12:49] <adiroiban> wgrant: thanks. I was a bit confused by IProduct and IProject
[12:51] <wgrant> product in the code == project in the UI. project in the code == project group in the UI.
[12:51] <wgrant> Yay for renaming things in the UI years ago, but not in the code.
[12:51] <adiroiban> yep
[12:52] <adiroiban> but still, a project is also somehow a product
[12:53] <wgrant> It's not.
[12:53] <wgrant> What gives you that idea?
[12:53] <adiroiban> well, I'm looking at registry/configure.zcml
[12:53] <adiroiban> for IProduct and IProject „translationpermission” attribute
[12:54] <adiroiban> I set the translationpermission attribut as requiring launchpad.TranslationsAdmin (RosettaAdmin)
[12:54] <wgrant> I don't see that for IProject.
[12:55] <adiroiban> and it's working for a project
[12:55] <adiroiban> but not for a project group
[12:55] <adiroiban> wgrant: right. me neither
[12:55] <wgrant> There's no TranslationsAdmin permission for IProject.
[12:57] <adiroiban> wgrant: True. That is the bug I am working on right now. bug 127171
[12:57] <mup> Bug #127171: Rosetta experts not allowed to "Change translators" <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/127171>
[12:58] <adiroiban> wgrant: Don't worry. I'll try to figure out what is wrong
[12:59] <wgrant> adiroiban: What do you see is wrong?
[12:59] <adiroiban> wgrant: I got this error: Unauthorized: (<Project at 0xd83934c>, 'translationpermission', 'launchpad.Edit')
[12:59] <wgrant> IProject.translationpermission comes from IHasTranslationGroup.
[13:00] <adiroiban> but in configure.zcml I have http://paste.ubuntu.com/345899/
[13:00] <wgrant> IProjectPublic inherits from IHasTranslationGroup
[13:00] <wgrant> And registry/configure.zcml requires launchpad.Edit to set IProjectPublic.
[13:00] <adiroiban> wgrant: thanks!
[13:16] <adiroiban> wgrant: and in this case how can I move translationpermission for Project from launchpad.Edit to launchpad.TranslationsAdmin ?
[13:16] <adiroiban> change IProjectPublic not to inherit from IHasTranslationGroup ?
[13:17] <wgrant> adiroiban: I think that might be best.
[13:17] <wgrant> adiroiban: Alter IProject to inherit directly from it.
[13:17] <adiroiban> wgrant: I am worried about the side effects
[13:17] <wgrant> adiroiban: Then make IHasTranslationGroup readable using launchpad.View, and writable with launchpad.TranslationsAdmin. You can probably then remove the explicit declarations about IProduct.
[13:17] <adiroiban> I see
[13:17] <wgrant> adiroiban: That's why we have a test suite.
[13:18] <wgrant> I don't think there should be a problem; those subclasses are meant to just be used for permissions.
[13:18] <adiroiban> ah. ok
[13:26] <adiroiban> wgrant: schema is for reading and set_schema for writing?
[13:26] <wgrant> adiroiban: interface for reading.
[13:28] <adiroiban> wgrant: thanks!
[13:31] <adiroiban> wgrant: instead of <require permission="launchpad.View" interface="x" />, can I just use <allow interface="X"/> ?
[13:31] <adiroiban> this is the current configuration for IProjectPublic
[13:31] <wgrant> adiroiban: Ah, yes, that makes sense for objects that don't have launchpad.View (because they're public)
[13:32] <wgrant> So, yes, <allow> is the right thing to use here.
[13:33] <adiroiban> what is the purpose/usage of launchpad.View or how it is different from zope.Public?
[13:35] <wgrant> It's used mostly for objects that can be private.
[13:35] <wgrant> zope.Public is always held.
[13:36] <adiroiban> Thanks!
[13:37] <adiroiban> the bug should be now fixed... will see what tests have to say
=== jelmer_ is now known as jelmer
[14:44] <adiroiban> jtv: for distributions, +changetranslators is +settings ? I was thinking to have a single name for that view
[14:44] <jtv> adiroiban: makes sense... it's the same form, right?
[14:44] <adiroiban> yes
[14:44] <adiroiban> same attributes can be changed
[14:44] <adiroiban> translationgroup translationpermission
[14:45] <adiroiban> should I go with +settings ?
[14:45] <adiroiban> beside translators, translations policy is also set from this view
[14:53] <adiroiban> jtv: well... they have the same fields... but are different views
[14:53] <adiroiban> same template
[14:54] <adiroiban> ProjectChangeTranslatorsView , ProductChangeTranslatorsView and DistributionChangeTranslatorsView
[14:55] <adiroiban> maybe we can put them on the same IHasTranslationsGroupView
[14:55] <jtv> adiroiban: don't we already have a +settings for projects?
[14:55] <jtv> ah, that's for productseries
[14:56] <adiroiban> jtv: there is +translations-settings
[14:56] <adiroiban> hm...
[14:56] <jtv> but it's still for the series, not the project
[14:56] <adiroiban> nope... +translations-settins is for IProduct
[14:57] <adiroiban> sorry IProductSeries
[14:57] <jtv> that gives me a 404 though
[14:57] <jtv> right
[14:57] <jtv> So +settings makes sense to me... I'm just not sure why +translations-settings isn't called +settings as well
[14:58] <adiroiban> jtv: maybe , the one implementing it was worried not to owerwrite a general +settings page for „main”
[14:59] <adiroiban> jtv: but I could not find any other +settings page
[14:59] <jtv> adiroiban: that made sense a long time ago, before we had separate namespaces for our different hostnames...  but I don't see anything in there that's that old
[14:59] <adiroiban> other than in translations
[15:00] <adiroiban> jtv: then maybe I can also rename +translations-settings to +settings
[15:00] <jtv> (The stuff that's on +tranlsations-settings barely predates the source tree split)
[15:00] <jtv> adiroiban: bear in mind that it may involve updating the help site as well...
[15:00] <adiroiban> it is strage there are no other +settings view in the other lp components
[15:05] <adiroiban> jtv: those lines were last touched by Danilo, so maybe he can give us some hints
[15:05] <jtv> adiroiban: that may have been from the codebase split though
[15:05] <jtv> when we broke the source tree down by app (code, translations, bugs, etc)
=== salgado is now known as salgado-lunch
=== salgado-lunch is now known as salgado
[23:56] <_Groo_> hi/2 all