[07:16] <jtv> jml: you're looking at my db patch as well?  If so, tia :)
[07:17] <jml> jtv, np.
[07:59] <thumper> jml: ping
[07:59] <jml> thumper, pong.
[07:59] <thumper> jml: re: removeSecurityProxy
[07:59] <thumper> jml: there is a big comment above as to why we need to change the datecreated
[08:00] <thumper> jml: are you explicitly mentining the use of the proxy in this case?
[08:00] <jml> thumper, in this case, yes.
[08:00] <thumper> jml: the member isn't publicly accessable, hence the need
[08:00] <thumper> I'll add a comment
[08:00] <jml> thumper, I'm remembering having this conversation about changing the datecreated, actually :)
[08:00] <jml> thumper, why can't we make it accessible?
[08:01]  * thumper thinks
[08:01] <thumper> no reason really I guess
[08:01] <thumper> it is readonly at the moment
[08:01] <thumper> normally there is no need to modify the default value
[08:01] <thumper> this is a special case
[08:01] <thumper> I'd rather not expose it for a special case
[08:01] <thumper> that is all really
[08:02] <jml> hmm.
[08:02] <jml> BjornT, are you around?
[08:02] <BjornT> hi jml 
[08:03] <thumper> BjornT: Karma.datecreated is currently readonly (like most datecreateds)
[08:03] <jml> BjornT, ... and we want to backdate karma
[08:03] <thumper> BjornT: do we change it to read/write for the special case where we want to backdate karma
[08:03] <thumper> BjornT: or use removeSecurityProxy?
[08:03] <jml> see allocateKarma in lp.code.model.revision
[08:04] <jml> https://code.edge.launchpad.net/~thumper/launchpad/revision-karma-fix/+merge/16825 for context
[08:04] <thumper> jml: well, it currently doesn't need the proxy removed, as it isn't wrapped at the point of access
[08:04] <thumper> but by change to use the target to get it wraps it
[08:04] <jml> *nod*
[08:05] <BjornT> thumper, jml: without looking, it sounds like you should try to specify the right datecreated when creating the karma in the first place. would that be possible?
[08:05] <jml> thumper, was just thinking that BjornT might want to look at the code to get some context as to _why_ we are fiddling w/ datecreated.
[08:05] <jml> hmm. maybe.
[08:05] <thumper> BjornT: not through the person.allocateKarma method
[08:05]  * jml looks.
[08:05] <thumper> we could add yet another parameter I guess
[08:06] <thumper> assignKarma that is
[08:06] <jml> thumper, yeah, that's what I was thinking.
[08:06] <jml> thumper, that'd probably be nicer.
[08:06] <jml> thumper, and wouldn't make the branch much bigger at all -- it's three lines of code
[08:07] <thumper> jml: exept for the tests to the change to assignKarma
[08:07] <jml> thumper, I'm not going to make you test it :P
[08:08] <jml> thumper, if you make it an optional parameter, you won't have to change any of the existing tests.
[08:08] <thumper> yeah...
[08:08] <thumper> almost all params to assignKarma are optional
[08:09] <jml> l/reg/doc/person-karma.txt are tests, I think.
[08:17] <thumper> jml: slightly more than 3 lines: 5 files changed, 20 insertions(+), 12 deletions(-)
[08:25] <jml> thumper, heh
[08:25] <jml> thumper, well, I'm not in coding any more, I'm in product management -- everything ought to be simple, right?
[08:25]  * jml recalls an account manager in a past job who insisted that every feature was only ever a weekend's work
[08:25] <jml> I should try not to be that guy
[08:26] <jml> anyway, people are putting drinks and delicious food in front of me -- good night.
=== matsubara-afk is now known as matsubara
[11:47] <allenap> gmb: When you have a mo, could you look at the post-review changes in https://code.edge.launchpad.net/~allenap/launchpad/checkwatches-stuff/+merge/16495?
[11:48] <allenap> bac: It's an old one, from before the hols, but when you have time can you have a look at the incremental changes I made to https://code.edge.launchpad.net/~allenap/launchpad/remove-xmlrpclib-marshalling-bug-254999/+merge/16436?
[11:53] <gmb> allenap: Looking now.
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[11:57] <gmb> allenap: You need to remove lib/lp/bugs/scripts/tests/test_checkwatches.py.moved
[11:58] <allenap> gmb: Gah, I hate computers.
[11:59] <gmb> allenap: Other than that, r=me.
[11:59] <allenap> gmb: Thanks.
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: sinzui || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[12:14] <allenap> gmb: In rev 10054.7.1, there's a method NonConnectingBugzillaAPI.getProductsForRemoteBugs that refers to a bug_ids variable that doesn't exist. Things seem to be working anyway, so do you think it might be safe to drop that method?
[12:14] <allenap> gmb: Sorry, rev 10054.7.1 is where it was added.
[12:15] <gmb> allenap: I have no idea... Drop it and see what happens. Is it in test_checkwatches.py?
[12:15] <allenap> gmb: Yep.
[12:15] <gmb> allenap: Then it's part of a regression test... Let me take a look.
[12:16] <allenap> gmb: It runs without it.
[12:16] <gmb> allenap: Then it should be safe to drop it.
[12:16] <allenap> gmb: Cool.
=== gmb changed the topic of #launchpad-reviews to: on call: gmb[lunch] || reviewing: sinzui || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== jpds changed the topic of #launchpad-reviews to: on call: gmb[lunch] || reviewing: sinzui || queue [jpds(361650)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: on call: gmb[lunch], bac || reviewing: sinzui || queue [jpds(361650)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:31] <bac> good morning
[13:33] <bac> hi allenap, i'll have a look at your MP shortly
=== bac changed the topic of #launchpad-reviews to: on call: gmb[lunch], bac || reviewing: sinzui, allenap || queue [jpds(361650)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:34] <bac> allenap: scratch that.  i see gmb already did.
=== bac changed the topic of #launchpad-reviews to: on call: gmb[lunch], bac || reviewing: sinzui, jpds(361650) || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== mrevell is now known as mrevell-lunch
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: sinzui, jpds(361650) || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:40] <gmb> Morning bac.
[13:42] <bac> hi gmb -- how's the frostbite?
[13:42] <allenap> bac: Hi Brad. Graham looked at a different mp, so my request still stands.
[13:42] <allenap> bac: If that's okay?
[13:43] <bac> allenap: ok, but i've already started on another.  will get to yours shortly.
[13:43] <allenap> bac: Brilliant, thanks.
[13:43] <gmb> bac: I'll survive. Perfectly pleasant 3-mile walk for milk this morning and all my extremities still in working order.
=== bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: sinzui, allenap|| queue [jpds(361650) ] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:58] <bac> allenap: donning your former-build-engineer hat, do you know why 'ec2 land' would not submit to PQM after a successful test run?  at the end of the email is "successfully ran all tests" but no message about submitting to PQM.
[13:58] <allenap> bac: I don't know off the top of my head, but I'll take a look.
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: mwhudson, allenap || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:05] <allenap> bac: ec2 land invokes ec2 test -s "message", so I can only think that the test runner failed after running tests, or didn't pick up a correct email configuration from your ~/.bazaar configuration.
[14:06] <bac> allenap: that would be odd.  it worked before the break and my config hasn't changed.
[14:07] <bac> allenap: i wonder if there is a trap for import_violations > METRIC_SHITLOAD
[14:07] <allenap> bac: Heh, yes, maybe :)
[14:07] <sinzui> The import violations are trivial fixes for the most part
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, allenap || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:15] <bac> allenap: on your bug 254999 branch is the only difference from the last review that you fixed more files?  just more of the same?
[14:16] <allenap> bac: Yes, more of the same.
[14:17] <bac> allenap: looks good.  r=bac
[14:17] <allenap> bac: Thanks :)
[14:19] <allenap> bac: I can't find anything that causes the test suite to go boom if there are anti-fascist imports, but perhaps the fascist's atexit handler itself blew up... seems unlikely though.
=== mrevell-lunch is now known as mrevell
[14:20] <bac> allenap: ok, thanks for looking
[14:34] <sinzui> gmb: regarding the unclear error message in delete team: I wanted to it to be: I am sorry Dave, but I cannot let you craft an application to delete other people's data and gain control of their projects.
[14:34] <sinzui> gmb: I am not sure what to write given that the the message is to someone trying to break into Launchpad
[14:35] <gmb> Hmm.
[14:35] <gmb> sinzui: Gimme a sec, just on a call; I'll have a think.
=== matsubara is now known as matsubara-lunch
[15:07] <gmb> sinzui: So, something simple like "unable to process submitted data"  - given this is an edge case and a nasty one at that we don't have to be terribly explicit. If you add a comment to explain why you're being vague that would work fine for me.
[15:07] <sinzui> okay
=== salgado is now known as salgado-lunch
=== bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:26] <adiroiban> jtv: hi. sorry for the delay. I was as bit bussy today
[15:26] <jtv> hi adiroiban!  I'm about to leave (in about -1.5 hours to be exact :)
[15:26] <adiroiban> np. tomorrow is also a day 
[15:27] <adiroiban> i got stuck with modifying the 2 configure.zcml
=== beuno is now known as beuno-lunch
=== jtv is now known as jtv-zzz
=== BjornT changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, - || queue [BjornT] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:40] <BjornT> gmb, bac: can anyone please review https://code.edge.launchpad.net/~bjornt/launchpad/enable-windmill-again?
[15:41] <bac> BjornT: i will
[15:41] <BjornT> thanks
=== bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, BjornT || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:43] <adiroiban> abentley: hi. is there anything I need to do for https://code.edge.launchpad.net/~adiroiban/launchpad/bug-359180/+merge/16422 ?
[15:44] <abentley> adiroiban: Has it passed the full test suite?
[15:45] <adiroiban> abentley: I only did the full test for translations module
[15:46] <adiroiban> my computer is low on RAM and I can not do a full test
[15:46] <adiroiban> as I get an out of memory error
[15:46] <adiroiban> in soyuz 
=== deryck is now known as deryck[lunch]
[15:47] <abentley> adiroiban: We can't land it until it passes the test suite.  Currently, I'm having trouble running the full suite myself.
[15:47] <abentley> adiroiban: perhaps gmb or bac would be willing to run it through ec2 for you.
[15:47] <gmb> adiroiban, abentley: I'll take care of it.
[15:47] <adiroiban> abentley: ok. for the same reason I am stuck with https://code.edge.launchpad.net/~adiroiban/launchpad/bug-496352-series-status-refactor/+merge/16108
[15:47] <gmb> adiroiban: I'll do that, too :)
[15:47] <abentley> gmb: thanks.
[15:48] <abentley> gmb: x2
[15:48] <adiroiban> gmb: for  the series-status-refactor let me do a new merge 
[15:48] <gmb> Welcome ^2
[15:48] <adiroiban> as it will probably fail after merging with devel 
[15:49] <adiroiban> the branch is pretty old and there is a chance that someone has added a new DistroSeriesStatus 
[15:49] <adiroiban> this will be merged without conflicts
[15:49] <adiroiban> but since it was renamed to SeriesStatus
[15:49] <adiroiban> the merged branch will be broken
[15:52] <gmb> adiroiban: Sure. Just ping me when ready.
[15:53] <jpds> gmb: Can you also ec2 test https://code.edge.launchpad.net/~jpds/launchpad/fix_499997 for me?
[15:53] <gmb> jpds: Sure
[15:55] <gmb> jpds: Running
[15:55] <jpds> gmb: Thanks.
=== matsubara-lunch is now known as matsubara
=== bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:17] <james_w> hi all, please to be reviewing https://code.edge.launchpad.net/~james-w/launchpad/sync-source-negative-versions/+merge/16857
[16:17] <james_w> gmb: ^ a bit of soyuz to warm your cockles?
[16:17] <gmb> Eurgh.
[16:17] <gmb> james_w: But since it's you.
[16:18] <james_w> heh
=== gmb changed the topic of #launchpad-reviews to: gmb, bac || reviewing: james_w, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:20] <james_w> oh, did I get the target branch wrong?
[16:21] <adiroiban> gmb: both branches should are ready for a full test. Thanks@
[16:21] <gmb> adiroiban: Okidoke. Will set them off shortly.
[16:22] <adiroiban> gmb: no hurry
[16:23] <gmb> WTF: bzr: ERROR: xmlrpc protocol error connecting to https://xmlrpc.edge.launchpad.net/bazaar/: 302 Found
[16:23] <gmb> Hmm.
[16:30] <gmb> adiroiban: Er, https://code.edge.launchpad.net/~adiroiban/launchpad/bug-496352-series-status-refactor/+merge/16108 appears to be 2000+ lines long and has 4 (apparently) unreviewed revisions in it. Can you take a look to see exactly what's gone on there please?
[16:32] <adiroiban> gmb: it is a rename of DistroSeriesStatus to SeriesStatus
[16:32] <gmb> adiroiban: Ah, so it was always 2000+ lines?
[16:32] <adiroiban> gmb: the new revisions are just fixing problems after merge
[16:32] <adiroiban> gmb: yes
[16:33] <gmb> adiroiban: Okay, thanks.
=== beuno-lunch is now known as beuno
[16:36] <gmb> james_w: Your change to security.py seems not relevant to the branch (I admit, I've not looked further down the diff yet). Is it?
[16:36] <james_w> gmb: it seems I started from the wrong branch/proposed for the wrong branch
[16:36] <gmb> Oh.
[16:36] <gmb> That's a new one.
[16:36] <james_w> I worked from devel, what should I propose merge in to?
[16:36] <gmb> Oh, I see.
[16:36] <gmb> james_w: launchpad/devel
[16:37] <gmb> lp:launchpad is actually db-devel
[16:37] <gmb> For stacking purposes.
[16:37] <gmb> james_w: want me to reject that m-p?
[16:37] <james_w> I just deleted
[16:39] <james_w> https://code.edge.launchpad.net/~james-w/launchpad/sync-source-negative-versions/+merge/16861
[16:41]  * gmb looks
[16:42] <gmb> james_w: There appear to be no tests for the change. I don't know Soyuz well enough to know whether there *can't* be any tests or not... can there?
=== henninge_ is now known as henninge
[16:42] <gmb> (I'm aware here that you might know the same amount as me on this front)
[16:43] <james_w> <james_w> where would I find the tests for ./scripts/ftpmaster-tools/sync-source.py ?
[16:43] <james_w> <bigjools> james_w: hahahaha
[16:44] <james_w> gmb: so I think no tests is the status quo
[16:44] <gmb> Hah.
[16:44] <gmb> Right.
[16:44] <gmb> james_w: In that case, r=me.
[16:45] <james_w> would you be so kind?
[16:45] <gmb> james_w: Sure.
[16:45] <james_w> I don't have PQM rights
[16:45] <gmb> Fair dos.
[16:45] <james_w> thanks gmb 
=== gmb changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:52] <noodles775> Hi bac - are you ok for a non-interactive review? (I'll be off in a few mins):
[16:52] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/499095-build-retry-depwait-stuck/+merge/16865
=== sinzui changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado-lunch is now known as salgado
[16:53] <bac> noodles775: sure
[16:53] <noodles775> Thanks.
[16:54] <bac> sinzui: why do you silently put things in the queue?  like pavlov's dog i only respond when i hear the bell.
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [sinzui noodles] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:54] <sinzui> bac: because I have a cat dropping books on me
[16:54] <sinzui> and it is now on meee and clawwinnng me
[16:55] <bac> good reason, i guess
[16:55] <bac> i could loan you jojo for a day and take care of that problem
[16:55] <sinzui> I have seen jojo try to get in your lap. I do not think that is much help
[16:57] <bac> sinzui: thanks for showing a lplib test in your MP
=== deryck[lunch] is now known as deryck
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui || queue [noodles] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:57] <sinzui> bac: I have a whole script if you want
[16:58] <bac> sinzui: nah, i just usually have to nag people to test API changes with lplib
[16:59] <sinzui> bac: EdwinGrubbs pointed out that I had mis-spelled the parameters in the webservice test. That is what I have been trying to fix since 2:30 PM EST yesterday. I suck
[16:59] <bac> sinzui: spelling is not your strongest point
[16:59] <sinzui> It will be my demise.
[17:16] <sinzui> abentley: rockstar: I want to resubmit a merge proposal to make it clear that it should be merged into db-devel, not devel. If I do so, will I loose all the excellent conversation and reviews that the proposal already has?
[17:16] <rockstar> sinzui, I don't think you can resubmit against another branch.
[17:16]  * rockstar checks
[17:17] <abentley> sinzui: You can't resubmit with a different target branch.  And if you could, the excellent conversation would not be shown on the new proposal.  We are discussing changing both these things.
[17:18] <sinzui> abentley: thanks for your insight. I do not think this is a common issue. jml/stuart should have caught the error when they started the review.
=== sinzui changed the topic of #launchpad-reviews to: on-call: bac || reviewing: sinzui, jpds || queue [noodles] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:25] <sinzui> bac: to be clear, I am reviewing jpds's branch
[17:51] <EdwinGrubbs> salgado: can you mark this mp as approved? I fixed the last two issues you listed, but I hadn't notice that the status on your review was still needs-fixing. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part2/+merge/16325
[17:52] <salgado> EdwinGrubbs, sure
[17:53] <salgado> EdwinGrubbs, what did you do with the code that was commented out?
[17:55] <EdwinGrubbs> salgado: I removed it entirely. It's just a message, and we normally show those with an info icon and no "Notice" header above it.
[19:38] <bac> sinzui: when i try to access findPerson(...) i get "Unrecognized parameters 'created_before' and 'created_after'"
[19:38] <bac> sinzui: this using your lplib snippet
[19:38] <bac> sinzui: what have i done wrong?  i rebuilt the wadl and removed my lplib cache file
[19:39] <sinzui> interesting
[19:41] <sinzui> I had to 
[19:41] <sinzui> rm lib/canonical/launchpad/apidoc/wadl-development.xml; make lib/canonical/launchpad/apidoc/wadl-development.xml
[19:42] <sinzui> bac ^ which is what I think make build does when the wadl does not exist
[19:44]  * bac tries
[19:45]  * bac fails
[20:02] <sinzui> bac: is there any chance you are not using env=dev in your test script?
[20:02] <sinzui> I can send you my test script
[20:03] <bac> sinzui: i'm definitely hitting dev.  i see the responses in the server window
[20:04] <sinzui> make clean; make build ?
[20:04] <bac> done
[20:04] <sinzui> do you see created_after in lib/canonical/launchpad/apidoc/wadl-development.xml ?
[20:09] <bac> sinzui: figured it out
[20:10] <sinzui> please tell
[20:10] <bac> the cached wadl is *NOT* in api.launchpad.dev/cache but is in api.launchpad.dev/
[20:18] <bac> sinzui: so, now that i can play with it in lplib -- it works very well
[20:24] <bac> sinzui: r=bac
[20:24] <sinzui> thanks
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: noodles || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: jtv || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[21:27] <rockstar> mwhudson, can you do the review for this code-import-list branch?  I think it'll make you giggle.
[21:27] <mwhudson> rockstar: sure
[21:27] <mwhudson> rockstar: will i be embarrassed too?
[21:27] <rockstar> mwhudson, you shouldn't be.
[21:27] <rockstar> mwhudson, sending now.
[21:28] <mwhudson> cool
[21:32] <rockstar> argh, forgot to sign me email.
[21:32] <rockstar> One day, I'll be able to use my mind to verify my identity.
[21:41] <mwhudson> rockstar: aaaaaaaaaaaargh!
[21:42] <rockstar> mwhudson, :)
[21:42] <rockstar> When I found it, I kind of chortled/facepalmed
[21:42] <rockstar> I was expecting it to be really complicated.
[22:20] <rockstar> thumper, could I get you to look at https://code.edge.launchpad.net/~rockstar/launchpad/branch-scanner-prep/+merge/16260 again?  I have some failing tests for the next branch, and then I can land these both.
[22:21] <thumper> rockstar: yes I'll look
[22:28] <rockstar> thumper, and as far as the <= is concerned, yes, I know it doesn't make sense.  It seems to be a storm oddity.  I had it the other way and couldn't get the test to pass, and then I noticed another garbo method had it that way, and changing it passed the test.
=== bac changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews