| jml | abentley, https://code.edge.launchpad.net/~jml/launchpad/use-testtools/+merge/16711 | 02:47 |
|---|---|---|
| abentley | thumper: https://code.edge.launchpad.net/~jml/launchpad/use-testtools/+merge/16711 | 03:00 |
| === stub1 is now known as stub | ||
| thumper | jml: ping | 03:36 |
| jml | thumper, pong | 03:50 |
| al-maisan | rockstar: please see bug #505725 | 04:09 |
| mup | Bug #505725: Replicate the processor/virtualized properties in the BuildQueue table <buildfarm> <Soyuz:Triaged by al-maisan> <https://launchpad.net/bugs/505725> | 04:09 |
| jml | jtv, noodles775: https://code.edge.launchpad.net/~jml/launchpad/behavior-refactor/+merge/17127 -- mid-implementation | 04:54 |
| mrevell | Howdy | 09:21 |
| jml | mrevell, hi | 09:43 |
| jml | mrevell, did I get my timing wrong? | 09:44 |
| mrevell | jml, Timing? | 09:48 |
| mrevell | jml, Oh, sorry, I misread your nick as jtv. | 09:50 |
| * mrevell checks glasses | 09:50 | |
| deryck | Morning, all. | 11:11 |
| henninge | salgado: ping | 11:19 |
| salgado | hi henninge | 11:20 |
| henninge | Hi salgado! :) | 11:20 |
| henninge | salgado: I may need to add a package to launchpad-dependencies. Can tell me or give me a hint about how to do that? | 11:21 |
| salgado | henninge, https://help.launchpad.net/Packaging/PPA | 11:21 |
| salgado | no, not that one | 11:22 |
| henninge | salgado: right, I was talking about an existing package that I need for some new code. | 11:22 |
| henninge | The package is intltool, btw. | 11:22 |
| salgado | henninge, https://dev.launchpad.net/LaunchpadPpa | 11:24 |
| salgado | henninge, does that help? | 11:25 |
| henninge | salgado: still reading but that looks like it's what I need. | 11:25 |
| henninge | thanks | 11:25 |
| salgado | once you're done updating meta-lp-deps you'll need https://help.launchpad.net/Packaging/PPA to upload a package to ~launchpad's ppa | 11:26 |
| henninge | salgado: hm, I am surprised it would be so much work. I am not talking about a package that I created or wrote. | 11:27 |
| henninge | salgado: I just need another package from the standard Ubuntu repository. | 11:28 |
| salgado | henninge, it's only a few commands to get that done | 11:29 |
| === salgado is now known as salgado-brb | ||
| === henninge is now known as hennige-lunch | ||
| === mrevell is now known as mrevell-lunch | ||
| === stub1 is now known as stub | ||
| === salgado-brb is now known as salgado | ||
| === hennige-lunch is now known as hennige | ||
| === mrevell-lunch is now known as mrevell | ||
| === danilo__ is now known as danilos | ||
| === ursula is now known as Ursinha | ||
| === salgado is now known as salgado-lunch | ||
| === hennige is now known as henninge | ||
| === matsubara is now known as matsubara-lunch | ||
| arnaud_ | hey everybody | 15:33 |
| mars | hi arnaud_ | 15:35 |
| === jamalta_ is now known as jamalta | ||
| === salgado-lunch is now known as salgado | ||
| beuno | EdwinGrubbs, sinzui, adding a member on staging looks super slick | 16:15 |
| sinzui | bac: did you start bug 491320? | 16:21 |
| mup | Bug #491320: Unnecessary spaces and lines in new team member approval page <trivial> <ui> <Launchpad Registry:Triaged by bac> <https://launchpad.net/bugs/491320> | 16:21 |
| bac | sinzui: i have not | 16:22 |
| sinzui | bac: okay. | 16:23 |
| kfogel | adeuring, deryck: bbiab w/ +patches view bug | 16:47 |
| deryck | kfogel, excellent. thanks. | 16:47 |
| adeuring | kfogel: cool | 16:48 |
| === matsubara-lunch is now known as matsubara | ||
| === beuno is now known as beuno-lunch | ||
| kfogel | deryck, adeuring: please read https://bugs.edge.launchpad.net/malone/+bug/506018 and give me your comments. | 17:33 |
| mup | Bug #506018: Need a "+patches" view: report lists patches attached to bugs. <story-patch-report> <Launchpad Bugs:New for kfogel> <https://launchpad.net/bugs/506018> | 17:33 |
| * deryck looks | 17:33 | |
| * adeuring looks too | 17:35 | |
| deryck | kfogel, yes, looks good to me. Seems complete. | 17:36 |
| deryck | kfogel, I triaged accordingly -- it would be "high" since this is a high priority story for us this month. | 17:37 |
| kfogel | deryck: sounds good | 17:37 |
| * kfogel waits for adeuring to say he's absorbed it | 17:37 | |
| deryck | kfogel, also, not a big deal, but we wouldn't assign to 10.01 now, even though we're all very confident this will land this month. | 17:37 |
| kfogel | deryck: ah, *nod* | 17:37 |
| deryck | kfogel, we would wait until it nears review state. but don't un-milestone it now -- we don't want to create confusion. | 17:38 |
| adeuring | kfogel, deryck: looks good to me too | 17:38 |
| * deryck recognizes this is at odds with how LP development has always worked, but the bugs team is trying a new approach | 17:38 | |
| kfogel | deryck: what part is at odds? | 17:40 |
| kfogel | adeuring: I'm going to show to Bryce and Jorge now (would like to keep them in the loop as much as possible). Sound good to you? | 17:41 |
| adeuring | kfogel: sure! | 17:41 |
| deryck | kfogel, historically the milestone has been either a backlog queue or a promise to deliver the listed bugs by the milestone release. | 17:41 |
| deryck | kfogel, so we're now using it as a list of what will actually make release | 17:42 |
| kfogel | deryck: ah, okay. I don't think it matters much; Lean Training said "you're going to write the code you write" and I agree :-). | 17:42 |
| deryck | kfogel, I agree completely too. | 17:43 |
| kfogel | adeuring: I edited the description field in response to a comment from jcastro, but after I clicked the green checkmark to submit my edit, it just spins forever with the red background. Is this a known problem? | 17:48 |
| adeuring | kfogel: haven't noticed this before... | 17:49 |
| kfogel | adeuring, deryck: fascinating. I can't update the bug's description, because of a... bug in updating descriptions, at least with my Firefox 3.5.7 on Karmic+updates. https://pastebin.canonical.com/26408/ has the new desc text. | 17:55 |
| deryck | kfogel, odd. Do you get an error of any kind? | 17:56 |
| adeuring | kfogel: Just copied&pasted your new version and changed the description. | 17:57 |
| kfogel | adeuring: thanks. | 17:58 |
| kfogel | deryck: no, just spins forever. I'm searching/filing a bug on it now. | 17:58 |
| deryck | kfogel, did you reload the page? Perhaps the description was changed, but the UI not updated? | 17:58 |
| kfogel | deryck: I tried a reload while it was spinning, last time, and my edit had not taken. (But good question: I will remember to include that in the bug report.) | 17:59 |
| mrevell | night all | 18:00 |
| * deryck has to bail for food before a call later... | 18:01 | |
| === deryck is now known as deryck[lunch] | ||
| === gary_poster is now known as gary-lunch | ||
| kfogel | adeuring: you might want to add your browser info to follow up to my comment here: https://bugs.edge.launchpad.net/malone/+bug/443217/comments/7 | 18:13 |
| mup | Bug #443217: Changing a bug's affected project or description doesn't ever finish <bug-page> <javascript> <ui> <lazr.restful:New for intellectronica> <Launchpad Bugs:Triaged by intellectronica> <https://launchpad.net/bugs/443217> | 18:14 |
| === kfogel is now known as kfogel-lunch | ||
| === beuno-lunch is now known as beuno | ||
| === deryck[lunch] is now known as deryck | ||
| deryck | kfogel-lunch, jusy fyi... when you see the red border on a failed AJax interaction, that's a server error of some sort, usually. Next time, use Firebug and get the error info that failed to display to the web page. | 18:56 |
| === gary-lunch is now known as gary_poster | ||
| === barry is now known as flufl | ||
| === flufl is now known as barry | ||
| === EdwinGrubbs is now known as Edwin-lunch | ||
| === salgado is now known as salgado-afk | ||
| jml | bigjools, http://wikitravel.org/en/Wellington#Eat | 20:09 |
| jml | thumper, ^ | 20:09 |
| beuno | sinzui, replied to the package linking email | 20:11 |
| beuno | sorry it took me a while | 20:11 |
| beuno | let me know if it's clear | 20:12 |
| beuno | also, does this plan involve making the series column nullable? | 20:12 |
| beuno | as in, stop this crazyness of linking series to series be mandatory? | 20:12 |
| sinzui | beuno: No and I have said that every time because we want to link to the development series, and we allways know that | 20:12 |
| mwhudson | jml, bigjools, thumper: boulcott st bistro or hummingbird would be nice :-) | 20:13 |
| sinzui | beuno: we do not have a model problem, we have a UI problem | 20:13 |
| sinzui | beuno: what ask for the user to select the development series when we know it? | 20:13 |
| beuno | sinzui, works for me, as long as you can click through without knowing about serieseses | 20:13 |
| wgrant | sinzui: Surely it's better to just link to the project than to lie? | 20:13 |
| wgrant | Linking to the development series is normally a lie, when you in fact want to link to just the project but cannot. | 20:14 |
| beuno | yes, I tend to agree | 20:14 |
| beuno | we will be inventing data | 20:14 |
| beuno | still, defaulting to something is already a big step forward :) | 20:14 |
| sinzui | wgrant: beuno: we have a separate problem for next month to ensure the development series is correct. because it can change, behind the Ubuntu contributors back, the upstream project needs more help to get this fixed. | 20:15 |
| sinzui | wgrant: the user is still requested to select a series, we will except the project if the user does not provide a series | 20:16 |
| sinzui | beuno: wgrant: the user experience is bad because we designed for the rare cases where there are many upstream series. We need to handle cases like python in a different manner. | 20:17 |
| === kfogel-lunch is now known as kfogel | ||
| mwhudson | down to 8 import policy violations, i see | 20:26 |
| bigjools | gary_poster: around? | 20:30 |
| bigjools | bug 505657 | 20:30 |
| gary_poster | bigjools: hi, yes | 20:30 |
| mup | Bug #505657: tachandler.py imports from launchpad <Launchpad Foundations:New> <https://launchpad.net/bugs/505657> | 20:30 |
| bigjools | gary_poster: hi there. We have a problem with that bug --^ :( | 20:30 |
| gary_poster | bigjools: ok, looking | 20:31 |
| bigjools | it's kinda urgent is it's going to block lamont from rolling out buildd changes | 20:31 |
| kfogel | intellectronica: got time for a few questions? | 20:32 |
| gary_poster | bigjools: ok, got urgency, but trying to understand problem still. staring at bug more... | 20:33 |
| gary_poster | bigjools, I'm afraid I don't have enough context to understand. Want to try Skype? | 20:34 |
| bigjools | gary_poster: I'm not particularly familiar with it either, just a sec, I'll talk to people here | 20:35 |
| gary_poster | bigjools: ack | 20:35 |
| bigjools | gary_poster: looks like the memcache stuff did something to tachandler | 20:36 |
| bigjools | gary_poster: see stub's commit 10064 on devel | 20:36 |
| gary_poster | bigjools: ok, looking | 20:36 |
| bigjools | tachandler now imports from lp stuff, which is not ideal for our buildds which don't have LP installed :) | 20:37 |
| gary_poster | bigjools: ok, so either we need to revert just the tachandler file (it looks like stub was just trying to consolidate code) or...is there someplace that tachandler *can* import from that is shared with LP? | 20:39 |
| bigjools | gary_poster: I don't think there is :( | 20:41 |
| bigjools | well, lib/canonical/buildd | 20:42 |
| gary_poster | bigjools: OK, then I think we just need to revert the file, and keep the rest of stub's changes | 20:42 |
| gary_poster | bigjools: are you all in a position to do that, or do you need one of us to do that? | 20:42 |
| bigjools | gary_poster: we can do it if you review it? | 20:43 |
| gary_poster | bigjools: +1 | 20:43 |
| bigjools | cool, thanks gary | 20:43 |
| gary_poster | np | 20:43 |
| gary_poster | bigjools: Beyond the simple revert of the file, the only additional request is a comment saying why we don't import the helper functions, so we don't do this again. :-) | 20:44 |
| bigjools | I was thinking the same as you typed that :) | 20:45 |
| gary_poster | heh cool | 20:46 |
| === matsubara is now known as matsubara-afk | ||
| sinzui | combine-css fails in rocketfule. I cannot identify which of the 100 CSS files is the cause of the failure. And I cannot run dev to work on my own branch. | 21:04 |
| wgrant | sinzui: Tried 'make clean'? rockstar had that problem this morning. | 21:06 |
| rockstar | sinzui, yes, make clean. | 21:06 |
| rockstar | Then make again. | 21:07 |
| sinzui | wgrant: rockstar: Thanks. That fixed the issue | 21:09 |
| beuno | danilos, ping | 21:10 |
| beuno | danilos, do you remember where the "error" message sprite breaks in translations? | 21:10 |
| beuno | flacoste, do you? the bug I have assigned is 405476, but that one's too generic | 21:10 |
| * sinzui thinks how to make the error appear | 21:12 | |
| al-maisan | rockstar: https://bugs.edge.launchpad.net/soyuz/+bug/506142 | 21:13 |
| mup | Bug #506142: JobStatus should have a "SUSPENDED" member <buildfarm> <Soyuz:In Progress by al-maisan> <https://launchpad.net/bugs/506142> | 21:13 |
| sinzui | beuno: I tried to remove the summary from a ProductSeries and got a small error. It is not dramatic, but you will see two icons in the z-index under the bug icon | 21:14 |
| beuno | sinzui, will try that, thanks | 21:15 |
| flacoste | beuno: https://translations.edge.launchpad.net/ubuntu/karmic/+source/apturl/+pots/apturl/av/+translate | 21:16 |
| flacoste | beuno: Bugs 405476, 389737, 487142 | 21:16 |
| beuno | perfect | 21:16 |
| beuno | I can work with that | 21:16 |
| beuno | thanls | 21:16 |
| intellectronica | kfogel: sure | 21:16 |
| sinzui | beuno: the markup is <p class="error message">text</p> no inside markup! I may have discovered a different but related problem | 21:17 |
| kfogel | intellectronica: oh, hey. I'm working on bug #506018, and burrowing my way through much documentation for the first time. If you have time for a phone call, that might be fastest. | 21:21 |
| mup | Bug #506018: Need a "+patches" view: report lists patches attached to bugs. <story-patch-report> <Launchpad Bugs:Triaged by kfogel> <https://launchpad.net/bugs/506018> | 21:21 |
| jml | mwhudson, my use-testtools branch is now blocked on fixing the upcalls in the signon code | 21:22 |
| intellectronica | kfogel: i can do a phone call, but i need 10m first so that you don't have to hear me chewing :) | 21:22 |
| kfogel | intellectronica: heh, that's fine | 21:22 |
| mwhudson | jml: :( | 21:23 |
| mwhudson | jml: i guess i can land my build-testtools in the mean time; that should get the bzr buildbot running a bit better at least | 21:23 |
| jml | mwhudson, yeah, I think so. | 21:24 |
| === Edwin-lunch is now known as EdwinGrubbs | ||
| intellectronica | kfogel: ready when you are. skype? | 21:34 |
| kfogel | intellectronica: my skype may or may not be broken. let's try it, but watch here in case you can't hear me. | 21:35 |
| intellectronica | kfogel: np. if not i can call you on skype creds | 21:35 |
| kfogel | intellectronica: what's your skype name? | 21:36 |
| intellectronica | kfogel: tom.berger | 21:36 |
| jml | noodles775, would you like to review https://code.edge.launchpad.net/~jml/launchpad/behavior-refactor/+merge/17127 | 21:36 |
| kfogel | intellectronica: ringing and ringing | 21:36 |
| kfogel | intellectronica: do you hear it ringing for you? | 21:36 |
| noodles775 | jml, sure | 21:37 |
| kfogel | intellectronica: huhn | 21:37 |
| kfogel | can you hear me? | 21:37 |
| kfogel | intellectronica: did you pick up? | 21:37 |
| intellectronica | kfogel: nope | 21:37 |
| kfogel | intellectronica: ok, sigh | 21:37 |
| jml | wgrant, oi | 21:37 |
| intellectronica | kfogel: i did pick up but i can't hear anything. could my setup. let me check | 21:37 |
| jml | wgrant, where's the branch you're working on? | 21:38 |
| jml | wgrant, I'd like to merge it in to the what we're doing | 21:38 |
| jml | bigjools, I'm talking about hacking on soyuz, what are you talking about? :P | 21:39 |
| kfogel | intellectronica: +1 (773) 351-1729? Let me get that headset on though. | 21:39 |
| kfogel | intellectronica: ? are you having Net troubles? | 21:41 |
| wgrant | jml: What are you wanting to do buildd-wise? | 21:41 |
| jml | wgrant, mostly just to make sure I'm not blundering all over your work. | 21:42 |
| intellectronica | kfogel: so it seems :-/ | 21:42 |
| kfogel | intellectronica: whups | 21:43 |
| wgrant | jml: lp:~wgrant/launchpad/lp-buildd-generalisation, but you'll need to unbreak tachandler yourself if you want to run it. | 21:43 |
| jml | wgrant, ok. thanks. | 21:43 |
| intellectronica | kfogel: sorry, i'm trying to work out what's the problem. if i can't, do you have an affordable way to call my phone? | 21:45 |
| kfogel | intellectronica: hmrmrm. I have some skype credit; whether skype works for me is another question, but I can try. | 21:46 |
| kfogel | intellectronica: privmsg me your number. in the meantime, I'll do a skype test call just to see. | 21:46 |
| intellectronica | kfogel: nevermind, got it working, i think, let's give it a try | 21:47 |
| kfogel | intellectronica: https://bugs.edge.launchpad.net/malone/+bug/506018 | 21:48 |
| mup | Bug #506018: Need a "+patches" view: report lists patches attached to bugs. <story-patch-report> <Launchpad Bugs:Triaged by kfogel> <https://launchpad.net/bugs/506018> | 21:48 |
| kfogel | intellectronica: https://pastebin.canonical.com/26421/ | 22:01 |
| gary_poster | bigjools, wgrant: branch approved. Thank you. | 22:01 |
| kfogel | intellectronica: we're fading | 22:02 |
| bigjools | gary_poster: cheers | 22:02 |
| kfogel | intellectronica: can you hear me? | 22:02 |
| wgrant | gary_poster: Thanks. | 22:02 |
| kfogel | intellectronica: http://www2.bryceharrington.org:8080/X/Reports/patches.html | 22:04 |
| kfogel | intellectronica: this is in lib/lp/bugs/model/bugtarget.py ? | 22:06 |
| thumper | gary_poster: do you know about copy_field? | 22:09 |
| thumper | I have a feeling it isn't quite doing what I want | 22:09 |
| gary_poster | thumper: I don't think I do. I'll look at it if you like | 22:09 |
| thumper | hmm.. | 22:09 |
| thumper | fields have implicit names somewhere don't they? | 22:10 |
| gary_poster | you mean, they know what they were called in the interface? if so, yes | 22:10 |
| thumper | gary_poster: I mean what the widget names become | 22:10 |
| thumper | fields.xxx | 22:10 |
| gary_poster | ah, yes, they do | 22:10 |
| thumper | hmm | 22:11 |
| thumper | I have branch_name = copy_field(IBranch['name']) | 22:11 |
| gary_poster | I'm pretty sure you can affect those names | 22:11 |
| thumper | and I want the widget and field to be called 'branch_name' not 'name' | 22:11 |
| gary_poster | thumper, will look at zope.formlib, one sec. I think that's the pertinent bit. Where is copy_field defined? | 22:12 |
| thumper | lazr.restfull | 22:12 |
| thumper | s/ll/l/ | 22:12 |
| gary_poster | a ok | 22:12 |
| thumper | .interfaces | 22:12 |
| gary_poster | thumper: try ``copy_field(IBranch['name'], __name__='branch_name')`` | 22:15 |
| thumper | gary_poster: I was just about to try that :) | 22:16 |
| gary_poster | :-) | 22:16 |
| thumper | works :) | 22:17 |
| thumper | ta | 22:17 |
| kfogel | intellectronica: still on? | 22:21 |
| kfogel | intellectronica: can hear me? | 22:21 |
| al-maisan | rockstar: https://bugs.edge.launchpad.net/soyuz/+bug/497520 | 22:38 |
| mup | Bug #497520: Disabled archives should automatically have their waiting builds removed <buildfarm> <ppa> <soyuz-build> <Soyuz:In Progress by al-maisan> <https://launchpad.net/bugs/497520> | 22:38 |
| lifeless | barry: ping | 22:39 |
| barry | lifeless: pong | 22:39 |
| lifeless | barry: you've climbed around inside distutils right | 22:40 |
| barry | a bit ;) | 22:40 |
| lifeless | I have two questions for you | 22:40 |
| lifeless | what does bzr integration actually do | 22:40 |
| lifeless | and | 22:40 |
| lifeless | how can I get 'setup.py sdist upload' to set the description field on the new release that that creates? | 22:41 |
| lifeless | barry: ^ | 22:43 |
| barry | lifeless: sorry, multitasking ;) | 22:43 |
| barry | the setuptools_bzr really just allows lazy package authors to not have to write a MANIFEST.in | 22:43 |
| lifeless | barry: au naturale | 22:43 |
| barry | it essentially queries bzr to find out what files are under vc and automatically adds them to the manifest | 22:43 |
| lifeless | barry: ah, its setuptools only? not distutils? | 22:43 |
| barry | i think it's distutils too, but distutils only supports svn out of the box | 22:44 |
| barry | lifeless: in truth though, it's much more trouble than its worth, so i don't plan on continuing to support it | 22:44 |
| barry | lifeless: and our lp packages don't use it any more | 22:44 |
| barry | the trouble isn't so much bzr, but distutils :/ | 22:44 |
| kfogel | intellectronica: you're in UK right? | 22:45 |
| intellectronica | kfogel: yup | 22:46 |
| barry | as for your second question, setting the 'description' and 'long_description' in your setup.py should do the trick. does it not? | 22:46 |
| jml | mwhudson, what's the correct type for sourcepackagerecipe.manifest | 22:47 |
| jml | sprbuild.manifest | 22:47 |
| jml | rather. | 22:47 |
| mwhudson | jml: in the zope.schema sense? | 22:47 |
| jml | mwhudson, indeed. | 22:47 |
| mwhudson | jml: probably just Attribute | 22:47 |
| kfogel | intellectronica: let's pick this up tomorrow then; I'm startig pretty early anyway, and I think it would be useful for me to do some poking around on my own now. | 22:47 |
| jml | mwhudson, ok. | 22:47 |
| intellectronica | kfogel: cool | 22:48 |
| kfogel | intellectronica: a lot of the dev wiki documentation makes a lot more sense now -- thank you for your help. | 22:48 |
| mwhudson | jml: for api purposes we'll want to expose a text representation i guess | 22:48 |
| mwhudson | jml: requires bzr-builder changes tho | 22:48 |
| lifeless | barry: which one ends up in the rest field in pypi | 22:48 |
| intellectronica | np. zope is a beast, but you'll get it in no time | 22:48 |
| barry | lifeless: otp | 22:49 |
| lifeless | otp? | 22:50 |
| mwhudson | on the phone | 22:50 |
| mwhudson | i expect | 22:50 |
| EdwinGrubbs | sinzui: ping | 22:50 |
| mwhudson | (not the erlang standard library thing) | 22:50 |
| sinzui | Hi EdwinGrubbs | 22:50 |
| lifeless | ah yes | 22:50 |
| EdwinGrubbs | sinzui: can you think of any reason that the Reply-To header set in notify_team_join() should actually be the proposed member's email address as opposed to the reviewer who is actually proposing them? | 22:52 |
| sinzui | EdwinGrubbs: yes. "invite" in the ui is admin -> user, but "propose" in the ui is user -> team | 22:53 |
| sinzui | EdwinGrubbs: So the user performing the action should be the reply to. | 22:53 |
| EdwinGrubbs | sinzui: I guess I should just remove the security proxy here when someone besides an LP admin or the user themself tries to propose someone as a member through launchpadlib. | 23:05 |
| * sinzui thinks | 23:06 | |
| sinzui | EdwinGrubbs: I think that is fair. If the user wants to join the team he must be willing to share his address. We do not how ever want someone to be able to craft a script to propose joining a team to learn another user's email address. In the contact-this-user feature the email address is shown to the other user. If the other user has a hidden email address, he must chose carefully about the consequences of his reply. | 23:08 |
| sinzui | EdwinGrubbs: I think joining a team is a lot like contact-this-team, so I this the rules of disclosure should be the same. | 23:09 |
| sinzui | EdwinGrubbs: We do use removeSecurityProxy() when send contact-this-user emails. | 23:09 |
| EdwinGrubbs | sinzui: oh, no, it could be used like that in launchpadlib, since it is not the user calling team.join(), it's a team admin calling team.addMember(status=PROPOSED) which normally doesn't happen ever. | 23:10 |
| sinzui | indeed that sounds wrong because the invite is in the wrong state. Proposed means the admin must approve, and surely he would since he just proposed it. | 23:11 |
| EdwinGrubbs | sinzui: I think I will have to talk to the user some more to figure out why they are doing that. | 23:12 |
| sinzui | "invite" is for an admin to contact another team to ask their approval to be added. I favour allowing admins to invite users so that the user can accept rather then discover someone claims they wanted to join the team | 23:13 |
| al-maisan | rockstar: lp:~al-maisan/launchpad/disabled-builds-497520 | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!