/srv/irclogs.ubuntu.com/2010/01/14/#launchpad-reviews.txt

rockstarBjornT, https://code.edge.launchpad.net/~rockstar/launchpad/fix-windmill-canonicalurl/+merge/1732801:24
mwhudsonreviewinate pls https://code.edge.launchpad.net/~mwhudson/launchpad/update-loggerhead/+merge/1733201:48
mwhudson(it's utterly simple)01:48
* thumper looks01:49
thumpermwhudson: r=me01:50
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
mwhudsonrockstar: https://code.edge.launchpad.net/~mwhudson/launchpad/arrargh-no-sourcecode-testtools/+merge/1733702:04
thumperhttps://code.edge.launchpad.net/~thumper/launchpad/code-imports-for-products/+merge/1733802:09
* mwhudson looks02:10
mwhudsonthumper: i'm sure there's a bug for that already02:11
thumpermwhudson: I thought so too, but couldn't find it02:11
mwhudsoni think wgrant filed it :-)02:11
thumpermwhudson: and neighter did the dupe search02:11
* thumper shrugs02:11
mwhudsonthumper: https://bugs.edge.launchpad.net/launchpad-code/+bug/24678202:13
mupBug #246782: "Import for this project page" <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/246782>02:13
thumperomg that is old02:13
mwhudsonit's a pretty crappy bug, i'm not surprised searching didn't find it02:14
al-maisanjtv: https://code.edge.launchpad.net/~al-maisan/launchpad/xx-select-job-506617/+merge/1732702:26
jtval-maisan: lp:~jtv/launchpad/bug-50011002:31
adiroibangmb: Hi, any news about https://code.edge.launchpad.net/~adiroiban/launchpad/bug-496352-series-status-refactor/+merge/16108 ?02:51
=== stub1 is now known as stub
=== thumper is now known as the-watcher
=== the-watcher is now known as thumper
leonardrjml, i never get to do reviews with you, but since my cold woke me up at 3:30 in the morning, you want to review a branch of mine?08:33
jmlleonardr, sure.08:33
jmlleonardr, wanna help me figure out why I can't use 'prepare.py' in lazr.yourpkg?08:34
jmlI guess it's 3:30am, so don't feel obliged.08:34
leonardrjml: no, i'm workin'08:34
leonardrso i'll help you08:34
jmlleonardr, thanks. what's the branch?08:34
leonardrlooking it up now08:34
leonardrjml: https://code.edge.launchpad.net/~leonardr/lazr.restful/bleed-through-stack08:35
leonardrer, https://code.edge.launchpad.net/~leonardr/lazr.restful/bleed-through-stack/+merge/1729808:36
jmlleonardr, reviewed.08:54
leonardrjml, do you know which specific class in lazr.config is the closest to BleedThroughDict?09:08
jmlleonardr, no, just that the behaviour -- layered key/value pairs -- is the same09:08
jmlleonardr, even down to the existence of pushConfig on lp.testing.TestCase09:09
gmbadiroiban: It didn't land already? That's weird (I don't get emails about it unless it fails). I'll look into it.09:17
=== matsubara-afk is now known as matsubara
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
=== matsubara is now known as matsubara-lunch
=== salgado is now known as salgado-lunch
=== matsubara-lunch is now known as matsubara
=== beuno is now known as beuno-lunch
=== salgado-lunch is now known as salgado
=== henninge_ is now known as henninge
=== beuno-lunch is now known as beuno
beunoadeuring, did my review make sense?17:36
adeuringbeuno: yeah, sure, i agree with your suggetsions.17:36
adeuringbeuno: problem is that CHR duties distracted me today...17:37
beunoheh, it's ok. I wanted to make sure they made sense to you17:37
beunojumping around projects all the time sometimes makes me slip  :)17:38
adeuringbeuno: ;)17:38
=== deryck is now known as deryck[lunch]
=== deryck[lunch] is now known as deryck
rockstarthumper, https://code.edge.launchpad.net/~rockstar/launchpad/clean-code-windmill-tests/+merge/1736020:01
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
al-maisanrockstar: https://code.edge.launchpad.net/~al-maisan/launchpad/observe-virtualized-507323/+merge/1741220:51
rockstarthumper, https://code.edge.launchpad.net/~rockstar/launchpad/branch-scan-job-script/+merge/1742922:38
thumperrockstar: https://code.edge.launchpad.net/~thumper/launchpad/branch-active-reviews/+merge/1743323:46
thumperrockstar: https://code.edge.launchpad.net/~thumper/launchpad/propose-merging-extra-options/+merge/1735023:47

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!