| rockstar | BjornT, https://code.edge.launchpad.net/~rockstar/launchpad/fix-windmill-canonicalurl/+merge/17328 | 01:24 |
|---|---|---|
| mwhudson | reviewinate pls https://code.edge.launchpad.net/~mwhudson/launchpad/update-loggerhead/+merge/17332 | 01:48 |
| mwhudson | (it's utterly simple) | 01:48 |
| * thumper looks | 01:49 | |
| thumper | mwhudson: r=me | 01:50 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| mwhudson | rockstar: https://code.edge.launchpad.net/~mwhudson/launchpad/arrargh-no-sourcecode-testtools/+merge/17337 | 02:04 |
| thumper | https://code.edge.launchpad.net/~thumper/launchpad/code-imports-for-products/+merge/17338 | 02:09 |
| * mwhudson looks | 02:10 | |
| mwhudson | thumper: i'm sure there's a bug for that already | 02:11 |
| thumper | mwhudson: I thought so too, but couldn't find it | 02:11 |
| mwhudson | i think wgrant filed it :-) | 02:11 |
| thumper | mwhudson: and neighter did the dupe search | 02:11 |
| * thumper shrugs | 02:11 | |
| mwhudson | thumper: https://bugs.edge.launchpad.net/launchpad-code/+bug/246782 | 02:13 |
| mup | Bug #246782: "Import for this project page" <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/246782> | 02:13 |
| thumper | omg that is old | 02:13 |
| mwhudson | it's a pretty crappy bug, i'm not surprised searching didn't find it | 02:14 |
| al-maisan | jtv: https://code.edge.launchpad.net/~al-maisan/launchpad/xx-select-job-506617/+merge/17327 | 02:26 |
| jtv | al-maisan: lp:~jtv/launchpad/bug-500110 | 02:31 |
| adiroiban | gmb: Hi, any news about https://code.edge.launchpad.net/~adiroiban/launchpad/bug-496352-series-status-refactor/+merge/16108 ? | 02:51 |
| === stub1 is now known as stub | ||
| === thumper is now known as the-watcher | ||
| === the-watcher is now known as thumper | ||
| leonardr | jml, i never get to do reviews with you, but since my cold woke me up at 3:30 in the morning, you want to review a branch of mine? | 08:33 |
| jml | leonardr, sure. | 08:33 |
| jml | leonardr, wanna help me figure out why I can't use 'prepare.py' in lazr.yourpkg? | 08:34 |
| jml | I guess it's 3:30am, so don't feel obliged. | 08:34 |
| leonardr | jml: no, i'm workin' | 08:34 |
| leonardr | so i'll help you | 08:34 |
| jml | leonardr, thanks. what's the branch? | 08:34 |
| leonardr | looking it up now | 08:34 |
| leonardr | jml: https://code.edge.launchpad.net/~leonardr/lazr.restful/bleed-through-stack | 08:35 |
| leonardr | er, https://code.edge.launchpad.net/~leonardr/lazr.restful/bleed-through-stack/+merge/17298 | 08:36 |
| jml | leonardr, reviewed. | 08:54 |
| leonardr | jml, do you know which specific class in lazr.config is the closest to BleedThroughDict? | 09:08 |
| jml | leonardr, no, just that the behaviour -- layered key/value pairs -- is the same | 09:08 |
| jml | leonardr, even down to the existence of pushConfig on lp.testing.TestCase | 09:09 |
| gmb | adiroiban: It didn't land already? That's weird (I don't get emails about it unless it fails). I'll look into it. | 09:17 |
| === matsubara-afk is now known as matsubara | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| === beuno is now known as beuno-lunch | ||
| === salgado-lunch is now known as salgado | ||
| === henninge_ is now known as henninge | ||
| === beuno-lunch is now known as beuno | ||
| beuno | adeuring, did my review make sense? | 17:36 |
| adeuring | beuno: yeah, sure, i agree with your suggetsions. | 17:36 |
| adeuring | beuno: problem is that CHR duties distracted me today... | 17:37 |
| beuno | heh, it's ok. I wanted to make sure they made sense to you | 17:37 |
| beuno | jumping around projects all the time sometimes makes me slip :) | 17:38 |
| adeuring | beuno: ;) | 17:38 |
| === deryck is now known as deryck[lunch] | ||
| === deryck[lunch] is now known as deryck | ||
| rockstar | thumper, https://code.edge.launchpad.net/~rockstar/launchpad/clean-code-windmill-tests/+merge/17360 | 20:01 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| al-maisan | rockstar: https://code.edge.launchpad.net/~al-maisan/launchpad/observe-virtualized-507323/+merge/17412 | 20:51 |
| rockstar | thumper, https://code.edge.launchpad.net/~rockstar/launchpad/branch-scan-job-script/+merge/17429 | 22:38 |
| thumper | rockstar: https://code.edge.launchpad.net/~thumper/launchpad/branch-active-reviews/+merge/17433 | 23:46 |
| thumper | rockstar: https://code.edge.launchpad.net/~thumper/launchpad/propose-merging-extra-options/+merge/17350 | 23:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!