[01:24] BjornT, https://code.edge.launchpad.net/~rockstar/launchpad/fix-windmill-canonicalurl/+merge/17328 [01:48] reviewinate pls https://code.edge.launchpad.net/~mwhudson/launchpad/update-loggerhead/+merge/17332 [01:48] (it's utterly simple) [01:49] * thumper looks [01:50] mwhudson: r=me === EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [02:04] rockstar: https://code.edge.launchpad.net/~mwhudson/launchpad/arrargh-no-sourcecode-testtools/+merge/17337 [02:09] https://code.edge.launchpad.net/~thumper/launchpad/code-imports-for-products/+merge/17338 [02:10] * mwhudson looks [02:11] thumper: i'm sure there's a bug for that already [02:11] mwhudson: I thought so too, but couldn't find it [02:11] i think wgrant filed it :-) [02:11] mwhudson: and neighter did the dupe search [02:11] * thumper shrugs [02:13] thumper: https://bugs.edge.launchpad.net/launchpad-code/+bug/246782 [02:13] Bug #246782: "Import for this project page" [02:13] omg that is old [02:14] it's a pretty crappy bug, i'm not surprised searching didn't find it [02:26] jtv: https://code.edge.launchpad.net/~al-maisan/launchpad/xx-select-job-506617/+merge/17327 [02:31] al-maisan: lp:~jtv/launchpad/bug-500110 [02:51] gmb: Hi, any news about https://code.edge.launchpad.net/~adiroiban/launchpad/bug-496352-series-status-refactor/+merge/16108 ? === stub1 is now known as stub === thumper is now known as the-watcher === the-watcher is now known as thumper [08:33] jml, i never get to do reviews with you, but since my cold woke me up at 3:30 in the morning, you want to review a branch of mine? [08:33] leonardr, sure. [08:34] leonardr, wanna help me figure out why I can't use 'prepare.py' in lazr.yourpkg? [08:34] I guess it's 3:30am, so don't feel obliged. [08:34] jml: no, i'm workin' [08:34] so i'll help you [08:34] leonardr, thanks. what's the branch? [08:34] looking it up now [08:35] jml: https://code.edge.launchpad.net/~leonardr/lazr.restful/bleed-through-stack [08:36] er, https://code.edge.launchpad.net/~leonardr/lazr.restful/bleed-through-stack/+merge/17298 [08:54] leonardr, reviewed. [09:08] jml, do you know which specific class in lazr.config is the closest to BleedThroughDict? [09:08] leonardr, no, just that the behaviour -- layered key/value pairs -- is the same [09:09] leonardr, even down to the existence of pushConfig on lp.testing.TestCase [09:17] adiroiban: It didn't land already? That's weird (I don't get emails about it unless it fails). I'll look into it. === matsubara-afk is now known as matsubara === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === matsubara is now known as matsubara-lunch === salgado is now known as salgado-lunch === matsubara-lunch is now known as matsubara === beuno is now known as beuno-lunch === salgado-lunch is now known as salgado === henninge_ is now known as henninge === beuno-lunch is now known as beuno [17:36] adeuring, did my review make sense? [17:36] beuno: yeah, sure, i agree with your suggetsions. [17:37] beuno: problem is that CHR duties distracted me today... [17:37] heh, it's ok. I wanted to make sure they made sense to you [17:38] jumping around projects all the time sometimes makes me slip :) [17:38] beuno: ;) === deryck is now known as deryck[lunch] === deryck[lunch] is now known as deryck [20:01] thumper, https://code.edge.launchpad.net/~rockstar/launchpad/clean-code-windmill-tests/+merge/17360 === matsubara is now known as matsubara-afk === salgado is now known as salgado-afk [20:51] rockstar: https://code.edge.launchpad.net/~al-maisan/launchpad/observe-virtualized-507323/+merge/17412 [22:38] thumper, https://code.edge.launchpad.net/~rockstar/launchpad/branch-scan-job-script/+merge/17429 [23:46] rockstar: https://code.edge.launchpad.net/~thumper/launchpad/branch-active-reviews/+merge/17433 [23:47] rockstar: https://code.edge.launchpad.net/~thumper/launchpad/propose-merging-extra-options/+merge/17350