[01:43] <thumper> noodles775: https://code.edge.launchpad.net/~michael.nelson/+activereviews
[03:17] <rockstar> thumper, https://code.edge.launchpad.net/~rockstar/launchpad/update-review-table-on-comment/+merge/17439
[03:49] <thumper> rockstar: https://code.edge.launchpad.net/~thumper/launchpad/js-play/+merge/17193
[04:28] <rockstar> mwhudson, https://code.edge.launchpad.net/~rockstar/launchpad/pedantry-round1/+merge/17441
[04:29] <mwhudson> +1 with added swearing
[04:35] <thumper> noodles775: https://code.edge.launchpad.net/~thumper/launchpad/js-play/+merge/17193
[06:28] <stub> https://code.launchpad.net/~stub/launchpad/bug-504291-disconnection-errors/+merge/17371 is a fix for the High priority Bug #504291
[06:28] <mup> Bug #504291: DisconnectionErrors (already disconnected) happening again <oops> <Launchpad Foundations:In Progress by stub> <Storm:Invalid> <https://launchpad.net/bugs/504291>
[07:29] <henninge> Good morning!
[07:29] <henninge> When ever a reviewer comes around, I'd be glad to get a review for my branch ... ;-)
=== henninge changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [henninge] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[09:59] <henninge> noodles775: https://code.edge.launchpad.net/~henninge/launchpad/buildmaster-failure/+merge/17449
[09:59] <noodles775> Looking
[10:06] <noodles775> henninge, done. Thanks for that!
[10:07] <henninge> noodles775: I saw it, thanks. Already in pqm.
[11:05] <salgado> henninge, how about exchanging some reviews? ;)
[11:06] <henninge> salgado: with pleasure!
[11:07] <salgado> henninge, where's yours?  mine's at https://code.edge.launchpad.net/~salgado/lazr.restful/bug-507447/+merge/17395
[11:07] <henninge> salgado: https://code.edge.launchpad.net/~henninge/launchpad/bug-488765-oops-translations/+merge/17396
[11:12] <henninge> salgado: done
=== matsubara-afk is now known as matsubara
[11:33] <salgado> henninge, I assume danilo was ok with fixing the bug by changing the view?  I ask because I see no comments from him on the bug after you listed the different ways we could fix it
[11:34] <henninge> salgado: danilo is out of order atm ... ;)
[11:34] <henninge> salgado: yes, I am sure he is ok with that.
[11:36] <henninge> salgado: bug 507534 is the real bug that still needs to be fixed.
[11:36] <mup> Bug #507534: Product.primary_translatable also lists source packages <Launchpad Translations:New> <https://launchpad.net/bugs/507534>
[11:36] <henninge> and that is what danilo propsed, too.
[11:37] <henninge> This is mainly to stop the oops from happening and not getting an empty page.
[11:39] <salgado> ok
=== salgado changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
[14:21] <bac> salgado: can i get a review for a tiny branch?
[14:21] <salgado> bac, sure!
[14:21] <bac> salgado: cool:  https://code.edge.launchpad.net/~bac/launchpad/bug-491320/+merge/17458
[14:22] <bac> salgado: rebooting but i'll be right back
=== henninge_ is now known as henninge
[14:26] <henninge> salgado, bac: can you tell me what this TALES statement does exactly?
[14:26] <henninge> context/required:launchpad.TranslationsAdmin
[14:26] <henninge> Does it mean "true if the current user has this permission on the current view"?
[14:26] <salgado> henninge, returns True if the logged in user has the given permission on context
[14:27] <henninge> context, not view, right.
[14:27] <henninge> salgado: thanks
[14:41] <salgado> bac, what was causing the newlines and spaces to be added to the text area?
[14:44] <bac> salgado, the spaces and newlines between <textarea> and </textarea>
[14:44] <salgado> oh, of course
=== salgado is now known as salgado-lunch
=== henninge changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: - || queue [henninge] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:50] <henninge> salgado-lunch: I have replied to your review and put another branch up for review. If you could be so kind ... ;)
[14:53] <henninge> salgado-lunch: oh, and please don't forget to enter "code" as the review type to keep "ec2 land" happy.
[14:58] <EdwinGrubbs> allenap: did you already start reviewing my branch? I was going to ask salgado to review it otherwise.
[14:59] <allenap> EdwinGrubbs: I am so sorry, no I haven't. I've been working on this sort-of-critical checkwatches issue and I forgot. Please ask salgado as I'm still working on it.
[15:00]  * allenap tasers himself in an act of modern auto-flagellation for forgetting.
[15:02] <EdwinGrubbs> salgado-lunch: can you review this branch. About half of it is simple search and replace on zcml files, so it is actually much easier than the size of the diff would indicate.  https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-451208-subscribing-reveals-email/+merge/17261
[15:20] <bac> salgado-lunch, thanks for the review
=== matsubara is now known as matsubara-lunch
=== salgado-lunch is now known as salgado
[16:04] <salgado> EdwinGrubbs, sure, I'll get to it soon
[16:04] <henninge> Hi salgado, I will not be around for much longer. Do you think you can have a look at my second proposal?
[16:04] <salgado> henninge, do you know how to enter the review type using the email interface?
[16:04] <salgado> doing that now
[16:04] <henninge> yes, just append
[16:04] <henninge> review approve code
[16:04] <salgado> cool
[16:05] <henninge> salgado: thanks a lot!
=== henninge is now known as henninge-brb
=== salgado changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: Edwin || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== henninge-brb is now known as henninge
=== matsubara-lunch is now known as matsubara
=== henninge changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: Edwin || queue [henninge] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:41] <henninge> salgado: thanks for the review. There is another branch of mine, just a short one.
[16:41] <henninge> salgado: https://code.edge.launchpad.net/~henninge/launchpad/bug-507498-oops-subset/+merge/17459
[16:41] <salgado> henninge, ok
[16:42] <henninge> salgado: I will leave now but if it's easy, please just do.
[16:42] <henninge> salgado: thank you very much!
[16:42] <salgado> well, you should tell me if it's easy or not. ;)
[17:01] <salgado> gary_poster, can we check that an object is security proxied in a way that's less ugly than http://paste.ubuntu.com/357145/?
[17:06] <henninge> salgado: I meant, if you don't have any questions ... ;)
[17:08] <henninge> salgado: I am off, ttyl ;-)
[17:22] <gary_poster> salgado: yes I think so (sorry was on call
[17:22] <gary_poster> getting ref
[17:24] <gary_poster> salgado: would queryProxy from zope.security work for you (see http://svn.zope.org/zope.proxy/trunk/src/zope/proxy/interfaces.py?rev=75161&view=auto )
[17:26] <salgado> gary_poster, I think it should work, let me check with EdwinGrubbs 
[17:26] <salgado> EdwinGrubbs, ^
[17:29] <EdwinGrubbs> salgado: I can try that.
=== beuno is now known as beuno-lunch
=== beuno-lunch is now known as beuno
=== deryck is now known as deryck[lunch]
=== deryck[lunch] is now known as deryck
[19:10] <EdwinGrubbs> salgado, gary_poster: I'm getting this error: ComponentLookupError: (<InterfaceClass zope.proxy.interfaces.IProxyIntrospection>, '')
[19:11] <gary_poster> EdwinGrubbs: it's not a utility
[19:11] <gary_poster> EdwinGrubbs: just import the desired function from zope.security
[19:11] <gary_poster> EdwinGrubbs: the interface describes what the package offers
[19:11] <gary_poster> zope.proxy I mean
[19:12] <gary_poster> EdwinGrubbs: ^^^
[19:18] <EdwinGrubbs> gary_poster: thanks, that worked
[19:18] <gary_poster> EdwinGrubbs: cool, np
[19:19] <EdwinGrubbs> salgado: did you want get_naked_vocab() defined just in that one doc test or added to the globals in c/l/testing/systemdocs.py?
[19:20] <salgado> EdwinGrubbs, just that one would be fine, I think
[19:37] <EdwinGrubbs> salgado: reply sent. I'm going to lunch now.
=== EdwinGrubbs is now known as Edwin-lunch
[19:41] <salgado> Edwin-lunch, why do you need the "vocab.__module__[:5] != 'zope.'" in your test?
=== salgado changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
=== Edwin-lunch is now known as EdwinGrubbs
[21:25] <EdwinGrubbs> salgado-afk: because there are a few vocabs that zope registers but not as a secured utility.
[21:49] <EdwinGrubbs> sinzui: did you want to review my one line fix for deactivating an account or wait until we hear back on how we can add real testing for this?
[21:50] <sinzui> EdwinGrubbs: I would like to review it. I'll look at the history of the problem if I think we need to do something else
[21:51] <EdwinGrubbs> sinzui: here is the diff. https://pastebin.canonical.com/26685/
[21:52] <EdwinGrubbs> sinzui: do you want an MP?
[21:52] <sinzui> No, I'll just look at blame to see some context
[21:55] <EdwinGrubbs> sinzui: You can make it lp.registry.tests.test_person.TestPerson.test_deactivateAccount_copes_with_names_already_in_use fail in the same way the oops does just by making this change on launchpad_ftest_template.   REVOKE UPDATE, INSERT ON EmailAddress FROM write;
[21:59] <sinzui> EdwinGrubbs: r=me. Every instance of this use was added 11 months ago as a part of the DB reconfiguration. There are no tests for this kind if issue
[22:29] <jamalta> Hi, I'm looking into fixing a trivial bug to see if I can get into helping with Launchpad a bit again
[22:29] <jamalta> I was looking at bug #253525 and can only find one place that changesfile is still listed
[22:29] <mup> Bug #253525: changesfile isn't a word <ppa> <trivial> <ui> <Soyuz:Triaged> <https://launchpad.net/bugs/253525>
[22:30] <jamalta> Anyways, my question is, what would be the best name for it to replace changesfile? The +archive/ppa page now reads "sources.changes"
[22:30] <jamalta> https://edge.launchpad.net/~schooltool-owners/+archive/ppa/+packages <-- page that still shows changesfile
[22:31] <sinzui> jamalta: "sources.changes" will do fine
[22:31] <jamalta> sinzui: thanks :)
[22:33] <sinzui> jamalta: I think you need to update some stories that verify the text
[22:33] <sinzui> lp/soyuz/stories/soyuz/xx-distribution-sources.txt for example
[22:34] <jamalta> sinzui: alright, i will make sure to udpate that as well
[22:34] <jamalta> also, i found a template that references changesfile but can't figure out where that template is loaded
[22:35] <jamalta> lp/soyuz/templates//distroseriessourcepackagerelease-index.pt
[22:35] <sinzui> jamalta: search for the file name in soyuze/browser/configure.zcml
[22:35] <jamalta> sinzui: ah awesome, thanks
[22:36] <sinzui> jamalta: configure is not a nice file to visit. That is were the view and template are registered under a name (+something)
[22:38] <sinzui> jamalta: This looks like the tests that need updating to pass with your changes. I am not certain though: http://pastebin.ubuntu.com/357284/
[22:38] <jamalta> sinzui: right, makes sense.. i actually was trying to find such file to figure out where the template was used :)
[22:41] <sinzui> jamalta: `./bin/test -vvc -t soyuz.*stories` will run all the stories to verify you text change.
[22:41] <jamalta> it's a bit heavy to take in, though, you're right
=== mup_ is now known as mup
[22:41] <bac> sinzui: if you get bored between now and tuesday...  https://code.edge.launchpad.net/~bac/launchpad/bug-499351-batching-dls/+merge/17492
[22:45] <sinzui> I'll review your branch now
[22:52] <sinzui> bac: why do you cast the list to a list on line 87 of the diff?
[22:52] <sinzui>      list(series_and_releases
[22:54] <bac> sinzui: an abundance of caution?
[22:54] <bac> stupidity?
[22:54] <bac> leftover from when s_r used to be something else, i think.
[22:54] <bac> yeah, i dumbly made it a set to start with.  that was suboptimal for many reasons.
[22:54] <sinzui> okay.
[22:55] <sinzui> anyway, r=me I think you can drop the cast
[22:56] <bac> sinzui: thanks