| mrevell | henninge, ping | 11:02 |
|---|---|---|
| henninge | mrevell: Hi! | 11:02 |
| mrevell | hey henninge, remember my translation help branch? I'm getting an odd error from ec2 test. Mind if I pastebin it to you? | 11:03 |
| henninge | mrevell: go ahead! | 11:03 |
| henninge | https://pastebin.canonical.com/26742/ | 11:05 |
| henninge | mrevell: the import violations are not your error. | 11:05 |
| henninge | mrevell: there has been a thread about that on the mailing list. | 11:06 |
| mrevell | henninge, Ah, I must have missed that. I'll go re-read | 11:06 |
| henninge | mrevell: you can still fix it, though, if you like. | 11:07 |
| henninge | ;-) | 11:08 |
| mrevell | henninge, I'm assuming I just need to merge the latest devel. | 11:08 |
| mrevell | Is that right? | 11:08 |
| henninge | mrevell: I thought ec2 uses the latest devel for the test. | 11:08 |
| henninge | mrevell: but that is a good check in any case. | 11:09 |
| henninge | mrevell: you do that and I'll prepare a patch that you can add to your branch, if it does not help. | 11:09 |
| mrevell | henninge, Thanks :) | 11:10 |
| henninge | mrevell: looks like one is gone, the other was my doing.... | 11:14 |
| mrevell | henninge, When you say "gone", does that mean I don't need to worry about it? | 11:15 |
| henninge | mrevell: yes, it means it is fixed in latest devel (from looking at the code). | 11:16 |
| mrevell | cool | 11:17 |
| henninge | mrevell: I'll have a fix for the other one once I ran a test on it. | 11:17 |
| mrevell | Ah thanks | 11:17 |
| mrevell | henninge, I'm just looking at the xx-translation-import-queue.txt failure | 11:18 |
| henninge | mrevell: yes, what does it look like? | 11:18 |
| henninge | mrevell: here is the patch for import violation | 11:22 |
| henninge | mrevell: you can just forward me the FAILURE mail btw. | 11:22 |
| henninge | http://paste.ubuntu.com/358977/ | 11:22 |
| mrevell | henninge, Unfortunately, I never get the failure mails. All I have is the output in my terminal. I can paste that to you. | 11:23 |
| mrevell | thanks for the patch, looking now. | 11:23 |
| henninge | mrevell: please paste | 11:25 |
| mrevell | henninge, Actually, isn't that what I've already pasted to you? https://pastebin.canonical.com/26742/ | 11:25 |
| henninge | mrevell: well, the actual output of the failure itself would be great but I can generate that myself from your branch. | 11:26 |
| henninge | if you don't have it | 11:26 |
| mrevell | henninge, I'll run the test alone now | 11:26 |
| henninge | good idea | 11:26 |
| henninge | ;_) | 11:26 |
| === matsubara-afk is now known as matsubara | ||
| henninge | mrevell: bin/test -vvct xx-translation-import-queue | 11:36 |
| mrevell | thanks henninge | 11:36 |
| henninge | mrevell: -vv for verbosity, -c for colours, -t for specifying the test. | 11:36 |
| mrevell | henninge, I'm getting a traceback from bin/test -- is this related to the import problems? https://pastebin.canonical.com/26747/ | 11:41 |
| henninge | mrevell: the output has lots of rubbish in it atm. dunno why | 11:41 |
| henninge | that's probably why I never cared about the import violations, either ... ;-) | 11:42 |
| mrevell | henninge, I'm confused. It looks to me as though the test is failing to run, rather than giving me any output I can reasonably use to understand why the test is failing | 11:45 |
| henninge | mrevell: ;-) | 11:48 |
| henninge | I'll try it out. What's your branch again? | 11:49 |
| mrevell | henninge, https://code.edge.launchpad.net/~matthew.revell/launchpad/translations-help-10.1 | 11:50 |
| henninge | mrevell: ok, got it. | 11:50 |
| henninge | ;-) | 11:50 |
| henninge | mrevell: This is what I get http://paste.ubuntu.com/358985/ | 11:57 |
| * mrevell looks | 11:58 | |
| henninge | not to mention that "'Upload either a single file' in ff_owner_browser.contents" is a bad test. | 11:58 |
| mrevell | I don't understand why the test won't run on my machine. It's complaining that there's "No module named testtools". Hmm. Thanks for the test output. I shall fix the test and then put it back through ec2 | 12:00 |
| stub | mrevell: Might be similar to the issue I had per mailing list - sounds familiar. | 12:04 |
| mrevell | thanks stub, i'll take a look at your mail | 12:04 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [adiroiban(bug-340662-take-2)] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | good morning | 12:27 |
| === mrevell is now known as mrevell-lunch | ||
| bigjools | morning bac | 13:30 |
| bigjools | got a branch for you | 13:30 |
| bigjools | will send it in 30m when I've a) eaten b) written a cover letter :) | 13:31 |
| === mrevell-lunch is now known as mrevell | ||
| bac | bigjools: ok | 13:53 |
| === jamalta changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [adiroiban(bug-340662-take-2), jamalta] || This channel is logged: http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | hi EdwinGrubbs | 14:18 |
| EdwinGrubbs | bac: hi | 14:19 |
| bac | jamalta: please ping the on-call reviewer when you have a branch. you'll get noticed faster. | 14:29 |
| jamalta | bac: Oh! Ok :) | 14:32 |
| jamalta | bac: ping ;) ... just kidding | 14:32 |
| jamalta | I actually have two things, of course the MP first | 14:32 |
| jamalta | https://code.edge.launchpad.net/~jamalta/launchpad/destination-ppa-498643/+merge/17628 | 14:32 |
| bac | jamalta: ok | 14:32 |
| jamalta | After that, I need a chat about a bug I started on.. I guess it's more of a late implementation talk | 14:33 |
| jamalta | It's another very trivial issue, I just want to make sure you are okay with the way I'm going to make the change, but more about that later. | 14:33 |
| bac | jamalta: sounds good | 14:34 |
| jamalta | bac: thanks :) | 14:35 |
| bac | beuno: can you have a look at the screenshots for https://code.edge.launchpad.net/~bac/launchpad/bug-499351-batching-dls/+merge/17492 ? | 14:36 |
| beuno | bac, will look in a minute | 14:36 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: adiroiban || queue [adiroiban(bug-340662-take-2), jamalta] || This channel is logged: http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: adiroiban || queue [jamalta] || This channel is logged: http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-lunch | ||
| bac | hi adiroiban | 15:09 |
| adiroiban | bac: hi | 15:09 |
| bac | adiroiban: i just started your review. running the test i notice there is an import violation. will you fix it please by importing IProductSeries from lp.registry.interface.productseries | 15:10 |
| adiroiban | ...looking into this... | 15:12 |
| jamalta | bac: now that you mention it, the test on my branch has an import violation as well, although it's not related to anything i changed... | 15:14 |
| adiroiban | how can I find that import violation? | 15:14 |
| jamalta | i tried asking about it yesterday but no one was around | 15:14 |
| bac | adiroiban: just run your test. it'll show up at the end | 15:14 |
| bac | adiroiban: it is not related to your work but this is a good time to clean it up. we're striving to stomp out import violations. | 15:15 |
| bac | jamalta: what is the import violation message? | 15:15 |
| * jamalta goes run the test again | 15:15 | |
| bac | adiroiban: the problem is simply that in lp.trans.browser.product the import from IProductSeries is from the wrong module | 15:19 |
| bac | s/from/for | 15:19 |
| adiroiban | potemplate-edit looks clean on my side http://paste.ubuntu.com/359058/ | 15:20 |
| adiroiban | running the other tests to see where is the problem | 15:20 |
| bac | adiroiban: have you merged from trunk lately? | 15:22 |
| bac | adiroiban: i just ran your demo. logged in as test@canonical.com and tried changing the 'translation domain' and i get an unauthorized exception. | 15:23 |
| bac | adiroiban: date_last_updated requires launchpad.TranslationsAdmin | 15:24 |
| adiroiban | bac: hm. I will merge the code and look into the problem. we need more tests for this branch | 15:26 |
| bac | adiroiban: agreed. can you reproduce the failure i'm seeing? | 15:27 |
| adiroiban | bac: waiting for LP to start on my computer | 15:28 |
| adiroiban | bac: strange. the potemplate-edit is also testing an update using „test@canonical.com” | 15:28 |
| adiroiban | yep. I got that error | 15:29 |
| adiroiban | I will improve potemplate-edit pagetest | 15:29 |
| bac | thanks adiroiban | 15:30 |
| adiroiban | np | 15:30 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: jamalta || queue [-] || This channel is logged: http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| adiroiban | bac: regarding the import violation. I shall see it after the merge? | 15:30 |
| bac | adiroiban: i suspect so. i got a fresh copy from devel and then merged in your branch. so if you merge in devel we'd be at the same spot. | 15:30 |
| adiroiban | ok | 15:31 |
| jamalta | bac: http://paste.ubuntu.com/359060/ that's the violation i'm receiving | 15:31 |
| bac | adiroiban: sorry you got bit by that import violation... | 15:31 |
| jamalta | don't worry about it for now though, we can cover that when you're ready for me :) | 15:31 |
| adiroiban | bac: np. I'll solve it. | 15:32 |
| bac | jamalta: the second one in that pastes is the same as i'm discussing with adiroiban | 15:32 |
| jamalta | bac: oh ok | 15:32 |
| jamalta | bac: is it safe for me to ignore it, or is it something i need to fix? | 15:33 |
| bac | jamalta: you can ignore it | 15:35 |
| jamalta | bac: ok, thanks :) | 15:35 |
| bac | jamalta: and the other goes away if you merge from devel as someone else has fixed it. | 15:36 |
| jamalta | bac: ok, i'll merge from devel and retest | 15:36 |
| bac | jamalta: on second thought you may want to fix the existing one since you may land before adiroiban does. | 15:37 |
| bac | jamalta: it's a simple one line change | 15:37 |
| jamalta | bac: sure | 15:37 |
| deryck | beuno, ping | 15:45 |
| beuno | deryck, pong | 15:47 |
| beuno | bac, almost looking | 15:47 |
| jamalta | is there a specific rocketfuel script to merge from devel? | 15:48 |
| jamalta | or is bzr merge lp:~launchpad-pqm/launchpad/devel sufficient | 15:48 |
| jamalta | bac: which of the 2 import violations did you want me to fix? | 15:48 |
| bac | jamalta: IProductSeries | 15:49 |
| deryck | beuno, can you do a UI review for me? | 15:49 |
| bac | jamalta: the merge you stated will work. you should be able to just do 'bzr merge' | 15:49 |
| jamalta | bac: oh even easier | 15:49 |
| deryck | beuno, mrjazzcat and I did a branch at the sprint and intellectronica and I are unsure about one part of it. | 15:50 |
| bac | jamalta: as devel should be the parent to your branch, if you used rocketfuel-branch to set it up | 15:50 |
| jamalta | bac: i did, so it should work :) thanks | 15:50 |
| jamalta | bac: also, IProductSeries is referenced once in lp.translations.browser.product | 15:50 |
| bac | jamalta: right, the problem is it is imported from .product instead of .productseries -- that's all | 15:51 |
| jamalta | bac: OH! Ok | 15:51 |
| jamalta | bac: makes sense, lets see if that fixed the test | 15:51 |
| beuno | deryck, sure | 15:52 |
| beuno | URL? | 15:52 |
| jamalta | bac: so the other violation i should ignore, correct? | 15:53 |
| bac | jamalta: the other should not be present after you merge from devel | 15:53 |
| jamalta | bac: oh ok, then i should no see any violations with this test | 15:54 |
| jamalta | sweet! | 15:54 |
| jamalta | uhm,.. this is interesting | 15:54 |
| jamalta | i've never come across this | 15:54 |
| jamalta | so i merged, and there's a ton of changes | 15:54 |
| jamalta | should i just commit and include that i merged in the description? | 15:55 |
| bac | jamalta: yep. you're seeing everything that has changed in devel since you made your branch. | 15:55 |
| deryck | beuno, https://code.edge.launchpad.net/~deryck/launchpad/no-lp-bugs-homepage-439245/+merge/17634 | 15:55 |
| deryck | beuno, screenshots attached. The main question is should we remove the search form when there are no bugs. | 15:56 |
| bac | jamalta: i have a bzr alias for it: bzr alias rfs="commit -m "Merge from trunk"" | 15:56 |
| deryck | beuno, I'm inclined to say yes and did the work. intellectronica thinks maybe this isn't right. | 15:56 |
| jamalta | bac: ah cool | 15:56 |
| beuno | deryck, it | 16:02 |
| beuno | it's a nice improvment | 16:02 |
| beuno | I only hve 2 comments | 16:02 |
| deryck | beuno, thanks | 16:02 |
| bac | jamalta: your MP is approved with one small formatting suggestion. thanks for the branch. | 16:03 |
| beuno | 1) project-not-using-lp-new-ui.png, I'd make it simpler, "Project doesn't use LP... (i) Enable bug tracking" | 16:03 |
| bac | bigjools: is your branch coming up soon? | 16:03 |
| beuno | 2) roject-using-lp-no-bugs-new-ui.png, "There are currently no bugs against $project. _Report a bug_" | 16:03 |
| beuno | deryck, minus those 2, ui=,e | 16:04 |
| beuno | me | 16:04 |
| beuno | :) | 16:04 |
| bigjools | bac: gah, forgot | 16:04 |
| jamalta | bac: wait, i ahven't commited the violation fix! | 16:04 |
| beuno | bac, no screenshots? :) | 16:04 |
| bac | jamalta: i've approved it with the understanding you'll make the requested fixes | 16:04 |
| beuno | ah | 16:04 |
| beuno | bug | 16:04 |
| jamalta | bac: oh! ok, got it :) | 16:04 |
| bac | beuno: 4 screenshots on the bug. | 16:04 |
| * bac wishes you could add screenshots to the MP | 16:04 | |
| jamalta | bac: thanks for catching that.. i don't know how i ended up shifting that code right heh | 16:05 |
| jamalta | i'll fix that as well :) thanks so much | 16:05 |
| deryck | beuno, will do. Thanks. | 16:06 |
| === salgado-lunch is now known as salgado | ||
| sinzui | bac: beuno: I did a UI review of https://code.edge.launchpad.net/~bac/launchpad/bug-499351-batching-dls/+merge/17492 because I am familiar with this problems that the page faces. merge proposals does not allow me to have separate reviews for UI and code. | 16:08 |
| beuno | sinzui, great, I'll just review your review then :) | 16:08 |
| bac | sinzui: thanks. | 16:09 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [-] || This channel is logged: http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jamalta | bac: am i to bug you about pre-implementation talks? | 16:10 |
| bac | jamalta: i can do a pre-imp if you'd like. that's one of the things the OCR is here to do. | 16:11 |
| jamalta | bac: awesome, do i need to add myself to the queue again? | 16:11 |
| bac | jamalta: no | 16:11 |
| jamalta | bac: ok cool, so i'm looking at bug #87058 and #106924 | 16:12 |
| mup | Bug #87058: Instruction 'Yes, define new tag' is misleading <bugtag> <Launchpad Bugs:Triaged by jamalta> <https://launchpad.net/bugs/87058> | 16:12 |
| jamalta | they are both very closely related, and it was suggested that both be fixed together | 16:12 |
| jamalta | i just wanted to know what the best language to use is | 16:12 |
| bigjools | bac: just sent off MP email | 16:12 |
| === matsubara is now known as matsubara-lunch | ||
| sinzui | EdwinGrubbs: I am not sure CHR should have admin on admin_merge_teams. They have access to delete a team (which is a very controlled merge) | 16:19 |
| sinzui | EdwinGrubbs: I think you made this change to update the story, but the problem is in a different story: delete teams. Since the fix in the view code, I expect the test to be of the view; I do not think a story test is right. | 16:21 |
| sinzui | EdwinGrubbs: We are testing the view's contract, operation, and the objects final state. So a unit test or doc test is more appropriate. | 16:23 |
| EdwinGrubbs | sinzui: I'll look into that. | 16:30 |
| sinzui | EdwinGrubbs: I am writing a fuller summary of the test | 16:30 |
| bac | bigjools: it still hasn't arrived on https://code.edge.launchpad.net/launchpad/+activereviews | 16:30 |
| sinzui | EdwinGrubbs: your security change allows any team owner/admin to take control of any other team! | 16:30 |
| deryck | beuno, I requested you as UI reviewer on that MP you just reviewed. Can you click approve for the sake of the MP? | 16:34 |
| beuno | deryck, yes I can | 16:36 |
| beuno | free karma | 16:36 |
| deryck | beuno, thanks | 16:36 |
| deryck | bac, I have a branch for review I would like to add to the queue. | 16:40 |
| bac | deryck: ok | 16:40 |
| deryck | bac, https://code.edge.launchpad.net/~deryck/launchpad/hot-bugs-list-color-icons-439128/+merge/17664 | 16:40 |
| deryck | bac, and thanks! | 16:40 |
| === deryck changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [deryck] || This channel is logged: http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bigjools | bac: I got an email back with an oops! | 16:41 |
| beuno | bac, I think sinzui is right on the mark with the problem | 16:45 |
| bac | beuno: ok | 16:45 |
| beuno | bac, one way of fixing this could be | 16:46 |
| beuno | to isntead of presenting it as a navigation | 16:46 |
| beuno | have an "See older releases >" link | 16:46 |
| sinzui | EdwinGrubbs: I replied to your MP with an outline of the test that reproduces what is happening. I included a real-world example that you can do on edge to get the oops | 16:47 |
| EdwinGrubbs | sinzui: thanks | 16:48 |
| === matsubara-lunch is now known as matsubara | ||
| bigjools | bac: I resent the MP request (was OTP) | 17:08 |
| bigjools | bac: https://code.launchpad.net/~julian-edwards/launchpad/ppa-expire-sources/+merge/17669 | 17:13 |
| jamalta | bac: submitted an MP for the issue we discussed earlier.. whenever you have some time for me again | 17:16 |
| === jamalta changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [deryck, jamalta] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === beuno is now known as beuno-lunch | ||
| === flacoste is now known as flacoste_lunch | ||
| === matsubara is now known as matsubara-dr | ||
| === beuno-lunch is now known as beuno | ||
| === jamalta is now known as jamalta-lunch | ||
| gary_poster | gmb, allenap` are either of you available to review https://code.edge.launchpad.net/~gary/launchpad/fix-db-devel-sourcecode/+merge/17674 quickly? two line change to work around wadl problem for now | 17:56 |
| allenap` | gary_poster: Sure, I'll do it. | 17:57 |
| gary_poster | Tahnks allenap` | 17:57 |
| allenap` | gary_poster: r=me | 18:01 |
| gary_poster | thanks allenap` | 18:01 |
| allenap` | gary_poster: Welcome :) | 18:01 |
| gary_poster | :-) | 18:02 |
| === gary_poster is now known as gary-lunch | ||
| === jamalta-lunch is now known as jamalta | ||
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: deryck || queue [jamalta] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === flacoste_lunch is now known as flacoste | ||
| bac | hi deryck | 18:39 |
| bac | sinzui, beuno: any idea why https://bugs.edge.launchpad.net/launchpad/+bugs doesn't show the bug sprite in webkit? | 18:46 |
| sinzui | bac: yes I know everything | 18:46 |
| bac | sinzui: cool. can you tell deryck how to fix it in his branch? | 18:47 |
| bac | or just tell me and i'll pass it along and look smart | 18:47 |
| sinzui | <span class="sprite bug-high" /> is invalid markup | 18:47 |
| bac | sinzui: ah, span can't self-close? | 18:48 |
| bac | sinzui: \0/ | 18:51 |
| sinzui | firefox likes this this markup, but wbkit nos it is bad | 18:51 |
| bac | sinzui: webkit is a tough cookie | 18:52 |
| sinzui | bac: the bug (me cannot remember its number) is fixable in tales formatter doing <span> </span> | 18:53 |
| bac | sinzui: the one in question is bug 439128, which doesn't use a formatter | 18:54 |
| mup | Bug #439128: "Hot bugs" doesn't show coloured bug icons <story-bug-heat> <ui> <Launchpad Bugs:In Progress by deryck> <https://launchpad.net/bugs/439128> | 18:54 |
| sinzui | bac: that is a duplicate. | 19:02 |
| bac | sinzui: do you have the other bug number? | 19:06 |
| * sinzui is still looking | 19:07 | |
| bac | great | 19:07 |
| bac | sinzui: bug 144101 ? | 19:08 |
| mup | Bug #144101: Bug icons are not correct colour on bugs.lp.net homepage <trivial> <ui> <Launchpad Bugs:In Progress by deryck> <https://launchpad.net/bugs/144101> | 19:08 |
| sinzui | It is a foundations bug about khtml/webkit | 19:08 |
| bac | ah | 19:08 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [jamalta] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: bigjools || queue [jamalta] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| sinzui | bug 393825 and I think it has a dup: bug 452799 | 19:11 |
| mup | Bug #393825: Icons missing from bug listings in WebKit and KHTML <sprite> <ui> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/393825> | 19:11 |
| mup | Bug #452799: no pencil next to title of bug with konqueror <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/452799> | 19:11 |
| === matsubara-dr is now known as matsubara | ||
| === gary-lunch is now known as gary_poster | ||
| sinzui | bac: I did not fix bug 393825 after I had identified the issue a few weeks ago because I expects the fix could break many tests. | 19:27 |
| mup | Bug #393825: Icons missing from bug listings in WebKit and KHTML <sprite> <ui> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/393825> | 19:27 |
| bac | sinzui: ok. i'll mention to deryck to see how brave he is | 19:29 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: jamalta || queue [] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * deryck is back from lunch, but about to see do lightening talks | 19:34 | |
| deryck | bac, will look closely after talks. thanks for the review and comments | 19:34 |
| bac | np deryck. hope you're having a good sprint | 19:34 |
| bac | jamalta: thank you for the nice MP including demo URLs. sure makes reviewing easier | 19:35 |
| sinzui | bac: as for deryck's work not using the tales formatter, He is sort of. | 19:37 |
| sinzui | <span tal:attributes="class context/default_bugtask/image:sprite_css" /> | 19:37 |
| sinzui | should be | 19:37 |
| sinzui | <span tal:replace="structure context/default_bugtask/image:icon" /> | 19:37 |
| sinzui | once the tales formatter is fixed | 19:37 |
| jamalta | bac: np :) glad to know! | 19:37 |
| bac | sinzui: ah, you're right. deryck ^^ | 19:37 |
| sinzui | bac: deryck: by asking for the icon, we get free updates to the markup and css when they change. The extravagant use of applying css directly to elements has caused a lot of bugs...the markup and the css are not independant | 19:39 |
| bac | jamalta: it looks like you missed some tests | 19:40 |
| bac | jamalta: try: bzr ls -VR --kind=file --null | xargs -0 grep -In define\ new\ tag | 19:40 |
| bac | jamalta: also, you can run all of the tests related to bugs by doing: | 19:41 |
| bac | % bin/test -vvm lp.bugs | 19:41 |
| bac | it's pretty handy to make sure you found all of the places in a given app | 19:41 |
| jamalta | bac: oh wow, cool | 19:42 |
| jamalta | makes a lot of sense | 19:42 |
| jamalta | i did miss some places, heh | 19:42 |
| bac | jamalta: do you use emacs? if so, jml has a nice bzr-grep tool | 19:44 |
| jamalta | bac: no, vim | 19:44 |
| jamalta | i saw some of the emacs tools available on the dev wiki | 19:44 |
| jamalta | but i would have to learn to use emacs | 19:44 |
| bac | jamalta: you'll also need to request a UI review from sinzui or beuno due to the wording change. | 19:44 |
| * bac hides from that discussion | 19:44 | |
| jamalta | that doesn't sound good... lol | 19:45 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jamalta | sinzui, beuno let me know when either of you have a chance :) | 19:47 |
| sinzui | jamalta: ui:r=me | 19:51 |
| jamalta | sinzui: need a link to the MP? | 19:52 |
| sinzui | jamalta: I just approved the UI for the MP. you will get the email shortly | 19:53 |
| jamalta | sinzui: oh awesome, thanks! :) | 19:53 |
| beuno | jamalta, sure | 20:00 |
| beuno | show me screenshots! | 20:00 |
| jamalta | beuno: sinzui already approved it, but i can show you | 20:00 |
| * jamalta sits patiently while make run does a ton of stuff | 20:00 | |
| bac | speaking of screenshots, is people.ubuntu.com down/deprecated? | 20:00 |
| beuno | jamalta, if sinzui approveed it | 20:01 |
| beuno | then it's all good | 20:01 |
| jamalta | beuno: ah ok | 20:01 |
| bac | beuno: FTR, you still have to mentor his UI review, right? | 20:02 |
| leonardr | bac, can you take a look at https://code.edge.launchpad.net/~leonardr/lazr.restful/use-bleedthrough-for-methods/+merge/17683 ? | 20:04 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: leonardr || queue [] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | leonardr: on it | 20:04 |
| leonardr | not sure if i explained it well enough, but i'm here | 20:05 |
| jamalta | beuno: http://picasaweb.google.com/lh/photo/yNYcG4o9IpJqET__8gP_cw?feat=directlink | 20:05 |
| bac | leonardr: at line 37 i think you need a comment explaining why you're doing a push(None) | 20:07 |
| deryck | sinzui, bac -- if I'm reading the scrollback right, I should use replace and structure to get the element right, and the icons will appear cross-browser correctly? | 20:07 |
| leonardr | bac: | 20:08 |
| leonardr | # Because we don't know the name of the earliest version | 20:08 |
| leonardr | # published by the web service (we won't know this until | 20:08 |
| leonardr | # runtime), we'll use None as the name of the earliest | 20:08 |
| leonardr | # version. | 20:08 |
| bac | leonardr: +1 | 20:08 |
| bac | deryck: yes, but i think the TALES formatter has to be fixed first | 20:09 |
| deryck | bac, ah, ok. a predicament :-) | 20:09 |
| deryck | bac, and yes, I can fix the related bug you mentioned on the MP. | 20:09 |
| deryck | bac, sinzui -- is there an ETA on fixing the TALES formatter? | 20:09 |
| bac | deryck: the bug i mentioned in the MP (bug 393825) is the one that does fix the TALES formatter... | 20:11 |
| mup | Bug #393825: Icons missing from bug listings in WebKit and KHTML <sprite> <ui> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/393825> | 20:11 |
| deryck | ah, sorry, misunderstood. | 20:11 |
| deryck | bac, let me look closer at it then. | 20:11 |
| deryck | bac, ah, I see now. Sure, we can fix the formatter and then use it correctly in my current branch. | 20:12 |
| bac | deryck: great | 20:12 |
| === salgado is now known as salgado-afk | ||
| deryck | bac, and thanks for the great review catching all this. | 20:14 |
| bac | deryck: i have a vested interest. :) | 20:14 |
| deryck | :-) | 20:15 |
| sinzui | deryck: I know the tales formatter has to be fixed for the UI changes I plan for +packaging and +needs-packaging. But I wont be working on the UI until tomorrow at the earliest | 20:16 |
| bac | leonardr: done | 20:17 |
| === bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jamalta | bac: running all tests in lp.bugs takes forever -.- | 20:22 |
| jamalta | but, provided it finishes successfully, i should be ready :) | 20:22 |
| bac | jamalta: indeed it does. well about 40 minutes i'd guess | 20:22 |
| deryck | bac, what's the bug number for the privacy icon in webkit browsers? | 20:30 |
| deryck | if you know | 20:30 |
| sinzui | I saw that a moment ago | 20:30 |
| sinzui | it is different | 20:30 |
| sinzui | deryck: bug 397457 | 20:31 |
| mup | Bug #397457: Bug privacy edit icon is not visible in WebKit browsers <bug-page> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/397457> | 20:31 |
| deryck | thanks sinzui | 20:31 |
| sinzui | um, how did I do that | 20:31 |
| sinzui | deryck: did my message appear right-to-left in your display? | 20:32 |
| deryck | sinzui, no | 20:32 |
| sinzui | okay, My display is on doap again | 20:33 |
| intellectronica | bac: fancy reviewing a nice little branch from bdmurray and me? | 20:46 |
| deryck | intellectronica, https://code.edge.launchpad.net/~deryck/launchpad/show-package-hot-bugs-455995/+merge/17675 | 21:10 |
| intellectronica | bac: nm, b.t.w, deryck already reviewed our branch | 21:16 |
| EdwinGrubbs | even though they had it before. | 21:16 |
| EdwinGrubbs | sinzui: I was able to recreate the error with delete instead of merge, so I have no problems adding correct tests for that. | 21:17 |
| sinzui | EdwinGrubbs: okay. I am sorry that I did not report how I discovered the bug on edge in the first place | 21:18 |
| EdwinGrubbs | sinzui: that wasn't the problem. I think I accidentally tried deleting a team that the no-priv user owned, so I didn't see the error. | 21:19 |
| sinzui | Yes, it a hard bug to discover. | 21:20 |
| jamalta | bac: awesome, everything works | 21:32 |
| jamalta | let me push up the changed tests.. hold on | 21:32 |
| deryck | bac, I've updated the MP for the branch you reviewed earlier, when time allows for you to re-consider it. | 21:34 |
| EdwinGrubbs | sinzui: so, do you want me to change /people/+adminmergeteam to launchpad.Admin from launchpad.Moderate? | 21:34 |
| === matsubara is now known as matsubara-afk | ||
| sinzui | EdwinGrubbs: No +adminteammerge should remain unchanged | 21:36 |
| EdwinGrubbs | sinzui: then, I think I should keep the change to the story test, since it is more likely to break for the registry experts than for the admins. | 21:38 |
| === jamalta is now known as jamalta-afk | ||
| === jamalta-afk is now known as jamalta | ||
| sinzui | EdwinGrubbs: Yes, keep the test and the permission change on the link. | 21:49 |
| bac | deryck, jamalta: will have a look in a bit | 21:52 |
| bac | thanks for your quick changes | 21:52 |
| jamalta | bac: thanks | 21:55 |
| deryck | bac, thanks | 22:05 |
| sinzui | intellectronica: Hurray you fixed hotness. Now my branch to use hotness will be broken in a few hours | 22:15 |
| intellectronica | sinzui: what do you mean by 'fixed hotness'? | 22:16 |
| sinzui | hotness => heat | 22:16 |
| sinzui | IBug.heat | 22:16 |
| intellectronica | sinzui: you can thank adeuring and kfogel for that | 22:17 |
| sinzui | did the schema change? | 22:18 |
| kfogel | sinzui: you're welcome. I think it's still in PQM, but yes, there's a small schema change. | 22:18 |
| sinzui | bugger, that kills the UI changes for edge this release. | 22:19 |
| kfogel | sinzui: easy search-and-replace, I hope? | 22:20 |
| kfogel | or is it an issue of the freeze coming up? | 22:21 |
| sinzui | no, edge and staging conflict. | 22:21 |
| kfogel | oh | 22:21 |
| * kfogel carefully inserts his head into the sand | 22:21 | |
| sinzui | So the devel's changes will not play on db-devel. | 22:21 |
| sinzui | I need to land a second branch after the failure in db-devel to make the query work with a different schema | 22:22 |
| sinzui | kfogel: I may be able to do some trick where I check the env to determine the correct column name. | 22:22 |
| kfogel | sinzui: I think the question I'm really asking (except that I haven't, until now) is: Is there something unusual/preventable about this situation, or is this just what schema changes tend to do? | 22:23 |
| kfogel | sinzui: wasn't the python name "Bug.heat" already, though? | 22:23 |
| sinzui | kfogel: This is a rare collision where I am adding model code on level 1 where you are changing schema SQL on level 0. | 22:23 |
| sinzui | kfogel: I do not think there is enough crack in the world to tempt me to check the model of bug.heat 20,000 times when sorting a list of every package in Ubuntu | 22:25 |
| kfogel | sinzui: see https://code.edge.launchpad.net/~kfogel/launchpad/509194-506514-bug-heat-db-fixes/+merge/17625 -- the interesting part of the diff is at the end. | 22:25 |
| === abentley1 is now known as abentley | ||
| === jamalta is now known as jamalta-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!