=== jamalta-afk is now known as jamalta
[02:32] <rockstar> anyone around for a few reviews?
[03:06] <jamalta> thanks bac 
[03:06] <bac> jamalta: np.  sorry i didn't get to it earlier.  (had to go to the movie!)
[03:06] <jamalta> bac: heh no worries, i'm sure there is no rush with a trivial bug like that :)
=== bac changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
[03:07] <jamalta> considering the majority of users won't even see that dialog ;)
[03:07] <bac> nope.  good work still.
[03:09] <jamalta> thanks
=== jamalta is now known as jamalta-afk
=== Ursinha is now known as Ursinha-afk
[09:46] <mrevell> Anyone wanna take a look at a small tour text change branch? https://code.edge.launchpad.net/~matthew.revell/launchpad/tour-commercial-tweak-bug-393348/+merge/17666
=== matsubara-afk is now known as matsubara
[14:04] <jamalta-afk> well, looks like some people didn't like my change :( (bug #509791)
[14:04] <mup> Bug #509791: "sources.changes" is not a well-known term <Soyuz:Triaged by julian-edwards> <https://launchpad.net/bugs/509791>
=== jamalta-afk is now known as jamalta
[14:08] <jamalta> i guess i'll just make the change to "changes file" ...
[14:13] <leonardr> gary, want to start the day off with a quick review?
[14:13] <leonardr> https://code.edge.launchpad.net/~leonardr/lazr.restful/multiversion-rename-params/+merge/17741
[14:14] <gary_poster> leonardr sure
[14:24] <jamalta> could someone approve the change to "changes file" instead of "sources.changes" from bug 509791 so i can push this branch really quick?
[14:24] <mup> Bug #509791: "sources.changes" is not a well-known term <Soyuz:Triaged by julian-edwards> <https://launchpad.net/bugs/509791>
=== henninge_ is now known as henninge
=== mrevell-lunch is now known as mrevell
[14:34] <jamalta> bigjools: https://code.edge.launchpad.net/~jamalta/launchpad/changesfile-509791
=== jamalta changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is  logged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
=== jamalta changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [jamalta] || This channel islogged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
=== Ursinha-afk is now known as Ursinha
=== salgado is now known as salgado-afk
=== salgado-afk is now known as salgado-lunch
=== sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [jamalta, sinzui] || This channel islogged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
[14:50] <bigjools> jamalta: looking
[14:51] <jamalta> bigjools: sorry about that, i tried to make sure i used a good term to replace changesfile with :(
[14:52] <bigjools> jamalta: np, easily fixed!
[14:52] <bigjools> approved, thank you, I'll land it shortly
[14:52] <jamalta> bigjools: yeah, specially since i already had a diff with the changes to sources.changes
[14:52] <jamalta> bigjools: thanks! glad to hear this is better :)
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [jamalta, sinzui] || This channel islogged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
[15:09] <gary_poster> leonardr: I'd like to see an example of the typical use of getting a given version of the declarations.  All I see in webservice-declarations is using pop, which doesn't seem likely to be the usual usage.  Is the expectation that you will say special_dict.stack[version_name][name that you want]?
[15:10] <leonardr> gary: no, i'm actually going to be using pop
[15:10] <leonardr> i'm going to create the most recent version, then the version before that, etc
[15:11] <gary_poster> leonardr: oh, huh.  So this is really a very transient data structure
[15:11] <gary_poster> ok
[15:11] <gary_poster> leonardr: the only other comment I've scribbled into the text box so far is that, for the name, VersionedDict makes sense to me, particularly with new approach.  OTOH, BleedThroughDict has the vampire-ish connotations that are so in vogue.
=== jamalta changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [sinzui] || This channelislogged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
[15:11] <leonardr> VersionedDict is good
[15:12] <gary_poster> leonardr: ok cool.  I'll approve, with that suggestion.
[15:21] <rockstar> EdwinGrubbs, do you mind if I chuck some branches in for review (I have 4 of them).
[15:22] <EdwinGrubbs> rockstar: go for it
=== matsubara is now known as matsubara-lunch
[15:28] <rockstar> EdwinGrubbs, https://code.edge.launchpad.net/~rockstar/launchpad/upgrade-job-2.0-changes/+merge/17701
[15:28] <rockstar> https://code.edge.launchpad.net/~rockstar/launchpad/upgrade-ui/+merge/17704
[15:28] <rockstar> https://code.edge.launchpad.net/~rockstar/launchpad/pedantry-round2/+merge/17705
[15:29] <rockstar> https://code.edge.launchpad.net/~rockstar/launchpad/pedantry-round3/+merge/17706
[15:29] <gary_poster> leonardr: approved, with some small comments
[15:36] <leonardr> gary: i may get rid of the class in the future, but who knows--it might get more complicated before this is all over
[15:38] <gary_poster> leonardr: ack, cool
=== Ursinha changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [sinzui, Ursinha] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:39] <henninge> mrevell: can you please revert lib/lp/translations/browser/product.py in your branch? Ursula is fixing that in hers.
[15:40] <mrevell> henninge, My branch won't pass the test suite if I revert it, though, won't it?
[15:41] <henninge> mrevell: no, they are just warning atm.
=== leonardr is now known as leonardr-market
[15:41] <mrevell> ah, okay, thanks henninge
=== salgado-lunch is now known as salgado
[15:43] <henninge> bac: I am not sure now, actually. As sinzui's branch has landed, are import violations still warnings?
[15:43] <sinzui> henninge: There were some that were introduced after I landed my branch
[15:44] <henninge> sinzui: the question is if the test suite will pass if the branch has import violations.
[15:44] <sinzui> yes, that is how we got so many in the first place
[15:45] <sinzui> henninge: there is one import violation in devel:
[15:45] <sinzui> There were 1 imports of names not appearing in the __all__.
[15:45] <sinzui> You should not import IProductSeries from lp.registry.interfaces.product:
[15:45] <sinzui>     lp.translations.browser.product
[15:45] <henninge> sinzui: that's the one we are talking about ... ;-)
[15:45] <EdwinGrubbs> sinzui: do you still need someone to review your needs-linking-bug-507937 branch?
[15:45] <Ursinha> sinzui: I just fixed that, as mrevell 
[15:45] <Ursinha> :)
[15:46] <sinzui> EdwinGrubbs: yes please
[15:46] <henninge> mrevell: didn't I review this branch before?
[15:46] <mrevell> henninge, no, this is a new branch
[15:47] <henninge> mrevell: but it also renames a button from Continue to Close. That looks awfully familiar.
[15:47] <henninge> Did you not land the first branch?
[15:48] <mrevell> henninge, Ah, I see. I merged that first branch into this one as I've had trouble getting it through the test suite, but needed the changes there. I'll land that branch and then ask you to review this new one.
[15:49] <henninge> mrevell: you can add that branch as a pre-requisite when creating the mp for the new one and it will create a correct diff.
[15:49] <mrevell> Ah, just a moment then
=== bigjools is now known as bigjools-otp
=== rockstar changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [sinzui, Ursinha, rockstar, rockstar, rockstar, rockstar] || This channelislogged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
[16:10] <bac> henninge: yeah, they are still warnings
[16:11] <bac> henninge: but that particular one will be fixed in many branches.
[16:16] <henninge> bac: we weren't sure earlier but is that likely to cause merge conflicts
[16:16] <henninge> ẞ
[16:16] <henninge> ?
[16:16] <henninge> ^
[16:17] <bac> henninge: probably
[16:20] <henninge> so that's why I asked Matt to back it out.
[16:20] <henninge> bac: do you know of a branch that has the fix that is about to land?
[16:21] <bac> henninge: i don't.  it's complicated to try to shepherd through.  perhaps it would be best just to do a simple rs branch to fix it
[16:22] <henninge> bac, I guess that's true. rs=bac?
[16:22] <bac> henninge: sure
[16:22] <bac> it's a two line fix...
[16:24] <henninge> I know ...
=== bigjools-otp is now known as bigjools
[16:28] <henninge> mrevell: so you only show the popup on the dashboard? What about the +translate page?
[16:29] <mrevell> henninge, I'm not sure there's a suitable place for it on the +translate page. What do you think?
[16:30] <henninge> mrevell: have you seen the balloon?
[16:31] <henninge> mrevell: I wonder if we could just put another (not dismissiable) one on top of that "Translating for the first time? Read the tips for new translators."
[16:31] <henninge> for no-karma people.
[16:31] <mrevell> henninge, that'd be ideal. I still don't see the balloon -- where is it on this page, for example? https://translations.edge.launchpad.net/ubuntu/karmic/+source/gfxboot-theme-ubuntu/+pots/bootloader/en_GB/+translate
=== matsubara-lunch is now known as matsubara
[16:35] <henninge> mrevell: the en_GB team doesn't have any instructions, either.
[16:36] <henninge> mrevell: see the German version:
[16:36] <henninge> https://translations.edge.launchpad.net/ubuntu/karmic/+source/gfxboot-theme-ubuntu/+pots/bootloader/de/+translate
[16:36] <mrevell> heh, ok
[16:36]  * mrevell looks
[16:37] <mrevell> Ah, yes, that'd be perfect henninge
[16:38] <henninge> mrevell: only I'd not make it dismissible because that requires Javascript.
[16:38] <henninge> mrevell: It is dismissed when people start translating.
[16:38] <mrevell> Sounds good
[16:39] <henninge> cool
[16:39] <henninge> mrevell: BUT
[16:39] <henninge> we do need an UI review for this ...
[16:39] <mrevell> henninge, right
[16:39] <henninge> two stacked balloons, maybe martin does not like that.
[16:40] <henninge> mrevell: I think both ui reviewers (I know of) are unavailable today.
[16:40] <henninge> but there are a few ui* reviewers on the schedule.
=== Ursinha is now known as Ursinha-nom
[17:10] <intellectronica> EdwinGrubbs: busy review shift, eh?
[17:11] <EdwinGrubbs> intellectronica: it seems like it
[17:11] <intellectronica> EdwinGrubbs: i wanted to ask for another review, but i'll try to see if someone else can do it
[17:16] <intellectronica> deryck: https://code.edge.launchpad.net/~intellectronica/launchpad/patch-in-mailnotification/+merge/17761
[17:17] <EdwinGrubbs> sinzui: is the hotness being updated by triggers yet?
[17:18] <sinzui> I do not know. I do not think that is a issue in my branch
=== leonardr-market is now known as leonardr
[17:39] <bac> sinzui: i've been reviewing your comments on https://code.edge.launchpad.net/~bac/launchpad/bug-499351-batching-dls/+merge/17492 together with beuno's.  i think i need to have a call after lunch to figure it out.
=== adiroiban changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [sinzui, Ursinha, rockstar, rockstar, rockstar, rockstar,adiroiban(bug-359180-take-2)] || This channelislogged:http://irclogs.ubuntu.com||https://code.edge.launchpad.net/launchpad/+activereviews
=== adiroiban changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [sinzui, Ursinha, rockstar, rockstar, rockstar, rockstar,adiroiban(bug-359180-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:47] <sinzui> bac: okay
[17:51] <rockstar> EdwinGrubbs, does the topic reflect your review progress?
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: sinzui || queue [Ursinha, rockstar, rockstar, rockstar, rockstar,adiroiban(bug-359180-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:51] <EdwinGrubbs> rockstar: now it does
[17:52] <rockstar> EdwinGrubbs, okay, thanks.
[18:08] <EdwinGrubbs> Ursinha-nom: do you need someone to review lp:~ursinha/launchpad/bug422056-add-translation-focus?
[18:09] <Ursinha-nom> EdwinGrubbs: yes, please
=== Ursinha-nom is now known as Ursinha
[18:10] <EdwinGrubbs> rockstar: fyi, your upgrade-ui branch shows zero diff lines on the +activereviews page.
[18:10] <rockstar> EdwinGrubbs, yes, this is why I put the real diff in the comment.
[18:11] <rockstar> EdwinGrubbs, and if you didn't see the comment in the prereq branch, you've already reviewed all the code in the upgrade-ui branch.
[18:11] <rockstar> EdwinGrubbs, it might be some artifact of the pipeline.  I'm not sure.
[18:29] <rockstar> EdwinGrubbs, howgoesit?
[18:29] <EdwinGrubbs> rockstar: I'm working on Ursinha's branch.
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: Ursinha || queue [rockstar, rockstar, rockstar, rockstar,adiroiban(bug-359180-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[18:30] <rockstar> EdwinGrubbs, ah, okay.
[18:30] <rockstar> EdwinGrubbs, I'll probably be heading to eat something in 30 minutes, so you may want to do the pedantry branches first (they're small).
[18:31] <EdwinGrubbs> rockstar: I'll be getting something to eat soon, too.
[18:31] <rockstar> EdwinGrubbs, great, that works out well then.
[18:32] <rockstar> I also have another branch that I'll probably need to cut in front of adiroiban with, if that's okay.
[18:32] <adiroiban> no hurry from my side :)
[18:35] <rockstar> adiroiban, great, because I kinda do have a hurry on my side.
[18:35] <adiroiban> go, go, go
=== rockstar changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: Ursinha || queue [rockstar, rockstar, rockstar, rockstar, rockstar, adiroiban(bug-359180-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[18:54] <bac> jamalta: ping
[18:55] <jamalta> bac: hey there
[18:55] <jamalta> or rather
[18:55] <jamalta> pong :)
[18:55] <bac> hi jamalta have you arranged for anyone to land your changes from yesterday?
[18:55]  * jamalta tries to remember which changes from yesterday bac is referring to
[18:55] <jamalta> bigjools said he would land my changes from today
[18:56] <bac> jamalta: the two merge proposals i reviewed for you
[18:56] <jamalta> as for yesterday, let me have a look
[18:56] <jamalta> bac: oh
[18:56] <jamalta> no, i didn't know i was supposed to find someone to land them
[18:56] <bac> jamalta: ah, ok.  yeah it doesn't happy automatically
[18:56] <bac> jamalta: i'll be glad to do it.
[18:56] <jamalta> bac: well i know that! what i meant is that usually whoever approved them took care of landing them
[18:56] <bac> jamalta: it's best if you can remember to either ask the reviewer or someone else
[18:56] <jamalta> bac: thanks! that would be great
[18:57] <jamalta> bac: right, well next time i'll make sure to ask :) thanks
[18:57] <bac> jamalta: i should've asked.
[18:57] <bac> if we both try to remember perhaps one will
[18:57] <jamalta> bac: haha, sounds like a deal
[19:00] <jamalta> well thanks for pointing that out
[19:00] <jamalta> i really appreciate it
[19:00] <EdwinGrubbs> Ursinha: what information do I need to add to make a series translatable?
[19:01] <Ursinha> EdwinGrubbs: you need to add a template so you have what to translate on it
[19:01] <Ursinha> EdwinGrubbs: to be really honest I've tested that by adding it in the tests, with factories
[19:05] <bac> jamalta: can you go to the MPs and set the commit message.  it is the text used when we send it to PQM
[19:05] <bac> https://code.edge.launchpad.net/~jamalta/launchpad/newtag-statement-redundancy/+merge/17670
[19:05] <jamalta> bac: sure thing
[19:05] <jamalta> sorry, forgot to do it for those
[19:07] <jamalta> bac: ok it's changed
[19:07] <bac> thx
[19:11] <Ursinha> danilos: are you there?
[19:11] <Ursinha> or henninge :)
[19:11] <Ursinha> henninge: which scripts need to be run for the imports to be approved in my local instance?
[19:13] <henninge> Ursinha: AFAIK you need to make run_all
[19:13] <henninge> Ursinha: and then
[19:13] <henninge> Ursinha: uploads or bzr imports?
[19:13] <Ursinha> henninge: uploads
[19:14] <EdwinGrubbs> Ursinha: since this came up in the reviewer meeting, I'll ask, did you have a pre-impl call with someone on the translations team.
[19:15] <Ursinha> EdwinGrubbs: yes
[19:16] <henninge> Ursinha: you can approve manually from the queue, unless you wish to try out the gardener
[19:16] <Ursinha> henninge: admin user isn't a rosetta admin?
[19:17] <henninge> Ursinha: and then "cronscripts/rosetta-poimport.py"
[19:17] <Ursinha> henninge: because the Approve option is grayed
[19:17] <henninge> Ursinha: you need to set an import target first.
[19:18] <henninge> Ursinha: edit the entry
[19:19] <henninge> Ursinha: if it's a new template, make up a domain and template name
[19:19] <Ursinha> henninge: now everything makes sense :)
[19:34] <Ursinha> henninge: what must happen for the imports to leave the queue?
[19:35] <Ursinha> henninge: I see they were imported here, and approved, and still on the list
[19:35] <henninge> Ursinha: the gardener will clear them out after a few days.
[19:35] <henninge> Ursinha: same for "Deleted" entries.
[19:35] <Ursinha> henninge: I see
[19:36] <henninge> Ursinha: you do know what the gardener is?
[19:36] <Ursinha> henninge: I presume it's a script that cleans things
[19:37] <henninge> Ursinha: it used to called the "auto approver", it approves and cleans, yes.
[19:37] <henninge> That's why jtv renamed it.
[19:38] <Ursinha> henninge: I see
[19:41] <Ursinha> thanks for the explanation
[19:41] <gary_poster> flacoste or gmb: review https://code.edge.launchpad.net/~gary/launchpad/bzr-builder-symlink/+merge/17774 for testfix?
[19:42] <flacoste> gary_poster: r=me
[19:42] <gary_poster> flacoste: thanks
[19:45] <Ursinha> henninge: merging caused no conflicts :)
[19:45] <henninge> Ursinha: See how smart Bazaar is? ;-)
[19:45] <Ursinha> henninge: hehehe :)
[19:52] <bac> jamalta: your branches have been sent off to ec2.  they will certainly fail when submitted to PQM due to buildbot being in testfix but i'll land them later.
[19:54] <flacoste> bac: testfix mode should be off
[19:54] <flacoste> i just reviewed gary's fix
[19:55] <bac> flacoste: so it'll be a foot race
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: rockstar || queue [rockstar, rockstar, rockstar, rockstar, adiroiban(bug-359180-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[19:55] <bac> flacoste: and, sadly, i have a head start
[19:55] <flacoste> bac: i think gary will submit his branch directly to PQM
[19:55] <flacoste> so it should land before yours EC2 tests complete
[19:55] <gary_poster> flacoste, bac, yes
[19:56] <gary_poster> bac, it is in PQM now
[19:56] <bac> flacoste: ah, right, so we go out of testfix as soon as buildbot starts working on it, not finishing?
[19:56] <flacoste> bac: yes
[19:57] <bac> excellent
[19:57] <flacoste> bac: as soon as PQM sees a testfix revision, it considers that the tree is clean
[19:57] <flacoste> optimist algorithm
[19:57] <gary_poster> from flacoste, the optimist :-)
[20:02] <jamalta> bac: ah ok
[20:02] <jamalta> thanks for everything :)
[20:10] <bac> jamalta: np.  you did all the hard work.
=== salgado is now known as salgado-afk
[20:12] <jamalta> bac: well, i really appreciate the help and insight :)
[20:13] <jamalta> it's really helping me learn launchpad
=== mwhudson_ is now known as mwhudson
[20:24] <bac> adiroiban: thanks for the fix.  i've approved the MP with a two-line change
[20:25] <adiroiban> bac: ok. will you send the branch for testing ? or should I run the full tests?
[20:25] <bac> adiroiban: i will land it for you
[20:25] <bac> adiroiban: just let me know when it is finalized
[20:25] <adiroiban> bac: finalized?
[20:26] <bac> adiroiban: also, i note some of the changes you made introduced trailing whitespace.  if you can remove those it'd be great.
[20:26] <bac> adiroiban: yes, i make one  final code change suggestion
[20:26] <bac> adiroiban: sorry if i'm being unclear
[20:26] <adiroiban> bac: ah. got the email :)
[20:26] <bac> ok
[20:26] <adiroiban> a bit of delay
[20:26] <adiroiban> ok
=== matsubara is now known as matsubara-afk
[20:37] <adiroiban> bac: done. I was thinking that „make lint” can catch such errors
[20:39] <bac> adiroiban: so you have pushed your changes and want me to land it as is?
[20:39] <adiroiban> bac: what are the outstanding problems?
[20:40] <bac> adiroiban: none.  i just got your diff and it looks good
[20:40] <bac> adiroiban: so i will land it as is.  thanks.
[20:41] <adiroiban> thanks for your help and guidance! much appreciated
[20:54] <rockstar> EdwinGrubbs, hi.  Do you have any questions so far?
[20:54] <EdwinGrubbs> rockstar: not yet. sorry I've been slow starting on it.
[20:55] <rockstar> EdwinGrubbs, that's okay, as long as you can get to the branch upgrade ones today.  The pedantry branches can probably get done tomorrow.
[20:57] <EdwinGrubbs> rockstar: so, is BZR_BRANCH_8 the same as 2a?
[20:58] <rockstar> EdwinGrubbs, no, BZR_BRANCH_8 is a branch format.  2a is a repository format.
[20:58] <rockstar> EdwinGrubbs, in a follow up branch, I add BZR_BRANCH_7 to the non-upgradables as well, since BZR_BRANCH_8 is still considered a development format.
[21:02] <rockstar> EdwinGrubbs, also, all these branches will probably land in one final branch together (hopefully today)
[21:14] <EdwinGrubbs> rockstar: I see where BranchUpgradeJob.create() checks upgrade_pending, but I don't see where that attribute is set. Is that in another branch?
[21:15] <rockstar> EdwinGrubbs, which branch are you looking at?
[21:15] <EdwinGrubbs> rockstar: upgrade-job-2.0-changes
[21:16] <rockstar> EdwinGrubbs, it's a property defined in the model code.
[21:22] <EdwinGrubbs> rockstar: Shouldn't lp/code/configure.zcml specify that requestUpgrade() requires launchpad.Edit instead of launchpad.View?
[21:22] <rockstar> EdwinGrubbs, yes, you are right.
[21:23] <rockstar> EdwinGrubbs, also, I'd like to expose that through the API eventually, but exposing jobs in the API right now is a little awkward.
[21:25] <leonardr> gary: given edwin's queue, would you like to review another of my branches?
[21:25] <leonardr> do you have time today?
[21:26] <gary_poster> leonardr: I'll give it a whirl, sure
[21:27] <EdwinGrubbs> rockstar: review sent
[21:28] <rockstar> EdwinGrubbs, cheers! One down, five to go.
[21:28] <rockstar> EdwinGrubbs, I can take adiroiban's review if you'd like.
[21:28] <EdwinGrubbs> rockstar: you make it sound like a drinking game.
[21:28] <EdwinGrubbs> rockstar: I would appreciate it if you take his mp
[21:28] <rockstar> EdwinGrubbs, only when it's Soyuz branches.
[21:31] <rockstar> adiroiban, ping
[21:31] <adiroiban> rockstar: hi
[21:31] <rockstar> adiroiban, why the change to lib/lp/registry/browser/peoplemerge.py
[21:32] <rockstar> Or rather, any of the people-merge stuff.
[21:32] <adiroiban> I messed up something 
[21:32] <rockstar> adiroiban, actually, most of this branch looks unrelated to the bug you reference.
[21:34] <adiroiban> hm...somethings get messed durring the devel merge
[21:36] <rockstar> adiroiban, you submitted the merge against db-devel
[21:37] <adiroiban> ah...
[21:37] <adiroiban> true
[21:37] <adiroiban> can I change the MP?
[21:37] <adiroiban> or should I create a new one for lp-devel?
[21:38] <leonardr> gary: https://code.edge.launchpad.net/~leonardr/lazr.restful/operation-removed-in/+merge/17784
[21:38] <gary_poster> leonardr: ack, looking
[21:39] <adiroiban> rockstar: sorry, here is the MP https://code.edge.launchpad.net/~adiroiban/launchpad/bug-359180-take-2/+merge/17785
[21:39] <rockstar> adiroiban, could you please delete the old one then?
[21:39] <gary_poster> leonardr: typo versuibed
[21:39] <adiroiban> done
[21:40] <leonardr> gary: i fixed that but haven't pushed yet
[21:40] <gary_poster> leonardr: cool
[21:40] <adiroiban> the new diff looks ok
[21:40] <rockstar> adiroiban, yes, this looks much better.
[21:40] <rockstar> adiroiban, I'm assuming you talked to someone in translations about this?
[21:41] <adiroiban> rockstar: yes. the big discussion is on the but comments
[21:41] <adiroiban> and this is also the second part of the change
[21:42] <rockstar> adiroiban, line 104 of the patch needs force returns in it.  It is too long.
[21:43] <gary_poster> leonardr: in @call_with(fixed=...), I am not familiar with that kwarg feature.  That means that, when the webservice calls the method, it includes the value as a kwarg (and does not allow a webservice caller to override it)?
[21:43] <adiroiban> rockstar: yes. I don't know why make lint did not catch that error. I'm fixing my MP script to catch such errors
[21:43] <rockstar> adiroiban, it's a pagetest, and lint doesn't look at non-python files for lint.
[21:44] <leonardr> gary: yes, that argument does not show up as part of the named operation's signature
[21:44] <gary_poster> leonardr: got it, thanks
[21:49] <gary_poster> leonardr: approved
[21:50] <leonardr> gary, great
[21:51] <jamalta> i have to admit, that's one rockstar queue
[21:52] <rockstar> jamalta, it's the best kind.
[21:52] <jamalta> rockstar: ;)
[22:02] <EdwinGrubbs> rockstar: it took me a while to find the upgrade link, since I expected it in the action menu for the branch as opposed to thinking about it as editing an attribute. Can you create a screenshot of that and ask beuno about the placement?
[22:02] <rockstar> EdwinGrubbs, well, this isn't the final UI.  I have one more branch that does all the polish, etc. but I need some graphics.
[22:03] <rockstar> EdwinGrubbs, I think the link needs to be much more prominent in these cases, since we REALLY want people to upgrade.  It's possible, however, that we'll be backing out the UI for this before next week's rollout.
[22:03] <EdwinGrubbs> rockstar: yeah, it also seems you would want to encourage users to press the upgrade button but also warn them about what they are about to do on the form.
[22:04] <rockstar> EdwinGrubbs, basically, I want a big button, but big buttons are a no-no now, apparently.  I'm not sure how it's going to happen, but I'm going to leave that until we know the rest of the feature is okay.
[22:05] <rockstar> The plan is to spend today and tomorrow QAing.  If the actual process is good, then the new UI will land as soon as PQM opens back up.
[22:05] <rockstar> (merely because UI work is not release critical)
=== mwhudson_ is now known as mwhudson
[22:24] <bac> adiroiban: could you set the commit message on https://code.edge.launchpad.net/~adiroiban/launchpad/bug-340662-take-2/+merge/17598
[22:28] <adiroiban> bac: done
[22:28] <bac> adiroiban: thanks
[22:29] <gary_poster> flacoste: are you available for a pretty quick review of the hack fix for bug 491705, https://code.edge.launchpad.net/~gary/launchpad/bug-491705-hack/+merge/17788 ?
[22:29] <mup> Bug #491705: AttributeError: 'NoneType' object has no attribute 'utf_8_decode' <Launchpad Foundations:In Progress by gary> <https://launchpad.net/bugs/491705>
[22:29] <flacoste> gary_poster: was actually looking at it right now :-)
[22:29] <gary_poster> flacoste: :-) thanks
[22:30] <adiroiban> bac: was the import warning solved on devel?
[22:30] <adiroiban> for IProduct
[22:30] <bac> yes
[22:31] <adiroiban> ok
[22:32] <adiroiban> there is one more thing regarding translations tests.
[22:32] <adiroiban> it looks like they are launched twice
[22:32] <adiroiban> Tests with failures: lib/lp/translations/browser/tests/pofile-views.txt lib/lp/translations/tests/../browser/tests/pofile-views.txt
[22:37] <bac> adiroiban: odd, i haven't seen that before
[22:37] <bac> adiroiban: are those tests failing now?
[22:37] <EdwinGrubbs> rockstar: when registering a new branch, I only see Hosted, Mirrored, and Remote branch types. How does an Imported branch get added?
[22:37] <rockstar> EdwinGrubbs, there's a different flow for import branches.  It's on a link that says "Import a branch"
[22:38] <rockstar> EdwinGrubbs, gnome-terminal/imported is a sample import branch.
[22:40] <EdwinGrubbs> rockstar: is there any reason that a branch such as ~vcs-imports/evolution/main, which has an Imported branch type, but hasn't been imported yet, should not show that link?
[22:40] <rockstar> No, I don't think so.
[22:40] <rockstar> EdwinGrubbs, unless you don't have permission to see the link.
[22:41] <rockstar> EdwinGrubbs, your best bet is to log in as mark.
[22:42] <adiroiban> rockstar: I've fixed all long lines from that file.
[22:42] <rockstar> adiroiban, great, thanks.
[22:42] <adiroiban> bac: ah.. the test are not failing. Is just they are run twice
[22:43] <adiroiban> bac: for testing, I changed a test so that it will fail... and I can see the test is run twice
[22:45] <bac> adiroiban: that's interesting but unrelated to your branch.  perhaps you could open a bug
[22:46] <EdwinGrubbs> rockstar: it's apparently caused by the <tal:has-codeimport condition="branch/code_import"> conditional in branch-import-details.pt. Do you think it would be ok to move it outside that condition?
[22:47] <rockstar> EdwinGrubbs, I don't think.  An import branch shouldn't ever exist without a code_import as well.
[22:47] <rockstar> I just fixed a bug pertaining to that.
[22:47] <rockstar> EdwinGrubbs, so in this case, the sample data sucks.
=== mwhudson_ is now known as mwhudson
[22:47] <EdwinGrubbs> rockstar: ok, sounds good. r=me
[22:47] <rockstar> EdwinGrubbs, great, thanks.
[22:48] <EdwinGrubbs> rockstar: do you want me to review pedantry3 or jam-suggested-changes next?
[22:48] <rockstar> EdwinGrubbs, probably the one from jam next, please.
[22:54] <adiroiban> bac: bug filled
[22:55] <adiroiban> rockstar: do I need to set the commit message for this branch ?
[22:55] <bac> adiroiban: great.  your branch is off at ec2 running.  i'll bounce you the email when it comes back.
[22:55] <rockstar> adiroiban, do you need your that branch landed?
=== flacoste is now known as flacoste_afk
[22:55] <adiroiban> rockstar: what do you mean? :)
[22:56] <adiroiban> should I found someone else to land it?
[22:56] <rockstar> adiroiban, my answer to your question is in direct relation to the answer to my question.  If you want it landed, then yes, please set the commit message.
[22:59] <adiroiban> rockstar: :) done :)
[23:12] <EdwinGrubbs> rockstar: I sent the review. I will be afk for a little bit, but I'll be able to look at your reply and the last branch today.
=== EdwinGrubbs is now known as Edwin-afk
[23:48] <EdwinGrubbs> rockstar: I'm back
[23:53] <rockstar> EdwinGrubbs, looking at your comments now.
[23:55] <EdwinGrubbs> rockstar: btw, I just sent the other review.
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: - || reviewing: rockstar || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews