=== abentley1 is now known as abentley
[00:48] <rockstar> EdwinGrubbs, just fixed the lint and test issue, pushing now.
=== rockstar changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[01:31] <EdwinGrubbs> rockstar: I'm getting AttributeError: type object 'RepositoryFormat' has no attribute 'BZR_BZR_CHK_2A'
[01:31] <rockstar> EdwinGrubbs, where are you getting that?
[01:31] <EdwinGrubbs> rockstar: when running test_needsUpgrading_repository_format_upgrade_not_needed (lp.code.model.tests.test_branch.TestBranch)
[01:32] <rockstar> EdwinGrubbs, huh.  That's odd.
[01:32] <EdwinGrubbs> rockstar: here is the command I used: ./bin/test -vv -m lp.code.model.tests.test_branch -t test_needsUpgrading_repository_format_upgrade_not_needed
[01:44] <rockstar> EdwinGrubbs, test fixed.  I have some other tests that need to be fixed as well.  Nothing major though.
=== jamalta is now known as jamalta-afk
[02:01] <EdwinGrubbs> rockstar: did you get the error when you ran the test?
[02:02] <rockstar> EdwinGrubbs, yeah, I must have had an editor hiccup.
=== jamalta-afk is now known as jamalta
=== jamalta is now known as jamalta-afk
[02:08] <rockstar> EdwinGrubbs, test changes pushed.
[02:21] <EdwinGrubbs> rockstar: sent you some more lint errors. r=me
[02:21] <rockstar> EdwinGrubbs, cheers.
=== abentley1 is now known as abentley
[10:07] <mrevell> Hey, anyone care to review a small text change branch? https://code.edge.launchpad.net/~matthew.revell/launchpad/tour-commercial-tweak-bug-393348/+merge/17808
[12:10] <henninge> sinzui: ping
[12:12] <henninge> BjornT: are post-3-ui-cleanups (still) rs'able?
=== abentley1 is now known as abentley
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
[14:28] <bac> hi jamalta-afk
[14:40] <mrevell> Hey, anyone care to review a small text change branch? https://code.edge.launchpad.net/~matthew.revell/launchpad/tour-commercial-tweak-bug-393348/+merge/17808
[14:44] <bac> mrevell: sure
[14:44] <mrevell> thanks bac!
[14:45] <bac> mrevell: maybe strike 'new' at line 9
[14:46] <mrevell> yeah, good idea bac
[14:47] <bac> mrevell: other than that it's a-ok
[14:48] <mrevell> bac, You happy if I use "beta" in place of "new" in line 9?
[14:48] <bac> mrevell: 'beta' is causing confusion
[14:48] <mrevell> Is it?
[14:48] <mrevell> Okay, I'll just scrub new and leave it at that.
[14:49] <bac> i get email from people saying they don't want to trust their code to a 'beta-level' code hosting service
[14:49] <mrevell> oh really? Crumbs
[14:49] <mrevell> there's another mention of "beta" in that page, so maybe I should scrub that too.
[14:49] <bac> yeah, then i lamely explain the 'beta' refers to our business model not the application
[14:50] <mrevell> Ah, I see.
[14:50] <bac> did VAT go up or were we just wrong?
[14:51] <bac> hi gary_poster, got a sec?
[14:51] <gary_poster> hi bac, yes
=== salgado is now known as salgado-lunch
[14:51] <gary_poster> (though have call soon)
[14:56] <mrevell> hey bac, could you please look at the newly updated diff, when you have a moment? I've removed the other mention of "beta" on that page. https://code.edge.launchpad.net/~matthew.revell/launchpad/tour-commercial-tweak-bug-393348/+merge/17808
[15:06] <jamalta> bac: hey there
[15:06] <jamalta> bac: saw your email, i'll fix the issue in a few
[15:06] <bac> ok
=== bigjools-afk is now known as bigjools
=== rockstar changed the topic of #launchpad-reviews to: on-call: rockstar open for bizniss || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado-lunch is now known as salgado
[16:04] <jamalta> bac: i pushed the fix to that tset
[16:04] <jamalta> test*
[16:04] <bac> jamalta: ok
[16:11] <jtv> rockstar: I have to leave now, but if you feel like reviewing a buildfarm-related branch...
[16:14] <rockstar> jtv, shoot it on over.
[16:14]  * jtv aims
[16:14] <jtv> https://code.edge.launchpad.net/~jtv/launchpad/bug-499405-translationtemplates-buildmanager/+merge/17811
[16:17] <jtv> rockstar: thanks
[16:36] <deryck> intellectronica, https://code.edge.launchpad.net/~deryck/launchpad/hot-bugtasks-to-hot-bugs-442170/+merge/17826
=== beuno is now known as beuno-lunch
[16:53] <intellectronica> deryck: https://code.edge.launchpad.net/~intellectronica/launchpad/search-for-bugs-affecting-me/+merge/17827 (if you're still up for another review)
[16:56] <deryck> intellectronica, sure
[17:10] <intellectronica> deryck: http://pastebin.ubuntu.com/360156/
=== beuno-lunch is now known as beuno
[18:28] <gmb> rockstar: allenap and I have a branch for review but we're about to head to lunch. Do you want to take it now and do an offline review or would you rather wait until we return?
[18:28] <rockstar> gmb, your choice.
[18:28] <rockstar> gmb, if it's a baby punching patch, you may want to walk away now.
[18:29] <gmb> rockstar: If you could start looking at it now that would be wonderful.
[18:29] <gmb> rockstar: Not quite baby-punching. Jobs system.
[18:29] <gmb> Using thereof.
[18:29] <rockstar> gmb, cool, I know that.
[18:29] <gmb> Rawk.
[18:29] <rockstar> gmb, url?
[18:29] <gmb> rockstar: https://code.edge.launchpad.net/~gmb/launchpad/jobbifiy-bug-heat-calculations-509193/+merge/17831
[18:29] <gmb> rockstar: We'll catch up when we've nommed, then. thanks!
=== EdwinGrubbs is now known as Edwin-lunch
[19:28]  * rockstar lunches
=== salgado is now known as salgado-afk
[20:46] <gmb> rockstar: Thanks for the review; response sent.
=== mwhudson_ is now known as mwhudson
[21:05] <rockstar> gmb, r=me
[21:05] <gmb> rockstar: Awesome, thanks!
=== EdwinGrubbs is now known as EdwinGrubbs21
=== EdwinGrubbs21 is now known as EdwinGrubbs2
=== EdwinGrubbs2 is now known as EdwinGrubbs
=== rockstar changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews