=== robbiew is now known as robbiew-afk === robbiew-afk is now known as robbiew_ [00:21] argh, forgot that xkb-data-i18n hadn't been promoted yet [00:28] ev: *clicketyclick* fixed for the next publisher run [05:52] ubiquity: superm1 * r3696 ubiquity/ (scripts/install.py ubiquity/frontend/gtk_ui.py): whitespace cleanup [07:38] ubiquity: superm1 * r3697 ubiquity/ (debian/changelog scripts/install.py): Remove another reference to a long dead xserver-xorg debconf question. [07:40] ubiquity: superm1 * r3698 ubiquity/ (debian/changelog scripts/install.py): Don't try reconfiguring LRM, it's been superceded by DKMS based packages. [08:49] ubiquity: evand * r3699 ubiquity/ (10 files in 6 dirs): Provide an option to determine the keymap from a decision tree. [09:03] ubiquity: evand * r3700 ubiquity/ (5 files in 3 dirs): [09:03] ubiquity: * Add missing parameter to exception in bin/ubiquity. [09:03] ubiquity: * slideshow_get_available_locale is an instance method. [09:11] note to self, run pychecker before upload [09:11] ugh [09:28] ubiquity: evand * r3701 ubiquity/scripts/install.py: [pychecker] Remove unused exception parameter. [14:17] cjwatson: have you run into issues with bogl-bterm and kvm? It throws a GPF for me in karmic and lucid. [14:17] haven't noticed it being *that* bad [14:18] terminfo seems a bit misconfigured in d-i rescue mode, it's doing something wrong with backspace, but that could be the shell's fault [14:19] weird [14:21] by the way, there's a bug in debconf_ui, introduced by r3665. self.db will always exist. I think the solution is to get rid of the check in debconf_ui.debconf_communicator, but you might want to double check that, just to make sure I'm not railroading over a case that you had considered and I had not. [14:24] hmm, I'd missed that [14:24] I'm not sure removing the check is right though [14:25] ignore that. you're quite right, ditch the check [14:25] you mean the hasattr bit? [14:25] yes [14:26] hmm [14:26] I think maybe we need to save the persistent d-c somewhere else [14:27] what about hasattr(self, 'db') and self.db is not None? [14:28] the intended behaviour is: [14:28] * if DEBIAN_HAS_FRONTEND, only ever instantiate self.db once, and on subsequent debconf_communicator calls just return the previous one [14:28] * otherwise, as normal [14:29] WDYT about http://paste.ubuntu.com/360085/ ? [14:31] or indeed the hasattr check might just be irrelevant since debconf_communicator should only ever be called if self.db is None, but I suppose it's a safety check [14:32] it will never hit, as BaseFrontend gets instantiated first [14:32] which sets self.db = None [14:35] ev: ah; then my patch combined with yours [14:35] or indeed just 'if self.db is not None' [14:36] http://paste.ubuntu.com/360089/ [14:36] ah, good call [14:39] ubiquity: evand * r3702 ubiquity/ (debian/changelog ubiquity/frontend/debconf_ui.py): [14:39] ubiquity: The frontend always has a db attribute, per r3665, so revise the check in [14:39] ubiquity: debconf_communicator. Thanks Colin Watson. [16:23] ubiquity: evand * r3703 ubiquity/ (debian/changelog ubiquity/components/install.py): Add missing function argument to Install's prepare. [16:26] ev, would you mind glancing over https://edge.launchpad.net/~superm1/ubiquity/mythbuntu-plugin-enhance r 3687, 3689 and 3690 to make sure those aren't doing anything to crackful before I continue wandering down that road? I'm trying to convert as much of the deviations in mythbuntu_ui that are overriding functions (both in gtk_ui and install.py) directly into plugins and coming across some deficiencies [16:27] superm1: absolutely. I'm knee deep in debconf_ui at the moment, but I'll try to find time for it later tonight. If not tonight, definitely tomorrow. [16:28] cool thanks, i won't be touching again until after work anyhow [16:28] is there a way to get the LVM partitioner to put the boot partition on partition 1? [16:29] note; if things look good, don't merge though - it's in an iffy state, i just want to make sure those particulars are good before i make the other bigger changes to mythbuntu_install.py [16:29] surely [16:42] ubiquity: evand * r3704 ubiquity/debian/changelog: LP bug reference. [19:45] cjwatson: Just a heads up, debconf_ui is broken, with the bug surfacing in scripts/install.py. It seems debconf doesn't like REGION in this context. I'm looking into it (as I try to gather what I can for packages with debconf support in gtk oem-config), but I'm a bit out of my depth, so it might be a while. [19:51] ev: if PROGRESS REGION is leaking through to debconf, that's the bug; it's supposed to be handled by the filter. We probably shouldn't be running install.py unfiltered [22:23] usb-creator: superm1 * r258 usb-creator/ (debian/changelog usbcreator/frontends/gtk/frontend.py): [22:23] usb-creator: If hiding the persistence and iso selection in the UI, make sure to do [22:23] usb-creator: so before window.show() to prevent weird sizing of the window [22:27] usb-creator: superm1 * r259 usb-creator/usbcreator/frontends/gtk/frontend.py: Leave backend.detect_devices where it was, in case it depended on those previous signal handlers [22:38] cjwatson: Shall I update d-i for -11, or you'll take care of it? [22:39] StevenK: if you have time, please go ahead [22:56] cjwatson: Uploaded, thanks. === robbiew is now known as robbiew_