[00:24] EdwinGrubbs: ping [00:24] sinzui: pong [00:25] EdwinGrubbs: You have a small conflict in your branch. adiroiban changed DistroSeriesStatus to SeriesStatus yeterday [00:26] EdwinGrubbs: I have one question. What does a failure look like when we test this: [00:26] + >>> assert vocabulary_tokens == series_names === jamalta is now known as jamalta-afk [00:36] EdwinGrubbs: we have avoided asserts in doctests since we discovered a bad one in a test 2 years ago [00:37] I would prefer that you print the vocabulary_tokens. We do know which ones they should be [00:38] EdwinGrubbs: I approved your branch on condition you resolve the merge conflict and change the assert in the doctest [00:54] sinzui: I'll look at that. I have to go though. [00:55] okay. land it when you are staisfied === mwhudson_ is now known as mwhudson [01:23] jml: ping === jamalta-afk is now known as jamalta === abentley1 is now known as abentley === jamalta is now known as jamalta-eee === abentley1 is now known as abentley === mwhudson_ is now known as mwhudson === jamalta-eee is now known as jamalta-afk [05:10] stub, around for a review? [05:10] yo [05:10] stub, hooray. I'll send it over. [05:28] ? [05:28] stub, I accidentally sent it to devel. Resubmitted as https://code.edge.launchpad.net/~rockstar/launchpad/fix-scan-branches-script/+merge/17869 [05:33] rockstar: r=stub [05:33] stub, cheers. [06:30] https://code.edge.launchpad.net/~stub/launchpad/pending-db-changes/+merge/17872 needs a review. Staging is busted until this lands. === jtv changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [jtv: http://tinyurl.com/yl59z62] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === matsubara-afk is now known as matsubara [12:10] Any reviewers here today? === matsubara is now known as matsubara-lunch === jamalta-afk is now known as jamalta === matsubara-lunch is now known as matsubara === sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [jtv: http://tinyurl.com/yl59z62, sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [sinzui, sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [16:34] jtv: I approved your branch [16:38] I am seeking one or two reviewers for two small branches. [16:38] sinzui: i'll take one [16:39] intellectronica: thanks: You will have some insights into this one and you can challenge me if you think I am wrong: https://code.edge.launchpad.net/~sinzui/launchpad/release-love [16:39] feel the lurve [16:42] sinzui: so basically, being launchpad's most active triager, you're being a karma ho with this branch, eh? ;) [16:43] intellectronica: I am also the affective owner of many projects, and I do not get karma for that. I need to add registry karmic events (my pretext will be to award karma for providing information needs to link ubuntu to upstream) [16:44] i think that makes sense [16:45] and i really like the improvements to release mgmt [16:45] sinzui: r=me [16:46] intellectronica: thanks. [16:47] sinzui: i'm still waiting on some tests to finish, so i can review the other one too if you still need a review [16:48] intellectronica: this one adds the UI to a hidden page (I want edge feed back before letting users use it). https://code.edge.launchpad.net/~sinzui/launchpad/needs-packaging-bug-509848 [16:51] sinzui: unless it's necessary (because the extra whitespace creates formatting problems), i prefer closing html tags on a new line. can you change the anchor on line 19 of your diff? [16:51] and in the template too, of course === beuno is now known as beuno-lunch [16:52] oh, that is clumbs of me. I will fix both [16:52] clumbsy [16:52] cool, thanks [16:55] sinzui: 'packagings' reads quite funny to me. are you sure this is the best choice? i would have dropped the plural s (but i'm not a native speaker so be critical with my english advice) [16:56] sinzui: everything else looks good to me, so r=me [16:57] thanks [16:57] sinzui: note that i haven't done any ui reviewing at all. i'll leave that for beuno-lunch (or noodles) [16:58] intellectronica: understood === sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === beuno-lunch is now known as beuno [18:04] beuno: can you take a look at https://code.edge.launchpad.net/~sinzui/launchpad/needs-packaging-bug-509848/+merge/17848. There is a comment and picture for you [18:05] sinzui, I have it opened with "needs fixing" and 2 lines already written [18:05] the heat is making me work slower, but I'm getting there! [18:05] beuno: This page will be hidden even if it lands because I am certain it will need refining from edge feedback [18:06] sinzui, ok, I'll take that into account then [19:35] Hi beuno I like your suggestions [19:35] hey sinzui [19:35] thanks [19:35] beuno: Upstream links is the current +packaging page that shows what is linked [19:35] sorry it took me so long [19:36] sinzui, so that will end up showing a gazillion packages, right? [19:36] right. [19:36] That report will change to indicate what is missing from the upstream project information [19:37] We might get better adoption from users if we had good names for these two pages [19:40] hey beuno -- care to gander at some screenshot? [19:41] bac, sure, shoot [19:41] sinzui, how about a drop down? [19:41] this adds the linking to an upstream in the source package portlet [19:41] http://people.canonical.com/~bac/linkup-multiple.png [19:41] http://people.canonical.com/~bac/linkup-one.png [19:41] http://people.canonical.com/~bac/linkup-none.png [19:43] bac, I will peak in 10, after this call [19:43] beuno: excellent [19:43] i shall make some tea === EdwinGrubbs is now known as Edwin-lunch === matsubara is now known as matsubara-afk [20:28] gmb, if you don't mind sir? https://code.edge.launchpad.net/~deryck/launchpad/sort-by-heat-as-default-77701/+merge/17919 [20:28] beuno, ping. how do you feel about sorting by bug heat by default? [20:29] deryck, everywhere? [20:29] bac, back [20:30] beuno, yes, for bug listings. and then menu for selecting order by now would read bug heat rather than importance. [20:30] deryck, I feel uneasy about it [20:30] maybe afer we've had it rolling for a while? [20:31] beuno, sure. The work is done, so you can even look at my branch and decide later. after it's been live for a bit and tweaked some. [20:32] * deryck feels a bit unsure about it too [20:32] deryck, we need to think about listings from the user vs developer perspective [20:32] and which listing is for whom [20:33] beuno, right, very good point. and I'll admit I didn't consider the difference there for this one question. [20:33] bac, a few questions [20:33] why isn't the project linked? [20:34] (as in, why is the "view project" seperate?) [20:34] because it's a radio button, etc? [20:34] what's the difference between "link" and "set" upstream link? [20:34] beuno: ah, good question. TBH, just going off the design sinzui did [20:35] beuno: no reason we can't make that change [20:35] there's some padding issue with those radio buttons as well [20:35] Maybe we want to say "Set upstream project" === Edwin-lunch is now known as EdwinGrubbs [21:45] sinzui: did you need me to do a review for you? [21:46] oh, know, beuno was kind enough to complete the review === sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [22:24] beuno: are you sill about to see the picture of my revision? https://code.edge.launchpad.net/~sinzui/launchpad/needs-packaging-bug-509848/+merge/17848 === jamalta is now known as jamalta-afk [23:00] kfogel, http://pastebin.ubuntu.com/360916/