[00:24] <sinzui> EdwinGrubbs: ping
[00:24] <EdwinGrubbs> sinzui: pong
[00:25] <sinzui> EdwinGrubbs: You have a small conflict in your branch. adiroiban changed DistroSeriesStatus to SeriesStatus yeterday
[00:26] <sinzui> EdwinGrubbs: I have one question. What does a failure look like when we test this:
[00:26] <sinzui>     +    >>> assert vocabulary_tokens == series_names
[00:36] <sinzui> EdwinGrubbs: we have avoided asserts in doctests since we discovered a bad one in a test 2 years ago
[00:37] <sinzui> I would prefer that you print the vocabulary_tokens. We do know which ones they should be
[00:38] <sinzui> EdwinGrubbs: I approved your branch on condition you resolve the merge conflict and change the assert in the doctest
[00:54] <EdwinGrubbs> sinzui: I'll look at that. I have to go though.
[00:55] <sinzui> okay. land it when you are staisfied
[01:23] <sinzui> jml: ping
[05:10] <rockstar> stub, around for a review?
[05:10] <stub> yo
[05:10] <rockstar> stub, hooray.  I'll send it over.
[05:28] <stub> ?
[05:28] <rockstar> stub, I accidentally sent it to devel.  Resubmitted as https://code.edge.launchpad.net/~rockstar/launchpad/fix-scan-branches-script/+merge/17869
[05:33] <stub> rockstar: r=stub
[05:33] <rockstar> stub, cheers.
[06:30] <stub> https://code.edge.launchpad.net/~stub/launchpad/pending-db-changes/+merge/17872 needs a review. Staging is busted until this lands.
[12:10] <jtv> Any reviewers here today?
[16:34] <sinzui> jtv: I approved your branch
[16:38] <sinzui> I am seeking one or two reviewers for two small branches.
[16:38] <intellectronica> sinzui: i'll take one
[16:39] <sinzui> intellectronica: thanks: You will have some insights into this one and you can challenge me if you think I am wrong: https://code.edge.launchpad.net/~sinzui/launchpad/release-love
[16:39] <intellectronica> feel the lurve
[16:42] <intellectronica> sinzui: so basically, being launchpad's most active triager, you're being a karma ho with this branch, eh? ;)
[16:43] <sinzui> intellectronica: I am also the affective owner of many projects, and I do not get karma for that. I need to add registry karmic events (my pretext will be to award karma for providing information needs to link ubuntu to upstream)
[16:44] <intellectronica> i think that makes sense
[16:45] <intellectronica> and i really like the improvements to release mgmt
[16:45] <intellectronica> sinzui: r=me
[16:46] <sinzui> intellectronica: thanks.
[16:47] <intellectronica> sinzui: i'm still waiting on some tests to finish, so i can review the other one too if you still need a review
[16:48] <sinzui> intellectronica: this one adds the UI to a hidden page (I want edge feed back before letting users use it). https://code.edge.launchpad.net/~sinzui/launchpad/needs-packaging-bug-509848
[16:51] <intellectronica> sinzui: unless it's necessary (because the extra whitespace creates formatting problems), i prefer closing html tags on a new line. can you change the anchor on line 19 of your diff?
[16:51] <intellectronica> and in the template too, of course
[16:52] <sinzui> oh, that is clumbs of me. I will fix both
[16:52] <sinzui> clumbsy
[16:52] <intellectronica> cool, thanks
[16:55] <intellectronica> sinzui: 'packagings' reads quite funny to me. are you sure this is the best choice? i would have dropped the plural s (but i'm not a native speaker so be critical with my english advice)
[16:56] <intellectronica> sinzui: everything else looks good to me, so r=me
[16:57] <sinzui> thanks
[16:57] <intellectronica> sinzui: note that i haven't done any ui reviewing at all. i'll leave that for beuno-lunch (or noodles)
[16:58] <sinzui> intellectronica: understood
[18:04] <sinzui> beuno: can you take a look at https://code.edge.launchpad.net/~sinzui/launchpad/needs-packaging-bug-509848/+merge/17848. There is a comment and picture for you
[18:05] <beuno> sinzui, I have it opened with "needs fixing" and 2 lines already written
[18:05] <beuno> the heat is making me work slower, but I'm getting there!
[18:05] <sinzui> beuno: This page will be hidden even if it lands because I am certain it will need refining from edge feedback
[18:06] <beuno> sinzui, ok, I'll take that into account then
[19:35] <sinzui> Hi beuno I like your suggestions
[19:35] <beuno> hey sinzui 
[19:35] <beuno> thanks
[19:35] <sinzui> beuno: Upstream links is the current +packaging page that shows what is linked
[19:35] <beuno> sorry it took me so long
[19:36] <beuno> sinzui, so that will end up showing a gazillion packages, right?
[19:36] <sinzui> right.
[19:36] <sinzui> That report will change to indicate what is missing from the upstream project information
[19:37] <sinzui> We might get better adoption from users if we had good names for these two pages
[19:40] <bac> hey beuno -- care to gander at some screenshot?
[19:41] <beuno> bac, sure, shoot
[19:41] <beuno> sinzui, how about a drop down?
[19:41] <bac> this adds the linking to an upstream in the source package portlet
[19:41] <bac> http://people.canonical.com/~bac/linkup-multiple.png
[19:41] <bac> http://people.canonical.com/~bac/linkup-one.png
[19:41] <bac> http://people.canonical.com/~bac/linkup-none.png
[19:43] <beuno> bac, I will peak in 10, after this call
[19:43] <bac> beuno: excellent
[19:43] <bac> i shall make some tea
[20:28] <deryck> gmb, if you don't mind sir?  https://code.edge.launchpad.net/~deryck/launchpad/sort-by-heat-as-default-77701/+merge/17919
[20:28] <deryck> beuno, ping.  how do you feel about sorting by bug heat by default?
[20:29] <beuno> deryck, everywhere?
[20:29] <beuno> bac, back
[20:30] <deryck> beuno, yes, for bug listings.  and then menu for selecting order by now would read bug heat rather than importance.
[20:30] <beuno> deryck, I feel uneasy about it
[20:30] <beuno> maybe afer we've had it rolling for a while?
[20:31] <deryck> beuno, sure.  The work is done, so you can even look at my branch and decide later.  after it's been live for a bit and tweaked some.
[20:32]  * deryck feels a bit unsure about it too
[20:32] <beuno> deryck, we need to think about listings from the user vs developer perspective
[20:32] <beuno> and which listing is for whom
[20:33] <deryck> beuno, right, very good point.  and I'll admit I didn't consider the difference there for this one question.
[20:33] <beuno> bac, a few questions
[20:33] <beuno> why isn't the project linked?
[20:34] <beuno> (as in, why is the "view project" seperate?)
[20:34] <beuno> because it's a radio button, etc?
[20:34] <beuno> what's the difference between "link" and "set" upstream link?
[20:34] <bac> beuno: ah, good question.  TBH, just going off the design sinzui did
[20:35] <bac> beuno: no reason we can't make that change
[20:35] <beuno> there's some padding issue with those radio buttons as well
[20:35] <sinzui> Maybe we want to say "Set upstream project"
[21:45] <EdwinGrubbs> sinzui: did you need me to do a review for you?
[21:46] <sinzui> oh, know, beuno was kind enough to complete the review
[22:24] <sinzui> beuno: are you sill about to see the picture of my revision? https://code.edge.launchpad.net/~sinzui/launchpad/needs-packaging-bug-509848/+merge/17848
[23:00] <deryck> kfogel, http://pastebin.ubuntu.com/360916/