| === jamalta-afk is now known as jamalta | ||
| === jamalta is now known as jamalta-afk | ||
| === jamalta-afk is now known as jamalta | ||
| === henninge changed the topic of #launchpad-reviews to: on-call: henninge || reviewing: - || queue [jpds] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === matsubara-afk is now known as matsubara | ||
| === henninge changed the topic of #launchpad-reviews to: on-call: henninge || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| * henninge can't stand the quiet .... ;) | 12:32 | |
| === henninge changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === sinzui changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gary_poster | hey gmb. For the release-critical request for https://code.edge.launchpad.net/~gmb/launchpad/remove-bug-heat-from-garbo-daily-bug-511283/+merge/17912 , I'm trying for the guideline of "if it would have been a CP, it can be a release-critical". The problem you say it addresses does sound like it would be a CP candidate under non-release circumstances, but could you verify before I pursue further? | 14:05 |
|---|---|---|
| sinzui | gary_poster: I have a bug that I just tagged as a release blocker. Maybe I was wrong: https://bugs.edge.launchpad.net/launchpad-registry/+bug/512182 | 14:21 |
| mup | Bug #512182: Karma and bug activity missing when bugs are updated by creating a release <current-rollout-blocker> <Launchpad Registry:In Progress by sinzui> <https://launchpad.net/bugs/512182> | 14:21 |
| gary_poster | looking | 14:22 |
| gary_poster | sinzui: my evaluation is that it is CP candidate, and therefore I will approve it for RC if it is available, but it doesn't sound like a release blocker to me because the two symptoms are not critical (that is, I value an on-time release higher than those two symptoms). Are you OK with that evaluation, or would you like to talk about it more? | 14:25 |
| sinzui | gary_poster: yes | 14:25 |
| gary_poster | sinzui: cool thanks | 14:25 |
| sinzui | EdwinGrubbs: can you review my branch at https://code.edge.launchpad.net/~sinzui/launchpad/release-bugtask-bug-512182/+merge/17989 | 14:47 |
| EdwinGrubbs | sinzui: sure | 14:47 |
| EdwinGrubbs | sinzui: is it really 13,000 lines, or should it be merged into db-devel instead of devel? | 14:48 |
| sinzui | oh bugger | 14:48 |
| sinzui | EdwinGrubbs: I will remake the merge request to db-devel, The diff is less that 100 lines | 14:49 |
| EdwinGrubbs | ok, cool | 14:49 |
| sinzui | EdwinGrubbs: https://code.edge.launchpad.net/~sinzui/launchpad/release-bugtask-bug-512182/+merge/17999 | 14:54 |
| === salgado is now known as salgado-lunch | ||
| intellectronica | abentley: can i ask you to review a small branch of mine, an r-c candidate to fix those timeouts in bug listings? | 15:14 |
| abentley | intellectronica: okay | 15:14 |
| intellectronica | abentley: thanks. https://code.edge.launchpad.net/~intellectronica/launchpad/patch-badge-performance/+merge/18000 | 15:14 |
| abentley | intellectronica: BugTaskImageDisplayAPI already exposed has_patch? | 15:18 |
| intellectronica | abentley: yes. i've added it in a previous branch, but didn't realise it's not being used because it's not included in the decorator | 15:18 |
| abentley | intellectronica: What decorator do you mean? | 15:19 |
| intellectronica | i mean BugTaskListingItem | 15:19 |
| abentley | intellectronica: I thought BugTaskImageDisplayAPI was an Interface because of its name and comment string. Now I understand that BugTaskListingItemImageDisplayAPI is a subclass of it. | 15:30 |
| abentley | intellectronica: I don't see any call site updates to match the new BugTaskListingItem.__init__. Where is it constructed? | 15:35 |
| abentley | intellectronica: never mind. | 15:36 |
| intellectronica | abentley: found it? they're passed as a dict to BugListingBatchNavigator which is why you missed them | 15:36 |
| === matsubara is now known as matsubara-lunch | ||
| abentley | intellectronica: Okay, approved. | 15:38 |
| intellectronica | abentley: thanks! | 15:38 |
| intellectronica | abentley: can i ask for an extra line for review? the same needed to be added in milestone views, since they also use BugTaskListingItem. see http://pastebin.ubuntu.com/362666/ | 15:42 |
| abentley | intellectronica: r=me | 15:43 |
| intellectronica | cheers | 15:43 |
| === salgado-lunch is now known as salgado | ||
| === matsubara-lunch is now known as matsubara | ||
| === beuno is now known as beuno-lunch | ||
| sinzui | EdwinGrubbs: Do you have time for that review? Should I seek someone else? | 17:33 |
| EdwinGrubbs | sinzui: I think this error is unrelated to your branch, but it is making it difficult for me to test things. When I run "make", I get ImportError: No module named builder.recipe | 17:34 |
| EdwinGrubbs | sinzui: do you get that error? | 17:35 |
| sinzui | I have not gotten that error. | 17:39 |
| EdwinGrubbs | sinzui: I think rocketfuel-get will solve it. I've gotten so used to running "bzr up download-cache" that I hardly ever run it. | 17:40 |
| sinzui | EdwinGrubbs: I certainly would have noticed that error. I had trouble with the code...the test was right, but I forgot to use notify so I ran my test many times without issue to understand my incompetence. | 17:41 |
| EdwinGrubbs | sinzui: make works now. Running the tests. | 17:41 |
| EdwinGrubbs | sinzui: it looks like Bug.setStatus() calls BugTask.transitionToStatus() and sends an event. you could use that with bug.setStatus(bugtask.target, status, user) | 17:48 |
| sinzui | bugtask.editView uses the approach I took | 17:49 |
| EdwinGrubbs | sinzui: ok, r=me | 17:51 |
| sinzui | EdwinGrubbs: how would you test the use of bugtask.bug.setStatus(self.series_target, BugTaskStatus.FIXCOMMITTED, user) | 17:52 |
| sinzui | Can I keep the same test and just update the code? | 17:52 |
| EdwinGrubbs | sinzui: I think so. | 17:53 |
| sinzui | let me try, The method you found has conjoined rules that I never ever want to write again | 17:53 |
| sinzui | Oh, I cannot | 17:56 |
| sinzui | EdwinGrubbs: I need 5 more minutes, the target is not as obvious as I thought because of source packages | 17:56 |
| sinzui | EdwinGrubbs: Thanks. I got rid of a lot of cruft: http://pastebin.ubuntu.com/362757/ | 18:00 |
| sinzui | The test was fine | 18:01 |
| EdwinGrubbs | sinzui: that looks good to go. | 18:02 |
| sinzui | thanks you very much. bug.setStatus works as I thought transitionToStatus() worked. | 18:02 |
| === matsubara is now known as matsubara-afk | ||
| sinzui | Hi Gary. I am officially asking for an RC for this branch that we discussed a few hours ago: https://code.edge.launchpad.net/~sinzui/launchpad/release-bugtask-bug-512182/+merge/17999 | 18:08 |
| gary_poster_ | ack, sincui, approving. | 18:09 |
| gary_poster_ | sinzui: | 18:09 |
| sinzui | gary_poster: ^ If we landed it, you can create a release and all the foundations bugs will be updated for you for free! | 18:09 |
| gary_poster_ | heh, cool | 18:09 |
| === beuno-lunch is now known as beuno | ||
| gary_poster_ | sinzui, the web interface is pretty slow, but I approved | 18:12 |
| === gary_poster_ is now known as gary_poster | ||
| === henninge_ is now known as henninge | ||
| === matsubara-afk is now known as matsubara | ||
| sinzui | beuno: Do you have time to do a follow up review of https://code.edge.launchpad.net/~sinzui/launchpad/needs-packaging-bug-509848/+merge/17848 | 18:50 |
| beuno | sinzui, yes | 18:50 |
| bac | hi beuno | 19:13 |
| beuno | hi bac | 19:14 |
| bac | beuno: on friday you noted some padding issues on the radio buttons as shown on http://people.canonical.com/~bac/linkup-multiple.png | 19:15 |
| beuno | yes | 19:15 |
| bac | beuno: i'm just using a vertical LaunchpadRadioWidget...so i don't see how the padding on it could be different than elsewhere | 19:15 |
| beuno | those lines are all squished | 19:16 |
| bac | beuno: but it does look cramped | 19:16 |
| beuno | off the top of my head, I can't think fo why that is | 19:16 |
| bac | i don't know fo why either | 19:16 |
| beuno | bac, are they in li's? divs? | 19:17 |
| beuno | or just br's? | 19:17 |
| bac | beuno: the widget does the rendering based on the vocab. i haven't looked at the implementation of it to see how it is done. | 19:18 |
| === gary_poster is now known as gary-lunch | ||
| === EdwinGrubbs is now known as Edwin-lunch | ||
| beuno | sinzui, doing your review | 19:52 |
| beuno | I think it's mostly ok | 19:52 |
| leonardr | gary: https://code.edge.launchpad.net/~leonardr/lazr.restful/generate-multiversion-operations/+merge/18032 | 20:02 |
| beuno | sinzui, done | 20:03 |
| sinzui | thank beuno | 20:04 |
| sinzui | beuno: I can make the link changes. This changes will appears on all pages and in the page title | 20:06 |
| sinzui | s/this/those/ | 20:07 |
| beuno | sinzui, I think that's fine | 20:07 |
| sinzui | I hope so, I only want one set of terms referring to these pages | 20:07 |
| sinzui | beuno: That hardest part about developing a portlet to show the status of information that communities need to work with the porject is that we do not have a name for it | 20:08 |
| beuno | sinzui, yaeh, it's more about "tell us how the community works" | 20:09 |
| sinzui | The information we show on the source package should be presented the same way on the project page: https://dev.launchpad.net/Registry/UbuntuLinkUpstream?action=AttachFile&do=get&target=linked-package.png | 20:10 |
| sinzui | I have been looking for a term that uses contributor or community for project version of this portlet. | 20:11 |
| sinzui | Contributor Connections is the best term I have, and I do not like it | 20:11 |
| beuno | hm | 20:12 |
| beuno | it's a tricky one | 20:12 |
| sinzui | oh, this information cooresponds to the Participation portlet, accept that it contains all the hosted and remote services | 20:14 |
| beuno | I'll think about it while I write a long email | 20:14 |
| sinzui | thanks | 20:14 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| bac | beuno: have a look at http://people.canonical.com/~bac/linkup-multiple-ff.png when you have a sec | 20:49 |
| beuno | bac, much better | 20:51 |
| beuno | but the "Upstream project" label is too far from the question :) | 20:51 |
| bac | beuno: i didn't do anything. :) FF vs. webkit | 20:51 |
| beuno | you could, of course, drop that label | 20:52 |
| beuno | it's meaningless to most people I think | 20:52 |
| === gary-lunch is now known as gary_poster | ||
| bac | beuno: that label is the 'title' for the widget. i tried omitting it and just got a free-standing colon. | 20:57 |
| beuno | garrrrrrrr | 20:57 |
| leonardr | gary: if you want to warm up before reviewing my huge branch, here's an extremely short one: | 20:58 |
| leonardr | https://code.edge.launchpad.net/~leonardr/lazr.restful/missing-field-error/+merge/18037 | 20:58 |
| beuno | bac, can the label be the question? | 20:58 |
| gary_poster | :-) ok | 20:58 |
| bac | beuno: if we want the question to end with ":" | 20:58 |
| beuno | double garrrrrrrrrrrrrr | 20:58 |
| bac | beuno: so the spacing issue is webkit only. i propose to ignore it for this branch and find/file a bug to address it in a later branch | 20:59 |
| beuno | bac, I'll stamp it if you target it :) | 21:00 |
| bac | que? | 21:00 |
| * bac curses his internet connection today | 21:01 | |
| beuno | bac, the bug for the webkit thingie | 21:01 |
| bac | beuno: ok. i'm still confused by stamp and target. target where? | 21:02 |
| bac | sorry if i'm being dense | 21:02 |
| beuno | bac, ah, sorry for confusing you | 21:02 |
| beuno | I'll approve the MP if you target the bug to be fixed in the next cycle | 21:02 |
| beuno | these are the kind of bugs that almost never get fixed :) | 21:03 |
| bac | beuno: sure i'll do that | 21:03 |
| bac | beuno: but, of course, i'll mark it as foundations... | 21:04 |
| beuno | ha | 21:04 |
| beuno | well played | 21:04 |
| gary_poster | :-P | 21:04 |
| gary_poster | leonardr: since you already looked at an earlier version of the file, could you review https://code.edge.launchpad.net/~gary/launchpad/bug_475371/+merge/18039 ? I think this should just be comparing it to Tom's description in that bug report, as you already did, so I'm hopeful that this would be easy. | 21:53 |
| leonardr | gary, sure | 21:53 |
| gary_poster | thank you | 21:53 |
| bac | sinzui: my MP is up if you're interested: https://code.edge.launchpad.net/~bac/launchpad/bug-490518-link-suggestion/+merge/18040 | 21:55 |
| sinzui | bac: Thanks, I'll start it shortly | 21:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
