[01:05] <rockstar> thumper, do you think you have time to review an RC candidate?
[01:05] <thumper> rockstar: shoot
[01:05] <rockstar> thumper, great, thanks.
[01:05] <rockstar> I just need to run it through one more tests.
[01:08] <thumper> ack
[02:15] <rockstar> thumper, https://code.edge.launchpad.net/~rockstar/launchpad/upgrade-branch-rc/+merge/18049
[02:25] <rockstar> gary_poster, ping
[03:09] <gary_poster> rockstar: yo
[03:09] <rockstar> gary_poster, got an rc candidate for you: https://code.edge.launchpad.net/~rockstar/launchpad/upgrade-branch-rc/+merge/18049
[03:09] <rockstar> gary_poster, it's playing in ec2 now.
[03:09] <gary_poster> cool, looking
[03:10] <gary_poster> rockstar: approved
[03:10] <rockstar> gary_poster, great, thanks.  I'll land as soon as the ec2 run is done.
[03:11] <gary_poster> rockstar: sounds great, thank you
[07:34] <al-maisan> Good morning!
=== henninge is now known as heninnge-lunch
=== mrevell is now known as mrevell-lunch
=== heninnge-lunch is now known as heninnge
=== mrevell-lunch is now known as mrevell
[13:25] <bac> good morning
[13:25] <bac> gmb, you reviewing today?
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:25] <gmb> Argh
[13:26] <gmb> bac: Yes, though no-one's asked so far.
[13:26] <bac> as i'd expect...
=== gmb changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: -, - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:26] <bac> i'm going to relocate but will be back in 12 minutes +/-
[13:27] <noodles775> Hi guys, non-urgent MP ready here: https://code.launchpad.net/~michael.nelson/launchpad/510331-syncsources-latest-pub/+merge/18070
[13:46] <jtv> hi bac, hi gmb!
[13:47] <gmb> Hi jtv
[13:48] <gmb> noodles775: I'll see if I can get to your mp this afternoon; depends on bugs QA atm
[13:48] <noodles775> gmb: thanks, no rush.
[13:48] <jtv> gmb: that sounds like you're busy... which is a shame because I've built up a bit of a backlog
[13:49] <gmb> jtv: Well, I've only got a few more items to do and bac's here too, so we'll see what we can get through
[13:49] <jtv> yay :)
[13:49] <gmb> jtv, noodles775: Queue 'em up gentlemen and we'll start rolling shortly.
=== noodles775 changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: -, - || queue [sinzui,noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:50] <jtv> gmb: I'm not asking for priority, mind you; just pointing out there's stuff on activereviews.  :)
[13:50] <gmb> :)
=== bac changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: sinzui, - || queue [noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:00] <bac> morning jtv, noodles.  we'll get to your reviews shortly
[14:01] <jtv> bac: good morning!  thanks :)
=== jamalta_ is now known as jamalta
[14:09] <bac> sinzui:  you were on the review queue but i don't see anything on +activereviews.  stale request?
=== bac changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: jtv, - || queue [noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== salgado is now known as salgado-afk
[15:00] <mrevell> Hey can I get a review on this what's new branch? it needs to go to gary for an RC soonish -- https://code.edge.launchpad.net/~matthew.revell/launchpad/whatsnews-10dot1/+merge/18071
[15:02] <gary_poster> mrevell: yes.  Looking.  It's actually only because we have had a bit of a problem with the release that we can still land it, so we're lucky.
[15:02] <mrevell> thanks gary_poster
=== gmb changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: jtv, noodles775 || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:08] <gary_poster> mrevell: approved https://code.edge.launchpad.net/~matthew.revell/launchpad/whatsnews-10dot1/+merge/18071 .  Please land asap
[15:10] <mrevell> thanks gary_poster, it's going through the test-suite atm. It started 3 hours ago so should be done soon.
=== matsubara is now known as matsubara-lunch
=== bac changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: jtv-2, noodles775 || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:17] <gmb> noodles775: r=me
=== gmb changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: jtv, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:17] <noodles775> Thanks gmb
[15:18] <gmb> noodles775: One minor nitpick about a comment but nothing major
[15:18] <jtv> hi bac, thanks for the review.   Like the 365/2; maybe I'll make it a leap year so we can avoid fractions.  :-)
[15:18] <bac> jtv....uh, ok
[15:21] <noodles775> gmb: great. Did you have any thoughts about a better way to test the private method (as mentioned in the MP)?
[15:22] <gmb> noodles775: Argh, must've skipped that bit of the mp. Sorry. Hang on...
[15:23] <gmb> noodles775: So, no, I can't think of a better way (which is why I never balked at the use of rSP()). The only way I could think of is to test it indirectly, but I'd rather have the direct test myself.
[15:24] <noodles775> Great, thanks for that.
=== beuno is now known as beuno-lunch
=== salgado-afk is now known as salgado
[16:11] <leonardr> gary, given that you're busy with the release, would you like me to put generate-multiversion-operations in the general review queue?
[16:12] <gary_poster> leonardr: yes, sorry.
[16:13] <leonardr> gary, np
[16:13] <gary_poster> salgado: also, feel free to do the same with yours, unless you want me to review (or you have a hard time getting someone to agree to the length)
[16:13] <leonardr> bac or gmb, can you take a look at https://code.edge.launchpad.net/~leonardr/lazr.restful/generate-multiversion-operations/+merge/18032 ?
[16:13] <leonardr> it's slightly over 800 lines
[16:13] <leonardr> i'm available to chat about it in any level of detail
[16:16] <bac> leonardr:  i can look at it in a bit
[16:16] <leonardr> cool
=== matsubara-lunch is now known as matsubara
[16:53] <bigjools> bac, do we use camelCase or under_score for methods on the API?
[17:11] <leonardr> bigjools, are you asking him to check on what i said?
[17:11] <leonardr> bac, gmb: another branch for you, this one is much easier to review: https://code.edge.launchpad.net/~leonardr/lazr.restful/test-multiversion-collection/+merge/18089
[17:11] <gmb> leonardr: I'll take it
[17:11] <bigjools> leonardr: yes - don't take it personally :)  I've not seen that said before, that's all.
=== gmb changed the topic of #launchpad-reviews to: on-call: bac, gmb || reviewing: jtv, leonardr || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:13] <leonardr> bigjools, np
[17:13] <leonardr> let me try to find a doc on one of our many wikis
[17:16] <leonardr> bigjools: i would expect to see it on https://dev.launchpad.net/API/ImplementingAPIs but it's not explicitly there
[17:17] <leonardr> you will however see createProduct exported as 'create_product'
[17:17] <leonardr> the general rule is that we want to follow pep 8 in the interfaces we expose the the public
[17:17] <bigjools> leonardr: there's a load of stuff exported in camelCase as well :/
[17:17] <leonardr> bigjools: yes, because people don't know about the coding standard
[17:17] <bigjools> yay, standards, there's so many to choose from
[17:17] <leonardr> if someone (maybe gary) can confirm this i'll add it to the wiki
[17:18] <bigjools> yeah that'd be good to clarify, and bring up in a reviewers' meeting
[17:19] <leonardr> once we have multiversion there will be a lot of renaming of methods
[17:26] <gmb> leonardr: r=me
=== gmb changed the topic of #launchpad-reviews to: on-call: bac || reviewing: jtv, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:26]  * gmb calls it a day
[17:26] <jtv> gmb: have a good one
[17:26]  * gmb will have a sleepy one, but the thought is appreciated
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: leonardr || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[18:04] <gary_poster> leonardr: we prefer initialCamelCase for methods, since the project adopted that before PEP 8 preferred underlines.  https://dev.launchpad.net/PythonStyleGuide#Naming
[18:04] <leonardr> gary: i'm talking about the names we present to the outside world via the web service, not the names we use internally
[18:05] <leonardr> i think flacoste would be a definitive source
[18:06] <leonardr> but what i believe happened was
[18:06] <gary_poster> leonardr: ah.  I'm not familiar with a standard there.  I'd be inclined to stick with the same standard as our Python classes.  This is actually more of a reviewers meeting sort of thing IMO, and barry quite possibly would have been the tie-breaker in olden days
[18:06] <leonardr> i guess at this point we might as well go with the de facto default
[18:07] <leonardr> gary: the rationale is that people are going to be using launchpadlib from their third-party python apps that conform to pep8
[18:07] <bac> leonardr, gary_poster: i can confirm that the decision was made when we started exporting things to be PEP8.  i'm surprised it isn't documented anywhere.
=== beuno-lunch is now known as beuno
[18:08] <leonardr> bac: i can't find it
[18:08] <bac> it will be a good topic for the reviewer's meeting
[18:08] <gary_poster> bac: ok, cool, I'm good with that.
[18:08] <gary_poster> thanks
[18:08]  * bac notes there is a lot of inconsistency, though.  :(
[18:11] <gary_poster> bac, yeah, I think it might be nice for leonardr to provide some third-party consistency, going through the webservice after completing versioning and lower-level collections, while he verifies that what he has done is usable.
[18:12] <salgado> bac, I have a branch which is about 1100 lines up for review, but should be an easy review.  any chance you can do take it?
[18:13] <bac> salgado: is that the one gary_poster started?
[18:13] <salgado> bac, yep, that's it
[18:13] <bac> salgado: and gary_poster isn't going to finish it?
[18:14] <bac> salgado: i'll be glad to take it later this afternoon if that is the case.
[18:14] <salgado> bac, not today and probably not tomorrow as he's busy with RM tasks
[18:14] <salgado> bac, that'd be great, thanks a lot!
[18:14] <bac> cool.  just didn't want to duplicate effort
=== EdwinGrubbs is now known as Edwin-afk
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: - || queue [salgado] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: on-call: bac || reviewing: bigjools || queue [salgado] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[19:27] <bac> salgado: i'm going to bump bigjools in front of you since his MP is short
[19:28] <salgado> bac, fair enough
[19:52] <sinzui> bac: I reviewed your branch. The bulk of my remarks are conversational. Do not panic at all the remarks
[19:53]  * bac pulls hair out and sets it on fire
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
=== bac changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [-] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews