[00:01] <bac> salgado-afk: i tried to review your branch but didn't get far.  i tried running the branch referenced in the MP but +login-openid does not work on that branch.  I then tried grabbing your loom branch but got bzr errors.
[00:03] <salgado-afk> bac, you should be able to try it out by merging from bzr+ssh://bazaar.launchpad.net/~salgado/launchpad/lp-as-openid-rp-for-ec2
[00:04] <salgado-afk> in that branch the +login page uses OpenID, so +login-openid doesn't exist there
[00:06] <bac> salgado-afk: got the branch
[00:07] <bac> salgado-afk: running the new branch i still don't see +login-openid
[00:08] <bac> salgado-afk: so, i'm confused as to what your two different branches do.
[00:08] <salgado-afk> bac, +login-openid doesn't exist anymore -- in that branch I've already switched the +login page to use OpenID
=== salgado-afk is now known as salgado
[00:09] <salgado> the branch you're reviewing just adds the OpenID provider, and the other one changes +login to use the OpenID provider
[00:10] <bac> salgado: and neither support the URL you listed in the MP -- +login-openid?
[00:11] <salgado> bac, the latter one used to, but I moved it over the existing +login
[00:11] <bac> salgado: ok, i think i understand now.
[00:12] <bac> +login on the branch you posted a second ago tries to work.  i need to add testopenid.lp.dev to /etc/hosts now to see it really work
[00:12] <salgado> yeah, forgot to mention that, sorry
[00:18] <bac> no biggie
[00:22] <bac> salgado: missing cert
=== jamalta is now known as jamalta-afk
=== jtv changed the topic of #launchpad-reviews to: on-call: jtv || reviewing: - || queue [-] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[08:27] <jtv> Who's free to review an RC/CP branch?  https://code.edge.launchpad.net/~jtv/launchpad/bug-512698/+merge/18124
[08:42] <jtv> flacoste, are you free to review a re-roll candidate?  It's just backing out another branch.  https://code.edge.launchpad.net/~jtv/launchpad/bug-512698/+merge/18124
[08:42] <jtv> I've never backed out a branch before, so would like to be sure I get it right.
[08:46] <flacoste> jtv: looking
[08:47] <jtv> thanks!
[08:50] <flacoste> jtv: looks good
[08:56] <jtv> flacoste: thanks...  I can't explain the conflict, so you'll notice that's the one part I didn't back out.  Seemed safer; somebody else may have started using the same JS module.
=== matsubara-afk is now known as matsubara
=== henninge is now known as henninge-lunch
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
=== jamalta-afk is now known as jamalta
=== henninge-lunch is now known as henninge
[14:25] <al-maisan> jtv: hello there! Are you still reviewing?
=== matsubara_ is now known as matsubara
=== al-maisan changed the topic of #launchpad-reviews to: on-call: jtv || reviewing: - || queue [al-maisan<http://tinyurl.com/yag7j48>] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== al-maisan changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [al-maisan<http://tinyurl.com/yag7j48>] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [al-maisan<http://tinyurl.com/yag7j48>] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== allenap` changed the topic of #launchpad-reviews to: on-call: Edwin, allenap || reviewing: -, - || queue [al-maisan<http://tinyurl.com/yag7j48>] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== beuno_ is now known as beuno
=== matsubara is now known as matsubara-lunch
=== salgado is now known as salgado-lunch
=== deryck is now known as deryck[lunch]
[16:15] <al-maisan> hello EdwinGrubbs or allenap : would either of you be willing to review the branch listed in the topic?
[16:15] <allenap> al-maisan: I'll do it.
=== beuno is now known as beuno-lunch
=== allenap changed the topic of #launchpad-reviews to: on-call: Edwin, allenap || reviewing: -, al-maisan<http://tinyurl.com/yag7j48> || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:15] <al-maisan> allenap: thank you!
=== salgado-lunch is now known as salgado
[16:25] <al-maisan> back in a few minutes..
=== jamalta changed the topic of #launchpad-reviews to: on-call: Edwin, allenap || reviewing: -, al-maisan<http://tinyurl.com/yag7j48> || queue [jamalta] || This channel is logged:           http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:27] <jamalta> EdwinGrubbs, allenap: Let me know when you have a chance, just want to have a short pre-implementation chat about a trivial bug
[16:27] <EdwinGrubbs> jamalta: I'm available
[16:28] <jamalta> EdwinGrubbs: I'm looking at bug #118609
[16:28] <mup> Bug #118609: "List related bugs" doesn't work on hosts other than bugs.launchpad.net <trivial> <ui> <Launchpad Bugs:Confirmed> <https://launchpad.net/bugs/118609>
[16:29] <jamalta> First, I wanted to see what the suggested implementation would be. Adding +bugs to the link works as expected, but would that be the best solution? Or should the link go to the bugs sub-domain instead?
[16:29]  * EdwinGrubbs checking
[16:31] <jamalta> Secondly, would a test for that bug just check if the link for "List related bugs" is pointing to +bugs or the bugs subdomain (depending on the implementation taken)?
[16:32] <jamalta> Only issue I see with using +bugs is that the link in the side menu is not active
[16:36] <EdwinGrubbs> jamalta: hmm, it seems that the root of the problem is that going to http://edge.launchpad.net/~bjornt/+assignedbugs does not redirect you to bugs.edge.launchpad.net so the canonical_url() creates a link to edge.launchpad.net instead of bugs.edge.launchpad.net
[16:37] <jamalta> EdwinGrubbs: So the solution should be to instead redirect the original URL to bugs.launchpad.net?
[16:37] <jamalta> I had skipped that as a solution as it resolved correctly :) But seems fair enough
[16:38] <EdwinGrubbs> jamalta: I think so. I'm looking up where the link is defined now.
=== matsubara-lunch is now known as matsubara
[16:39] <jamalta> EdwinGrubbs: Well the sidebar menu is in lib/lp/registry/browser/person.py
[16:40] <jamalta> But the only way I know to get to that page is by clicking the "Bugs" tab which correctly moves you to bugs.launchpad.net, in which case all links will work correctly.
[16:40] <jamalta> I was assuming that the use-case would be if the user typed the URL manually instead of following a link, although I could be very wrong.
[16:40] <jtv> al-maisan: hi! sorry, long break, but yes.
[16:41] <al-maisan> jtv: no problem, allenap was so kind to take a look at the branch in question.
[16:41] <jtv> allenap: sorry for leaving you alone for so long.  There was nothing in my earlier day... what needs doing?
[16:41] <al-maisan> jtv: do you mind if I review yours tomorrow morning .. my day is drawing to a close.
[16:42] <jtv> al-maisan: not at all!
[16:42] <al-maisan> jtv: thanks!
[16:42] <allenap> jtv: Don't worry, I started after Edwin today; I was out this morning.
[16:42] <EdwinGrubbs> jamalta: it looks like the best fix will be to change Link('', text, summary) to Link('', site='bugs', text, summary)
[16:43] <jamalta> EdwinGrubbs: Ah, okay
=== beuno-lunch is now known as beuno
[16:45] <jamalta> EdwinGrubbs: That makes a lot of sense, I should add site='bugs' to all of the bugs link, though, right?
[16:46] <jamalta> All the links within that class
=== deryck[lunch] is now known as deryck
[16:47] <EdwinGrubbs> jamalta: It's not absolutely necessary, since those urls don't overlap with urls in other domains, but it would make it more consistent.
[16:48] <jamalta> EdwinGrubbs: Right, that's why I wanted to consider that
[16:49] <jamalta> EdwinGrubbs: Last question would be about testing
[16:50] <jamalta> I'm assuming I need to write a test for this bug, right?
[16:50] <jamalta> If so, should I simply pull out the link and make sure the URL is "bugs.launchpad.dev..."?
[16:50] <al-maisan> allenap: sorry for bothering you but I corrected two comments; this may make it easier to read the branch: http://pastebin.ubuntu.com/363970/
[16:50] <jamalta> I can't find any tests that deal with that link specifically
[16:52] <allenap> al-maisan: Cool, thanks for letting me know.
[16:52] <EdwinGrubbs> jamalta: that should be sufficient. You can add that test to lib/lp/registry/stories/xx-person-bugs.txt
[16:52] <jamalta> EdwinGrubbs: thanks so much! I'll get working on that then :)
[17:00] <allenap> barry: Out of interest, do you know if argument unpacking - i.e. def foo(a (b, c)): ... - is deprecated, generally frowned upon, or jolly good stuff?
[17:01] <barry> allenap: generally frowned upon, surprising to many users, and (not sure about this) maybe gone in python 3?
[17:01] <allenap> barry: Cool, thanks.
[17:02] <barry> np!
[17:02] <allenap> barry: Yes, actually, it's a SyntaxError in 3.
[17:02] <barry> allenap: cool, that's what i thought.  thanks for checking it!
=== EdwinGrubbs is now known as Edwin-lunch
[17:36] <jamalta> allenap: since Edwin is now out to lunch, would you care to review an MP for me? It'll be fun, I promise! :)
[17:37] <allenap> jamalta: I'd love to, but I won't get to it until tomorrow; it's nearly my end-of-day here. I can take it, or you could ask tomorrow's OCR.
[17:39] <jamalta> allenap: alright that sounds good.. thanks :)
[17:39] <allenap> jamalta: Which one? OCR or me? :)
[17:41] <jamalta> allenap: waiting for another reviewer
[17:41] <jamalta> or waiting for you
[17:41] <jamalta> whichever comes first :)
[17:41] <jamalta> I have no problem waiting, heh
[17:42] <allenap> jamalta: Okay, cool. Just to be clear, it's for bug 118609 right?
[17:42] <mup> Bug #118609: "List related bugs" doesn't work on hosts other than bugs.launchpad.net <trivial> <ui> <Launchpad Bugs:Confirmed for jamalta> <https://launchpad.net/bugs/118609>
[17:42] <jamalta> allenap: correct
[17:43] <allenap> jamalta: Actually, it's short, I'll do it now.
[17:44] <al-maisan> allenap: are you done with the other branch by any chance?
[17:44] <jamalta> allenap: Alright, thanks!
[17:44] <jamalta> It is pretty short, maybe 10 lines changed ;)
[17:47] <allenap> al-maisan: I hope to have it done in the next 15 minutes.
[17:47] <allenap> jamalta: Do you need someone to land that branch for you?
[17:47] <al-maisan> allenap: great, thanks!
[17:48] <jamalta> allenap: well, yeah i guess so :)
[17:48] <jamalta> i always get confused at that question.. 
[17:48] <jamalta> do you ask because some people land their own branches?
[17:48] <jamalta> i'll fix the description in the test, thanks
[17:49] <allenap> jamalta: Well, only some people have permission to submit the branches to PQM, which is what actually lands the branches on devel. I can land it for you. Can you either email me when it's ready, or ping me in the morning?
[17:49] <jamalta> allenap: ah ok, i get it
[17:50] <jamalta> now is ok with me, as long as you have time for it
[17:51] <jamalta> i fixed the doctest per your suggestion
=== mrevell is now known as mrevell-dinner
[18:09] <allenap> al-maisan: Wow, your branch has a lot in it. I'm not finished yet, but http://pastebin.ubuntu.com/364018/ has my review so far. I've just got to TestMultiArchJobDelayEstimation, and I'll finish it in the morning.
[18:10] <al-maisan> allenap: OK .. that's fine .. have a nice evening.
[18:10] <allenap> al-maisan: And you, and sorry for not getting it all done.
[18:10] <al-maisan> allenap: no problem .. I understand, it's quite a big branch.
[18:14] <leonardr> edwin or allenap, can you review https://code.edge.launchpad.net/~leonardr/lazr.restful/generate-multiversion-collections/+merge/18153 ?
=== sinzui changed the topic of #launchpad-reviews to: on-call: Edwin, allenap || reviewing: -, al-maisan<http://tinyurl.com/yag7j48> || queue [sinzui, jamalta] || This channel is logged:           http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[19:34] <sinzui> Edwin-lunch: allenap: I am jumping the queue because I have a branch that address the timeouts when creating a release
=== Edwin-lunch is now known as EdwinGrubbs
[19:50] <EdwinGrubbs> sinzui: is it the release-timeout-bug-513321 you want me to review
[19:50] <sinzui> yes
[20:19] <EdwinGrubbs> sinzui: r=me. I wonder why we don't have an architecture for optionally queueing up notify() calls and processing them later.
[20:20] <EdwinGrubbs> jamalta, leonardr: do you still need a review?
[20:20] <sinzui> EdwinGrubbs: you mean "What happened to rabbitMQ"? I agree this is needed. This was a very rude surprise for me
[20:20] <leonardr> edwingrubbs: yes, please
[20:20] <leonardr> https://code.edge.launchpad.net/~leonardr/lazr.restful/generate-multiversion-collections/+merge/18153
[20:21] <EdwinGrubbs> sinzui: well, these are all internal messages, so they could easily be queued up in a db table by pickling the objects involved.
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: Edwin, allenap || reviewing: leonardr, al-maisan<http://tinyurl.com/yag7j48> || queue [jamalta] || This channel is logged:           http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[20:25] <jamalta> EdwinGrubbs: no allenap reviewed the branch, i believe it has to be landed still, though.
[20:25] <jamalta> i think allenap ran short on time, i'm not sure where that is at this point
[20:26] <EdwinGrubbs> jamalta: since there was just a rollout, non-critical branches probably won't be able to be landed until Monday.
[20:26] <jamalta> EdwinGrubbs: sounds good to me, thanks
[20:27] <EdwinGrubbs> jamalta: I can do it for you, but you should probably ping me on Monday so I don't forget.
[20:27] <jamalta> EdwinGrubbs: will jot that down on my calendar, thanks :)
[20:27] <jamalta> and thanks for the help earlier
[20:27] <jamalta> it's fun to learn so much from such trivial bugs :)
[20:29] <sinzui> EdwinGrubbs: correct: Our struggle is that since we do not have that infrastucture, I need to proposed schema changes, land model changes, and isolate these on staging. Regardless of the labour, this this a 5 week fix and few users will see it for me to get good feedback :/
[20:39] <sinzui> EdwinGrubbs: Can I resubmit my proposal against the correct branch? for an RC I should make it clear that I want to merge into db-devel
[20:40] <sinzui> EdwinGrubbs: and the diff will be very small
[20:41] <EdwinGrubbs> sinzui: yes.
=== salgado is now known as salgado-afk
[20:43] <sinzui> EdwinGrubbs: https://code.edge.launchpad.net/~sinzui/launchpad/release-timeout-bug-513321/+merge/18160
=== matsubara is now known as matsubara-afk
[20:43] <EdwinGrubbs> sinzui: done
[20:53] <sidnei> an, there we go
[20:54] <sidnei> anyone up for a lazr-js review?
[21:10] <intellectronica> sidnei: sure, i'm happy to take it
[21:10] <sidnei> intellectronica, awesome. it's pretty trivial actually. let me find the url
[21:12] <sidnei> intellectronica, https://code.edge.launchpad.net/~sidnei/lazr-js/module-config-uses-min
[21:14] <intellectronica> sidnei: i'd start the tuple on line 20 of the diff on the next line. your call but i find this a bit weird to read
[21:15] <sidnei> intellectronica, good catch.
[21:15] <intellectronica> sidnei: no other comment. patch looks great
[21:15] <sidnei> intellectronica, cool. is lazr-js still using pqm?
[21:16] <intellectronica> sidnei: i think so, yes
[21:16] <sidnei> intellectronica, ok. i have to find the majik incantation again *wink*
[21:17] <intellectronica> sidnei: and confusingly the trunk branch is called 'toolchain'
[21:18] <intellectronica> sidnei: also, i think you'll have to wait until launchpad's pqm is open again. it's still in release-critical mode after the release
[21:18] <sidnei> intellectronica, man, that really shouldn't block lazr-js
[21:18]  * sidnei holds up on the angrymail
[21:19] <sidnei> intellectronica, is this what you mean? https://pastebin.canonical.com/27105/
[21:19] <intellectronica> i totally agree. time is high for us to start including lazr-js as a separate package and test it independently
[21:19] <intellectronica> sidnei: yes, exactly
[21:20] <intellectronica> makes it a bit clearer on first pass that you are concatenating tuples
[21:20] <sidnei> yeah. it wasn't intentional. i refactored that line a couple times.
[21:49] <EdwinGrubbs> leonardr: I got errors in multiversion.txt and field.txt tests.
[21:52] <leonardr> edwingrubbs, can you paste the errors?
[21:56] <EdwinGrubbs> leonardr: http://pastebin.ubuntu.com/364149/
[21:57] <leonardr> edwin: i think you have a different version of something
[21:58] <leonardr> edwingrubbs: yes, i believe you have an old version of simplejson
[21:58] <leonardr> edwingrubbs: i have 2.0.9. what do you have?
[22:02] <EdwinGrubbs> leonardr: you're right, I have an old version.
[23:21] <EdwinGrubbs> leonardr: do you get an oops when you reload the mp? https://code.edge.launchpad.net/~leonardr/lazr.restful/generate-multiversion-collections/+merge/18153