/srv/irclogs.ubuntu.com/2010/02/02/#launchpad-dev.txt

kfogelintellectronica: saw your branch get linked just now00:02
intellectronicakfogel: yes. had a chance to look at it?00:03
kfogelintellectronica: not yet, about to00:03
intellectronicai think it's good to go00:03
kfogelintellectronica: in this comment, "lisp-style identifier" means with hyphen instead of camelCase, right?00:04
kfogelIs this a new CSS class or an existing one. If it's new, let's change it to00:04
kfogellisp-style-identifier. Otherwise don't worry about it.00:04
intellectronicakfogel: right. sorry for not being clearer.00:05
kfogelintellectronica: no, I think you were clear -- just you were here, so I thought I'd check to make abs sue.00:05
kfogelsure00:05
kfogelintellectronica: also, you wrote this: "Repeating the same style over and over again kinda' screams CSS class."00:07
kfogelbut making a new class for this feels wrong -- I'd think the right class already exists somewhere.  Do you know if there's one I should use?00:07
kfogelThis is for the table cells in the patches view.00:07
intellectronicakfogel: i have no idea. launchpad's css is a messy business, but look at the file and if you don't find one feel free to add00:07
kfogelintellectronica: "the file" is lib/canonical/launchpad/icing/style-3-0.css or lib/canonical/launchpad/icing/style.css00:08
kfogel?00:08
kfogelor somethig else? :-)00:08
intellectronicakfogel: lib/canonical/launchpad/icing/style.css, i think00:09
intellectronicathere's a section in it dedicated to the bugs application, so it should be ok to jsut add the class there00:09
lifelessthumper: poing00:11
kfogelintellectronica: oh, and I'm taking the "<!--" ... "-->" out of the script type=text/javascript block.  Thanks for the comment about the 90s calling :-).00:11
intellectronica:)00:12
=== mpt_ is now known as mpt
mwhudsonrockstar: if you *are* in the reviewing mood though, https://code.edge.launchpad.net/~mwhudson/launchpad/less-import-requestMirrors-bug-487357/+merge/1836100:16
rockstarmwhudson, I assume you're probably pretty lonely in your hemisphere currently, so I would review it even if I wasn't in the mood.00:17
mwhudsonrockstar: indeed; thanks00:17
lifelessmwhudson: ping00:22
lifelessmwhudson: I'm going to nag you as thumper seems awol. please see up about one page for the bug link  I threw at him00:22
kfogelintellectronica: what I'm going to do is make an integration branch with your branch, my brancha, and allenap's branch (adding patches view to persons/teams), and run that integration branch through EC2 tests.  I assume if we get review on the three branches, then when the integration branch passes tests, we can merge each of the three individually to devel, right?00:27
intellectronicakfogel: yups00:27
lifelesskfogel: or bomb the lot in :P00:30
kfogelintellectronica: want to review https://code.edge.launchpad.net/~allenap/launchpad/patch-report-for-people-and-teams-bug-506018/+merge/18414 ?00:30
kfogellifeless: well, how does one write the PQM submit message for that? :-)00:30
lifelesskfogel: "foo bar baz"00:31
kfogelI'm thinking what the combination of "[r=foo...]" on the front would be.00:31
kfogelah00:31
intellectronicaok00:31
kfogelmaybe I'll just do that00:31
kfogelintellectronica: thanks00:31
kfogelintellectronica: btw, do you need to get review on https://code.edge.launchpad.net/~intellectronica/launchpad/no-patches-message ?  (I am not a reviewer, unfortunately.)00:37
kfogel(s/unfortunately/fortunately/, as you please :-) )00:37
mwhudsonlifeless: thumper is in london00:38
intellectronicakfogel: i do need to get a review, yes00:38
kfogelintellectronica: is that something I can submit, or do you have to do it?  because if I could, I'd pick one of these gents currently in the channel (assuming cross-team reviews are kosher).00:39
intellectronicakfogel: wow, if you feel like doing that that would be super awesome, because i'm dying to go to bed00:39
intellectronicabut don't feel obliged00:39
mwhudsonlifeless: do you know if 2.1rc2 will be out soon and if it will have the fix?00:39
kfogelintellectronica: remember, I'm just submitting to someone else, not reviewing.  But sure, I'll create a merge proposal and point to some test data for them, etc.00:40
intellectronicakfogel: approved allenap's branch, b.t.w00:40
kfogelintellectronica: great!00:40
intellectronicakfogel: you rock00:40
* intellectronica --> zZz00:40
kfogelintellectronica: if tests pass, and the other branch passes review, then tomorrow we are all focused on the patch-age sorting, because IIUC that's the only thing left.00:40
kfogelintellectronica: good night!00:41
lifelessmwhudson: soon yes00:41
lifelessmwhudson: otoh this bug is going to be biting people, 2+ reports of it a day at the moment (judging by malone + hallway conversations here)00:41
mwhudsonhmm00:42
mwhudsoni wonder if the diff applies cleanly to the bzr we're currently running...00:42
lifelessyes, it will. its a tiny patch00:42
mwhudsonok cool00:43
kfogelmwhudson, thumper: will y'all be around, say, an hour from now?00:46
mwhudsonkfogel: i will, thumper won't (i really hope)00:47
wgrant+upgrade is severely lacking in the text department.00:49
wgrantAnd it seems to be letting me upgrade a branch on which others are stacked. That seems bad.00:49
kfogelmwhudson: I may hit you with an easy review request a bit later then :-)00:49
mwhudsonkfogel: ok00:49
lifelesswgrant: you have to be able to do that00:51
wgrantlifeless: Yes, but there's this nice clicky button with no explanation that will let me break everything.00:57
rockstarHuh, ec2 missed the fact that my branch wasn't up to date...00:57
mwhudsonrockstar: thanks00:59
mwhudsonrockstar: it's possible the branch hadn't been mirrored by the time ec2 grabbed it?00:59
rockstarmwhudson, no, my public branch was out of date.01:00
mwhudsonoh01:00
* rockstar shrugs01:00
lifelessrockstar: hi01:01
lifelessrockstar: so, the upgrade button seems to show up right after push until the branch is scanned01:01
lifelessrockstar: I presume the default value in the table causes it to be shown01:01
rockstarlifeless, :(01:01
rockstarlifeless, can you please specify that in the bug? I'll fix it tomorrow.01:02
lifelessrockstar: cool, thanks01:03
rockstarlifeless, no, thank you for reporting and following up on the bug.  I really appreciate it.01:03
lifelessanytime, its easy karma :)01:04
rockstarmwhudson, could we chat really quick?  I'm trying to figure out some of jml's suggested voodoo that I bet you know a lot about.01:06
mwhudsonrockstar: sure01:06
mwhudson(i've even found my headset now)01:06
rockstarmwhudson, yay!01:06
rockstarmwhudson, http://pastebin.ubuntu.com/367205/01:07
rockstarmwhudson, http://pastebin.ubuntu.com/367206/01:08
lifelessmwhudson: so you're going to cherrypick the fix ?01:18
mwhudsonlifeless: i guess i should01:18
* mwhudson tries to remember what the process is for using non-released versions of sourcedeps is01:19
mwhudsonrockstar: i'm not going to land the bzr upgrade until after this cp is sorted01:19
mwhudsonrockstar: so don't rush things on my account01:19
rockstarmwhudson, well, I was already rushing.  :)01:19
mwhudsonheh01:20
lifelessmwhudson: rockstar was landing another non released version for bzr-loggerhead01:24
lifelessmwhudson: so build on that :)01:24
lifelessmwhudson: for now, I'd like to assign the bug to you and bump to critical01:24
rockstarmwhudson, well, I'm actually doing one cherry pick at a time.01:24
rockstarIs there a dev wiki entry on landing against the production branches?01:39
kfogelmwhudson: https://code.edge.launchpad.net/~intellectronica/launchpad/no-patches-message/+merge/1842801:39
kfogelrockstar: does dev.launchpad.net/Trunk link to what you need?01:40
rockstarkfogel, no.01:41
kfogelrockstar: pity01:41
kfogel:-)01:41
rockstarkfogel, I'm looking for the instructions for landing against production branches.01:42
kfogelrockstar: they may not be in the dev wiki.  Is this different from landing against one of the four usual horsemen (db-devel, devel, stable, db-stable)?01:43
kfogelrockstar: i.e., I'm not clear on the shorthand "landing against production branches".01:44
rockstarkfogel, yes.  I need to land against what's in production right now.01:44
rockstarkfogel, none of those four are currently deployed.01:44
rockstarkfogel, AIUI, I submit to PQM with a release-critical against a production db.01:45
kfogelrockstar: you mean you need to land your change into production right away??  (Sorry, I'm not being deliberately dense, I'm just not clear on what you're trying todo.)01:45
rockstarkfogel, yes.  I have a high priority issue that needs to get cherry picked to production.01:45
kfogelrockstar: I'm not expert in this, having never done it, but I thought you just land the change on one of the regular trunks and then request a cherry pick.01:45
kfogelThe request can be by email?  check with mthaddon or someone who might know better.01:45
spmwhat kfogel said01:45
mwhudsonno, it has to be landed on production-devel01:45
mwhudsondoesn't it?01:45
spmerrr....01:46
rockstarmwhudson, yea, I think that's new.01:46
mwhudsonwhich ties up pqm for like 14 hours01:46
kfogelmwhudson: but that's what the cherrypick does, no?01:46
spmdon't you land against one of the rarely used, yet still in PQM branches?01:46
rockstarspm, yes, and I'm trying to figure out which one.01:46
mwhudsoni think there is much talking past each other going on here01:46
rockstarAfter it lands, I then beg a LOSA to deploy it to production.01:46
rockstarI'm just trying to find a wiki page on how to do it.01:46
mwhudsonrockstar: bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/production-devel01:46
rockstarmwhudson, thanks.01:47
kfogelmwhudson: (I don't think so; I think it just took a moment to figure out the goal)01:47
kfogelrockstar: this should be a note somewhere on dev.launchpad.net/Trunk01:47
lifelessmwhudson: https://bugs.edge.launchpad.net/bzr/+bug/513432 metadata twiddled.02:11
mupBug #513432: AttributeError: 'Inter1and2Helper' object has no attribute 'source_repo' <fetch> <Bazaar:Fix Released by mbp> <Bazaar 2.0:Invalid> <Bazaar 2.1:Fix Released by mbp> <Launchpad Bazaar Integration:Confirmed for mwhudson> <https://launchpad.net/bugs/513432>02:11
lifelessfor now, dinner time here.02:11
kfogelwowwwwwww... combination of "<<<<"  ">>>>" conflict markers and story test ">>>" lines is... dazzling to the eye.02:12
* kfogel rubs his eyes02:12
wgrantjames_w: Oh, 2.5 is going to be gone entirely?02:38
james_wthat's the plan02:38
james_w2.5->2.6 was less painful than 2.4->2.5 so there's less holding it back, and moving to 2.6 only means that we can move quicker towards python302:39
wgrantThe intention has been to only move LP to 2.6 once Lucid is out and the DC is upgraded.02:39
james_wthat could make things tricky02:40
wgrantYes.02:41
james_wwe can always stick 2.5 in a PPA for those couple of months, but it would obviously be better if there were fewer PPAs involved02:41
wgrantI think everybody thought that 2.5 would remain like 2.4 did.02:41
wgrantWe already have 2.5 rebuilds of most stuff in the PPA.02:41
kfogelmwhudson: any idea what this is about?  I see the import line right where the error message implies it is, but I have no idea what it means nor why it has never happened to me before :-).02:44
kfogelhttp://paste.ubuntu.com/367245/02:44
mwhudsonkfogel: make build?02:45
kfogelhttps://lists.launchpad.net/launchpad-dev/msg00071.html ...02:45
kfogelmwhudson: oh, hmrm.  I'd done successful 'make run', I thought.  But let me do make build, let's see.02:45
kfogelmwhudson: *embarrassment*02:46
kfogelmwhudson: my 'make run' was in the wrong branch.  nothing to see here, move along...02:46
thekornallenap, intellectronica, just in case anyone of you is still around, I got Person.searchTasks() working in my branch, it still needs some more tests, but I'm getting there03:34
kfogelthekorn: they're in bed (and I'm about to be) but they'll be on in the morning UK time03:35
thekornok03:36
mwhudsonkfogel: reviewed that branch, finally04:03
kfogelmwhudson: thanks.  I think I should have explained that only Tom Berger's changes needed review -- but actually, you've saved us time by reviewing a lot of my recent changes too :-).04:09
mwhudsonkfogel: oh04:09
mwhudsonwell, i just reviewed the diff :)04:09
kfogelmwhudson: I meant allenap, but same thing.04:11
kfogelmwhudson: yeah.  That's kind of a bug, in that "the diff" was the wrong thing.  I'm sure there was a way for us to set things up so it would be the right thing, but I didn't do that...04:11
kfogelmwhudson: no, I was right the first time: intellectronica, sorry04:12
Ursinhahey mwhudson, I have a question that you might know the answer04:35
mwhudsonUrsinha: shoot04:36
Ursinhamwhudson: what exactly sets the properties of a bzr revision?04:36
mwhudsonUrsinha: in what context?04:36
Ursinhamwhudson: I'm using bzrlib to get all the lp commits, one by one, and looking in its properties for the name of the "original" branch04:37
mwhudsonoh right04:38
Ursinhamwhudson: and I just hit one that has no properties set04:38
mwhudsonwell, there's the branch nick i guess04:38
mwhudsonUrsinha: in some sense, there's not much more of an answer than "bzrlib"04:39
Ursinhahm04:39
mwhudsonthere are some common properties, but none you can absolutely 100% rely on04:39
Ursinhamwhudson: I see04:39
mwhudsonparticularly given how old a codebase launchpad is04:39
UrsinhaI was counting on the branch-nick property, and then it exploded because a revision had no branch-nick property04:40
mwhudsonyeah04:40
mwhudsoni think you just have to cope with that case04:40
Ursinhamwhudson: I'm trying to find one alternative way to get the bugs related to a commit besides people having to add the bug tag to the commit message04:41
mwhudsonUrsinha: ah, i see04:42
UrsinhaI know that this is automagically added to the commit message when you use ec2 land04:43
Ursinhamwhudson: I think I'll keep relying on the commit message now the bug is added without intervention04:43
Ursinhado you have any ideas? :)04:43
mwhudsonUrsinha: not really04:44
Ursinhamwhudson: I mean, do you know a way of getting to a list of related bugs from a branch revision?04:44
mwhudsonUrsinha: well, if the associate was done with ci --fixes lp:12345 then it's a revision property04:44
mwhudsonif the fix was recorded in the web ui, then no, not from the bzr branch04:45
Ursinhamwhudson: I was thinking about getting the branch nick, then the owner, and searching for the original branch in lp, and getting the list of linked bugs...04:46
mwhudsonUrsinha: that would most likely work, i guess04:47
Ursinhamwhudson: yeah, that works but it's slow and if you don't have a branch-nick, it fails04:47
mwhudsonUrsinha: really, you want to get the branch with tip revid that of the rhs parent of the mainline commit04:47
mwhudsonUrsinha: which is easy if you have db access :-)04:47
Ursinhamwhudson: trying to understand what you mean here :)04:49
mwhudsonUrsinha: all mainline commits for launchpad are merges made by pqm04:50
mwhudsonso the revisions have 2 parents04:50
Ursinhamwhudson: right04:50
Ursinhapqm and the owner's04:50
mwhudsonthe second parent revid is the tip revision of the branch being merged04:50
mwhudsonso if you can find the branch with a given revid as its tip revid, you can find the merged branch04:50
Ursinhahmmmm04:51
mwhudson(well, probably, unless the branch has been deleted or something, but then you're SOL anyway)04:51
Ursinhamwhudson: so searching in the db for the branch using the tip revid04:52
UrsinhaI wonder if that's overkill now04:52
mwhudsonUrsinha: i think using the branch nick is probably a reasonable approach for now04:52
mwhudsonUrsinha: we could export "get me the branch with tip revid $foo" over the api i guess04:52
mwhudson(maybe it is already! but i doubt it)04:53
Ursinhamwhudson: that would be neat04:53
Ursinhamwhudson: I couldn't find it04:53
mwhudsonUrsinha: it's probably not there then04:53
UrsinhaI see I can search using the branch url or the unique name04:53
mwhudsoni don't think it's even an internal api04:53
Ursinhahm04:53
Ursinhamwhudson: is that bug 356360?05:01
mupBug #356360: API call for finding branches that contain a revid <api> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/356360>05:01
mwhudsonUrsinha: looks like it!05:02
Ursinhamwhudson: :)05:05
=== thekorn_ is now known as thekorn
noodles775Morning ppl08:25
al-maisanGood morning noodles775 :)08:25
wgrantMorning.08:25
thumpermorning08:29
thumperwgrant: I bet it isn't morning for you :)08:29
wgrantthumper: Not quite, no.08:29
thumpermwhudson: around at all?08:30
adeuringgood morning08:33
al-maisanmoin adeuring08:33
adeuringhi al-maisan!08:33
mwhudsonthumper: ish09:08
thumpermwhudson: what's the status of the bzr update cp?09:08
mwhudsonthumper: https://code.edge.launchpad.net/~mwhudson/launchpad/apply-fix-for-bug-513432/+merge/1843509:09
thumpermwhudson: was it branched from the production branch?09:10
mwhudsonthumper: no09:10
thumpermwhudson: I'll get flacoste to rc it09:10
thumpermwhudson: hmm09:10
mwhudsonthumper: but i think it'll cherrypick cleanly :-)09:10
thumperif you want to land on the production branch, you'll need that09:10
thumperwe don't tend to CP any more09:11
thumperwe just merge a branch into production09:11
mwhudsonsure09:11
mwhudsonbut merge into devel first?09:11
thumpermwhudson: yes, normally09:11
mrevellhi09:11
mwhudsonthumper: you can review it for that then :-)09:12
thumpermwhudson: you might want to replace the branch content with the same content but from the production revision09:12
thumperyep09:12
thumperdone09:14
thumpermwhudson: so land on devel and I'll have flacoste rc approve before lunch09:14
mwhudsonthumper: at the risk of sounding churlish, it's 22:14 here09:16
mwhudsonthumper: want to do it yourself?09:16
noodles775mwhudson: Enjoy your evening. I'm assuming there was nothing that stood out as drastically wrong when you went over the bfb ui?09:26
mwhudsonnoodles775: no indeed09:26
noodles775Great, thanks for that.09:26
* noodles775 writes the email to get wider feedback.09:28
intellectronicajames_w: the bad news are that your patch didn't land because of test failures. the good news is that looks like these are unrelated, spurious failures10:02
intellectronicasome good news...10:02
intellectronicamwhudson: thanks a lot for the review. i guess karl forgot to mention that mine was a tiny branch, dependent on his previous work?10:03
intellectronicamwhudson: anyway, you didn't make any comment about my work, so i'll interpret that as r=you and ask karl to look the rest of your comments. sorry that you had to do so much extra work (i'm sure the comments are valuable, though).10:06
=== matsubara-afk is now known as matsubara
thekornintellectronica, hey, I have Person.searchTasks working for the webservice API in lp:~thekorn/launchpad/make_iperson_ihasbugs, it already has two (doctest) testcases, I'm wondering how many of them do I need, and esp. where to put them11:15
jtvhenninge: what went wrong with my branch to check for unique template names?12:02
adiroibandanilos: Hi. Should I create a MP for bug 340664 , or since the performace issue is not solve, it is better to not push those changes?12:02
mupBug #340664: Add administration page for all POTemplates in ProductSeries or DistroSeries <ui> <Launchpad Translations:In Progress by adiroiban> <https://launchpad.net/bugs/340664>12:03
danilosadiroiban, sorry, in the meeting12:03
jtvhenninge: ahhh, let me guess: you ran into the problem before my fix had landed?12:03
jtvadiroiban: if there's a performance problem... it's not the one where Language is being queried far too often?12:03
adiroibanjtv: i don't think. This is for the +templates12:04
henningejtv: I had checked the revisions but mixed up some numbers ...12:04
adiroibanand afaik this is a long standing issue12:04
jtvadiroiban: makes sense, but thought I'd better ask12:04
jtvhenninge: right, I don't think it's on staging yet—it only just came out of EC2.12:04
jtvhenninge: s/staging/edge/12:05
asabilHi all12:05
jtvhello12:05
henningejtv: just two revisions missing, actually12:05
asabildoes anyone know that the download button on wide screens look bad ?12:05
asabil(the background image is not large enough)12:05
jtvasabil: thanks for the report... let me see if that's a known problem.12:06
asabilyou're welcom12:06
jtvasabil: looks like that one's not known yet... could you file a bug against the "launchpad" project and attach a piece of screenshot to illustrate?12:07
asabilyeah sure12:08
jtvthanks12:08
asabildone: https://bugs.launchpad.net/launchpad/+bug/51600012:13
mupBug #516000: The download button look bad on wide screens <Launchpad itself:New> <https://launchpad.net/bugs/516000>12:13
jtvasabil: great, thanks.  The people who would normally deal with this are in a meeting this week, so it could be a while before somebody gets to it.12:17
asabiljtv, yeah sure12:20
asabillooks like lazr.config is used in the launchpad code12:36
asabilanyone knows if it supports variables substitution ?12:37
jtvasabil: it doesn't afaik12:39
asabilok I see12:40
asabilthanks12:40
=== mrevell is now known as mrevellunch
danilosadiroiban, hi, sorry, in a live meeting here and get only short breaks from time to time :)13:04
adiroibandanilos: np. just ping me when you have more time. I want to know if I can continue with the implementation for some branches13:05
danilosadiroiban, anyway, I'd suggest you prepare an MP for 340664 and get it landed, it's still useful where it works13:05
adiroibandanilos: thanks. That is all for now13:07
danilosadiroiban, it was just a comment that we should definitely fix those performance problems as well (bug 475435)13:07
mupBug #475435: More timeouts on +templates page <timeout> <Launchpad Translations:Triaged> <https://launchpad.net/bugs/475435>13:07
=== mrevellunch is now known as mrevel
=== mrevel is now known as mrevell
noodles775Hi james_w, you mentioned in your email that you won't have time to continue the trigger work. I'm looking at continuing it (as I'll need the api exposure for some of the UI), but have a few questions.13:46
noodles775First, is there any reason that you didn't land your approved branch here: https://code.edge.launchpad.net/~james-w/launchpad/create-source-recipe-build13:46
noodles775And secondly, ah, I was going to ask about the inclusion of distroseries as an argument for requestBuild() (as defined on the iface), but then noticed that you haven't included it in the implementation?13:49
noodles775which ever way your intention was, I'd be keen to hear the argument behind it (ie. whether a build should be able to define a distroseries different to the recipe).13:50
=== jamalta-afk is now known as jamalta
=== salgado is now known as salgado-lunch
kfogeladeuring: btw, I forgot to list that I'm making screenshots for Jorge (today or maybe tomorrow)14:49
adeuringkfogel: noted ;)14:49
kfogelintellectronica: http://paste.ubuntu.com/367596/   has full results so far.  How on earth can it not have terminated after more than eight hours??14:50
intellectronicakfogel: because technology sucks?14:50
kfogelintellectronica: oh14:51
kfogelintellectronica: looking for failures now14:51
intellectronicasometimes our EC2 machines don't terminate. they have very strong will to live, i guess14:51
intellectronicait's worth looking at the mgmt console from time to time, because the costs can run very high if an instance is left running for many days14:51
intellectronica(i'm saying that from experience)14:51
kfogelintellectronica: "Failure in test test_inline_request_a_reviewer (lp.code.windmill.tests.test_branchmergeproposal_review.TestRequestReview)"14:51
kfogelintellectronica: *nod*14:52
intellectronicakfogel: i'd bet this is an unrelated spurious failure. we still get lots of those from windmill14:52
intellectronicalet's try to run the same test locally to verify, but most likely that's the case14:52
kfogelintellectronica: so, that failure appears after lots and lots of successes, including success of patches-view.txt.14:52
kfogelokay14:52
intellectronicayay14:52
kfogelintellectronica: how do I run a particular Windmill test?14:53
intellectronicakfogel: https://dev.launchpad.net/Windmill14:53
* kfogel hides his head14:53
kfogelintellectronica: thanks :-)14:53
intellectronicakfogel: crucial difference from the example is that it will be a different layer in this case. CodeWindmillLayer (iirc)14:54
intellectronicathe windmill tests for each subdomain run in a separate layer, because of the restrictions browsers place on accessing JS code over different domains14:55
=== matsubara is now known as matsubara-lunch
kfogelintellectronica: ah, gotcha14:57
kfogelintellectronica: running now.  Meanwhile, the EC2 test seems to be stuck at that spot -- there's been no more output, it just ends in the middle of a word....14:58
intellectronicaargh14:59
intellectronicahappened before. guess you'll have to kill that machine and fire a new test run.14:59
kfogelintellectronica: ok.  well, I was going to have to re-run anyway, what with the DB patch coming up and possibly a few more changes from me due to mwhudson's review, so no loss really.15:00
kfogelintellectronica: so test runs get stuck sometimes?  This is not unheard of?15:00
intellectronicayeah, it happened to me before15:00
kfogeloh goody, now my whole browser has frozen up15:01
intellectronicathat's not unheard of either ;)15:01
* kfogel snarkily observes that it never happens to him on his Debian box15:02
kfogelAlthough, I don't do Launchpad development on my Debian box either, so it's under considerably less strain :-).15:02
intellectronicabecause it only runs lynx? :P15:02
* intellectronica runs and hides15:02
kfogelYesterday I nearly shut down my whole Ubuntu laptop by running 'bzr log -v -n0 > outfile' in a devel branch.15:03
kfogelOH15:04
kfogelintellectronica: I didn't realize windmill tests actually display a browser dancing around!  This is spooky.15:05
intellectronicakfogel: yes. there's also a way to run them headless, under xvfb.15:06
intellectronicabut they have to run a browser to complete the test. that's the whole point of these tests - they interact with a real browser.15:06
kfogelintellectronica: sure, I just didn't know that that browser displayed on the screen.15:07
kfogelintellectronica: anyway, it passed15:08
intellectronicayes, for me too15:08
kfogelintellectronica: okay, I'm terminating this instance in Elasticfox.  Any reason I should show mercy?15:10
marsintellectronica, ping, could you help confirm a JavaScript bug for me?15:10
intellectronicamars: sure. what's the problem?15:12
asabilwhen running launchpad, how can I disable the creation of the thread-*.request files ?15:12
intellectronicakfogel: no, you should feel free to terminate it if you've lost all hope of getting anything useful from that machine15:12
marsintellectronica, try going to a bug on staging.launchpad.net, and edit the product.15:16
marsintellectronica, when I do so I see an infinite spinner15:16
intellectronicamars: yes, we've seen this problem before15:16
marsintellectronica, and if I have Firebug turned on to catch all errors, it does grab something15:16
intellectronicaoh?15:17
marsI can't make out the red error text though.  It is hidden by the long line.15:20
marsMaybe the error is also present in .dev15:20
intellectronicamars: sorry, back now15:40
intellectronicathere's a bug already filed about this, let me try and find it15:40
marsok15:40
intellectronicaoh, and i can reproduce on FF15:41
intellectronicamars: https://bugs.edge.launchpad.net/malone/+bug/44321715:43
mupBug #443217: Changing a bug's affected project or description doesn't ever finish <bug-page> <javascript> <ui> <lazr.restful:New for intellectronica> <Launchpad Bugs:Triaged by intellectronica> <https://launchpad.net/bugs/443217>15:43
kfogeladeuring: question about our "make_thing()" meta-factory function from patches-view.txt story tests.  That function has now moved to factory.py, and is LaunchpadObjectFactor.doAsUser().  In https://code.edge.launchpad.net/~intellectronica/launchpad/no-patches-message/+merge/18428, Michael Hudson asks: "Do you really need to commit here?  Zope-level users and database transactions are basically orthogonal."   Full context at http://pas15:44
kfogelte.ubuntu.com/367658/15:44
adeuringkfogel: yes, I think we must commit here. A story test does not access the database directly, but via a web server, which has its own database connection. When we manipulate the database via factroy.makeSomething(), the connetcion of the web server does not "see" any change, if we don't commit(). Also, I think we get an error message if we don't commit when the web server accesses the DB after a factory.mkeWhatever() call. Just re15:50
kfogeladeuring: thanks.  I'll respond to mwhudson with that.15:51
kfogeladeuring, intellectronica: advice: I'd like to change the "package" column to be called "target" in the patches view, because sometimes it's a package and sometimes it's a product (e.g., if you show the patches view on a project group).15:54
kfogelThoughts?15:54
adeuringkfogel: sounds good. But there is another option, ii think15:54
kfogel?15:54
adeuringyou can display "package", if the context is a distribution or distroseries,15:55
adeuringand you can display "project" if the context is a project group15:55
intellectronicakfogel: wouldn't it be better to title it dynamically, depending on what kind of target it is? i don't think we use 'target' anywhere in the UI.15:55
intellectronicaadeuring: high five!15:55
adeuringkfogel, intellectronica: though things will become messy with this approach when we have a patches view for persons...15:56
adeuringkfogel: ignoring the IPersoncontext, you could get the right column name for the current context from a browser class property.15:57
kfogeladeuring, intellectronica: So here's why I didn't propose the conditional solution: is it possible that the same view (same column) may display multiple types of targets?15:57
adeuringkfogel: yeah, now you mention this...15:58
adeuringif we have a bug with emough targets, that will happen...15:58
adeuringe.g., a bug where target 1 is a package and target 2 is a project15:58
intellectronicabut don't we only deal with one target at a time?15:59
kfogeladeuring: well, it's not a matter of quantity, it's just that it could happen -- heck, maybe I could make it happen right now with project group, by attaching a bugtask to a package in a project in that group?15:59
adeuringkfogel: sure15:59
kfogelintellectronica: let me see if I can actually make this happen here15:59
intellectronicai mean, doesn't the patches view filter only bug tasks for a single target (unless it's a distro)?15:59
kfogelintellectronica: distro, or project group,...16:00
adeuringintellectronica: but distros are the context where we need this "target/"Pakcages" column...16:00
kfogelintellectronica: and when the view is on a product, then it shows different src packages16:00
intellectronicain fact, maybe you also want to hide that column if it's not a distro or a project group16:00
kfogelintellectronica: we do16:00
kfogelintellectronica: that is, we hide that column whenever it's not applicable16:00
intellectronicacool, so i think you should be safe to use either 'project' or 'package' depending on the type of the context16:01
=== salgado-lunch is now known as salgado
adeuringintellectronica: really? If we run serachTasks() for a disto, are butasks for projects indeed not included?16:01
adeurings/butasks/bugtasks/16:02
intellectronicaadeuring: correct16:02
adeuringintellectronica, kfogel: OK, then it makes sense to display a more specific column title that "target"16:02
=== matsubara-lunch is now known as matsubara
adeuring...provided that distro-related bugtasks a not returened for IProject.searchTasks()16:03
=== jamalta is now known as jamalta-afk
intellectronicathe problem with 'target' is that users will confuse it with release-management. we never use target in the UI to mean what it means in the code16:03
kfogelintellectronica: good point16:04
kfogeladeuring: that's what I'm trying to confirm right now, re distro-related bugtasks, and also project-group-related bugtasks.16:04
=== jamalta-afk is now known as jamalta
kfogeladeuring: in https://bugs.launchpad.dev/evolution/+patches, we don't show the "Package" column.  Was this on purpose?  If there's a bugtask on a package related to the evolution product, do we not want to show that in bugs targeting evolution itself?  (I can see a case both ways...)16:06
adeuringkfogel: yes, because evolution is project (or IProduct)16:06
kfogeladeuring: "yes, we don't want to show package bugtasks" ?16:07
adeuringkfogel: well, let's double-check what searchTasks() returns in this case...16:07
kfogeladeuring: I'm trying to do that via the UI right now, yep.16:09
adeuringkfogel: bugs/model/bugtask.py, line 1492: extra_clauses.append("BugTask.product = Product.id")16:10
adeuringso, only bugtasks for the current project(IProduct) are retuned16:10
adeuringerm, returned16:11
kfogeladeuring: so trusting of the code... :-)16:11
adeuringyeah ;)16:11
kfogeladeuring: but yes, you're probably right.  I'm trying it in the UI anyway, just to make sure.16:11
adeuringkfogel: sure, that's always better, considering the famous remark by Mr. Knuth about proving corretness and testing code ;)16:12
kfogeladeuring: okay, I filed this with a patch attachment: https://bugs.launchpad.dev/ubuntu/+source/evolution/+bug/25 .16:12
mupBug #25: Allow discussion/commenting on translations <feature> <Launchpad Translations:Triaged> <https://launchpad.net/bugs/25>16:12
kfogelBUT, it does not show up in https://bugs.launchpad.dev/evolution/+patches16:12
kfogeladeuring: what's that remark?  I don't know it.16:12
adeuringsomething like "beware with the code above. While Iproved its correctness, I did not run it"16:13
adeuringkfogel: from /usr/share/games/fortunes/computers; Beware of bugs in the above code; I have only proved it correct, not tried it.   -- Donald Knuth16:17
kfogelnice :-)16:17
=== henninge_ is now known as henninge
jamaltaso i'm having this issue16:20
jamaltahttps://lists.launchpad.net/launchpad-dev/msg02281.html16:20
jamaltai've tried rocketfuel-get, but that doesn't seem to solve the problem16:20
jamaltaand running the mentioned script tells me "Bazaar Explorer requires QBzr. Please install it and try again." but i have both bzr-explorer and qbzr installed.16:20
marsjamalta, running rocketfuel-get complains about qbzr?16:22
jamaltanvm, i think i found my problem16:22
jamaltamars: no the utilities/update-sourcecode script16:23
jamaltamy problem is that rocketfuel-get was failing to download anything because of my proxy :)16:23
jamaltathis time it should be able to solve the problem16:23
lifelessjml: nice patch16:25
jamaltai lied, i still can't run launchpad16:29
jamaltai installed bzr-builder from apt, so i can import bzrlib.plugins.builder.recipe from the python interpreter16:29
jamaltabut make run still complaints it can't import it16:30
jamaltahere is what make run is giving me http://paste.ubuntu.com/367682/16:34
thekornjamalta, I had something similar yesterday, after running make clean & make this was solved for me16:37
jamaltathekorn: thanks16:38
jamaltathekorn: make fails with the same error :(16:45
lifelessdo you have builder in your optional bzrplugins dir ?16:49
jamaltalifeless: where is the optional bzrplugins dir?16:52
jamaltaignore that question16:53
jamaltathere is a broken symlink there16:53
jamaltahmm.16:53
jamaltathat explains a lot16:53
jamaltasourcecode/bzr-builder was gone16:54
jamaltas/was/is16:54
* jamalta sighs17:02
jamaltastill having the issue, this is strange17:02
jamaltaam i supposed to have a sourcecode/bzr-builder?17:20
jmljamalta, I think so.17:24
jmllifeless, the subunit-by-default one or the on-edge one?17:25
jamaltajml: So how can I get it? rocketfuel-get is not fetching it and I'm not quite sure how I lost it in the first place17:26
jamaltaUnless it was recently added, in which case, I don't have it17:26
lifelessjml: subunit17:26
jmljamalta, it was added recently, I think. I'm not sure about rocketfuel-get17:26
* jamalta has a feeling that's what scripts/update-sourcecode is for17:26
jmljamalta, yeah, run that.17:26
lifelessjml: the on-edge one is  intereseting too; I haven't read the code though, so can't comment about it so much :)17:26
jamaltajml: i can't17:27
jamaltaok now i can17:27
jmllifeless, heh heh.17:27
jamaltaHaving bzr-explorer installed on my system broke it for some odd reason17:27
jmlpoolie, can you please add a commit message to https://code.launchpad.net/~mbp/launchpad/436294-review-mails/+merge/1822717:28
poolieoh sure17:28
jmlpoolie, you don't have to bother with any of the tags.17:29
jmlpoolie, just something meaningful with no newlinesn17:29
pooliedone17:31
jmlpoolie, thanks.17:32
kfogeladeuring: (back from an early lunch)  So, TAL conditions can only be Booleans, right?  But I can do tal:condition="python: arbitrary python code here resulting in boolean"17:32
jmlpoolie, fwiw, if you have a commit message and an approved proposal, any Launchpad dev can land it with './utilities/ec2 land <merge_proposal_url>'17:33
jmlpoolie, so there's rarely an excuse for a delay in landing17:34
jmldev w/ commit access, I guess I should say. old habits die hard.17:34
kfogeljml: when one uses that script, the MP "commit message" is used as the commit message, right?17:34
adeuringkfogel: yes you can do that. But tal:condition can take anything that _evaluates_ to true/false17:34
jmlkfogel, mostly17:34
jmlkfogel, it also automatically does the [r=oaue][ui=aoueo][bug=4234,908034] stuff17:35
kfogeljml: ah, ok17:35
jmlkfogel, which I was sick of figuring out manually17:35
kfogeladeuring: here's what I'm solving: we're going to choose the presence or absence of that patches view column, and (if present!) choose its ("package" vs "project") in a conditional way.17:36
kfogels/its/its name/  sorry17:36
adeuringkfogel: I think the best readable version for this would be to add a property to the the browser.17:36
kfogeladeuring: "target_name" or something?17:37
kfogeltarget_type ?17:37
adeuringkfogel: right, or target_column_header_name17:37
kfogeladeuring: so the idea is, if browser.shouldShowTargetName is true, then we choose the column name based on that property17:37
james_wnoodles775: it's not landed as I don't have the rights to do so, and I think the review tweaks still need to be made17:38
adeuringkfogel: yes17:38
kfogeladeuring: beautifulicious17:38
kfogeladeuring: on it17:38
kfogeladeuring: what's status of patch-age-sort db patch?  landing today you think?17:38
adeuringkfogel: I'm still waiting for a second DB review...17:38
james_wnoodles775: and nice spot on the distroseries argument, it just needs to be removed from the interface17:39
adeuringkfogel: my point for using a browser property is: something "if IDistribution.providedBy(context)" in a tal expression tends to look quite ugly. And I am not sure if/how we can import IDistribution into a TAL expression...17:39
kfogeladeuring: I was considering a route where shouldShowTargetName() becomes a non-boolean method 'targetName()', and returns either a column name or None, and then the .pt file is adjusted accordingly.  Do you think that way is better or your way is better?17:41
kfogeladeuring: who was your first db review?  jml?17:41
adeuringkfogel: no, it was stub17:41
kfogeladeuring: rhetorically, just to shoot the breeze here in the channel, I will ask you if jml is aware of the urgency of this db patch getting in?17:42
adeuringahh, I see jml. jml, could you have a look at this mp https://code.edge.launchpad.net/~adeuring/launchpad/bug-512500-searchtasks-patch-age-sort/+merge/18446 ?17:42
adeuringkfogel: yes, you can do something like tal:define="target_name view/target_name" tal:condition="target_name"17:43
thekornhi allenap. does lp:~allenap/launchpad/patch-report-for-people-and-teams-bug-506018 in any way interfere with my work on making searchTasks() available for persons?17:43
adeuringkfogel: thouhg i need to double-check if these expression can go into the same XML tag17:44
kfogeladeuring: oh, if a TAL condition expr evaluates to None, then it is treated as false?  That's considered okay?17:44
allenapthekorn: No it won't, it'll be fine.17:44
adeuringkfogel: yes. I think an empty string also evaluates to False, for example17:44
kfogeladeuring: (style-wise, I mean)17:44
kfogeladeuring: in Python yes, but I never assume TAL == Python.17:45
noodles775james_w: great, I'll take it from there then. Thanks!17:45
thekornallenap, ok, super17:45
james_wthanks noodles77517:45
kfogeladeuring: $ python17:45
kfogelPython 2.6.4 (r264:75706, Dec  7 2009, 18:45:15)17:45
kfogel[GCC 4.4.1] on linux217:45
kfogelType "help", "copyright", "credits" or "license" for more information.17:45
kfogel>>> TAL == Python17:45
kfogelTraceback (most recent call last):17:45
jmlhi17:45
adeuringkfogel: yes, I think that's ok -- at least i would do the reveiw ;)17:45
kfogel  File "<stdin>", line 1, in <module>17:45
kfogelNameError: name 'TAL' is not defined17:45
kfogel>>>17:45
kfogelsee? :-)17:45
jmladeuring, kfogel: you have some stuff for me, I see :)17:45
jmlI'll take a look17:45
jmlit's got conflicts.17:45
adeuringjml: yes, this branch: https://code.edge.launchpad.net/~adeuring/launchpad/bug-512500-searchtasks-patch-age-sort/+merge/1844617:46
kfogeladeuring: and in the UI, the column name for a Product should be "Project", right?17:46
adeuringkfogel: yes17:46
adeuringjml: sigh, yes, I see the conflicts now too...17:47
adeuringjml: let me merge db-devel again17:47
jmladeuring, np.17:47
jmlhas this patch been discussed before?17:48
jamaltaAre API permissions defined by configure.zcml?17:52
allenapjamalta: Yes. But then see security.py for where the permissions are actually checked.17:54
jamaltaallenap: thanks17:54
jamaltaallenap: thanks!17:55
allenapjamalta: Welcome :) You might not be saying that once you've read security.py ;)17:56
jamaltaallenap: It's not too bad! I think I found what I needed actually17:56
jamaltaMuch easier than reading configure.zcml ;)17:57
adeuringjml: yes, I sent a mail to the lp-dev list (last Thursday, I think), and I discussed with stub some problems that we have without the schema change. Basically, it boils down to Storm bot supporting DINSTINCT ON (column name) and to nest query like SELCT * from (SELECT ... ) ORDER BY ...17:57
allenapjamalta: Cool.17:57
jmladeuring, ok, thanks.17:57
jmladeuring, it's all fine by me.17:58
adeuringjml:  great, thanks!17:58
* adeuring needs to restart X. windows are not properly redrawn. back in two minutes...17:59
allenapthekorn: Sorry, I'm just looking at your branch. I think the approach of moving IHasBugs.official_bug_tags into a new interface would be better than moving searchTasks().18:00
allenapthekorn: Person already implements all of IHasBugs because it inherits HasBugsBase, with the exception of official_bug_tags. I'm not sure why that was put on IHasBugs, it doesn't belong there, but I don't think it'll be a big job to move it.18:01
kfogeladeuring: I have this memory that the exact name "shouldShowTargetName" is something we used because it would have certain effects elsewhere, not merely to match a previously-existing view's method name.  Should I be worried about changing it to targetName or whatever?  http://paste.ubuntu.com/367724/ for kicks18:03
kfogelI see that lib/lp/bugs/templates/bugtarget-macros-search.pt uses it, but I'm not sure that matters for us, since it's presumably referring to the one in bugtask.py.18:04
allenapthekorn: A few changes are in my branch at lp:~allenap/launchpad/make_iperson_ihasbugs. I'll test it overnight and see what breaks.18:04
adeuringkfogel: I think we can choose any name, as long as we won't mess with bugtarget-macros-search.pt.18:05
* adeuring would prefer to do that, but others disagree18:05
kfogeladeuring: we haven't edited bugtarget-macros-search.pt AFAIK, so we shouldn't affect it.18:06
adeuringkfogel: xactly.18:06
thekornallenap, actually I'm fine with any solution, as long as the resulting person obect does not have an official_bug_tags attribute, I'll look what you have in your branch tomorrow18:10
thekornallenap, there is one thing left for me, I don't know how detailed the tests must be, how many of them are needed, and especially where to put them18:11
mptsinzui, are you available to talk about USC ratings and reviews?18:23
sinzuimpt: I may have time this week18:24
mptsinzui, we're getting kind of concerned since we have only two weeks until Feature Freeze18:26
sinzuimpt: I cannot start working on it until this weekend. I will not work on it during my core hours. My team must catchup the work it lost because of spammers18:27
jamaltaSo I'm looking into figuring out how to solve bug #515761 and I'm completely stumped. I can't find anything in configure.zcml and security.py that excludes public access to a project's series18:38
mupBug #515761: Not able to access project releases anonymously <launchpadlib :New> <https://launchpad.net/bugs/515761>18:39
jamaltaIs there something obvious I could be missing? I don't really want to waste anyones time with this :)18:39
james_wdid edge rollout in the last 12 hours?18:42
thekornallenap, I thought about what you said again, I we move official_bug_tags away from IHasBugs, I think we would have similar problems with getUsedBugTagsWithOpenCounts() and getUsedBugTags()18:50
thekornwhere should this methods go?18:50
kfogeladeuring: want to re-review https://code.edge.launchpad.net/~kfogel/launchpad/506018-patch-report ?  It's changed a lot.  (My latest comment on https://code.edge.launchpad.net/~intellectronica/launchpad/no-patches-message/+merge/18428 has details, actually.)18:57
adeuringkfogel: yes, I'll have a look18:59
kfogeladeuring: also, I think I should now make an integration branch that includes lp:~kfogel/launchpad/506018-patch-report, lp:~intellectronica/launchpad/no-patches-message, your branch (which should be attached to https://bugs.edge.launchpad.net/malone/+bug/512500 but isn't? :-) ), and lp:~allenap/launchpad/patch-report-for-people-and-teams-bug-506018 .19:00
mupBug #512500: In patches view, offer sorting on patch age. <story-patch-report> <Launchpad Bugs:Triaged by kfogel> <https://launchpad.net/bugs/512500>19:00
kfogelah, https://code.edge.launchpad.net/~adeuring/launchpad/bug-512500-searchtasks-patch-age-sort/+merge/18446, got it now19:01
adeuringkfogel: that branch went into ec2test just 30 minutes ago...19:01
kfogeladeuring: ah, ok.  But we still need to test all these things together, right?19:01
kfogelNo one has put all four branches together in one instance, AFAIK.19:01
* kfogel afk to put laundry in dryer, bbiab19:02
adeuringkfogel: if you simpyl merge tehse brnaches, I think sepaeate tests are not necessary. Only when you actually add more code, you'll need new tests19:02
* adeuring is afk for dinner19:03
kfogeladeuring: well, we shouldn't be adding more code; there are a couple of minor conflicts to resolve, but they're trivial.19:09
mwhudsonadeuring: i think you're mistaken about how page tests work, btw19:13
mwhudsonthere's no web server19:13
mwhudsonthe testbrowser talks to the publication code directly, there isn't network-level stuff19:17
sesammaseswhere in the code tree do I find the entry point for the "answers" subsite?19:27
mwhudsonsesammases: ./lib/lp/answers19:28
bacabentley: you indicate in the whiteboard that you were going to follow up on https://code.edge.launchpad.net/~davidcaste/eopsoa/trunk19:29
abentleybac, yes.  I actually wanted to talk to mwhudson about that.19:29
mwhudsonoh right19:30
sesammasesthx :)19:30
abentleymwhudson, are you on duty?19:30
mwhudsonabentley: yeah19:31
abentleymwhudson, skype?19:31
mwhudsonabentley: one sec19:31
mwhudsonabentley: ok19:35
abentleymwhudson, I don't see you on Skype.19:38
adeuringmwhudson: right, there is no "real" webserver, but I maintain that the "server side" of a pagetest uses a different DB connection that that we use directly in tests to manipulate test data19:53
adeuringkfogel: what is the revision of your branch that Tome reviewed?19:55
kfogeladeuring: oh, wow, let me see19:57
adeuringkfogel: sorry, didn't yet start th review -- had to fill my stomach first...19:58
kfogeladeuring: np (I was also (re)filling mine)19:58
abentleymwhudson, 51622219:59
kfogeladeuring: I *think* it was roughly http://bazaar.launchpad.net/%7Ekfogel/launchpad/506018-patch-report/revision/1017519:59
kfogelgive or take a rev or two19:59
adeuringkfogel: ok19:59
mwhudsonadeuring: i'm still a bit sceptical of that, but i can't be bothered to check now...20:01
kfogeladeuring: I'm getting tangled up here thinking about this question: if I want to put all four branches together just to do some manual testing, should I base the "root" branch from devel or db-devel?20:01
kfogelyours is the only one with db patches20:02
adeuringkfogel: ca't you simply merge one branch into [db-]devel, then merge the next brach and so on?20:02
adeuringmwhudson: are you sure that DB changes in page tests without  login() and commit() calls work?20:03
mwhudsonadeuring: you need to login() and logout() yes20:03
kfogeladeuring: oh, I'm trying that20:03
kfogeladeuring: can think of various reasons why it "shouldn't" work, but I'm probably over-theorizing.20:04
mwhudsonadeuring: but look at, say, the bottom of lp/code/stories/codeimport/xx-codeimport-view.txt20:04
adeuringmwhudson: oh, yes, now I get it. thanks!20:05
=== matsubara is now known as matsubara-afk
james_wany chance of a CP for the task_age fix? It's not on edge so I'm still blocked.20:13
kfogeldang it, bzr merge lp:~adeuring/launchpad/bug-512500-searchtasks-patch-age-sort/+merge/18446 should work!20:14
adeuringkfogel: yes, but then you can't any longer merge to devel, due to the DB patches in my branch20:14
kfogeladeuring: no, I mean merging a merge proposal should work20:15
kfogeladeuring: instead of a branch (i.e., treat it like the branch it refers to)20:15
=== salgado is now known as salgado-afk
adeuringkfogel: interesting...20:15
kfogeladeuring: Assuming all the branches have been approved, I can land them all with the appropriate "[r=foo]" from the MP, right?20:27
kfogeladeuring: and I land three of them on devel and one on db-devel, right?20:27
kfogeladeuring: (I'm not landing any until I've got the integration branch running here -- I want to see this stuff all play together first)20:27
adeuringkfogel: yes. But again, there is not real point yet for you to merge my branch, because it just contains the DB schema, no real code. I'll try to finish a branch that implements the new sort order for searchTasks() this evening.20:28
kfogeladeuring: oh!  I didn't realize that, sorry.20:29
kfogeladeuring: okay, then I won't try to land your branch.  But I _will_ try to get the others into devel today/tonight.20:29
adeuringkfogel: yeah, makes sense20:29
kfogeladeuring: though since I've just done the work, I'm going to run with your new db schema and see what happens :-).20:31
kfogeladeuring: people.canonical.com/~kfogel/patches-view/512500-current-dev-sql.diff in case you want my test data20:34
adeuringkfogel: no, sorry, need to focus now on my own brnach ;)20:34
kfogeladeuring: that's for your branch!20:37
kfogeladeuring: "I'm only trying to help you because I love you, honey..."20:38
adeuringkfogel: ah, sorry... my fault... seems to be too late for me proper read IRC channels...20:38
kfogeladeuring: except, it seems it's broken, one sec, trivial fix20:38
kfogeladeuring: okay, fixed up that diff.  And it's working for me, in an integration branch that includes your db changes.20:51
adeuringkfogel: great20:52
kfogeladeuring: http://paste.ubuntu.com/367826/  (some sample URLs under launchpad.dev for you)20:54
adeuringkfogel: thanks!20:54
kfogeladeuring: no problem.  oh, I think the "https://bugs.launchpad.dev/ubuntu/warty/+source/evolution" URL should be https://bugs.launchpad.dev/ubuntu/warty/+source/evolution/+patches20:55
kfogelsigh20:55
kfogelwill fix up and make a new reference paste20:55
Ursinharockstar: hi20:56
rockstarUrsinha, hi back20:56
kfogelhttp://paste.ubuntu.com/367828/20:56
Ursinharockstar: :) don't know if you saw jtv's request earlier today, about bug 35636020:57
mupBug #356360: API call for finding branches that contain a revid <api> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/356360>20:57
rockstarUrsinha, I did.20:57
rockstarUrsinha, I don't think that will happen for a while though.20:57
rockstarI started work on it, but after talking with thumper about the Revision table, it would be work that would just get removed.20:58
rockstarWe want to change how we gather revisions.20:58
Ursinharockstar: hm.. I see20:58
rockstarUrsinha, did you see abentley's comment?20:58
Ursinharockstar: let me explain why that would be useful20:58
Ursinharockstar: reading now20:58
rockstarHe (as usual) has a good point.20:58
Ursinharockstar: I need to know the merged branch to be able to get the bugs linked to it, right?20:59
rockstarUrsinha, yes.20:59
rockstarUrsinha, also, we put the bug numbers in the PQM commit message.21:00
Ursinharockstar: all this work would be to avoid that21:00
Ursinharockstar: it would be great if that never fails, but it does, so I'm trying to find another approach21:00
rockstarUrsinha, well, I'm not sure if we'll be able to provide a better approach soon.  :(21:01
Ursinharockstar: to migrate all teams to the tagging schema, we'd like to get rid of the wiki pages21:01
rockstarUrsinha, you could always mail thumper.  He's in London this week, but putting a bug in his ear about it being important for QA might help.21:01
Ursinharockstar: to get rid of the wiki pages, I'm searching for a safe approach to just ignore orphaned commits21:02
abentleyUrsinha, it should be easy to find all the merged branches.  If it's not, we can tweak the API.21:02
Ursinharockstar: so, it would be good to be able to rely on the bug added to the commit message by the ec2 script, but not everyone here uses that21:03
Ursinharockstar: what I found out is that I can get the branch-nick in the revision properties, but it turns out not all revisions have that21:03
Ursinhahaving the branch-nick, I can guess the branch url and search for it using the API21:04
Ursinharockstar: but not having that, I have no way out21:04
Ursinhaabentley: how?21:04
Ursinhaabentley: how to find the merged branches using bzrlib, I mean21:05
abentleyUrsinha, look for the merge proposals that are marked merged.21:05
Ursinhaabentley: how do I correlate that with the revision?21:06
abentleyUrsinha, why do you want to start with the revision?21:06
Ursinhaabentley: because when I see a new one in the branches I monitor (stable and db-devel) that triggers the tagging of the bug fixed by that21:07
Ursinhaunless I start to monitor the branches being merged instead of the main branches21:07
Ursinhaby main branches I mean stable and devel21:08
abentleyUrsinha, why not look at branches merged into stable and devel instead of revisions committed to stable and devel?21:10
Ursinhaabentley: could be an option, just haven't thought about that yet :)21:10
Ursinhaabentley: this revision thing is how it works today21:10
abentleyCode is already tracking which branches fix which bugs and which branches have been merged into their targets, so there's an opportunity to avoid double work here.21:11
Ursinhaabentley: good. I'll look into that21:12
Ursinhathanks for the idea21:12
Ursinhathanks rockstar21:12
abentleyNo problem.21:12
adeuringkfogel: sorting by creation date of most recnetly added patch is now possible in bugtarget.searchTasks(). lp:~adeuring/launchpad/bug-512500-model-change21:17
adeuringI'm still waiting for the base branch to run through ec2, so I'm not yet submitting this one for review.21:17
adeuringkfogel: simply use  bugtarget.searchTasks(orderby='latest_patch_uploaded')21:19
adeuringsigh.. I meant '-latest_patch_uploaded', for the +patches view21:19
mwhudsonabentley: https://code.edge.launchpad.net/~mwhudson/launchpad/ssl-imports-bug-512763/+merge/1847921:31
abentleymwhudson, what would you think about providing that comment on force_bzr_to_use_urllib as a docstring?21:34
mwhudsonabentley: i guess it's slightly better21:35
abentleymwhudson: r=me, preferably with that docstring.21:37
mwhudsonabentley: ok21:37
mwhudsonabentley: thanks21:37
abentleymwhudson, np.21:39
=== jamalta is now known as jamalta-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!