[00:10] spm: Around? bug #514074 has been going on for a few days now, and I think it's probably a sysadmin/LOSA thing. [00:10] Bug #514074: PGP fingerprint registration fails to find key [00:11] hrm. I have a sneaking suspicion I may know what's causing that.... [00:11] Is keyserver.internal not syncing with the rest? [00:42] do you know if there is some plan to upgrade the launchpad bzr branch to fix bug #513432? (I'm stuck for installing LP on lucid to expose some new element on the API) [00:43] Bug #513432: AttributeError: 'Inter1and2Helper' object has no attribute 'source_repo' [01:03] didrocks: you can't work around it? [01:07] james_w: I guess I have to init-repo 0.92 format, right? [01:07] so, change the lp-rocket script? [01:08] didrocks: I'll find you. [01:08] james_w: thanks, just one sec, getting some coffee right now :) [01:09] I can't see which branch would be problematic, though. [01:10] spm: Any luck? (I suspect this will affect me tomorrow, so I'm fairly interested) [01:10] wgrant: not yet unf; I'm about 2-3 layers down in higher priority interrupts atm. sorry... :-/ [01:11] Ah, right. [02:04] well, getting online in town was a bit more of an adventure than i expected [03:58] mwhudson, surprised. The nets were favourable at LCA. [03:58] abentley: yeah, it was a bit strange [03:58] abentley: i'm now in the library about 150m from the lca venue and it's working fine :) [03:59] :-) [04:01] i had a 70000 (yes 70 seconds) ping to python.org from the other place i tried [04:08] Does Wellington's Internet somehow break when it no longer has the extra load of 700 geeks? [04:14] it's possible the access points got rebooted more aggressively that week or something [04:20] right, time to go and see some dotty art [04:26] 150m ?? [04:26] I'm getting ~30kb/s between my two systems trying to doanlowd ~200MB [06:08] Anyone here who can do UI review? [06:21] stub: if code review has approved https://code.edge.launchpad.net/~kfogel/launchpad/506018-patch-report, and martin's UI review said "need fixing" but then I fixed all the things he said need fixing, is it okay to land it? [06:21] stub: my intuition is yes, but I don't want to step on any toes. [06:22] Need Fixing means they want to see it again. [06:22] stub: thanks. Second question is finding someone who can do UI review right now, then :-). [06:22] You can get Approved conditional on changing stuff [06:22] That wouldn't be me then :) [06:23] stub: ah, I see. [06:23] yeah, I wonder if the dev wiki lists ui reviewers, let's see... [06:26] stub: https://dev.launchpad.net/ReviewerSchedule pretty much everyone is EU/Americas right now. Oh well. [06:29] spm: okay, ready for some questions. http://paste.ubuntu.com/368019/ lists five branches, in various states of review (some can be landed now, some need review or re-review first). For the purposes of argument, let's say they're all approved already, so we can focus on the mechanics of landing. Three of the branches are against devel, two are against db-devel. The goal is to have the total (all five) live on staging. Would I land [06:29] the three devel ones on devel, the two db-devel on db-devel, and then... anything special to do after that? [06:30] I see I stumped him :-) [06:30] yup [06:30] I think I know the answer, just confirming :-) [06:34] ahh this is what I was looking for. it's moved. https://dev.launchpad.net/Trunk [06:34] yup. land on devel 1st; when that gets thru to db-devel; land against db-devel. from a high level. [06:34] Is there any point in landing the first one separately? [06:35] so it gets to edge? [06:36] or is your meaning; why not merge the 1st 3 into one mega merge? [06:36] It's not clear that the second and third are related, but they both include the first so landing it separately seems pointless. [06:37] ahh. that'd be code issues - /me hands that Q back to kfogel :-) [06:38] spm: one of these db-devel branches has no dependencies on the others, and is approved. I assume I can land that one now, right? [06:39] wgrant: as for how to land them, yes, I may do it all as one mega merge. [06:39] wgrant: point is, they all need to be approved first -- separately. [06:39] spm: specifically, https://code.edge.launchpad.net/~adeuring/launchpad/bug-512500-searchtasks-patch-age-sort/+merge/18446 seems approved. I'm not sure it's landed yet. I know it passes tests because I just ran them on a mega-integration branch :-). [06:40] if it hasn't landed, I'm going to land it [06:40] * kfogel issues fair warning [06:40] kfogel: ... [06:41] kfogel: yeah that looks fine; stub's given the nod and he's the one I know needs to care about db-devel landings [06:41] spm: oh, wait, I forgot to mention that there are *slight* conflicts (trivial) between some of these branches. I already resolved them once in my integration branch, so I may just land that when the time comes. [06:41] oh? [06:41] being ware that if BB can't merge; it'll reject [06:42] heh (evil grin ON) much a losa does when doing a manual merge..... [06:42] spm: what does "can't merge" here mean? If I've resolved the conflicts in my mega-integration branch, and that's the branch I land, then it's okay, right? [06:43] kfogel: rephrasing - if you submit a branch; and "something/one" goes to merge against their version of the code; and it fails. Boom. [06:44] spm: sure. But I don't see why it would fail to merge, in this case, that's all. [06:44] ie. you need to verify your branch (whichever one you submit) works as a merge against, eg, db-devel [06:44] spm: *nod* [06:44] so if it has a trivial conflict; it's still a conflict [06:44] kinda thing.... [06:45] spm: sure, but I resolved those (on the integration branch) [06:47] sweet, shouldn't be a problem then. and we can all igore the last 5 minutes of conversation. :-D [06:48] spm: interesting -- in all of db-devel, two revisions seem to have a pqm commit message of the form "[db=foo]"; all the rest use "[r=foo]" :-) [06:48] I'd put down a small wager that was eitehr one of us; or stub, getting bored. :-) [06:50] [db=foo] doesn't appear to be in the RE, so that should be fine [06:50] spm: sanity check: bzr pqm-submit --submit-branch=lp:~launchpad-pqm/launchpad/db-devel -m "[r=stub,jml][bug=512500] Add Bug.latest_patch_uploaded column, to allow efficient sorting by patch age." [06:50] looks good to me [06:52] spm: holy cow, PQM is backed up though. I guess this'll be landing in 2012 sometime. [06:53] oh oh.... [06:53] spm: btw, I got this error, because it's abel's branch not mine: [06:54] bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/~kfogel/launchpad/bug-512500-searchtasks-patch-age-sort/". [06:54] I don't see an option to pqm-submit to tell it "use ~adeuring/... instead of ~kfogel/..." though [06:55] Most people seem to use 'ec2 land' or push the branch up themselves. [06:55] I'm not sure if there's another way. [06:58] kfogel: https://wiki.canonical.com/InformationInfrastructure/OSA/LaunchpadRollout <== under prep there's a complete submit we/I use for config submissions. that may help? I've used that to land eg branches from francis. [06:58] spm: thanks [06:58] wgrant: I've already run through ec2, so don't want to reintroduce that delay [06:59] spm: hunh, looks like the '--public-location' option of bzr pqm-submit might be useful here. I've been trying to figure out what it's doc means :-). [07:00] "Use this url as the public location to the pqm." is not exactly crystal clear [07:02] spm: this worked (I think) -- http://paste.ubuntu.com/368037/ [07:02] kfogel: if any consolation, when I worked that recipie out istr I was almost at the level of bliding trying random configs in the hope something worked. :-) [07:03] s/bliding/blindly/ [07:03] spm: pqm is to code submission as reed snorkel is to traversing arctic sea under ice? [07:04] on the grounds of living near to lead dev for same - ie thumping range: No Comment. [07:04] spm: I'm a little worried -- pqm.launchpad.net says "Wed Feb 3 07:01:51 2010 UTC: Karl Fogel , Request for non-PQM managed branch." [07:05] spm: I was trying to land abel's branch *onto* db-devel, and I thought db-devel is a PQM managed branch. So why that message in the queue (currently #16, at the bottom)? [07:06] hrm. I suspect the syntax may be backwards on the submit; I'll check the mesg [07:07] spm: ack, sorry. I can redo w/ reverse values to the options... [07:08] kfogel: did you use "--submit-branch=ARG" ? [07:08] spm: you know, reverse values, like http://paste.ubuntu.com/368039/ (/me giggles) [07:08] al-maisan: I used both --submit-branch and --public-branch, and fear I messed it up. I'm submitting a branch of adeuring's, not my own branch. [07:09] * spm falls out of chair; hurts self laughing and sues the pants offa kfogel [07:09] --submit-branch is probably all you need [07:09] al-maisan: my exact command is here: http://paste.ubuntu.com/368037/ [07:09] al-maisan: no, that got an error (is backscroll available to you?) [07:09] * al-maisan looks [07:09] al-maisan: here, I'll clarify: [07:09] I originally did this: [07:10] 1) I branched lp:~adeuring/launchpad/bug-512500-searchtasks-patch-age-sort locally [07:10] 2) I cd'd into that local branch [07:10] 3) I ran this pqm submit command: bzr pqm-submit --submit-branch=lp:~launchpad-pqm/launchpad/db-devel -m "[r=stub,jml][bug=512500] Add Bug.latest_patch_uploaded column, to allow efficient sorting by patch age." [07:10] [07:10] That got me an error: [07:10] bzr: ERROR: Not a branch: "bzr+ssh://bazaar.launchpad.net/~kfogel/launchpad/bug-512500-searchtasks-patch-age-sort/" [07:11] ah [07:11] I see [07:11] al-maisan: ...okay, so it was looking in lp:~kfogel instead of lp:~adeuring. How to tell it to use the lp: branch where my local branch "came from", not the branch it "would go to" if I pushed? [07:11] just a second [07:11] al-maisan: so next, I tried http://paste.ubuntu.com/368037/ (just so you're up to date) [07:12] al-maisan: and that got the result that the PQM queue at pqm.launchpad.net has a weird message at the bottom of the queue now: [07:12] "Wed Feb 3 07:01:51 2010 UTC: Karl Fogel , Request for non-PQM managed branch." [07:12] al-maisan: that's where we are now. [07:13] kfogel: I believe for '--submit-branch' you should use the uri syntax from ~/.bazaar/locations.conf [07:14] al-maisan: bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel ? [07:14] i.e. --submit-branch=bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel [07:14] :-) [07:14] :) [07:14] spm: wanna get my dud out of the queue, and I'll try al-maisan's suggestion above? [07:14] sure [07:15] gone [07:15] kfogel: also, https://dev.launchpad.net/WorkingWithDbDevel [07:15] (fwiw, was prepping to do just that, figuring it'd be needed shortly) [07:15] spm: nice magic wand you got there [07:15] al-maisan: thank you! [07:15] * kfogel reads [07:16] last section: "Submitting to PQM" [07:18] Even Minotaur would be proud of the labyrinth called launchpad (development) .. *sigh* [07:19] * spm bows in admiration to al-maisan for THAT line [07:19] * al-maisan blushes [07:20] If you want to land abel's branch, you don't need to fake things with --public-location. Just tell pqm to land it (bzr pqm-submit -m 'comment' --submit-branch=bzr+ssh://... bzr+ssh://bazaar.launchpad.net/~abel/... [07:21] stub: just pass abel's branch as a direct argument? [07:21] Yes. bzr pqm-submit --help gives you the command line syntax [07:22] No need to stuff around with local branches - its not like pqm can access your hard drive. [07:22] stub: Thank you. Believe me, I've been poring over that help quite a bit :-). It doesn't make clear when one can/can't use the "lp:" shorthand, and the difference between --submit-branch and --public-location is not clear. [07:22] Glitches are bits of pqm can't cope with lp: urls and you need to explicitly specify --submit-branch because you likely haven't got abel's launchpad branches configured in your locations.conf [07:22] stub: yeah, I thought it looked in the local branch to divine the upstream lp branch to submit, but if there's a way to just tell it, then... no need. [07:23] right, I don't have anything in locations.conf about it [07:23] Use bzr+ssh: all the time for pqm - I think they work in some bits, but no idea which bits they are [07:24] stub: http://paste.ubuntu.com/368044/ [07:26] Bah [07:26] stub: if I did use --public-location, would adeuring's branch be the right arg to it? [07:29] Bah. Could have sworn that worked. echo "star-merge bzr+ssh://bazaar.launchpad.net/~abel/... bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/foo-devel" | gpg --cl | mail pqm@canonical.com -s "merge message" [07:29] kfogel: Might work with --public-location [07:29] stub: I'll try. I can always get spm to clean a dud out of the pqm queue again :-) [07:29] heh [07:30] stub: well, that seemed to succeed. let me see what pqm front page says about it. [07:31] looks good to me! item #16 [07:31] spm: seriously, though: should I worry about the size of that pqm queue? [07:31] kfogel: nope [07:31] we have a real landing taking place; and the tests are... slow [07:31] spm: ok [07:31] it's still doing real work [07:31] stub: thanks [07:32] yeah, most recent, just a few mins ago. slowly but surely... [07:33] Howdy people [07:34] hey noodles775 [07:35] hey noodles775 [07:35] * noodles775 waves to spm and kfogel [07:37] huh. that'd be why mwh and myself were able to attempt to break buildbot with impunity earlier; all the merges are stuck behind pqm. win. [08:07] beuno: ping [08:09] kfogel, hi [08:10] beuno: hey, morning [08:10] beuno: need some UI re-review on some branches. [08:10] beuno: actually, give me a sec and I'll point you to a mail with lots of nice info [08:11] beuno: this is all assuming you've NOTHING BETTER to do, of course :-) [08:11] kfogel, I still need to get out of bed [08:11] beuno: what are you doing on IRC, man?? [08:11] but if you give me a link, I will get to it within the next few hours :) [08:12] kfogel, danilo got to the bathroom first! [08:12] beuno: https://lists.launchpad.net/launchpad-dev/msg02411.html [08:13] beuno: that mail gives context for what's going on. The actual branches that need ui review are: [08:13] https://code.edge.launchpad.net/~allenap/launchpad/patch-report-for-people-and-teams-bug-506018/+merge/18414 [08:13] kfogel, cool, will feed back soon [08:14] https://code.edge.launchpad.net/~intellectronica/launchpad/no-patches-message/+merge/18428 [08:14] and a re-review for this one: [08:14] https://code.edge.launchpad.net/~kfogel/launchpad/506018-patch-report/+merge/18181 [08:15] beuno: re that mail: I'm writing a followup in which I de-confuse something that is very confused toward the end of the mail. sorry. It's late here. [08:16] and I'm still sleepy, so it should even out [08:18] heh [08:18] beuno: okay, followup sent [08:19] beuno: upshot is, there will probably be one more MP later that needs UI review ("patches view sorting by patch age" basically), in addition to the above. But the new one doesn't exist yet. [08:30] good morning [08:31] adeuring: heh [08:31] adeuring: I'm about to go to bed -- see my email. [08:31] adeuring: good morning :-) [08:31] adeuring: but before I go to bed, let's coordinate a bit maybe? [08:31] hi kfogel, must have been a long for you,.. [08:32] kfogel: yes, but let me find your mail first. [08:32] adeuring: well, it was punctuated by an amazing concert by Radu Lupu in Carnegie Hall, that's why I'm up now. [08:32] adeuring: https://lists.launchpad.net/launchpad-dev/msg02411.html [08:32] adeuring: note that right after, I send a followup that clarifies something confusing in the original post. [08:33] adeuring: (it's where I wrote the wrong summary line for the hypothetical merge proposal text; it'll be obvious) [08:33] adeuring: so, I'm going to go brush teeth and stuff while you read. I'll check back here in some minutes. [08:37] kfogel: do you have screenshots for the ui re-review of lp:~kfogel/launchpad/506018-patch-report ? [08:39] adeuring: no, but I could make them [08:39] adeuring: hey, let me brain dump at you briefly about conflict resolution: [08:40] adeuring: some subsequent changes of 506018-patch-report trivially conflict with the other branches for which it is a prereq. I've had to resolve them two or three times now, so I know them almost by heart :-). It's that in the story test, "user_browser" became "anon_browser", and "expected_contents" became "contents". [08:40] And in factory.py, we init is_patch to the "_DEFAULT" object instead of None now, and test for that. [08:41] there might be some others, but they're equally trivial if so [08:41] kfogel: ok. [08:41] adeuring: now, would you like some screenshots? [08:41] kfogel: na, i think you should go to bed ;) I'M trying to understand what i need to do today, except to get a review for one of my branches [08:42] adeuring: main thing, I think, is actually implement the UI for patch age sorting. [08:42] kfogel: right. [08:42] adeuring: it's actually easy for me to make the screenshots, let me do that. I have martin's three Ui comments right here in front of me anyway. [08:42] - Padding in the tooltips would be super nice [08:42] - I'd add an "Order by: " label to the ordering drop down, and drop the "by" from each option to improve readability [08:42] - Bug icons don't respect importance [08:47] adeuring: urrrrgh, just noticed a buglet: if you view patches by user: [08:47] https://bugs.launchpad.dev/~name16/+patches [08:47] the page says: [08:47] "Patch attachments in Foo Bar" [08:47] where Foo Bar is the person's name. [08:47] should be "for Foo Bar" or something. [08:47] kfogel: I like this ;) [08:47] you like the "in"? [08:47] kfogel: yes [08:48] adeuring: as a native speaker, I'm going to have to assert my authority here :-). [08:48] kfogel: yeah, I get the meaning .-- that's the reason why I like it [08:54] adeuring: okay, here you go: [08:54] http://people.canonical.com/kfogel/patches-view/screenshot-patches-view-distroseries-2010-02-03.png [08:54] http://people.canonical.com/kfogel/patches-view/screenshot-patches-view-no-patches-message-2010-02-03.png [08:54] http://people.canonical.com/kfogel/patches-view/screenshot-patches-view-orderby-dropdown-2010-02-03.png [08:54] http://people.canonical.com/kfogel/patches-view/screenshot-patches-view-padding-around-tooltip-has-orderby-label-bug-icon-respects-importance-2010-02-03.png [08:54] http://people.canonical.com/kfogel/patches-view/screenshot-patches-view-project-group-2010-02-03.png [08:55] kfogel: thanks! [08:55] adeuring: before I go to bed, are you set? [08:55] kfogel: yes ;) [08:56] adeuring: beuno should be coming back soon, and has the list of things needing UI review, but might be good to confirm with him. [08:56] Okay, I'm off. [08:56] adeuring: thanks! Sorry not to have had the new patch-age-sorting UI ready for you :-(. [08:56] kfogel: ok. BTW, I think my branch for sorting by patch age does not need a ui review, because it does not implement any UI chenages [08:57] kfogel: no problem with the patch age sorting still missing. [08:58] adeuring: (if I handed beuno your branch for UI review, it was an accident -- in fact, I think I *did* do that accidentally at one point, then deleted the MP right afterwards when I realized) [08:58] but you might have gotten an email about it [08:59] kfogel: ah, right, just tred to find that MP and got a 404 [08:59] :-) [08:59] adeuring: let beuno know that was an accident when he comes back, please :-) [08:59] kfogel: sure [09:01] adeuring: ok, g'night for realz. See you later. [09:01] Night kfogel [09:01] night noodles775 [09:01] night kfogel [09:01] * kfogel gets stuck in an infinite good night loop... [10:03] hi, after reading some launchpad code, I'm a bit confused. what is a Project, and what is a Product? [10:07] hmm, I think I got it now, it looks like for example "firefox" is called a "project" in the web UI, but internally it is implemented by IProduct [10:08] and IProject defines a super-project/project-group [10:09] thekorn: IProduct is what is called in the UI a 'project', and IProject is what is called in the UI 'project group'. confusing, eh? :) [10:10] hi all [10:10] it, is confusing! same with bug and tasks, in the web UI your can search for bugs, but get a list of tasks as the result [10:10] launchpad needs a glossar ;) [10:10] what's the difference between the lp_person table and the person table ? [10:11] thekorn: that's actually a good idea. maybe we should start one on the wiki [10:12] * intellectronica doesn't know :-O [10:12] yeah, let's called it "launchpad speech for n00bs" [10:12] -ed [10:16] anyone ? [10:16] asabil: stub would probably know, but i can't see him online at the moment [10:17] ok thanks, I will wait then [10:17] asabil: It's to do with integration with the Ubuntu SSO service. Ignore the lp_* tables. [10:18] (they should be identical copies of the corresponding non-lp_* tables -- eg. lp_person has the same content as person.) [10:18] wgrant, that's what I see, but I don't really understand the purpose [10:18] asabil: We can't see the code that uses them, so that's not surprising. [10:19] oki thanks === salgado-afk is now known as salgado [10:57] allenap, hi, I merged your official_bug_tags changes to my branch, now the xx-official-bug-tags.txt test is failing, http://paste.ubuntu.com/368114/ [10:57] do you have any idea what's going wrong there? [11:01] thekorn: I'll take a look.. [11:02] thank you [11:09] thekorn: It's because I made IOfficialBugTagTargetPublic.official_bug_tags read-only. [11:13] allenap, oh yeah, makking it readonly=False works [11:13] thekorn: Of course, other things break now :) [11:14] allenap, but in my understanding there are a few lines in registry/interfaces/product.py which make this field writable? [11:14] * allenap goes to look [11:15] around line 727 [11:16] thekorn: In r/i/distribution.py too. [11:16] thekorn: This is all a bit hacky and unpleasant. [11:29] allenap, ok, I don't think I have enough voodoo powers to understand what's going on there, and maybe to work around it, [11:30] thekorn: I think I've got something... I'll paste a diff in a minute or two. [11:30] wow great [11:30] thekorn: Well, more like 10 or 20. [11:30] take your time === henninge is now known as henninge-bbl === matsubara-afk is now known as matsubara [12:24] thekorn: Merge my branch again; it's got something that seems to work in it. === henninge-bbl is now known as henninge [12:55] can someone explain what is zopeless please ? [13:27] allenap, thanks. looking [13:58] allenap, super, I finally was able to merge your changes, it works great, (altought I don't get how this is different to the old hackish solution) [13:58] thanks again === jamalta-afk is now known as jamalta === henninge_ is now known as henninge [14:31] thekorn: Well, the difference is that it's less hackish ;) [14:31] allenap, ok, but this does not explain why it was not working the other way :) [14:32] thekorn: That's the magic of Zope! (Meaning, I will try and think of a better answer...) [14:34] allenap, anyway, it seems to work now, is something fundamental missing (or wrong), if not I think I will go an file a merge proposal for this branch [14:35] so I can get this searchTasks in, in a later branch I will try to add methods like searchCommentedTasks() ... [14:39] A/5 [14:42] thekorn: Go for it :) === salgado is now known as salgado-lunch [15:01] done, https://code.edge.launchpad.net/~thekorn/launchpad/make_iperson_ihasbugs/+merge/18523 [15:01] allenap, thanks again for your help, you helped me alot [15:02] thekorn: Cool, you're welcome, you're helping us a lot :) [15:43] hi rockstar === matsubara is now known as matsubara-lunch [16:11] bac, hi === salgado-lunch is now known as salgado [16:22] hi rockstar. nm, i was able to get help from abentley [16:23] bac, awesome. abentley is handy like that. :) [16:43] rockstar: When using "Resubmit proposal", can I change the merge target? [16:43] allenap, no, because then you're not resubmitting. Your submitting to another target. [16:45] rockstar: Ah, fair. (I'm trying to be constructively lazy when I submit to lp:launchpad when I mean devel.) [16:45] thekorn: The merge proposal for make_person_ihasbugs is proposed for merging into lp:launchpad, aka db-devel, so the diff is huge. You'll need to file a new proposal for devel. [16:45] allenap, yeah, I've done that a few times as well. I just delete the proposal and start over. [16:46] rockstar: Yep, me too. Thanks. [16:49] rockstar, allenap: We are planning to allow resubmitting with a changed target in the future. [16:51] abentley: That will be great. [16:53] rockstar, chat? [16:53] abentley, 5 mins? [16:53] rockstar, sure. Call me. === matsubara-lunch is now known as matsubara [17:01] adeuring: I haven't read all email yet, btw [17:02] kfogel: so, Martin ui-approved your main branch, and (implicitly) also the "no patches available" variant [17:02] my branches landed on db-devel [17:02] adeuring: both of yours? awesome! [17:02] adeuring: so the three devel branches still need to land, then? [17:02] intellectronica branched from your big-iintegration branch and added sorting by patch age [17:03] kfogel: yes, but i think we can just land tom's most recnet branch, if... [17:03] if we are sure that everything is reveiwed ;) [17:03] adeuring: ah, it has everything, right. [17:03] whew [17:03] adeuring: well, I'm doing that now: checking the review status on all the individual branches, then will look at tom's integration+sorting branch. [17:04] kfogel: cool. [17:04] beuno: can you mark https://code.edge.launchpad.net/~intellectronica/launchpad/no-patches-message/+merge/18428 as approved by you, since you implicitly approved that UI in another branch already? [17:05] adeuring: https://code.edge.launchpad.net/~allenap/launchpad/patch-report-for-people-and-teams-bug-506018/+merge/18414 has no UI review yet, and it's not clear to me if beuno or anyone else did persons/teams. [17:05] ? [17:05] kfogel: well, the presentation is the same as for the other variants [17:06] kfogel, done [17:06] adeuring: well, there is that "in" vs "for" issue we noticed last night [17:06] beuno: thank you! [17:06] kfogel: I think it's safe to not do a UI review. There are, however, some pending changes to that branch which abel noticed this morning. [17:06] allenap: pending changes? [17:07] kfogel: yes, the things you moticed earlier [17:07] kfogel: The title was wrong for people, and the target column was not showing up. [17:07] "patches in..." [17:07] allenap: so the necessary changes are in the branch now, or need to be made? [17:07] and i think that we should show the target on ~person/+patches [17:07] kfogel: I'm making them, and will be done soon. [17:08] adeuring, kfogel: you can land my branch, it's reviewed and all. it does require a test run, though i'm quite confident about it [17:08] adeuring: I'm actually a little curious, now that I think about it, about the meaning of ~person/+patches. Is it showing all patches for bugs which that person is somehow associated with, or...? [17:08] kfogel: i'll have to go away in an hour. are you cool to take over? [17:08] intellectronica: yes [17:08] intellectronica: your branch https://code.edge.launchpad.net/~intellectronica/launchpad/no-patches-message/+merge/18428 was part of my mega-test-run yesterday. [17:08] kfogel: yes, but don't ask me about details, what "associated" exactly means... [17:09] adeuring: IOW, it's about how a person/team "has bugs", whatever "has" means [17:09] kfogel: yes [17:09] adeuring: the issue, though, is what should the title of the target column be then? [17:09] kfogel: i have another branch, ~intellectronica/launchpad/sort-by-patch-age, which does what it says on the tin. that's the one i was referring to [17:09] adeuring: what if it can be both packages and products, for example? [17:09] intellectronica: ah, ok, thanks [17:09] kfogel: right [17:10] it can be packages and products... [17:10] adeuring: so, we need a better title :-) [17:10] so, "target"? [17:10] ugh [17:10] adeuring: loathe to use "target", since (as others have pointed out) it has a verb meaning for series and milestones. [17:10] or "package/product"? [17:10] prackuct? prodage? [17:11] kfogel: let's try that ;) [17:12] whoo boy [17:12] kfogel: but I wouldn't put too much effort into this detail right now. There isn't very much time left to run the ec2 test and to merge [17:13] kfogel: let's take something vaguely reasonable, like target, and replace it by a better word later [17:14] adeuring: *nod* [17:14] beuno: are you seeing above? I can summarize if you want. [17:15] kfogel, sorry, am not [17:15] beuno: I'll summarize, np: [17:15] what's up? [17:15] When seeing the patches view for a person/team, we're going to make two simple UI tweaks. [17:15] One is obvious: "Patches in J. Random" isn't a good page title, should be "Patches *for* J. Random". [17:15] I assume no controversy there :-). [17:16] The second is that there's a variable column in the view -- second from right column, it's sometimes called "Package" and sometimes called "Project" (meaning product) depending on the type of the view. But in the case of persons/teams, it can vary row-by-row, sometimes pkg, sometimes proj. [17:16] beuno: so, we're thinking we have to call it "target" for now, unless you can think of a better name. [17:17] the column, that is [17:17] (maybe "Task Target" ?) [17:17] kfogel, target I think is something we only know what it means [17:18] beuno: I know. I just can't come up with a better word right now. "Pkg/Proj" ? [17:18] "Package / Project" is awfully long. [17:18] kfogel, this is the table header? [17:18] beuno: right, column name in the table. [17:22] adeuring: okay, so I'd like to sketch out what comes next if you don't mind. [17:22] kfogel: sure [17:22] adeuring: first of all, we're done with db-devel, right? No worries there. [17:22] kfogel: right [17:23] adeuring: we now have four other branches to integrate [17:23] (one sec) [17:23] kfogel: well, they _are_ integrated, aren't they? [17:23] s/integrate/land/ [17:23] but one of them needs some code changes! [17:23] I don't actually have intellectronica's new branch; let me find it. [17:24] kfogel: i think allenap's branch is not yet merged into your big integration branch [17:24] oh, allenap's [17:24] adeuring: how much longer are you on? [17:25]