| kfogel | Anyone here who can do UI review? | 06:07 |
|---|---|---|
| === allenap changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: - || queue [henninge,jpds] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| allenap | henninge: I can't see a review on the queue for you, so I'll do jpds's now. | 10:43 |
| === allenap changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: jpds || queue [henninge] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | allenap: oh sorry, that entry is stale. But I am currently preparing a new MP, so I'll keep my spot in the queue ... ;) | 10:44 |
| allenap | henninge: Cool. | 10:46 |
| === salgado-afk is now known as salgado | ||
| === allenap changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: - || queue [jpds,henninge] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| allenap | I have not made any progress with jpds's review yet. | 11:45 |
| adeuring | beuno: could you have a look at kfogel's recent screenshots for the +patches view ( https://code.edge.launchpad.net/~kfogel/launchpad/506018-patch-report/+merge/18181 ) ? | 11:50 |
| beuno | adeuring, sure, I'll do it now | 11:52 |
| adeuring | beuno: thanks! I've added links to karl's recent screenshots in a comment | 11:53 |
| beuno | adeuring, thank you for that | 11:56 |
| beuno | adeuring, done | 12:07 |
| adeuring | beuno: thanks! | 12:07 |
| henninge | allenap: my mp is ready now but I will go to lunch. We can talk later. ;-) Thanks. | 12:11 |
| === henninge is now known as henninge-bbl | ||
| === matsubara-afk is now known as matsubara | ||
| jpds | allenap: Here's a screenshot of my changes: http://people.canonical.com/~jpds/2010-02-03-121355_1280x800_scrot.png | 12:15 |
| allenap | jpds: I'm really sorry, I haven't looked at your branch at all; I got stuck on other things. Assuming it lp:~jpds/launchpad/fix_361650, then I think you should go back to the reviewers who've already seen it. In this case you'll need to talk to noodles775 and sinzui. I suspect sinzui1 will not be available much this week, so I can try to step in for him if you would like. | 12:19 |
| jpds | It was ~jpds/launchpad/mirror_pages_v3 | 12:20 |
| jpds | allenap: Actually, it looks like sinzui1 has claimed the review, I'll leave it with him. | 12:21 |
| === jpds changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: - || queue [henninge] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| allenap | jpds: Ah ha, well that's a different kettle of fish altogether :) | 12:21 |
| allenap | jpds: It wasn't appearing on the view I use because it didn't have a review request for me or a team I'm in. I've added it, and I'll do it after lunch. Sadly, I cannot do UI reviews, but several people can, for example intellectronica and noodles775. | 12:23 |
| jpds | allenap: fix_361650 needs, err, fixing, which I'll do later on. :) | 12:24 |
| allenap | jpds: Hehe :) I'm going out now, but I'll be back in <2h, and other reviewers may turn up too, so one way or another your branch will be reviewed today. | 12:26 |
| === henninge-bbl is now known as henninge | ||
| * henninge is back | 12:50 | |
| === jamalta-afk is now known as jamalta | ||
| === henninge_ is now known as henninge | ||
| abentley | allenap, could you please review https://code.launchpad.net/~abentley/launchpad/ampoule-0.1.1/+merge/18481 ? | 14:16 |
| allenap | abentley: Sure, sounds interesting :) I have jpds's to do first, but I don't think it will take long. | 14:31 |
| === allenap changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: - || queue [henninge, jpds, abentley] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| abentley | allenap, thanks. | 14:32 |
| === salgado is now known as salgado-lunch | ||
| intellectronica | who wants a review? | 15:37 |
| intellectronica | allenap: do you really have 3 more in the queue? | 15:37 |
| allenap | intellectronica: Yeah, I've been stuck on trying to get the production-devel builder to work, so please talk to henninge. Thank you. | 15:38 |
| intellectronica | are you suggesting that i talk to henninge about reviewing my branch? | 15:39 |
| henninge | lol | 15:39 |
| intellectronica | i'm not sure i can offer my help with reviews just now, if that's what you meant. sorry. | 15:39 |
| henninge | intellectronica: if your's is not too big, we can trade reviews ... | 15:40 |
| * henninge goes to look how big his is .... | 15:40 | |
| intellectronica | henninge: mine is 154 lines, and most of that boring test updates | 15:40 |
| henninge | intellectronica: ok, mine is 217, not quite as trivial. You chose ... ;-) | 15:41 |
| intellectronica | henninge: i'll review your branch | 15:43 |
| === gmb changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: - || queue [henninge, jpds, abentley, gmb] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | just creating an MP now | 15:43 |
| * gmb reads scrollback. | 15:44 | |
| gmb | Ah. | 15:44 |
| intellectronica | henninge: this is a bit urgent, so i'm assuming you can do it immediately. if you can't, please tell me and i'll find another reviewer | 15:44 |
| gmb | allenap: I'll take a wild stab and guess that the chances of you getting through that queue this afternoon are very low | 15:44 |
| gmb | allenap: Want me to take jpds's branch, since intellectronica's already taking care of henninge's? | 15:44 |
| henninge | intellectronica: going right to it | 15:44 |
| allenap | intellectronica: Oh right, I got the wrong end of the stick. | 15:44 |
| intellectronica | henninge: wonderful. thanks a lot for offering this review. https://code.edge.launchpad.net/~intellectronica/launchpad/sort-by-patch-age/+merge/18531 | 15:46 |
| intellectronica | henninge: do you have an MP for your branch? | 15:46 |
| henninge | intellectronica: https://code.edge.launchpad.net/~henninge/launchpad/bug-515680-status/+merge/18517 | 15:47 |
| henninge | intellectronica: thanks | 15:47 |
| intellectronica | henninge: cool, i'm on it | 15:47 |
| === matsubara is now known as matsubara-lunch | ||
| allenap | gmb: Yes please, that would be awesome. Thank you indeedy. | 15:48 |
| gmb | allenap: I'm on it. | 15:50 |
| === gmb changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: - || queue [abentley, gmb] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| intellectronica | oh wow, looks like MPs now generate the correct diff if you include a dependent branch | 15:51 |
| intellectronica | i lurve launchpad code! | 15:51 |
| intellectronica | rockstar: ^^^^^ | 15:51 |
| === allenap changed the topic of #launchpad-reviews to: on-call: allenap || reviewing: abentley || queue [gmb] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | intellectronica: I am not familiar with the patch report. Do you have an example? Is it on edge already? | 15:56 |
| intellectronica | henninge: i'm not sure it's on edge already. you can give it a try by going to launchpad.dev/product-name/+patches | 15:57 |
| intellectronica | but it's only interesting if there are some bugs with patches in the project | 15:57 |
| henninge | I figured ... ;) | 15:58 |
| intellectronica | henninge: sorry, hard as i tried i could not find even a single flaw in your branch | 16:01 |
| intellectronica | i'm afraid i'll have to approve it | 16:01 |
| intellectronica | maybe next time | 16:01 |
| henninge | rats, now I have to land it! | 16:01 |
| henninge | ;-) | 16:01 |
| henninge | intellectronica: thanks! | 16:01 |
| henninge | intellectronica: what's with the leading "-" on the orderby values? Is it to indicate inverse ordering? | 16:02 |
| intellectronica | henninge: exactly | 16:05 |
| intellectronica | it's the same format that is used on bug searches. a bit funny, i know | 16:05 |
| henninge | intellectronica: consistency is cool | 16:06 |
| henninge | intellectronica: but not all possible orderings are allowed, right? | 16:07 |
| henninge | intellectronica: ok, got it now. The value is coming from a drop-down list, so the choices are limited. | 16:09 |
| henninge | I was thinking of table headers with little arrows ... ;-) | 16:09 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: allenap, Edwin || reviewing: abentley || queue [gmb] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | intellectronica: now that I understood it, I had to approve it. ;-) | 16:10 |
| intellectronica | henninge: fanks! | 16:11 |
| === salgado-lunch is now known as salgado | ||
| EdwinGrubbs | gmb: are you looking for someone to review your process apport blob job branch? | 16:17 |
| gmb | EdwinGrubbs: Yes. | 16:17 |
| === allenap changed the topic of #launchpad-reviews to: on-call: allenap, Edwin || reviewing: -, gmb || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | EdwinGrubbs: Excellent, thank you :) | 16:18 |
| allenap | EdwinGrubbs: I just put your name down in the topic for gmb's branch, but I'm free too and very happy to take it if you want to do something else. I've been rather a negligent reviewer today. | 16:18 |
| * gmb notes he should *acutally read* the full "$foo has changed the topic..." notices | 16:19 | |
| EdwinGrubbs | allenap: I can take it. Thanks for offering. | 16:20 |
| === matsubara-lunch is now known as matsubara | ||
| EdwinGrubbs | gmb: do you get any errors when you try to set _json_data to a str object instead of a unicode object? | 17:10 |
| gmb | EdwinGrubbs: Yeah, that's why I do the conversion. | 17:14 |
| gmb | I can't remember the exact error though. Hang on... | 17:14 |
| EdwinGrubbs | gmb: since launchpad doesn't override the default encoding unicode(foo) will raise an exception if foo contains any non ascii characters. You can decode utf-8 characters correctly with unicode(foo, 'utf-8') | 17:16 |
| gmb | EdwinGrubbs: Ah, good point. | 17:16 |
| gmb | Thanks. | 17:16 |
| gmb | EdwinGrubbs: Yeah, trying set _json_data to a str just gets me a TypeError. | 17:17 |
| === jamalta-afk is now known as jamalta | ||
| EdwinGrubbs | I don't think I'll be able to keep my composure if I read job_for_blob any more. | 17:32 |
| gmb | Hmm. A poor choice of var name, in hindsight... | 17:44 |
| gmb | Although it was nearly called blob_job. | 17:45 |
| gmb | Which is just too open to typos. | 17:45 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on-call: Edwin || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| thekorn | hey, who wants to review a small string change in launchpadlib? - https://code.edge.launchpad.net/~thekorn/launchpadlib/add_tilde_to_url/+merge/18552 | 19:44 |
| === salgado is now known as salgado-afk | ||
| leonardr | thekorn: r=me | 21:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
