=== matsubara-afk is now known as matsubara
[10:11] <henninge> Any reviewers around that could review https://code.edge.launchpad.net/~henninge/launchpad/bug-516739-needs-information/+merge/18693 for me, please?
[10:14] <henninge> jtv: want some fun? ^
[10:14] <henninge> ;-)
[10:14] <jtv> henninge: sure
[10:19] <jtv> henninge: for the docstring on NEEDS_INFORMATION may I suggest, "The reviewer needs more information before this entry can be approved"?
[10:19] <henninge> fbm
[10:20] <henninge> = "Friday's Big Meeting" according to the GTF ... ;-)
[10:21] <jtv> which is a really nice kind of online novel, highly recommend it.
[10:22] <jtv> henninge: I'm puzzled by the tests... they list statuses A B D F I NR NI in that order.  But that's not the order they have in the enum.
[10:23] <jtv> Should be A I D F NR B NI
[10:23] <jtv> And the tests do expose that difference...
[10:23] <henninge> jtv: yes, I did not look at the enum. There is a comment on it in the test.
[10:23] <henninge> which difference?
[10:23] <jtv> Maybe they're sorted by name somewhere in the test?
[10:24] <jtv> But in that case NR and NI should be the other way around.
[10:24] <henninge> jtv: right, that's what I did! ;-)
[10:24] <henninge>         # Could iterate RosettaImportStatus.items but listing them here
[10:24] <henninge>         # explicitely is better to read. They are sorted alphabetically.
[10:25] <jtv> s/explicitely/explicitly/g
[10:25] <jtv> So that comment is wrong now.
[10:25] <henninge> no, my ordering. I will fix that.
[10:26] <henninge> Eclipse even marked the wrong spelling on explicitly ... ;)
[10:28] <jtv> nice :)
[10:28] <jtv> OK, r=me, I'll make it official.
[10:30] <jtv> For some reason I missed the box where I could set the review type, sorry
[10:31] <henninge> jtv: you can still edit your vote
[10:31] <jtv> ah yes, that lets me set it
[10:31] <jtv> all done.  I've got to run to catch that train
[10:31] <henninge> jtv: thanks and enjoy FOSDEM!
[10:32] <jtv> thanks!
[10:32] <jtv> you'll have to entertain ursula today.  :)
[10:32] <henninge> I will, no worries ... ;-)
=== salgado changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
[12:38] <sinzui> BjornT: https://code.edge.launchpad.net/~barry/launchpad/rnr-techdebt/+merge/18696
=== deryck is now known as deryck[lunch]
=== mrevell is now known as mrevell-lunch
=== deryck[lunch] is now known as deryck
=== jamalta-afk is now known as jamalta
[14:09] <jamalta> salgado: hey there, want to do a review for me? :) fibiger
[14:09] <jamalta> err
[14:09] <jamalta> https://code.edge.launchpad.net/~jamalta/launchpad/515761-anonymrelease/+merge/18641
[14:09] <jamalta> had the wrong thing on my clipboard, sorry
[14:09] <salgado> heh. no worries
[14:11] <salgado> jamalta, well, it's been reviewed already?
[14:11] <jamalta> salgado: yes, rockstar said it needs fixing
[14:12] <jamalta> he just wanted me to create a class that defines anonymous access to inherit from, instead of repeating the same thing over and over
[14:12] <jamalta> also, i'm supposed to bring up any security concerns with opening these items up for webservices
[14:13] <jamalta> i haven't talked to anyone specifically regarding security but it seems in general these items should be open
[14:13] <jamalta> considering, they are available to unauthorized users through the web frontend
[14:13] <salgado> jamalta, cool, in that case you can just send him the incremental diff and he should approve your branch
[14:13] <jamalta> salgado: rockstar?
[14:14] <salgado> jamalta, yeah, but they might be public by accident in the web UI, although that's unlikely.  maybe send am email to launchpad-dev@?
[14:14] <jamalta> salgado: sounds good, i will confirm that
[14:14] <salgado> jamalta, yeah, he's reviewed your branch already, so he'll just have to check the changes you did since his review.
[14:14] <jamalta> salgado: sounds good, sorry for bugging you then
[14:14] <salgado> no worries
=== matsubara is now known as matsubara-lunch
[14:29]  * maxb has a nice tiny MP, when someone has a moment https://code.edge.launchpad.net/~maxb/launchpad/py2.6-importfascist/+merge/18646
[14:30] <leonardr> rockstar, are you around for another review in the multiversion series?
[14:38] <salgado> maxb, approved
[14:38] <maxb> thanks. Will you land it?
[14:39] <salgado> sure
[14:39] <maxb> Maybe one day someone will sort out a publicly accessible PQM :-)
[14:39] <salgado> does it have a commit message?
[14:40] <salgado> maxb, ^
[14:40]  * maxb adds one
[14:41] <maxb> "Accept and propagate a 'level' parameter in importfascist. (New feature in Python 2.5, helps compatibility with 2.6)" sound ok?
[14:41] <maxb> I've saved that in the MP
[15:10] <leonardr> rockstar: when you come in, https://code.edge.launchpad.net/~leonardr/lazr.restful/multiversion-mutators/+merge/18702
=== matsubara-lunch is now known as matsubara
=== salgado is now known as salgado-lunch
=== noodles775 changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: - || queue [noodles] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
[15:47] <noodles775> salgado-lunch: easy one for when you get back: https://code.edge.launchpad.net/~michael.nelson/launchpad/513201-move-recipe-to-code/+merge/18703
=== salgado-lunch is now known as salgado
[15:56] <rockstar> leonardr, I'm on it.
[15:58] <leonardr> rockstar, tx
[15:59] <rockstar> jamalta, I'll get to yours next.
[15:59] <jamalta> rockstar: thanks! :)
[15:59] <salgado> noodles775, approved
=== salgado changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
[15:59] <noodles775> Thanks salgado
=== jelmer changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: - || queue [jelmer] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
[16:14] <jelmer> salgado, hi
[16:14] <salgado> hi jelmer
[16:15] <jelmer> salgado: Can you perhaps review this branch: https://code.edge.launchpad.net/~jelmer/launchpad/sync-tbz2/+merge/18615
[16:17] <salgado> wow, that's a big one
[16:17] <salgado> jelmer, sure, I can do it
[16:23] <leonardr> rockstar, taking a short subway ride, biab
[16:23] <rockstar> leonardr, no sweat.
=== salgado changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: jelmer || queue [-] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
[16:36] <jelmer> salgado: thanks!
[16:37] <rockstar> jamalta, you don't really need to post an incremental diff.  The diff on the merge proposal page gets updated, and that makes it easier for me to read the changes anyway.
[16:37] <rockstar> The incremental diff was a method we had when merge proposals sucked.
[16:37] <jamalta> rockstar: alright.. i'm having difficulty keeping up with how everyone likes things :(
[16:37] <salgado> jelmer, so, we already support orig.tar.bz2 uploads and your branch is only fixing the script which syncs packages from debian?
[16:37] <jamalta> a previous reviewer said he prefers an inc diff with the changes
[16:38] <jamalta> ohh! ok
[16:38] <jamalta> that makes sense then, thanks
[16:38] <jelmer> salgado: yep, exactly
[16:41] <salgado> cool, I got confused by the bug description
[16:45] <thekorn> hi, how is this review process in this channel working? - if it is just posting the like and be patient, here it is: https://code.edge.launchpad.net/~thekorn/launchpad/fix-tagcombinator-517570/+merge/18706
[16:45] <thekorn> but it is not urgent ;)
[16:46] <jamalta> thekorn: there's usually an on-call reviewer (in the topic) and they keep up a queue... from what i understand you usually ping them with your MP and they'll let you know when they can get to it
[16:47] <jamalta> rockstar: thanks so much! :)
[16:47] <jamalta> would you be able to land it too?
[16:47] <thekorn> aha, ok, salgado if you have some time, can you please have a look at my MP above
[16:47] <thekorn> thank you!
[16:49] <thekorn> and btw, when I'm working on a bug, is it ok to assign this but to me and mark it as "in progress" ?
[16:49] <rockstar> jamalta, I can. Give me a bit.
[16:49] <jamalta> rockstar: sure thing, no rush at all.. whenever you have time
[16:50] <salgado> thekorn, I'm currently doing a big one for jelmer, so I might not get to yours.  if that's the case, I'm sure someone else will be able to review it either today or Monday, though
[16:52] <thekorn> salgado, ok cool. again it is not urgent, just wnated to make sure I'm following the correct process here
=== jamalta is now known as jamalta-afk
[16:59] <leonardr> rockstar: thanks for the review
=== jamalta-afk is now known as jamalta
=== salgado changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: thekorn || queue [-] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
=== EdwinGrubbs is now known as Edwin-lunch
[18:24] <salgado> thekorn, just approved your branch; do you want me to land it for you?
=== salgado changed the topic of #launchpad-reviews to: on-call: salgado || reviewing: - || queue [-] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
[19:01] <thekorn> salgado, yes please
[19:01] <thekorn> salgado, thanks alot
[19:02] <salgado> thekorn, can you set a commit message in the merge proposal?
[19:02] <thekorn> sure, give me a few
=== matsubara is now known as matsubara-afk
[19:05] <thekorn> salgado, done
[19:08] <jamalta> salgado: do you have time for a quick chat?
[19:08] <jamalta> salgado: after you're done with thekorn of course
[19:10] <salgado> jamalta, sure, what's up?
[19:12] <jamalta> salgado: well, i make silly mistakes that screw up the total in https://dev.launchpad.net/Contributions
[19:12] <jamalta> so i was wondering what you thought of doing something like this http://paste.ubuntu.com/369688/ to the contributions script
[19:15] <salgado> jamalta, I think that's ok
[19:15] <jamalta> salgado: cool! can I push a branch and make an MP for you to review then?
[19:16] <salgado> sure
[19:19] <jamalta> salgado: awesome, thanks so much
[19:26] <jamalta> salgado: when you have a chance https://code.edge.launchpad.net/~jamalta/launchpad/contributions-merge/+merge/18715
[19:26] <jamalta> thanks again
[19:28] <salgado> jamalta, the diff there has 900 lines
[19:29] <jamalta> salgado: ugh realyl?
[19:30] <jamalta> ...wow let me fix that
[19:30] <jamalta> salgado: yeah, i'm not even sure what happened there.. my commit is only for the one script
[19:30] <jamalta> i'm going to make a new branch and try again
[19:31] <jamalta> salgado: really sorry about that, not sure how that happened
[19:32] <thekorn_> jamalta: you have choosen lp:launchpad as merge target, but lp:launchpad/devel is the correct one
[19:32] <jamalta> thekorn_: ah oops, ok that makes sense
[19:32] <salgado> jamalta, just resubmit the m-p
[19:33] <salgado> and pick launchpad/devel as the target
[19:34] <jamalta> salgado: sorry about that
[19:34] <jamalta> https://code.edge.launchpad.net/~jamalta/launchpad/contributions-merge/+merge/18716
[19:34] <salgado> no worries
[19:34]  * jamalta keeps an eye on the diff this time
[19:35] <jamalta> that's a bit more accurate :)
[19:37] <dhillon-v10> hi all, I am new here, but have been reading launchpad code for a while now (especially schemas), there are some features in soyuz that I would like to work on and the wiki said to setup a pre-implementation call, so can anyone mentor me so I can get the feature worked out :)
[19:37] <dhillon-v10> they are mostly bug reports asking for features
[19:39] <salgado> jamalta, would you mind fixing the pylint complaints in that file?  just shortening a couple too long lines and suppressing a warning about a bare except
[19:39] <jamalta> salgado: guess it wouldn't hurt
[19:39] <jamalta> i left them alone because i was unsure
[19:42] <salgado> dhillon-v10, best thing would be to talk to one of the soyuz guys (bigjools, al-maisan or noodles), but none of them are around now
[19:42] <dhillon-v10> salgado: hi there :) alright will do, i guess you guys all work at european times right?
[19:43] <dhillon-v10> jamalta: hi :)
[19:43] <jamalta> dhillon-v10: hey there! how's it going?
[19:44] <dhillon-v10> jamalta: long time no see, i am good how about you
[19:45] <salgado> dhillon-v10, most of the soyuz guys do, but we have plenty of devs on american timezones
[19:45] <jamalta> dhillon-v10: not too bad, just fixing some stupid errors of mine :)
[19:45] <jamalta> salgado: ok pushed the fixes
[19:46] <dhillon-v10> salgado: alright, so do you think mailing the list could be a better idea then
[19:48] <salgado> dhillon-v10, probably.  that way you might even get a reply during the weekend
[19:48] <dhillon-v10> salgado: thanks a lot :) bye and take care
[19:49] <salgado> dhillon-v10, you're welcome. :)
[19:50] <salgado> thanks jamalta.  approved and now I'll submit it
[19:50] <jamalta> salgado: thanks!
=== salgado changed the topic of #launchpad-reviews to: on-call: - || reviewing: - || queue [-] || This channel is logged: http://irclogs.ubuntu.com ||https://code.edge.launchpad.net/launchpad/+activereviews
[19:53] <jamalta> salgado: by submit you mean you will land it?
[19:56] <salgado> jamalta, yep
[19:56] <jamalta> salgado: sweet, thanks to much
=== salgado is now known as salgado-afk
=== jamalta is now known as jamalta-afk
=== jamalta-afk is now known as jamalta
=== jamalta is now known as jamalta-afk