mwhudsondhillon-v10: yeah, i'd look for something smaller i think00:00
dhillon-v10mwhudson: would you be around in like 5 mins. until i find something else?00:01
mwhudsondhillon-v10: i'll have lunch soon, but i'm around for another 4 hours or so00:01
mwhudsondhillon-v10: you could try looking at https://bugs.edge.launchpad.net/launchpad-project/+bugs?field.tag=trivial00:01
* mwhudson has lunch now, in fact00:02
dhillon-v10mwhudson: when you get back, look at this one: https://bugs.edge.launchpad.net/launchpad-code/+bug/294048 it doesn't seem too bad00:10
mupBug #294048: Branch name ambiguous in revision feed for a person <feeds> <trivial> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/294048>00:10
mwhudsondhillon-v10: yeah, that looks more suitable00:20
dhillon-v10mwhudson: and I found another one that is a typo :)00:22
mwhudsondhillon-v10: even better :-)00:22
dhillon-v10mwhudson: one question, its a little unrealted, I develop kernel drivers for open-solaris, and we use something called open-grok which is a pretty amazing source-code browser, it can locate almost every instance of a word,struct,function and other stuff easily, I want to use that to index launchpad code, when I do that, is it possible to deploy that to a website, opengrok needs tomcat so what do you think about that00:24
mwhudsondhillon-v10: it sounds interesting, but i don't think we have tomcat anywhere so i don't think it could be on our servers00:25
dhillon-v10mwhudson: in finding typos like that one, I can just type in the word, and it will find the exact file that it is in, do you want to see a sample, I can set it up locally and you can see it :)00:26
mwhudsondhillon-v10: i can do that on my machine with grep easily enough...00:26
dhillon-v10mwhudson: ohh, I forgot about grep, thanks that saved my 10 mins. of configuration setup :)00:27
mwhudson'bzr ls --versioned --recursive --null --kind file | xargs -0 egrep ... ' is handy, if a little wordy00:28
wgrantmwhudson: There is, and it works. But I got distracted when that revealed a whole lot of other isues in process-upload, which make it difficult to test.00:32
mwhudsonwgrant: can you link it to the bug?00:33
wgrantmwhudson: Done.00:37
mwhudsonwgrant: ta00:37
dhillon-v10mwhudson: someone fixed that typo before me: https://bugs.launchpad.net/malone/+bug/41517000:47
mupBug #415170: Typo in AJAX milestone picker class <bug-page> <trivial> <ui> <Launchpad Bugs:Fix Released> <https://launchpad.net/bugs/415170>00:47
dhillon-v10mwhudson: I closed it :)00:47
mwhudsondhillon-v10: hah00:48
dhillon-v10mwhudson: have a look at this one: https://bugs.launchpad.net/soyuz/+bug/410331 , there's a default name but only for the first time someone activated their ppa, does it make sense to have it there every single time01:26
mupBug #410331: PPA: should default to sensible/good name (or give example) <ppa> <trivial> <ui> <Soyuz:Triaged> <https://launchpad.net/bugs/410331>01:26
mwhudsondhillon-v10: not really my area, but i don't see why not01:29
wgrantThere is no default name at all any more.01:30
wgrantNote that the bug is about the *display* name.01:30
dhillon-v10wgrant: I looked in staging and ppa shows up in the default name field, but you are right :) no display name there01:32
dhillon-v10mwhudson: this will have to be edited: http://pastebin.com/d42ab475d01:34
mwhudsondhillon-v10: yeah01:35
mwhudsondhillon-v10: it would be good for the default to update as the name is updated but that sounds fiddly...01:36
dhillon-v10mwhudson: Curtis suggested that on the bug report, so I just put that there :)01:36
dhillon-v10mwhudson: so what do you say, should I go ahead and make that edit, then put add a patch to that bug report, so you can review it and push it ?01:46
mwhudsondhillon-v10: i might let someone from the soyuz team review it and you should put the change in a branch, not a patch01:46
mwhudsonbut otherwise yes :-)01:46
thumpermwhudson: you'll be happy to know that we are killing weekly chr01:47
mwhudsonthumper: i heard this rumour01:47
thumperof a sort anyway01:47
mwhudsonthumper: but i thought i should do it today at least01:47
thumpersome things back to daily01:47
thumpermwhudson: yeah, not sure when the "new" - old way comes back01:47
thumperUrsinha: the getBranches update is being kicked off with ec2 land now01:54
dhillon-v10thumper: hi :) I remember you from the developer week01:57
thumperdhillon-v10: which developer week?  I did one ages ago01:57
dhillon-v10thumper: it was the one with launchpad api, you were only there for a few moments someone else actually did the session01:58
dhillon-v10mwhudson: for pushing a branch, do I have to download the entire edge branch again (I already did it to setup my developmental environment) or is there another way02:01
dhillon-v10mwhudson: sorry for taking a lot of your time, once I get proficient at this, I won't bother you as much :)02:01
mwhudsondhillon-v10: do you have a shared repository locally?02:02
Ursinhathumper: awesome! :)02:04
dhillon-v10mwhudson: I don't think so02:04
mwhudsondhillon-v10: did you run rocketfuel-setup ?02:04
dhillon-v10mwhudson: yes02:05
mwhudsondhillon-v10: ok, so you have a ~/canonical directory and a trunk directory in there?02:06
mwhudsonwhat does 'bzr info' say in the ~/canonical directory?02:06
dhillon-v10mwhudson: just a sec.02:07
dhillon-v10mwhudson: this is what i get on the top-level directory: http://pastebin.com/m3f21dc0102:09
dhillon-v10mwhudson: and yes I do have a local shared repo. :)02:09
mwhudsondhillon-v10: then the usual practice is to "bzr branch trunk fix-bug-$BUG_NUMBER" in the repo02:09
mwhudsonmake your changes in the branch you just created02:10
mwhudsonthen commit, push lp:~<you>/launchpad/fix-bug-$BUG_NUMBER02:10
dhillon-v10mwhudson: ok will do, right now updating my branch after that will follow the steps you listed above :)  thanks a lot for your help02:13
dhillon-v10mwhudson: it says not a branch Not a branch: "/home/vikram/launchpad/lp-branches/devel/trunk/".02:26
mwhudsonoh sorry02:26
mwhudsondhillon-v10: cd /home/vikram/launchpad/lp-branches/; bzr branch devel <new-branch-name>02:27
dhillon-v10mwhudson: yeah I already did that and it worked :)02:27
dhillon-v10mwhudson: I figured if trunk doesn't exist then I can branch devel02:28
dhillon-v10mwhudson: one bug down :) i pushed the branch, now do I request a merge or does it get reviewed first02:40
mwhudsondhillon-v10: request a merge02:40
dhillon-v10mwhudson: alright thanks again, that was my first change :)02:41
mwhudsondhillon-v10: woo02:41
dhillon-v10mwhudson: just curious, how many changes have you made, give me like 2 years and i'll catch up to you :)02:42
mwhudsondhillon-v10: um, not sure, must be a few hundred02:43
dhillon-v10mwhudson: wow that's a lot to catch up on, but I'll do it, just wait :)02:43
mwhudsondhillon-v10: it's my full time job, that gives me a bit of an advantage!02:44
dhillon-v10mwhudson: oh I forgot you work for canonical :P  i go to school which is a big pain02:45
* thumper is moving on02:46
dhillon-v10mwhudson: last question of the day :) is it okay if I push launchpad code to google code, it has a little function search feature that makes it easy to search for functions and so on02:51
mwhudsondhillon-v10: so long as it's marked as AGPLv3, sure02:51
dhillon-v10mwhudson: yeah, all my projects are with GPL :) alright so thanks a lot, and good night02:52
wgrantmwhudson, dhillon-v10: Google Code does permit AGPLv3, AFAIK.02:56
wgrantEr, "does not" permit.02:56
dhillon-v10wgrant: http://code.google.com/p/launchpad-ubuntu/02:58
dhillon-v10wgrant: that was changed a while ago :)02:58
wgrantWhy Ubuntu?02:59
dhillon-v10wgrant: it just sounds good, and also because ubuntu uses launchpad, something wrong with it??03:00
wgrantLaunchpad doesn't need any more publicity about it being linked to Ubuntu.03:01
dhillon-v10wgrant: okay, I'll change it, if google code allows me to :)03:01
bjfi'd like to know if I can use searchTasks to search only the last 6 months, or to at least order the search results by date03:19
bjfi've used order_by='-id' but can't figure out how do order_by date03:20
mwhudsonbjf: what do you mean by 'date' ?03:23
mwhudsonbjf: date created?03:23
bjfmwhudson, date_created03:23
bjfwgrant, that worked, thanks!  where would I have found that out on my own?03:24
bjfwgrant, is there a way to limit the search to the last 6 months?03:25
wgrantbjf: I don't know how I knew it -- maybe from looking at query strings for normal bug searches.03:25
wgrantbjf: There is no way to do that.03:25
bjfwgrant, thanks03:25
bjfif I take the resulting collection from searchTasks and try to only look at the last 500 with taskSearch(order_by='-datecreated')[:500] I get an "file too long" error03:31
mwhudsonthat's a launchpadlib bug03:32
mwhudsonhttps://bugs.edge.launchpad.net/launchpadlib/+bug/512832, at least03:33
mupBug #512832: launchpadlib caches based on full URL <launchpadlib :New> <https://launchpad.net/bugs/512832>03:33
bjfmwhudson, ack03:34
bjfmwhudson, just ran int that bug again (for a slightly different reason) the only workaround I can think of is to use taskSearch without any parameters03:51
mwhudsonbjf: i don't have any great ideas sadly03:51
bjfmwhudson, thanks, thought I'd at least ask03:52
mwhudsonwell, apart from fixing launchpadlib to cache in directories named after the SHA1 or something03:52
bjfmwhudson, is that bug on anyone's "soon to be fixed" list? :-)03:53
mwhudsonbjf: i don't know03:53
mwhudsonlet me push up the priority at least03:54
Ursinhamwhudson: something crossed my mind now: all branches merged to devel/db-devel are necessarily in lp?05:16
mwhudsonUrsinha: i guess theoretically not, but that seems very very unlikely05:16
Ursinhamwhudson: hm05:16
Ursinhamwhudson: same way, all branches merged to db-devel/devel need a merge proposal before being merged?05:17
mwhudsonUrsinha: no05:17
Ursinhamwhudson: right05:18
mwhudsontestfix branches don't always have merge props for example05:18
Ursinhamwhudson: but they are in lp?05:19
mwhudsonUrsinha: yeah05:19
mwhudsonthe branch has to be somewhere internet accessible to merge05:19
mwhudsonyou *could* push to devpad i guess, but it's really not very likely05:20
Ursinhamwhudson: I see05:21
Ursinhamwhudson: well, I'll work with monitoring branches that are merged to devel/db-devel in lp05:22
mwhudsonUrsinha: that should be fine05:22
Ursinhamwhudson: I hope so :)05:22
Ursinhamwhudson: thanks for the thoughts05:22
mwhudsonUrsinha: np05:23
adeuringgood morning08:31
noodles775Morning adeuring and all.08:37
adeuringHi noodles775!08:37
jmlgood morning08:54
jmlnoodles775, I'm going to acquaint myself with the last week of discussion of buildbranchtoarchive08:56
beunohey jml08:57
noodles775jml: great, thanks.08:59
jmlbeuno, hi09:04
jmlbeuno, I'm working from home today & for the rest of this week, fwiw09:04
beunojml, I expected as much. It's too cold to do anything else  :)09:05
mrevellHello friends09:06
beunohey mrevell09:06
mrevellHi there beuno, congrats on your new role09:06
jmlbeuno, also, despite the length in calendar days, I've really only just moved in. I need to be home to receive deliveries of bookshelves and the like09:07
beunojml, sounds exciting09:07
beunomrevell, thanks  :)09:07
jmlbeuno, yeah, I'm quivering with anticipation.09:08
jmlhow do I tell whether an import branch is bzr-svn or cscvs svn09:10
wgrantThere's a tooltip somewhere.09:10
wgrantIn "This branch is an import of the Subversion branch [...]", "Subversion" has a tooltip.09:14
jmlwgrant, thanks for the "tip" (get it!?!?!)09:16
wgrantHa ha ha.09:16
beunojml, how can I find a list of all MPs with the09:47
beuno"ui" review tag in them?09:47
jmlbeuno, there's no UI for that.09:51
jmlbeuno, probably not an API either.09:51
beunojml, can I get all MPs against launchpad through the API?09:52
jmlbeuno, the 'review type' thing isn't really a tag, fwiw. perhaps it ought to be.09:52
jmlbeuno, hmm.09:52
james_wlp.projects['launchpad'].getMergeProposals() I believe09:52
jmlbeuno, I don't know. I could find out by looking at the API docs. Want me to do that?09:52
jmljames_w, hello :)09:52
james_wstatus=[<list of statuses you want>]09:52
james_whi jml09:52
beunojames_w, you should be on the code team09:53
beunothank you09:53
james_wI'd love it if I could get these landed: https://code.edge.launchpad.net/~james-w/launchpad/09:54
beunojames_w, my "ec2 land" is broken, but jml was nice enough to land my branch last week, he may still have niceness in him09:55
james_wwhat do you mean? jml is always overflowing with niceness09:57
jmljelmer, may I encourage you to reply to Michael Hudson's "[Launchpad-dev] plan for incremental code imports" email?09:57
jmljames_w, happy to do so.09:58
jelmerjml: consider me encouraged.09:58
jmljelmer, :D09:58
james_wthanks jml09:58
jmljames_w, although I think I'm going to propose in future that we make this sort of thing the OCR's job.09:58
james_wfor the older one I think it was submitted, perhaps twice, so I think that has more to do with the fragility of the process. Having the OCR chase up approved but not merged branches would be a good idea though.10:00
noodles775jml: will you have time for a call before lunch?10:20
jmlnoodles775, probably not.10:21
jmlnoodles775, but I'll almost certainly be ready right after10:21
jmlnoodles775, unless you want a call right now10:21
noodles775jml: right now is fine too.10:21
jmljames_w, both branches are now being tested on ec210:22
noodles775jml: sorry, right now as in 2 mins :/10:22
jmlnoodles775, np :)10:22
=== henninge is now known as heninge-afk
=== matsubara-afk is now known as matsubara
=== heninge-afk is now known as heninge
=== heninge is now known as henninge
beunodoes anyone know a way around bug 512832?11:28
mupBug #512832: launchpadlib caches based on full URL <launchpadlib :Triaged> <https://launchpad.net/bugs/512832>11:28
beunoI can't use launchpadlib at all  :(11:29
beunojames_w, is there anyway to get all the MPs I've reviewed?11:36
BjornTbeuno: if you have an encrypted home dir, a workaround can be to symlink the .launchpadlib/ dir to an unencrypted folder. that made it work for me11:38
beunoBjornT, thanks, I'll try that11:42
maxbsalgado: Hi, did https://code.edge.launchpad.net/~maxb/launchpad/py2.6-importfascist disappear in a puff of ec2?11:44
beunoBjornT, that totally worked, thank you11:46
salgadomaxb, thanks for reminding me of it -- the test suite was hung and the instance failed to shut down11:47
salgadomaxb, I'll submit it again11:47
james_wbeuno: not that I know of. One of the branches of mine that will land shortly allows you to do me.getRequestedReviews(), but I don't know if that includes reviews you have done.12:01
beunojames_w, ended up filtering in a loop, thanks12:03
bachi jamalta14:05
jmlnoodles775, hello. I'm now caught up with my reading for daily build ui.14:06
jamaltabac: hey, how's it going?14:06
bacjamalta: good.  hey have you arranged for someone to land your branch for bug 515761?  i have a branch that needs to use your new AnonymousAuthorization class so I've been waiting.14:07
mupBug #515761: Anonymous API access to some collections returns nothing <Launchpad Foundations:Confirmed for jamalta> <https://launchpad.net/bugs/515761>14:07
jamaltabac: well, yes i thought i had14:07
jamaltabut i guess they didn't get time to do so14:07
bacjamalta:  i'll be glad to do it now14:07
bacjamalta: if you'd merge from trunk and push back up to LP i'll land it for you14:07
jamaltabac: sure! if you could please, i would really appreciate it14:08
jamaltabac: sure thing14:08
jamaltabac: sorry to have kept you waiting also :\14:09
jmlnoodles775, and I'm thus happy to have a call whenever you are ready14:09
jml(except not at 1500UTC).14:09
noodles775jml: OK, I'm justgot a scheduled call with abentley first...14:12
noodles775abentley: are you available now?14:12
abentleynoodles775, sure.14:12
noodles775abentley: OK, I've added you as a contact on skype.14:12
jmlnoodles775, np14:12
* jml seizes the opportunity to ruthlessly clean out his desktop & physical in-tray14:13
abentleynoodles775, I'm on skype, but I don't see a contact request.14:13
bac jamalta: please let me know when that is done14:15
jamaltabac: alright, it should be updated now. Thanks for that.14:17
bacjamalta: np.  i'll land it now.  please don't do any more pushes to that branch.14:18
jamaltabac: of course, thanks so much14:18
jamaltabac: oh thanks for catching that, i will start marking bugs as "In Progress" when I'm working on them14:20
=== henninge_ is now known as henninge
noodles775jml: is now ok, or too close to your next call?14:38
jmlnoodles775, let's have one now and then schedule another if there's not enough time?14:39
beuno# of ui reviews ever done using MPs:14:39
beuno{u'beuno': 170, u'launchpad': 5, u'rockstar': 17, u'barry': 17, u'michael.nelson': 39, u'sinzui': 13, u'edwin-grubbs': 2, u'bac': 1, u'adeuring': 1, u'mars': 1, u'intellectronica': 12, u'matthew.revell': 4}14:39
noodles775jml: ok, when you're ready.14:40
=== matsubara is now known as matsubara-lunch
=== salgado is now known as salgado-lunch
marsEdwinGrubbs, ping, mind if I assign bug #405476 to you?14:59
mupBug #405476: sprite class bleeds extra images in tall elements <css> <post-3-ui-cleanup> <tech-debt> <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/405476>14:59
EdwinGrubbsmars: go ahead14:59
kfogeladeuring: I have read and understood https://bugs.edge.launchpad.net/malone/+bug/518746 .  If you're working on it, I'll just make sure that is communicated to jcastro.  Is there anything else I can do to help?15:03
mupBug #518746: Read the patch age on the +patches view directly from Bug.latest_patch_updated <oops> <patch-tracking> <Launchpad Bugs:In Progress by adeuring> <https://launchpad.net/bugs/518746>15:03
adeuringkfogel: well, if you want to discuss details how to address it, I'd appreciate it15:05
kfogeladeuring: oh, I thought from this that the solution was already basically known: "The only detail we need from the query is the creation time of the bug message (retrieved in another, faster, query), and we can get this value already from the new column Bug.latest_patch_updated"15:06
adeuringkfogel: seems that wrote nonsense: We want to display the title, the URL and a few other things...15:07
kfogeladeuring: reading query more carefully now, then15:07
kfogeladeuring: you're talking about the stuff in the popup block?15:09
adeuringkfogel: yes, and about the URL we show for each patch15:09
* kfogel thinks out loud... "Maybe our denormalized column should be "latest_patch" rather than "latest_patch_updated"15:12
adeuringkfogel: we need something to sort on in this column ;) But since row1.id < row2.id should imply row1.datecreated  row2.dattecreated, that should actually work quite well15:15
adeuringkfogel: so: I think I'll change my DB atch again ;)15:16
adeuringthanks for the suggestion!15:16
adeuringerm, that should have been row1.datecreated < row2.dattecreated15:17
kfogeladeuring: the only thing I worry about is, is that something we can count on always being true?  If "later IDs must be higher numbers" is going to be a constraint from now on, where do we document that?15:17
kfogel(Do we use this sort-by-ID technique elsewhere in LP already?)15:17
micahgif anyone needs a high profile bug with upstream implications to work on...bug 499113 is upsetting bugzilla.mozilla.org users... :)15:18
mupBug #499113: Launchpad will sync comments and link back to all bug watches, even those not linked to a bug task <bugwatch> <story-reliable-bug-syncing> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/499113>15:18
adeuringkfogel: We had such a discussion a few hours ago, related to timeouts on the main LP bugs page15:18
adeuringwhere a SELCT * from BUG WHERE ... SORT B> datecreated, id timed out15:19
kfogeladeuring: in SQL, "SORT BY foo, bar" means sort by foo first, then by bar within that?15:19
adeuringkfogel: yes15:19
kfogeladeuring: The idea sounds solid to me.  But I'd feel more comfortable if someone with lots of DB knowledge said "Oh, sure, we sort by ID all the time, it's totally normal."15:20
adeuringkfogel: I can imagine one situation where we might get a, let's "minor deviation" from the rule "ordering by id is equvialent to ordering by date_creeated"15:21
adeuringWhen two attachments are created simultaneously, attachment A might get the lower ID, while attachment 2 might have its INSERT statement executed first15:22
adeuringbut (a) aving two attachments field for the same bug at the same time is quite unlikely, and (2) if this happens, the fine details of which cam first are irrelevant anyway15:23
kfogeladeuring: well, they're only going to differ by a milliseconds, right, and we're just sorting for UI purposes.15:23
kfogelhaving two *patch* attachments is especially unlikely15:23
adeuringkfogel: excatly15:24
kfogeladeuring: is there any UI by which someone can retroactively mark an attachment as a patch or non-patch?15:24
adeuringkfogel: es. Just follow the "edit" link in the patch/attachment poertlet of any bug page15:24
kfogeladeuring: so when someone does that, we update the latest_patch_updated field, right?15:27
adeuringkfogel: yes, via a trigger.15:27
kfogelah right, thx15:28
adeuringkfogel: IIRC, stub alreaddy suggested to sort on bugattachment.id in some +patches-related query, when we discussed the sorting15:29
kfogelah, so this idea has an honorable provenance15:31
kfogelgood :-)15:31
=== matsubara-lunch is now known as matsubara
=== salgado-lunch is now known as salgado
beunosince august last year, developers have done more UI reviews each month than I have16:41
beunoI got my ass kicked in september16:41
beuno(I knew I shouldn't of gone on vacations!)16:42
Ursinha_abentley: hello.17:03
abentleyUrsinha_, Hi.17:04
Ursinha_abentley: that day, when you suggested me monitoring branches being merged into devel/db-devel instead of their revisions, you really meant branches or merge proposals?17:04
=== Ursinha_ is now known as Ursinha
abentleyI meant merge proposals.17:06
Ursinhaabentley: so, it turns out that not all branches merged into lp have a merge proposal17:06
abentleyWhat branches don't?17:06
Ursinhaabentley: testfixes, for instance17:07
Ursinhanot necessarily have mps17:07
Ursinhaabentley: I did a test here in lp and could see that17:07
Ursinhaabentley: getting all merged branches of launchpad-project, not all of them have mps17:08
abentleyUrsinha, Sorry I didn't think of that.17:08
adeuringmbarnett: could you please run this query for me on staging: https://pastebin.canonical.com/27546/ ?17:08
Ursinhaabentley: no problem, actually I'd like to know if you have another idea17:09
Ursinhaabentley: ideally I'd monitor branches17:09
Ursinhaabentley: thumper very kindly implemented yesterday a way of getting branches given a date17:09
Ursinhain that case, the last modified date17:10
mbarnettadeuring: ERROR:  syntax error at or near "ORDER"17:11
mbarnettLINE 6:        WHERE BugAttachment.bug = 445852 AND ORDER BY BugAtta...17:11
Ursinhaabentley: but some information will be missing, case the branch doesn't have an mp, like the target_branch17:11
abentleyUrsinha, without merge proposals, I don't see a cheap way to query this.17:12
Ursinhaabentley: ah :/17:12
adeuringmbarnett: I'm an idiot, sorry. This one should work: https://pastebin.canonical.com/27547/17:12
abentleyI'd like to bring it up in our standup.17:12
Ursinhaabentley: but, is it possible to add more information to the branch? Also, I see that the merged_revno in the mp isn't filled. Is that a bug?17:12
adeuringmbarnett: also, could you please check if we have an index on bugattachment(bug), in the staging database?17:13
adeuringmbarnett: ot my best day... I meant an "explain analyze" for https://pastebin.canonical.com/27547/ . Sorry for the confusion...17:15
abentleyUrsinha, we can add more info, but I'm not sure the branch is the right place, because a merge involves two branches and may happen multiple times.17:15
abentleyUrsinha, yes, it's a bug that we don't include that revno.17:15
mbarnettadeuring: https://pastebin.canonical.com/27549/17:16
Ursinhaabentley: I agree with your statement about branches not being the right place to put that, but I couldn't find another place considering not all branches have mps17:16
adeuringmbarnett: thanks!17:16
Ursinhaabentley: ideas more than welcome :)17:17
mbarnettadeuring: np17:17
abentleyUrsinha, the two ideas I have are 1. create a "merged" merge proposal when branch merges are detected, 2. create a new table to track merges.17:18
beunoabentley, hey, you may be able to answer this. I can't figure out how to, from the API, which user commented on each comment17:22
beunoI can get the content of the comment17:22
beunobut not the author17:23
beunois it possible that it's not exposed?17:23
abentleybeuno, I believe that's recorded as the creator.17:23
beunorockstar, ^17:23
beunoabentley, there doesn't seem to be such an attribute17:23
rockstarbeuno, lemme look17:23
adeuringmbarnett: so... could you run this query on staging https://pastebin.canonical.com/27550/ ? That's from a not-yet-merged branch (https://code.edge.launchpad.net/~adeuring/launchpad/fix-broken-initialisation-of-bug-latest-patch-uploaded/+merge/18610 ); my hope is that this will improve the run time of the first query you ran17:23
beunoI can get it for votes17:24
beunonot for comments17:24
abentleybeuno, it is the owner of the message.17:25
rockstarbeuno, huh.  ICodeReviewComment doesn't have a author attribute.17:25
rockstarabentley, I don't think message is exposed.17:26
abentleyrockstar, there's an export_as_webservice_entry line in the interface file.17:26
rockstarNope, it's not.17:26
rockstarabentley, yeah, but the ICodeReviewComment.message isn't17:26
beunorockstar, easy fix?   I'm working on publishing a paper on Launchpad's whole UI review experience, and I need it as part the data I want to present  :)17:27
rockstarbeuno, I can't imagine it would be too difficult, but the API constantly has unknowns whenever I expose something.17:28
beunorockstar, will you have a few minutes to look into it and give me a nod?17:28
beunoI'd super appreciate it if you could17:28
rockstarbeuno, can it wait a few hours.  I'd like to get a branch into review soon.17:29
beunorockstar, of course it can. Thanks17:29
rockstarbeuno, okay.  If you're lucky, it'll be on edge tomorrow.  ;o)17:29
beunorockstar, fingers crossed17:29
rockstarHell, if _I'm_ lucky...17:29
mbarnettadeuring: sorry, got pulled in 2*10^7 directions there... your index is now on staging18:15
jamaltabac: hey18:16
rockstargary_poster, hello sir.18:18
gary_posterhey rockstar18:18
rockstargary_poster, bin/jsbuild is a generated file, correct?18:18
rockstarmbarnett, hi18:19
gary_posterrockstar: yes18:19
mbarnettheya rockstar18:19
rockstargary_poster, where is the code that generates that?  I think I'm going to have to generate a Makefile in a similar fashion.18:19
rockstarmbarnett, so, about that cherry pick...18:19
mbarnettrockstar: there was some sql business if i recall correctly18:21
rockstarmbarnett, yup.  Lemme get my ducks in a row first here.18:22
gary_posterrockstar: If the end result is a Makefile, then I think you want a slightly different mechanism than bin/jsbuild, but same idea.  Look in [LP tree]/buildout-templates.  The .in files are processed and put in the LP tree by buildout.  Processing is as per http://pypi.python.org/pypi/z3c.recipe.filetemplate .  You might be able to get what you need just by looking at the files already in the bin dir there, though18:23
gary_posterFWIW, that is hooked up in buildout.cfg in the [filetemplates] section18:23
rockstargary_poster, okay.  Basically, I need a make target that uses the filenames of all our js files as the dependent targets.18:24
gary_posterrockstar: ...oh.  I'd guess you want to have something sniff out out js files so you don't have to maintain the list?  Is that the idea?  If you want to know what lazr.js is building, you'd probably need to ask mars or maybe salgado about that18:27
gary_posterI don't know if there is a config file for that info anywhere, or what18:27
rockstargary_poster, yes, I want to automate it.18:28
rockstargary_poster, the problem currently is that the js gets combined every time you run make run.  This is no fun.18:28
gary_posterrockstar: ah, yes!  have complained about this as well.  mars/salgado did want to address as well.  thank you for tackling.  salgado has a plan for this in fact, IIRC.  salgado, am I right?18:29
rockstargary_poster, well, it's one of the reasons I'm build manager this cycle.  Javascript needs to suck less.  :)18:30
salgadogary_poster, I had, yes, but rockstar took it over as he's the build engineer. :)18:30
rockstarsalgado, if you have a better plan than mine, I'm all ears.18:30
gary_posterrockstar: yay :-)18:30
salgadorockstar, my plan is the one I described in the UI call last week18:31
rockstarsalgado, I've been rather perplexed at the nastiness of Makefile generation.18:31
rockstarsalgado, I don't recall you explaining it last week.18:31
rockstarMaybe two weeks ago, before I was build engineer?18:31
rockstarI remember you talking about it then, but I don't remember that there were any specifics discussed.18:31
salgadowe already maintain a hard-coded list of CSS files that we want to combine as we don't want to include everything from yui/lazr-js, so I think you could easily change bin/combine-css to not do anything if combo.css is newer than all CSS files in the list18:32
rockstarsalgado, ah, you're suggesting hacking it in bin/ scripts then.18:34
rockstarOkay, that makes sense.18:34
rockstarSo the script still runs, but is basically a no-op.18:34
salgadoyep.  not the cleanest approach, but should be easy enough18:35
adeuringmbarnett: cool, thanks!18:37
bachi jamalta18:43
jamaltabac: any clue as to why those tests failed?18:43
jamaltai guess the ec2 test didn't like '...' being used?18:43
bacjamalta: haven't looked yet18:44
jamaltabac: alright, when you get a chance318:44
bacjamalta: it will be easiest if i just merge in your branch into mine, fix the tests and land them together.  you'll still get credit as you're in the bzr history18:45
bacjamalta: sound good?18:45
jamaltabac: yeah that's fine too :)18:47
bacjamalta: can you run the xx-bug.txt test in your branch and see if it fails?  i don't get a failure locally18:49
jamaltabac: it doesn't fail for me either18:50
bacjamalta: :(18:50
jamaltathat's mainly why i was confused18:50
jamaltai know! :(18:50
jamaltai thought it might have been after the merge, but they still worked fine18:50
* jamalta checks if he forgot to commit something18:51
jamaltawell, that wouldn't make sense because you'd be having the issue too18:51
jpds(I usually find that running 'make schema' helps sometimes with weird test failures).18:51
jamaltajpds: thanks, will try that18:52
bacjamalta: the reason for the failure is not the wild-carding with ellipsis. it is b/c the actual output of that test had the unexpected output for 'task_age'18:54
jamaltabac: oh18:55
bacjamalta: your MP has db-devel as a landing target, not devel.  db-devel has task_age exported but devel does not18:57
jamaltabac: wowah, how and why is it db-devel?!19:00
jamaltai'm pretty sure i asked for lp:launchpad/devel19:00
jamaltaoh i see what i did, hmm..19:01
jamaltahow can i fix thatA?19:01
bacjamalta: it won't be an issue if i land it with mine19:02
jamaltabac: ah okay19:02
jamaltathanks for figuring that out19:02
mrevellnight all19:15
mwhudsongood morning19:23
jtvhi mwhudson19:57
mwhudsonjtv: hello19:57
=== matsubara is now known as matsubara-afk
=== salgado is now known as salgado-afk
lifelessjml: can I offer any assistance on your subunit branch for lp ?21:27
jmllifeless, thanks. What I'm going to do is finish up the zope.testing branch. I'd like you're input on that once I've finished off the last few bits.21:34
lifelesssure thing21:43
rockstargary_poster, I don't see a template for bin/jsbuild - Where can I find a mapping for all of these scripts?21:59
gary_posterrockstar: all the files in bin are generated by buildout.  If they are not generated from the templates then they are generated from entry points, via the zc.recipe,egg zc.buildout recipe.  See the [scripts] section of buildout.cfg, in the entry-points key.22:03
gary_poster(I don't think this affects your needs, but I don't advise looking too closely at those scripts specifically.  I'm putting the final touches now on a branch that gets rid of the whole fragile sys.modules ugliness.)22:03
gary_posterrockstar: I'm not sure you are going to be able to get what I vaguely understand you want22:04
rockstargary_poster, getting rid of the sys.modules stuff will be nice, as it makes the script more manageable in an editor.22:04
gary_posterbut my understanding is vague, so hopefully I'm wrong22:04
gary_posterrockstar: yeah, the new scripts are < 20 lines of <80 chars each22:05
rockstargary_poster, awesomeness.22:05
=== jamalta is now known as jamalta-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!