[00:23] <jono> Nafai, hey
[00:23] <Nafai> Hey jono
[00:23] <Nafai> I was just working on an e-mail to y'all :)
[00:25] <jono> Nafai, awesome
[00:25] <jono> I will wait for that :-)
[00:30] <Nafai> sent
[00:32] <jono> Nafai, thanks, in future could you also copy in Rick Spencer
[00:32] <jono> thanks!
[00:32] <Nafai> oh, sure
[00:32] <Nafai> want me to forward today's to him?
[00:33] <Nafai> anything else you wanted, or just a status report? :)
[00:34] <jono> I forwarded it to him
[00:34] <jono> nope, just a status is good, thanks!
[00:36] <Nafai> sweet
[08:10] <jono> hey murrayc
[08:16] <murrayc> hey jono
[09:11] <jono> jpetersen, hey!
[09:15] <jpetersen> hi jono 
[09:17] <jono> hey jpetersen
[09:17] <jono> welcome!
[09:17] <jono> :)
[09:18] <jpetersen> thanks :)
[09:18] <jono> jpetersen, I am just sending you a mail right now with the next set of apps
[09:18] <jpetersen> jono, ok
[09:18] <jono> :)
[09:21] <murrayc> jono: Don't get disconcerted by jpetersen's ueber-efficiency. He tends to just get stuff done, usually perfect the first time, without talking much about it.
[09:22] <murrayc> It weirds me out when he just does what I ask.
[09:22] <jono> lol
[09:22] <jono> sounds good to me :)
[09:31] <jono> jpetersen, ok, so in a nutshell we are shooting for your three apps being done in a week
[09:31] <jono> I know you are still pretty new, so let me know if there are any blockers
[09:32] <jpetersen> jono, ok sounds good
[09:33] <jono> thanks jpetersen, murrayc
[09:33] <jono> ok, I am heading to bed :)
[13:53] <Nafai> Good morning, reporting for duty :)
[13:58] <kenvandine> Nafai, hey great work on brasero
[13:59] <Nafai> Thanks
[13:59] <Nafai> Looking forward to any comments :)
[13:59] <kenvandine> Nafai, i haven't built it, but writing up a little feedback
[13:59] <kenvandine> the autofoo stuff :)
[13:59] <Nafai> Thanks
[13:59] <Nafai> brb, restarting with latest updates
[14:04] <Nafai> back
[14:04] <Nafai> Love how fast things restart
[14:07] <Nafai> tedg: About to test with the latest updates
[14:12] <tedg> Nafai: Cool, ping me if there are issues
[14:12] <Nafai> Sure thing
[14:13] <Nafai> tedg: Yay, your fix worked!
[14:13] <kenvandine> i made it a enable arg and tweaking naming to match upstream's style
[14:13] <Nafai> kenvandine: I'll have a patch available soon for gnome-control-center
[14:13] <Nafai> After I make changes there based on your feedback for brasero
[14:14] <kenvandine> Nafai, upstreams can be picky, so following their conventions can be important, depending on the project
[14:14] <Nafai> Right, I admit I just wanted the autoconf foo to work, I'll be more particular in the future :)
[14:14] <kenvandine> also i would say if it is common code between both the tray and the indicator stuff you should probably pull that out into a separate file
[14:15] <kenvandine> i am sure upstream would appreciate that
[14:15] <kenvandine> but what you have should work... but maintainability would be better if it was moved
[14:15] <Nafai> Yeah, shouldn't take too long to do
[14:15] <kenvandine> Nafai, no worries, just trying to spread some of my experiences with upstreams :)
[14:16] <kenvandine> not all upstreams are as awesome as tedg to work with :)
[14:16]  * kenvandine looks for brownie points before nagging about the duplicate menus :-p
[14:16] <Nafai> No, I appreciate it
[14:16] <tedg> kenvandine: It's fixed in trunk ;)
[14:16] <kenvandine> woot!
[14:16] <kenvandine> i am worried it might be masking other bugs :)
[14:17] <tedg> kenvandine: Actually, that's untrue -- it needs a review first.
[14:17] <kenvandine> dbusmenu?
[14:17]  * kenvandine can do a patch to test it :)
[14:17] <kenvandine> link me
[14:19]  * tedg is trying -- but really just yelling at LP to be faster.
[14:19] <tedg> kenvandine: https://code.launchpad.net/~ted/dbusmenu/menu-repeat-repeat-repeat
[14:20] <tedg> kenvandine: There still is some repeating in the Messaging Menu, but I think that's there, not in dbusmenu.
[14:21] <kenvandine> ok
[14:21] <kenvandine> i really want to verify that my code actually works :)
[14:22] <kenvandine> tedg, also... i suspect this is a different bug
[14:22] <kenvandine> but if you try to restart indicator-messages-service when something is in the indicator... it crashes
[14:22] <kenvandine> i just found that this morning
[14:23] <tedg> kenvandine: Yes, there are a few... let me get some patches out :)
[14:23] <kenvandine> start empathy and "illall indicator-messages-service; killall indicator-applet; /usr/lib/indicator-messages/indicator-messages-service 
[14:23] <kenvandine> ok... so known :)
[14:24] <kenvandine> http://pastebin.ubuntu.com/372510/
[14:24] <kenvandine> in case that helps
[14:24] <kenvandine> hopefully it is known and fixed :)
[14:25] <kenvandine> i am also seeing this output from indicator-messages-service
[14:25] <kenvandine> (process:15198): libindicate-WARNING **: Unable to get property data: Method invoked for GetIndicatorProperty returned FALSE but did not set error
[14:25]  * kenvandine wonders if that is his code
[14:25] <kenvandine> tedg, ^^
[14:26] <Nafai> kenvandine: I should have an updated patch with the autoconf changes and the common stuff refactored out this morning
[14:26] <Nafai> Plus a patch for gnome-control-center :)
[14:26] <Nafai> And then I'm about halfway through gnome-bluetooth
[14:26] <Nafai> So prepare to be inundated with patches
[14:26] <tedg> kenvandine: I've seen a few of those.  I think it's review-notifier right now... but I haven't looked into that one much yet.
[14:27] <kenvandine> Nafai, awesome
[14:27] <kenvandine> tedg: review-notifier?
[14:29] <tedg> kenvandine: The LP review thingy that dobey wrote.  I think it's in lp-tools.
[14:30] <kenvandine> oh, i am not running that
[14:30] <kenvandine> so maybe it is one of the things i wrote
[14:31] <kenvandine> i have gwibber, xchat-gnome, empathy and evo in the indicator
[14:32] <tedg> kenvandine: Possible.  It usually happens with timeouts.  If you don't make it back to the mainloop in 500 ms, I think that'll cause it.
[14:32] <tedg> kenvandine: Though, now that I'm seeing it more than usual, I'm a bit suspicious if it isn't a libindicate bug.
[14:33] <tedg> kenvandine: So don't spend too much time on it before I get a chance to look into it.
[14:33] <kenvandine> ok
[14:33] <kenvandine> i won't :)
[14:33] <jcastro> good morning
[14:34] <Nafai> Morning jcastro
[14:34] <jcastro> a community guy went out and finished Transmission yesterday
[14:35] <jcastro> http://trac.transmissionbt.com/ticket/2873
[14:35] <jcastro> !
[14:37] <Nafai> Nice!
[14:38] <jcastro> Nafai: ok so is ken done reviewing the brasero patch?
[14:39] <Nafai> I think so, not sure how closely he's looked at the code itself
[14:40] <Nafai> I'm really unsure how to best move common stuff out, since the functions that are common have stuff in the middle of the functions that are the same, but other parts that are not :(
[14:43] <jcastro> Nafai: ok, what's the status of bluetooth?
[14:43] <jcastro> (just updating all the statuses since I've been gone)
[14:44] <Nafai> I'd say about 50%, the menus are built on the fly there it seems so I'll have to read through the code and see if there are any issues
[14:44] <jcastro> ok
[14:44] <Nafai> I just tested tedg's changes, and g-c-c is working.  If we are find with green -> red -> lock, then I just need to tweak my autoconf foo to be more acceptable upstream and that is ready
[14:46] <jcastro> ok so we can probably send the patches to brasero, and g-c-c later today pending review?
[14:46] <Nafai> Yeah
[14:46] <jcastro> ok, and after that you're doing vino?
[14:46] <Nafai> Would brasero upstream be willing to give me advice on how to make the patch better?
[14:46] <jcastro> after bluetooth I mean
[14:46] <Nafai> That's the plan
[14:46] <jcastro> yeah, after your initial review with ken I'll ask luis to look at it
[14:46] <jcastro> and then he can review it 
[14:46] <Nafai> Thanks
[14:47] <Nafai> I know there are some improvements that could be done to improve maintainability/reduce code duplication but I'm unsure of the best way to attack it
[14:47] <Nafai> kenvandine: Should I attach an updated patch with your autoconf changes included?
[14:48] <kenvandine> yes
[14:48] <seb128> I can review the g-c-c one
[14:48] <seb128> Nafai, please don't run autoconf in the same patch if that's what you suggested
[14:48] <jcastro> wook, upstream onboard (the onscreen keyboard) just committed a fix for app indicators
[14:49] <seb128> fix?
[14:49] <jcastro> the ported their own app
[14:49] <seb128> they have a patch for it upstream already?
[14:49] <jcastro> already upstream
[14:49] <jcastro> no release for lucid yet though
[14:49] <Nafai> seb128: hrm?
[14:52] <seb128> jcastro, ok
[14:52] <seb128> Nafai, hrm? to you too ;-)
[14:53] <Nafai> I was confused by what you meant.  Ken gave me some changes to the configure.in changes I had and I'm updating my overall patch to reflect that
[14:53] <Nafai> My patch doesn't include anything generated by autoconf, if that's what you meant :)
[14:54] <jpetersen> I attached a patch for gnome-power-manager lp#497870
[14:54]  * jcastro is overwhelmed updating the statuses. :D
[14:54] <seb128> Nafai, yes that's what I meant
[14:55] <Nafai> ok, cool
[14:55] <jcastro> jpetersen: bah, I messed that one up and I don't think I filed a gnome upstream bug for it, when it's ready can you file a gnome upstream bug?
[14:55] <jpetersen> jcastro, yes i can do
[15:03] <jcastro> jpetersen: hughsie prefers patches sent to the g-p-m mailing list btw.
[15:03] <jcastro> jpetersen: also, getting it blessed as an external dep is important to him, I've made a note of it
[15:03] <jcastro> but I've explained that we'll be carrying the patch for a cycle
[15:03] <jpetersen> jcastro, ok
[15:04] <jcastro> tedg: when does the window open to propose external deps for the next GNOME cycle?
[15:09] <jpetersen> i am looking at gnome-media now, which is basically the volume control
[15:09]  * jcastro nods
[15:09] <tedg> jcastro: I don't remember, I believe it starts right when the release leaves.
[15:09] <tedg> jcastro: Think of it as an excuse to talk to vuntz ;)
[15:10] <jpetersen> Any idea how to map the slider widget? (GtkVScale)
[15:11] <seb128> hum
[15:11] <seb128> jpetersen, you attached your gpm change to gnome-media
[15:11] <seb128> bug #497870
[15:11] <ubot4> Launchpad bug 497870 in gnome-power-manager (Ubuntu) (and 1 other project) "Support Application Indicators (affects: 1)" [Medium,In progress] https://launchpad.net/bugs/497870
[15:11] <seb128> hum
[15:12] <jcastro> seb128: that's my fault
[15:12] <seb128> why do we have 2 components on a same bug there?
[15:12] <jcastro> that bug is all messed up
[15:12] <jcastro> it was the first one I did and I hosed it
[15:12] <seb128> can we close the gnome-media task
[15:12] <seb128> and open a new bug?
[15:12] <seb128> will be easier to track
[15:12] <jpetersen> that would be fine with me
[15:12] <seb128> than having comment and patches about 2 components in the same bug
[15:15]  * jcastro nods
[15:15] <jcastro> just make sure it's tagged with indicator-application or it drops from my list into the ether of lp
[15:17] <jpetersen> i will just file a new bug for gnome-media
[15:20] <jpetersen> lp#519345
[15:24] <jcastro> jpetersen: ok so you're just waiting on review for g-p-m before sending it up so you're just going to -media next right?
[15:24] <jcastro> jpetersen: Also you know about this page right? https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators/ContractorWorkflow
[15:24] <jcastro> jpetersen: I'll need the list of icons for each package you touch
[15:25] <jpetersen> jcastro, Ah no have not seen that page yet
[15:26] <jcastro> feel free to change it to fit reality, so if seb or ken want the assignee to be different or something adjust the page.
[15:29] <jcastro> kenvandine: btw did you upload xchat-gnome to lucid yet?
[15:49] <Nafai> Morning jono!
[15:50] <jono> hey Nafai
[15:51] <seb128> jcastro, I did
[15:51] <seb128> jcastro, and pitti new-ed it today
[15:51] <seb128> jcastro, xchat-indicator that is
[15:51] <seb128> not sure if that's what you meant by xchat-gnome
[15:51] <seb128> or if you mean xchat-gnome itself to activate the indicator by default
[15:52] <jcastro> seb128: I meant xchat-indicator
[15:54] <Nafai> jcastro: Uh, so given mpt's feedback in #ubuntu-desktop, perhaps merely reproducing functionality wasn't exactly what was needed here for brasero :/
[16:14] <Nafai> FYI, I'm back to working on gnome-bluetooth
[16:42] <jono> Nafai, rock and roll :)
[16:42] <jono> jpetersen, how are you getting on?
[16:44] <jpetersen> jono, i am basically done with gnome-power-manager, just testing it after i did a small additional change
[16:44] <jpetersen> jono, and i started to look at gnome-media
[16:44] <jono> jpetersen, awesome :-)
[16:45] <jpetersen> jono, with gnome-media there is the question how to do the volume control scale in app indicators
[16:47] <jpetersen> jono, i mean this slider widget to control the volume
[16:47] <jono> jpetersen, actually ignore gnome-media for now, move onto the next one
[16:47] <jono> we need some design input on it
[16:48] <jpetersen> jono, yes ok
[16:49] <jono> jpetersen, yeah, so focus on  gnome-settings-daemon 
[16:49]  * vish notes kenvandine likes and is playing a lot with the memenu ;)
[16:51] <jpetersen> jono, ok i will do
[19:16] <Nafai> kenvandine: Uh, so I clicked "XChat Gnome" in the message indicators thingy...and I launch a new xchat gnome instance
[19:16] <Nafai> s/I launch/it launched/
[19:19] <seb128> kenvandine, ^
[19:30] <qense> I've got a problem with Indicator Application (C implementation) not using the actions as defined somewhere in the code. Instead it shows GTK+ stock menu items.
[19:30] <qense> What is needed to properly associate the actions with the menu passed to AppIndicator?
[19:31] <qense> I have used  g_object_set_data_full() to associate the ui_manager to the window
[19:39] <jono> Nafai, can you help qense
[19:39] <jono> or tedg can you help him ^
[19:39] <qense> :)
[19:39] <tedg> jono: Considering I have no scrollback :)
 I've got a problem with Indicator Application (C implementation) not using the actions as defined somewhere in the code. Instead it shows GTK+ stock menu items.
[19:40] <qense>  What is needed to properly associate the actions with the menu passed to AppIndicator?
 I have used  g_object_set_data_full() to associate the ui_manager to the window
[19:41] <qense> But somehow the actions aren't used in the menu
[19:42] <qense> tedg: ^^ (I always forget to include people's names when I'm talking to them...)
[19:42] <Nafai> tedg is probably best one to help :)
[19:43] <tedg> qense: It shows stock items or it connects to stock actions?
[19:43] <qense> tedg: both, but I think the stock icons aren't bad.
[19:43] <qense> Weirdly the menu items are defined with just the action and no icon, so it must read something iirc.
[19:44] <qense> They look like this: "<menuitem action='alt-speed-enabled'/>"
[19:44] <qense> and the action are defined from a dictionary/list like is done in the C example of the AppIndicator
[19:45] <tedg> Hmm, I've not done that before.  bratsche ^
[19:45] <qense> The patches as committed to the upstream trunk are here: <http://trac.transmissionbt.com/changeset/10133>
[19:46] <qense> yay! upstream before it's working properly! :S
[19:47] <jono> qense, you are awesome for working on this :)
[19:51] <qense> jono: thank you. But it is just a bit of work and I'm relying a lot on the code samples when programming C since I'm not very familiar with that language, don't give me too much honour. ;)
[20:25] <qense> tedg: It was caused by a bug: the strings were translated with glib's gi18n N_() function.
[20:25] <tedg> qense: Ah, I see.
[20:25] <qense> when I removed that function from around the label the right text was displayed, and even properly localised
[20:25] <tedg> qense: Hmm, but that means that it probably won't be setup to get translated.
[20:26] <tedg> qense: The N_() gets pulled into the .po files.
[20:26] <qense> ah
[20:26] <qense> that's what it's for
[20:26] <qense> ok, then is this a bug in AppIndictor?
[20:27] <qense> tedg: What does N_() do that could hinder Indicator Application?
[20:28] <tedg> qense: Typically it's just a pass through.
[20:28] <tedg> qense: One issue that sometimes comes up is with static strings.
[20:28] <qense> like "static GtkToggleActionEntry  pref_toggle_entries[]"? 
[20:28] <qense> that's one of the dictionaries
[20:29] <tedg> qense: I'll sometimes do something like:
[20:29] <tedg> #ifdef N_
[20:29] <tedg> #undef N_
[20:29] <tedg> #endif
[20:29] <tedg> #define N_(x) x
[20:29] <tedg> To get a cleaner pass through.
[20:29] <tedg> You'll need that if you want to do something like:  "bob" N_("alvin") "bob"
[20:30] <qense> ok
[20:33] <qense> tedg: whoops, I was wrong.
[20:33] <qense> That string that worked was already translated. It's not N_()'s fault this time. 
[20:33] <qense> painful mistake here :)
[21:41] <Nafai> jono, jcastro: quick update before I head out to my appointment.  I've got my initial version of gnome-bluetooth working, just I need to look over how the menus are created and figure out why app indicators are confused
[21:41] <jono> Nafai, sweet :)
[21:41] <Nafai> jono, jcastro: screenshot http://www.travishartwell.net/gnome-bluetooth.png
[21:42] <Nafai> So, possibly, 65-75% done.  Or possibly more :)
[21:42] <jcastro> \o/
[21:42] <jono> Nafai, great work, thanks for your hard work
[21:42] <Nafai> One thing I have noticed is that app indicators are picking smaller icons (or scaling them smaller) than the previous StatusIcon versions
[21:42] <Nafai> no problem, enjoying it
[21:43] <jcastro> Nafai: yeah that's why we need the icon names
[21:43] <jcastro> so the design people can do the right thing there
[21:43] <Nafai> cool
[21:43] <Nafai> I'll send you an updated list for gnome-bluetooth tonight after I have made sure which icons it uses
[21:44] <Nafai> bbl
[21:45] <jcastro> woo, this is looking sweet
[23:27] <Nafai> back
[23:27] <Nafai> tedg: You around?