[03:10] <Nafai> tedg: Hey
[03:10] <tedg> Nafai: Good Evening
[03:10] <Nafai> Should app indicators have any problems with a menu constructed by GtkBuilder that has sub-menus?
[03:11] <Nafai> My initial conversion of gnome-bluetooth has produced interesting results: http://www.travishartwell.net/gnome-bluetooth.png
[03:11] <Nafai> If you aren't familiar, the original version has sub-menus off of each of the devices (such as TMobile G1)
[03:12] <Nafai> tedg ^^
[03:12] <Nafai> :)
[03:14] <tedg> Nafai: In theory there shouldn't be any issue.  But I'm not sure if bratsche's GTK parsing code handles submenus.
[03:15] <tedg> Nafai: It shouldn't make a difference whether it's GtkBuilder or normal GtkMenu.
[03:15] <Nafai> I figured that shouldn't be the issue, but I wanted to give the full details
[03:17] <Nafai> I need to look at how the menus are built, perhaps there is something else I need to call, but I thought I'd run it by you as well
[03:19] <bratsche> Nafai: Does it work other than the submenu?
[03:20] <bratsche> I'm not sure if I added support for submenus.  If not I can do that tomorrow probably.
[03:20] <Nafai> bratsche: yes, the items that have actions associated with them do work
[03:20] <Nafai> Oh, one thing I noticed, those items that are insensitive are not styled any differently than sensitive items
[03:21] <Nafai> For example, in that screenshot, "Bluetooth: On" and "Devices" should be insensitive
[03:22] <tedg> Nafai: Hmm, both of those should work.
[03:22] <tedg> Nafai: You should file bugs on indicator-application for things that don't work so we don't forget them.
[03:23] <Nafai> Now that I think of it, I had the same issue with brasero
[03:23] <Nafai> Sure thing
[03:23] <Nafai> I'll file bugs on the potential sub-menu parsing issue and the insensitive thing
[03:24] <Nafai> (either tonight or first thing in the morning)
[03:24] <Nafai> glad I'm helping to find bugs :)
[03:24] <tedg> Yup, that's the fun of running alpha code :)
[03:24] <bratsche> Nafai: Can you assign the submenu parsing bug to me once you file it?
[03:26] <Nafai> Sure, what's your username on launchpad?
[03:27] <Nafai> You're Cody Russell, right?
[03:27] <Nafai> :)
[03:28] <Nafai> (I'm just as guilty, not using an easy nick -> name like tedg or jono or rickspencer3) :)
[03:30] <tedg> Nafai: Yes, but he fixed it on LP too ;)  http://launchpad.net/~bratsche
[03:30] <Nafai> :)
[03:31]  * Nafai files bugs
[03:31] <Nafai> Should I assign the insensitive one to anyone?
[03:32] <bratsche> You can assign that one to me too probably.  If it turns out to be more of a tedg thing then I'll reassign it.
[03:32] <Nafai> ok
[03:33] <Nafai> This one has it as the #3 item: https://bugs.launchpad.net/indicator-application/+bug/513924
[03:33] <ubot4> Launchpad bug 513924 in indicator-application "Tooltips, formatting, and unsensitive items (affects: 1)" [Undecided,New]
[03:33] <Nafai> Should I file a separate one?
[03:34] <bratsche> The submenu one as well.
[03:35] <Nafai> Right
[03:35] <Nafai> But since the insensitive one is already reported, should I just comment on that one saying "Me too"?
[03:36] <bratsche> tedg: https://bugs.launchpad.net/indicator-application/+bug/513924
[03:36] <ubot4> Launchpad bug 513924 in indicator-application "Tooltips, formatting, and unsensitive items (affects: 1)" [Low,In progress]
[03:36] <bratsche> tedg: Have any comments on #1 and #2?
[03:38] <tedg> bratsche: I'll comment on the bug :)
[03:38]  * bratsche grabs a bag of popcorn
[03:51] <Nafai> Ok, bug submitted #519625
[03:51] <Nafai> Plz school me on better bug reporting, kind of out of the habit.
[03:52] <nigel_nb> is there a particular debug process if notify osd does not show up notifications?
[04:01] <tedg> nigel_nb: Check to see if notify-send works.
[04:01] <nigel_nb> tedg, it does not work
[04:02] <tedg> nigel_nb: Then probably look at the log in ~/.cache and see if there is anything getting put in there.
[04:02] <nigel_nb> tedg, its bug 518524
[04:02] <ubot4> Launchpad bug 518524 in notify-osd (Ubuntu) "Pidgins notifications doesn't show anymore (affects: 1)" [Low,Incomplete] https://launchpad.net/bugs/518524
[04:02] <nigel_nb> what should I be asking?
[04:03] <nigel_nb> is there an apport hook for notifications?
[04:03] <tedg> nigel_nb: Hmm, I'm not sure what else to look for.  That is odd.  I don't believe there is an apport hook.
[04:04] <nigel_nb> tedg, I'll ask for the log then
[04:05] <nigel_nb> tedg, is the current version of notify-send 0.9.24?
[04:05] <nigel_nb> because in karmic its only 0.4.5
[04:07] <tedg> nigel_nb: No, they're versioned differently.  notify-send comes from the libnotify package not the notify-osd one.
[04:10] <nigel_nb> ah
[04:11] <nigel_nb> tedg, so, is there any info that I can get that would be helpful (besides log)
[04:11] <tedg> nigel_nb: Perhaps video card/driver.  I mean, the only thing I could think of at that point would be X bugs.
[04:12] <nigel_nb> tedg, will do, thanks :)
[04:37] <jono> tedg, did you see Nafai's mail?
[04:37] <tedg> jono: No
[04:37] <jono> tedg, he found a couple of bugs
[04:38] <Nafai> he wasn't on the list because I talked to him here :)
[04:38] <Nafai> he knows about the bugs
[04:38] <tedg> jono: Yes, we discussed them in the backlog :)
[04:38] <jono> ahhh sweet
[04:38] <jono> cool :)
[04:39] <tedg> jono: Were you eating dinner again?  Haven't I told you need to give up eating to keep up!?!?!  :)
[04:39] <jono> tedg, LOL
[04:39] <jono> my mistake tedg :)
[04:39] <jono> hey mccann :)
[04:39] <mccann> yo jono 
[04:39] <nigel_nb> tedg, I have asked for the log and info about video card + xorg log :)
[04:40] <jono> mccann, hows tricks?
[04:40] <tedg> nigel_nb: Cool, hopefully something comes of that.
[04:40] <nigel_nb> tedg, :)
[04:40] <mccann> jono: not bad.  trying to smoke a cigar and not doing very well
[04:41] <jono> mccann, lol
[04:41] <jono> wrong end? :)
[04:41] <mccann> uneven burn and i didn't have a cutter so i had to bite it and came out bad
[04:41] <jono> aha, gotcha :)
[04:44] <nigel_nb> tedg, for issues about notify-osd not working/intermittent, adding the log files would be standard work flow then?
[04:44] <tedg> nigel_nb: I think so.  We should probably figure out an apport hook for that....
[04:44]  * tedg is scared of Pythons
[04:44] <Nafai> heading for bed y'all, later
[04:45] <tedg> 'night Nafai
[04:45] <Nafai> tedg: I'm scared of the seas than the pythons
[04:45] <Nafai> er, the Cs :)
[04:45] <nigel_nb> tedg, I'm not sure if I can, but I can kill some time trying to tame it ;)
[04:46] <nigel_nb> i'll let you know if i come up with something :)
[04:46] <tedg> nigel_nb: Cool, that'd be great!
[05:22] <bratsche> mccann: Don't accidentally swallow the tip!
[05:44] <mccann> bratsche: ick
[05:45] <bratsche> Yum?
[06:10] <vish> seg|ars: hi.. when switching themes in gwibber , i think you should force the font colors as well..  ex: with Ubuntu gwibber theme , if you are using dark system theme ,[where the system fonts are white] gwibber becomes unreadable
[06:11] <seg|ars> that's on my todo list. I'm going to fix the font colors in the ubuntu theme
[06:12] <vish> neat..
[06:12] <seg|ars> most of the themes for gwibber use system colors throughout, the ubuntu one is (I think) the only one that has statically colored backgrounds
[06:12] <seg|ars> it's a pretty trivial fix. I just have to look at what colors are used in the adium version and apply those to the css in the gwibber one
[06:17] <vish> hmm , even the gwilouche,flat becomes kinda unreadable[seem to use system font color] , but Ubuntu theme is the worse 
[06:19] <seg|ars> ugh you are right
[06:20] <seg|ars> I should do more testing with a dark gtk theme
[06:25] <vish> seg|ars: should i reopen Bug #473515 ? or...
[06:25] <ubot4> Launchpad bug 473515 in ubuntu (and 1 other project) "Dark Theme results in white text on white background for updates (affects: 6)" [Undecided,Invalid] https://launchpad.net/bugs/473515
[06:26] <seg|ars> no, it's fine. I've added it to my todo list
[06:26] <vish> ok.. thanks
[06:26] <seg|ars> thanks for bringing it to my attention
[07:12] <nigel_nb> jono, are you around? could use some help with notify :)
[07:12] <nigel_nb> I'm writing (trying to write) an apport hook for notify-osd... any suggestions as to what all info should be attached besides the notify-log
[07:14] <jono> nigel_nb, I am about to head to bed
[07:14] <jono> you mean info in the bubble?
[07:15] <nigel_nb> jono, yep
[07:15] <jono> apport hook is a cool idea
[07:15] <jono> maybe summarize the problem
[07:15] <nigel_nb> yeah.  I was triaging bugs earlier and thought it might help.
[07:15] <nigel_nb> I'm still learning though.  right now, its set to only include the notify-osd.log from cache
[07:17] <nigel_nb> anything more you'd like me to add?
[07:18] <jono> nigel_nb, maybe:
[07:18] <jono> App Name crashed: summarize problem
[07:18] <jono> sweet, pal :-)
[07:18] <nigel_nb> jono, I'll play around and let you know what happens :)
[07:18] <jono> sweet!
[07:18] <jono> ok, I am heading to shower
[07:18] <jono> later!
[07:19] <nigel_nb> good nite :)
[10:22] <invernizzi> Hi there.
[10:22] <invernizzi> I just finished to develop an appindicate integration for Getting Things GNOME
[10:23] <invernizzi> I get a weird Segfault when the status is set the second time
[10:23] <invernizzi> any chance to understand why?
[13:57] <Nafai> Good morning
[13:57] <Nafai> invernizzi: Still around?
[13:57] <invernizzi> yes
[13:58] <jpetersen> Good morning
[13:58] <Nafai> Figure out the segfaulting issue?
[13:59] <invernizzi> not really
[13:59] <Nafai> hrm
[13:59] <invernizzi> I found an open bug for that
[13:59] <Nafai> so it happens when you call app_indicator_set_status?
[13:59] <invernizzi> yes
[14:00] <invernizzi> bzr branch lp:gtg, activate and deactivate the "notification area" plugin
[14:00]  * Nafai looks
[14:00] <Nafai> I've got some code where I've done it multiple times without issue, I wonder what's different...
[14:01] <Nafai> HI jpetersen, how's your porting stuff going?
[14:01] <invernizzi> well, maybe I'm doing something wrong. That's why I asked
[14:03] <Nafai> tedg is a great person to help :)
[14:03] <Nafai> python, hrm.  I wonder if it is a bindings issue
[14:03] <Nafai> invernizzi, Just run gtg in the root of the checkout?
[14:04] <invernizzi> or ./scripts/debug.sh
[14:04] <invernizzi> either one
[14:04] <Nafai> weird, it can't find configobj
[14:04] <Nafai> I'll install the deps
[14:05] <invernizzi> sure
[14:05] <Nafai> I've been doing too much C the last couple weeks :)
[14:06] <invernizzi> :-)
[14:06] <Nafai> okay, I can reproduce, let me put it in a debugger to find out
[14:07] <jpetersen> Nafai, hi i am just working on gnome-settings-daemon
[14:08] <Nafai> this has been fun so far, I'm starting my 4th conversion this morning
[14:12] <Nafai> just a sec, installing more debug symbols so I can get a full stacktrace
[14:12] <invernizzi> take your time
[14:19] <Nafai> hrm, I'm not familiar with the insides of this, but I have got a full C stack trace
[14:19] <Nafai> Did you say there was a bug this might apply to?
[14:19] <invernizzi> sure
[14:19] <invernizzi> i'll find it
[14:19] <Nafai> thanks
[14:20] <Nafai> perhaps I'll post this stack trace to it
[14:20] <Nafai> tedg: Who do we bug about the Python bindings?
[14:20] <tedg> Nafai: Probably the best person is kenvandine
[14:20] <Nafai> ok
[14:20] <Nafai> kenvandine: Hey! :)
[14:20] <kenvandine> :)
[14:21] <invernizzi> https://bugs.edge.launchpad.net/indicator-application/+bug/510169
[14:21] <ubot4> Launchpad bug 510169 in indicator-application "Segfault when setting status second time (affects: 2)" [Undecided,New]
[14:21] <tedg> Nafai: He doesn't hate Python, yet.  I'm trying to teach him.
[14:21] <Nafai> why would one hate Python?
[14:21] <Nafai> If the alternative is C? :)
[14:21] <jpetersen> is it possible to have multiple app indicators in one application?
[14:22] <jpetersen> that would be required for gnome-settings-daemon (screen, keyboard, a11y)
[14:22] <tedg> jpetersen: Should be, but I haven't tested it.
[14:22] <tedg> jpetersen: You might find bugs.
[14:22] <Nafai> invernizzi: Well, this stack trace is different
[14:22] <tedg> jpetersen: The key would be to ensure they all have different paths.
[14:23] <kenvandine> wow even included a test case!
[14:23] <invernizzi> Nafai, maybe because it's a differente application?
[14:23] <Nafai> http://gist.github.com/300339
[14:23] <Nafai> invernizzi: I would guess, if it were the same bug it would still end up at the same place at the top
[14:24] <invernizzi> right. But the description of the bug is really the same, so maybe they're related
[14:24] <Nafai> Right.
[14:25] <Nafai> kenvandine: should invernizzi attach this stack trace and repro steps as well to that bug?
[14:25] <jpetersen> tedg, yes it seems there is a problem that in app_indicator_init the second app indicator is registered with dbus_g_connection_register_g_object at the same path (/org/ayatana/NotificationItem)
[14:26] <jpetersen> tedg, that seems to fail
[14:26] <Nafai> jpetersen: just checking, you are giving the new ones unique names?
[14:26] <tedg> jpetersen: Hmm, okay.  So there is probably needed a new "_new" function that can take a custom path.
[14:27] <jpetersen> Nafai, yes but the path seems to be always the same
[14:27] <Nafai> ok, just double checking
[14:27] <kenvandine> in the example included in that bug i don't see the problem
[14:27] <kenvandine> and can't repro it in ipython
[14:27] <kenvandine> different bug
[14:29] <invernizzi> ok
[14:29]  * invernizzi waves and goes to sleep, will report the bug tomorrow
[14:31] <kenvandine> thx invernizzi
[14:33] <jpetersen> tedg, maybe one could include the id in the path?
[14:34] <tedg> jpetersen: Hmm... that works for me.  I like it.
[14:34] <jpetersen> something like /org/ayatana/NotificationItem/@id and /org/ayatana/NotificationItem/@id/Menu
[14:34] <tedg> jpetersen: Good idea, thanks!
[14:35] <Nafai> Looks like vino is another one like brasero, their statusicon inherits from GtkStatusIcon.  You know this would be easier to share code if they would have used composition instead of inheritance :)
[14:52] <jcastro> Nafai: I have some tips from mpt for vino
[14:53] <jcastro> Recommendation: Port menu directly. Change Preferences text to ?Show Remote Desktop menu:? ?Always?/?Whenever someone is connected?/?Never?.
[14:53] <jcastro> Nafai: make sense?
[14:53] <Nafai> Just a sec, let me look at the preferences again (just had it open)
[14:54] <Nafai> Ah, instead of the current "Notification Area", etc
[14:54] <Nafai> Yeah, makes sense
[14:54]  * jcastro nods
[14:54] <Nafai> So behavior is identical, just tweak the preferences dialog :)
[14:54] <jcastro> Nafai: what's the status of ken's reviews?
[14:54]  * jcastro would like to get some patches sent upstream today!
[14:54] <Nafai> kenvandine: status? :)
[14:55] <kenvandine> soon... sorry!
[14:56] <Nafai> np, just let me know if I can do anything
[14:56] <kenvandine> before lunch :)
[14:56] <Nafai> what's your timezone btw?
[14:56] <kenvandine> EST
[14:57] <Nafai> ok. I'm MST
[15:02] <Nafai> hopefully if bratsche figures out the bug I reported, I'll have another two for kenvandine to look at tomorrow (vino and gnome-bluetooth) :)
[15:05] <seb128> kenvandine, let me know if you need some help reviewing
[15:06] <kenvandine> nah, i already started, will finish it up real soon
[15:06] <kenvandine> seb128, thx though :)
[15:07] <seb128> np
[15:07] <jcastro> \o/
[15:13] <Nafai> can't wait until my first code is installed on someone's machine
[15:13] <Nafai> from the repo
[15:34] <kenvandine> Nafai, building brasero :)
[15:35] <Nafai> yay
[15:39] <Nafai> jcastro: How does this look? http://www.travishartwell.net/vino-prefs.png
[15:40] <jcastro> mpt: ^^^
[15:44] <Nafai> morning jono
[15:45] <mpt> Nafai, good
[15:46] <Nafai> cool, thanks
[15:46] <mpt> (I know I said "menu:" rather than "Menu", but that would make it inconsistent with all the other headings, and it would be a bit of a diversion to change them all)
[15:47] <Nafai> oh, heh, I didn't even notice the capitalization.
[15:47] <jono> hey Nafai :)
[15:48] <Nafai> looking forward to another jono webcast today :)
[15:48] <Nafai> just think, during the last one I asked you how I could get a job with Canonical
[15:51] <jono> Nafai, should be fun :)
[15:59] <kenvandine> Nafai, is there a way to test brasero without actually burning a disc?
[15:59] <Nafai> kenvandine: heh, yeah.  I just had it create ISOs
[15:59] <Nafai> just a second
[16:00] <Nafai> mind you, I don't have an optical drive in this laptop at all so I'm not sure if it presented me the options differently
[16:00] <kenvandine> ah
[16:00] <kenvandine> didn't know it would do that :)
[16:00] <kenvandine> thx
[16:01] <Nafai> after you choose "create new data project", there is a drop down at the bottom, mine defaults to an image file, perhaps you need to change that
[16:09] <kenvandine> Nafai, ok the patch looks good
[16:09] <kenvandine> and it works... but i get a segfault in brasero
[16:09] <Nafai> oh
[16:09] <kenvandine> if at the end of the burn you click around in the indicator
[16:09] <kenvandine> show and hide
[16:09] <kenvandine> then click cancel
[16:10] <Nafai> let me take a look :)
[16:10] <kenvandine> thx
[16:12] <GogglesGuy> Hi, I want to add ApplicationIndicator support to my application. Can I run the indicator-applet under XFCE (it suppossed to support gnome applets)?
[16:22] <kenvandine> seb128, actually could you review the gnome-control-center patch?  
[16:22] <kenvandine> i think you wanted that one :)
[16:22] <seb128> kenvandine, sure
[16:22] <kenvandine> bug 497857
[16:22] <ubot4> Launchpad bug 497857 in gnome-control-center (Ubuntu) (and 1 other project) "Support application indicators (affects: 1)" [Wishlist,Fix committed] https://launchpad.net/bugs/497857
[16:22] <seb128> kenvandine, well, I worked on g-c-c quite a bit over years and I'm fine doing reviews
[16:22] <seb128> so I'm happy to review this one yes
[16:23] <seb128> ;-)
[16:23] <kenvandine> seb128, thx
[16:23] <Nafai> for some reason I can't get it to show up as an indicator right now, it's falling back to a statusicon
[16:25] <seb128> is indicator-application-service running?
[16:25] <tgpraveen12> is gnome-user-share present in default install in lucid? it is reqd for bluetooth receive to work
[16:25] <Nafai> seb128, Yeah, it is
[16:26] <tgpraveen12> i should ask in #ubuntu-desktop i guess
[16:26] <seb128> Nafai, try removing the applet and added it again maybe
[16:26] <Nafai> weird, did a complete re-compile and it works now
[16:26] <Nafai> must have been linking weird or something
[16:26] <seb128> tgpraveen12, no it's not
[16:26] <seb128> Nafai, ok
[16:27] <Nafai> kenvandine: Okay repro'd, now investigating
[16:27] <kenvandine> cool
[16:38]  * Nafai wonders if this is a case of finalize already being called
[16:38] <Nafai> got look up the semantics of that
[16:43] <Nafai> kenvandine: So, a little C debugging advice, I can read the back trace: http://gist.github.com/300520
[16:43] <Nafai> but when I try to print the values in the memory locations in gdb (print *self, for example, to see what values are in that parameter), I'm getting "cannot access memory address at 0xf00"
[16:44] <Nafai> I'm doing this by loading the program and a core dump, btw
[16:48] <Nafai> stepping away for a short break, bbiab
[17:00] <tedg> GogglesGuy: I've never tried, but I don't see any reason it wouldn't work if they support gnome applets.
[17:01] <tedg> GogglesGuy: There was also a port of the messaging menu at some point to a native XFCE applet, it seems like that could be updated to work pretty easily.
[17:01] <tedg> kenvandine: Have you heard much about that recently? ^
[17:02] <GogglesGuy> tedg: thanks. I'm trying to build the various packages now
[17:02] <kenvandine> Mark__T did it
[17:50] <Nafai> back
[17:54] <Nafai> ok, back to tracking down that segfault
[17:56] <jcastro> Nafai: which app are you on?
[17:56]  * jcastro scrambles to get the bug #'s straight
[17:57] <Nafai> jcastro, brasero, ken found a crasher :)
[17:57] <jcastro> ah
[17:57] <Nafai> but, otherwise, I'm working on vino
[17:59] <jcastro> would it be safe to say that everything in the project is now blocking on ken? 
[17:59] <jcastro> :p
[18:00] <Nafai> well, technically, gnome-bluetooth is blocked on bratsche :)
[18:04] <jcastro> ah this is the nested menu bits right?
[18:04] <Nafai> yes
[18:07] <kenvandine> hehe :)
[18:07] <kenvandine> Nafai, any progress on brasero?
[18:07] <kenvandine> what else is waiting for me to review?
[18:08] <kenvandine> seb128 is reviewing g-c-c
[18:08] <Nafai> kenvandine: no, not yet, perhaps some help in debugging
[18:08] <Nafai> I've got the backtrace, and it's in gtk code.  but it can't find the code on my system because it is looking for it in /build/buildd
[18:08]  * kenvandine isn't great at that
[18:08] <jcastro> kenvandine: g-p-m needs a look
[18:08] <kenvandine> ok
[18:09] <Nafai> I did an apt-get src libgtk2.0-0 and added the appropriate source line in gdb, but that didn't seem to help
[18:09] <kenvandine> Nafai, which package?
[18:09] <kenvandine> you should install the -dbg packages for the libs
[18:09] <kenvandine> ah
[18:09] <Nafai> yeah, have those too
[18:10] <kenvandine> you do?
[18:10] <kenvandine> deb http://ddebs.ubuntu.com lucid main restricted universe multiverse
[18:10] <kenvandine> in your sources?
[18:10] <kenvandine> libgtk2.0-0-dbg
[18:10] <kenvandine> you have that installed?
[18:10] <Nafai> yeah
[18:11] <Nafai> ok, figured it out
[18:11] <Nafai> by the time this function is called, the ui manager is already NULL
[18:12] <Nafai> wee.
[18:13] <Nafai> probably because g_free(cobj->priv) has already been called in the finalizer
[18:13] <Nafai> I would think the indicator should go away by this time
[18:13]  * Nafai reads the original code
[18:21]  * Nafai tries something
[18:30] <Nafai> ok, interesting
[18:31] <Nafai> in the tray icon  version, you left click on it when the burn is complete, the icon and dialog disappears and it goes back to the main window
[18:35] <Nafai> is activate the signal that gets called when an item is clicked?
[18:37] <Nafai> kenvandine (or any other gtk hackers): around?
[18:39] <Nafai> Here's what is happening.  BraseroTrayIcon inherits from GtkStatusIcon.  So when finalize is called for GtkStatusIcon from BraseroTrayIcon's finalize, the widget is destroyed, etc.
[18:40] <Nafai> I'm not doing anything other than calling g_free on the private data structure of BraseroAppIndicator (which holds as a data member an AppIndicator)
[18:40] <Nafai> Is there something I need to call on AppIndicator to tell it to "go away"?
[18:40] <Nafai> tedg^^ perhaps?
[18:41] <kenvandine> or clicked
[18:42] <kenvandine> humm
[18:42] <Nafai> because finalize has been called by this time, that's why we are getting segfaults because of invalid pointers
[18:43] <kenvandine> yeah
[18:43] <kenvandine> the examples on the wiki don't show anything about cleaning up
[18:43] <Nafai> kind of a problem :)
[18:44] <tedg> Nafai: You need to do a g_object_unref
[18:45] <Nafai> Of the AppIndicator pointer?
[18:47]  * Nafai tries
[18:47] <tedg> Nafai: Yes.
[18:47] <Nafai> ok
[18:49] <kenvandine> i think you did
[18:50] <kenvandine> if (priv->indicator) {
[18:50] <kenvandine> should be 
[18:50] <kenvandine> if (priv->indicator != NULL) {
[18:50] <kenvandine> i think
[18:50] <kenvandine> right tedg?
[18:50] <kenvandine> although... i wonder why finalize is getting called a second time
[18:50] <kenvandine> i guess missing a unref then
[18:51] <tedg> kenvandine: I'm not looking at the code, but I would say that you shouldn't unref a NULL pointer :)
[18:51] <kenvandine> yeah... but if (priv->indicator)
[18:51] <kenvandine> is not the same as
[18:51] <kenvandine> if (priv->indicator != NULL)
[18:51] <tedg> They're actually the same.
[18:51] <kenvandine> they are?
[18:51] <tedg> In some compilers.
[18:51] <kenvandine> hehe
[18:51] <kenvandine> ok
[18:51] <Nafai> yeah, the unref didn't change things
[18:51] <tedg> TRUE = !0
[18:51] <tedg> NULL == 0
[18:55] <Nafai> Sorry if I'm slightly unresponsive for a few minutes; my wife forgot a short paper for her college class at home and I have to re-type it for her because she didn't save it only printed it.  :)
[19:03] <Nafai> ok
[19:03] <Nafai> back to this
[19:05] <Nafai> Trying to figure out what's appropriate here
[19:11] <qense> I've got a problem with actions used in a menu in AppIndicator. The custom labels aren't used, but the stock labels instead.
[19:13] <qense> I've got no idea how to solve this, could anyone help?
[19:13] <qense> The changeset of the support can be found at <http://trac.transmissionbt.com/changeset/10133>.
[19:14]  * Nafai looks
[19:15] <Nafai> where is the menu constructed in that code?
[19:18] <qense> Nafai: in ui.h, give me a sec, I'm looking up a link to the files
[19:18] <Nafai> thanks
[19:19] <qense> Nafai: Menu is 'icon-popup' in <http://trac.transmissionbt.com/browser/trunk/gtk/ui.h>, the actions are defined in <http://trac.transmissionbt.com/browser/trunk/gtk/actions.c>.
[19:19] <qense> the menu is at the bottom of the ui.h file
[19:21]  * Nafai nods
[19:21] <Nafai> I'm looking at the GtkActionEntry array, and it looks similar to the ones I've used before
[19:22] <Nafai> I'm not sure what could be going on
[19:23] <Nafai> tedg, bratsche?  Perhaps one of you could look at qense's problems?
[19:23] <Nafai> qense: btw, are you qense on digg.com? (I assume since it is an unusual nick)
[19:23] <qense> Nafai: yes, that's what was bugging me, the 
[19:23] <qense> code looks perfectly normal
[19:23] <qense> Nafai: tedg already had a look on it yesterday but couldn't find it
[19:23] <qense> Nafai: I am qense on Digg, yes
[19:24] <Nafai> Whenever I look at upcoming, digg tells me that you are the digg'r most like me
[19:25] <Nafai> I'm nafai77
[19:25] <qense> Nafai: that name does sound familiar
[19:25] <bratsche> qense: "The custom labels aren't used, but the stock labels instead."  <-- that will always happen if you use stock.
[19:25] <bratsche> Because stock items are not just a convenience for loading icons, they really are a matched pair.
[19:26] <qense> bratsche: but according to the GTK+ documentation of GtkActionEntries/Array(What's it called again?) this shouldn't happen when the label is not NULL.
[19:26] <qense> bratsche: http://library.gnome.org/devel/gtk/unstable/GtkActionGroup.html#GtkActionEntry
[19:27] <bratsche> I'd have to trace through some code to see what the problem is.  There's a possibility that this documentation is wrong. :/
[19:28] <bratsche> I also don't completely understand how the icon naming spec stuff works though.
[19:29] <qense> bratsche: these action entries do work the way the documentation says it should when launching it next to a GtkStatusIcon, but not when sending it to AppInd via libdbusmenu.
[19:29] <qense> However, I couldn't find anything in the code of AppInd or libdbusmenu that changed the menu or the actions.
[19:29] <bratsche> Ah okay, then maybe it's a bug of mine.
[19:30] <bratsche> Feel free to file bugs in Launchpad and assign to me.
[19:30] <GogglesGuy> Is there a document that describe the differences between the  KStatusNotifier API and the added extensions?
[19:30] <qense> bratsche: OK, I'll file a bug.
[19:42] <jcastro> kenvandine: how goes the reviewing? I'm concious of not running into your release day of death tomorrow.
[19:43] <Nafai> jcastro: advice
[19:44] <Nafai> so I found out why it was segfaulting
[19:44] <Nafai> in the GtkStatusIcon version, when you click on it after the burning is done, it goes way, closes the dialog box and goes back to the main window
[19:45] <kenvandine> we should do the same thing
[19:45] <jcastro> yeah
[19:45] <Nafai> but can I capture the mouse click?
[19:45] <jcastro> we should not alter behavior I don't think.
[19:45] <Nafai> because doesn't it automatically just show the menu?
[19:47] <tedg> GogglesGuy: We're working on a wiki page for that, but you can look at notification-item.xml in lp:indicator-application and that's the basics.
[19:48] <Nafai> tedg: can I catch a mouse click event or something?
[19:49] <tedg> Nafai: No
[19:50] <GogglesGuy> tedg: ok thanks. (FYI I'm porting a non-gtk/non-kde to use the new status icon, so I'm using the dbus api directly.) 
[19:50] <jcastro> GogglesGuy: which app?
[19:50] <tedg> Nafai: It seems to me the status should be update to "complete" and you can show the window with a menu item.
[19:51] <Nafai> Is the dbus api documented any where?  I'd like to be able to connect to app indicators with emacs, which has dbus support now :)
[19:51] <tedg> GogglesGuy: The only part of libappindicator that is GTK is the menu support.  You could probably easily comment that out and steal the rest of the code :)
[19:51] <Nafai> tedg: so I would change the menu item for "cancel" to "close" probably
[19:51] <qense> bratsche: assigned you to bug #520048
[19:51] <ubot4> Launchpad bug 520048 in indicator-application "Custom labels in GtkActionEntries aren't resepected by Application Indicators C-bindings (affects: 1)" [Undecided,New] https://launchpad.net/bugs/520048
[19:51] <tedg> Nafai: Makes sense to me.
[19:52] <Nafai> okay, I'll do that
[19:52] <Nafai> shouldn't take too long
[19:52] <GogglesGuy> jcastro: http://code.google.com/p/gogglesmm
[19:53] <jcastro> GogglesGuy: cool!
[19:56] <qense> AppIndicator support for byobu! :P
[20:18] <kenvandine> https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators#Automake fu
[20:19] <kenvandine> Nafai, smithj: ^^
[20:20] <Nafai> kenvandine: Thanks
[20:21] <smithj> oh, nice
[20:21] <kenvandine> Nafai, it is a little better than what i gave you this morning
[20:22] <kenvandine> but it actually allows upstreams to disable it if they want :)
[20:22] <smithj> i was banging my head against that a few days ago
[20:22] <kenvandine> i think they will be happier with that :)
[20:22] <Nafai> okay, I'll update my patches :)
[20:22] <kenvandine> thx
[20:22]  * kenvandine does hate autotools
[20:22] <Nafai> me too
[20:22] <smithj> yeah. auto* is short-bus special
[20:22] <kenvandine> hehe
[20:34] <jono> Nafai, how is today's progress?
[20:38] <seb128> tedg, is calling app_indicator_set_status() with the current status a no-op call?
[20:38] <seb128> tedg, ie, is it worth to do "get current status; check with new one; set_status if different" rather than just setting it?
[20:39] <tedg> seb128: Yes, it should be a no-op.
[20:39] <seb128> tedg, ok thanks
[20:41] <Nafai> jono: not bad, fixing a bug that ken found in brasero, and have made decent progress on vino
[20:42] <jono> Nafai, awesome :)
[20:42] <jono> Nafai, based on your progress is it likely that Vino will be completed today, or more likely tomorrow?
[20:43] <Nafai> probably more likely tomorrow
[20:44] <jono> Nafai, no worries :)
[20:44] <Nafai> ok, good
[20:44] <jono> I have one more to add to your list, I will mail you
[20:44] <Nafai> ok, good
[20:52] <seb128> Nafai, I just had a first look to the g-c-c change and commented on the bug
[20:52] <Nafai> ok, checking
[20:52] <seb128> Nafai, where has the "use 2 icons and no gradiant color" being discussed?
[20:53] <Nafai> unfortunately, just in e-mail and a bit here on the channel
[20:53] <seb128> no problem
[20:53] <seb128> jcastro, ^
[20:55] <Nafai> reply to a comment in launchpad, or is it copy-paste?
[20:55] <seb128> copy-paste
[20:55] <seb128> or use email and reply
[20:57] <jcastro> seb128: what's up?
[20:57] <seb128> jcastro, bug #497857 
[20:57] <ubot4> Launchpad bug 497857 in gnome-control-center (Ubuntu) (and 1 other project) "Support application indicators (affects: 1)" [Wishlist,Fix committed] https://launchpad.net/bugs/497857
[20:57] <seb128> "As agreed on with jcastro, this only supports showing green when plenty of time before locked -> showing red right before -> locking."
[20:57] <seb128> jcastro, ^ can we get some rational for that on the bug?
[20:57] <jcastro> right, there was some blinking or something before
[20:57] <seb128> I though we were porting things
[20:57] <seb128> not changing behaviour?
[20:58] <jcastro> right, but this had blinking
[20:58] <jcastro> and iirc tedg and maybe someone else was like "no blinking!"
[20:58] <seb128> can we get a rational about why we don't want that?
[20:58] <seb128> will avoid upstream asking
[20:58]  * jcastro nods
[20:58] <seb128> thanks
[20:59] <seb128> I don't really care either way
[20:59] <seb128> I just want to be ready for upstream comments :-)
[20:59] <jcastro> tedg: thoughts?
[20:59] <jcastro> I remember this coming up and we mostly all nodded that blinking was bad
[21:00] <seb128> I'm not sure I agree
[21:00] <seb128> I keep missing people who im me since I use the message indicator
[21:00] <Nafai> part of the issue, also, is that there is the gradual changing to a darker green
[21:00] <tedg> jcastro: I thought it was in the design guidelines...
[21:00] <seb128> no blinking is for sure less noticable
[21:00] <Nafai> and I'll need pre-generated icons in order to do this
[21:01] <seb128> Nafai, you can use pixbuf the way upstream code is doing?
[21:01] <seb128> could rather
[21:01] <jcastro> tedg: the design guidelines don't mentioning blinking at all
[21:01] <tedg> jcastro: Hmm, no, just looking.
[21:02] <Nafai> seb128: as far as I'm aware, no, unless I manually load the pixbufs into an icon theme with the right size
[21:02] <Nafai> which I'm not sure how to find the right size
[21:02] <seb128> tedg, also is that normal that our menus don't respect the no icon thing?
[21:02] <tedg> seb128: No, we're not passing pixbufs to allow for panel theming.
[21:02] <tedg> seb128: The no icon thing is a bug.
[21:02] <tedg> seb128: It's been... low priority :)
[21:02] <seb128> Nafai, tedg: ok, thanks
[21:03] <tedg> jcastro: I think that we should probably work with mpt to get something in the design guidelines like that.  I could have sworn he wrote something about it already, but I can't find it.
[21:03] <jcastro> tedg: I thought blinking in general was frowned upon right?
[21:03] <tedg> I would say in general yes.  It's mighty annoying. :)
[21:04] <seb128> it's useful though
[21:04] <seb128> I would not keep missing message if the thing was blinking
[21:04] <jcastro> Nafai: how much work is it to keep the blink?
[21:04] <tedg> seb128: There's rarely something important enough to justify blinking :)
[21:04] <seb128> and I'm not the only one by looking at user feedback
[21:04] <jcastro> I would rather err on the side of "that's how upstream did it before we touched it"
[21:04] <seb128> tedg, seems pitti got in trouble with his wife due to it :-p
[21:04] <tedg> seb128: Better grabbing of attention, I'm with you, but blinking... that's too much.
[21:05] <Nafai> jcastro: probably not too bad, really, just switching the icon
[21:05] <Nafai> it's the gradual getting darker as time goes on that I can't yet do :)
[21:05]  * tedg would love to see that conversation: "Honey, it's not you, it's the icon theme I swear!"
Ok let's go with blink and then let the designers argue about it, this way we'll just follow what upstream does in the meantime.</blink>
[21:05] <seb128> tedg, ;-)
[21:06] <seb128> jcastro, Nafai: maybe try a first patch this way and wait for comments from upstream
[21:06] <jcastro> Nafai: and we'll make a note when we submit it upstream the limitation with the darkening green
[21:06] <seb128> if we believe that blinking is annoying
[21:06] <seb128> we can update if they care about it
[21:06] <Nafai> ok
[21:06] <jcastro> ok sounds good to me
[21:06] <Nafai> I'm almost done commenting on your comments seb128
[21:06] <jcastro> ok let's do that
[21:06] <seb128> ok
[21:06] <seb128> Nafai, cool
[21:11] <Nafai> so I am unclear...we decided I should add the blinking?  I don't believe it to be too hard, really, just adding a couple of calls to set_attention_icon
[21:11] <jcastro> no
[21:12] <jcastro> let's leave it off
[21:12] <jcastro> and see what upstream says
[21:12] <jcastro> and if they care about the blinking we'll turn it on
[21:12] <Nafai> ok
[21:13] <Nafai> so let's address seb128's other concerns he has commented on and then we're ready to submit upstream and package for lucid?
[21:13] <Nafai> btw, it's great to be getting feedback like this.  It's been a while since I've worked somewhere where they care enough to take the time to do reviews :)
[21:15] <seb128> Nafai, ok, makes sense for the text change
[21:15] <seb128> Nafai, address the other comments and I think we are good for upload
[21:15] <seb128> Nafai, thanks for your work ;-)
[21:15] <Nafai> thank you!
[21:19] <kenvandine> tedg, ping
[21:19] <Nafai> I'll also update configure.ac to match the update kenvandine put on the wiki
[21:19] <kenvandine> ;)
[21:20] <tedg> Afternoon kenvandine
[21:20] <kenvandine> tedg, does libappindicator do anything that scales the icon size down?
[21:20] <kenvandine> looking at gnome-power-manager, the icon looks pretty small
[21:20] <kenvandine> and i don't see anything that jpeterson did to cause it
[21:21] <tedg> kenvandine: I don't believe so.  There is no application control for icon size.
[21:21] <kenvandine> i am guessing the applet doesn't provide as much space to draw
[21:21] <kenvandine> like extra padding
[21:21] <tedg> kenvandine: I bet that design put padding around it for the notification area, and now we don't need that.
[21:21] <kenvandine> so with a tall thin icon like the battery
[21:22] <kenvandine> it looks pretty tiny
[21:23] <kenvandine> tedg, so do you think the icon has the padding or the area we give it has the padding?
[21:23]  * kenvandine changes icon themes
[21:24] <tedg> kenvandine: I think both, and I think that's the issue.
[21:24] <jcastro> Nafai: so let's address seb128's other concerns he has commented on and then we're ready to submit upstream and package for lucid? <--- YES!
[21:26] <Nafai> :)
[21:26] <kenvandine> tedg, so where should that bug get filed?
[21:27] <tedg> kenvandine: Considering the padding is a GTK theme issue, and the icon is a theme issue, I think you should file it directly on kwwii ;)
[21:27] <tedg> kenvandine: I imagine the icon theme will be the one to change though.
[21:27] <kenvandine> ok
[21:28] <kenvandine> hey jpetersen
[21:28] <Nafai> So is the _( ) a macro for localization stuff?
[21:28] <kenvandine> yes
[21:28] <jpetersen> hi
[21:30] <Nafai> geez busy birthday coding
[21:33] <kenvandine> jpetersen, see comment on the g-p-m bug, mostly looking good
[21:33] <seb128> kenvandine, tedg: the icon difference is noticable on rhythmbox too
[21:33] <kenvandine> tweak the autotools stuff, which i updated on the wiki
[21:33] <kenvandine> seb128, yeah i am not convinced that is the theme's fault :)
[21:34] <jpetersen> kenvandine, ok i will look
[21:34] <kenvandine> maybe indicator-applet needs to give it more space that it is
[21:34] <kenvandine> we have to assume apps have icons optimized for the notification area
[21:34] <jcastro> jpetersen: did you send a list of icons for gpm with your last report?
[21:34] <seb128> I think that's the applet having pading or something
[21:34] <tedg> seb128: yes, they will be smaller, just because we have padding, which didn't happen before.
[21:37] <kenvandine> tedg, so doesn't it make sense to reduce/remove the padding in the indicator-applet?
[21:38] <tedg> kenvandine: No :)
[21:38] <jpetersen> jcastro, i will send the list of icons to you
[21:38] <tedg> kenvandine: It makes sense to steal the padding patch from Fedora for the notification area ;)
[21:38]  * kenvandine would rather not make the upstreams hate us
[21:38] <jcastro> jpetersen: no worries!
[21:39] <kenvandine> tedg, what does it do?
[21:39] <seb128> tedg, I'm not sure their patch is doing padding this way, it's rather doing spacing between icons
[21:39] <tedg> seb128: Oh, so only horizontal?
[21:39] <vish> tedg: the fedora padding was for 22/24px icons , the app indicators already use 16px and seem to have good pagging ;)
[21:40] <vish> padding*
[21:40] <seb128> kenvandine, http://blogs.fedoraproject.org/wp/mclasen/2009/10/26/5-little-things/
[21:40] <seb128> tedg, ^ see screenshot
[21:41] <seb128> the firefox icon goes to the bar limit
[21:41] <kenvandine> "Status icons have any number of problems. Two of the bigger problems are that they are all crammed together"
[21:41] <kenvandine> i don't really think that is one of the bigger problems :)
[21:41] <kenvandine> anyway
[21:42] <kenvandine> seb128, yeah so just horizontal
[21:43] <tedg> Hmm, honestly, I think we should pass that question off to design.  I think it is a gtk/icon theme thing.  Right now it's just menubar defaults.
[21:44] <kenvandine> oh right, so it knows it is a menubar
[21:44] <seb128> tedg, I'm still not clear what the visual difference is between active and attention status btw
[21:45] <tedg> seb128: It just swaps the icons right now.  So it depends on the application setting those icons.
[21:45] <seb128> how is that different of using set_icon?
[21:47] <seb128> Nafai, the patch seems to have a bug too
[21:47] <seb128> Nafai, I never get an another icon than the green one
[21:47] <Nafai> seb128: do you have the latest app indicator libraries installed?
[21:47] <seb128> ie it doesn't turn red before the break
[21:47] <tedg> seb128: In many ways it isn't.  But, it's what we inherited from KDE :)
[21:47] <Nafai> that didn't work until yesterday
[21:47] <Nafai> with tedg's latest changes
[21:48] <seb128> Nafai, I dist-upgraded one hour ago
[21:48] <tedg> seb128: I imagine in the future we could do something like remove some padding or something :)
[21:48] <Nafai> doh
[21:48] <Nafai> I hope it's not broken again :(
[21:49] <Nafai> weird
[21:49] <Nafai> I switch from const char [] to #define and now the compile is acting like it doesn't see the string :(
[21:50] <seb128> what line did you use?
[21:50] <Nafai> #define TYPING_MONITOR_ACTIVE_ICON "bar-green";
[21:50] <Nafai> Oh
[21:50] <Nafai> don't need the ;
[21:50] <Nafai> :)
[21:51] <seb128> right
[21:51] <Nafai> I've been away from active C dev for a while, it seems
[21:57] <nigelbabu> tedg, looks like I dont have to write apport hook after all, its already written for lucid :)
[21:58] <Nafai> seb128: hrm, I haven't dist-upgraded since last night and it still switches icons here :(
[21:59] <tedg> nigelbabu: Cool, thanks for looking!
[22:03] <nigelbabu> tedg, I spent quite some time writing one ;) when I was about to generate a diff, noticed the new one :)
[22:35] <Nafai> okay, updated patch for gnome control panel attached to the launchpad bug
[22:58] <seb128> Nafai, I'm wondering if the blink callback need to be called at all in the indicator case...
[22:58] <seb128> Nafai, would space cpu cycles to not have a timeout function called every second for something we don't use
[22:58] <Nafai> oh, good point
[22:58] <Nafai> :)
[22:59] <Nafai> give me a minute
[22:59] <seb128> no hurry
[23:00] <seb128> I will not sponsor that tonight now anyway
[23:00] <seb128> I'm about to go to bed
[23:00] <seb128> that's for tomorrow morning
[23:01] <Nafai> ok
[23:01] <Nafai> thanks for the help
[23:03] <seb128> np
[23:16] <jcastro> Nafai: ok so g-c-c is ready to go upstream?
[23:16] <Nafai> I'm doing one final test, where the blink stuff isn't even compiled/ran
[23:16] <jcastro> ok
[23:16] <Nafai> if that works, I'm attaching and it should be
[23:17] <Nafai> :)
[23:17] <jcastro> I'm going to answer his question in the upstream bug tracker, and then you can attach the patch
[23:19] <Nafai> sounds good
[23:21] <jcastro> Nafai: ok ping me when the final test is passed, and I'll click send. :D
[23:27] <Nafai> ok, got some tweaking so it will compile correctly without using app indicators, just a sec
[23:28] <Nafai> oh, nevermind, it was on auto so it detected I had it.  I'm recompiling with enable=no. :)
[23:30] <GogglesGuy> question: Can the menu property be set to empty?
[23:33] <Nafai> jcastro: attached my final patch to the launchpad bug
[23:34] <jcastro> sweet
[23:34] <jcastro> Nafai: can you attach it to gnome bug pls?
[23:34] <Nafai> Sure thing
[23:34] <jcastro> https://bugzilla.gnome.org/show_bug.cgi?id=606671
[23:34] <ubot4> Gnome bug 606671 in general "Support for application-indicators/StatusNotifierIcon" [Enhancement,Unconfirmed]
[23:38] <Nafai> Do I need to put much detail with the patch?
[23:38] <Nafai> (first time working with an upstream)
[23:38] <Nafai> In the comment, that is
[23:39] <jcastro> Do something like, "Here's the first attempt"
[23:39] <jcastro> also, do something like
[23:39] <jcastro> "Here's the link to our bug in Launchpad where it's been getting reviews"
[23:40] <jcastro> that way he sees that someone has been reviewing it
[23:42] <Nafai> ok, patch submitted!
[23:43] <Nafai> Okay, finally back to brasero
[23:44] <jcastro> Nafai: woo! one down!
[23:44] <Nafai> Yay!
[23:44] <Nafai> bratsche: Have you had a chance to look at the submenu parsing bug?  Or do you have an ETA?
[23:44] <Nafai> Not blocking my work entirely, I've got others I'm working on, just curious
[23:45] <Nafai> jono: btw, you mentioned you were going to e-mail me with another assignment
[23:45] <jono> Nafai, will do
[23:45] <jono> on the list :)
[23:46] <Nafai> cool, just curious :)
[23:47] <bratsche> Nafai: Sorry I haven't had a chance yet.. I'll let you know when I do.
[23:48] <Nafai> no problem, thanks
[23:48] <bratsche> Has anyone here ever used rsvg from Python?  The example code that comes with python-rsvg doesn't even seem to work.
[23:52] <Nafai> Okay, noooow back to brasero