[01:11] mwhudson: ping [01:11] bug 298284 [01:11] comments? [01:11] Bug #298284: No headers suitable for filtering branch subscription emails for Gmail users [01:13] wgrant: since you are around, any comments on that bug? [01:13] "fuck stupid mail clients", basically. [01:14] wgrant: well... around 50% of the launchpad users use gmail [01:16] Silly people. [01:18] silly gmail too [01:18] thumper: i can't see how setting list-id as stub suggests would hurt [01:18] perhaps you submit bugfixes.... [01:18] oh right, its proprietary [01:19] what you can do is write a imap client to do filtering for you on the gmail boxen [01:26] Is there a good reason that revision emails come from noreply@ rather than the committer? [01:32] wgrant: no [01:32] wgrant: at least I don't think so [01:32] wgrant: what if the person doesn't want their email address shown? [01:32] wgrant: or we don't know who they are... [01:33] mwhudson: I'm beginning to think we should just do it (add a list id that is) [01:33] thumper: If they're committing to a public branch with an email address but don't want it disclosed, they are probably insane. [01:33] mwhudson: conduct an experiment for code email, and if it ends up working, get other LP email sources to add it too [01:33] wgrant: heh [01:33] wgrant: some of our users are insane [01:33] thumper: +1 [01:34] * thumper is finally through the inbox [01:34] * mwhudson has a desk to put together, will be in and out irc-wise [03:24] mwhudson: my first balsamiq mockup sent to the list (and you) [03:24] mwhudson: do you think this is the right approach to starting? [03:24] (I do) [03:26] * mwhudson looks [03:47] * thumper afk for a bit to get dinner on [04:12] Ursinha: are you really here [04:12] ? [04:58] * thumper EODs [05:00] ciao [07:38] G'day all. [08:46] Morning [10:25] bigjools: I don't think anybody cares in the slightest about the "maintainer defaults". We have been saying this for years! [10:26] wgrant: ? [10:26] Bug 521722 [10:26] Bug #521722: Display of Component on distro source summary page may be wrong (but we know the right value) [10:28] wgrant: fine, we should just remove that column then [10:35] bigjools: Why not replace it with the real value? [10:35] bigjools: re: https://code.edge.launchpad.net/~wgrant/launchpad/sprbu-columns-to-sprb/+merge/18995 , do we have a record on who did the upload elsewhere? (SourcePackageRecipeBuildUpload.registrant at the moment) [10:35] what real value? [10:35] it's got many [10:35] which are listed below [10:35] (or wgrant) [10:35] stub: SourcePackageRecipeBuild.requester. [10:35] what he said [10:36] bigjools: The current component in the development series is the current component. [10:36] k [10:36] wgrant: I don't see the benefit of repeating it [10:36] bigjools: Hm, true, it is just there. [10:37] Also, I wonder if we can make https://launchpad.net/debian/+source/dpkg more useful. The table doesn't take Pending SPPHs into account, so it's empty for gina'd archives. [10:39] I'm currently downloading the sources of Launchpad through the installer, and this seems to be rather slow, I'm stuck at 33760 or something and it freezes from time to time [10:39] Can we download them from another place? [11:06] stub: Thanks. [11:22] Ursinha: hi, any idea why for bug 509252 the status was not updated? [11:22] Bug #509252: Remove AdminPoTemplateSubset from security.py [11:26] allenap, let me know when you have some time to help me with the bug problem i emailed you about [11:26] leonardr: Very soon, I just saw your message. [11:28] i've made a little progress in diagnosis [11:29] leonardr: Okay, there are some weird things to do with bug comments/messages. I'll get your branches and try to replicate here. [11:29] allenap, i can tell you it's not a navigation problem. a stock launchpad branch also turned up with a BugComment object there [11:33] leonardr: So I should be able to replicate with only your lazr.restful branch? [11:34] allenap: my launchpad branch includes changes necessary to integrate the new lazr.restful branch [11:34] so you'll need both [11:44] allenap: i've confirmed that in a stock launchpad, the same code runs and self.entry.parent returns None [11:44] so i think it's something to do with the way the entry adapter was generated [11:46] leonardr: Okay. [11:49] leonardr: I think I'm being stupid. How do you normally set up your lazr.restful branch in a Launchpad branch? [11:50] allenap, good question [11:50] symlink it to a directory in your launchpad root directory [11:51] and change buildout.cfg to mention it [11:51] develop = [11:51] . [11:51] lazr.restful.dev [11:51] then run bin/buildout [11:51] leonardr: Ah ha, that sounds good. Thanks [11:55] allenap: does this make any sense to you? i've got both versions of launchpad running side-by-side [11:55] and it looks like the object returned by traversal is a BugComment in both cases [11:55] but in stock Launchpad, the object that gets made into an EntryResource is a Message, and in my changed Launchpad, the object that gets put into the EntryResource is the same BugComment that was retrieved from traversal [11:56] obviously a Message has a .parent and a BugComment does not [11:56] leonardr: Cool, that's useful info. I'm still trying to get the branch to run the test :-/ But I know that there's some smoke and mirrors in the bug message/comment area, and I helped to create some of it, so I'm hopeful I'll find the culprit. [11:57] cool [11:57] let me know if i can help you get it running [11:57] leonardr: It keeps failing in create-lp-wadl.py with: AttributeError: 'WebServiceTestRequest' object has no attribute 'version' [11:58] allenap: that makes me think you're not using the new lazr.restful [12:09] allenap: i did make clean and am now getting the same error [12:10] this should be easy to fix [12:13] leonardr: I have to go and feed children, so I'll be back in ~45 minutes, sorry about that. [12:13] ok === henninge is now known as henninge-lunc [12:49] flacoste, i need some help from you today. i'm trying to integrate the new lazr.restful into launchpad so that we can make launchpadlib use '1.0' before the feature freeze [12:50] my gut feeling is that i won't make it, but if i'm going to make it i'll need advice from you since gary is not in today [13:04] leonardr: is /beta/ going to start changing at that point? [13:04] james_w: no, beta will _stop_ changing at that point [13:04] nice [13:05] thanks :-) [13:05] james_w: the goal is to retire 'beta' at the same time that karmic is retired [13:05] if i don't make this goal then we will be retiring 'beta' when lucid is retired [13:22] allenap: i've pushed an update that will make the wadl generation work (in doing so i discovered a much bigger problem with the wadl generation, but you don't need to worry about it) === henninge-lunc is now known as henninge [13:40] allenap: found it! [13:40] leonardr: Awesome :) [13:40] i need your help figuring out what to do [13:41] the problem is bugcomment_to_entry [13:41] leonardr: Phew, at least I might be able to help eventually. [13:42] allenap: basically, in the new system, you can no longer adapt just an object to an IEntry [13:42] you need to multi-adapt a 2-tuple (object, version_marker) [13:43] leonardr: Ah. What does the version_marker signify? [13:43] allenap: which version of the web service the user is trying to access [13:43] ie. beta, 1.0, etc [13:44] i'm going to try just adding the marker interface to the adapter function and ignoring it. since this mechanism doesn't change between versions that _should_ work [13:55] allenap: i think it's working [13:56] leonardr: Cool. I still don't quite get it all, but I'll pull your branch and figure it out. I've not been very useful to you, except perhaps as an over-the-shoulder viewer. [14:00] allenap: i've pushed my revision. looking at webservice.zcml that seems to be the only special adapter launchpad has [14:00] which would explain why everything else is working [14:03] leonardr: Ah, I get it now. Awesome. [14:07] hi leonardr [14:08] hi [14:09] flacoste: right now i know of two unresolved issues w/r/t making launchpad multi-version [14:09] the cached WADL file and the apidoc derived from that file [14:10] right now my code is getting the 'devel' version of the WADL [14:10] we need to get separate WADL and generate separate apidoc for each version [14:11] but, maybe we don't need to do that right now [14:14] flacoste: i'm going to add a launchpad test to make sure that the 1.0 web service is _accessible_. then i can get launchpad/lazr.restful reviewed and landed, and then i can do a new launchpadlib [14:15] good plan? [14:16] leonardr: i agree, you don't need the separate apidoc right now, nor the separate WADL file [14:17] one thing we don't want though [14:17] is that people start developping 1.0 launchpadlib application [14:17] while we are still changing it [14:17] might be better to freeze beta now [14:17] cut devel [14:17] and release a launchpadlib that talks to devel by default [14:18] and discuss with the Ubuntu side that they would be ok with us uploading a version that switch devel to 1.0 in a couple of weeks [14:18] before beta [14:18] once we have frozen 1.0 [14:18] flacoste: what changes were you hoping to make in 1.0? [14:19] leonardr: remove obsolete mutators [14:19] as named operations [14:19] ok, that's the only one i was planning to do in the next couple weeks [14:19] and maybe a general call to the teams to think about any API they wanted to change [14:19] break backward compatibility [14:21] flacoste: i don't think i agree about releasing a launchpadlib that talks to devel by default [14:21] what is the worst that happens if we release a 1.0 launchpadlib and people start using it? [14:21] 1.0 will start out one way and then change [14:21] that's the same as if they start using devel [14:22] and if something goes wrong and we end up releasing a devel launchpadlib in lucid, we're in big trouble [14:22] leonardr: expectations management [14:22] right now people don't even notice the version [14:22] we'll have to announce that the version change is happening and what it means [14:22] people will have to know that they can revert to beta if they want [14:23] i think doing devel -> 1.0 is a less confusing story [14:24] flacoste: do you know who i should talk to on the ubuntu side? [14:24] james_w: do you have a suggestion about the above suggestion? [14:24] james_w, maybe? [14:24] james_w: s/suggestion/conversation/ [14:31] flacoste, james_w: sorry, my laptop battery died. what have you been talking about? [14:31] leonardr: no news from james_w yes [14:31] yet [14:31] ok [14:32] hi [14:32] sorry, was at lunch [14:33] you want to know if we would be ok with a devel -> 1.0 default change in a couple of weeks [14:33] ? [14:36] james_w: basically, yes [14:36] I don't have a problem with it [14:36] I'm not on the release team though [14:37] james_w: has launchpadlib been moved to main? apt still shows it as Ubuntu MOTUY Developers [14:37] it has [14:37] james_w: are you the maintainer? [14:37] it's in Debian now, so the Debian python team take care of it [14:38] james_w: and who is that? [14:38] there's a whole bunch of them [14:38] Luca is the one that has done most of the work so far [14:39] so I guess we should talk to him [14:39] and someone on the release team [14:40] pitti or slangasek i assume [14:42] I can talk to Luca if you get the go ahead [14:42] flacoste: can you sort things out with the distro developers while i complete the integration? [14:43] yeah, #ubuntu-release works [14:43] leonardr: i think it's best if you or gary handles it directly, let me know if there is problem [14:43] ok [15:10] I never modified sendmail.py in my branch. But when I merged from today's devel, I got a conflict there. I resolved it in the obvious way (half of it was empty text, and it looked like a bzr artifact), I still have this diff: [15:10] http://paste.ubuntu.com/376899/ [15:11] (I'm sure this is related to r10306 in devel) [15:13] the sha part I can explain from my resolution, and can fix. the set thing mystifies me [15:15] oh, duh, nm. devel vs db-devel issue sigh === jamlata-afk is now known as jamalta === beuno is now known as beuno-lunch === henninge is now known as henninge-afk [16:30] adeuring: got a sec? I'm beginning to wonder if I'm on the right track here. http://paste.ubuntu.com/376948/ [16:30] kfogel: LET ME LOOK... [16:31] adeuring: caps lock? :-) [16:31] kfogel: yeah... This key should be banned... [16:31] :-) [16:31] or I should remove it from my keyboard [16:32] hi thumper, when you are around, and have a minute, I've a question about bug 520412 [16:32] Bug #520412: fix review_types argument of the API's Branch.createMergeProposal method [16:40] adeuring: what I'm trying to do is make a portlet template that can be reused on other pages as well, not just the product-index page [16:41] kfogel: is patches-view.test an IProduct ? [16:41] erm, patches-view-test [16:42] adeuring: yes [16:42] odd... I that case, I'm lost. In theory, things look correct, I'd say... But: Did you consider to define the protlet for IHasBugs instead of IProduct? [16:43] kfogel: I know, that question is not related to your problem, but anyway... [16:48] adeuring: phone, one sec [16:48] kfogel: no problem... I'm afraid you need to as somebody else anyway :( === beuno-lunch is now known as beuno [17:14] kfogel: Just tired the diff you posted. Looks good; no problems to access http://launchpad.dev/firefox ; the new portlet appears. But there is a little bug in your ZCML data: a duplicate tag [17:14] s(tired/tried/ [17:14] adeuring: d'oh [17:14] adeuring: thank you (off phone now) [17:14] adeuring: I wonder why I'm getting that OOPS. [17:15] adeuring: you're right that the portlet should be for IHasBugs, I think [17:15] kfogel: A guess: Your test object is something else than an IProduct, or [17:15] you did not test the diff that you posted. [17:16] more likely the latter -- the web server should simply not start wirth that ZCML data ;) [17:18] adeuring: aaaaaah, that may be it [17:18] adeuring: thx [17:26] adeuring: working for me now [17:26] kfogel: great! [17:29] Ursinha: poimport error reporting seems to be broken on staging... do you know anything about it? [17:41] adeuring: when you asked "Did you consider to define the portlet for IHasBugs instead of IProduct?", did you mean something like http://paste.ubuntu.com/376995/ ? [17:42] kfogel: yes [17:42] adeuring: cool, thanks [17:42] adeuring: man, I wish we were sitting in the same room :-) [17:42] kfogel: shall we organize a mini sprint ;)? [17:43] adeuring: I'm all for it sometime soon, actually. I have some travel plans solidifying right now, but once I know those, maybe I can come out to Berlin or you to NY in the next month or two... [17:45] kfogel: sounds like an interesting idea! But as a nitpick, I don't live in berlin, but in Bielefeld (ca 3 hours by train from berin) [17:45] s/berin/Berlin/ [17:45] adeuring: oh, sorry -- dunno why I thought you lived in Berlin. [17:49] kfogel: because both names start with 'B' and sound somewhat foreign ;)? [17:49] adeuring: I'm not *that* American, man :-) [17:49] * kfogel skirts around self-examination [17:51] kfogel: perhaps is because Bielefeld does not exist: http://www.dw-world.de/dw/article/0,,1400913,00.html [17:53] adeuring: I always suspected you might live in a place that does not exist. Don't think we didn't all notice that you showed up in Alabama with an empty suitcase, or that your ticket back listed a non-existent terminal at Atlanta airport. [17:54] kfogel: you didn't noticed my other suitcase! [17:55] adeuring: that's because that one didn't exist at all! [17:55] .oO (sheesh) [17:55] kfogel: bullshit. I travel _always_ with two suitcases! [17:55] though one most times invislibke [17:55] ...invisible [17:56] Now you're talking crazy, clearly. [17:57] well, I'm from a town that doesn't exist -- what do you expect ;)? [17:57] mthaddon, if you're still here: could you (a) stop for the day or (b) give me another import run on staging? :-) [18:07] g'night folks. [18:07] * jml will be back later for kiwi chat! === flacoste is now known as flacoste_lunch [18:24] morning jml [18:34] hello mwhudson [18:34] jelmer: hi [18:49] adeuring: http://paste.ubuntu.com/377042/ [18:49] adeuring: background: I realize that using the same patch batcher as we use in the main +patches view is not a good long-term solution; I was just trying to get something working, and then to refine to somehow show the "top 5" youngest patches or something in the portlet. [18:50] I failed at the "get something working" stage, as you can see :-). === danilos is now known as daniloff [19:33] morning morning people === flacoste_lunch is now known as flacoste [19:48] kfogel: that's because lp.registry.browser.product.ProductView does not define batchedPatchTasks . You should use the view class that has this method in the ZCML attribute 'class="..."' [19:49] kfogel: and sorry for the late answer. was out to buy some food [19:49] adeuring: no problem -- it's already late for you! [19:49] adeuring: edits to .zcml files require restart or no? [19:50] adeuring: it seems to have been working without restart... [19:50] adeuring: ...but I wonder if I'm just getting lucky or something. [19:50] kfogel: I think youmust restart the server [19:50] * kfogel winds up the mouse [19:52] rockstar, thumper, did you guys know that branch icons seem to be missing on edge? [20:01] beuno: yes, bug has been filed [20:01] rockstar: ping? [20:20] adeuring: it must be late there -- curious, how much longer you plan to be on? [20:20] kfogel: perhaps an hour or so [20:20] adeuring: *nod* thx [20:31] thumper, hi. [20:37] mars, can you help me with a windmill test failure? [20:38] adeuring: oh wow, while adding some more test data, I just got this great confirmation box: [20:38] This file does not look like a patch. What is a patch? [20:38] Is this file a patch: [20:38] yes [20:38] no [20:38] adeuring: that is so awesome [20:38] leonardr, sure, I can have a look. what is the problem? [20:38] mars, http://paste.ubuntu.com/377137/ [20:40] kfogel: thanks :) [20:42] I just hit the bug that caused me to propose https://code.edge.launchpad.net/~james-w/launchpad/sync-source-negative-versions/+merge/16861 again, and I was a little surprised to realise that it's been approved for 6 weeks and isn't yet merged, let alone in production, could someone move it along please? [20:43] leonardr, did you try running those tests locally? [20:43] leonardr, bin/test --layer=BugsWindmillLayer -t test_security_settings_form_overlay [20:44] mars, trying now [20:45] james_w: can you not land via PQM? [20:46] kfogel: I cannot [20:46] hello james_w, kfogel [20:46] james_w: two questions: one, why not? (we should fix that?) [20:46] hi poolie [20:46] kfogel: I'm not on the LP team [20:47] two: I notice the repeat of "if dest_version is None" in the diff... looking closely at the redundancy now. [20:47] poolie: hey there [20:47] james_w: oy vey [20:47] james_w: ok [20:47] hi kfogel [20:49] I don't know if that's a rule, but it's why I don't have it currently, and I'm not even sure that I would want the ability :-) [20:49] james_w: i may see about batch-upgrading those branches soon [20:50] mars: i get a different error, but it's one that looks like my fault... [20:50] thanks [20:51] james_w: yeah, looking at the diff and at the full file's source... I can't take a break from what I'm working on right now long enough to puzzle out whether that apparently-repeated conditional makes sense, but it might be worth a second look from you? [20:51] mars: here's the local errors: [20:51] http://paste.ubuntu.com/377148/ [20:52] The "could not fulfil proxy request" looks like it could have started failing due to multiversion. could that have caused the other errors? [20:52] kfogel: it does make sense (at least to me) the first case is for the actual catching of the case where the package isn't in Ubuntu, the second is to not crash trying to do "ubuntu" in None. [20:53] kfogel: it may be possible to restructure everything to avoid it, but there may well be other duplication if that is done [20:59] james_w: if (dest_version is None [20:59] or apt_pkg.VersionCompare(dest_version, source_version) < 0): [20:59] if (not Options.force [20:59] and dest_version is not None and dest_version.find("ubuntu") != -1)): [20:59] james_w: (off the top of my head, just for clarity) [20:59] james_w: but I see what you mean; it's tricky [21:01] adeuring: got a sec for quick discussion? (might be useful to check out lp:~kfogel/launchpad/255868-link-to-patches-view for this) [21:02] kfogel: yes [21:02] adeuring: basically, I'm trying to figure out a) the best way, visually, to present this "latest patches" list, and b) how to limit it to the five (or whatever) youngest patches. [21:04] kfogel: I am really bad for aestheical things ;) [21:04] adeuring: no problem, let's limit it to question (b) :-) [21:04] ok ;) [21:05] kfogel: To limit the result set, just use something like storm_result_set[:5] [21:05] adeuring: right now it will just show batch-size number of bugtasks with patches -- could be 50. [21:05] adeuring: aaaaaaaah [21:06] adeuring: in the .pt file?? [21:06] kfogel: it is probably a bt nicer to do that in the view class. But it should also be possible in the template [21:08] adeuring: well, the view class is BugsPatchesView, the same view we're using for the full +patches view. Ah, but maybe I should make a new method in the view, instead of using batchedPatchTasks. Something like latestPatchTasks or something. Is that the usual route? [21:08] leonardr, got lost in a context switch, looking [21:08] kfogel: yes, that's what I meant [21:08] adeuring: thanks, all clear now [21:08] great [21:08] mars: when i run it locally and watch the browser window i see 2 failures [21:09] the first one is that we're expected to be at the login page when we're actually at the bug detail page [21:09] and the other is an exception generated by the web service, which i believe is caused by the attempted request to /api/beta/api/devel/ [21:09] leonardr, have you tried running it stand-alone, and changing the privacy? [21:09] mars, trying that now [21:10] leonardr, don't worry about the first error, that is something in windmill we need to silence [21:10] it does not cause a failure, just a lot of noise [21:10] so the ERROR is not the same as a bug failure? [21:11] line 9 is just a loud BANG, line 11 is your branch dying [21:13] mars: yes, changing the bug privacy settings POSTs to /api/beta/api/devel/bugs/15 [21:13] Bug #15: PO file import errors should be more verbose [21:13] that's definitely my fault but i don't know how it happens... [21:13] how what happens? [21:13] how the /api/devel/ gets in there [21:14] client.js [21:14] or base-template-macros.pt [21:14] grep for the string '/api' in *.js and/or *.pt [21:15] mars: well, i know that if someone was in fact sending a request to /api/devel it would get munged by LP.client.normalize_uri into /api/beta/api/devel [21:16] but no one should be doing that yet [21:18] leonardr, are there any in-page