[04:24] <thumper> mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/only-show-latest-bmp-in-revision-mail/+merge/19377
[12:33] <wgrant> bigjools: You poked me about 10 minutes too late last night?
[12:33] <bigjools> wgrant: it was about the branch I reviewed
[12:33] <bigjools> I put the question on the MP
[12:34] <wgrant> bigjools: Ah, right. I fixed those this morning.
[12:34] <bigjools> sweet
[14:59] <adeuring> gmb, bac: could one of you review please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/bug-283941-show-patch-numbers-on-upstream-report/+merge/19405 ?
[14:59] <bac> adeuring: i'll take it
[14:59] <adeuring> bac: thanks!
[15:01] <bac> adeuring: the MP shows lots of text conflicts
[15:01] <bac> adeuring: have they been resolved?
[15:01] <adeuring> bac: no, let me check...
[15:09] <adeuring> bac: The conflicts were mostly caused by me and somebody else removing some lint in lp.bugs.browser.bugtask ;) I pushed a new vresion of the branch
[15:11] <bac> thanks adeuring
[15:59] <bac> adeuring: is your branch really based on db-devel not devel/
[16:00] <adeuring> bac: yes. I ue the column Bug.latest_patch_uploaded in the modified SQL query, and thi column is not yet in the production DB
[16:00] <adeuring> s/ue/use/
[16:00] <bac> right
[16:08] <noodles775> Hi gmb, bac, when you've time: https://code.edge.launchpad.net/~michael.nelson/launchpad/506203-ppa-privatisation-check/+merge/19415
[16:09] <gmb> noodles775: I'll take a look at it in a minute or two.
[16:09] <noodles775> Thanks gmb.
[16:14] <leonardr> rockstar, if you're feeling better, i have a multiversion branch coming up
[16:15] <rockstar> leonardr, "better" is a relative term, but yeah, I'm able to review.
[16:15] <leonardr> rockstar: it's pretty simple
[16:17] <bac> adeuring: what is the lp.dev URL to see your new work?
[16:18] <adeuring> bac: https://launchpad.dev/ubuntu/+upstreamreport (sorry for not mentioning it in the MP...)
[16:18] <bac> np.  that's why interactive reviews are so nice
[16:27] <leonardr> rockstar: https://code.edge.launchpad.net/~leonardr/lazr.restful/fix-request-user/+merge/19418
[16:27] <gmb> noodles775: r=me with a couple of tweaks.
[16:27] <gmb> Nothing major.
[16:33] <noodles775> Great, thanks gmb.
[16:37] <noodles775> gmb: lol, re. the is_empty()... we hit the same point last week. I tried is_empty first, but it's not part of ISQLObjectResultSet.
[16:38] <gmb> noodles775: Oh, sod. I hate that shim. Okay, checking .count() is an acceptable alternative then.
[16:38] <leonardr> intellectronica, can i trouble you to take another look at https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-integration/+merge/19346 ?
[16:42] <intellectronica> leonardr: ok
[16:42] <intellectronica> have you made changes to it?
[16:45] <leonardr> intellectronica: yes
[16:45] <leonardr> i can paste you an incremental diff
[16:45] <intellectronica> leonardr: that would be great
[16:45] <intellectronica> just reading your comment now
[16:46] <leonardr> http://paste.ubuntu.com/377720/
[16:46] <intellectronica> leonardr: thanks
[16:46] <intellectronica> it would be nice if the revision entries in an mp could expand to contain the incremental diff
[16:46] <intellectronica> abentley, rockstar: ^^^^^
[16:47] <intellectronica> leonardr: i don't understand why on line 65 of the diff you still have '/beta/' in the url
[16:48] <intellectronica> isn't it supposed to be replaced by the 'devel' you pass to api_version?
[16:48] <leonardr> intellectronica: hm, it's possible i didn't run that test, it's not a javascript test
[16:49] <abentley> intellectronica, see bug #485625
[16:49] <mup> Bug #485625: mail out interdiffs when updating review diffs <code-review> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/485625>
[16:49] <intellectronica> leonardr: everything else looks fine to me, so just check this one test first to see if it's ok. other than that r=me
[16:50] <intellectronica> abentley: nice :)
[17:04] <sinzui> bac: You will see my mp in a few minutes. It ill look familiar. I decided to use a tales formatter for boolean icons. We can reconcile my branch with yours after our branches land
[17:04] <bac> sinzui: ok
[17:07] <jtv> abentley: 'howbout dis den: https://code.edge.launchpad.net/~jtv/launchpad/branch-url/+merge/19422
[17:11] <abentley> jtv, why are you listifying a tuple and then adding a list to it, instead of just adding a tuple to the tuple?
[17:12] <jtv> abentley: IIRC somebody decided once upon a time that tuples were bad for these "in constant_bunch" checks...  I'm fine with making it a tuple, but this is less sensitive to change too.
[17:13] <abentley> jtv, why are lists better for that kind of check?  Wouldn't a set be better?
[17:13] <jtv> abentley: true, it would save one letter of typing
[17:15] <abentley> jtv, I would like to see the rationale for not using tuples for that kind of check.
[17:15] <jtv> abentley: it was a surprisingly long discussion, and frankly I didn't care enough to get involved.  If it's performance-sensitive, that's different.
[17:15] <abentley> jtv, I know I suggested bzr_identity, but I think it makes more sense to use unique_name, as xmlrpc version does.
[17:16] <jtv> abentley: I guess all that skips is the "abbreviation" of the name, right?
[17:17] <abentley> jtv, it means you don't have to slice, but it also means you won't get short names like lp:bzr.
[17:18] <jtv> abentley: off the top of my head, it'd give me '~abentley/launchpad/mybranch', right?
[17:18] <abentley> jtv, unique_name will give you that.
[17:19] <jtv> abentley: then change it I shall.
[17:19] <jtv> definitely cleaner than adding the "lp:", checking for its presence, and removing it again.  :-)
[17:21] <abentley> jtv, why are you composing the URL using strings rather than the URI class?
[17:21] <jtv> abentley: never occurred to me, but it's clearer now that I just simplified things.
[17:22] <abentley> jtv, cool.
[17:22] <jtv> (changing)
[17:24] <abentley> jtv, test_composePublicURL_unknown_scheme needs a comment.
[17:25] <abentley> jtv, could you also export the method over the API, please?
[17:25] <jtv> abentley: working on it
[17:26] <abentley> jtv, (I've already had to compensate for the lack of it several times in plugins).
[17:27] <jtv> abentley: any idea why URI doesn't insert the "/" between host/port and path?
[17:28] <abentley> jtv, not really.
[17:29] <jtv> especially with the temptation to use os.path, which is wrong...
[17:29] <jtv> (except maybe for "file:" :-)
[17:32] <leonardr> rockstar, any progress on the review?
[17:32] <rockstar> leonardr, sorry, was looking after another issue real quick.
[17:41] <jtv> abentley: the diff is updated.
[17:43] <abentley> jtv, were you going to change accepted_schemes to a set?
[17:43] <jtv> abentley: if you care enough to ask me to, yes.
[17:43] <abentley> jtv, okay, please do.
[17:44] <abentley> jtv, r=me with that change.
[17:45] <jtv> abentley: thanks!  The change is being pushed.
[17:47] <EdwinGrubbs> bac: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-99395-linking-sourcepackages-to-projects/+merge/19429
[17:47] <bac> EdwinGrubbs: sure
[18:02] <abentley> bac, could you please review https://code.edge.launchpad.net/~abentley/launchpad/twisted-oopsdir/+merge/19431 ?
[18:02] <bac> abentley: sure
[21:13] <sinzui> bac: I just created an mp for a branch that got too large. I need to fix an oops, but I had to migrate some code to lp.registry first. So I have a mechanical branch for you to review.
[21:15] <bac> ok
[21:49] <bac> sinzui: done
[23:56] <leonardr> is anyone around to review a truly trivial launchpadlib branch? maybe jml?