[04:24] mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/only-show-latest-bmp-in-revision-mail/+merge/19377 === henninge changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [adiroiban(codereview bug-340664)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === daniloff is now known as danilos === adiroiban changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [adiroiban(codereview bug-340664),adiroiban(bug-522188)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [12:33] bigjools: You poked me about 10 minutes too late last night? [12:33] wgrant: it was about the branch I reviewed [12:33] I put the question on the MP [12:34] bigjools: Ah, right. I fixed those this morning. [12:34] sweet === mrevell is now known as mrevell-lunch === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue [adiroiban(bug-522188)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === salgado_ is now known as salgado === mrevell-lunch is now known as mrevell === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: adiroiban || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [14:59] gmb, bac: could one of you review please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/bug-283941-show-patch-numbers-on-upstream-report/+merge/19405 ? [14:59] adeuring: i'll take it [14:59] bac: thanks! === bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, abel || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [15:01] adeuring: the MP shows lots of text conflicts [15:01] adeuring: have they been resolved? [15:01] bac: no, let me check... [15:09] bac: The conflicts were mostly caused by me and somebody else removing some lint in lp.bugs.browser.bugtask ;) I pushed a new vresion of the branch [15:11] thanks adeuring === jamalta-afk is now known as jamalta === salgado is now known as salgado-lunch [15:59] adeuring: is your branch really based on db-devel not devel/ [16:00] bac: yes. I ue the column Bug.latest_patch_uploaded in the modified SQL query, and thi column is not yet in the production DB [16:00] s/ue/use/ [16:00] right === noodles775 changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, abel || queue [noodles] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [16:08] Hi gmb, bac, when you've time: https://code.edge.launchpad.net/~michael.nelson/launchpad/506203-ppa-privatisation-check/+merge/19415 [16:09] noodles775: I'll take a look at it in a minute or two. [16:09] Thanks gmb. === gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: noodles, abel || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [16:14] rockstar, if you're feeling better, i have a multiversion branch coming up [16:15] leonardr, "better" is a relative term, but yeah, I'm able to review. [16:15] rockstar: it's pretty simple [16:17] adeuring: what is the lp.dev URL to see your new work? [16:18] bac: https://launchpad.dev/ubuntu/+upstreamreport (sorry for not mentioning it in the MP...) [16:18] np. that's why interactive reviews are so nice [16:27] rockstar: https://code.edge.launchpad.net/~leonardr/lazr.restful/fix-request-user/+merge/19418 [16:27] noodles775: r=me with a couple of tweaks. [16:27] Nothing major. [16:33] Great, thanks gmb. === salgado-lunch is now known as salgado === gmb changed the topic of #launchpad-reviews to: on call: bac || reviewing: abel || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [16:37] gmb: lol, re. the is_empty()... we hit the same point last week. I tried is_empty first, but it's not part of ISQLObjectResultSet. [16:38] noodles775: Oh, sod. I hate that shim. Okay, checking .count() is an acceptable alternative then. [16:38] intellectronica, can i trouble you to take another look at https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-integration/+merge/19346 ? [16:42] leonardr: ok [16:42] have you made changes to it? === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [16:45] intellectronica: yes [16:45] i can paste you an incremental diff [16:45] leonardr: that would be great [16:45] just reading your comment now [16:46] http://paste.ubuntu.com/377720/ [16:46] leonardr: thanks [16:46] it would be nice if the revision entries in an mp could expand to contain the incremental diff [16:46] abentley, rockstar: ^^^^^ [16:47] leonardr: i don't understand why on line 65 of the diff you still have '/beta/' in the url [16:48] isn't it supposed to be replaced by the 'devel' you pass to api_version? [16:48] intellectronica: hm, it's possible i didn't run that test, it's not a javascript test [16:49] intellectronica, see bug #485625 [16:49] Bug #485625: mail out interdiffs when updating review diffs [16:49] leonardr: everything else looks fine to me, so just check this one test first to see if it's ok. other than that r=me [16:50] abentley: nice :) === sinzui changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [17:04] bac: You will see my mp in a few minutes. It ill look familiar. I decided to use a tales formatter for boolean icons. We can reconcile my branch with yours after our branches land [17:04] sinzui: ok [17:07] abentley: 'howbout dis den: https://code.edge.launchpad.net/~jtv/launchpad/branch-url/+merge/19422 [17:11] jtv, why are you listifying a tuple and then adding a list to it, instead of just adding a tuple to the tuple? [17:12] abentley: IIRC somebody decided once upon a time that tuples were bad for these "in constant_bunch" checks... I'm fine with making it a tuple, but this is less sensitive to change too. [17:13] jtv, why are lists better for that kind of check? Wouldn't a set be better? [17:13] abentley: true, it would save one letter of typing [17:15] jtv, I would like to see the rationale for not using tuples for that kind of check. [17:15] abentley: it was a surprisingly long discussion, and frankly I didn't care enough to get involved. If it's performance-sensitive, that's different. [17:15] jtv, I know I suggested bzr_identity, but I think it makes more sense to use unique_name, as xmlrpc version does. [17:16] abentley: I guess all that skips is the "abbreviation" of the name, right? [17:17] jtv, it means you don't have to slice, but it also means you won't get short names like lp:bzr. [17:18] abentley: off the top of my head, it'd give me '~abentley/launchpad/mybranch', right? [17:18] jtv, unique_name will give you that. [17:19] abentley: then change it I shall. [17:19] definitely cleaner than adding the "lp:", checking for its presence, and removing it again. :-) [17:21] jtv, why are you composing the URL using strings rather than the URI class? [17:21] abentley: never occurred to me, but it's clearer now that I just simplified things. [17:22] jtv, cool. [17:22] (changing) [17:24] jtv, test_composePublicURL_unknown_scheme needs a comment. [17:25] jtv, could you also export the method over the API, please? [17:25] abentley: working on it [17:26] jtv, (I've already had to compensate for the lack of it several times in plugins). [17:27] abentley: any idea why URI doesn't insert the "/" between host/port and path? [17:28] jtv, not really. [17:29] especially with the temptation to use os.path, which is wrong... [17:29] (except maybe for "file:" :-) [17:32] rockstar, any progress on the review? [17:32] leonardr, sorry, was looking after another issue real quick. === deryck is now known as deryck[lunch] [17:41] abentley: the diff is updated. [17:43] jtv, were you going to change accepted_schemes to a set? [17:43] abentley: if you care enough to ask me to, yes. [17:43] jtv, okay, please do. [17:44] jtv, r=me with that change. [17:45] abentley: thanks! The change is being pushed. [17:47] bac: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-99395-linking-sourcepackages-to-projects/+merge/19429 [17:47] EdwinGrubbs: sure [18:02] bac, could you please review https://code.edge.launchpad.net/~abentley/launchpad/twisted-oopsdir/+merge/19431 ? [18:02] abentley: sure === abentley changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [sinzui, abentley] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: edwin || queue [abentley] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gary_poster is now known as gary-lunch === deryck[lunch] is now known as deryck === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: abentley || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === gary-lunch is now known as gary_poster === salgado is now known as salgado-brb === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === sinzui changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue [sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === salgado-brb is now known as salgado-afk [21:13] bac: I just created an mp for a branch that got too large. I need to fix an oops, but I had to migrate some code to lp.registry first. So I have a mechanical branch for you to review. [21:15] ok === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: sinzui || queue [-] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews === adiroiban changed the topic of #launchpad-reviews to: on call: bac || reviewing: sinzui || queue [adiroiban(bug-127171)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [21:49] sinzui: done === jamalta is now known as jamalta-afk === bac changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [adiroiban(bug-127171)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews [23:56] is anyone around to review a truly trivial launchpadlib branch? maybe jml?