| leonardr | rockstar, if you're still around? | 00:03 |
|---|---|---|
| mwhudson | leonardr: i'm here | 00:06 |
| leonardr | mwhudson, huzzah | 00:06 |
| leonardr | give me a few min to write an mp | 00:06 |
| mwhudson | leonardr: sure | 00:07 |
| mwhudson | request the mp | 00:07 |
| mwhudson | leonardr: i might be having lunch but i won't be away for very long | 00:07 |
| leonardr | mwhudson: https://code.edge.launchpad.net/~leonardr/launchpadlib/use-beta-service/+merge/19453 | 00:10 |
| mwhudson | leonardr: done | 00:13 |
| leonardr | mwhudson: actually i need you again--i ran the launchpad-based tests but not the unit test, and my change caused a tiny test failure (which is good, imo) | 00:15 |
| mwhudson | leonardr: same merge proposal? | 00:15 |
| leonardr | mwhudson: yes, i had to change one line in a test in addition to one line in the code :) | 00:15 |
| leonardr | i just pushed it | 00:16 |
| leonardr | hmm | 00:17 |
| leonardr | i'm doing another merge proposal | 00:17 |
| leonardr | since, sensibly, the old one stopped covering my changes after you approved it | 00:17 |
| mwhudson | leonardr: er no, it just took a while | 00:17 |
| leonardr | ah, ok | 00:17 |
| leonardr | mwhudson: thanks, all done! | 00:19 |
| mwhudson | yay | 00:19 |
| thumper | trivial review for someone: https://code.launchpad.net/~thumper/launchpad/fix-2a-description/+merge/19455 | 02:12 |
| === jtv changed the topic of #launchpad-reviews to: on call: jtv || reviewing: adiroiban(bug-127171) || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === jtv changed the topic of #launchpad-reviews to: on call: jtv || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | adeuring: just otp... I can do a ui review, but if it's not urgent (ie. can wait until this evening) I'd recommend requesting one from sinzui (or checking with him). | 10:10 |
| noodles775 | As he's wanting to build up his ui reviews, afaik. | 10:11 |
| adeuring | noodles775: OK; I'll ask him | 10:11 |
| === salgado-afk is now known as salgado | ||
| jtv | adiroiban: thanks for a great branch! Can I land it in the form I reviewed? | 11:23 |
| adiroiban | jtv: hi. I have fixed the formatting problems and they should be pushed | 11:24 |
| adiroiban | aren't they? | 11:24 |
| jtv | adiroiban: then please push! | 11:24 |
| adiroiban | let me check what happend | 11:25 |
| adiroiban | I can see them here https://code.edge.launchpad.net/~adiroiban/launchpad/bug-127171/+merge/19444 | 11:25 |
| adiroiban | on the MP page | 11:25 |
| jtv | adiroiban: looking... sorry for the confusion, got a bit distracted here | 11:25 |
| adiroiban | jtv: don't worry | 11:26 |
| adiroiban | better safe, than sorry | 11:26 |
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: jtv || reviewing: - || queue [noodles] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | Hi jtv, if you're still reviewing, I've got a branch that is just a test refactoring: | 13:12 |
| noodles775 | https://code.edge.launchpad.net/~michael.nelson/launchpad/ppa-privatisation-test-refactor/+merge/19482 | 13:12 |
| === henninge changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [noodles] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| henninge | noodles775: jtv is unavailable this afternooon | 13:20 |
| henninge | I am sorry. ;) | 13:21 |
| === adiroiban changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [noodles,adiroiban(This change renders the AdminDistroSeriesLanguage class from security.py useless, so I have also removed it.] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === adiroiban changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [noodles,adiroiban] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === adiroiban changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [noodles,adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === salgado is now known as salgado-lunch | ||
| === fjlacoste is now known as flacoste | ||
| === salgado-lunch is now known as salgado | ||
| noodles775 | henninge: np, thanks for the heads-up! | 14:35 |
| === EdwinGrubbs_ is now known as EdwinGrubbs | ||
| === salgado is now known as salgado-brb | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue [noodles,adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | noodles775: do you still need someone to review your branch? | 15:36 |
| noodles775 | EdwinGrubbs: yeah, that'd be great. | 15:36 |
| EdwinGrubbs | noodles775: are there really 774 other people with the nick "noodles"? | 15:36 |
| adeuring | sinzui: thanks for your review! | 15:39 |
| sinzui | your welcome. | 15:39 |
| === allenap changed the topic of #launchpad-reviews to: on call: Edwin, allenap || reviewing: -, - || queue [noodles,adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| allenap | EdwinGrubbs: Are you free? If so, can you review an incremental change to a branch? http://paste.ubuntu.com/378410/ | 15:49 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: noodles || queue [adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| EdwinGrubbs | allenap: I'm already started on a branch, but it shouldn't take too long. | 15:49 |
| === salgado-brb is now known as salgado | ||
| allenap | EdwinGrubbs: Thanks :) | 15:50 |
| noodles775 | EdwinGrubbs: heh, I just didn't like noodles2 (-: | 15:50 |
| abentley | noodles775, your nick implies that anyone can execute you. Have you committed some kind of capital crime? | 16:00 |
| noodles775 | hah ha.... ha :) | 16:05 |
| jml | and the obscure pun of the day award goes too... | 16:05 |
| === salgado changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: noodles || queue [adiroiban(bug-509252-take-2), salgado] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| salgado | EdwinGrubbs, I have a trivial one (https://code.launchpad.net/~salgado/canonical-identity-provider/dont-use-launchpad-login/+merge/18940) for review. will you have time for it? | 16:38 |
| EdwinGrubbs | noodles775: why is the SoyuzTestPublisher needed in doc/archive.txt? | 17:14 |
| EdwinGrubbs | noodles775: also, what is the point of this? | 17:15 |
| EdwinGrubbs | naked_cprov_archive.sources_cached = 1000 | 17:15 |
| noodles775 | EdwinGrubbs: the SoyuzTestPublisher is used to create consistent publishing records for an archive (without going through the publisher). | 17:20 |
| noodles775 | It's needed there to populate the private ppa with some packages. | 17:20 |
| noodles775 | And the point of setting the sources_cached is to show that they are *not* included in the getNumberOfPPA*() calls as the archive is private. | 17:21 |
| noodles775 | Perhaps the string "Caches for private PPAs are not considered.' needs to be expanded? | 17:22 |
| noodles775 | (I'm just refactoring the test to pass, I didn't update the text unless it was wrong or something I noted as easy to improve). | 17:23 |
| noodles775 | EdwinGrubbs: I'm going for dinner, but will check back in case you have any other questions (or pop them on the MP, whatever you prefer). Thanks | 17:34 |
| EdwinGrubbs | noodles775: I don't have any more questions. I'll send the review in a couple of minutes. | 17:34 |
| EdwinGrubbs | salgado: I can review that. Where did it go? the link doesn't work. | 17:52 |
| EdwinGrubbs | salgado: oh, I just don't have permission to view it | 17:53 |
| salgado | EdwinGrubbs, can you try again now? | 17:54 |
| EdwinGrubbs | salgado: I can view it now, but it doesn't look like I have permission to review it. | 17:55 |
| salgado | EdwinGrubbs, I've requested a review from you now | 17:56 |
| === danilos is now known as daniloff | ||
| EdwinGrubbs | salgado: how do you run the tests. | 18:06 |
| salgado | EdwinGrubbs, need to merge that branch into lib/canonical/signon and then you can run the tests using bin/test | 18:08 |
| === deryck is now known as deryck[lunch] | ||
| EdwinGrubbs | salgado: r=me | 18:19 |
| salgado | thanks EdwinGrubbs | 18:19 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue [adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === EdwinGrubbs is now known as Edwin-lunch | ||
| === gary_poster is now known as gary-lunch | ||
| === deryck[lunch] is now known as deryck | ||
| === sinzui changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue [adiroiban(bug-509252-take-2), sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === gary-lunch is now known as gary_poster | ||
| intellectronica | can anyone review a tiny diff to fix the failure in db-devel? | 19:56 |
| intellectronica | deryck: maybe you, if you're still around? ^^^ it's only two lines | 19:57 |
| deryck | intellectronica, sure. ping me the MP please. | 19:58 |
| intellectronica | deryck: http://pastebin.ubuntu.com/378575/ | 19:58 |
| intellectronica | i'll create an MP | 19:58 |
| intellectronica | basically, i'm committing the transaction to get the trigger that populates the patch age column fired | 19:59 |
| deryck | intellectronica, ah, ok. makes sense. r=me. | 20:01 |
| intellectronica | deryck: thanks! | 20:01 |
| deryck | intellectronica, I'll stamp the MP when it's ready if you ping me again. | 20:03 |
| intellectronica | deryck: https://code.edge.launchpad.net/~intellectronica/launchpad/test-failure-fix/+merge/19529 | 20:04 |
| deryck | intellectronica, done. | 20:07 |
| intellectronica | deryck: thanks again | 20:07 |
| deryck | np! | 20:07 |
| rockstar | Edwin-lunch, may I add a small branch to your queue? | 20:12 |
| === Edwin-lunch is now known as EdwinGrubbs | ||
| EdwinGrubbs | rockstar: yes, you may | 20:32 |
| rockstar | EdwinGrubbs, great. | 20:32 |
| === salgado is now known as salgado-afk | ||
| abentley | mwhudson, https://code.launchpad.net/~abentley/launchpad/branch-url/+merge/19441 | 20:39 |
| mwhudson | abentley: noted | 20:41 |
| jtv | EdwinGrubbs, time for a big one? https://code.launchpad.net/~jtv/launchpad/bug-507681/+merge/19531 | 20:41 |
| EdwinGrubbs | jtv: probably not, but I haven't seen rockstar's branch yet, so it might go quick enough. | 20:42 |
| rockstar | EdwinGrubbs, https://code.edge.launchpad.net/~rockstar/launchpad/makefile-hackery/+merge/19533 | 20:42 |
| rockstar | EdwinGrubbs, mine really is quite small. | 20:42 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: sinzui || queue [rockstar, adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: sinzui || queue [rockstar, jtv, adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | rockstar: btw you still haven't OK'ed this one: https://code.edge.launchpad.net/~jtv/launchpad/bug-499405-translationtemplates-buildmanager/+merge/17811 | 20:43 |
| rockstar | jtv, done. | 20:44 |
| jtv | rockstar: \o/ thanks | 20:44 |
| EdwinGrubbs | rockstar: your branch has conflicts | 21:51 |
| rockstar | EdwinGrubbs, fixing now. | 21:51 |
| rockstar | EdwinGrubbs, conflict resolved, pushing now. | 21:59 |
| EdwinGrubbs | rockstar: r=me | 22:20 |
| rockstar | EdwinGrubbs, thanks! | 22:21 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: jtv || queue [adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!