[00:01] wgrant: I have a branch in progress that sends the email on needs review [00:01] wgrant: but it is blocked on two others [00:01] wgrant: to avoid the horrible edge cases [00:01] wgrant: one of them is done [00:01] wgrant: the one that adds a description to the MP [00:02] wgrant: the other isn't too hard [00:02] * thumper waves at beuno [00:03] * beuno waves back at thumper [00:06] thumper: Great. [00:13] thumper: Do you know about the Zopeless email thing I asked earlier? [00:20] wgrant: didn't see your question [00:25] thumper: Where do Zopeless emails go in the dev config? I cannot find them anywhere. [00:25] wgrant: haha, I remember looking for it too [00:25] wgrant: root@localhost I think [00:26] thumper: Normal emails go there. [00:26] But not Zopeless ones. [00:26] really? [00:26] AFAICT. [00:27] Which is perhaps not surprising, since it looks like Zopeless uses SMTP directly, and there is a zopeless/send_email config key which is set to false. [00:27] Hmmm. [00:27] How annoying. [00:45] AAAAAAA [00:45] * wgrant stabs ISD in the face repeatedly. [00:45] Gnarnrewwfwfew [00:46] please don't. [00:46] they are very nice people. [00:46] * ajmitch detects some rage there [00:48] hi jml [00:48] jml: how's pycon? [00:49] thumper, great! [00:49] thumper, I'm at the Twisted sprint now [00:49] thumper, it's exciting to be able to personally fix multiple bugs in a single day :) [00:50] (bug #525556, for anybody ISDish) [01:00] jml: :) [01:02] jml: \o/ [01:53] * thumper wonders how often the staging scanner is running [02:07] thumper: */15 i think? [02:08] The production scanner seems to be pretty slow at the moment. [02:08] (or maybe the puller) [02:48] beuno: Since you seem to have access, can you have a look at bug #525556? [02:50] sure [02:50] It seems like it should be fairly critical. [02:51] * beuno facepalms [02:51] That's what I said. [02:52] spm, if you or any other losa is around ^ [02:52] just to be aware, I know you can't do anything about it [02:53] beuno: Thanks. [02:54] wgrant, thanks for raising it, I'll make sure the appropriate people know ASAP [02:54] Great. [02:56] elmo, ^ === wgrant_ is now known as wgrant [04:58] I'm trying to write a Storm query to return a resultset of objects ordered by a column on an optional reference. [04:59] ie. I have a BinaryPackageReleaseDownloadCount, which has an optional Country associated. [04:59] I want to order them by Country.name. [04:59] any hints? [04:59] do a leftouterjoin on country [04:59] then sort on country.name [05:00] yes, but how do I do that in Storm? [05:00] maybe coalesced with something depending on which end of the results you want things without country to end up at [05:00] Hm, I guess a more manual select with a DecoratedResultSet might work. [05:01] http://paste.ubuntu.com/381372/ is the code at the moment, but it of course doesn't return objects with a NULL Country. [05:06] wgrant: http://paste.ubuntu.com/381376/ or similar i think [05:07] mwhudson: Oh, yes, of course. [05:07] Thanks. [05:25] * thumper settles down again [05:28] thumper: hi, i have some reviews for you :-) [05:28] mwhudson: sure, paste the links [05:29] https://code.edge.launchpad.net/~mwhudson/launchpad/smarter-code-import-scheduling-bug-236973/+merge/19841 [05:29] thumper: https://code.edge.launchpad.net/~mwhudson/launchpad/incremental-code-imports-bug-512683/+merge/19674 [05:31] * thumper looks now [05:32] mwhudson: are you around for a question? [05:33] thumper: just about, i should stop pretty soon [05:33] mwhudson: why does the interdiff for the incremental imports actually change anything? [05:34] thumper: because the tearDown raises NotImplementerError [05:34] mwhudson: and that does what? [05:34] thumper: and this is the signal to the zope test runner to not run any more tests in that process [05:34] so bad [05:34] so very very bad [05:34] have I mentioned bad? [05:34] thumper: it's what the functionallayer (i.e. the one that sets up the component architecture) does [05:35] lifeless: hey, if bzr supported unloading plugins... [05:35] mwhudson: so because the teardown isn't implemented, the test runner starts another process? [05:35] thumper: it seems so yes [05:35] thumper: i just cargo culted from layers.py [05:35] mwhudson: why do you need to unload plugins? [and it does to an extent] [05:35] mwhudson: can you add a comment saying as much? [05:35] mwhudson: I'd really like to avoid you needing this feature. Can we discuss? [05:36] lifeless: right now, no we can't [05:36] lifeless: some of our other tests fail if the plugins are loaded [05:36] thumper: ok [05:36] lifeless: some tests need it [05:36] lifeless: we'd like to be able to have plugins loaded for only some tests [05:36] is there a doc somewhere explaining this, so I don't en up playing twenty questions? [05:36] lifeless: probably not [05:37] so, lets play twenty questions. [05:37] why do some tests fail [05:37] * thumper shrugs [05:37] lifeless: probably worth playing 20 questions when mwhudson is working tomorrow [05:37] lifeless: as mwhudson is trying to finish up [05:37] mwhudson: can you ping me at a good time tomorrow? [05:37] lifeless: and I won't know answers to your questions [05:37] lifeless: ok [05:37] mwhudson: thanks [05:43] * mwhudson EODs [05:43] good idea [05:52] thumper: Whatever happened to my branch? [05:52] wgrant: not heard anything [05:53] * thumper checks ec2 thingy in firefox [05:53] wgrant: I have one instance that is terminated [05:53] wgrant: I submitted yours and one of mine [05:53] So it hates my branch again :( [05:53] wgrant: heard from one... [05:54] I ec2tested a branch last night and it emailed me OK. [05:55] wgrant: check your email [05:55] wgrant: id emails you not me [05:56] wgrant: I double checked, and it at least started off right [05:56] wgrant: there was a test fix issue [05:56] wgrant: so I'm resubmitting mine [05:57] wgrant: interesting [05:57] wgrant: I didn't get an email from ec2 either [05:57] wgrant: even though it submitted mine to pqm [05:57] wgrant: I should have got one but didn't [05:58] I haven't had an ec2 success notification since mid-December, although I have had successful submissions since then. [05:59] wgrant: your branch hasn't landed if that helps... [06:00] * wgrant looks through mail server logs. [06:04] thumper: It doesn't look like it tried to email me. [06:04] wgrant: sorry dude, no idea at all [06:04] thumper: Thanks for trying. [06:04] Lots of branches have been going missing lately. [07:37] noodles775: Morning. Do you have access to buildd-manager logs? It seems to have stopped dispatching builds about an hour ago. [07:39] wgrant: Yeah, but a losa will need to restart it I'd say. [07:39] * noodles775 checks logs [07:40] wgrant: ouch, another job without a builder: http://pastebin.ubuntu.com/381433/ [07:41] Gnarrrgh. [07:41] There are also two builders stuck (the usual two: samarium and bohrium), but that's probably unrelated. [07:42] Do we have no LOSAs today? I thought there was a Nagios check for that. [07:42] yeah, there should be... I'm just checking the bug and then I'll try to find someone. [07:43] wgrant: they are sprinting this week in europe [07:43] noodles775: morning [07:43] Hi thumper [07:43] thumper: Ahh. [07:43] noodles775: I'm working on a wiki page BuildBranchToArchiveUI/InitialCut [07:44] noodles775: nothing there yet, but I'm working on it [07:44] Great. [07:45] noodles775: actually I just hit save, but I'm still editing :) [07:46] thumper: sure. Do you think it wasn't clear enough on the other pages? (ie. what wouldn't be included in the initial cut?) [08:06] wgrant: the buildd-manager should be dispatching again now (as of a min. ago). [08:07] wgrant: thanks for the heads-up. [08:07] noodles775: I'm going to have a little more detail [08:07] noodles775: ordering of work [08:07] thumper: ah, great. [08:07] noodles775: Thanks. [08:08] noodles775: stuff broken up into ready to code chunks [08:08] noodles775: something where I can say "hey , do this chunk" and it has what they need to know [08:08] noodles775: at least, that's the plan :) [08:09] thumper: yeah, I was hoping the list of urls required could be turned into bugs for that reason, but you're right, they're a bit too coarse grained (and have interdependencies). [08:09] * thumper nods [08:20] good morning === jamesh_ is now known as jamesh [09:02] Morning === daniloff is now known as danilos [09:49] bigjools, hey, good morning :) [09:49] hey danilos - what do you want? :) [09:49] bigjools, ha! [09:49] bigjools, do you know if there have been any firewall rules set up to allow access to our bzr branches from the build farm? [09:50] bigjools, is that something build-from-recipe requires as well, or are translations special in that regard :) [09:51] danilos: no, BFB needs it too. So far I have it set up on dogfood so we can test stuff, but it's not done in production. [09:51] bigjools, ok, I am considering writing up an RT, but I am sure you can give me a few pointers on how to best word it so IS actually understands it :) [09:52] bigjools, i.e. what machines need what privileges :) [09:52] danilos: you don't need it yet [09:52] Do we actually know that it works on dogfood? [09:52] bigjools, heh, ok, if you say so :) [09:52] and you won't get it until you've testing on DF :) [09:52] It didn't after the first reuqest. [09:52] s/testing/tested/ [09:52] wgrant: huh? [09:52] bigjools, ok, makes a lot of sense, then I'll get on with the next phase to actually do it, and then we can see what happens [09:53] danilos: in all seriousness, dogfood is the way to go here so that we can establish that stuff works before altering production [09:53] bigjools: I remember that codehosting access from DF was supposedly set up during the sprint, but it didn't work. [09:53] wgrant: I don't remember us even trying at the sprint! [09:53] bigjools, of course, I am not disagreeing [09:54] it was all on your laptop [09:54] danilos: I'm always right.... 'cept when I'm wrong. [09:54] bigjools: We didn't try the code, but we tried branch access in anticipation. [09:54] wgrant: we only opened up access for the builders IIRC [09:55] bigjools: Isn't that what we're discussing? [09:56] wgrant: I just tried and it works fine [09:56] OK, great. [09:56] I even remember testing it at the time it was done [09:57] Hm. I remember you had to make a second request, but didn't remember if that was resolved. [09:57] I don't remember that but then I don't remember at lot of things at my age :) [09:57] Haha. [10:09] BjornT: Can you please re-review that branch know that we've clarified that ILFA isn't exportable? [10:09] s/know/now/ [10:11] Anyone used the with statement in a doctest yet? [10:11] I think I need to inject some flags somewhere [10:12] stub: Why not just use the import? [10:12] Because it doesn't work [10:12] Ah. Good rationale. [10:14] I think it is http://www.python.org/dev/peps/pep-0264/, but no english translation in the __future__ or doctest bits of the reference manual. [10:18] wgrant: sure, done. [10:20] bigjools: No violent objections to https://code.edge.launchpad.net/~wgrant/launchpad/export-das-chroot/+merge/19759? [10:20] stub: have you tried putting the __future__ import in the test harness (i.e., the file that sets up the doctest)? [10:21] stub: or maybe in the test runner, although that's a very big hammer... [10:21] bigjools, btw, does BFB already have the code which checks the branch out? [10:21] BjornT: Looks like more than that. I need to do the import at the top of the harness, and then pass a globs={'with_statement': with_statement} when constructing the suite. [10:21] icky [10:22] danilos: It's done by bzr-builder, so it's probably not useful for your purposes. [10:23] wgrant, right, so it's outside the LP tree? [10:24] danilos: Yes, and inside a script that takes a recipe. [10:25] wgrant: one sec [10:25] danilos: it's done in the builder code [10:27] bigjools, wgrant: ok, excuse me for not being certain where to look now, but... is there some code in LP I could generalize and reuse for translations? [10:27] danilos: If you really want to look at it, try sourcecode/bzr-builder. But it's probably just as easy for you to do it yourself. [10:27] danilos: nothing in LP - as wgrant says it's done in bzr-builder [10:28] bigjools, wgrant: ok, thanks, that clarifies it [10:33] wgrant: MP is ok, I commented on it [10:33] bzr pish [10:44] Is the branch scanner broken? [10:44] I pushed a new rev 7 minutes ago. [10:45] It has still not scanned. [10:49] BjornT/bigjools: Branch finally scanned -- can one of you please check the new revs and land it? [10:51] sure [10:52] bigjools: Thanks. Do you have a moment to talk about those test changes you requested last week? [10:53] wgrant: sure [10:56] bigjools: So, regarding your last comment on https://code.edge.launchpad.net/~wgrant/launchpad/p-u-sprb-handling/+merge/19380... [10:56] The security is there so the storeUploadLog test works. [10:56] It just needs some declaration of writeability. It does not care what. [10:57] The tests will fail if the security is removed, and I'm not sure it can be usefully tested otherwise. [10:59] wgrant: ah ok, so there is a test :) In that case, please document that fact on the test. [11:00] * bigjools is about to order a new Thinkpad [11:01] would love to get one w/Ubuntu pre-installed but the stuff at LinuxEmporium is all old models :( [11:01] :( [11:01] windows tax here I come [11:01] * wgrant removes the security to work out which test it was. [11:02] Morning, all. [11:02] danilos: can you give me a hint for how can I make a TranslationMessage to be the current translation? Basically I have this test http://paste.ubuntu.com/381520/, and the contributors for makeTranslationMessages are listed in the POFile details page, but not on the language global statistics [11:02] hi deryck [11:07] jtv: hi. when you have time, can you please test the fix for bug #127171 ? [11:07] Bug #127171: Rosetta experts not allowed to "Change translators" [11:08] adiroiban, looking at your test [11:09] adiroiban, fwiw, a lot of that data is maintained through triggers or nightly scripts, so that might be part of the problem [11:11] adiroiban, so, list of top contributors is based on karma, and karma is updated only with a nightly script [11:11] hm... how do you suggest I should write that test? [11:16] You need to populate the relevant Karma and KarmaCache tables. I don't think there are factory methods for that though :-/ [11:25] adiroiban: hang on, some high-priority stuff going on :) [11:26] adiroiban: ah, I guess danilos took care of it while I was otp :) [11:27] adiroiban, I am not exactly sure what would be the best way to do it [11:33] adiroiban, you can just add a method which updates karma for one particular user, or you can fake it by adding it directly [11:58] wgrant: hmmm, I am thinking about your security zcml [11:59] The upload processor is zopeless and doesn't need security, so what is falling over exactly? [12:00] bigjools: The test that I added the comment to. It appears to run in that semi-secure mode which doesn't care about users. [12:00] wgrant: your diff has got merge conflict markers in it [12:00] in the spr model [12:01] bigjools: Argh. [12:01] * wgrant fixes. [12:02] wgrant: which test? the comment was on the zcml itself [12:02] testSetsBuildAndState? [12:02] bigjools: I added a comment at both ends. [12:02] Yes, IIRC. [12:02] ah I see it [12:02] The one that tests UploadProcessor [12:02] buried in other comments :) [12:02] Indeed. [12:02] hmmm [12:03] Remember that Soyuz's Build has the same sort of thing, with little explanation. It would be nice to work out both. [12:04] hmm yes [12:04] it's very odd [12:04] ah I know I think [12:04] Hm? [12:04] those Build attributes get reset in the webapp when you retry the build [12:04] which explains why you need lp.edit [12:05] so I am still confused as to wehy SPRB needs it :/ [12:05] But shouldn't they be set from within retry()? [12:06] Once you're inside the object, security is irrelevant. [12:06] I didn't think it was but now you have me thinking [12:07] since IBuild is exported, lp.edit still makes sense anyway [12:08] For a dangerous value of sense that has caused security issues in the past! [12:09] yeah, we have a bad record there :( [12:09] I mean that particular line of ZCML has been problematic. === jtv is now known as jtv-afk [12:17] bigjools: That conflict's resolved. [12:17] Argh, wrong push location though. [12:17] heh [12:25] bigjools: That looks a bit healthier. [12:32] wgrant: approved [12:32] I can land it, it's db-devel right? [12:32] bigjools: It's db-devel. [12:33] bigjools: But watch out: thumper tried to land the prereq earlier, and the instance disappeared silently. [12:33] :/ [12:33] what happened to the pre-req? [12:33] Hm? [12:34] it landed, or is it still in limbo? [12:35] bigjools: It's not landed. The instance died, and we're not sure why. [12:35] ok I'll try merging it and having another go [12:35] So you might not want to land this headlessly. [12:36] I'll run tests on my box [12:36] Ah, good point. [12:36] I don't need no steenkin ec2 [12:36] I have a fork whore === mrevell is now known as mrevell-lunch === Ursinha-afk is now known as Ursinha [13:10] bigjools: It hasn't exploded yet? [13:10] wgrant: there's a test failure [13:11] Hrmph. [13:11] ProgrammingError: relation "sourcepackagerecipebuildupload" does not exist [13:11] for a few tests [13:12] test_DeleteExpiredBlobs test_cronscript test_PersonPruner and others - non soyuz, which is odd [13:12] Oh, damn. [13:12] I know about and have fixed that. [13:12] lib/canonical/librarian/tests/librarian-report.txt now [13:13] if you have a fix I'll quit this test run [13:13] I forgot to pump one of the DB patch changes through. Oops. [13:13] Sorry. [13:13] ok [13:14] (we can't drop SPRBU entirely due to replication limitations, so it has been moved to another schema, which confuses things that look for foreign keys referencing Person) [13:21] bigjools: r8934 has that DB change pumped through (it's already reviewed) and pushed. [13:21] But I guess it'll take about 10 minutes to appear on the public branch. [13:25] okay [13:27] wgrant: on your lp:~wgrant/launchpad/sprb-new-model-columns branch? [13:27] Stuart Metcalfe doesn't exist on Freenode, does he? [13:28] bigjools: The missing piece started on https://code.edge.launchpad.net/~wgrant/launchpad/sprbu-columns-to-sprb, but is now in p-u-sprb-handling [13:28] ok got it [13:29] ok off with another test run [13:29] Thanks. [13:29] doubt you'll be up in 3h huh? :) [13:29] I really hope not. [13:30] 3am while sick is not advisable. [13:32] hope you're feeling better tomorrow [13:40] wgrant: still failing [13:41] bigjools: Is this line in database/schema/patch-2207-32-0.sql? [13:41] ALTER TABLE SourcePackageRecipeBuildUpload DROP CONSTRAINT sourcepackagerecipebuildupload_registrant_fkey; [13:41] wgrant: yep [13:42] I suspect that when I run "make check" it deletes the table when doing make schema [13:43] anyway, I need food, back in a bit === mrevell-lunch is now known as mrevell [13:52] If dropping the table is too painful, comment out that line and open a bug. [13:53] See, the tests pass here. [13:54] Ah, no, there's one failure. [13:54] * wgrant pokes around. [13:55] * wgrant drops the rest of the foreign keys. [13:56] stub: No objections to dropping the other three foreign keys? [13:57] No - all the foreign key constraints on that table should die. [14:00] bigjools: OK, r8935 pushed, with all the foreign keys dropped. All the failures you've mentioned are fixed by that. [14:10] wgrant: ok trying again [14:24] adeuring, gmb, intellectronica, kfogel -- just a reminder, update the board before the standup. [14:24] deryck: oh, thanks! [14:24] I did some QA and moved things there. [14:25] deryck: I saw. We don't have to hit "save" or anything, right? Just move the post-it and it's done? [14:26] kfogel, right. Just move the card. [14:26] deryck: *nod* [14:26] ooi, why does the LaunchpadDatabaseRevision table contains multiple rows, instead of just the current revision? [14:26] intellectronica: know a good example of a usage of a standard Zope form somewhere? (I'm in bug #515584) [14:26] Bug #515584: BugsPatchesView:batchedPatchTasks() should use a Zope form, instead of validating form values manually [14:27] maxb: I don't know for sure, but it's probably something to do with the fact that a DB patch can live in a branch for ages. [14:27] kfogel: it's probably worth fixing that together with fixing it for the search form [14:27] ah - so in theory they might not actually be sequential? [14:27] maxb: Exactly. [14:27] kfogel: there's a bug for that. let me try and find that [14:27] maxb: In practice, too. [14:28] kfogel: https://bugs.edge.launchpad.net/malone/+bug/322130 [14:28] Bug #322130: Convert IHasBugs.searchTask(order_by) to use a real enumeration

[14:29] intellectronica: thank! [14:29] * kfogel opens it up [14:29] kfogel: it's quite a lot of work, i think [14:30] but it would be even more work if we end up doing it twice [14:30] intellectronica: it's a lot of work? Just because of all the callers? [14:30] bigjools: If it's still looking good, I will head to bed. [14:30] intellectronica: if it's just a bunch of caller updates, well, Emacs and I can do that together. If you think it's a lot of work in terms of inherent complexity, then I'm not sure lumping the two bugs together is a good idea. [14:30] wgrant: yes, no issues so far [14:30] sleep well [14:30] kfogel: yes. also you need to arrange for backwards compatibility [14:30] bigjools: Excellent. Thanks. [14:31] intellectronica: backwards compatibility? This is an API issue? [14:31] mmmmm [14:31] kfogel: maybe the API, also the search form, since many users save URLs for later [14:32] intellectronica: okay, then I think we should keep these two bugs separate. I'm all for fixing 322130, but 515584 is its own separate piece of tech debt, and doesn't have any compat issues. [14:32] intellectronica: *nod* I see. [14:32] kfogel: ok, maybe you're right and it's worth fixing this first, don't know [14:33] intellectronica: This *is* a fair amount of work, then. Not against it, but I don't think we should just randomly start on it vs some other thing -- it needs to be triaged, and we probably want team input, or at least deryck's. There might be more presing stuff to do. [14:33] intellectronica: which we can discuss on the call now :-) [14:33] kfogel: indeed :) === jtv-afk is now known as jtv [14:34] intellectronica: in the meantime... know a good example of a zope form? :-) [14:45] are thunderbird 3 and enigmail conflicting packages these days [14:45] enigmail de-installs thunderbird 3 and vice versa [14:45] ECHAN [14:45] sorry [14:45] kfogel, looking at QA page, can you update bug 513608, to link branch, status, milestone, etc. I think this landed? [14:46] Bug #513608: community-contributions.py script should use Launchpad to determine who is not a Canonical employee [14:46] deryck: yup [14:48] deryck: oh, no -- wrong bug number there. 513608 is still open, it's just mentioned in an XXX comment now. the fix that landed is for another bug. I'll fix it all up. [14:48] (the qa page I mean) [14:49] kfogel, excellent. Thanks, sir. I think I marked something as OK, so sorry about that. [14:49] deryck: well, the change is indeed OK, it just needs to be associated with the right bug number. no worries. [14:49] ok, cool [14:52] deryck: so, it kind of disturbs me that if I do a bugs search across all projects, and put "community-contributions.py" in the search box, it shows no matches -- even though I know of bugs where that exact string is in the *summary* of the bug. [14:52] deryck: is this expected? [14:53] by "search across all projects" what exactly do you mean? [14:53] deryck: https://bugs.launchpad.net/, put that string in the search box, make sure "All projects" is checked, hit the button. [14:54] deryck: it also turns up nothing if I do "One project:" and put launchpad or launchpad-projects as the project name. === matsubara is now known as matsubara-lunch [14:56] kfogel, seems like a bug. This should work. Maybe something with the way full text queries handle the ".py" [14:57] deryck: urgk, sigh. I'll push stack once more :-) and ensure there's a bug report for this. [14:57] may already be one, we'll see [14:59] kfogel, note that search on "launchpad" shouldn't work but search on "launchpad-project" should, since that is the project group. yes, this is confusing, I know. [15:00] deryck: I knew the latter should work. I can never remember what the former is supposed to represent. [15:01] kfogel, it's a thing to catch bugs that no one knows where to file, *I think*. :-) [15:01] deryck: oic :-) [15:04] deryck: so, it turns out that in addition to that change (the one that is not for 513608), I also need to land https://code.edge.launchpad.net/~kfogel/launchpad/cc-script-new-world, which is approved. To land that, I need to find the bug number(s) relevant to it. On the way to finding those, I may be filing a bug about how I can't find them. There. I think that's everything at the current stack level. [15:04] :-) [15:05] heh [15:05] Not too bad for a monday, kfogel ;) [15:05] deryck: oy [15:14] deryck: okay! that's in the queue (https://pqm.launchpad.net/). No need to respond. I'm just feeling the work-at-home-cabin-fever this morning and so I'm yammering what I do at you. [15:15] :-) [15:32]