[01:00] <thumper> mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/branch-push-permission/+merge/19834 if you have a minute
[01:02]  * jpds would like https://code.edge.launchpad.net/~jpds/launchpad/fix_517839 looked into, please.
[01:03]  * thumper looks
[01:03] <mwhudson> thumper: done
[01:03] <thumper> mwhudson: ta
[01:15]  * wgrant is making use of that in another branch, and it seems good.
[01:34] <thumper> wgrant: the county one?
[01:34] <wgrant> thumper: Yeah.
[01:35] <thumper> jpds: I have a few comments on the branch, just finishing some QA first
[01:35] <wgrant> He's probably asleep.
=== wgrant_ is now known as wgrant
=== adeuring changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [adeuring, jpds] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== noodles775 changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [adeuring, jpds, noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== daniloff is now known as danilos
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue [adeuring, jpds, noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[09:56] <noodles775> intellectronica: mine's a really easy one :) https://code.edge.launchpad.net/~michael.nelson/launchpad/499421-dont-grind-bm-to-a-halt/+merge/19846
[09:56] <noodles775> 50 lines.
[09:56] <intellectronica> noodles775: cool, i'll review it now
[09:56] <noodles775> Thanks intellectronica.
[10:01] <intellectronica> noodles775: r=me
[10:01] <noodles775> Ta.
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[11:26] <gmb> intellectronica: I have a branch that's 105-lines over the limit due to a couple of bits of refactoring (i.e. some of that 905-lines is due to moving large blocks of code). Would you be able to review it?
[11:26] <intellectronica> gmb: sure, i'll review it
[11:26] <gmb> intellectronica: Thanks. https://code.edge.launchpad.net/~gmb/launchpad/filebug-polling-for-jobs-bug-513193/+merge/19859.
[11:28] <stub> https://code.edge.launchpad.net/~stub/launchpad/dbpolicy-syntax/+merge/19854 <- 210 lines of syntactic sugar and documentation
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: gmb || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: gmb || queue [stub] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[12:11] <jtv> stub: I can review your branch after lunch
[12:11] <gmb> intellectronica: I'm going to grab some lunch; feel free to ping me and I'll respond to any questions when I get back.
[12:11] <intellectronica> gmb: ok. no surprises so far
[12:11] <gmb> Cool.
[12:11] <jtv> stub: and, typo in the doctest: "Much of our code does not know if the objects being retrieved are need"
[12:12] <stub> I'm going to do future doctests in lolspeak
[12:13] <jtv> stub: such as this?  "want to prove only accesses slave database resources"
[12:13] <jtv> (also a double "if" in that sentence)
[12:13] <stub> Go easy. I'm Australian.
[12:14] <jtv> heh.  Looks like a very good branch otherwise, so I wouldn't have thought there was any need to.
[12:14] <stub> Actually.... that last is technically correct I think (just clumsy and confusing)
=== jtv is now known as jtv-afk
=== mrevell is now known as mrevell-lunch
=== mrevell-lunch is now known as mrevell
=== noodles775 changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: gmb || queue [stub, noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[13:53] <noodles775> hi intellectronica, if and when you have time, this next branch is just a test-refactor, but is 700 lines:
[13:53] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/ppa-privatisation-test-refactor3/+merge/19864
[13:54] <intellectronica> noodles775: sure. i'm just in the middle of gmb's 900 line branch review, and have stub's (smaller) branch after that, but will do yours after that.
[13:54] <noodles775> Thanks.
=== jtv-afk is now known as jtv
[14:47] <henninge> Oh, it's Monday!!!
[14:47] <henninge> Hi intellectronica ... ;)
=== henninge changed the topic of #launchpad-reviews to: on call: intellectronica, henninge || reviewing: gmb || queue [stub, noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== henninge changed the topic of #launchpad-reviews to: on call: intellectronica, henninge || reviewing: gmb, - || queue [stub, noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== abentley changed the topic of #launchpad-reviews to: on call: intellectronica, henninge, abentley || reviewing: gmb, -, stub || queue [noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[14:52]  * henninge was too slow
=== henninge changed the topic of #launchpad-reviews to: on call: intellectronica, henninge, abentley || reviewing: gmb, noodles775, stub || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== abentley changed the topic of #launchpad-reviews to: on call: intellectronica, henninge, abentley || reviewing: gmb, noodles775, henninge || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-lunch
=== intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica, henninge, abentley || reviewing: -, noodles775, henninge || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:02] <abentley> henninge, your code for creating parent directories recursively seems to overlap with Transport.create_prefix.
[15:02] <henninge> abentley: yes, I was wondering if that has been done elsewhere. I guess, I was too lazy to search ... ;-)
[15:02] <henninge> abentley: thanks for the hint, I'll use that.
[15:02] <abentley> henninge, interesting definition of lazy :-)
[15:03] <henninge> abentley: well, coding is fun, isn't it? ;)
[15:04] <abentley> henninge, isHidden looks like it will match on any path containing dots, such as foo/../bar
[15:04] <henninge> abentley: good point ...
[15:04] <henninge> abentley: I should apply normpath first, I guess.
[15:05] <abentley> henninge, sure.  Alternatively, you could use bzrlib.osutils.splitpath and ensure that none of the path elements began with .
[15:06] <henninge> abentley: or is ".." or "."
[15:06] <abentley> henninge, yeah.  Probably normpath is simpler.
[15:11] <abentley> henninge, with those changes I'd be happy with your branch.
[15:20] <henninge> abentley: cool, thank you! ;)
=== abentley changed the topic of #launchpad-reviews to: on call: intellectronica, henninge, abentley || reviewing: -, noodles775, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:24] <henninge> abentley: are you sure about create_prefix, though? It does not take a path. Maybe I don't understand "transport" correctly.
[15:25] <henninge> abentley: if I have a file "foo/bar/bla.pt", how do I create that and the two directories above it?
[15:25] <abentley> henninge, a transport represents a path.  So you create the transport for the path you want to exist and then call create_prefix.
[15:25] <abentley> henninge, t = get_transport('foo/bar/bla.pt'); t.create_prefix(); t.put_bytes('bla.pt', 'contents')
[15:26] <abentley> henninge, actually, the last would be just put_bytes('.', 'contents')
[15:26] <henninge> abentley: oh cool, thanks.
[15:29] <abentley> henninge, actually, I guess you're starting with a transport, so you'd do root_transport.clone('foo/bar/bla.pt')
[15:55] <henninge> abentley: put_bytes does not like '.', it seems. http://paste.ubuntu.com/381669/
[15:56]  * henninge tries to use basename, now.
[15:56] <abentley> henninge, looking.
[15:57] <henninge> abentley: the code snippet http://paste.ubuntu.com/381673/
[16:00] <abentley> henninge, that's irritating; it works with mkdir.
=== matsubara-lunch is now known as matsubara
[16:07] <abentley> henninge, I suggest: https://pastebin.canonical.com/28208/
[16:09] <henninge> abentley: thanks. Only it is "create_prefix". ;) You might be confusing it with ensure_base.
[16:10] <abentley> henninge, okay, so ensure_base would probably be more appropriate.
[16:10] <abentley> henninge, actually, no.
[16:10] <henninge> abentley: no, I looked at the code and it's not recursive
[16:11] <henninge> or iterative ... ;)
[16:11] <abentley> henninge, ^
[16:11] <henninge> right ;)
[16:24] <gmb> intellectronica: What was the final outcome of your review of my branch? LP still says "pending" for your review and I haven't seen any emails about it.
[16:24] <intellectronica> gmb: really? it was r=me, and i definitely approved it in the ui
[16:25] <gmb> intellectronica: Hrm. Nothing showing on the mp at all. Can you re-approve it for the sake of seeing what happens?
[16:26] <intellectronica> gmb: yes, approved again now. don't know what happened
[16:26] <gmb> intellectronica: Thanks.
[16:41] <noodles775> hi henninge, I'll be leaving soon, just wondering if you had any questions about the MP?
[16:43] <abentley> BjornT, what's the status of lp:~bjornt/launchpad/form-overlay-render-by-default ?
[16:51] <henninge> noodles775: sorry, I did not get  very far...
[16:52] <henninge> noodles775: but no questions so far.
[16:57] <noodles775> OK, thanks henninge.
[17:09] <al-maisan> Hello there! I have a simple branch that fixes spurious test failures.
[17:09] <al-maisan> https://code.edge.launchpad.net/~al-maisan/launchpad/fuzzy-test-525329/+merge/19885
[17:09] <al-maisan> 46 lines
[17:09] <al-maisan> anybody willing to review it?
=== al-maisan changed the topic of #launchpad-reviews to: on call: intellectronica, henninge, abentley || reviewing: -, noodles775, - || queue [al-maisan] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:11] <al-maisan> abentley: could you please take a look?
[17:11] <abentley> al-maisan, sure.
[17:11] <al-maisan> thanks!
[17:15] <abentley> al-maisan, r=me
[17:15] <al-maisan> abentley: thank you very much!
=== abentley changed the topic of #launchpad-reviews to: on call: intellectronica, henninge, abentley || reviewing: -, noodles775, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to: on call: henninge, abentley || reviewing: noodles775, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:16] <abentley> al-maisan, it might be profitable to allow an external time source to be used, but that would probably take more re-engineering.
=== henninge is now known as henninge-afk
[17:17] <al-maisan> abentley: indeed.
=== jamalta is now known as jamalta-afk
=== jamalta-afk is now known as jamalta
=== jamalta is now known as jamalta-afk
=== jamalta-afk is now known as jamalta
=== gary_poster is now known as gary-lunch
[18:11] <mrevell> Hey, anyone want the easiest review evah? :) It's the what's new for 10.02 https://code.edge.launchpad.net/~matthew.revell/launchpad/whatsnew-10.02/+merge/19892
=== mrevell is now known as mrevell-dinner
[18:20]  * jpds needs https://code.edge.launchpad.net/~jpds/launchpad/fix_520469/+merge/19890 looking into. :)
=== jpds changed the topic of #launchpad-reviews to: on call: henninge, abentley || reviewing: noodles775, - || queue [mrevell, jpds] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== jpds changed the topic of #launchpad-reviews to: on call: henninge, abentley || reviewing: noodles775, - || queue [mrevell] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== danilos is now known as daniloff
=== gary-lunch is now known as gary_poster
[19:52] <jpds> thumper: I fixed the issues you found on https://code.launchpad.net/~jpds/launchpad/fix_517839/+merge/19774
[19:52] <thumper> jpds: cool
[19:55] <thumper> jpds: done
[19:56] <jpds> thumper: Can you please ec2land it for me? I don't have access to PQM.
[19:56] <thumper> jpds: yep
[19:57] <jpds> Awesome, thanks. :)
=== abentley changed the topic of #launchpad-reviews to: on call: henninge, abentley || reviewing: noodles775, - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[21:15] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/no-none-subject/+merge/19902
[21:15] <thumper> very trivial
[21:18] <mwhudson> thumper: done
[21:31] <rockstar> abentley, do you have time for my trivial bug?
=== matsubara is now known as matsubara-afk
[21:51] <abentley> rockstar, looking
[21:54] <rockstar> abentley, actually, I think it might be better to just pass the bugbranch.bug.default_bugtask into the DeletionCallable.
[21:54] <rockstar> abentley, then I don't need the messy change to the tal.
[21:56] <abentley> rockstar, I agree.  Actually, I'm not sure we should still be displaying it, but that needs more thought.
[21:57] <rockstar> abentley, well, it's not doing any harm displaying it instead of the bug itself.
[21:58] <abentley> rockstar, I'm about to EOD.
[21:58] <rockstar> abentley, okay, I'll push this change so you can see it.
[21:58] <abentley> Cool.
[22:00] <thumper> mwhudson: ec2 land is complaining because you just approved without reviewing :)
[22:00] <mwhudson> thumper: must be a bug in the ui
[22:01] <mwhudson> :)
[22:01] <mwhudson> thumper: done now
[22:01] <thumper> mwhudson: ta
[22:01] <rockstar> abentley, just waiting for lp to figure out the branch has changes now...
[22:03] <rockstar> abentley, new diff there.
[22:05] <abentley> rockstar, r=me.  Maybe you should change "deleted-items" into "deletion-items" since they haven't been deleted yet.
[22:05] <rockstar> abentley, okay.  I'll do that.
[23:19] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/code-review-email-attachment-fix/+merge/19924 anyone?
[23:19]  * thumper heads out for coffee