/srv/irclogs.ubuntu.com/2010/02/23/#launchpad-reviews.txt

mwhudsonthumper: done00:20
thumpermwhudson: ta00:34
* maxb has a merge, if someone's free: https://code.edge.launchpad.net/~maxb/launchpad/py2.6-importfascist-again/+merge/1992701:07
mwhudsonmaxb: done01:13
mwhudsonmaxb: want to set a commit message?01:14
maxboh, I always forget that01:14
maxbany reason not to just copy the commit message of the single revision, for single revision branches?01:14
mwhudsoni guess that would be a sensible default01:15
maxbI've set that01:15
=== jamalta is now known as jamalta-afk
mwhudsonthumper: hi, can you review a simple branch?02:40
mwhudsonthumper: found a problem in the incremental import stuff, luckily it's super easy02:40
mwhudsonmaxb: your branch is in ec2 btw02:41
mwhudson(has been for a while)02:41
thumpermwhudson: sure02:41
mwhudsonthumper: https://code.edge.launchpad.net/~mwhudson/launchpad/incremental-oops/+merge/1993102:43
mwhudsonthumper: otherwise the incremental stuff seems to be going ok02:44
thumpermwhudson: testing on staging?02:44
mwhudsonalthough the setup part before it starts importing revisions is a bit long02:45
thumpermwhudson: done02:45
mwhudsonso maybe we should up the number of revisions we import02:46
mwhudsonhooray for QA i guess02:47
mwhudsonmaxb: actually i lied there02:47
mwhudsontrying again...02:47
=== henninge_ is now known as henninge
noodles775Hi henninge, did you get a chance to start/finish my MP? If not, I'll ask todays ocr to take a look.08:47
henningenoodles775: I did start and I will finish it this morning ...;-)08:48
noodles775Great, thanks henninge !08:48
henningenoodles775: review sent.09:59
=== henninge changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
noodles775Thanks henninge.09:59
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bigjools changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [bigjools] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
bigjoolsan easy soyuz branch in the queue for ya gmb :)11:23
gmbbigjools: Ta.11:23
bigjoolshttps://code.launchpad.net/~julian-edwards/launchpad/publish-copy-archives-bug-520520-getPubConfig-proc-accept/+merge/1995511:23
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: bigjools || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
bigjoolssorry for the terse cover note11:23
bigjoolsI wrote a long one then my mail client crashed11:23
bigjoolsI was too depressed to re-create it11:23
bigjoolsso I am here to answer your questions11:24
intellectronicanoodles775: can i bother you for a code and ui review for a small lazr-js change? 20 lines of code, and the ui review is quite trivial too11:29
noodles775intellectronica: sure.11:32
intellectronicanoodles775: lovely. sending an MP your way11:32
intellectronicanoodles775: https://code.edge.launchpad.net/~intellectronica/lazr-js/choiceedit-position/+merge/1995611:40
noodles775intellectronica: thanks, I'll just finish off a branch for review, and then start it.11:45
intellectronicacheers11:46
gmbbigjools: No answers needed; it actually made sense for a change... r=me with some minor coding-style fixes11:46
bigjoolsgmb: for a change? :)11:46
bigjoolsthanks for the review11:46
gmbnp11:46
bigjoolsblame vim's python mode for the closing brace positioning :/11:47
=== noodles775 changed the topic of #launchpad-reviews to: on call: gmb || reviewing: bigjools || queue [noodles775] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
noodles775Hi gmb, this one is pure test refactoring, and is just over 800lines: https://code.edge.launchpad.net/~michael.nelson/launchpad/ppa-privatisation-test-refactor4/+merge/1996112:11
gmbEeesh.12:11
gmbnoodles775: Okay, I'll take a look12:11
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: noodles775 || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
gmbseems like the week of the long branches.12:11
noodles775Yeah, and it's the 4th pipe in the test refactoring! Thanks gmb, let me know if you want me to move some of the changes to the next branch to make it more manageable.12:12
=== matsubara-afk is now known as matsubara
gmbnoodles775: I like how "just over" means "+11%" ;)12:13
gmbnoodles775: But no, it's fine. I'll take care of it.12:13
noodles775gmb: thanks.12:13
=== daniloff is now known as danilos
gmbnoodles775: r=me12:50
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: lunch || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
noodles775Thanks gmb12:50
noodles775intellectronica: I can see from the code what your lazr-js branch is meant to do, but when testing it in a browser, I can find a way to show the difference between trunk and your branch?12:52
intellectronicanoodles775: i'm not sure i understand the question. do you mean that it behaves in the same way the version in trunk behaves?12:53
intellectronicanoodles775: and if so, could it be a cache issue?12:53
noodles775intellectronica: yes, with the two side-by-side, I haven't found a way to ...12:53
noodles775ah...12:53
noodles775intellectronica: http://people.canonical.com/~michaeln/tmp/intellectronica.ogv13:01
noodles775intellectronica: forget that...13:02
noodles775I just saw the issue (my end, too many tabs)13:03
intellectronicanoodles775: looks like it's working correctly. some of the entries you choose cause the box to go out of screen, and that's why the position is not as expected. as i explained in the MP, i can't think of a better way of handling that situation13:04
intellectronicai wish i could cause the mouse pointer to move13:05
noodles775intellectronica: yeah, I was just thinking the same thing ;)13:05
noodles775intellectronica: code-wise, any reason for not using boundingBox.query('span.current') instead of iterating through all the spans?13:10
intellectronicanoodles775: no, i just didn't think of that. let me give that a try.13:10
intellectronicanoodles775: yeah, that works fine. changing.13:12
noodles775Great, r=me.13:13
intellectronicanoodles775: thanks!13:13
jpdsDoes anyone know if ec2test is having problems?13:20
noodles775jpds: Twice in the past few weeks I've had an ec2 run not come back (gets stalled during windmill and then I have to terminate it). But I've just rerun them and it worked fine.13:20
* noodles775 -> lunch13:21
jpdsTwo branches of mine were approved yesterday and still haven't landed. :/13:21
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: lunch || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: lunch,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
bacjpds: do you need me to re-submit them or will your reviewer do it?13:24
jpdsbac: They're https://code.launchpad.net/~jpds/launchpad/fix_517839/+merge/19774 and https://code.launchpad.net/~jpds/launchpad/fix_520469/+merge/1989013:25
bacjpds: ok13:25
leonardrbac: trivial branch: https://code.edge.launchpad.net/~leonardr/lazr.restful/prep-for-release/+merge/1996813:29
bacleonardr: ok, i'll get right on it13:30
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: lunch,leonard || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: lunch,- || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
bacleonardr: that really was trivial13:38
leonardrbac: yes, but gary dings me if i commit to lazr.* without an r=13:38
leonardrand i agree with him13:38
bacglad to help13:38
bacjpds: both sent off.  cross your fingers13:51
jpdsbac: "What could possibly go wrong?"13:52
bacnothing i can think of!13:52
adeuringgmb, bac: could one of you do review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/bug-513382/+merge/19970 (should be really simple)13:55
adeuringnoodles775: could you ui--review this ^^^^branch?13:56
bacadeuring: yes13:56
adeuringbac: thanks13:56
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: lunch,abel || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: - , abel || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
leonardrintellectronica, if you're around, i need one more review of https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-integration14:01
intellectronicaleonardr: ok14:01
leonardrintellectronica: i'm preparing an incremental diff now14:01
intellectronicaleonardr: thanks14:02
leonardrintellectronica: http://pastebin.ubuntu.com/382273/14:10
leonardrwriting up the changes now14:10
intellectronicaleonardr: why the change in doc/menus.txt?14:11
intellectronicaoh, ok, i'll wait then :)14:11
leonardrintellectronica:https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-integration/+merge/1934614:14
intellectronicaleonardr: so my question (above) still stands14:15
leonardrintellectronica: what's missing from the explanation i gave?14:15
leonardroh, menus.txt14:16
intellectronicayes, i don't understand why the error changed14:16
leonardrsorry, i thouht you were talking about folder.txt14:16
leonardri'll write another comment14:16
intellectronicacool14:16
leonardrintellectronica: added14:18
intellectronicaah, got it14:19
intellectronicaleonardr: r=me14:19
leonardrok, time to test it and hopefully see no more failures14:19
=== jamalta-afk is now known as jamalta
noodles775Hi adeuring, I can, but it'd be great to first request a UI review from one of the people with an asterisk at: https://dev.launchpad.net/UI/Reviews - I can then do the second UI review.14:27
noodles775This'll help us build up more ui reviewers.14:27
noodles775But if it's urgent, I'll do it straight away.14:27
adeuringnoodles775: sure, but this one is really trivial...14:27
noodles775adeuring: ok, I'll do it straight away then :)14:27
bacadeuring: wow, the reviews today keep getting more trivial14:32
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: - , - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
noodles775adeuring: I think you've got the wrong bug linked on your MP ;) ui=me, thanks!14:36
noodles775adeuring: I think you've got the wrong bug linked on your MP ;) ui=me, thanks!14:37
adeuringnoodles775: thanks! and right, the bug is 513380...14:42
=== deryck is now known as deryck[lunch]
=== salgado is now known as salgado-lunch
=== matsubara is now known as matsubara-lunch
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: - , jtv || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
al-maisanhello gmb, here's a branch that remedies the merge conflict between stable and db-devel, https://code.edge.launchpad.net/~al-maisan/launchpad/merge-conflict/+merge/1998116:20
al-maisanCould you please have a look at it?16:20
gmbal-maisan: Sure16:20
al-maisanthanks!16:20
=== gmb changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: al-maisan, jtv || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
gmbal-maisan: Is there some extra data in the diff? It looks like there's other changes in there besides conflict resolutions.16:21
al-maisangmb: I actually merged stable into db-devel and then resolved the conflicts .. that's what you're seeing..16:22
gmbAh.16:22
gmbal-maisan: Looks fair enough. r=me16:26
al-maisangmb: thank you very much!16:26
gmbnp16:26
=== gmb changed the topic of #launchpad-reviews to: on call: bac || reviewing: jtv || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== deryck[lunch] is now known as deryck
adeuringbac, noodles775: could you please re-review my MP https://code.edge.launchpad.net/~adeuring/launchpad/bug-513382/+merge/19970 ?16:49
bacadeuring: i will.  i'm in the middle of a long one and my lunch is fast approaching.  i'll do it later if that's ok16:50
adeuringbac: sure, thanks16:50
=== jamalta is now known as jamalta-afk
noodles775adeuring: I'll do it first thing tomorrow (as I'm off for dinner in a tick).16:54
adeuringnoodles775:  thanks!16:54
=== matsubara-lunch is now known as matsubara
=== salgado-lunch is now known as salgado
leonardrrockstar, do you want to review https://code.edge.launchpad.net/~leonardr/lazr.restful/register-operations-when-version-list-is-known/+merge/19985 ?17:50
rockstarleonardr, well, I'm a bit tied up at the moment.  You might be better served having bac look at it.17:52
leonardrrockstar: sure, just wanted to give you right of first refusal since it's multiversion17:53
leonardrbac: -^17:53
jtvbac: sorry for the extensive drive-by damage :)17:55
=== gary_poster is now known as gary-lunch
al-maisanhello bac, this branch resolves the "stable -> db-devel" merge conflicts, https://code.edge.launchpad.net/~al-maisan/launchpad/merge-conflicts-2/+merge/1999419:35
al-maisanCan you please take a look?19:35
bacal-maisan: is this different from the similar branch you did earlier today that gmb looked at?19:36
al-maisanit is similar in the sense that it resolves the merge conflict19:36
al-maisanhrmpff .. the diff generation takes ages19:37
al-maisanbac: the diff is available now19:37
bacal-maisan: the diff isn't available here yet.  propogation delay19:38
bacand now i have it19:38
al-maisangreat!19:38
bacal-maisan: done19:39
bacthanks muharem19:39
al-maisanbac: thank you!19:39
EdwinGrubbsbac: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-526001-edit-packaging-oops/+merge/1999719:53
bacEdwinGrubbs: yes.  please add to the queue19:55
=== EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: jtv || queue [adiroiban(bug-509252-take-2), Edwin(bug-526001)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
bacleonardr: i didn't see your request.  i'll put it on the queue where it would've landed20:01
=== bac changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue [adiroiban(bug-509252-take-2), leonard, Edwin(bug-526001)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: abel || queue [adiroiban(bug-509252-take-2), leonard, Edwin(bug-526001)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
bacEdwinGrubbs: if you have a moment could you look at https://code.edge.launchpad.net/~adeuring/launchpad/bug-513382/+merge/19970 since it involves sprites?20:05
=== gary-lunch is now known as gary_poster
bacadiroiban: i'd prefer to let henninge re-review your changes20:15
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: leonard || queue [adiroiban(bug-509252-take-2), leonard, Edwin(bug-526001)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: leonard || queue [adiroiban(bug-509252-take-2), Edwin(bug-526001)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: edwin || queue [adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
bacEdwinGrubbs: you didn't add a test case to show an obsolete productseries20:21
EdwinGrubbsbac: I can add that.20:22
bacEdwinGrubbs: thanks20:22
thumperrockstar: https://code.edge.launchpad.net/~thumper/launchpad/descriptions-for-merge-proposals/+merge/1956420:34
abentleythumper, could you review https://code.launchpad.net/~abentley/launchpad/restricted-diffs/+merge/19999 ?20:51
thumperoooh 1999920:51
thumperabentley: yes20:51
abentleythumper, thanks.20:52
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
=== bac changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [adiroiban(bug-509252-take-2)] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== sinzui changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [adiroiban(bug-509252-take-2), sinzui] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
EdwinGrubbsbac: looking at adeuring's branch, the only info that couldn't be displayed if he switched it to sprites would be the alt tag on the image. The size of the sprite is no problem.22:12
bacEdwinGrubbs: would you mind adding that to the MP?22:13
EdwinGrubbsbac: no problem22:13
mwhudsonthumper: around to review a branch?23:23
mwhudsonhttps://code.edge.launchpad.net/~mwhudson/launchpad/incremental-save-all-revs/+merge/20020 if you or anyone else fancies it23:27
* thumper looks23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!