[00:20] <mwhudson> thumper: done
[00:34] <thumper> mwhudson: ta
[01:07]  * maxb has a merge, if someone's free: https://code.edge.launchpad.net/~maxb/launchpad/py2.6-importfascist-again/+merge/19927
[01:13] <mwhudson> maxb: done
[01:14] <mwhudson> maxb: want to set a commit message?
[01:14] <maxb> oh, I always forget that
[01:14] <maxb> any reason not to just copy the commit message of the single revision, for single revision branches?
[01:15] <mwhudson> i guess that would be a sensible default
[01:15] <maxb> I've set that
[02:40] <mwhudson> thumper: hi, can you review a simple branch?
[02:40] <mwhudson> thumper: found a problem in the incremental import stuff, luckily it's super easy
[02:41] <mwhudson> maxb: your branch is in ec2 btw
[02:41] <mwhudson> (has been for a while)
[02:41] <thumper> mwhudson: sure
[02:43] <mwhudson> thumper: https://code.edge.launchpad.net/~mwhudson/launchpad/incremental-oops/+merge/19931
[02:44] <mwhudson> thumper: otherwise the incremental stuff seems to be going ok
[02:44] <thumper> mwhudson: testing on staging?
[02:45] <mwhudson> although the setup part before it starts importing revisions is a bit long
[02:45] <thumper> mwhudson: done
[02:46] <mwhudson> so maybe we should up the number of revisions we import
[02:47] <mwhudson> hooray for QA i guess
[02:47] <mwhudson> maxb: actually i lied there
[02:47] <mwhudson> trying again...
[08:47] <noodles775> Hi henninge, did you get a chance to start/finish my MP? If not, I'll ask todays ocr to take a look.
[08:48] <henninge> noodles775: I did start and I will finish it this morning ...;-)
[08:48] <noodles775> Great, thanks henninge !
[09:59] <henninge> noodles775: review sent.
[09:59] <noodles775> Thanks henninge.
[11:23] <bigjools> an easy soyuz branch in the queue for ya gmb :)
[11:23] <gmb> bigjools: Ta.
[11:23] <bigjools> https://code.launchpad.net/~julian-edwards/launchpad/publish-copy-archives-bug-520520-getPubConfig-proc-accept/+merge/19955
[11:23] <bigjools> sorry for the terse cover note
[11:23] <bigjools> I wrote a long one then my mail client crashed
[11:23] <bigjools> I was too depressed to re-create it
[11:24] <bigjools> so I am here to answer your questions
[11:29] <intellectronica> noodles775: can i bother you for a code and ui review for a small lazr-js change? 20 lines of code, and the ui review is quite trivial too
[11:32] <noodles775> intellectronica: sure.
[11:32] <intellectronica> noodles775: lovely. sending an MP your way
[11:40] <intellectronica> noodles775: https://code.edge.launchpad.net/~intellectronica/lazr-js/choiceedit-position/+merge/19956
[11:45] <noodles775> intellectronica: thanks, I'll just finish off a branch for review, and then start it.
[11:46] <intellectronica> cheers
[11:46] <gmb> bigjools: No answers needed; it actually made sense for a change... r=me with some minor coding-style fixes
[11:46] <bigjools> gmb: for a change? :)
[11:46] <bigjools> thanks for the review
[11:46] <gmb> np
[11:47] <bigjools> blame vim's python mode for the closing brace positioning :/
[12:11] <noodles775> Hi gmb, this one is pure test refactoring, and is just over 800lines: https://code.edge.launchpad.net/~michael.nelson/launchpad/ppa-privatisation-test-refactor4/+merge/19961
[12:11] <gmb> Eeesh.
[12:11] <gmb> noodles775: Okay, I'll take a look
[12:11] <gmb> seems like the week of the long branches.
[12:12] <noodles775> Yeah, and it's the 4th pipe in the test refactoring! Thanks gmb, let me know if you want me to move some of the changes to the next branch to make it more manageable.
[12:13] <gmb> noodles775: I like how "just over" means "+11%" ;)
[12:13] <gmb> noodles775: But no, it's fine. I'll take care of it.
[12:13] <noodles775> gmb: thanks.
[12:50] <gmb> noodles775: r=me
[12:50] <noodles775> Thanks gmb
[12:52] <noodles775> intellectronica: I can see from the code what your lazr-js branch is meant to do, but when testing it in a browser, I can find a way to show the difference between trunk and your branch?
[12:53] <intellectronica> noodles775: i'm not sure i understand the question. do you mean that it behaves in the same way the version in trunk behaves?
[12:53] <intellectronica> noodles775: and if so, could it be a cache issue?
[12:53] <noodles775> intellectronica: yes, with the two side-by-side, I haven't found a way to ...
[12:53] <noodles775> ah...
[13:01] <noodles775> intellectronica: http://people.canonical.com/~michaeln/tmp/intellectronica.ogv
[13:02] <noodles775> intellectronica: forget that...
[13:03] <noodles775> I just saw the issue (my end, too many tabs)
[13:04] <intellectronica> noodles775: looks like it's working correctly. some of the entries you choose cause the box to go out of screen, and that's why the position is not as expected. as i explained in the MP, i can't think of a better way of handling that situation
[13:05] <intellectronica> i wish i could cause the mouse pointer to move
[13:05] <noodles775> intellectronica: yeah, I was just thinking the same thing ;)
[13:10] <noodles775> intellectronica: code-wise, any reason for not using boundingBox.query('span.current') instead of iterating through all the spans?
[13:10] <intellectronica> noodles775: no, i just didn't think of that. let me give that a try.
[13:12] <intellectronica> noodles775: yeah, that works fine. changing.
[13:13] <noodles775> Great, r=me.
[13:13] <intellectronica> noodles775: thanks!
[13:20] <jpds> Does anyone know if ec2test is having problems?
[13:20] <noodles775> jpds: Twice in the past few weeks I've had an ec2 run not come back (gets stalled during windmill and then I have to terminate it). But I've just rerun them and it worked fine.
[13:21]  * noodles775 -> lunch
[13:21] <jpds> Two branches of mine were approved yesterday and still haven't landed. :/
[13:24] <bac> jpds: do you need me to re-submit them or will your reviewer do it?
[13:25] <jpds> bac: They're https://code.launchpad.net/~jpds/launchpad/fix_517839/+merge/19774 and https://code.launchpad.net/~jpds/launchpad/fix_520469/+merge/19890
[13:25] <bac> jpds: ok
[13:29] <leonardr> bac: trivial branch: https://code.edge.launchpad.net/~leonardr/lazr.restful/prep-for-release/+merge/19968
[13:30] <bac> leonardr: ok, i'll get right on it
[13:38] <bac> leonardr: that really was trivial
[13:38] <leonardr> bac: yes, but gary dings me if i commit to lazr.* without an r=
[13:38] <leonardr> and i agree with him
[13:38] <bac> glad to help
[13:51] <bac> jpds: both sent off.  cross your fingers
[13:52] <jpds> bac: "What could possibly go wrong?"
[13:52] <bac> nothing i can think of!
[13:55] <adeuring> gmb, bac: could one of you do review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/bug-513382/+merge/19970 (should be really simple)
[13:56] <adeuring> noodles775: could you ui--review this ^^^^branch?
[13:56] <bac> adeuring: yes
[13:56] <adeuring> bac: thanks
[14:01] <leonardr> intellectronica, if you're around, i need one more review of https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-integration
[14:01] <intellectronica> leonardr: ok
[14:01] <leonardr> intellectronica: i'm preparing an incremental diff now
[14:02] <intellectronica> leonardr: thanks
[14:10] <leonardr> intellectronica: http://pastebin.ubuntu.com/382273/
[14:10] <leonardr> writing up the changes now
[14:11] <intellectronica> leonardr: why the change in doc/menus.txt?
[14:11] <intellectronica> oh, ok, i'll wait then :)
[14:14] <leonardr> intellectronica:https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-integration/+merge/19346
[14:15] <intellectronica> leonardr: so my question (above) still stands
[14:15] <leonardr> intellectronica: what's missing from the explanation i gave?
[14:16] <leonardr> oh, menus.txt
[14:16] <intellectronica> yes, i don't understand why the error changed
[14:16] <leonardr> sorry, i thouht you were talking about folder.txt
[14:16] <leonardr> i'll write another comment
[14:16] <intellectronica> cool
[14:18] <leonardr> intellectronica: added
[14:19] <intellectronica> ah, got it
[14:19] <intellectronica> leonardr: r=me
[14:19] <leonardr> ok, time to test it and hopefully see no more failures
[14:27] <noodles775> Hi adeuring, I can, but it'd be great to first request a UI review from one of the people with an asterisk at: https://dev.launchpad.net/UI/Reviews - I can then do the second UI review.
[14:27] <noodles775> This'll help us build up more ui reviewers.
[14:27] <noodles775> But if it's urgent, I'll do it straight away.
[14:27] <adeuring> noodles775: sure, but this one is really trivial...
[14:27] <noodles775> adeuring: ok, I'll do it straight away then :)
[14:32] <bac> adeuring: wow, the reviews today keep getting more trivial
[14:36] <noodles775> adeuring: I think you've got the wrong bug linked on your MP ;) ui=me, thanks!
[14:37] <noodles775> adeuring: I think you've got the wrong bug linked on your MP ;) ui=me, thanks!
[14:42] <adeuring> noodles775: thanks! and right, the bug is 513380...
[16:20] <al-maisan> hello gmb, here's a branch that remedies the merge conflict between stable and db-devel, https://code.edge.launchpad.net/~al-maisan/launchpad/merge-conflict/+merge/19981
[16:20] <al-maisan> Could you please have a look at it?
[16:20] <gmb> al-maisan: Sure
[16:20] <al-maisan> thanks!
[16:21] <gmb> al-maisan: Is there some extra data in the diff? It looks like there's other changes in there besides conflict resolutions.
[16:22] <al-maisan> gmb: I actually merged stable into db-devel and then resolved the conflicts .. that's what you're seeing..
[16:22] <gmb> Ah.
[16:26] <gmb> al-maisan: Looks fair enough. r=me
[16:26] <al-maisan> gmb: thank you very much!
[16:26] <gmb> np
[16:49] <adeuring> bac, noodles775: could you please re-review my MP https://code.edge.launchpad.net/~adeuring/launchpad/bug-513382/+merge/19970 ?
[16:50] <bac> adeuring: i will.  i'm in the middle of a long one and my lunch is fast approaching.  i'll do it later if that's ok
[16:50] <adeuring> bac: sure, thanks
[16:54] <noodles775> adeuring: I'll do it first thing tomorrow (as I'm off for dinner in a tick).
[16:54] <adeuring> noodles775:  thanks!
[17:50] <leonardr> rockstar, do you want to review https://code.edge.launchpad.net/~leonardr/lazr.restful/register-operations-when-version-list-is-known/+merge/19985 ?
[17:52] <rockstar> leonardr, well, I'm a bit tied up at the moment.  You might be better served having bac look at it.
[17:53] <leonardr> rockstar: sure, just wanted to give you right of first refusal since it's multiversion
[17:53] <leonardr> bac: -^
[17:55] <jtv> bac: sorry for the extensive drive-by damage :)
[19:35] <al-maisan> hello bac, this branch resolves the "stable -> db-devel" merge conflicts, https://code.edge.launchpad.net/~al-maisan/launchpad/merge-conflicts-2/+merge/19994
[19:35] <al-maisan> Can you please take a look?
[19:36] <bac> al-maisan: is this different from the similar branch you did earlier today that gmb looked at?
[19:36] <al-maisan> it is similar in the sense that it resolves the merge conflict
[19:37] <al-maisan> hrmpff .. the diff generation takes ages
[19:37] <al-maisan> bac: the diff is available now
[19:38] <bac> al-maisan: the diff isn't available here yet.  propogation delay
[19:38] <bac> and now i have it
[19:38] <al-maisan> great!
[19:39] <bac> al-maisan: done
[19:39] <bac> thanks muharem
[19:39] <al-maisan> bac: thank you!
[19:53] <EdwinGrubbs> bac: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-526001-edit-packaging-oops/+merge/19997
[19:55] <bac> EdwinGrubbs: yes.  please add to the queue
[20:01] <bac> leonardr: i didn't see your request.  i'll put it on the queue where it would've landed
[20:05] <bac> EdwinGrubbs: if you have a moment could you look at https://code.edge.launchpad.net/~adeuring/launchpad/bug-513382/+merge/19970 since it involves sprites?
[20:15] <bac> adiroiban: i'd prefer to let henninge re-review your changes
[20:21] <bac> EdwinGrubbs: you didn't add a test case to show an obsolete productseries
[20:22] <EdwinGrubbs> bac: I can add that.
[20:22] <bac> EdwinGrubbs: thanks
[20:34] <thumper> rockstar: https://code.edge.launchpad.net/~thumper/launchpad/descriptions-for-merge-proposals/+merge/19564
[20:51] <abentley> thumper, could you review https://code.launchpad.net/~abentley/launchpad/restricted-diffs/+merge/19999 ?
[20:51] <thumper> oooh 19999
[20:51] <thumper> abentley: yes
[20:52] <abentley> thumper, thanks.
[22:12] <EdwinGrubbs> bac: looking at adeuring's branch, the only info that couldn't be displayed if he switched it to sprites would be the alt tag on the image. The size of the sprite is no problem.
[22:13] <bac> EdwinGrubbs: would you mind adding that to the MP?
[22:13] <EdwinGrubbs> bac: no problem
[23:23] <mwhudson> thumper: around to review a branch?
[23:27] <mwhudson> https://code.edge.launchpad.net/~mwhudson/launchpad/incremental-save-all-revs/+merge/20020 if you or anyone else fancies it
[23:59]  * thumper looks