/srv/irclogs.ubuntu.com/2010/02/24/#launchpad-dev.txt

thumperwgrant: eh?00:04
thumperwgrant: launchpad.dev uses openid?00:04
wgrantthumper: Yeah.00:05
wgrantAnd edge will tonight.00:05
thumperwhy?00:05
wgrantBecause c-i-p is the new hotness.00:05
thumpercip?00:06
wgrantcanonical-insecurity-provider00:06
thumperand wtf is that?00:06
wgrantlogin.ubuntu.com00:06
lifelessthumper: the i is identity00:18
wgrantNot after 48 hours.00:18
lifelesswgrant: do we need to stop the rollout ?00:18
thumperwgrant: does this mean you can't create a user?00:19
thumperwgrant: locally?00:19
wgrantthumper: The OpenID thing does, but that's easily resolved with the factory.00:19
wgrantJust a little annoying that all this functionality is being pushed into an external proprietary application the development team for which isn't doing a very good job.00:20
=== bjf is now known as bjf-afk
=== jamalta-afk is now known as jamalta
thumpermy current branch is 1600 revisions behind devel... :(01:33
lifelessthumper: wheee01:34
thumperlifeless: and I merged trunk with no conflicts \o/01:34
lifelessnice01:36
lifelesswhat vcs are you using ? :)01:36
thumperlifeless: perforce01:36
thumperheh01:36
lifelesshaha01:36
thumperNOT!01:36
* mwhudson writes a LEP: using clearcase for launchpad development01:41
lifelessmwhudson: E stands for enhancement01:41
mwhudsonlifeless: spoilsport!01:41
lifelessmwhudson: :>01:41
wgrantAre Clearcase and Perforce really that bad?01:46
wgrantI know VSS is, but I haven't had the pleasure of using the other two.01:46
lifelessdifferently bad01:46
lifelessnot dataloss bad like vss01:46
wgrantPfft. Where's the fun in that?01:47
thumperwgrant: perforce is quite good01:47
thumperwgrant: clearcase is fcuking aweful01:48
* thumper checks his spelling01:48
thumperno e01:48
thumperawful01:48
thumperhorrible01:48
thumpermakes you want to slit your wrists01:48
lifelessso, a lphant then ?01:49
thumperperforce at least does what you expect01:49
thumperclearcase takes forever, slow, complex and doesn't always do what you want01:49
thumperdoesn't even have atomic commits01:50
wgrantEw.01:50
mwhudsonapparently it gained atomic commits in december 2009!!01:50
thumpermwhudson: really?01:52
mwhudsonthumper: it's what wikipedia says01:53
thumperok, didn't have atomic commits when I used it01:53
thumperwhich was 200601:53
maxbhmm. I get a different set of test failures on lucid to wgrant02:33
wgrantmaxb: What failed?02:35
wgrant(this brings back bad, bad memories of mid-Karmic)02:36
maxbAppServerLayer oopsed all over the place, and I have one bugs windmill failure02:36
wgrantWhich Windmill test failed?02:37
wgrantAnd what were the AppServerLayer oopses?02:37
maxbohh.... wait a moment02:38
maxbit might work better if I had testopenid.dev in my /etc/hosts02:38
wgrantYeah.02:38
maxbthe oopsing just gave me a load of 500 internal server errors, and nothing more helpful in a visible log02:39
wgrantIt'll be the OpenID XRDS hostname lookup exception.02:40
maxbhmm, so now I just have test_bug_tags_entry (lp.bugs.windmill.tests.test_bug_tags_entry.TestBugTagsEntry)02:44
wgrantmaxb: that passed here. What's the error?02:45
* wgrant tries on recent devel.02:45
maxbrerunning, I suppose it could have been openid issues too02:45
maxbyeah, it's happy now02:46
maxbwell, that's nice. Lucid here we come... next up python2.602:46
wgrantmaxb: Can you reproduce the two identical question-target.txt failures, and the test_ftparchive one?02:47
maxbquestion-target.txt did not fail for me02:47
wgrantThe question-target.txt one looks really odd -- the query should ensure order.02:47
* wgrant reruns.02:47
maxbI see the ftparchive one02:47
wgrantI haven't looked at that one at all.02:48
wgrantI also need to test utilities/*, since some of it is broken.02:48
maxboh, you mean the "You need to invoke update-sourcecode using the system python, not what its shebang says" problem?02:49
wgrantyes.02:49
wgrantAnd maybe others too02:49
wgrantHave you had the bootstrapping issue lately?02:50
wgrantI ran into it for the first time in weeks last night when trying the python2.6 branch.02:50
maxbI've been working in karmic still quite a lot02:51
maxbso no, I've not seen it02:52
wgrantOK.02:52
wgrantAnd what do you know, questiontarget.txt passes for me now.02:52
wgrantActually, the failure was on db-devel.02:53
* wgrant tries there.02:53
wgrantI would really love it if the DB and librarian data directories were per-branch.02:53
lifelessdoable02:55
wgrantOK, questiontarget.txt works on db-devel too.02:57
wgrantIt must have just hated me yesterday.02:57
* wgrant looks at test_ftparchive.02:57
* wgrant vomits in the direction of lp.archiveuploader.ftparchive.03:00
wgrants/uploader/publisher/03:00
maxbuhoh, postgres 8.3 just got kicked out of lucid - so much for launchpad-dependencies being installable03:07
* maxb copies it back into the ppa03:08
wgrantUrgh.03:08
wgrantstill, it seems that stub wants to move to 8.4 really soon.03:08
maxbI love how easy it is to use PPAs to rescue removed packages03:10
wgrantYeah, it's pretty handy.03:11
maxb... pending publication on amd64 i386 powerpc sparc and ia64 :-)03:11
maxbnot often you see the ppa build status column being stretched that far03:12
wgrantNo armel?03:12
maxbit ftbfs, apparently03:12
wgrantAh.03:12
wgrantmaxb: Oh. I just realised that questiontarget.txt does still fail on db-devel. I just had my test fix in place.03:21
wgrantmaxb: can you try it on db-devel?03:21
thumperAARRGGGHHHH!!!!!03:29
thumperYUI madness03:29
* thumper heads to #yui03:34
wgrantAnybone else running LP on Lucid?03:54
pooliewgrant: only under a chroot03:55
wgrantpoolie: That's fine. Could you please 'bin/test -vvt questiontarget.txt' in db-devel?03:55
poolieit will take a few minutes, but yes03:56
pooliewgrant: just to be clear, i mean in a karmic chroot on a lucid host03:58
pooliewgrant: do you still want it?04:02
wgrantpoolie: Oh, right. That's probably not what I want, then.04:02
mwhudsongaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaar04:14
lifeless?04:15
wgrantNormally I would assume that was a JavaScript scream.04:15
mwhudsonit's a zope scream04:15
mwhudsonxml-rpc methods can't take *args04:15
lifelesshaha04:16
lifelesssorry.04:16
wgrantBetter than lazr.restful methods, which can't take positional args at all.04:16
lifeless'omg I'm so surprised'04:16
mwhudsonand it'04:16
mwhudsons basically because of stupid LBYL-ism04:16
mwhudsonwgrant: i _could_ be writing js!04:17
mwhudsontheoretically04:17
wgrantGngrg stupid doctests.04:18
wgrant-D is almost completely useless with them.04:18
wgrantAlso, WTF. I have a test failure in db-devel on Lucid that does not appear in devel. It's an ordering difference, but executing the query manually in the transaction gets the right order.04:25
poolielifeless: so it's bug 5984604:32
pooliehullo bot?04:33
* mwhudson EODs04:33
swarnahttp://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/utilities is not opening04:33
wgrantswarna: Go to http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel and browse to utilities/rocketfuel-setup from there.04:34
lifelesspoolie: well, that was about an earlier behaviour04:35
lifelesspoolie: I think perhaps the last subscriber can't unsubscribe.04:36
poolieis it? that looks like what we're hitting here04:36
lifelessno, the bug in question had plenty of subscribers04:36
wgrantAh, it's private. That's why there's no bot.04:36
lifelessand I've unprivated it.04:36
pooliehow is having lots of subscribers relevant?04:38
lifelessin reference to bug 59846, where we dealt with bugs having only one subscriber (the filer) due to a bug in the bug filing logic04:39
pooliei think kiko felt that bug was closed by dealing by cleaning up some particular cases04:40
pooliebut the description says04:40
poolie>  it seems wrong that (a member of) the *security contact* for a product can be prohibited from viewing a bug report about that product, whether they are subscribed or not.04:40
poolieand i agree with that04:40
pooliethe underlying bug still exists04:40
lifelessso, this isn't a quick topic, and I started 9 1/2 hours ago.04:41
poolienp04:41
poolieit's not urgent04:41
pooliei was just surprised04:41
pooliei understand what's causing this now, so thanks04:41
poolieyou can followup on 59846 if you want04:41
lifelessI appreciate you feel that there is a bug here; I don't see how to reconcile what you are asking for with CVE support and multiple  organisations both contributing to one project.04:41
lifelessthe bug you found wasn't filed on bzr; it was half-connected to bzr, and should have been made unprivate at the same time04:42
poolieare you saying that's a case where there are bugs that affect a project, that the project's security team is not allowed to know about?04:42
lifelesspoolie: yup04:42
lifelessas I understand it anyhow.04:43
pooliehm04:44
lifelesstwo separate cases; also note that private and 'security' are nowadays separate flags.04:44
pooliewell, nobody has yet made a case for that on that bug04:44
lifelessso I wouldn't comment on bug 59846 regardless, I'd file a new one.04:44
poolieso it looks like just a plain bug04:44
lifelesspoolie: [meta] this looks like a case where a new bug would really have been better04:48
poolieyes, you said that04:48
lifelesspoolie: I've commented there anyhow04:48
lifelessgnight04:48
poolieto me it seems like the underlying bug has not actually been fixed04:48
lifelesspoolie: it is deliberate, by design. Rejected would be a better term, for that aspect of it.04:49
pooliethat may be true but nobody has actually said so04:50
poolieexcept you :)04:50
poolieand it sounds more like defense of an accidental behaviour04:50
lifelesspoolie: comment #2 describes it04:50
lifelessI agree that a clear unambiguous statement wasn't made.04:51
poolieit's not actually the same thing04:51
lifelessAnd I'm not in a position to do that either.04:51
lifelessI'm just sharing the context and history I know of with you. Privacy was /agonised/ over.04:51
stubwgrant: If the ordering is depended on but not explicit, its broken. implicit order is effectively random (you can't even trust it to come out in disk order, as it might get pulled from a cache).05:30
wgrantstub: The order is in the query, sorry.05:55
wgrantstub: What is the timeframe for moving to PostgreSQL 8.4?05:57
wgrantstub: 8.3 is gone from Lucid now.05:57
poolielifeless: (when you're back)05:58
pooliei don't think this is a critical bug05:58
pooliebut it is pretty surprising05:58
poolieand i think there is some kind of bugginess here05:58
poolieit's internally inconsistent05:58
wgrantWhat is the bug?05:58
pooliethe security team can't see all bugs on the product05:59
poolieand, depending on the history of the bug, they may not get subscribed by default05:59
pooliefor instance adding a new bugtask does subscribe them05:59
stubAs soon as possible. Last I looked, we had maybe three or four tests failing that looked trivial. I need to get slony 1.2.20 packages backported from lucid to hardy, at which point we can test staging and migration procedures.05:59
poolieretargeting an existing bugtask does not05:59
wgrantAh. Hm.05:59
wgrantstub: Oh, excellent.05:59
wgrantpoolie: Really? I've found that moving a task explicitly subscribes the security contact even when the bug is public.06:00
stubwgrant: Bug #426823 is tracking this06:01
mupBug #426823: Update to PostgreSQL 8.4 <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/426823>06:01
pooliewgrant: nup, definitely not06:01
poolielook at https://bugs.staging.launchpad.net/launchpad/+bug/45310406:01
mupBug #453104: sftp user/password don't work <Bazaar:Incomplete> <https://launchpad.net/bugs/453104>06:01
poolieoh heh, you can't :)06:01
pooliebut try now06:02
wgrantIf mup can see it, it's probably public...06:02
poolieit's public in reality, i changed it on staging06:02
wgrantAh.06:03
* wgrant curses 64kbps throttling.06:06
lifelesspoolie: so I think this hinge on what 'security team' means06:36
lifelesspoolie: I think it means 'people to be told about new security bugs, by default'06:36
wgrantI think that is the assumption.06:36
pooliek06:36
lifelesspoolie: I'm open to 'adding a product task to a secured disto bug should subscribe the product security team'06:37
poolieright06:37
poolieor retargeting a task06:37
lifelesspoolie: but that is very different to 'the security team can always see bugs'06:37
lifelessright06:37
poolieand i dont' think it's specific to whether they're distro or product or series tasks etc06:37
lifelessconceptually perhaps not06:38
poolielifeless: so 'the security team should always see bugs' is a different bug06:38
poolieperhaps a closer match for this existing one06:38
pooliei'm kind of ok if that's marked wontfix06:38
pooliei would like there to be a public bug for it, as documentation06:38
poolieand explanation06:38
pooliei do think it's a bit weird that potentially absolutely no one from the product can see the bug06:39
lifelessI think thats fine, but something we want to have happen explicitly not accidentally06:39
wgrantIt's handy if you want to hide a bug, like I did last week.06:39
pooliei mean some bugs seem to at least accidentally have got into this state06:40
wgrantWhen does edge update these days?07:37
noodles775wgrant: I didn't realise it had changed (but haven't been watching), so I'd assume between 8:30-9:00UTC?07:38
wgrantnoodles775: buildd-manager has again been broken for three or four hours.07:38
wgrantnoodles775: It probably hasn't changed. I just didn't remember.07:39
noodles775wgrant: no losa? OK, they're still sprinting and probably having brekkie.07:39
* noodles775 tries to find out.07:39
* wgrant wonders if this actually happens quite often, but there's normally a LOSA around to respond to the Nagios scream.07:40
noodles775wgrant: I don't think so, there's a note on their page to always let us know (which is why I keep the bug up to date).07:41
wgrantnoodles775: Ah, good.07:41
noodles775If it is happening regularly now, it might be worth CP'ing the change so that it doesn't block the b-m.07:41
wgrantIt seems like it might be worth it to log all SQL queries executed by b-m to see if we can work out WTF is happening.07:42
noodles775yeah, let's chat about that with bigjools. Great, the losa's are on it :)07:44
wgrantGreat.07:45
noodles775wgrant: back to normal now, thanks to the losa's, and we'll check the sql log to see if it can point us back to a problem in the code.07:59
wgrantnoodles775, $LOSA: Thanks.08:00
* wgrant has a look through the new code for anything suspicious.08:02
wgrantIt was the building build without a builder again, right?08:02
adeuringgood morning08:17
noodles775wgrant: Thanks, and yes, a build_queue item that is dispatched (ie. has a related job with non-null date_started), but build_queue.builder is None.08:27
wgrantnoodles775: Do we have the state of build/buildqueue/job before it was repaired?08:42
noodles775wgrant: other than the above, no, but I'll update the wiki page so that we have it next time.08:44
wgrantnoodles775: Great.08:44
wgrantIt might tell us where in the build it actually was.08:44
bigjoolsg'morning09:00
wgrantMorning bigjools.09:05
mwhudsonhello europe09:06
bigjoolsmorning wellington09:07
wgrantYou know you're in trouble when the Americans (apart from deryck) show up.09:07
mwhudsonwgrant: even more so for me i guess09:08
mwhudsonhaven't stayed up that late in a while09:09
wgrantbigjools: Speaking of download stats...09:09
bigjoolsheh09:10
* mwhudson stares at buildbot, trying to figure out if his change will be in db-stable in time for the code import update in more than twelve hours time09:12
wgrantmwhudson: In time to get the incremental import repo pull fix onto staging?09:14
mwhudsonwgrant: exactly09:14
jelmermoin mwhudson09:17
jelmerhi wgrant09:17
wgrantMorning jelmer.09:17
wgrantjelmer: Are you running LP on Lucid?09:17
jelmerwgrant, yep09:17
wgrantjelmer: Can you 'bin/test -t questiontarget.txt' on db-devel, please?09:18
wgrantjelmer: I get a strange ordering failure here, but not on devel, and I wonder if anybody else can reproduce it.09:18
jelmerwgrant: ok09:19
wgrantIt's one of only two lucid test failures.09:19
* jelmer hates how slow 'make schema' is on this machine09:22
wgrantIt's slow everywhere.09:22
jelmerwgrant, running now09:32
wgrantjelmer: Thanks.09:32
jelmerwgrant, failing here too because of the ordering09:35
wgrantjelmer: excellent except not.09:36
jelmer"daf" is now the first entry rather than the second09:36
wgrantjelmer: Yep, same failure is seen here.09:36
wgrantBut the query is explicitly ordered, and running it in that transaction gets the right result.09:37
jtvhenninge: feel free to replace the intltool-debian line with plain intltool, or use them both.09:53
henningejtv: I am still not convinced they are the same.09:54
henningejtv: ah, now I see09:55
jtvhenninge: when I wrote that line, I had no reason to care.  I might as well have installed Quake and added a comment for you to replace it with the right package.  :)09:55
henningejtv: so why is it that you install it manually from the script and not just add a dependency to the package?09:56
jtvhenninge: to what package?  I didn't want to pull in another package for all slaves when we only need it for this one job.09:57
jtvAlso, IIRC this gets installed into the chroot whereas the buildd package lives outside it.09:57
henningejtv: oh, we have a chroot inside the buildd?09:58
henningeto build09:58
jtvhenninge: yes, the slave sets up a chroot, and then sets up its build environment in there.  That's what I did in translationtemplates.py09:59
henningejtv: frankly, translationtemplates.py looks a bit over-engineered ... ;) Mind if I change it or is this some common pattern?10:02
henningejtv: using a state machine this way, I mean.10:03
jtvhenninge: that's how the base class wants it.  The job runs asynchronously in twisted, so it doesn't hold everything up.10:03
jtvIt is _possible_ to do the whole thing in one go, but not much easier.10:04
jtvAnd this way helps provide progress information, I believe.10:04
wgrantYou need to either use the state machine or have a single subprocess that does all of the work.10:05
wgrantbigjools: Given the earlier discussion, I guess you don't have time to discuss PPA download stats today?10:24
bigjoolswgrant: next week would be better - I really need to get the rebuild work done10:24
bigjoolsor maybe on Friday if I am done by then10:24
wgrantYep, OK.10:25
wgrantI found some odd behaviour when testing them locally -- the binaries ended up in NEW. But it looks like it's OK on production.10:25
wgrantHm, rebuild archives have the same permission rules as PPAs when they're disabled. Damn.10:28
wgrantbigjools: Is there a good reason for that, or can I submit a branch to fix it?10:33
bigjoolswgrant: which rule is a problem?10:35
wgrantbigjools: Disabled copy archives are not accessible except by their owners and admins.10:37
wgrantThis is awkward, since they normally get disabled when they're done.10:37
bigjoolsthere's a bug about not being able to see them when they get disabled10:38
wgrantBug #48846810:41
mupBug #488468: Disabled rebuild archives are not shown anywhere <Soyuz:Triaged by jelmer> <https://launchpad.net/bugs/488468>10:41
bigjoolsthere ya go10:42
deryckMorning, all.11:04
=== jtv is now known as jtv-afk
deryckBjornT, ping.11:26
deryckadeuring, hi.  I think noodles775 suggestion about using real text and hiding it off screen is nice, assuming this does indeed play well with screen readers.11:38
deryckI say "assuming" not to question noodles775, just that I don't know much about screen readers.11:39
adeuringderyck: yes and no. I think it is a bit like expoiting a bug in screen readers ;)11:39
adeuringthey should not present non-visible text, I'd argue11:40
deryckadeuring, hmmm, that would make me concerned then.  img alt tags are the standard way to handle this.11:40
adeuringderyck: that's my main point indeed.11:40
deryckadeuring, let me look closer at the comments in the MP again.11:41
deryckadeuring, did you see the link noodles775 provided?  The webaim site notes pushing content off screen as an acceptable way to hide content.  I would assume they know screen readers well.11:45
adeuringderyck: no, I had not looked yet.11:45
deryckadeuring, it makes me confident in this approach, and using a sprite and a fmt'er would make this nicer to use in tal and for front-end performance.11:47
adeuringderyck: well, ok. I am not 100% convinced, but it does not matter that much.11:48
=== jtv-afk is now known as jtv
deryckadeuring, ok, thanks.  sorry to send you back to work again.11:48
adiroibanhenninge: hi. when you have time, can you please take a look at the last comment from https://code.edge.launchpad.net/~adiroiban/launchpad/bug-509252-take-2/+merge/1948411:51
BjornTderyck: pong12:07
jtvOh wow, a "here's your compensation from the Nigerian government for being scammed" Nigerian scam.12:43
=== jtv is now known as jtv-eat
gmbintellectronica: If you want to chat about a logarithmic scale for bug heat, I'll be free in 5.13:12
intellectronicagmb: excellent. i'm just firing an MP for my first branch and will ping you in ~5m13:12
gmbCool.13:12
beaverwww.search2.net13:14
intellectronicanow that must be the mossad ^^^^^13:16
intellectronicagmb: ready when you are13:23
gmbintellectronica: Cool. Skype?13:24
intellectronicagmb: yup13:24
deryckintellectronica, just FYI, I'm changing my max_heat branch to have max_bug_heat where the default is NULL not 0.13:26
deryckintellectronica, but you could review as is, and I can fix it up in my branch when merging in.13:26
=== al-maisan_ is now known as al-maisan
kfogelintellectronica: hey, you're totally right about that targetName thing -- I feel dumb.  Will fix, thanks.14:44
intellectronicacool14:44
intellectronicaand it was easy to confuse that one14:44
intellectronicamaybe it's even worth a comment, so that the next reader won't get confused. i nearly missed it myself14:45
intellectronicakfogel: ^^^14:45
kfogelintellectronica: well, I think the code will make it clear, since the used-visible display name is going to be generated instead of hardcoded.14:46
kfogelintellectronica: maybe an explanation of why, though, yeah.14:47
intellectronicaderyck: i didn't really update on my bug heat work. the branch for using max_heat is in review. i am now looking at scaling the results. went over it with gmb and we've reached the conclusion that just using a logarithmic scale is not obviously a good solution, so now i'm trying out a few formulas to see what makes sense. i'll try not to get stuck on that for too long and come up with something by the end of the day. it will be much easier 14:48
deryckintellectronica, sounds good.  thanks for the info.14:48
deryckintellectronica, sorry to leave you out, too.  Still trying to find a good rhythm with the board.14:49
intellectronicathat's oright. it's also not like the call is our one and only opportunity to update14:50
deryckright14:50
intellectronicai wonder if we can get a feed or something of the updates on the kanban and spew it here14:50
deryckintellectronica, there is RSS for the board.14:51
intellectronicait's nice how the kanban shows a notification when someone changes something, but you can't really follow it14:51
deryckyeah14:53
deryckwe need some kind of commit email or something.14:53
deryckthis would also make sharing in the open better.14:53
deryckflacoste, is there something like the above for the board? ^^  Or some way to come up with that.14:54
flacostederyck: there is14:55
flacosteeach line has an email icon14:55
flacosteto subscribe to events there14:55
flacostethere is also a RSS feed for the whole board14:55
flacosteand there is an email notification option for the whole board also14:55
flacostelook under the Options tab14:55
deryckah, ok.  thanks flacoste14:56
deryckintellectronica, see that ^^.  You can subscribe your email to board events.14:56
intellectronicaderyck: thanks. i'll give that a try.14:57
deryckI find the per lane rss or email useless, really.  But the global option is nice.14:58
intellectronicaah, and i found out why i didn't see avatars. there's a global option to show or hide them14:58
flacostederyck, intellectronica: the option to turn off the white board markers is also nice to get more screen real-estate14:59
deryckah, right.  sorry.  I didn't realize that was per user.14:59
intellectronicaflacoste: indeed14:59
deryckyes, nice.15:00
deryckflacoste, I wonder if we couldn't have a generic user account and subscribe some email to all boards and have this go to a mailing list.  Or something like this.15:01
=== danilo__ is now known as danilos
deryckflacoste, would make it less private.15:01
flacostederyck: they should implement a "public board" option soon15:01
deryckflacoste, ah, ok.  cool.15:01
kfogelintellectronica: new version of the branch pushed up.  It was actually not as trivial to fix as I thought -- the uppercase/lowercase needs are different between the sort order display and the column name on the right, which wasn't an issue before.15:20
kfogelintellectronica: anyway, review when ready15:21
intellectronicakfogel: looks good. r=me15:23
kfogelintellectronica: thx15:23
kfogelintellectronica: you think any need for UI review on this one?15:25
* kfogel answers his own question15:25
kfogelno.  the ui change is trivial and unambiguously an improvement :-)15:25
intellectronicakfogel: never hurts, but since this was such a small change i don't think it's strictly necessary15:25
intellectronicakfogel: normally i wouldn't even ask for a first ui review for something like this, tbh15:26
kfogelintellectronica: what, you mean for the whole feature?15:26
intellectronicai only added the keyword because we did discuss it a bit in the review15:26
kfogelintellectronica: keyword?15:26
* kfogel confused15:26
kfogelintellectronica: where?15:27
intellectronicakfogel: for the whole feature definitely, but for something like the capitalization of the option in a combo ... depending on how confident i'd feel about the change15:27
intellectronicakfogel: keyword in the review signature. i used 'code ui'.15:27
intellectronicamaybe it's called review type15:27
kfogelintellectronica: oh, didn't refresh, didn't see that yet15:28
kfogelintellectronica: so if I use 'ec2 land', it'll automatically use the commit message from the merge proposal, right?  That is, I can just run 'utilities/ec2 land -v --headless -b launchpad=db-devel' ?15:29
intellectronicakfogel: if so then that's a complete surprise to me. i never used it like that.15:29
kfogelhmmm.15:29
intellectronicalet me know if it works for you :)15:29
kfogelintellectronica: well, I don't want to risk a change landing with a bogus message.  I'll ask around.15:30
kfogelderyck: do you regularly use 'ec2 land'?15:33
deryckkfogel, I do15:33
kfogelderyck: so the 'ec2 help land' text is a bit thin.  I'm trying to figure out if, when a merge proposal has a commit text set (as https://code.edge.launchpad.net/~kfogel/launchpad/515584-fix-DRY-violation/+merge/19990 does) whether 'ec2 land' will automatically use that as the PQM submit message.15:33
deryckkfogel, it will.  do `ec2 land --dry-run` and you can see what it will do.15:34
kfogelderyck: and if so, whether it auto-generates the reviewer metadata "[r=foo][etc]" or whether it figures all that out from the merge proposal.15:34
deryckkfogel, it does15:34
kfogelderyck: thx15:34
deryckkfogel, np15:34
=== jtv-eat is now known as jtv
cbx33hey peeps15:46
=== salgado is now known as salgado-lunch
=== matsubara is now known as matsubara-lunch
=== Guest5903 is now known as NCommander
bdmurraycould somebody review my branch for bug 527174?16:56
mupBug #527174: logo_link missing from "team" object in API <Launchpad Registry:In Progress by brian-murray> <https://launchpad.net/bugs/527174>16:56
thumperrockstar: I have a branch now that refreshes the status table on the mp page when the status is updated16:57
thumperrockstar: it is awesome16:57
rockstarthumper, we're refreshing the whole table?16:58
thumperrockstar: I'll make a movie :)16:58
rockstarbdmurray, #launchpad-reviews is what you want.16:58
=== matsubara-lunch is now known as matsubara
kfogelintellectronica: in my launchpad.dev instance, default batch size for +patches view seems to be 5 bugs per page instead of (say) 50.  Is this a dev thing we do?  I don't remember setting that param anywhere, and it's not in my URL.17:27
intellectronicakfogel: yes, that's a dev env setting17:38
kfogelintellectronica: thanks17:38
jtvWasn't there an easy way to add a person to a team?18:19
=== gary_poster is now known as gary-lunch
salgadojtv, the team's home page should allow you to do that.  there's an ajaxy link there19:05
jtvsalgado: I should've said: in code.19:08
salgadooh, code19:08
salgadojtv, team.addMember(person), then?19:08
jtvsalgado: ah, thanks!  Yes, that's what I was looking for.  I missed it somehow (did grep for addPerson of course)19:09
=== mpt_ is now known as mpt
=== gary-lunch is now known as gary_poster
maxbOOI, are there any estimations on when the datacentre Lucid upgrades are planned?20:25
sinzuijtv: you are still awake?21:02
thumpermaxb: IIRC some get upgraded at beta time21:03
thumpermaxb: others shortly after release i think21:03
maxbTo put it another way: When is edge or staging likely to running on lucid? :-)21:04
maxb* to be21:04
mwhudsoni would guess staging would be pretty soon after release21:06
mwhudsontotally a guess though21:06
=== salgado is now known as salgado-afk
sinzuibac: EdwinGrubbs: I just sent a request for sql/ddl help to launchpad-dev. Can both of you read it and provide your thoughts.21:22
bacok21:23
* sinzui is now thinking about how to move the packaging portlet to staging-only and update the bug heat script to add info to sourcepackagename21:24
lifelessmwhudson: was the bzr-git patch sufficient?21:26
mwhudsonlifeless: i haven'21:27
mwhudsont tested it actually21:27
mwhudsoni guess it would be easy enough21:27
thumpermwhudson: you have much QA to mark off :)21:29
mwhudsonthumper: see earlier griping about staging21:29
thumpermwhudson: yeah, but there are some we can check off right?21:30
mwhudsonthumper: no?21:30
mwhudsonthumper: all the 'landed' things are code import related21:30
=== matsubara is now known as matsubara-afk
lifelessmwhudson: it would be good to get it tested and done21:38
lifelessmwhudson: one less thing in progress ;)21:38
EdwinGrubbssinzui: can you do an EXPLAIN ANALYZE on that query? EXPLAIN can often be misleading with its cost numbers.21:55
sinzuiEdwinGrubbs: just explain as I showed21:55
EdwinGrubbssinzui: I'm asking whether you can rerun it with EXPLAIN ANALYZE?21:56
sinzuisent21:57
sinzuiEdwinGrubbs: The numbers look roughly the same.21:57
EdwinGrubbssinzui: the costs will look the same, but I would like to see the times, which are easier to understand. How many times is this query run on the page? just once?21:58
sinzuiEdwinGrubbs: We pay a terrible cost scanning all bugs and the join to bugtask is also expensive21:59
sinzuicheck your email21:59
* sinzui is trying to understand how bugs are queued in the new bugjob system.21:59
sinzuiEdwinGrubbs: the query is run once for every page that uses it.22:06
EdwinGrubbssinzui: I don't think it will be possible to get much better results if 3/5 of the bugs have a sourcepackage. Caching the heat in sourcepackage is definitely the best bet if it is ok for the data to be a little stale. If it needs to be absolutely up to date, caching it on the BugTask table would be safer to implement via a trigger, and eliminating the join should speed it up greatly.22:14
EdwinGrubbssinzui: as a shot in the dark, you could try "set enable_seqscan = false;" before you run explain analyze to see if it cuts down the times. It probably won't help since so many of the bugs in the table are being read.22:15
sinzuiEdwinGrubbs: agreed. bug heat is updated using the bugjob system. The mechanism for jobs is quite elaborate. I was hoping to append a rule for sourcepackagename to something.22:16
EdwinGrubbsmakes sense22:16
sinzuiI bug heat and po messages scoring is fuzzy, I think it is fine to cache it. I think I need to consider disabling the problem calls in the views; the work to build a cronscript correctly may be mroe than 8 hours. I need a schema change approval too22:18
thumperrockstar: ping22:25
rockstarthumper, pong22:26
thumperrockstar: skype?22:26
rockstarthumper, sure.22:26
thumperrockstar: https://code.edge.launchpad.net/~thumper/launchpad/use-last-rev-id/+merge/2002322:27
sinzuiis salgado an admin in sample data?22:31
mwhudsonsinzui: i think so, not sure though22:32
sinzuiWe cannot expire our oauth tokens. I see a typo in the security checker, yet the test passes, implying it works because salgado has god-like qualities.22:33
mwhudsonyep, he's an admin22:34
mwhudsoni remember griping at this because the webservice tests are/were done with salgado by default22:34
mwhudsonor something like that22:34
sinzuiyes, the same is true for oauth22:34
=== jelmer__ is now known as jelmer
=== jelmer is now known as Guest75587
thumperrockstar: http://people.canonical.com/~tim/magic.ogv22:42
=== Guest75587 is now known as ctrlsoft
jtvsinzui: I'm here23:04
sinzuijtv: I was looking for help improving a query. I sent a request to launchpad-dev for help. EdwinGrubbs concluded that changing the schema was the only viable option to improve the query performance.23:05
jtvsinzui: the fix for the translations was simple; cp'ed yesterday23:06
jtvsinzui: where is this query you posted used?23:07
sinzuijtv: [Launchpad-dev] SQL/DDL help wanted to fix a distrosseries timeouts23:08
jtvsinzui: yes, I just read it.  But where is the query that you posted used in the code?23:08
sinzuiregistry.model.distroseries._current_sourcepackage_joins_and_conditions() it is used in the packaging portlet on the distroseries, and in the +needs-packaging report23:10
sinzui^ jtv https://edge.launchpad.net/ubuntu/lucid/+needs-packaging23:10
thumperQuick straw poll: Rename +junk to +personal?23:10
* thumper leaves to collect Maia23:10
lifeless'meh'23:10
lifelessmore clear23:11
lifelessless sexy23:11
wgrantthumper: Hasn't this been discussed to death lots of times?23:11
sinzuithumper: +123:11
wgrantAlso, +personal doesn't really work for teams.23:11
lifeless+misc23:11
lifelessactually, delete +junk23:11
jtvsinzui: but that view is batched.23:11
lifelesscreate a junkcode project; move everything to it.23:12
sinzuiyes, but the query behind it is a monster23:12
thumperwgrant: yes, but I'm willing to move now23:12
jtvsinzui: then leave the counting to the browser code.23:12
thumper+personal doesn't work so well for team branches does it?23:12
jtvsinzui: You're probably doing the counting for _all_ sourcepackages even though you're only showing 20.23:13
sinzuijtv: This is an actual query used by the portlet...it only wants the top 10, but learning the top ten by bug heat and po messages is terrible: http://pastebin.ubuntu.com/383302/23:14
* jtv whistles23:14
sinzuijtv: that came from https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1516S9823:14
sinzuithumper, I close 3 projects a week because the user does not know +junk. The word they use to describe it is "personal" and "sandbox"23:16
jtvsinzui: that is a monster.23:16
sinzuijtv: yes, it took me four days to create a query that had viable results. It was a sad week for me23:17
lifelesssinzui: so we should create a sandbox project perhaps?23:18
sinzuijtv: I think I want to change sourcpackagename to store reporing data that Is updated daily.23:18
jtvsinzui: I see that total_bugs and total_messages can be left out... does that help any?23:18
jtvWe have a cache like that for POFiles.  It's necessary, but keeping it up to date is sheer hell.23:19
sinzuilifeless: I have approved a few when the user decided to focus the code on a single problem. I think project registration to explain to the user what a project is in launchpad and point him to +junk when he wants a sandbix23:20
mwhudsonsinzui: sourcepackagename doesn't have any connection to a distro23:20
sinzuijtv, no, but yes they can be left out now23:20
mwhudsonsinzui: are you proposing just caching the values for ubuntu on there?23:21
lifelesssinzui: I'm saying lets delete +junk /from launchpad/ and replace it with an actual project, called - 'sandbox' or 'personal' (or even a few such things)23:21
lifelesssinzui: owned by registry; bugs turned off; no trunk series, or an empty one.23:21
lifelesssinzui: we can simplify our code and make it more discoverable at the same time.23:22
sinzuimwhudson: sourcepackagename is nothing but a key in our schema, but we do not think about it that way. We think about source packages having bugs and being in a distro, but launchpad does not think that way23:22
wgrantExcellent.23:22
wgrantEr.23:22
wgrantGah, thought the other Lucid failure had fixed itself :(23:22
wgrantBut no.23:22
mwhudsonsinzui: what you say is undoubtedly true, but i don't see the connection with what i said23:23
sinzuimwhudson: I am proposing that sourcepackagename have new columns that can be used to store the total bug heat or total messages so that these do not need to be recalculated.23:24
mwhudsonsinzui: are you proposing actually having a "source package" concept in the databgase?23:24
jtvsinzui: I take it the part you posted took the bulk of the time though?23:24
lifelessjtv: look at the oops itself. (and yes)23:24
mwhudsonsinzui: but nowhere do we show the bugs targeted to a sourcepackagename23:24
lifelessnext highest question was 576ms23:24
lifelesssorry, 59223:24
mwhudsonsinzui: we show those targeted to a sourcepackage23:24
sinzuilifeless: I think your general proposal is right, but creating exceptions is costly. I think we want this repo space more visible, and have a mechanism to promote a branch to be the basis of a new project23:25
mwhudsonsinzui: so i guess i'm saying i don't really understand your proposal23:26
sinzuimwhudson: no, just extending the sourcepackagename.23:26
sinzuijtv: yes, the bugheat for a sourcepackagename is the main problem by a vast magnitude23:26
sinzuimwhudson: I am using sourcepackagename as a key to join many objects (because there is not really a source package object). I think it would be easier for many queries if the sourcepackagename had additional data with it that would allow me to make simpler queries23:28
jtvsinzui: I don't suppose you could ignore (or treat separately) packages without any bugtasks?23:29
jtvAt least you'd have an inner join instead of an outer one23:30
sinzuijtv: bug heat is the best indicator that a package needs linking to an upstream project, but we do not have that data in a convenient place.23:31
jtvsinzui: why is Bug in that join?23:31
jtvIs there no way to get it out?23:32
jtvIt's used for counting heat and ids.  For ids you don't actually need it.23:32
jtv(Because you can count the bugs' primary keys as the bugtasks' foreign keys)23:32
sinzuijtv: bugs have heat, not tasks, which are linked to a sourcepackagename, that is in a publishing table that says the package is in a series23:32
jtvsinzui: ok, so can you limit the Bug join to ones that have heat?23:34
sinzuijtv: removing count is inconsequential: http://pastebin.ubuntu.com/383310/23:34
mwhudsonsinzui: so what data would you attach?23:34
sinzuiall bugs have heat, Would limiting it to heat > 0 woek23:35
sinzuimwhudson: sum of bugheat and po messages23:35
jtvLooks like most bugs have heat.  :(23:35
mwhudsonsinzui: across all distros?23:36
sinzuiall? yes, because only Ubuntu is really present23:36
mwhudsonok23:36
mwhudsonthat's all i wanted to check23:36
jtvsinzui: if you dropped bugs with heat <= 10 from the heat count, you would make a serious dent in the number of Bugs the query has to churn through.23:37
sinzuimwhudson: we claim to support all distro, but we only support Ubuntu. If we change distro(series).getSourcePackage() to only return what we know exists, several hundred bugtasks disapear, and 60 packaging links tpp23:38
wgrantabentley: You pinged me yesterday?23:38
* sinzui tries23:38
* sinzui hugs jtv23:39
jtvsinzui: or maybe it's not me; in your post with the subquery, "explain analyze" only reported a cost of about 2 seconds.  The larger query as shown in the pastebin and the timeout takes 12.5 seconds.23:40
jtvSo are we barking up the wrong tree because there are too many digits in the millisecond counts?23:41
sinzuijtv: This is the largest junk from the whole query: http://pastebin.ubuntu.com/383314/23:42
jtvwhoa, thanks for splashing _that_ across my eyes in the wee hours of the night!23:42
sinzuijtv: I did try to show only what was needed23:42
sinzuijtv heat > 200 is great. I can lower it a bit23:43
wgrantjtv: Hm, you probably don't want to use makeGPGKey. The user needs to hold the matching private to make an upload...23:43
jtvsinzui: I'm just messing with you.  But AFAICS the part you posted accounted for 2 seconds out of 13.23:43
jtvwgrant: drat.  Any alternatives you know of?23:43
sinzuijtv: This listing is a heuristic. We just want the most problematic packages being seen by users23:44
jtvsinzui: don't forget to count(BugTask.bug) instead of count(Bug.id) though23:44
wgrantjtv: Not really.23:45
jtvwgrant: so makeGPGKey doesn't even create a proper key pair and hide the private side somewhere?23:45
sinzuijtv: did you ping-bomb me? I saw your name then pidgen went belly-up23:45
jtvsinzui: I didn't ping you at all23:46
sinzuijtv: yes, makeGPGKey() is bogus.23:46
EdwinGrubbsbac: I have a question regarding the formatting of the upstream assoc portlet.23:46
wgrantjtv: No.23:46
sinzuijtv: I had to hack it last release to get a test to work23:46
wgrantMaybe sinzui knows what to do.23:46
jtvwgrant: would it be possible to let the user provide an email address that they have a proper key for?23:46
jtvJust fork gpg to do the interesting work?23:47
sinzuiwgrant: repeat the question, I lost my scrollback when irc restarted23:47
jtv(Or invoke some gpg library, but to the same effect)23:47
=== EdwinGrubbs is now known as Edwin-brb
jtvsinzui: a script needs to create a user with a proper GPG key23:47
wgrantjtv: There is code already in LP to take a fingerprint and look it up. That's how we add gpg keys.23:47
wgrantjtv: So you can find that code, and take a fingerprint on the command line.23:47
wgrantThe only caveat is that zeca needs to be running before that will work.23:48
jtvdrat23:48
jtvwhat _is_ zeca, anyway?23:48
jtvthe keyserver?23:48
wgrantSee PersonGPGView.claim_gpg for the code you need to replicate.23:48
sinzuipr_BR for test?23:48
jtvwgrant: thanks23:48
wgrantIt's a mostly braindead test keyserve.r23:48
jtvsinzui: meanwhile, did you say there was progress?23:50
wgrantI would have liked to have had all this functionality in the script at the start, but I'd had the LP code for less than 24 hours and didn't really know my way around yet.23:50
wgrantThanks for adding it.23:50
sinzuijtv: yes, filtering the lower bug.heat  will make the query fast enough for now.23:50
jtvwgrant: pretty impressive.23:51
jtvOne day.23:51
jtvsinzui: \o/23:51
sinzuiwgrant: jtv: I do not understand the gpg question, I only know that the kerys we make in testing are not unique. I had a test failure and I make a quick hack to the factory to make them unique enough for me to test23:52
wgrantsinzui: jtv is extending one of my scripts to add a user's real GPG key.23:53
sinzuiah23:53
jtvor at least, _a_ real GPG key that the LP user can use.23:53
wgrantTrue.23:54
jtvsinzui: oh, I said count(BugTask.bug) but I guess that should be count(DISTINCT BugTask.bug)23:58
* sinzui tries that too23:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!