=== daniloff is now known as danilos
[10:28]  * henninge keeps forgetting about Mondays ... ;)
=== henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== henninge changed the topic of #launchpad-reviews to: on call: henninge || reviewing: lunch || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara-afk is now known as matsubara
=== intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[12:39] <leonardr> intellectronica, can you review https://code.edge.launchpad.net/~leonardr/lazr.restful/mutators-are-not-named-operations ?
[12:42] <intellectronica> leonardr: sure
=== intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, leonardr || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: lunch, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: -, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:06] <henninge> oops
[14:18] <bigjools> hi henninge, I have a review if you don't mind - it's 28 lines and r-c
[14:18] <henninge> bigjools: sure
[14:18] <bigjools> thank you sir
=== henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: bigjools, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:21] <bigjools> https://code.edge.launchpad.net/~julian-edwards/launchpad/archive-url-bug-520520/+merge/20369
[14:21] <bigjools> henninge: sorry should have pasted that earlier
[14:38] <henninge> bigjools: r=me
=== henninge changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: -, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-lunch
[14:49] <bigjools> thanks henninge
=== salgado is now known as salgado-lunch
[15:49] <EdwinGrubbs> intellectronica: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-525956-unlink-button/+merge/20334
[15:49] <intellectronica> EdwinGrubbs: ok
=== intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica || reviewing: -, Edwin || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[15:50] <EdwinGrubbs> intellectronica: it should also have a UI review, so you might want to do that first.
[15:50] <intellectronica> EdwinGrubbs: oright
=== abentley changed the topic of #launchpad-reviews to: on call: henninge, intellectronica, abentley || reviewing: -, Edwin, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:10] <intellectronica> EdwinGrubbs: ui*=me
=== deryck is now known as deryck[lunch]
=== intellectronica changed the topic of #launchpad-reviews to: on call: henninge, intellectronica, abentley || reviewing: -, -, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:22] <james_w> hello reviewers, I have a slightly odd request
[16:22] <james_w> https://code.edge.launchpad.net/~james-w/launchpad/fix-getRequestedReviews/+merge/20378
[16:22] <james_w> I'd appreciate if someone could check that the test fails without the code change and passes with it
[16:22] <james_w> I don't have a working LP dev environment at the moment, but want this bug fixed
=== matsubara-lunch is now known as matsubara
=== kfogel is now known as kfogel-loonch
=== james_w changed the topic of #launchpad-reviews to: on call: henninge, intellectronica, abentley || reviewing: -, -, - || queue [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[16:43] <bac> hi intellectronica, abentley: can i have a review for https://code.edge.launchpad.net/~bac/launchpad/bug-512408/+merge/20379 ?  it is targeted to 10.03, so not a RC candidate
=== deryck[lunch] is now known as deryck
[16:45] <intellectronica> henninge, abentley: would you mind taking this one? i'm working on an r-c candidate
[16:47] <abentley> bac, intellectronica, I'll take it.  (henninge seems to be missing)
[16:47] <intellectronica> thanks
[16:47] <bac> thx, abentley
=== salgado-lunch is now known as salgado
=== kfogel-loonch is now known as kfogel
[17:08] <abentley> bac, r=me.  Hate that &-encoding is done by cgi.escape.  Would expect that to be % encoding.
[17:09] <bac> abentley: can you elaborate?
[17:10] <abentley> bac, the python standard library is silly, because cgi.escape has nothing to do with CGI and everything to do with HTML.
[17:11] <bac> abentley: ah, ok, i see your point.
[17:11] <bac> abentley: i guess i've been numbed to that point by years of use
[17:13] <abentley> bac, it's been a while for me, so I was fooled.  Actually, there's an equivalent in xml.sax.saxutils, which is a marginally better place for it.
=== abentley changed the topic of #launchpad-reviews to:  on call: henninge, intellectronica, abentley || reviewing: -, james_w, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== abentley changed the topic of #launchpad-reviews to:  on call: henninge, intellectronica, abentley || reviewing: -, -, james_w || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:20] <bac> sinzui: do you have time for a UI review of my branch? https://code.edge.launchpad.net/~bac/launchpad/bug-512408/+merge/20379
[17:20] <sinzui> I do
[17:20] <bac> sinzui: do you need screenshots or do you want to run it yourself?
[17:21] <sinzui> I will run it
[17:22] <bac> sinzui: gah, i already notice i didn't title the choice list properly.
[17:23] <bac> sinzui:  s/Registered upstream project/Ubuntu packages/
[17:23] <sinzui> okay
=== gary_poster is now known as gary-lunch
[17:49] <EdwinGrubbs> abentley: can I get a secondary UI review from you?
[17:49] <abentley> EdwinGrubbs, I don't do UI reviews.
[17:50] <EdwinGrubbs> noodles775: can you do a secondary UI review for me?
[17:54] <EdwinGrubbs> rockstar, mars, sinzui: can you do a secondary UI review for me?
[17:54] <rockstar> EdwinGrubbs, is it urgent?
[17:54] <EdwinGrubbs> rockstar: not at all
[17:55] <rockstar> EdwinGrubbs, I can do it after lunch (~2 hours)
[17:55] <EdwinGrubbs> rockstar: thanks, https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-525956-unlink-button/+merge/20334
[17:56] <sinzui> EdwinGrubbs: I may get to it. I am looking at bac's branch now
[18:06] <abentley> james_w, sorry, I can't get the branch to run, myself.  See [Launchpad-dev] make silently fails building bin/py
=== abentley changed the topic of #launchpad-reviews to:  on call: henninge, intellectronica, abentley || reviewing: -, -, - || queue [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== intellectronica changed the topic of #launchpad-reviews to:  on call: henninge, abentley || reviewing: -, - || queue [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[18:12] <sinzui> bac: ping
[18:12] <bac> hi
[18:12] <sinzui> I think I have done the impossible while testing your branch
[18:13] <sinzui> I did the pmount scenario first. I delete the link to sp pmount...
[18:14] <bac> and it blew up?
[18:15] <sinzui> bac: then I linked applets to lucid pmount, then returned to pmount. I was promoted to link to pmount, so I did. It worked. I seem to have  two projects providing lucid pmount.
[18:16] <sinzui> bac: If I merge your work into db-devel, I am sure I would get a db constraint violation
=== danilos is now known as daniloff
[18:17] <bac> sinzui: yes, i guess you would
[18:18] <bac> sinzui: let me do the merge and see what happens
[18:19] <sinzui> bac:I think the list of candidates should no contain anything that already has a packaging link for the the ubuntu focus series
[18:20] <bac> sinzui: you're right.
[18:21]  * sinzui was expecting a NotOne error. maybe that was in db-devel too
[18:22] <sinzui> bac: okay, I do get a
[18:22] <sinzui>     NotOneError: one() used with more than one result available
[18:22] <sinzui> when I visit lucid pmunt
[18:22] <sinzui> pmount
[18:26] <sinzui> bac: I think your solution address the most common desire the link to an sp from a project page. We do not handle the case for multiple series. We could offer a multi-step as EdwinGrubbs created for sp-project-series, but maybe we can just offer a links to alternate series from +ubuntupkg and declare victory.
[18:27] <sinzui> s/address/addresses/
[18:27] <bac> yes, i got a NotOne error when i visit https://launchpad.dev/ubuntu/hoary/+source/pmount after following your scenario
=== EdwinGrubbs is now known as Edwin-lunch
=== matsubara is now known as matsubara-afk
=== gary-lunch is now known as gary_poster
[19:23] <sinzui> Edwin-lunch: ping me when you are available. I have a question in my review. I think we can answer it together quickly
=== Edwin-lunch is now known as EdwinGrubbs
[19:24] <EdwinGrubbs> sinzui: I'm here
[19:24] <sinzui> https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-525956-unlink-button/+merge/20334
[19:24] <sinzui> ^ your thoughts on using your new view on the dsp page?
[19:31] <EdwinGrubbs> sinzui: so you want me to point the DSP page's delete button at the unlink template? That will be easy enough, and I can just hold onto the referring url to use for next_url. The DSP puts the remove button to the left of the edit button, but I prefer it on the right like I did for the SP page.
[19:31] <EdwinGrubbs> sinzui: I'll add a variable to hide the edit/remove links on the +packaging page.
[19:38] <sinzui> EdwinGrubbs: I agree with the position. If the DSP really is easy then do it. Thanks for hiding the actions on the listing.
=== matsubara-afk is now known as matsubara
[21:21] <sinzui> bac: EdwinGrubbs: can either of you review this now: https://code.edge.launchpad.net/~sinzui/launchpad/product-release-file-api/+merge/20398
=== salgado is now known as salgado-afk
[21:21] <bac> sinzui: i will
[21:24] <bac> sinzui: when was this bug introduced?
[21:25] <sinzui> I think it was July of last year when we added download counters
[21:25] <bac> gah
[21:25] <bac> sinzui: i have done a review with 'approved' but left it in 'needs review' so you can get an RC
[21:26] <sinzui> bac: June actually
[21:26] <sinzui> fab
[21:27] <sinzui> thumper: I would like your RC for https://code.edge.launchpad.net/~sinzui/launchpad/product-release-file-api/+merge/20398 . The issue actually dates from June of 2009
[21:27] <thumper> june?
[21:28] <sinzui> The defect was introduced when download counters were added. The code for showing a file was refactored into a link formatter
[21:34] <thumper> sinzui: done
[21:34] <sinzui> fab
[21:57] <sinzui> bac: there was some non-sense with my review of your mp. My code and UI reviews are both approve
[21:57] <bac> non sense?
[21:58] <bac> ah, yes.  i think ec2 might puke on that review type
[21:58] <bac> we'll see later in the week
[22:07] <leonardr> gary: at least ready for a review of https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-wadl/+merge/20405
[22:07] <leonardr> there were some minor changes after you looked at it
[22:07] <leonardr> i'm starting the ec2 test now
[22:07] <gary_poster> leonardr: looking
[22:07] <gary_poster> diff not there yet :-)
[22:12] <leonardr> gary, it's there now
[22:12] <gary_poster> yes looking thanks
=== abentley changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[22:17] <gary_poster> leonardr: approved.  We should link the branch to the bug and then ask thumper to give a release-critical review so you can land it tomorrow morning on db-stable.
[22:17] <leonardr> gary, do you have the bug handy?
[22:18] <gary_poster> leonardr: no, sorry, I thought you had one, and that it was on the janban board.  Perhaps there is not one?
[22:18] <gary_poster> kanban
[22:19] <leonardr> i put it on the kanban but i don't know of any bug--just emails
[22:19] <gary_poster> leonardr: ok fair enough, nm
[22:20] <gary_poster> leonardr: I'll make a bug. :-/
[22:20] <leonardr> all right
[22:21] <leonardr> thumper, can you give https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-wadl/+merge/20405 a release-critical review?
[22:21] <thumper> aye
[22:22] <thumper> done
[22:25] <gary_poster> leonardr: made bug and linked branch already: https://bugs.edge.launchpad.net/launchpad-foundations/+bug/530354
[22:25] <mup> Bug #530354: wadl generation is broken after multiversion code has landed <Launchpad Foundations:In Progress by leonardr> <https://launchpad.net/bugs/530354>
[22:25] <gary_poster> thank you thumper
[22:25] <leonardr> gary, great
[22:25] <leonardr> yes, thanks thumper
[22:25] <leonardr> gary: i'll come back in a few hours to see if the ec2 test passed
[22:26] <gary_poster> leonardr: thanks
=== matsubara is now known as matsubara-afk
=== jamalta is now known as jamalta-afk
[23:42] <james_w> https://code.edge.launchpad.net/~james-w/launchpad/fix-getRequestedReviews/+merge/20378 should now be good to go if anyone is willing to take it
[23:43] <james_w> on call: - || reviewing: - || queue [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== james_w changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [james_w] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[23:51] <james_w> actually, the test isn't quite testing the right thing yet