| james_w | right, it's confirmed working now. Please to be reviewing https://code.edge.launchpad.net/~james-w/launchpad/fix-getRequestedReviews/+merge/20378 | 01:04 |
|---|---|---|
| james_w | also, https://code.edge.launchpad.net/~james-w/launchpad/sync-source-negative-versions/+merge/16861 has been approved for 8 weeks and hasn't landed yet. I think it's been hit by ec2 swallowing mails a couple of times. It would be great if someone could submit again. | 01:05 |
| james_w | thanks | 01:05 |
| leonardr | thumper: i need another release-critical review of https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-wadl/+merge/20405 as there were some ec2 test failures | 03:39 |
| * thumper looks | 03:39 | |
| thumper | leonardr: done | 03:42 |
| thumper | leonardr: Approved revision: 10427 (in case you were wondering) | 03:42 |
| leonardr | cool | 03:43 |
| === al-maisan changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jpds | bigjools: Morning, lp:~jpds/launchpad/timestamp-archivepublisher-run should be good to land. | 09:27 |
| bigjools | jpds: it's landing right now :) | 09:27 |
| === jtv changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>, jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jpds | bigjools: Woo! :) | 09:41 |
| jtv | noodles775, you interested in reviewing my branch for the local soyuz setup scripts? https://code.launchpad.net/~jtv/launchpad/bug-527170/+merge/20440 | 10:34 |
| noodles775 | jtv: sure! | 10:34 |
| jtv | noodles775: great, thanks! | 10:34 |
| jtv | noodles775: I just realized I haven't gotten around to moving the instructional output all the way to the end since I added GPG key registration... mind if I do that now? | 10:42 |
| noodles775 | jtv: go for it, just let me know when it's ready and i'll merge. | 10:42 |
| jtv | noodles775: it's pushed, sorry for the delay | 10:53 |
| jtv | Just moved a "print" down a few lines | 10:53 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>, jtv] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | gmb: noodles775 is reviewing mine | 10:54 |
| gmb | jtv: Cool, thanks for letting me know. | 10:54 |
| noodles775 | Thanks jtv | 10:54 |
| === jtv changed the topic of #launchpad-reviews to: gmb || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | /topic: on call: gmb || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | 10:55 |
| jtv | gah | 10:55 |
| gmb | Heh. | 10:55 |
| === jtv changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | ahhhh | 10:55 |
| gmb | jtv: It's good to know that I'm not the only one that struggles with /topic. | 10:56 |
| jtv | it's not us, it's /topic | 10:56 |
| === adiroiban changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>,adiroiban(bug-512307)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === adiroiban changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>,adiroiban(bug-512307),adiroiban(bug-359180-take-2)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | james_w: Does your branch still need reviewing? I don't see an MP for it in the +activereviews queue | 11:08 |
| gmb | In the meantime... | 11:09 |
| james_w | gmb: it should still be there | 11:10 |
| james_w | https://code.edge.launchpad.net/~james-w/launchpad/fix-getRequestedReviews/+merge/20378 | 11:10 |
| james_w | and remember https://code.edge.launchpad.net/~james-w/launchpad/sync-source-negative-versions/+merge/16861 ? :-) | 11:10 |
| james_w | I think that's been hit by ec2 not sending mails a couple of times | 11:10 |
| gmb | Argh sodbollocks. | 11:10 |
| gmb | james_w: Right, I'll run that one again but stay connected to make sure we find out what's going on. | 11:11 |
| james_w | thanks | 11:11 |
| gmb | Man, LP's slow today... | 11:13 |
| adeuring | gmb: fancy to review a small rbanch (ca 10 lines interface changes; 100 lines tests): https://code.edge.launchpad.net/~adeuring/launchpad/api-export-bug-linked-branches/+merge/20444 ? | 11:18 |
| gmb | adeuring: Sure, let me just finish james_w's branch. Won't be a sec. | 11:19 |
| adeuring | gmb: thanks! | 11:19 |
| al-maisan | gmb: there's another branch in the queue as well :) | 11:20 |
| gmb | james_w: r=me | 11:20 |
| james_w | thanks gmb | 11:20 |
| james_w | would you submit that one too please? | 11:21 |
| gmb | al-maisan: I'm in the process of sorting out who's here and who's not and who's just left things lying in the queue. Good to know you're not one of the latter. I'll take a look at yours now. | 11:21 |
| gmb | james_w: Sure. | 11:21 |
| james_w | thanks | 11:21 |
| gmb | adeuring: Please put your branch in the queue; first come first served and all that... | 11:21 |
| al-maisan | gmb: thanks! | 11:21 |
| adeuring | gmb: sure | 11:21 |
| === adeuring changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue [james_w, al-maisan<http://tinyurl.com/y8gmlcd>,adiroiban(bug-512307),adiroiban(bug-359180-take-2), adeuring] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: al-maisan || queue [adiroiban(bug-512307),adiroiban(bug-359180-take-2), adeuring] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| gmb | al-maisan: Is this review for your spurious-tests branch? tinyurl isn't resolving for me atm... | 11:27 |
| al-maisan | gmb: yes | 11:27 |
| al-maisan | https://code.launchpad.net/~al-maisan/launchpad/spurious-tests-525329/+merge/20233 | 11:27 |
| gmb | Cool, thanks. | 11:28 |
| al-maisan | gmb: not sure whether this matters but lp:~al-maisan/launchpad/spurious-tests-525329 was branched off of devel and not db-devel | 11:29 |
| gmb | al-maisan: I think you're in luck. The diff's only 123 lines, so I guess the devel revisions in your branch have already been merged into db-devel. | 11:30 |
| al-maisan | hmm :) | 11:30 |
| gmb | al-maisan: r=me. | 11:33 |
| al-maisan | gmb: thanks! | 11:33 |
| gmb | np | 11:33 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue [,adiroiban(bug-359180-take-2), adeuring] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| noodles775 | jtv: what would be the problem with just adding amd64 as an arch always? the user still needs to target a specific series? | 11:35 |
| jtv | noodles775: dunno frankly; I figured the safe thing to do was to stay faithful to what we already had. | 11:36 |
| noodles775 | jtv: also, do you think it should be possible to run this twice? (ie. the first time I didn't set my email, so I need to make schema before re-running right?) | 11:36 |
| jtv | noodles775: right now you'll have to "make schema" between runs. | 11:36 |
| jtv | wgrant: is there any conceivable reason not to add amd64 support when setting up the sampledata for soyuz? | 11:37 |
| wgrant | jtv: No. | 11:37 |
| jtv | noodles775: there's your answer. No reason. Fixing. | 11:37 |
| noodles775 | jtv: great. | 11:37 |
| jtv | noodles775: testing the fix. | 11:39 |
| noodles775 | jtv: I wonder if in the future we should separate out utilities/soyuz-add-ppa-user.py? | 11:39 |
| noodles775 | (ie. it could be run multiple times). | 11:40 |
| jtv | noodles775: we have that option. But I think we'll get a lot of documentation benefit out of sticking with ppa-user for now. | 11:41 |
| noodles775 | Right. | 11:41 |
| noodles775 | Wow... automatic addition of my GPG key :) | 11:42 |
| jtv | yup | 11:42 |
| jtv | noodles775: It was hard, but I hope worth it. I just pushed the version that always includes amd64 support. | 11:44 |
| noodles775 | jtv: it seems to have added a third key, in addition to the two identified by my email? | 11:46 |
| jtv | noodles775: the bogus one is for signing the Code of Conduct. Please don't make me rework that to use the proper key (and prompt you for a passphrase) | 11:46 |
| noodles775 | jtv: ah, no worries :) | 11:47 |
| jtv | noodles775: but glad to hear that it picked up both keys for someone who had two. :-) | 11:47 |
| noodles775 | jtv: and none of them are found in zeca when clicking on the key id? | 11:47 |
| noodles775 | jtv: actually, if I modify the final url param to op=get it finds it. | 11:48 |
| jtv | noodles775: yup | 11:48 |
| jtv | that would've happened with a manual upload as well, app'ly | 11:48 |
| noodles775 | but not op=index.... ok, but it's there :) | 11:48 |
| noodles775 | jtv: Another thought, it'd only be an extra 1 line to create a default PPA for the user in create_ppa_user? (you could just use factory.makeArchive(owner=person)) | 11:51 |
| jtv | noodles775: I thought that'd be a nice next feature, but I think you just saved me the research. | 11:51 |
| noodles775 | jtv: great! | 11:51 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue [adeuring] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | noodles775: should I add virtualized=False? | 11:53 |
| noodles775 | jtv: yes, definitely. | 11:54 |
| jtv | noodles775: running tests... | 11:54 |
| * noodles775 tries uploading a package with the new setup. | 11:55 | |
| noodles775 | jtv: oh, and an extra line to add the external dependencies? | 11:57 |
| jtv | noodles775: here we go, feature creep! | 11:57 |
| noodles775 | lol | 11:58 |
| jtv | noodles775: is that something you can rattle off off the top of your head? Because if not, I'd prefer to leave it documented as a manual step. And bear in mind that there's the matter of distroseries choice to be considered. | 11:58 |
| gmb | james_w: I've seen the same error twice now running your sync-source branch: http://pastebin.ubuntu.com/386940/ | 11:59 |
| gmb | james_w: I'll run it again, but this may need some debugging. | 11:59 |
| james_w | gmb: I'm not sure I have any clue what's going on there | 12:00 |
| gmb | james_w: Well, look on the bright side, you're not alone. | 12:01 |
| james_w | :-) | 12:01 |
| jtv | noodles775: object lesson in feature creep... I have to merge devel to get the "virtualized" parameter. Just done that, but it introduces an import policy violation. Now you see why I'm hell-bent on restricting scope sometimes. | 12:02 |
| noodles775 | jtv: sure, in which case, just leave it without the PPA creation. I'd be happy to contribute to it later :) | 12:02 |
| james_w | gmb: you cwd seems to be processapportblobjob-api-bug-513191? Would that have any impact? | 12:02 |
| noodles775 | jtv: r=me | 12:02 |
| === matsubara-afk is now known as matsubara | ||
| jtv | noodles775: thanks... I'll see if I can resolve the import violation now though; I prefer that over multiple uncommits. :-) | 12:03 |
| gmb | james_w: It shouldn't; the error's occurring on the ec2 box. My cwd on my machine shouldn't have an impact on that because I tell EC2 which bzr branch to grab. | 12:03 |
| james_w | right | 12:03 |
| gmb | james_w: But it's a good idea. If it fails again I'll try branching and running fromthat branch. | 12:03 |
| james_w | is the paging chopping stuff out? | 12:04 |
| gmb | james_w: Not AFAICT. | 12:04 |
| james_w | it seems to be running tests, then stops in the middle of outputting a line | 12:04 |
| james_w | then appears to be running make clean | 12:04 |
| gmb | Hmm. Maybe that's bad copy-paste on my part. | 12:04 |
| gmb | FTR, your other branch is running fine. | 12:04 |
| james_w | good | 12:04 |
| noodles775 | jtv: ok, well in terms of the external dependencies, it should be as simple as person.archive.external_dependencies = ".." | 12:07 |
| noodles775 | jtv: just if you wanted to try it. | 12:07 |
| noodles775 | (assuming you're currently logged in as admin, that is). | 12:07 |
| jtv | noodles775: I don't know what that'll do in terms of taking people's testing choices away though. | 12:07 |
| noodles775 | jtv: up to you. I'd think of it as a sensible default that they can always edit if they like. | 12:18 |
| jtv | noodles775: true | 12:18 |
| * gmb grabs some lunch | 12:20 | |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue [adeuring] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === adiroiban changed the topic of #launchpad-reviews to: on call: gmb || reviewing: adiroiban || queue [adeuring,adiroiban(bug-525325)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| jtv | noodles775: you have an ancient lock on the UsingSoyuzLocally page | 12:50 |
| noodles775 | jtv: sorry, should be gone now. | 13:07 |
| jtv | so it is. | 13:08 |
| === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban, adeuring || queue [adiroiban(bug-525325)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | good morning gmb | 13:29 |
| === daniloff is now known as danilos | ||
| gmb | Hi bac | 13:29 |
| bac | busy today? | 13:29 |
| === mrevell is now known as mrevell-lunch | ||
| jtv | noodles775: all done... a few more paragraphs to scratch from the manual, er, manual. | 13:38 |
| gmb | bac: Not really; just thrashing through an 800-liner at the moment. | 13:43 |
| wgrant | jtv: Excellent. | 14:01 |
| jtv | wgrant: it's in EC2 now. Once it lands, I've got some wiki editing to do. :-) | 14:01 |
| wgrant | Very good. | 14:02 |
| jtv | but now, time to enjoy the night. See you tomorrow! | 14:04 |
| wgrant | See you. | 14:04 |
| gmb | adiroiban: Can you point me at a page on launchpad.dev where I can see the results of https://code.edge.launchpad.net/~adiroiban/launchpad/bug-359180-take-2/+merge/20122? | 14:21 |
| adiroiban | gmb: no. what results? | 14:22 |
| gmb | adiroiban: You've made JS changes; I'd like to see the effects of that in the UI. | 14:22 |
| adiroiban | gmb: hm... they are just keybindings | 14:23 |
| gmb | adiroiban: Yes, but I'd still like to actually try them out for myself. | 14:23 |
| gmb | adiroiban: It's an 802-line diff, so I'd like to see exactly what it's done. | 14:23 |
| gmb | Actually, that sounds excessive for "just keybindings" | 14:24 |
| adiroiban | gmb: sure :) | 14:24 |
| gmb | adiroiban: Is the diff on that mp sane? | 14:24 |
| adiroiban | gmb: yes. | 14:24 |
| gmb | Okay. | 14:24 |
| adiroiban | https://code.edge.launchpad.net/~adiroiban/launchpad/bug-359180/+merge/16422 | 14:25 |
| adiroiban | Here was the original MP with an extensive QA | 14:25 |
| adiroiban | the code from this MP was merged into edge...but since there were some problems on edge, it was removed prior to 10.01 release | 14:26 |
| adiroiban | gmb: so the page https://translations.launchpad.dev/ubuntu/hoary/+source/evolution/+pots/evolution-2.2/es/+translate?start=0 | 14:26 |
| gmb | adiroiban: Okay, so I'm confused now; is your new branch a resubmission of the old branch? | 14:26 |
| adiroiban | gmb: yes. for some of the code. | 14:27 |
| adiroiban | so the initial branch was landed on edge | 14:27 |
| adiroiban | and then we got some feedback | 14:27 |
| gmb | adiroiban: Okay. So, I don't think I need to re-review the old code. I just need to see the changes that you've made to that old code, correct? | 14:28 |
| adiroiban | we discovered some problems with the keybings, and since it was near the release jtv had removed the branch | 14:28 |
| adiroiban | from edge | 14:29 |
| adiroiban | gmb: I don't know what is the process for reviewing branches that were pulled out of edge | 14:31 |
| gmb | adiroiban: Can you paste a diff between the old branch and the new one into the merge proposal please? If the old branch was approved I don't need to re-approve it. I just need to approve the changes that you've made to it to fix the problems that caused it to be pulled in the first place. | 14:31 |
| adiroiban | gmb: the latest approved revision in this branch was 10168 | 14:35 |
| adiroiban | but diff -r 10168 is just to noisy | 14:36 |
| === salgado_ is now known as salgado | ||
| gmb | adiroiban: Okay, I'll work out a way to get a sane diff. | 14:39 |
| gmb | Thanks. | 14:39 |
| === mrevell-lunch is now known as mrevell | ||
| bac | hi abel | 14:43 |
| bac | er, adeuring | 14:43 |
| adeuring | hi bac | 14:43 |
| bac | adeuring: could you update your branch with devel and repush? | 14:43 |
| adeuring | bac: sure. is there again a merge conflict? | 14:44 |
| bac | adeuring: i've merged yours in and got a lot more changes than i expect... i'm a bit baffled. no conflicts. | 14:44 |
| adeuring | odd... let me see | 14:44 |
| adeuring | bac: i merged devel again; locally, the diff against devel looks exactly at the one here: https://code.edge.launchpad.net/~adeuring/launchpad/api-export-bug-linked-branches/+merge/20444 | 14:49 |
| bac | ok | 14:49 |
| abentley | gmb, bac: Could you please review https://code.edge.launchpad.net/~abentley/launchpad/no-original-to/+merge/20451 | 14:50 |
| bac | abentley: yes | 14:50 |
| abentley | bac, thanks. | 14:50 |
| bac | adeuring: found the problem. PEBCAK | 14:55 |
| adeuring | bac: ;) | 14:56 |
| bac | adeuring: when i do a 'make build' on your branch i get errors about the reference to IBugBranch. it works for you? | 15:00 |
| adeuring | bac: let me check... | 15:01 |
| bac | adeuring: it looks like bug.py is just missing an import | 15:12 |
| adeuring | bac: yeah. I am really suprised that I did not get errors running the page test... | 15:12 |
| bac | adeuring: i'm confused too. the page test errored for me | 15:13 |
| adeuring | interesting... | 15:13 |
| adeuring | bac: anyway, I've oushed a new version, containing the missing import statement | 15:14 |
| adeuring | erm, I've pushed... | 15:14 |
| leonardr | rockstar, can you give a quick review to https://code.edge.launchpad.net/~leonardr/lazr.restful/tag-web-service-request/+merge/20454 ? it's critical | 15:20 |
| bac | leonardr: rockstar is not available now. if it is critical you should ask one of the OCRs | 15:24 |
| leonardr | bac: sure. can i get you or gmb to look at it? | 15:25 |
| bac | leonardr: i'd be delighted. move yourself to the top of the queue | 15:25 |
| === leonardr changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban, adeuring || queue [leonardr, adiroiban(bug-525325)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| salgado | bac, gmb, hi there. I have a RC one, can I jump the queue? | 15:29 |
| salgado | it's a trivial one, btw | 15:29 |
| bac | salgado: yes, after leonard | 15:29 |
| salgado | cool, thanks bac | 15:30 |
| salgado | https://code.launchpad.net/~salgado/launchpad/bug-530738/+merge/20452 | 15:30 |
| bac | adeuring: did you test your changes from launchpadlib? if so, please paste a script that you used. | 15:30 |
| adeuring | bac: no. I did not... | 15:31 |
| === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban, leonard/adeuring || queue [adiroiban(bug-525325)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | adeuring: could you whip up something? | 15:31 |
| adeuring | bac: sure | 15:31 |
| === matsubara is now known as matsubara-lunch | ||
| === adiroiban changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban, leonard/adeuring || queue [adiroiban(bug-525325),adiroiban(bug-527728)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | leonardr: that branch looks fine. will you be updating lp to use it now? | 15:35 |
| leonardr | bac: yes, as part of https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-wadl | 15:35 |
| leonardr | which is not done yet--i have to fix more test failures | 15:36 |
| bac | leonardr: is that an RC candidate? | 15:36 |
| leonardr | bac: i don't know the exact terminology, but thumper gave my last revision of it a release-critical review | 15:36 |
| === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban, salgado/adeuring || queue [adiroiban(bug-525325),adiroiban(bug-527728), abentley] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | leonardr: ok | 15:37 |
| salgado | thanks for the review, bac. but the bug was introduced a week ago, when I changed the +login page to use OpenID. :) | 15:40 |
| bac | oh | 15:40 |
| bac | anyway, good catch | 15:41 |
| === salgado is now known as salgado-lunch | ||
| adeuring | bac: sorry, haven't run LP scripts locally since a longer time.. I'm getting a really odd error trying to access the local server: Error fetching XRDS document: <urlopen error (-5, 'No address associated with hostname') ... | 15:42 |
| bac | adeuring: i'm able to exercise the linked_branches property but unlinkBranch does not work | 15:44 |
| adeuring | bac: interesting... what is going wrong? | 15:44 |
| bac | adeuring: it returns a 'bad request' | 15:45 |
| adeuring | bac: can you show me your script? | 15:46 |
| bac | adeuring: i'm just poking at it interactively | 15:47 |
| adeuring | bac: just a hint: there is an oddity with linkes_branches vs. linkBranch() and unlinkBranch(): linked_branches does not return branches themselves, but IBugBranch objects, while (un)linkBranch() expect a branch | 15:49 |
| adeuring | bac: thanks for the review! | 15:59 |
| bac | np | 15:59 |
| bac | abentley: is your branch an RC candidate? | 15:59 |
| abentley | bac, yes. | 15:59 |
| === bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: adiroiban, abentley || queue [adiroiban(bug-525325),adiroiban(bug-527728)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| bac | abentley: glad i asked. i'll start on it now. | 16:00 |
| bac | abentley: r=bac. good luck getting your RC | 16:05 |
| abentley | bac, considering thumper asked for it, I doubt that | 16:06 |
| abentley | will be hard. | 16:06 |
| bac | :) | 16:06 |
| === gmb changed the topic of #launchpad-reviews to: on call: bac || reviewing: adiroiban, abentley || queue [adiroiban(bug-525325),adiroiban(bug-527728)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: adiroiban, adiroiban(bug-525325) || queue [adiroiban(bug-527728)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: adiroiban, adiroiban(bug-527728) || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === danilos is now known as daniloff | ||
| === salgado-lunch is now known as salgado | ||
| === fjlacoste is now known as flacoste_lunch | ||
| leonardr | gary: while i hunt down the launchpadlib problem, maybe you can look at https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-wadl/+merge/20405 ? | 17:03 |
| gary_poster | leonardr: on it. | 17:03 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| gary_poster | leonardr: can we get rid of fix_url in that test in the future? Either it is already planned, or you have an idea? | 17:08 |
| leonardr | gary: ideally we would be able to take a browser-based website request and turn it into a web service client web service request | 17:11 |
| leonardr | the way we can turn a browser-based website request into a browser-based web service request | 17:11 |
| gary_poster | leonardr: is it reasonable to ask you to put in a bug for this and reference it, or is this going to be so annoying that it is unlikely to happen? | 17:12 |
| leonardr | gary: well, it'll happen whenever someone tries to get the url of an object and use it in a web service request | 17:13 |
| leonardr | i don't know how likely that is, it only happens once now | 17:13 |
| gary_poster | ...leonardr, would that greatly simplify our JS usage of the webservice? | 17:13 |
| leonardr | gary: no, because all js usage is already handled. browser-based website request -> browser-based web service request | 17:14 |
| gary_poster | leonardr: OK. Anyway, I don't want to get in your way. I'm fine with this branch in the short term. If it is reasonable to say that we can get rid of fix_url, I'd prefer a bug for that, but if not, just tell me, move on, and I approve. | 17:15 |
| leonardr | gary: i think one way or another we can get rid of fix_url | 17:15 |
| leonardr | but probably by making the test do something more sensible | 17:16 |
| leonardr | not by making it easier to do what the test does | 17:16 |
| gary_poster | leonardr: ok. | 17:16 |
| leonardr | gary, i think the launchpadlib failure may have been introduced by another branch that landed recently, or by me not having an up-to-date launchpad | 17:19 |
| leonardr | DiscoveryFailure: Error fetching XRDS document: <urlopen error (110, 'Connection timed out') | 17:20 |
| leonardr | does that look like something that might be caused by the auth split? | 17:20 |
| gary_poster | leonardr: it looks pretty generic. I don't think the auth split has done anything pertinent in the last few hours. salgado, am I right? | 17:21 |
| leonardr | i'm updating everything now. i'll try again and if it still doesn't work i'll just put this into ec2test, because i'm pretty sure it's not my error | 17:22 |
| salgado | leonardr, grep testopenid /etc/hosts | 17:22 |
| leonardr | salgado: nothing | 17:22 |
| leonardr | do i need to add something? | 17:23 |
| salgado | leonardr, either add testopenid.dev to the 127.0.0.88 line or run rocketfuel-setup | 17:23 |
| leonardr | salgado: thanks much | 17:26 |
| leonardr | gary: launchpadlib error has gone away | 17:27 |
| leonardr | i'm going to try once more without the new lazr.restful (which shouldn't be necessray) and then start ec2 | 17:28 |
| gary_poster | yay, leonardr! | 17:28 |
| leonardr | gary: ok, starting ec2 | 17:35 |
| leonardr | i'm very confident it will work because i haven't changed launchpad since the time the two tests failed | 17:36 |
| leonardr | i've just fixed the two tests | 17:36 |
| gary_poster | makes sense to me. | 17:37 |
| leonardr | i'm also doing a test of launchpadlib against a running launchpad.dev to make sure the whole thin works | 17:37 |
| gary_poster | have some lunch. :-) | 17:37 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: adiroiban(bug-527728) || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| leonardr | gary: live launchpadlib test works fine | 17:53 |
| gary_poster | great, leonardr. | 17:53 |
| === deryck is now known as deryck[lunch] | ||
| bac | hi adiroiban | 18:12 |
| adiroiban | bac: hi | 18:12 |
| bac | adiroiban: i'm reviewing your branch for bug 527728. did you happen to test getting component_name from lplib? i'm trying and cannot get it to work. | 18:13 |
| mup | Bug #527728: Export source package component in API <api> <Launchpad Registry:In Progress by adiroiban> <https://launchpad.net/bugs/527728> | 18:13 |
| adiroiban | bac: no. I was just testing from a webbrowser | 18:13 |
| === flacoste_lunch is now known as flacoste | ||
| bac | adiroiban: here is what i'm seeing: http://paste.ubuntu.com/387146/ | 18:14 |
| bac | adiroiban: it's always a good idea to test new changes to the API interactively with launchpadlib to ensure the WADL got generated properly, etc. (in fact reviewers are supposed to ensure it has been done.) | 18:15 |
| adiroiban | bac: but bin/test -t source-package.txt is OK? | 18:15 |
| bac | adiroiban: yes | 18:15 |
| adiroiban | bac: have you tried deleting the old wsdl file ? | 18:16 |
| bac | not yet | 18:16 |
| bac | ah, perhaps it is cached | 18:16 |
| adiroiban | not sure, but I know the makefile does not build it properly | 18:17 |
| adiroiban | so during devel I have to delete it manualy | 18:17 |
| adiroiban | and then it is regenerated | 18:17 |
| === gary_poster is now known as gary-lunch | ||
| bac | adiroiban: i've removed my cache and am trying again | 18:18 |
| adiroiban | bac: do I need the latest build from launchpadlib, or it is ok to test with karmic version? | 18:20 |
| bac | karmic is fine | 18:20 |
| bac | adiroiban: or you can use the one packaged with lp by using 'make iharness' | 18:20 |
| adiroiban | and how can I tell it to use the lp.dev | 18:20 |
| bac | login_with('somename', 'dev') | 18:21 |
| adiroiban | bac: sorry. the name is latest_published_component_name | 18:22 |
| adiroiban | so instead of sp.component_name use sp.latest_published_component_name | 18:22 |
| bac | adiroiban: no, it isn't. you have no "exported_as" clause | 18:23 |
| bac | it now works that i got rid of my cache | 18:23 |
| bac | In [7]: ev.component_name | 18:23 |
| bac | Out[7]: 'main' | 18:23 |
| adiroiban | bac: hm... then something is fishy | 18:24 |
| bac | adiroiban: did you not push the latest version | 18:25 |
| adiroiban | on https://launchpad.dev/+apidoc/index.html#source_package I can see the key exported as latest_published_component_name | 18:25 |
| bac | https://code.edge.launchpad.net/~adiroiban/launchpad/bug-527728/+merge/20456 | 18:25 |
| bac | the diff at line 8 shows you didn't set an 'exported_as' | 18:25 |
| bac | also, your test fails b/c the component output is in the wrong place | 18:25 |
| adiroiban | I have pushed the code. The latest revision should be 10428 | 18:26 |
| adiroiban | bac: on my local branch the lib/lp/registry/tests/../stories/webservice/xx-source-package.txt has 0 failures | 18:29 |
| bac | adiroiban: ok, i just grabbed your new version. it does not match what is in the MP or what i grabbed an hour ago | 18:32 |
| bac | adiroiban: but that's fine -- it explains the mystery | 18:32 |
| adiroiban | bac: sorry for this mess! | 18:33 |
| bac | np. glad it is figured out | 18:33 |
| bac | yay, your tests pass now | 18:33 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: <your name here> || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
| === Edwin-lunch is now known as EdwinGrubbs | ||
| === deryck[lunch] is now known as deryck | ||
| === gary-lunch is now known as gary_poster | ||
| abentley | bac, could you please review https://code.launchpad.net/~abentley/launchpad/branch-scanner-zcml/+merge/20471 ? | 19:44 |
| bac | abentley: RC? | 19:49 |
| abentley | bac, no. | 19:49 |
| bac | abentley: ok, i'll get right on it anyway. just wondered. | 19:50 |
| leonardr | gary, do i need thumper or someone to approve the changes to https://code.edge.launchpad.net/~leonardr/launchpad/multiversion-wadl/+merge/20405 for release-critical? | 20:02 |
| gary_poster | leonardr: I don't think so. He's approved it twice. :-) He wants it fixed. | 20:03 |
| leonardr | ok, cool | 20:03 |
| thumper | leonardr: yes I do | 20:11 |
| thumper | leonardr: want it fixed that is | 20:12 |
| === matsubara is now known as matsubara-afk | ||
| === salgado is now known as salgado-afk | ||
| bac | hi rockstar | 21:15 |
| rockstar | bac, hi | 21:24 |
| bac | hey rockstar, i notice your JS reorg branch has been languishing/rotting for a long time. any reason you haven't gotten it reviewed? do you want me to review it? | 21:25 |
| bac | is it still current? | 21:25 |
| rockstar | bac, which one? | 21:25 |
| bac | https://code.edge.launchpad.net/~rockstar/launchpad/code-js-reorg/+merge/20170 | 21:26 |
| rockstar | code-js-reorg ? | 21:26 |
| rockstar | bac, yes, I have a topic for the reviewers meeting tomorrow that is blocking it. | 21:26 |
| rockstar | bac, I'm several pipes from there right now. | 21:26 |
| bac | so, by "yes" you mean "no, don't review it"? | 21:26 |
| bac | rockstar: please add your topic to the ReviewersMeetingAgenda | 21:27 |
| rockstar | bac, yes, that's what I mean. I'll get it reviewed as soon as we have a consensus with the rest of the reviewers team (the UI Swat team is already okay with it) | 21:27 |
| bac | rockstar: if it is contentious or interesting would you present it at the AMEU meeting? | 21:27 |
| bac | else you'll have to wait another week | 21:28 |
| rockstar | bac, I plan on presenting it at the AMEU meeting. | 21:28 |
| bac | excellent | 21:28 |
| rockstar | (which means I'll miss my bike ride in the morning) | 21:28 |
| bac | boo | 21:28 |
| rockstar | bac, you're assuming that I'm not sore from yesterday's ride. :) | 21:28 |
| bac | what is your temperature cut-off for riding? | 21:29 |
| bac | isn't it still crazy cold there? | 21:29 |
| rockstar | bac, it's actually really nice here right now, ~50 degrees or so. | 21:30 |
| bac | much nicer than us... | 21:30 |
| rockstar | The lowest I've ridden was -18F. I have good warm riding clothes though. | 21:30 |
| rockstar | The last few weeks it's been nice during the week and then snows all weekend. | 21:30 |
| bac | rockstar: i changed the status of that branch to WIP to avoid confusion | 21:32 |
| bac | er, MP not branch | 21:33 |
| rockstar | bac, okay, whatever works best for reviewers is good with me. | 21:35 |
| === bac changed the topic of #launchpad-reviews to: on call: - || reviewing: <your name here> || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!