=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== jtv1 is now known as jtv
=== noodles785 is now known as noodles775
[09:51] <gmb> adeuring: Do you have time to review my fix for bug 509195? Hoping to get it in the re-roll or CP'd today.
[09:51] <mup> Bug #509195: Add a task to garbo-hourly to update out-of-date bug heat scores <story-bug-heat> <Launchpad Bugs:In Progress by gmb> <https://launchpad.net/bugs/509195>
[09:51] <adeuring> gmb: sure. Fancy in exchange another review? https://code.edge.launchpad.net/~adeuring/launchpad/bug-532078/+merge/20727
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: gmb || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[09:52] <gmb> adeuring: Certainly. Let me just get a merge proposal for you...
[09:54] <gmb> adeuring: Actually, damn, I've just realised I've made an error. Give me 10 minutes and I'll fix it up.
[09:55] <adeuring> gmb: no problem ;)
[10:11] <gmb> adeuring: Finally, done: https://code.edge.launchpad.net/~gmb/launchpad/heat-garbo-hourly-bug-509195/+merge/20729
[10:11] <gmb> adeuring: I'll look at yours now.
[10:11] <adeuring> gmb: thanks!
=== daniloff is now known as danilos
[10:14] <gmb> adeuring: r=me; nice branch.
[10:15] <adeuring> gmb: thanks!
=== bigjools changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: gmb || queue [bigjools] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[10:21] <bigjools> adeuring: simple one for you from me, it just changes some logging in the buildd-manager
[10:21] <bigjools> TIA :)
[10:21] <adeuring> bigjools: sure, after I finished the review for gmb
[10:49] <adeuring> gmb: r=me
[10:49] <gmb> adeuring: Thanks.
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: bigjools || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== al-maisan is now known as al-maisan-lunch
=== al-maisan-lunch is now known as al-maisan
[11:14] <adeuring> bigjools: r=me
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[11:14] <bigjools> adeuring: thank you
=== matsubara-afk is now known as matsubara
=== mrevell is now known as mrevell-lunch
=== henninge is now known as heninnge-lunch
=== heninnge-lunch is now known as heninnge
=== mrevell-lunch is now known as mrevell
[13:29] <danilos> adiroiban, second iteration of the review sent out, only two minor issues remaining: one is to export direction as 'text_direction', another is to provide a negative test (test that hidden languages are not shown in the default listing)
[13:30] <adiroiban> danilos: correct :) I will do that now
=== salgado changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:02] <jtv> adeuring, salgado: got a fresh one for you — https://code.launchpad.net/~jtv/launchpad/bug-532354/+merge/20749
[14:03] <adeuring> jtv: I'll look
[14:03] <jtv> thanks
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: jtv, - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[14:15] <adeuring> jtv: I assume I should use a dif against between r10428 and 10433 of your branch?
[14:15] <jtv> adeuring: maybe something went wrong with the prerequisite branch... hang on
[14:17] <jtv> adeuring: oh, you're not working from the diff in the mp?  Then yes, that's right
[14:17] <adeuring> jtv: The diff in the MP is ca 100 lines longer than "bzr diff -r 10428 "
[14:21] <jtv> adeuring: looks as if the prerequisite branch is included in the mp, yes
[14:22] <jtv> so the manual diff you're doing is the right one.
[14:22] <adeuring> jtv: OK, so we learned that specifying a prerequisitebranch does not remove changes from that branch from the MP's diff ;)
[14:22] <jtv> Maybe it's because I merged the prereq instead of branching from it.
[14:22] <jtv> It has worked for me in the past.
=== jamalta-afk is now known as jamalta
[14:28] <adeuring> jtv: parse_fingerprints() expects untranslated gpg output: the string "Key fingerprint". Is gpg invoked without the user's language settings? (I get "Schl.-Fingerabdruck" instead when I invoke gpg --fingerprint from a shell)
[14:29] <jtv> adeuring: gah, good point.  I of all people should know better.  I'll set LC_ALL to C, since I'm manipulating the environment anyway.
[14:30] <adeuring> jtv: thanks!
[14:30] <jtv> Thanks for pointing that out.
[14:31] <jtv> Fixed.
[15:03] <adeuring> jtv: r=me
[15:04] <jtv> adeuring: thanks again!
[15:04] <adeuring> jtv: welcome (and sorry for the long time the review -- had a standup call...)
[15:04] <jtv> understandable.  :)
=== salgado is now known as salgado-lunch
=== adiroiban changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: jtv, - || queue [adiroiban(bug-531261)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: -, - || queue [adiroiban(bug-531261)] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-lunch
[16:07] <bigjools> adeuring: hi, are you still reviewing?
[16:08] <adeuring> bigjools: i can do a review, if you need one
[16:09] <bigjools> adeuring: you've dropped off the internal server, can you get on?  this is a security fix :)
[16:18] <adeuring> bugjsorry, had a skype call... I think I'm connected to the canonical irc server
[16:18] <adeuring> bigjools: i think I'm coeencted to the canonical irc server
[16:19] <bigjools> adeuring: my client says you're not
[16:19] <adeuring> odd... I saw messages on the bug team's cahhnel a few minutes ago
[16:20] <bigjools> adeuring: ok my client is having a spazz
=== deryck is now known as deryck[lunch]
=== matsubara-lunch is now known as matsubara
=== salgado-lunch is now known as salgado
=== salgado changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: -, adiroiban || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== adeuring changed the topic of #launchpad-reviews to: on call: salgado || reviewing: adiroiban || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== danilos is now known as daniloff
=== salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[17:37] <jtv> salgado: got time for another one?
[17:37] <salgado> jtv, sure
[17:37] <jtv> https://code.edge.launchpad.net/~jtv/launchpad/bug-286237/+merge/20767
[17:37] <jtv> obrigado
=== deryck[lunch] is now known as deryck
=== salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: jtv || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[19:06] <rockstar> Who wants to review a fix for critical bug (and potential cherry pick)?
[19:06] <rockstar> salgado, can I hop on your queue?
[19:06] <salgado> rockstar, sure
=== rockstar changed the topic of #launchpad-reviews to: on call: salgado || reviewing: jtv || queue [rockstar] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[19:07] <rockstar> salgado, https://code.edge.launchpad.net/~rockstar/launchpad/bug-532290/+merge/20772
=== gary_poster is now known as gary-lunch
=== salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: rockstar || queue [gary] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[19:31] <leonardr> salgado, can i add https://code.edge.launchpad.net/~leonardr/launchpad/no-mutator-named-operations/+merge/20777 to the queue?
[19:31] <leonardr> i'm on chr so i may be slow to respond
[19:31] <salgado> leonardr, how big is it?
[19:31]  * salgado checks
[19:32] <leonardr> salgado, not too big
[19:32] <salgado> leonardr, ok, add it to the queue.  there are 2 others in front of you, but I should be able to get to yours
[19:33] <leonardr> salgado: no big deal if you don't
=== leonardr changed the topic of #launchpad-reviews to: on call: salgado || reviewing: rockstar || queue [gary,leonardr] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[19:36] <salgado> 1	=== modified file '.bzrignore'
[19:36] <salgado> 2	--- .bzrignore	2010-02-23 21:48:53 +0000
[19:36] <salgado> 3	+++ .bzrignore	2010-03-05 19:04:24 +0000
[19:36] <salgado> 4	@@ -60,3 +60,7 @@
[19:36] <salgado> 5	 .testrepository
[19:36] <salgado> 6	 .memcache.pid
[19:36] <salgado> 7	 ./pipes
[19:36] <salgado> 8	+tags.new
[19:36] <salgado> 9	+lib/canonical/launchpad/apidoc/wadl-development-1.0.xml
[19:36] <salgado> 10	+lib/canonical/launchpad/apidoc/wadl-development-beta.xml
[19:36] <salgado> 11	+lib/canonical/launchpad/apidoc/wadl-development-devel.xml
[19:36] <salgado> rockstar, did you add those?
[19:38] <salgado> 62	+        #import pdb; pdb.set_trace()
[19:38] <salgado> and that?
[19:39] <leonardr> rockstar, i've got a better way of fixing the .bzrignore in my branch
[19:40] <rockstar> salgado, oops.  I'll pull the pdb.
[19:40] <rockstar> leonardr, if you're fixing that, great.  I'll revert it.
[19:40] <rockstar> salgado, the tags.new probably should stay.
[19:40] <leonardr> rockstar: i'm not doing anything with tags.new though
[19:41] <salgado> rockstar, ok, what is tags.new?
[19:41] <rockstar> salgado, it's created from make tags.
[19:42] <salgado> ok, so just drop the pdb and revert the other changes to .bzrignore
[19:42] <rockstar> salgado, done.
=== salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: leonardr || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
=== jamalta is now known as jamalta-afk
[20:14] <salgado> leonardr, the diff there includes the changes from my remove-change-password-page branch
[20:14] <leonardr> salgado: hmm, maybe it's diffing against hte wrong branch
[20:14] <salgado> yeah, it's diffing against db-devel
[20:16] <leonardr> salgado, i originally branched off db-devel because that was the branch with my changes
[20:17] <leonardr> i'll give you a diff vs devel
[20:17] <salgado> leonardr, I guess you had a db-devel branch and then merged trunk after I landed my changes
[20:17] <salgado> leonardr, no need to worry about that
[20:17] <leonardr> salgado, ok
=== jamalta-afk is now known as jamalta
[20:43]  * salgado closes the review shop
=== salgado changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com/ || https://code.edge.launchpad.net/launchpad/+activereviews
[20:43] <jtv> salgado: and thanks!
[20:44] <salgado> jtv, you're welcome. :)
[20:44] <jtv> good night :)
=== gary-lunch is now known as gary_poster
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
[21:24] <EdwinGrubbs> rockstar: can you review a tiny branch for me? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-524492-spriteutil-make-dependency/+merge/20784
[21:25] <rockstar> EdwinGrubbs, done
[21:25] <EdwinGrubbs> thanks
=== jamalta is now known as jamalta-afk